Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi wrote: > Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from GetModuleHan

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

On Tue, 25 Jan 2022 10:29:48 GMT, Thomas Stuefe wrote: > I'm curious, under what circumstances would, before > https://bugs.openjdk.java.net/browse/JDK-8237750, we ever hit the LoadLibrary > in imageDecompressor.cpp? Did this ever work? Was there ever a scenario where > the JVM was not

Re: RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

On Tue, 25 Jan 2022 01:59:56 GMT, David Holmes wrote: > * The jimage code was using the OS code (dlopen/loadlibrary etc) to try and > load the zip library when needed. Yes. The zip library has to be in PATH. > * The VM, which is always loaded first, always used to load the zip library >

RFR: 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call

Please review, When jlink with --compress=2, zip is used to compress the files while doing copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. This failure is after we get NULL from GetModuleHandle("zip.dll"), then do LoadLibrary("zip.dll") will have same result.

Integrated: 8268821: Split systemDictionaryShared.cpp

On Wed, 23 Jun 2021 06:08:41 GMT, Yumin Qi wrote: > Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (Dump

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

On Mon, 28 Jun 2021 23:13:24 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'Shared' from class names and rename corresponding files > > This looks OK to me. > &g

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

On Fri, 25 Jun 2021 16:50:37 GMT, Calvin Cheung wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove 'Shared' from class names and rename corresponding files > > src/hotspot/share/cds/

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

ed lambda proxy related to > lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and > light. > > Tests: tier1,tier3,tier4 > > Thanks > Yumin Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v3]

ed lambda proxy related to > lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and > light. > > Tests: tier1,tier3,tier4 > > Thanks > Yumin Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Re

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v2]

On Wed, 23 Jun 2021 20:45:49 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved sha

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v2]

ed lambda proxy related to > lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and > light. > > Tests: tier1,tier3,tier4 > > Thanks > Yumin Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8268821: Split systemDictionaryShared.cpp

On Wed, 23 Jun 2021 06:08:41 GMT, Yumin Qi wrote: > Hi, Please review > systemDictionaryShared becomes fatter and fatter so it is time to split it > into functional files. Moved security and jar operation related code into > CDSProtectionDomain, and moved shared class info (Dump

Re: RFR: 8268821: Split systemDictionaryShared.cpp

On Wed, 23 Jun 2021 12:40:57 GMT, Erik Joelsson wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info

RFR: 8268821: Split systemDictionaryShared.cpp

Hi, Please review systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to sharedClassInfo.[ch]pp, also moved lambda proxy related

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

On Thu, 11 Mar 2021 18:46:21 GMT, Yumin Qi wrote: >> LGTM > > Thanks to @iklam @erikj79 @dcubed-ojdk ! > _Mailing list message from [Magnus Ihse > Bursie](mailto:magnus.ihse.bur...@oracle.com) on > [build-dev](mailto:build-dev@openjdk.java.net):_ > > Hi Yumin, &g

Integrated: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi wrote: > Hi, Please review > > JDK-8236847 changes failed on build linux-aarch64 on xcross build. The > reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We > should check ENABLE_CDS instead. > > Than

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

On Thu, 11 Mar 2021 18:42:53 GMT, Ioi Lam wrote: >> Hi, Please review >> >> JDK-8236847 changes failed on build linux-aarch64 on xcross build. The >> reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We >> should check ENABLE_CDS instead. >> >> Thanks >> Yumin > >

RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Hi, Please review JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead. Thanks Yumin - Commit messages: - 8263465: JDK-8236847 causes tier1 build

Integrated: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages

On Fri, 19 Feb 2021 18:15:45 GMT, Yumin Qi wrote: > Hi, Please review > Usually most OSes are configured with page size of 4K, but some others are > configured with 64K. If jdk binary is built on 4K platform and run on > different configured platforms, CDS fails to be loaded d

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v7]

On Wed, 10 Mar 2021 18:33:53 GMT, Thomas Stuefe wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains seven commits: >> >> - Merge branch 'master' into jdk-8236847 >> - Merge master

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v8]

ease about 300K due to the change. >Tests: tier1-4 > Run MacOS/X64 binary on MacOS/aarch64 > >Thanks >Yumin Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Fix core region alignment for macosx-

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v7]

ease about 300K due to the change. >Tests: tier1-4 > Run MacOS/X64 binary on MacOS/aarch64 > >Thanks >Yumin Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v6]

On Tue, 9 Mar 2021 17:42:34 GMT, Magnus Ihse Bursie wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - Merge master >> - Add --enable-compatible-cds-alignmen

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v6]

On Thu, 4 Mar 2021 23:40:33 GMT, Ioi Lam wrote: > SharedArchiveConsistency.java I would like to do this in a separate PR. Look at the test, WhiteBox.getWhiteBox().metaspaceReserveAlignment(), I believe this should be _core_region_alignment too. Before this PR, they are all page size so no

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v5]

On Mon, 1 Mar 2021 13:51:39 GMT, Erik Joelsson wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add --enable-compatible-cds-alignment for linux-aarch64 and macosx-x64 in >> jib job &

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v6]

ease about 300K due to the change. >Tests: tier1-4 > Run MacOS/X64 binary on MacOS/aarch64 > >Thanks >Yumin Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v5]

ease about 300K due to the change. >Tests: tier1-4 > Run MacOS/X64 binary on MacOS/aarch64 > >Thanks >Yumin Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Add --enable-compatible-cds-alignm

Re: RFR: 8236847: CDS archive with 4K alignment unusable on machines with 64k pages [v4]

ease about 300K due to the change. >Tests: tier1-4 > Run MacOS/X64 binary on MacOS/aarch64 > >Thanks >Yumin Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Switch to enble compatible-cds-alignment a

Withdrawn: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region"

On Mon, 7 Dec 2020 05:01:27 GMT, Yumin Qi wrote: > Hi, Please review > Windows mapping for file into memory could not happen to reserved memory. > In mapping CDS archive we first reserve enough memory then before mapping, > release them. For cds archive and using class space

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v5]

On Tue, 8 Dec 2020 06:12:36 GMT, Yumin Qi wrote: >> Changes requested by iklam (Reviewer). > > Please check 03. 02 is generated when merge with most current and remote head > not updated correctly. After set remote head correct, 03 is regenerated and > is correct one

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v5]

ot do the 'real' split either. For Windows (and using > class space), the reserved space will be released anyway. > > Tests:tier1-5,tier7 Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 35 commits: - Added test case; Fixe

Re: RFR: 8255917: runtime/cds/SharedBaseAddress.java failed "assert(reserved_rgn != 0LL) failed: No reserved region" [v3]

ot do the 'real' split either. For Windows (and using > class space), the reserved space will be released anyway. > > Tests:tier1-5,tier7 Yumin Qi has updated the pull request incrementally with 32 additional commits since the last revision: - Add total_space_

Integrated: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

On Tue, 15 Sep 2020 18:57:55 GMT, Yumin Qi wrote: > This patch is reorganized after 8252725, which is separated from this patch > to refactor jlink glugin code. The previous > webrev with hg can be found at: > http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v16]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with three additional commits since the last revision: - Correct typo for check message - Removed try/catch from ja

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v12]

On Wed, 7 Oct 2020 17:53:30 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains >> 23 commits: >> - Added new separate function to CDS for logging species and modified the >

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v15]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Changed isValidInputLines to validateInputLines and throw IAE u

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v12]

On Wed, 7 Oct 2020 20:36:18 GMT, Mandy Chung wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains >> 23 commits: >> - Added new separate function to CDS for logging species and modified t

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v14]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Made isDumpingClassList a private final and add a public functio

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v13]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Move assert on klass is InstanceKlass after its NULL ch

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v11]

On Tue, 6 Oct 2020 18:12:50 GMT, Mandy Chung wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused imports. > > src/java.base/share/classes/jdk/internal/misc/CDS.java line 83:

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v12]

On Wed, 7 Oct 2020 17:48:41 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains >> 23 commits: >> - Added new separate function to CDS for logging species and modified the >

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v12]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits: - Added new separate function to

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v11]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Removed unused imports. - Changes: - all: https://

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v10]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Fixed comments with correct class and method name in CDS, removed

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v9]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Moved and renamed cdsGenerateHolderClasses from Gener

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v8]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Move the check work to java, restore code in VM. Modi

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v7]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Remove trailing word of line which is not used in h

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v3]

On Fri, 25 Sep 2020 21:45:13 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8247536: Support for pre-generated java.lang.invoke classes in CDS static >> archive > > t

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v6]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - In case of exception happens durin

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v5]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'master' of https://

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v4]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: 8247536: Support for pre-generated java.lang.invoke classe

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v3]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: 8247536: Support for pre-generated java.lang.invoke classe

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v2]

classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - 8247536: Support for pre-generated

Integrated: 8253500: [REDO] JDK-8253208 Move CDS related code to a separate class

On Wed, 23 Sep 2020 23:05:59 GMT, Yumin Qi wrote: > This patch is a REDO for JDK-8253208 which was backed out since it caused > runtime/cds/DeterministicDump.java failed, > see JDK-8253495. Since the failure is another issue and only triggered by > this patch, the test cas

RFR: 8253500: [REDO] JDK-8253208 Move CDS related code to a separate class

This patch is a REDO for JDK-8253208 which was backed out since it caused runtime/cds/DeterministicDump.java failed, see JDK-8253495. Since the failure is another issue and only triggered by this patch, the test case now is put on ProblemList.txt. The real root cause for the failure is detailed

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

On Wed, 16 Sep 2020 19:01:18 GMT, Ioi Lam wrote: >> This patch is reorganized after 8252725, which is separated from this patch >> to refactor jlink glugin code. The previous >> webrev with hg can be found at: >> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 >>

Integrated: 8253208: Move CDS related code to a separate class

On Fri, 18 Sep 2020 23:47:56 GMT, Yumin Qi wrote: > With more CDS related code added to VM, it is time to move CDS code to a > separate class. CDS is the new class which is > specific to CDS. > Tests: tier1-4 This pull request has now been integrated. Changeset: c1df13b8 Author:

Re: RFR: 8253208: Move CDS related code to a separate class [v3]

> With more CDS related code added to VM, it is time to move CDS code to a > separate class. CDS is the new class which is > specific to CDS. > Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: 8253208: Move

Re: RFR: 8253208: Move CDS related code to a separate class [v2]

On Sun, 20 Sep 2020 06:10:53 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8253208: Move CDS related code to a separate class > > src/java.base/share/native/libjava/CDS.

Re: RFR: 8253208: Move CDS related code to a separate class [v2]

> With more CDS related code added to VM, it is time to move CDS code to a > separate class. CDS is the new class which is > specific to CDS. > Tests: tier1-4 Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: 8253208: Move

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

S.java > 493 * Output to DumpLoadedClassList, format is simimar to LF_RESOLVE > > s/simimar/similar > > 494 * @see InvokerBytecodeGenerator > 495 * @param line the line to output. > > @see is typically placed after @param. > > Should it say @see java.lang.invoke.Gener

RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

HI, all   Please review changes for  8247536: Support for pre-generated java.lang.invoke classes in CDS static archive.   What happened:   I pushed with commit comment:     8247536: Support for pre-generated java.lang.invoke classes in CDS static archive   When created pullrequest, the

RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

This patch is reorganized after 8252725, which is separated from this patch to refactor jlink glugin code. The previous webrev with hg can be found at: http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 integrated, the regeneration of holder classes is simply to call the new

Re: RFR(XS): 8245070: 32-bit builds are broken after JDK-8242524

Magnus,  Thanks! I will push. Yumin On 5/16/20 12:35 AM, Magnus Ihse Bursie wrote: On 2020-05-16 00:57, Yumin Qi wrote: Hi, Erik   Thanks for test/review. On 5/15/20 1:48 PM, Erik Joelsson wrote: I tried a variant of this patch with a 32 bit intel build (server only to get the cds

Re: RFR(XS): 8245070: 32-bit builds are broken after JDK-8242524

clutter IMO. Otherwise  good. Just don't want to have not-useful variables defined. I will remove them. Thanks Yumin /Erik On 2020-05-15 11:29, Yumin Qi wrote: Magnus,   Thanks. Let's wait for the result of your patch.   I updated my webrev as your suggestion. Thanks Yumin On 5/15/20 11

Re: RFR(XS): 8245070: 32-bit builds are broken after JDK-8242524

Magnus,   Thanks. Let's wait for the result of your patch.   I updated my webrev as your suggestion. Thanks Yumin On 5/15/20 11:19 AM, Magnus Ihse Bursie wrote: On 2020-05-15 19:49, Yumin Qi wrote: Hi,   Please review the xsmall change for   bug: 8245070: https://bugs.openjdk.java.net

Re: RFR(XS): 8245070: 32-bit builds are broken after JDK-8242524

There is a copy/paste caused mismatch: On 5/15/20 10:49 AM, Yumin Qi wrote: Hi,   Please review the xsmall change for   bug: 8245070: https://bugs.openjdk.java.net/browse/JDK-8245070   webrev: http://cr.openjdk.java.net/~minqi/2020/8245070/webrev-00/   The change of 8245070 broke build for 32

RFR(XS): 8245070: 32-bit builds are broken after JDK-8242524

Hi,   Please review the xsmall change for   bug: 8245070: https://bugs.openjdk.java.net/browse/JDK-8245070   webrev: http://cr.openjdk.java.net/~minqi/2020/8245070/webrev-00/   The change of 8245070 broke build for 32 bits, since no compressed oops on 32 bits. Guard the change for 64 bits

Re: RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

Hi, Erik   Thanks for review! Yumin On 5/14/20 10:57 AM, Erik Joelsson wrote: Build changes look good. /Erik On 2020-05-14 10:40, Yumin Qi wrote: Hi,   Please review:   bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524   webrev: http://cr.openjdk.java.net/~minqi/2020/8242524

RFR(S): 8242524: Use different default CDS archives depending on UseCompressOops

Hi,   Please review:   bug: 8242524: https://bugs.openjdk.java.net/browse/JDK-8242524   webrev: http://cr.openjdk.java.net/~minqi/2020/8242524/webrev-00/ Summary:  After 8232069, CDS can create shared archive with -XX:-UseCompressedOops which also turned off by ZGC. The build with cds enabled

Re: Inquiry whether jdk8u can compile with icc？

The first error is known issue and fixed in jdk 9: https://bugs.openjdk.java.net/browse/JDK-8016451 For the second one, I am not familiar with icc/icpc, it looks the linker find a static version which is not an expected version. you need to check the detail of library dependency. Yumin On Mon,

Re: Inquiry whether jdk8u can compile with icc？

Hi, Vic You can try the help: sh configure --help Also export CC='your ICC' Yumin On Mon, Jun 25, 2018 at 8:20 AM Vic Wang(BJ-RD) wrote: > Hi, > >I get the openjdk-jdk8u-jdk8u source code, and I want to compile > jvm with ICC compiler. >How to configure jvm

Re: the Minimum set when install jdk8u

HI, Diaz I think you need build headless version (no X11 library etc). set *BUILD_HEADLESS true.* *Regards* *Yumin* On Thu, Oct 20, 2016 at 6:37 AM, Diaz Soho wrote: > Hi all, > > when I finish build openjdk, and try to install to a local directory, > I find the

Re: RFR (XXS) 8020622 - Visual Studio 2012 project creation for hotspot

Looks good to me. Thanks Yumin On 8/26/2013 6:17 PM, Ioi Lam wrote: Please review a very small fix: http://cr.openjdk.java.net/~iklam/8020622/vs2012_proj_001/ Bug: create.bat on Windows failed to create project file for Visual Studio 2012

Re: RFR (XS) 8023406 - [windows] build_vm_def.sh takes too long even when BUILD_WIN_SA != 1

Ioi, One question, SKIP_GENERATED, is this a environment variable or need to give on command? Others looks OK. Thanks Yumin On 8/20/2013 2:11 PM, Ioi Lam wrote: |Please review a very small fix:|| || ||http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_001/|| || ||Bug:

Re: RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

Filed: https://jbs.oracle.com/bugs/browse/JDK-8020622 Thanks Yumin On 7/16/2013 9:21 AM, Tim Bell wrote: Hi Yumin: Thanks for looking at this. The patch works fine when using build.bat to build hotspot on Windows, there is one issue with create.bat, which will fail to create project file