Thanks Magnus.
On 2019/1/23 下午8:39, Magnus Ihse Bursie wrote:
On 2019-01-16 06:56, Jie Fu wrote:
Hi Magnus,
Thanks a lot for your review and helpful comments.
The patch[1] had been tested with Apache NetBeans IDE 9.0 (Build
incubator-netbeans-release-334-on-20180708) on a Linux_64 (amd64)
On 2019-01-16 06:56, Jie Fu wrote:
Hi Magnus,
Thanks a lot for your review and helpful comments.
The patch[1] had been tested with Apache NetBeans IDE 9.0 (Build
incubator-netbeans-release-334-on-20180708) on a Linux_64 (amd64)
machine.
I've noticed that all files under the specified root
Hi Magnus,
Thanks a lot for your review and helpful comments.
The patch[1] had been tested with Apache NetBeans IDE 9.0 (Build
incubator-netbeans-release-334-on-20180708) on a Linux_64 (amd64) machine.
I've noticed that all files under the specified root will be scanned
automatically when the
On 2019-01-03 08:22, Fu Jie wrote:
Thanks Alan for your review and valuable advice.
I think it's worth keeping a NB project in the repo since it seems
more convenient for IDE developers.
And to keep configurations.xml current is also important.
I made a patch to fix the issue mentioned by Ala
Hi Alan,
With NetBeans, we can edit all the sources in the JDK just like using a vim.
But I don't think that is the main intent of the NB project.
For me, I found it more convenient to analyze the source code such as
finding the definition and usages of a method, showing the call graph in
a me
On 03/01/2019 07:22, Fu Jie wrote:
Thanks Alan for your review and valuable advice.
I think it's worth keeping a NB project in the repo since it seems
more convenient for IDE developers.
And to keep configurations.xml current is also important.
I made a patch to fix the issue mentioned by Ala
Thanks Alan for your review and valuable advice.
I think it's worth keeping a NB project in the repo since it seems more
convenient for IDE developers.
And to keep configurations.xml current is also important.
I made a patch to fix the issue mentioned by Alan.
Webrev: http://cr.openjdk.java.ne
On 28/12/2018 06:34, Fu Jie wrote:
Hi,
Please review this patch for a build failure with NetBeans:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215952
Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/
Summary
The build failure is caused by an incorrect setting of preBuildCommand
i
Thanks Magnus.
Best regards,
Jie
On 2018年12月30日 04:12, Magnus Ihse Bursie wrote:
It's difficult to really review such a patch, but I skimmed through it and it
looks reasonable. If it makes netbeans work for you, I'm ok with it.
/Magnus
28 dec. 2018 kl. 07:34 skrev Fu Jie :
Hi,
Please rev
It's difficult to really review such a patch, but I skimmed through it and it
looks reasonable. If it makes netbeans work for you, I'm ok with it.
/Magnus
> 28 dec. 2018 kl. 07:34 skrev Fu Jie :
>
> Hi,
>
> Please review this patch for a build failure with NetBeans:
>
> Bug: https://bugs.ope
Hi,
Please review this patch for a build failure with NetBeans:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215952
Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/
Summary
The build failure is caused by an incorrect setting of preBuildCommand
in make/nb_native/nbproject/configura
Hi,
I have filed a bug and posted the patch.
Bug: https://bugs.openjdk.java.net/browse/JDK-8215952
Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/
This is my first time to do this. If there is something wrong,
suggestion and correction are welcome:)
Cheers,
Ao Qi
On Fri, Dec 28, 2
Nice.
Many thanks to you David.
Best regards,
Jie
On 2018/12/28 上午11:47, David Holmes wrote:
On 28/12/2018 1:36 pm, Fu Jie wrote:
Hi David,
Thanks for your reply.
I had tried to send the patch as an attachment last night, but the
mailing lists reminded me that the size of my email with su
On 28/12/2018 1:36 pm, Fu Jie wrote:
Hi David,
Thanks for your reply.
I had tried to send the patch as an attachment last night, but the
mailing lists reminded me that the size of my email with such an
attachment was too big.
I'm very appreciative of your help. And I'd like to follow your a
Hi David,
Thanks for your reply.
I had tried to send the patch as an attachment last night, but the
mailing lists reminded me that the size of my email with such an
attachment was too big.
I'm very appreciative of your help. And I'd like to follow your advice
to submit the patch again later
Hi,
All patches to OpenJDK must be submitted on OpenJDK infrastructure. This
means either hosted on cr.openjdk.java.net or else included inline, or
as attachments, to emails to the OpenJDK mailing lists. Patches hosted
on github are not acceptable.
Thanks,
David
On 27/12/2018 10:56 pm, Fu J
Hi all,
OpenJDK build with NetBeans failed during the pre-build process.
The reason is that configuration in
make/nb_native/nbproject/configurations.xml is wrong.
The setting that leads to the failure is:
sh ../configure --with-debug-level=slowdebug
--disable-zip-debug-info
Two pion
17 matches
Mail list logo
