On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available
>> when both 8282948 and 8282700 were written. They can now be moved to using
>> the cleaner logic that UTIL_ARG_WITH grants.
>>
>> There are many more options
Hi Erik,
On Tue 15. 11. 2022 at 19:03, wrote:
> Hello Jaroslav,
>
> Jib is an Oracle internal tool used to manage builds and tests of
> OpenJDK at Oracle. There is no way for us to share that with external
> people unfortunately.
Ah, so it has nothing to do with the Google Jib …
A bit of unfor
On Sat, 12 Nov 2022 15:23:41 GMT, Christoph Langer wrote:
>> With this PR I'd like to make it easier to use dedicated installations of
>> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
>> globally via `xcode-select`.
>>
>> I propose adding a new configure flag `--
> With this PR I'd like to make it easier to use dedicated installations of
> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
> globally via `xcode-select`.
>
> I propose adding a new configure flag `--with-xcode-path` that takes the path
> to an Xcode installation.
On Tue, 15 Nov 2022 20:26:37 GMT, Alan Bateman wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
>> line 613:
>>
>>> 611: * @return the value of the scoped value if bound, otherwise
>>> {@code other}
>>> 612: */
>>> 613: public T orEls
On Tue, 15 Nov 2022 19:19:57 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/Scoped
On Tue, 15 Nov 2022 18:28:56 GMT, Maurizio Cimadamore
wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/Scoped
On Tue, 15 Nov 2022 17:36:16 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix failing serviceability tests
src/jdk.incubator.concurrent/share/classes/jdk/incubator/con
On Tue, 15 Nov 2022 17:36:16 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix failing serviceability tests
test/jdk/ProblemList.txt line 804:
> 802:
> 803: # Loom, f
On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available
>> when both 8282948 and 8282700 were written. They can now be moved to using
>> the cleaner logic that UTIL_ARG_WITH grants.
>>
>> There are many more options
Hello Jaroslav,
Jib is an Oracle internal tool used to manage builds and tests of
OpenJDK at Oracle. There is no way for us to share that with external
people unfortunately.
/Erik
On 11/15/22 08:28, Jaroslav Bachorík wrote:
Hello,
I apologize for possibly stupid question - but how can I us
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing serviceability tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Fix failing serviceability tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/442a04ef.
Hello,
I apologize for possibly stupid question - but how can I use the
'--with-jib' option?
In particular, where can I get the binaries I can point `--with-jib` to?
Thanks a bunch!
-JB-
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with one additional
commit since the last revision:
Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/10952/files/4bd44d66.
On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available
>> when both 8282948 and 8282700 were written. They can now be moved to using
>> the cleaner logic that UTIL_ARG_WITH grants.
>>
>> There are many more options
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
> have any practical purposes, IMHO. It also goes against ou
On Tue, 15 Nov 2022 14:25:15 GMT, Erik Joelsson wrote:
> Build change looks good.
Thanks, Erik. Actually, that change should have been reverted with the last
change. I'll revert that.
-
PR: https://git.openjdk.org/jdk/pull/11133
On Tue, 15 Nov 2022 14:15:26 GMT, Andrew Haley wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 318:
>>
>>> 316: }
>>> 317: }
>>> 318: @Hidden
>>
>> Can we rename this to runWith(Runnable, Object) in both Thread and
>> VirtualThread to keep the naming con
> JEP 429 implementation.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Update test
- Reviewer feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10952/files
- new: https://git.openjdk.org/jdk/pull/1095
On Tue, 15 Nov 2022 14:06:35 GMT, Erik Joelsson wrote:
> I think this looks good. I'm assuming you have manually tried the options and
> inspected the resulting spec.gmk thoroughly.
Yep, but for completion's sake I re-ran configure again for a fresh spec.gmk:
COPYRIGHT_YEAR:=2022
HOTSPOT_BUIL
On Tue, 15 Nov 2022 10:42:58 GMT, Stefan Karlsson wrote:
>> One of the more prevalent issues is that files in src/hotspot/share/include
>> are not properly sorted. There has been some discussion that that was done
>> on purpose, but it just adds another exception to the include rules that
>> d
> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would
> have `templateTable.cpp` excluded with cast-function-type warning. The
> underlying cause for it is casting functions for `ldc` bytecodes, which take
> `bool`-typed handlers:
Aleksey Shipilev has updated the pull req
On Tue, 15 Nov 2022 09:55:38 GMT, Ludvig Janiuk wrote:
> When jib tries to download itself behind a proxy, sometimes it can get a
> different file than it expected. This can result in cryptic errors that are
> hard to troubleshoot. Let's handle this a little more gracefully by detecting
> it i
On Mon, 14 Nov 2022 17:34:31 GMT, Alan Bateman wrote:
>> JEP 429 implementation.
>
> src/java.base/share/classes/java/lang/VirtualThread.java line 318:
>
>> 316: }
>> 317: }
>> 318: @Hidden
>
> Can we rename this to runWith(Runnable, Object) in both Thread and
> VirtualThread t
On Fri, 4 Nov 2022 23:17:32 GMT, Dean Long wrote:
>> JEP 429 implementation.
>
> src/hotspot/share/prims/jvm.cpp line 1410:
>
>> 1408: loc = 3;
>> 1409: } else if (method == resolver.thread_run_method) {
>> 1410: loc = 2;
>
> This depends on how javac numbers locals, right? It
On Fri, 4 Nov 2022 09:53:39 GMT, Andrew Haley wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 1610:
>>
>>> 1608: ensureMaterializedForStackWalk(bindings);
>>> 1609: task.run();
>>> 1610: Reference.reachabilityFence(bindings);
>>
>> This shoul
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java
line 475:
> 473: // ??? Do we want to search cache for this? In most cases we
> don't expect
> 474: // this {@lin
On Thu, 3 Nov 2022 11:50:17 GMT, ExE Boss wrote:
>> JEP 429 implementation.
>
> src/java.base/share/classes/java/lang/Thread.java line 1610:
>
>> 1608: ensureMaterializedForStackWalk(bindings);
>> 1609: task.run();
>> 1610: Reference.reachabilityFence(bindings
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/java.base/share/classes/java/lang/Thread.java line 1610:
> 1608: ensureMaterializedForStackWalk(bindings);
> 1609: task.run();
> 1610: Reference.reachabilityFence(bindings);
T
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/hotspot/share/prims/jvm.cpp line 4072:
> 4070: */
> 4071: JVM_ENTRY(void, JVM_EnsureMaterializedForStackWalk_func(JNIEnv* env,
> jobject vthread, jobject value))
> 4072: //asm("nop");
The asm("nop") was comm
On Thu, 10 Nov 2022 17:42:38 GMT, Andrew Haley wrote:
>> src/hotspot/share/prims/jvm.cpp line 1410:
>>
>>> 1408: loc = 3;
>>> 1409: } else if (method == resolver.thread_run_method) {
>>> 1410: loc = 2;
>>
>> This depends on how javac numbers locals, right? It seems a bit fragil
JEP 429 implementation.
-
Commit messages:
- Update StressStackOverflow
- Release _scopedValueCache after use
- Merge branch 'JDK-828' of https://github.com/theRealAph/jdk into
JDK-828
- Update src/java.base/share/classes/jdk/internal/vm/ScopedValueContainer.java
- Renam
On Wed, 2 Nov 2022 16:23:34 GMT, Andrew Haley wrote:
> JEP 429 implementation.
src/hotspot/share/prims/jvm.cpp line 1410:
> 1408: loc = 3;
> 1409: } else if (method == resolver.thread_run_method) {
> 1410: loc = 2;
This depends on how javac numbers locals, right? It seems a bi
On Mon, 14 Nov 2022 16:12:48 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features t
On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters wrote:
>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available
>> when both 8282948 and 8282700 were written. They can now be moved to using
>> the cleaner logic that UTIL_ARG_WITH grants.
>>
>> There are many more options
On Sat, 12 Nov 2022 15:23:41 GMT, Christoph Langer wrote:
>> With this PR I'd like to make it easier to use dedicated installations of
>> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
>> globally via `xcode-select`.
>>
>> I propose adding a new configure flag `--
On Mon, 14 Nov 2022 13:06:28 GMT, Kim Barrett wrote:
>> Yep, just something that C++ does a little neater, at least in my view
>
> We (the HotSpot Group) have not discussed or approved the use of the new C++
> attribute syntax, whether for standard attributes or compiler-specific ones.
> That
On Tue, 15 Nov 2022 06:12:52 GMT, Kim Barrett wrote:
>> Reverted to use the original, less intrusive solution from
>> [8274980](https://github.com/openjdk/jdk/pull/11081/commits/83ed3deb29d7344bbc95a3831f2388d077bc59e9)
>> that initially could not work with the older Visual C++ compiler (With a
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
> have any practical purposes, IMHO. It also goes against ou
When jib tries to download itself behind a proxy, sometimes it can get a
different file than it expected. This can result in cryptic errors that are
hard to troubleshoot. Let's handle this a little more gracefully by detecting
it in the bootstrapper and printing an error.
-
Commit
On Mon, 10 Oct 2022 15:08:43 GMT, Julian Waters wrote:
> Several parts of the make system in the JDK has large parts of cluttered if
> branches dedicated to setting flags for the specific compiler used in the
> build. This could be more neatly accomplished by instead adding more target
> combi
On Tue, 15 Nov 2022 07:05:33 GMT, Magnus Ihse Bursie wrote:
> > I know Skara, I'm deliberately holding off from integrating this for now...
>
> Why is that?
I was trying to see if I could find and rework every site that could use
touching up with this change in one fell swoop, but on second th
44 matches
Mail list logo
