RFR: 8300099: Configuration fails to auto-detect build user through $USER in dockers

2023-01-12 Thread Jie Fu
Hi all, Configuration is broken in dockers after JDK-8296478. This is because `$USER` is not defined in dockers [1]. The fix will check `whoami` if we get an empty `$USERNAME`. Thanks. Best regards, Jie [1] https://stackoverflow.com/questions/54411218/docker-why-isnt-user-environment-variable-

Integrated: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

2023-01-12 Thread Justin King
On Thu, 12 Jan 2023 18:30:12 GMT, Justin King wrote: > Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` > to ADLC. This pull request has now been integrated. Changeset: 19628e3e Author:Justin King Committer: Magnus Ihse Bursie URL: https://git.openjdk.

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 21:47:28 GMT, Maurizio Cimadamore wrote: > Ok - I thought false negative was the thing to absolutely avoid - and that > was the no. 1 concern. You're right. I think at the time I reasoned that it would be unusual enough for the type of an expression to start as an instanc

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 19:12:27 GMT, Archie L. Cobbs wrote: >> Uhm. Turns out I probably did not understand the filter correctly, and now >> I'm more dubious about what it actually does. Say you have this hierarchy: >> >> >> interface A { } >> class B { >> B() { >> A a = (A)this; >

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v8]

2023-01-12 Thread Archie L . Cobbs
> This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated for a constructor `A()` in a class `A` > when the compiler

Re: RFR: 8146132: Excessive output from make test-image [v2]

2023-01-12 Thread Magnus Ihse Bursie
On Thu, 12 Jan 2023 18:01:50 GMT, Coleen Phillimore wrote: >> This change makes native output files be only printed when building with >> LOG=info, to make the build not have so many pages of output. >> Tested with GHA and locally (tbd) > > Coleen Phillimore has updated the pull request incremen

Re: RFR: JDK-8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2023-01-12 Thread Aleksey Shipilev
On Thu, 12 Jan 2023 20:28:50 GMT, Justin King wrote: > The implementation of `offset_of` for GCC/Clang only deals with types are > aligned to 16 bytes or less, if they are more, such as `zCollectedHeap` the > behavior is undefined. UBSan also suggests that `offset_of` is not always a > compile

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 21:28:12 GMT, Archie L. Cobbs wrote: >> My point is about who puts ThisRef in the set to begin with. It seems to me >> that ThisRef is put there at the start of a method analysis. After which, >> there's several code points where we say "if there's a direct ThisRef in the >

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 19:01:10 GMT, Maurizio Cimadamore wrote: >> The code you quoted has nothing specifically to do with method invocations. >> This code is simply handing the evaluation of the expressions `this` and >> `super`. For example, `this` could just be a parameter we're passing to >>

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 19:24:50 GMT, Archie L. Cobbs wrote: >> This patch passes all tests: >> >> >> diff --git >> a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> >> b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> index 9

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 18:48:25 GMT, Maurizio Cimadamore wrote: >>> I guess what I'm thinking about: >> >> No leak is possible in that example. >> * `new Foo()` creates an instance of `Foo` (not a subclass of `Foo`) >> therefore `m()` is not overridden >> * Any subclass of `Foo` that may exist in

Re: RFR: 8146132: Excessive output from make test-image [v2]

2023-01-12 Thread Coleen Phillimore
On Wed, 11 Jan 2023 14:09:23 GMT, Erik Joelsson wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> This seems to do the right thing without summarizing the number of object >> files compiled for the tests. > > I

Re: RFR: JDK-8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2023-01-12 Thread Justin King
On Thu, 12 Jan 2023 20:28:50 GMT, Justin King wrote: > The implementation of `offset_of` for GCC/Clang only deals with types are > aligned to 16 bytes or less, if they are more, such as `zCollectedHeap` the > behavior is undefined. UBSan also suggests that `offset_of` is not always a > compile

RFR: JDK-8300080: offset_of for GCC/Clang exhibits undefined behavior and is not always a compile-time constant

2023-01-12 Thread Justin King
The implementation of `offset_of` for GCC/Clang only deals with types are aligned to 16 bytes or less, if they are more, such as `zCollectedHeap` the behavior is undefined. UBSan also suggests that `offset_of` is not always a compile time constant, as the stack trace came from the dynamic loader

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v8]

2023-01-12 Thread Matias Saavedra Silva
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to acquire previous val

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v7]

2023-01-12 Thread Matias Saavedra Silva
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to acquire previous val

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 18:40:38 GMT, Maurizio Cimadamore wrote: >> This patch: >> >> >> diff --git a/make/test/BuildMicrobenchmark.gmk >> b/make/test/BuildMicrobenchmark.gmk >> index 1c89328a388..7c3f0293edc 100644 >> --- a/make/test/BuildMicrobenchmark.gmk >> +++ b/make/test/BuildMicrobenchmark

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 17:40:36 GMT, Maurizio Cimadamore wrote: > But the filtering will end up dropping the expression Ref on the floor, > right? (because B and A are unrelated). Ah, I see what you mean. Here's a more complete example: public class CastLeak { public CastLeak() { (

Re: RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

2023-01-12 Thread Magnus Ihse Bursie
On Thu, 12 Jan 2023 18:30:12 GMT, Justin King wrote: > Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` > to ADLC. Marked as reviewed by ihse (Reviewer). Yeah. the ADLC build is still quite strange and do not conform to the rest of the build system. It's been that

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 17:33:48 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> line 875: >> >>> 873: // Reference to this? >>> 874: if (tree.name == names._this || tree.name == names._super) { >>> 875: i

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 17:29:22 GMT, Maurizio Cimadamore wrote: >> I put it there because of switch expressions and `yeild`... ? > > Well, yield can... yield a value - `case` doesn't. So I'm confused. Also > because the variable is called `referenceExpressionNode` and `CASE` is not an > expressio

Re: RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

2023-01-12 Thread Justin King
On Thu, 12 Jan 2023 18:56:38 GMT, Magnus Ihse Bursie wrote: >> Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and >> `UBSAN_LDFLAGS` to ADLC. > > make/autoconf/jdk-options.m4 line 480: > >> 478: LDFLAGS_JDKEXE="$LDFLAGS_JDKEXE $UBSAN_LDFLAGS" >> 479: ]) >> 480: if tes

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 18:37:06 GMT, Archie L. Cobbs wrote: >> I guess what I'm thinking about: >> >> class Foo { >> private Foo() { >> m(this); >> } >> >> public void m() { ... } // overridable >> >> static Foo makeFoo() { return new Foo(); } >> } > >> I guess wha

[jdk20] Integrated: 8299918: Update Xcode11.3.1-MacOSX10.15 devkit at Oracle

2023-01-12 Thread Mikael Vidstedt
On Wed, 11 Jan 2023 18:37:01 GMT, Mikael Vidstedt wrote: > This pull request contains a clean backport of commit > [a17b563f](https://github.com/openjdk/jdk/commit/a17b563f54b2e0953a1dd9a613e6d5e0e9a8e4cb) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being b

Re: RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

2023-01-12 Thread Justin King
On Thu, 12 Jan 2023 18:30:12 GMT, Justin King wrote: > Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` > to ADLC. @magicus After adding the strict build configuration preprocessor check to the UBSan default options source file, I apparently never attempt to build

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 18:18:38 GMT, Maurizio Cimadamore wrote: >> I can't seem to be able to run tests - I get failures in the build: >> >> >> * For target support_test_micro_tools-classes__the.BUILD_INDIFY_batch: > > This patch: > > > diff --git a/make/test/BuildMicrobenchmark.gmk > b/make/t

RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

2023-01-12 Thread Justin King
Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` to ADLC. - Commit messages: - UBSan CFLAGS/LDFLAGS not passed when building ADLC Changes: https://git.openjdk.org/jdk/pull/11975/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11975&range=00 Is

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 16:40:33 GMT, Maurizio Cimadamore wrote: > I guess what I'm thinking about: No leak is possible in that example. * `new Foo()` creates an instance of `Foo` (not a subclass of `Foo`) therefore `m()` is not overridden * Any subclass of `Foo` that may exist in the outside worl

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 18:11:01 GMT, Maurizio Cimadamore wrote: >> Same comment as previous: I don't quite know what I'm doing and I'm loathe >> to break what is already working. Do you have a suggested patch? > > I can't seem to be able to run tests - I get failures in the build: > > > * For ta

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 17:39:05 GMT, Vicente Romero wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarify how

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 12:28:12 GMT, Maurizio Cimadamore wrote: > This might also be related with the fact that we deal with return values in > different ways than with e.g. values returned from a nested scope (where we > just pop, and then copy all pending expression to the outer depth). Yes, a

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 17:48:37 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> line 909: >> >>> 907: >>> 908: // Check for implicit outer 'this' reference >>> 909: if (this.types.hasOuterClass(currentClassT

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 12:26:27 GMT, Maurizio Cimadamore wrote: > Do we really need a set for this? There are surely other ways to model things. But I got myself really confused trying to build more complicated models. What I ended up with is this simple model that works: * There is a set of `Re

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 12:17:32 GMT, Maurizio Cimadamore wrote: > There is a concept of push/popScope and then there's a separate concept of > call stack (which is just a list of diagnostic position up to the point). I > wonder if this could be better modeled by using a single class e.g. > Scope

Re: RFR: 8146132: Excessive output from make test-image [v2]

2023-01-12 Thread Coleen Phillimore
> This change makes native output files be only printed when building with > LOG=info, to make the build not have so many pages of output. > Tested with GHA and locally (tbd) Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: This

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 12:15:17 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Vicente Romero
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gene

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 17:13:55 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> line 411: >> >>> 409: final boolean referenceExpressionNode; >>> 410: switch (tree.getTag()) { >>> 411: case CASE: >> >> surpri

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 11:09:35 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 10:56:53 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 10:48:49 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 16:20:12 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> line 218: >> >>> 216: new TreeScanner() { >>> 217: >>> 218: private Lint lint = ThisEscapeAnalyzer.this.lint; >> >> On a first loo

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 10:32:19 GMT, Maurizio Cimadamore wrote: > If we have a class with a private constructor and public static factory > invoking said constructor, and the constructor makes this escape, isn't that > an issue we should detect? A static factory method will not create a subclass

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 10:25:27 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 10:18:27 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Integrated: JDK-8298448: UndefinedBehaviorSanitizer

2023-01-12 Thread Justin King
On Fri, 9 Dec 2022 06:53:31 GMT, Justin King wrote: > Allow building OpenJDK with UBSan. Currently the build fails when optimizing > the image due to lots of undefined behavior (it invokes the built JVM). > Follow up PRs will either replace the undefined behavior with well defined > behavior o

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 15:10:19 GMT, Maurizio Cimadamore wrote: > Interesting example - I thought you might have been referring to a case where > the class being analyzed was itself an exception. Yes - although that example doesn't compile (oops!). Just replace `catch (RuntimeException e)` with

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 13:01:44 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Use the more appropriate Type comparison method Types.isSameType(). >> - Add some more comments to clarif

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 14:59:12 GMT, Archie L. Cobbs wrote: >>> * On the Java stack >>> (a) The current 'this' instance >>> (b) A method parameter >>> (c) A local variable >>> (d) A temporary value that is part of the current expression being >>> evaluated >>> (e) The return value from a

Re: RFR: 8295884: Implement IDE support for Eclipse [v30]

2023-01-12 Thread Julian Waters
On Wed, 4 Jan 2023 13:06:37 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >> powerful

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v54]

2023-01-12 Thread Julian Waters
On Thu, 12 Jan 2023 14:39:08 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Integrated: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH

2023-01-12 Thread Julian Waters
On Mon, 7 Nov 2022 14:39:02 GMT, Julian Waters wrote: > 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-12 Thread Archie L . Cobbs
On Thu, 12 Jan 2023 09:57:00 GMT, Maurizio Cimadamore wrote: > I'm not sure what you mean by (1f). You mean this can be embedded in an > exception being thrown? Is that different from (2)? Yes, this would be a different case from any other that you'd have to handle in the code if you wanted t

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v53]

2023-01-12 Thread Julian Waters
On Wed, 28 Dec 2022 10:44:41 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v54]

2023-01-12 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v11]

2023-01-12 Thread Julian Waters
On Thu, 12 Jan 2023 14:28:54 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's temporary >> directory rather than inside the newly checked out repository containing all >> the JDK's source code, as doing so may interfere with the build process and >> c

Integrated: 8299330: Minor improvements in MSYS2 Workflow handling

2023-01-12 Thread Julian Waters
On Fri, 23 Dec 2022 17:53:05 GMT, Julian Waters wrote: > MSYS2 should be more appropriately installed into the runner's temporary > directory rather than inside the newly checked out repository containing all > the JDK's source code, as doing so may interfere with the build process and > cause

Re: RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v10]

2023-01-12 Thread Magnus Ihse Bursie
On Thu, 12 Jan 2023 14:01:57 GMT, Julian Waters wrote: > > Hi, I'm back today from vacation and is trying to catch up, so your timing > > was excellent. ;) > > Haha, Merry Christmas and a Happy New Year, hope you had a good time with > your family :) Actually, I spent most of the time isolate

Re: RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v11]

2023-01-12 Thread Magnus Ihse Bursie
On Thu, 12 Jan 2023 14:24:34 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's temporary >> directory rather than inside the newly checked out repository containing all >> the JDK's source code, as doing so may interfere with the build process and >> c

Re: RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v10]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's temporary >> directory rather than inside the newly checked out repository containing all >> the JDK's source code, as doing so may interfere with the build process and >> c

Re: RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v10]

2023-01-12 Thread Julian Waters
On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's temporary >> directory rather than inside the newly checked out repository containing all >> the JDK's source code, as doing so may interfere with the build process and >> c

Re: RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v11]

2023-01-12 Thread Julian Waters
> MSYS2 should be more appropriately installed into the runner's temporary > directory rather than inside the newly checked out repository containing all > the JDK's source code, as doing so may interfere with the build process and > cause weird corner cases in the submitted actions workflow. On

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v53]

2023-01-12 Thread Julian Waters
On Wed, 28 Dec 2022 10:44:41 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v53]

2023-01-12 Thread Julian Waters
On Thu, 12 Jan 2023 12:44:49 GMT, Magnus Ihse Bursie wrote: > I'm not sure I understand the relationship of the GHA fix in this PR wrt > #11782. Are both needed? Do 11782 supersede this fix? > > If both are needed, would it make sense to fold the GHA fix part of this PR > into 11782? Otherwise

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

2023-01-12 Thread Julian Waters
On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's tool cache >> rather than inside the newly checked out repository containing all the JDK's >> source code, as doing so may interfere with the build process and cause >> weir

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

2023-01-12 Thread Julian Waters
On Thu, 12 Jan 2023 12:26:16 GMT, Magnus Ihse Bursie wrote: > Hi, I'm back today from vacation and is trying to catch up, so your timing > was excellent. ;) Haha, Merry Christmas and a Happy New Year, hope you had a good time with your family :) > This looks good. I have seen your attempt at

Re: RFR: 8295884: Implement IDE support for Eclipse [v30]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 4 Jan 2023 13:06:37 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >> powerful

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gene

Re: RFR: 8295884: Implement IDE support for Eclipse [v30]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 4 Jan 2023 13:06:37 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >> powerful

Re: RFR: 8295884: Implement IDE support for Eclipse [v30]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 4 Jan 2023 13:06:37 GMT, Julian Waters wrote: >> Eclipse is a popular and very well-known IDE in the world of Java >> development, utilized widely in many contexts, by beginners and experienced >> teams alike. Although a relatively lightweight IDE, it features surprisingly >> powerful

Re: RFR: 8294982: Implementation of Classfile API [v7]

2023-01-12 Thread Magnus Ihse Bursie
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bu

Re: RFR: 8294982: Implementation of Classfile API [v7]

2023-01-12 Thread Magnus Ihse Bursie
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bu

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v53]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 28 Dec 2022 10:44:41 GMT, Julian Waters wrote: >> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available >> when both 8282948 and 8282700 were written. They can now be moved to using >> the cleaner logic that UTIL_ARG_WITH grants. >> >> There are many more options

Re: RFR: JDK-8298448: UndefinedBehaviorSanitizer [v10]

2023-01-12 Thread Magnus Ihse Bursie
On Sat, 17 Dec 2022 06:39:48 GMT, Justin King wrote: >> Allow building OpenJDK with UBSan. Currently the build fails when optimizing >> the image due to lots of undefined behavior (it invokes the built JVM). >> Follow up PRs will either replace the undefined behavior with well defined >> behav

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Maurizio Cimadamore
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gene

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's tool cache >> rather than inside the newly checked out repository containing all the JDK's >> source code, as doing so may interfere with the build process and cause >> weir

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's tool cache >> rather than inside the newly checked out repository containing all the JDK's >> source code, as doing so may interfere with the build process and cause >> weir

Re: RFR: 8299592: Fix and reenable warnings in java.desktop native code compilation

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel JeliƄski wrote: > Please review this patch that fixes and re-enables a few warnings in libawt > compilation. > > Verified that debug and release builds finish successfully on Win, Mac and > Linux. Also verified that client libs tests still pass. Build c

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]

2023-01-12 Thread Magnus Ihse Bursie
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gene

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v10]

2023-01-12 Thread Julian Waters
On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's tool cache >> rather than inside the newly checked out repository containing all the JDK's >> source code, as doing so may interfere with the build process and cause >> weir

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-12 Thread Maurizio Cimadamore
On Thu, 12 Jan 2023 02:14:10 GMT, Archie L. Cobbs wrote: >>> >>> D'oh, you're right. But if you made `returnMe()` static or private then the >>> argument would still hold. >>> >>> > And, if the method is static, same story - you are passing ref3 somewhere >>> > else, and ref3 potentially cont

Re: RFR: 8294982: Implementation of Classfile API [v7]

2023-01-12 Thread Adam Sotona
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote: >> **This pull request is not intended for immediate integration to JDK >> mainline.** >> >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolida