On Thu, 2 Mar 2023 22:35:17 GMT, David Holmes wrote:
> We can replace `gethostbyname`, which is deprecated on Windows and Linux,
> with `getaddrinfo`. This API is available on all supported platforms and so
> can be placed in shared code. @djelinski pointed out that `getaddrinfo` can
> resolve
On Fri, 3 Mar 2023 04:04:25 GMT, Kim Barrett wrote:
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
A few initial comments while I try to digest this.
I don't use these particular debugging mechanism, neither Debugger nor
BREAKPOINT, but it seems potentially prob
On Fri, 3 Mar 2023 04:04:25 GMT, Kim Barrett wrote:
> Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
make/hotspot/lib/CompileJvm.gmk line 103:
> 101: DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value
> 102:
> 103: DISABLED_WARNINGS_microsoft := 46
Also 8302799: Refactor Debugging variable usage for noreturn crash reporting
-
Commit messages:
- new implementation of Debugging
- noreturn attributes
Changes: https://git.openjdk.org/jdk/pull/12845/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12845&range=00
Issue: ht
On Fri, 3 Mar 2023 01:02:40 GMT, Vladimir Kozlov wrote:
> Hotspot changes are okay but I'm a bit confused about what the hotspot code
> will now be used for?
I'm not 100% positive if the current __kernel_rem_pio2 code would be in use.
IIRC, back when we used the fsin/fcos instructions to intri
On Fri, 3 Mar 2023 00:38:18 GMT, David Holmes wrote:
> Actually this is really my lack of understanding about the current code: why
> do we intrinsify `Math` but not `StrictMath`?
In brief, the Math methods are allowed implementation flexibility in terms of
their algorithm but the StrictMath m
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Fri, 3 Mar 2023 00:31:12 GMT, David Holmes wrote:
> Hotspot changes are okay but I'm a bit confused about what the hotspot code
> will now be used for?
`SharedRuntime::*` runtime math functions are used on platforms where there are
no HW instructions or intrinsics (Zero VM). JIT compiled co
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 22:35:17 GMT, David Holmes wrote:
> We can replace `gethostbyname`, which is deprecated on Windows and Linux,
> with `getaddrinfo`. This API is available on all supported platforms and so
> can be placed in shared code. @djelinski pointed out that `getaddrinfo` can
> resolve
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
We can replace `gethostbyname`, which is deprecated on Windows and Linux, with
`getaddrinfo`. This API is available on all supported platforms and so can be
placed in shared code. @djelinski pointed out that `getaddrinfo` can resolve
both IP addresses and host names so the two step approach used
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 15 Feb 2023 14:12:21 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java
>> line 63:
>>
>>> 61: * aload_0}).
>>> 62: */
>>> 63: sealed interface IntrinsicConstantInstruction extends
>>> ConstantInstruction
>>
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 19:19:20 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback and add description of transliteration process.
>
> src/java.base/share/classes/java/lang/St
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for JDK-83020
On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](https://bug
On Wed, 1 Mar 2023 13:06:35 GMT, Daniel Jeliński wrote:
> Please review this PR that upgrades winsock lib from version 1 (wsock32) to
> version 2 (ws2_32) and removes unnecessary libs from the build.
>
> With the winsock upgrade we should be able to avoid loading wsock32.dll at
> runtime. Wins
On Wed, 1 Mar 2023 19:50:56 GMT, Naoto Sato wrote:
> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
> locales with `common` locales
> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
> to have the same coverage level of locales, CLDRConve
On Thu, 2 Mar 2023 14:05:55 GMT, Erik Joelsson wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback and add description of transliteration process.
>
> make/autoconf/buildjdk-spec.gmk.in line 85:
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Thu, 2 Mar 2023 07:12:01 GMT, Alan Bateman wrote:
> This is a great milestone to get to! Does the comment at the top of
> sharedRuntimeTrig.cpp need updating?
Updated several of the comments in the HotSpot sources and added a description
of the transliteration process to StrictMath.
--
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales, CLDRC
On Thu, 2 Mar 2023 14:29:13 GMT, Adam Sotona wrote:
>> I had the same observation as Maurizio.
>
> I've extracted `StackMapFrameInfo` to the top level and moved
> `VerificationTypeInfo`, however it is still nested.
> Let me know if you think we should really avoid all nested or if info inside
>
On Wed, 1 Mar 2023 20:28:14 GMT, Mandy Chung wrote:
> `$JAVA_HOME/release` file currently includes `JAVA_VERSION` which is the
> version
> number plus the pre-release identifier for example "21-ea".The build
> number
> and additional build information are useful in identifying the inform
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales, CLDRC
> Eclipse is a popular and very well-known IDE in the world of Java
> development, utilized widely in many contexts, by beginners and experienced
> teams alike. Although a relatively lightweight IDE, it features surprisingly
> powerful indexing and code analysis capabilities, as well as useful t
On Wed, 1 Mar 2023 23:57:52 GMT, Paul Sandoz wrote:
>> Every case has been considered individually, evaluated on use cases and pros
>> and cons have been weighted. Unified approach across the whole API would be
>> nice, however not so simple and not the highest priority.
>
> I had the same obse
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Thu, 2 Mar 2023 05:54:52 GMT, Joe Darcy wrote:
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 an
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Wed, 1 Mar 2023 23:07:38 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl
>> - abstract implementations of RefEntry, RefsEntry and NamedE
On Wed, 1 Mar 2023 23:43:55 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl
>> - abstract implementations of RefEntry, RefsEntry and NamedE
Please review this superficial documentation cleanup that was triggered by
unrelated analysis of doc comments in JDK API.
The only effect that this multi-area PR has on the JDK API Documentation (i.e.
the observable effect on the generated HTML pages) can be summarized as follows:
diff -ur
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Wed, 1 Mar 2023 22:38:32 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl
>> - abstract implementations of RefEntry, RefsEntry and NamedE
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Wed, 1 Mar 2023 21:36:41 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - renamed all remaining ConcreteXyzEntry to XyzEntryImpl
>> - abstract implementations of RefEntry, RefsEntry and NamedE
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Wed, 1 Mar 2023 18:55:05 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert flag change in ResolverConfi
On Wed, 1 Mar 2023 10:12:41 GMT, Jan Lahoda wrote:
> The OpenJDK build is using a Plugin called Depend to avoid building Java code
> unnecessarily. It has two parts, one is checking module APIs (and forces
> rebuild of dependent modules if a dependency changes), and second takes
> modified fil
62 matches
Mail list logo
