On Thu, 20 Apr 2023 19:15:00 GMT, Mikael Vidstedt wrote:
> With the JDK 20 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 21.
>
> Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but
> then fails for unrelated reasons, and one seemingly
On Thu, 20 Apr 2023 19:15:00 GMT, Mikael Vidstedt wrote:
> With the JDK 20 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 21.
>
> Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but
> then fails for unrelated reasons, and one seemingly
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
> Note that `amd64` and
On Thu, 20 Apr 2023 19:15:00 GMT, Mikael Vidstedt wrote:
> With the JDK 20 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 21.
>
> Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but
> then fails for unrelated reasons, and one seemingly
On Thu, 20 Apr 2023 21:33:59 GMT, Chen Liang wrote:
> Do you know if fixpath will take unix-style path with spaces as input? If it
> should reject spaces, then we can run fixpath before quote and reject this
> quoted argument with space, which is known to be absent in unix paths.
I'm not
On Thu, 20 Apr 2023 19:15:00 GMT, Mikael Vidstedt wrote:
> With the JDK 20 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 21.
>
> Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but
> then fails for unrelated reasons, and one seemingly
On Thu, 20 Apr 2023 19:15:00 GMT, Mikael Vidstedt wrote:
> With the JDK 20 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 21.
>
> Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but
> then fails for unrelated reasons, and one seemingly
With the JDK 20 GA out it's time to bump the minimum boot JDK version for
mainline/JDK 21.
Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but
then fails for unrelated reasons, and one seemingly unrelated Vector API test
failure in tier 3)
-
Commit
On Fri, 21 Apr 2023 12:21:39 GMT, Christoph Langer wrote:
>> We figured that seemingly the correct toolchain could be (and is) already
>> installed by default on Github runners and it makes sense to skip the
>> expensive installation operation which takes some 10+ minutes.
>>
>> I also tested
On Tue, 11 Apr 2023 18:17:06 GMT, Leonid Mesnik wrote:
> The plugin which support execution of test's main method in separate virtual
> thread is added.
> The plugin is built as a part of test image and might be used in testing by
> adding JTREG_TEST_THREAD_FACTORY=Virtual option.
This pull
On Fri, 21 Apr 2023 11:54:04 GMT, Matthias Baesken wrote:
> seems I have to adjust the separated test script to
>
> ```
> #!/bin/sh
>
> COMPILER_VERSION_OUTPUT=`xlclang -qversion 2>&1`
>
> COMPILER_VERSION_NUMBER=`echo $COMPILER_VERSION_OUTPUT | sed -e
> 's/^.*Version:
> We figured that seemingly the correct toolchain could be (and is) already
> installed by default on Github runners and it makes sense to skip the
> expensive installation operation which takes some 10+ minutes.
>
> I also tested the scenario with an older toolchain version which would really
On Fri, 21 Apr 2023 09:16:58 GMT, Aleksey Shipilev wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains one commit:
>>
>> JDK-8306658
>>
>> GHA: MSVC installation could be optional since it might
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
Thanks for the reviews. Now the GHAs are merely done with only some jtregs for
Windows and
On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
This pull request has now been integrated.
Changeset: 5a00617b
Author:Christoph Langer
On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
LGTM.
-
Marked as reviewed by mdoerr (Reviewer).
PR Review:
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote:
>> - The `throw()` (i.e., no throw) specifications are removed from the
>> instances of `operator new` where _do not_ return `nullptr`.
>>
>> - The `-fcheck-new` is removed from the gcc compile flags.
>>
>> - The `operator new` and
On Fri, 21 Apr 2023 09:00:47 GMT, Christoph Langer wrote:
>> We figured that seemingly the correct toolchain could be (and is) already
>> installed by default on Github runners and it makes sense to skip the
>> expensive installation operation which takes some 10+ minutes.
>>
>> I also tested
On Fri, 21 Apr 2023 07:51:00 GMT, Aleksey Shipilev wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains one commit:
>>
>> JDK-8306658
>>
>> GHA: MSVC installation could be optional since it might
On Fri, 21 Apr 2023 08:51:31 GMT, Aleksey Shipilev wrote:
> Okay, as long as GHAs are green after this change.
It already got past the installation step. Will wait until GHA is done and
integrate if there are no new related issues.
-
PR Comment:
> We figured that seemingly the correct toolchain could (and is) already
> installed by default and it makes sense to skip the expensive installation
> operation which takes some 10+ minutes in that case.
>
> I also tested the scenario with an older toolchain version which would need
>
On Fri, 21 Apr 2023 08:40:49 GMT, Christoph Langer wrote:
> This is the plain fix for the currently observed error in GHA.
>
> Will handle the optional install of the MSVC toolchain in a separate item.
Okay, as long as GHAs are green after this change.
-
Marked as reviewed by
This is the plain fix for the currently observed error in GHA.
Will handle the optional install of the MSVC toolchain in a separate item.
-
Commit messages:
- JDK-8306543
Changes: https://git.openjdk.org/jdk/pull/13576/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13576=00
On Fri, 21 Apr 2023 07:51:00 GMT, Aleksey Shipilev wrote:
> Okay, this sounds good to me. The synopsis is now incorrect, though: we do
> not fail because the component was already installed, we fail because of the
> backslashes. Suggestion: "GHA: MSVC installation should be skipped when it is
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Fri, 21 Apr 2023 06:56:43 GMT, Christoph Langer wrote:
> I did some more investigation for this issue.
>
> The real root cause for the failing install seems to be that the option
> --installPath nowadays needs a correct Windows path with backslashes. This
> probably must have been
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote:
>> Minor changes to the build system to recognize and warn that an incompatible
>> toolchain is detected.
>
> Tyler Steele has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change min xlx
I did some more investigation for this issue.
The real root cause for the failing install seems to be that the option
--installPath nowadays needs a correct Windows path with backslashes. This
probably must have been different beforehand. So I corrected that.
However, as we figured that
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
On Thu, 20 Apr 2023 11:56:37 GMT, Aleksey Shipilev wrote:
> Currrent GHA fails on MSVC installation. Looks like the required versions are
> already installed in the runner image, and this is why the command fails. Our
> configure scripts look for the specific minor version, and the builds
33 matches
Mail list logo
