> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all
> of the fixes required for HotSpot to compile under the stricter mode
> activated when the permissive- flag is passed
>
> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to
> avoid goto
On Thu, 2 Nov 2023 05:34:00 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Try immediate bailout in os_windows.cpp
>
> src/hotspot/os/windows/os_windows.cpp line 2915:
>
>> 2913: goto
On Thu, 2 Nov 2023 03:32:14 GMT, Julian Waters wrote:
>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains
>> all of the fixes required for HotSpot to compile under the stricter mode
>> activated when the permissive- flag is passed
>>
>> - Reworks code in
On Fri, 27 Oct 2023 11:59:59 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
Build failure with GCC8.3.1
=== Output from failing command(s) repeated here ===
* For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
/data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
In function 'hb_bool_t hb_ot_layout_get_font_extents(hb_font_t*,
> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all
> of the fixes required for HotSpot to compile under the stricter mode
> activated when the permissive- flag is passed
>
> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to
> avoid goto
On Wed, 1 Nov 2023 18:52:15 GMT, Phil Race wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 499:
>>
>>> 497:LIBFONTMANAGER_EXCLUDE_FILES += hb-ft.cc hb-subset-cff-common.cc \
>>> 498:hb-subset-cff1.cc hb-subset-cff2.cc hb-subset-input.cc
>>> hb-subset-plan.cc \
>>>
Tool modules can be created via `jmod --main-class` option such that
`ModuleMainClass` attribute will be added in `module-info.class` and the
module's main class can be launched via `java -m ` without
specifying the name of the main class.
In addition, for modules with `ModuleMainClass`
On Wed, 1 Nov 2023 18:51:26 GMT, Phil Race wrote:
>> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
>> We can cut the compilation time by not compiling the unused files.
>>
>> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
>> This is
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
On Fri, 27 Oct 2023 11:59:59 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote:
>> Hi, please consider.
>>
>> insn_options[0] is set to empty string if there is no options (NULL or empty
>> strings).
>> Checking it for empty string should cover both cases, caller option is NULL
>> or caller option is empty string.
>>
>>
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This
> Hi, please consider.
>
> insn_options[0] is set to empty string if there is no options (NULL or empty
> strings).
> Checking it for empty string should cover both cases, caller option is NULL
> or caller option is empty string.
>
> Tested hsdis no longer gives me the warning.
Robbin Ehn has
On Wed, 1 Nov 2023 11:19:20 GMT, Julian Waters wrote:
>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains
>> all of the fixes required for HotSpot to compile under the stricter mode
>> activated when the permissive- flag is passed
>>
>> - Reworks code in
> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all
> of the fixes required for HotSpot to compile under the stricter mode
> activated when the permissive- flag is passed
>
> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to
> avoid goto
hb-subset and hb-style APIs are not used and not exported by libfontmanger. We
can cut the compilation time by not compiling the unused files.
The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
This is with harfbuzz 8, with harfbuzz 7 the improvement was ~30 seconds.
On Tue, 31 Oct 2023 14:21:02 GMT, Hamlin Li wrote:
>> Hi, please consider.
>>
>> insn_options[0] is set to empty string if there is no options (NULL or empty
>> strings).
>> Checking it for empty string should cover both cases, caller option is NULL
>> or caller option is empty string.
>>
>>
On Wed, 1 Nov 2023 06:58:23 GMT, David Holmes wrote:
>> I've removed the goto, but would like to wait until Thomas is back
>
> No response from @tstuefe but I think the empty block is pointless and we
> should just check `if (!InterceptOSException) {`.
Sure, remove the empty block.
On Tue, 31 Oct 2023 08:37:44 GMT, Julian Waters wrote:
>> Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely, so
>> hadn't noticed the discussion there. Not sure why this is using a literal 0
>> rather than `(T) '\n'` as in that PR?
>>
>> So the literal "0" (or
On Wed, 1 Nov 2023 05:54:34 GMT, Julian Waters wrote:
>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains
>> all of the fixes required for HotSpot to compile under the stricter mode
>> activated when the permissive- flag is passed
>>
>> - Reworks code in
On Wed, 4 Oct 2023 04:40:25 GMT, Julian Waters wrote:
>> I think killing the goto makes most sense here.
>
> I've removed the goto, but would like to wait until Thomas is back
No response from @tstuefe but I think the empty block is pointless and we
should just check `if
On Fri, 6 Oct 2023 05:14:18 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Initialized thread in os_windows.cpp
>> - Oops in os_windows.cpp
>> - Remove goto in os_windows.cpp
>
> These
24 matches
Mail list logo
