RFR: 8330206: Bump minimum boot jdk to JDK 23

2024-10-04 Thread Mikael Vidstedt
With the JDK 23 GA out it's time to bump the minimum boot JDK version for mainline/JDK 24. Testing: tier1-5, GHA - Commit messages: - 8330206: Bump minimum boot jdk to JDK 23 Changes: https://git.openjdk.org/jdk/pull/21296/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2

Withdrawn: 8329816: Add SLEEF version 3.6.1

2024-09-17 Thread Mikael Vidstedt
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to b

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v6]

2024-09-16 Thread Mikael Vidstedt
On Mon, 16 Sep 2024 10:30:46 GMT, Magnus Ihse Bursie wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> sep

Re: RFR: 8340075: Autoconf bundle cannot run on read-only filesystem

2024-09-13 Thread Mikael Vidstedt
On Thu, 12 Sep 2024 22:33:43 GMT, Erik Joelsson wrote: > The autoconf launcher script in the autoconf bundle created by > `make/devkit/createAutoconf.sh` currently writes a config file into the > bundle installation dir every time it runs. This prevents it from functioning > when installed on

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]

2024-08-27 Thread Mikael Vidstedt
On Tue, 27 Aug 2024 22:26:02 GMT, Hamlin Li wrote: >> @Hamlin-Li We now have the necessary approvals in place for the new plan to >> include all of SLEEF (and the pre-generated header files) in the JDK. I (or >> somebody else from Oracle) will need to be the one committing/contributing >> the

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]

2024-08-27 Thread Mikael Vidstedt
On Fri, 16 Aug 2024 09:45:59 GMT, Hamlin Li wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update README to include RISC-V > >> With this solution I would recommend put

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]

2024-08-21 Thread Mikael Vidstedt
On Thu, 27 Jun 2024 22:03:37 GMT, Mikael Vidstedt wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files n

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-15 Thread Mikael Vidstedt
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review the patch? >> This pr is based on previous work and discussion in [pr >> 16234](https://github.com/openjdk/jdk/pull/16234), [pr >> 18294](https://github.com/openjdk/jdk/pull/18294). >> * NOTE: This pr depends on

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

2024-07-15 Thread Mikael Vidstedt
On Tue, 9 Jul 2024 12:08:50 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review the patch? >> This pr is based on previous work and discussion in [pr >> 16234](https://github.com/openjdk/jdk/pull/16234), [pr >> 18294](https://github.com/openjdk/jdk/pull/18294). >> * NOTE: This pr depends on

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Mikael Vidstedt
On Mon, 24 Jun 2024 13:30:35 GMT, Hamlin Li wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> separately.

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]

2024-06-27 Thread Mikael Vidstedt
enabling the rest of > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward. Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision: Update README to include RISC-V - Changes: - all: https://git.openj

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-06-27 Thread Mikael Vidstedt
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to b

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v2]

2024-06-27 Thread Mikael Vidstedt
enabling the rest of > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull r

Integrated: 8332849: Update doc/testing.{md, html} (spelling and stale information)

2024-05-28 Thread Mikael Vidstedt
On Thu, 23 May 2024 23:22:51 GMT, Mikael Vidstedt wrote: > Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 This pull reque

Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]

2024-05-28 Thread Mikael Vidstedt
On Fri, 24 May 2024 21:05:27 GMT, Mikael Vidstedt wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 >

Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]

2024-05-24 Thread Mikael Vidstedt
On Fri, 24 May 2024 12:50:59 GMT, Erik Joelsson wrote: >> doc/testing.html line 366: >> >>> 364: to setting JTREG_JOBS=1 JTREG_TIMEOUT_FACTOR=8, but using >>> 365: the keyword format means that the JTREG variable is parsed >>> 366: and verified for correctness, so JTREG="TIMEOUT_FACTOR=8" >> >>

Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]

2024-05-24 Thread Mikael Vidstedt
> Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 Mikael Vidstedt has updated the pull request incrementally with one additional c

RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)

2024-05-23 Thread Mikael Vidstedt
Update the testing doc to remove some stale information (AOT_MODULES, removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some spelling issues. Testing: tier1 - Commit messages: - 8332849: Update doc/testing.{md,html} (spelling and stale information) Ch

Re: RFR: 8329816: Add SLEEF version 3.6

2024-05-17 Thread Mikael Vidstedt
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to b

Re: RFR: 8329816: Add SLEEF version 3.6

2024-05-16 Thread Mikael Vidstedt
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to b

Re: RFR: 8329816: Add SLEEF version 3.6

2024-05-13 Thread Mikael Vidstedt
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to b

RFR: 8329816: Add SLEEF version 3.6

2024-05-10 Thread Mikael Vidstedt
[JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to optimize vector math operations by leveraging the SLEEF library. For legal reasons the actual contribution of the SLEEF files needs to be handled separately. This enhancement adds the relevant files, enabling the rest of [

Re: RFR: 8331939: Add custom hook for TestImage

2024-05-08 Thread Mikael Vidstedt
On Wed, 8 May 2024 14:03:48 GMT, Erik Joelsson wrote: > We need a custom hook in TestImage.gmk to modify behavior when building with > custom source. Marked as reviewed by mikael (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19139#pullrequestreview-2046326105

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

2024-04-09 Thread Mikael Vidstedt
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review the patch? >> This pr is based on previous work and discussion in [pr >> 16234](https://github.com/openjdk/jdk/pull/16234), [pr >> 18294](https://github.com/openjdk/jdk/pull/18294). >> >> Compared with previous

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF

2024-04-04 Thread Mikael Vidstedt
On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li wrote: > Hi, > Can you help to review the patch? > This pr is based on previous work and discussion in [pr > 16234](https://github.com/openjdk/jdk/pull/16234), [pr > 18294](https://github.com/openjdk/jdk/pull/18294). > > Compared with previous prs, th

Re: RFR: 8320799: Bump minimum boot jdk to JDK 22

2024-04-03 Thread Mikael Vidstedt
On Mon, 1 Apr 2024 16:16:50 GMT, Mikael Vidstedt wrote: > With the JDK 22 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 23. > > Testing: tier1-5, GHA Thank you for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/1

Integrated: 8320799: Bump minimum boot jdk to JDK 22

2024-04-03 Thread Mikael Vidstedt
On Mon, 1 Apr 2024 16:16:50 GMT, Mikael Vidstedt wrote: > With the JDK 22 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 23. > > Testing: tier1-5, GHA This pull request has now been integrated. Changeset: 023f7f17 Author: Mikael Vidstedt

RFR: 8320799: Bump minimum boot jdk to JDK 22

2024-04-01 Thread Mikael Vidstedt
With the JDK 22 GA out it's time to bump the minimum boot JDK version for mainline/JDK 23. Testing: tier1-5, GHA - Commit messages: - 8320799: Bump minimum boot jdk to JDK 22 Changes: https://git.openjdk.org/jdk/pull/18563/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1

Re: RFR: 8017234: Hotspot should stop using mapfiles [v5]

2024-02-22 Thread Mikael Vidstedt
On Thu, 22 Feb 2024 16:15:23 GMT, Magnus Ihse Bursie wrote: >> **Summary:** Finally get rid of the mapfiles in Hotspot, and replace it with >> compiler options and `JNIEXPORT` on all platforms. >> >> The bug that this PR solves, >> [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234), wa

Re: RFR: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts

2024-02-20 Thread Mikael Vidstedt
On Wed, 21 Feb 2024 00:59:18 GMT, David Holmes wrote: > Revert "8325963: Clean up NativeCompilation.gmk and its newly created parts" > > This reverts commit 1bd91cdebee1e9ec78ecf185529923eef40ff89c due to code > signing failures on macOS. > > Thanks Marked as reviewed by mikael (Reviewer). -

Integrated: 8325800: Drop unused cups declaration from Oracle build configuration

2024-02-13 Thread Mikael Vidstedt
On Tue, 13 Feb 2024 20:47:01 GMT, Mikael Vidstedt wrote: > The cups dependency was used for Solaris builds, and has been unused since > [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > > Testing: tier1 This pull request has now been integrated. Changeset: 876

Re: RFR: 8325800: Drop unused cups declaration from Oracle build configuration

2024-02-13 Thread Mikael Vidstedt
On Tue, 13 Feb 2024 20:47:01 GMT, Mikael Vidstedt wrote: > The cups dependency was used for Solaris builds, and has been unused since > [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > > Testing: tier1 Thank you for the review! - PR Comment: https://git

RFR: 8325800: Drop unused cups declaration from Oracle build configuration

2024-02-13 Thread Mikael Vidstedt
The cups dependency was used for Solaris builds, and has been unused since [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). Testing: tier1 - Commit messages: - 8325800: Drop unused cups declaration from Oracle build configuration Changes: https://git.openjdk.org/jdk/pul

Integrated: 8325570: Update to Graphviz 9.0.0

2024-02-12 Thread Mikael Vidstedt
On Fri, 9 Feb 2024 19:02:13 GMT, Mikael Vidstedt wrote: > Graphviz (aka. dotty/dot) is used when building "full" docs, and in > particular for creating various module graph images (.svg). This change > upgrades the Graphviz version used to 9.0.0 (latest). > >

Re: RFR: 8325570: Update to Graphviz 9.0.0

2024-02-12 Thread Mikael Vidstedt
On Fri, 9 Feb 2024 19:02:13 GMT, Mikael Vidstedt wrote: > Graphviz (aka. dotty/dot) is used when building "full" docs, and in > particular for creating various module graph images (.svg). This change > upgrades the Graphviz version used to 9.0.0 (latest). > >

Re: RFR: 8325570: Update to Graphviz 9.0.0

2024-02-09 Thread Mikael Vidstedt
On Fri, 9 Feb 2024 19:32:01 GMT, Erik Joelsson wrote: > Quick question, since configure scans for dot, will platform-specific pandoc > (like Windows pandoc) lead to different image outputs? AFAIU pandoc is not involved in the generation of the .svg images. The .dot files are generated by the t

RFR: 8325570: Update to Graphviz 9.0.0

2024-02-09 Thread Mikael Vidstedt
Graphviz (aka. dotty/dot) is used when building "full" docs, and in particular for creating various module graph images (.svg). This change upgrades the Graphviz version used to 9.0.0 (latest). In particular, the change: * Updates the createGraphvizBundle.sh script (currently broken) to build

Re: [jdk22] RFR: 8319547: Remove EA from the JDK 22 version string with first RC promotion

2024-02-05 Thread Mikael Vidstedt
On Tue, 6 Feb 2024 00:14:40 GMT, Jesper Wilhelmsson wrote: > Removed ea from the version string Marked as reviewed by mikael (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/106#pullrequestreview-1864071852

Re: RFR: 8274300: Address dsymutil warning by excluding platform specific files

2024-01-09 Thread Mikael Vidstedt
On Tue, 9 Jan 2024 07:50:36 GMT, David Holmes wrote: > > We run dsymutils on the libraries (e.g. `libjvm.dylib`) to extract the > > debug symbols. > > So how does it know about empty files??? Does an empty src file create an > empty object file which in turns creates an empty section in the li

Re: RFR: 8274300: Address dsymutil warning by excluding platform specific files

2024-01-08 Thread Mikael Vidstedt
On Mon, 8 Jan 2024 02:46:03 GMT, David Holmes wrote: > Are we passing the wrong set of files to dsymutils? I'm guessing it is > actually passed a set of object files not source files. We run dsymutils on the libraries (e.g. `libjvm.dylib`) to extract the debug symbols. - PR Comme

Re: RFR: 8274300: Address dsymutil warning by excluding platform specific files

2024-01-08 Thread Mikael Vidstedt
On Fri, 5 Jan 2024 21:05:49 GMT, Mikael Vidstedt wrote: > When building on macOS, dsymutil generates a warning for some files: > > `warning: no debug symbols in executable (-arch x86_64)` > > It turns out that the files in question have one thing in common: they're > e

Integrated: 8274300: Address dsymutil warning by excluding platform specific files

2024-01-08 Thread Mikael Vidstedt
On Fri, 5 Jan 2024 21:05:49 GMT, Mikael Vidstedt wrote: > When building on macOS, dsymutil generates a warning for some files: > > `warning: no debug symbols in executable (-arch x86_64)` > > It turns out that the files in question have one thing in common: they're > e

Re: RFR: 8274300: Address dsymutil warning by excluding platform specific files

2024-01-08 Thread Mikael Vidstedt
On Mon, 8 Jan 2024 02:41:29 GMT, David Holmes wrote: >> When building on macOS, dsymutil generates a warning for some files: >> >> `warning: no debug symbols in executable (-arch x86_64)` >> >> It turns out that the files in question have one thing in common: they're >> empty. Specifically, th

RFR: 8274300: Address dsymutil warning by excluding platform specific files

2024-01-05 Thread Mikael Vidstedt
When building on macOS, dsymutil generates a warning for some files: `warning: no debug symbols in executable (-arch x86_64)` It turns out that the files in question have one thing in common: they're empty. Specifically, the source files have include guards which, on macOS, end up excluding all

Integrated: 8322873: Duplicate -ljava -ljvm options for libinstrument

2024-01-03 Thread Mikael Vidstedt
On Tue, 2 Jan 2024 21:44:04 GMT, Mikael Vidstedt wrote: > The libinstrument library is linked against libjava and libjvm, twice. This > is mostly harmless but Xcode 15.x generates a warning: > > Creating support/modules_libs/java.instrument/libinstrument.dylib from 12 > file(s

Re: RFR: 8322873: Duplicate -ljava -ljvm options for libinstrument

2024-01-03 Thread Mikael Vidstedt
On Tue, 2 Jan 2024 21:44:04 GMT, Mikael Vidstedt wrote: > The libinstrument library is linked against libjava and libjvm, twice. This > is mostly harmless but Xcode 15.x generates a warning: > > Creating support/modules_libs/java.instrument/libinstrument.dylib from 12 > file(s

RFR: 8322873: Duplicate -ljava -ljvm options for libinstrument

2024-01-02 Thread Mikael Vidstedt
The libinstrument library is linked against libjava and libjvm, twice. This is mostly harmless but Xcode 15.x generates a warning: Creating support/modules_libs/java.instrument/libinstrument.dylib from 12 file(s) ld: warning: ignoring duplicate libraries: '-ljava', '-ljvm' In particular, note t

Re: RFR: 8320942: Only set openjdk-target when cross compiling linux-aarch64

2023-11-29 Thread Mikael Vidstedt
On Wed, 29 Nov 2023 02:25:20 GMT, Mikael Vidstedt wrote: > When building linux-aarch64 at Oracle using jib, > --openjdk-target=aarch64-linux-gnu is always specified regardless of if > building natively or cross compiling (on linux-x64). Among other things this > has the (harmles

Integrated: 8320942: Only set openjdk-target when cross compiling linux-aarch64

2023-11-29 Thread Mikael Vidstedt
On Wed, 29 Nov 2023 02:25:20 GMT, Mikael Vidstedt wrote: > When building linux-aarch64 at Oracle using jib, > --openjdk-target=aarch64-linux-gnu is always specified regardless of if > building natively or cross compiling (on linux-x64). Among other things this > has the (harmles

RFR: 8320942: Only set openjdk-target when cross compiling linux-aarch64

2023-11-28 Thread Mikael Vidstedt
When building linux-aarch64 at Oracle using jib, --openjdk-target=aarch64-linux-gnu is always specified regardless of if building natively or cross compiling (on linux-x64). Among other things this has the (harmless) effect of tricking configure into thinking that it's cross compiling even for

Re: RFR: JDK-8320932: [BACKOUT] dsymutil command leaves around temporary directories

2023-11-28 Thread Mikael Vidstedt
On Tue, 28 Nov 2023 21:48:13 GMT, Erik Joelsson wrote: > This is a backout of > [JDK-8320863](https://bugs.openjdk.org/browse/JDK-8320863). That fix only > works on a very limited selection of Xcode versions, and is causing the build > to fail on other versions, including at least 12, 13 and 1

Integrated: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Mikael Vidstedt
On Fri, 17 Nov 2023 00:31:36 GMT, Mikael Vidstedt wrote: > In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 > (fastdebug). With the changes in JDK-8319883 additional stringop-overflow > warnings are produced with GCC 13.2.0, this time for linux

Re: RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Mikael Vidstedt
On Fri, 17 Nov 2023 00:31:36 GMT, Mikael Vidstedt wrote: > In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 > (fastdebug). With the changes in JDK-8319883 additional stringop-overflow > warnings are produced with GCC 13.2.0, this time for linux

Re: RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-17 Thread Mikael Vidstedt
On Fri, 17 Nov 2023 15:36:29 GMT, Magnus Ihse Bursie wrote: > Looks okay from a build perspective. In the end, I guess some hotspot > developers need to weigh in if this is acceptable. > > I presume you have tried to analyze what makes the Thread:current access > different in these files, so t

RFR: 8320212: Disable GCC stringop-overflow warning for affected files

2023-11-16 Thread Mikael Vidstedt
In JDK-8319818 the stringop-overflow warnings were disabled for linux-aarch64 (fastdebug). With the changes in JDK-8319883 additional stringop-overflow warnings are produced with GCC 13.2.0, this time for linux-x64-zero (fastdebug). The warnings are related to GCC thinking JavaThread:current (an

Re: RFR: 8320258: Refresh building.md

2023-11-16 Thread Mikael Vidstedt
On Thu, 16 Nov 2023 17:40:36 GMT, Magnus Ihse Bursie wrote: > The contents of the build README has been poorly kept up to date in places. > With the move to Github, the need to have markdown syntax that looks good on > Github has become apparent. The entire document has been in need for a while

Integrated: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle

2023-11-13 Thread Mikael Vidstedt
On Tue, 7 Nov 2023 23:37:06 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of GCC for building the JDK on Linux to 13.2.0. > > > **Note: The changes discussed below were broken out into a separate change > and integrated through #16584.** > > Apart from

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v4]

2023-11-13 Thread Mikael Vidstedt
On Mon, 13 Nov 2023 17:55:12 GMT, Mikael Vidstedt wrote: >> Oracle is updating the version of GCC for building the JDK on Linux to >> 13.2.0. >> >> >> **Note: The changes discussed below were broken out into a separate change >> and integrated through #165

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v4]

2023-11-13 Thread Mikael Vidstedt
t; > The linux/zero build generates lots and lots of dangling pointer warnings. As > with the first warning I tried to understand why but also gave up in the end. > Like the first warning I disabled it instead, for zero builds. Again > appreciating feedback/suggestions. Mikael Vidstedt ha

Integrated: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)

2023-11-13 Thread Mikael Vidstedt
On Thu, 9 Nov 2023 16:07:53 GMT, Mikael Vidstedt wrote: > This PR is splitting out the GCC 13.2.0 warning related changes from #16550, > excluding the Oracle/devkit parts, for clarity and to make potential > backports more straightforward. > > GCC 13.2.0 generates t

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer) [v2]

2023-11-13 Thread Mikael Vidstedt
On Fri, 10 Nov 2023 18:08:17 GMT, Mikael Vidstedt wrote: >> This PR is splitting out the GCC 13.2.0 warning related changes from #16550, >> excluding the Oracle/devkit parts, for clarity and to make potential >> backports more straightforward. >> >> GCC 13.

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer) [v2]

2023-11-10 Thread Mikael Vidstedt
On Fri, 10 Nov 2023 01:25:32 GMT, Hao Sun wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add comment for stringop-overflow warning >> >> Co-authored-by: Hao Sun >

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer) [v2]

2023-11-10 Thread Mikael Vidstedt
_current_resource_mark' > [-Werror=dangling-pointer=] > > Lots and lots of warnings related to ResourceMark. Thanks to @stefank for > suggesting moving the ASSERT implementation of the ResourceMark constructor > to the .cpp file. With that change there's no need to expl

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)

2023-11-09 Thread Mikael Vidstedt
On Thu, 9 Nov 2023 16:07:53 GMT, Mikael Vidstedt wrote: > This PR is splitting out the GCC 13.2.0 warning related changes from #16550, > excluding the Oracle/devkit parts, for clarity and to make potential > backports more straightforward. > > GCC 13.2.0 generates t

Re: RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)

2023-11-09 Thread Mikael Vidstedt
On Thu, 9 Nov 2023 16:07:53 GMT, Mikael Vidstedt wrote: > This PR is splitting out the GCC 13.2.0 warning related changes from #16550, > excluding the Oracle/devkit parts, for clarity and to make potential > backports more straightforward. > > GCC 13.2.0 generates t

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v3]

2023-11-09 Thread Mikael Vidstedt
On Thu, 9 Nov 2023 05:20:18 GMT, David Holmes wrote: >> Mikael Vidstedt has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright years > > src/hotspot/share/memory/resourceArea.cpp line 1: > >

RFR: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)

2023-11-09 Thread Mikael Vidstedt
This PR is splitting out the GCC 13.2.0 warning related changes from #16550, excluding the Oracle/devkit parts, for clarity and to make potential backports more straightforward. GCC 13.2.0 generates two new warnings: * linux-aarch64-debug src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.h

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v3]

2023-11-08 Thread Mikael Vidstedt
t; > The linux/zero build generates lots and lots of dangling pointer warnings. As > with the first warning I tried to understand why but also gave up in the end. > Like the first warning I disabled it instead, for zero builds. Again > appreciating feedback/suggestions. Mikae

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v2]

2023-11-08 Thread Mikael Vidstedt
On Wed, 8 Nov 2023 21:30:24 GMT, Magnus Ihse Bursie wrote: >> FWIW I just followed the preexisting pattern in the same file, e.g. >> https://github.com/openjdk/jdk/blob/7d25f1c6cb770e21cfad8096c1637a24e65fab8c/make/hotspot/lib/CompileJvm.gmk#L1100. >> @magicus Let me know if you want me to chan

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v2]

2023-11-08 Thread Mikael Vidstedt
On Wed, 8 Nov 2023 22:10:20 GMT, Mikael Vidstedt wrote: >> Oracle is updating the version of GCC for building the JDK on Linux to >> 13.2.0. >> >> Apart from the "obvious" changes, I'll add some color to the CompileJvm.gmk >> changes. In part

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v2]

2023-11-08 Thread Mikael Vidstedt
t; > The linux/zero build generates lots and lots of dangling pointer warnings. As > with the first warning I tried to understand why but also gave up in the end. > Like the first warning I disabled it instead, for zero builds. Again > appreciating feedback/suggestions. Mikael

Re: RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle

2023-11-08 Thread Mikael Vidstedt
On Wed, 8 Nov 2023 13:24:21 GMT, Magnus Ihse Bursie wrote: >> Oracle is updating the version of GCC for building the JDK on Linux to >> 13.2.0. >> >> Apart from the "obvious" changes, I'll add some color to the CompileJvm.gmk >> changes. In particular, I ran into two different types of new war

RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle

2023-11-07 Thread Mikael Vidstedt
Oracle is updating the version of GCC for building the JDK on Linux to 13.2.0. Apart from the "obvious" changes, I'll add some color to the CompileJvm.gmk changes. In particular, I ran into two different types of new warnings with GCC 13.2.0: 1. linux-aarch64-debug + stringop-overflow `src/hot

Integrated: 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle

2023-11-07 Thread Mikael Vidstedt
On Mon, 6 Nov 2023 23:00:39 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of Visual Studio for building the JDK on > Windows to Visual Studio 2022 17.6.5. This pull request has now been integrated. Changeset: 806529aa Author:Mikael Vidstedt URL:

RFR: 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle

2023-11-06 Thread Mikael Vidstedt
Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.6.5. - Commit messages: - 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle Changes: https://git.openjdk.org/jdk/pull/16533/files Webrev: https://webrev

Re: RFR: 8318481: linux-arm32 attribute warning for offset_of

2023-10-19 Thread Mikael Vidstedt
On Wed, 18 Oct 2023 23:02:18 GMT, Mikael Vidstedt wrote: > The linux-arm32 build generates a somewhat spectacular number of warnings, > all for the same code - the offset_of macro in hotspot: > > > src/hotspot/share/utilities/globalDefinitions_gcc.hpp:144:40: warning: > r

Withdrawn: 8318481: linux-arm32 attribute warning for offset_of

2023-10-19 Thread Mikael Vidstedt
On Wed, 18 Oct 2023 23:02:18 GMT, Mikael Vidstedt wrote: > The linux-arm32 build generates a somewhat spectacular number of warnings, > all for the same code - the offset_of macro in hotspot: > > > src/hotspot/share/utilities/globalDefinitions_gcc.hpp:144:40: warning: > r

RFR: 8318481: linux-arm32 attribute warning for offset_of

2023-10-18 Thread Mikael Vidstedt
The linux-arm32 build generates a somewhat spectacular number of warnings, all for the same code - the offset_of macro in hotspot: src/hotspot/share/utilities/globalDefinitions_gcc.hpp:144:40: warning: requested alignment 16 is larger than 8 [-Wattributes] alignas(16) char space[sizeof (kla

Integrated: 8317970: Bump target macosx-x64 version to 11.00.00

2023-10-13 Thread Mikael Vidstedt
On Wed, 11 Oct 2023 17:49:14 GMT, Mikael Vidstedt wrote: > macOS 10.x is no longer receiving updates - the most recent/last release was > 10.15.7 back in July of 2022. It's time to bump the target macOS version > (min/max) for macosx-x64. macOS 11.x is still receiving updates. &g

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v4]

2023-10-13 Thread Mikael Vidstedt
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote: >> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receivi

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v4]

2023-10-13 Thread Mikael Vidstedt
cosx-x64 to 11.00.00, which is > the same version used for macosx-aarch64. Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision: Drop redundant MACOSX_METAL_VERSION_MIN variable - Changes: - all: https://git.openjdk.o

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v3]

2023-10-13 Thread Mikael Vidstedt
cosx-x64 to 11.00.00, which is > the same version used for macosx-aarch64. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional

Integrated: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Mikael Vidstedt
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote: > In GHA, the versions of macOS (note: the version used for build/test, **not** > the target macOS version we compile for) and Xcode are starting to show age. > It's time to update to more modern versions. > > T

Re: RFR: 8318039: GHA: Bump macOS and Xcode versions

2023-10-13 Thread Mikael Vidstedt
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote: > In GHA, the versions of macOS (note: the version used for build/test, **not** > the target macOS version we compile for) and Xcode are starting to show age. > It's time to update to more modern versions. > > T

RFR: 8318039: GHA: Bump macOS and Xcode versions

2023-10-12 Thread Mikael Vidstedt
In GHA, the versions of macOS (note: the version used for build/test, **not** the target macOS version we compile for) and Xcode are starting to show age. It's time to update to more modern versions. This change bumps the macOS to 13 (from 11) and Xcode to 14.3.1 (from 12.5.1/11.7). This is a p

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v2]

2023-10-11 Thread Mikael Vidstedt
cosx-x64 to 11.00.00, which is > the same version used for macosx-aarch64. Mikael Vidstedt has updated the pull request incrementally with two additional commits since the last revision: - Update stale comment (again) - Update stale comment - Changes: - all: https://git.openjdk.o

RFR: 8317970: Bump target macosx-x64 version to 11.00.00

2023-10-11 Thread Mikael Vidstedt
macOS 10.x is no longer receiving updates - the most recent/last release was 10.15.7 back in July of 2022. It's time to bump the target macOS version (min/max) for macosx-x64. macOS 11.x is still receiving updates. This change updates the target version for macosx-x64 to 11.00.00, which is the

Integrated: 8317560: Change to Xcode 14.3.1 for building on macOS at Oracle

2023-10-06 Thread Mikael Vidstedt
On Thu, 5 Oct 2023 17:05:33 GMT, Mikael Vidstedt wrote: > This change bumps the version of Xcode used for building at Oracle to Xcode > 14.3.1 and updates the docs accordingly. The change also updates the devkit > creation logic to work around issues with macOS. This pull request has

RFR: 8317560: Change to Xcode 14.3.1 for building on macOS at Oracle

2023-10-05 Thread Mikael Vidstedt
This change bumps the version of Xcode used for building at Oracle to Xcode 14.3.1 and updates the docs accordingly. The change also updates the devkit creation logic to work around issues with macOS. - Commit messages: - 8317560: Change to Xcode 14.3.1 for building on macOS at Ora

Re: RFR: 8306630: Bump minimum boot jdk to JDK 21

2023-09-27 Thread Mikael Vidstedt
On Tue, 26 Sep 2023 21:22:07 GMT, Mikael Vidstedt wrote: > With the JDK 21 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 22. > > Testing: tier1-5, GHA Thank you for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/1

Integrated: 8306630: Bump minimum boot jdk to JDK 21

2023-09-27 Thread Mikael Vidstedt
On Tue, 26 Sep 2023 21:22:07 GMT, Mikael Vidstedt wrote: > With the JDK 21 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 22. > > Testing: tier1-5, GHA This pull request has now been integrated. Changeset: 83c0e451 Author: Mikael Vidstedt

RFR: 8306630: Bump minimum boot jdk to JDK 21

2023-09-26 Thread Mikael Vidstedt
With the JDK 21 GA out it's time to bump the minimum boot JDK version for mainline/JDK 22. Testing: tier1-5, GHA (in progress) - Commit messages: - 8306630: Bump minimum boot jdk to JDK 21 Changes: https://git.openjdk.org/jdk/pull/15934/files Webrev: https://webrevs.openjdk.org/?

Re: RFR: 8303427: Fixpath confused if unix root contains "/jdk"

2023-08-31 Thread Mikael Vidstedt
On Tue, 29 Aug 2023 00:16:46 GMT, Erik Joelsson wrote: > On Windows, when a directory exists in the "unix" root with the same name as > a directory in the "test" dir, fixpath will corrupt test arguments to jtreg > (and possibly other arguments as well). Fixpath sees a string like this: > > tes

Re: RFR: 8314444: Update jib-profiles.js to use JMH 1.37 devkit

2023-08-16 Thread Mikael Vidstedt
On Wed, 16 Aug 2023 15:52:09 GMT, Claes Redestad wrote: > Use most recent devkit when using jib. > > Test: staged, configured from scratch and verified micros locally Marked as reviewed by mikael (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15313#pullrequestreview-158

Integrated: 8314166: Update googletest to v1.14.0

2023-08-15 Thread Mikael Vidstedt
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt wrote: > As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This &g

Re: RFR: 8314166: Update googletest to v1.14.0 [v2]

2023-08-15 Thread Mikael Vidstedt
On Tue, 15 Aug 2023 17:05:28 GMT, Mikael Vidstedt wrote: >> As part of the ongoing work to enable -Wconversion with gcc there are a >> number of occurrences of code in the GoogleTest code itself which need >> fixing. These have been addressed in version 1.14.0 of GoogleTest.

Re: RFR: 8314166: Update googletest to v1.14.0 [v2]

2023-08-15 Thread Mikael Vidstedt
y just > around the corner.. > > Testing: GHA, tier1-5 (still in progress) Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains tw

RFR: 8314166: Update googletest to v1.14.0

2023-08-11 Thread Mikael Vidstedt
As part of the ongoing work to enable -Wconversion with gcc there are a number of occurrences of code in the GoogleTest code itself which need fixing. These have been addressed in version 1.14.0 of GoogleTest. This change is picking up that version, adjusting the relevant build configuration fil

Re: [jdk21] RFR: 8312985: Remove EA from the JDK 21 version string with first RC promotion on August 10, 2023

2023-08-07 Thread Mikael Vidstedt
On Mon, 7 Aug 2023 23:11:27 GMT, Jesper Wilhelmsson wrote: > JDK-8312985: Remove EA from the JDK 21 version string with first RC promotion > on August 10, 2023 Marked as reviewed by mikael (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/165#pullrequestreview-156626161

Re: RFR: 8311545: Allow test symbol files to be kept in the test image

2023-07-12 Thread Mikael Vidstedt
On Fri, 7 Jul 2023 02:38:37 GMT, David Holmes wrote: > Please review this simple change to allow a test to request that its symbol > files be copied across into the test image. > > Testing: > - sanity test - tiers 1-3 > - direct testing in the context of > [JDK-8311541](https://bugs.openjdk.

  1   2   >