On Fri, 20 Sep 2024 16:56:58 GMT, Matias Saavedra Silva
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/cds/archiveUtils.cpp line 348:
>
>> 346: old_tag = (i
On Sun, 22 Sep 2024 11:02:20 GMT, Julian Waters wrote:
>> Trivial change to drop the optimization level (for both fastdebug and
>> release) of stackMapTable.cpp to O1 on MacOS with Xcode 16.
>>
>> This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which
>> prevents building
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote:
> Trivial change to drop the optimization level (for both fastdebug and
> release) of stackMapTable.cpp to O1 on MacOS with Xcode 16.
>
> This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which
> preve
Trivial change to drop the optimization level (for both fastdebug and release)
of stackMapTable.cpp to O1 on MacOS with Xcode 16.
This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which
prevents building on MacOS.
Tested: with patch fastdebug and release builds are green aga
On Thu, 19 Sep 2024 13:08:43 GMT, Stefan Karlsson wrote:
>> Yes, please, not having this code would be really nice. This is difficult
>> code.
>
> Do you seen any effects of this in anything other than special-crafted micro
> benchmarks? I wonder if it would be good enough to hard-code this to
On Thu, 19 Sep 2024 05:44:42 GMT, Stefan Karlsson wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JVMCI support
>
> src/hotspot/share/oops/compressedKlass.cpp line 231:
>
>> 229: // The reason is that we want
On Wed, 18 Sep 2024 23:53:28 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JVMCI support
>
> src/hotspot/share/oops/compressedKlass.hpp line 175:
>
>> 173: // 5b) if CDS=off: Calls ini
On Tue, 17 Sep 2024 10:36:58 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - fix CompressedClassPointersEncodingScheme yet again for linux aarch64
>> - Fixes post-8340
On Thu, 19 Sep 2024 11:43:12 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/oops/compressedKlass.cpp line 231:
>>
>>> 229: // The reason is that we want to avoid, if possible, shifts larger
>>> than
>>> 230: // a cacheline size.
>>> 231
On Wed, 18 Sep 2024 23:49:34 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JVMCI support
>
> src/hotspot/share/oops/compressedKlass.cpp line 242:
>
>> 240: } else {
>> 241:
>> 242:
On Wed, 11 Sep 2024 12:27:14 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 87:
>
>> 85: kl
On Wed, 11 Sep 2024 11:40:24 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 57 commits:
>>
>> - fix CompressedClassPointersEncodingScheme yet again for linux aarch64
>> - Fixes post-8340
On Wed, 11 Sep 2024 11:29:38 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 52:
>
>> 50: bool is_e
On Wed, 11 Sep 2024 11:25:56 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 48:
>
>> 46:
>> 47: M
On Wed, 11 Sep 2024 13:50:59 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace.cpp line 656:
>
>> 654: // Adjust size
On Wed, 11 Sep 2024 13:05:10 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 165:
>
>> 163: MetaBl
On Wed, 11 Sep 2024 12:25:37 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.hpp line 81:
>
>> 79: metaspac
On Wed, 11 Sep 2024 11:25:41 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/metablock.hpp line 51:
>
>> 49: size_t wo
On Wed, 11 Sep 2024 21:15:21 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental change of UCOH default
>
> I was starting to understand the concerns with having prototype_heade
On Tue, 10 Sep 2024 12:35:42 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/oops/compressedKlass.cpp line 116:
>>
>>> 114: _range = end - _base;
>>> 115:
>>> 116: DEBUG_ONLY(assert_is_valid_encoding(addr, len, _base, _shift);)
>>
>> Can y
On Tue, 10 Sep 2024 12:13:58 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/oops/compressedKlass.cpp line 243:
>>
>>> 241: } else {
>>> 242:
>>> 243: // In legacy mode, we try, in order of preference:
>>
>> Can you not use the word
On Tue, 10 Sep 2024 12:19:32 GMT, Coleen Phillimore wrote:
>> This is tricky. We are already deep in initialization and have done a couple
>> of decisions based on +UseCompressedClassPointers (e.g. CDS setup). I
>> *think* we could still go with -UseCCP, but I wonder whether this is wise.
>>
On Mon, 9 Sep 2024 15:58:29 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/cpu/aarch64/compressedKlas
On Wed, 11 Sep 2024 14:47:07 GMT, Roberto Castañeda Lozano
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental change of UCOH default
>
> src/hotspot/share/opto/machnode.cpp line 390:
>
>> 388:
On Thu, 12 Sep 2024 10:17:47 GMT, Roberto Castañeda Lozano
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental change of UCOH default
>
> src/hotspot/share/opto/lcm.cpp line 272:
>
>> 270: c
On Wed, 11 Sep 2024 16:14:39 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/metaspace/binList.hpp line 202:
>>
>>> 200: b_last = b;
>>> 201: }
>>> 202: if (UseNewCode)printf("\n");
>>
>> I guess this line
On Wed, 11 Sep 2024 14:15:12 GMT, Roberto Castañeda Lozano
wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/metaspace/binList.hpp line 202:
>
>> 200
On Wed, 11 Sep 2024 12:47:30 GMT, Johan Sjölen wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix FullGCForwarding initialization
>
> src/hotspot/share/memory/classLoaderMetaspace.cpp line 115:
>
>> 113: if (wa
On Mon, 9 Sep 2024 17:40:03 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/compressedKlass
On Mon, 9 Sep 2024 16:01:10 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/compressedKlass.hpp line 43:
>>
>>> 41:
>>> 42: // Tiny-class-pointer mode
>>> 43: static int _tiny_cp; // -1, 0=true, 1=false
>>
>> Suggestion:
>>
>> static int _tiny_cp; // -1 = uninitialized, 0 = true
On Mon, 9 Sep 2024 15:59:43 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - More touch-ups, fix Shenandoah oop iterator
>> - Remove asserts in XArrayKlass::oop_oop_iterate()
>> - Various
On Mon, 9 Sep 2024 15:50:50 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/compressedKlass
On Mon, 9 Sep 2024 15:49:57 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/compressedKlass
On Fri, 30 Aug 2024 07:27:45 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/shared/gcForwarding.cpp line 37:
>>
>>> 35: size_t max_narrow_heap_size = right_n_bits(NumLowBitsNarrow - Shift);
>>> 36: if (UseCompactObjectHeaders && max_heap_size > max_narrow_heap_size *
>>> HeapWordSize)
On Fri, 30 Aug 2024 07:25:54 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/serial/serialArguments.cpp line 33:
>>
>>> 31: void SerialArguments::initialize_heap_flags_and_sizes() {
>>> 32: GenArguments::initialize_heap_flags_and_sizes();
>>> 33: GCForwarding::initialize_flags(MaxNewSize
On Fri, 23 Aug 2024 16:23:19 GMT, Leonid Mesnik wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> make/Images.gmk line 135:
>
>> 133: #
>> 134: # Param1 - VM variant (e.g., server,
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 23 Aug 2024 19:03:19 GMT, Leonid Mesnik wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> test/hotspot/jtreg/runtime/cds/appcds/TestZGCWithCDS.java line 59:
>
>> 57: pu
On Fri, 26 Jul 2024 16:21:33 GMT, Aleksey Shipilev wrote:
> I noticed that `build/$confname/configure.log` was truncated on some of my
> build nodes. Turns out, we are moving configure.log from tree root to that
> place a bit prematurely.
>
> We move `configure.log` here:
> https://github.com/
On Mon, 24 Jun 2024 21:22:48 GMT, Ioi Lam wrote:
> More filtering is needed when building the default archive in the JDK:
> constant pool resolution when running the
> `build.tools.classlist.HelloClasslist` program is not deterministic (due to
> concurrency in core library classes). This could
On Mon, 24 Jun 2024 13:45:38 GMT, Jan Kratochvil
wrote:
>> fastdebug:
>>
>>
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> # Internal Error
>> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77),
>> pid=878152, tid=878158
>> # assert
ixed mode, tiered, compressed oops,
>> compressed class ptrs, g1 gc, linux-amd64)
>> # Problematic frame:
>> # V [libjvm.so+0x1d20658] constantPoolHandle::constantPoolHandle(Thread*,
>> ConstantPool*)+0x268
>
> Jan Kratochvil has updated the pull request incrementally with o
On Mon, 24 Jun 2024 14:14:36 GMT, Jan Kratochvil
wrote:
>> make/autoconf/jdk-options.m4 line 448:
>>
>>> 446: if test "x$TOOLCHAIN_TYPE" = "xclang"; then
>>> 447: ASAN_CFLAGS="$ASAN_CFLAGS
>>> -fsanitize-address-use-after-return=never"
>>> 448: fi
>>
>> Curious
On Mon, 24 Jun 2024 11:37:07 GMT, David Holmes wrote:
> > That's all.
>
> That's somewhat of an understatement. :)
>
> I'm still unclear how anything ASAN does gets examined by our assertion, but
> it sounds to me like ASAN is just broken in this area. So I support Kim's
> conclusion - lets j
On Sun, 23 Jun 2024 01:39:14 GMT, Kim Barrett wrote:
>> fastdebug:
>>
>>
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> # Internal Error
>> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77),
>> pid=878152, tid=878158
>> # assert(_th
On Fri, 21 Jun 2024 08:29:37 GMT, Matthias Baesken wrote:
>> Sometimes it would be helpful to have configure-support for adding
>> additional ubsan check options.
>> E.g. support new configure option
>> '--with-additional-ubsan-checks=' .
>
> Matthias Baesken has updated the pull request increm
On Fri, 21 Jun 2024 08:29:37 GMT, Matthias Baesken wrote:
>> Sometimes it would be helpful to have configure-support for adding
>> additional ubsan check options.
>> E.g. support new configure option
>> '--with-additional-ubsan-checks=' .
>
> Matthias Baesken has updated the pull request increm
On Wed, 19 Jun 2024 16:50:22 GMT, Daniel Jeliński wrote:
>> We use 2 ParkEvent instances per thread. The ParkEvent objects are never
>> freed, but they are recycled when a thread dies, so the number of live
>> ParkEvent instances is proportional to the maximum number of threads that
>> were li
On Wed, 19 Jun 2024 14:53:27 GMT, Viktor Klang wrote:
>> yeah, it's the C++ construction where the constructor and the destructor
>> have side effects. It increases the system timer resolution, unless
>> `ForceTimeHighResolution` is set. `ForceTimeHighResolution`, contrary to its
>> name and h
On Wed, 19 Jun 2024 11:40:16 GMT, Daniel Jeliński wrote:
> As you found out already, the implementation is based on a hash table, so
> access will be slower with many threads waiting at the same time. The hash
> table is stored in user space (in PEB), and the implementation reportedly
> doesn'
On Tue, 18 Jun 2024 21:01:15 GMT, Daniel Jeliński wrote:
> We use 2 ParkEvent instances per thread. The ParkEvent objects are never
> freed, but they are recycled when a thread dies, so the number of live
> ParkEvent instances is proportional to the maximum number of threads that
> were live a
On Wed, 12 Jun 2024 14:04:41 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>>
>> I have added the following enhancements:
>> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
>> respectively.
>>
On Tue, 11 Jun 2024 13:34:24 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>>
>> I have added the following enhancements:
>> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
>> respectively.
>>
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote:
> When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure
> flag --enable-ubsan), in a lot of jfr related tests like
> compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr
> serviceability/jvmti/RedefineClasses/Re
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote:
> When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure
> flag --enable-ubsan), in a lot of jfr related tests like
> compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr
> serviceability/jvmti/RedefineClasses/Re
On Tue, 11 Jun 2024 14:46:10 GMT, Matthias Baesken wrote:
> My maximum JfrEventId is 163 , see the generated
> hotspot/variant-server/gensrc/jfrfiles/jfrEventIds.hpp
>
> ```
>
> enum JfrEventId {
> JfrMetadataEvent = 0,
> JfrCheckpointEvent = 1,
> JfrDurationEvent = 2,
> JfrInstantEven
On Tue, 11 Jun 2024 13:12:48 GMT, Pavel Rappo wrote:
> Opinion: while it's good to see improvements to the existent script, since
> JEP 330, we can now conveniently implement a similar script in Java. That'll
> also automatically take care of OS specifics.
Sure, but the script is here, it work
On Mon, 10 Jun 2024 12:30:59 GMT, Matthias Baesken wrote:
> When running hs :tier1 tests or jdk/jfr tests, with ubsan enabled (configure
> flag --enable-ubsan), in a lot of jfr related tests like
> compiler/intrinsics/klass/CastNullCheckDroppingsTest.jtr
> serviceability/jvmti/RedefineClasses/Re
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> - Altere
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> - Altere
On Thu, 9 May 2024 17:05:40 GMT, Ioi Lam wrote:
>> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K,
>> and (when run on Mac M1 hardware) 16K.
>>
>> Since forgetting to specify `--enable-compatible-cds-alignment` is a common
>> error that is only noticed when running t
On Wed, 8 May 2024 15:14:16 GMT, Thomas Stuefe wrote:
> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K,
> and (when run on Mac M1 hardware) 16K.
>
> Since forgetting to specify `--enable-compatible-cds-alignment` is a common
> error that is only notic
On Thu, 9 May 2024 05:04:47 GMT, Thomas Stuefe wrote:
>> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K,
>> and (when run on Mac M1 hardware) 16K.
>>
>> Since forgetting to specify `--enable-compatible-cds-alignment` is a common
>> e
On Wed, 8 May 2024 15:14:16 GMT, Thomas Stuefe wrote:
> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K,
> and (when run on Mac M1 hardware) 16K.
>
> Since forgetting to specify `--enable-compatible-cds-alignment` is a common
> error that is only notic
On Wed, 8 May 2024 17:01:26 GMT, Andrew Haley wrote:
> This is obviously correct. Otherwise, the CDS archive will only work if the
> JDK happens to have been built on a machine with greater or equal page size.
>
> Does the default `compatible-cds-alignment=false` make any sense anywhere on
> o
On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, and
(when run on Mac M1 hardware) 16K.
Since forgetting to specify `--enable-compatible-cds-alignment` is a common
error that is only noticed when running the produced JVM on hardware with
different page size, we propose
On Wed, 10 Apr 2024 13:46:11 GMT, Martin Doerr wrote:
>> In my humble opinion the inclusion of alloca.h was slightly cleaner, but I
>> guess it doesn't matter. Out of curiosity, why do you guys prefer not
>> including it?
>
> When only looking at AIX code, I think the inclusion of alloca.h was
On Wed, 10 Apr 2024 12:15:34 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus t
On Tue, 2 Apr 2024 09:19:16 GMT, Joachim Kern wrote:
>> Hi Thomas,
>> I would like to get totally rid of this, because as I mentioned IBM already
>> modified the `stdlib.h` header not using `#define malloc vec_malloc` any
>> more (and all the other vec_... defines). We have to ask the adoptium
On Tue, 2 Apr 2024 16:14:12 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus th
On Tue, 2 Apr 2024 10:26:42 GMT, Joachim Kern wrote:
>> src/hotspot/os/aix/os_aix.cpp line 314:
>>
>>> 312: ErrnoPreserver ep;
>>> 313: log_trace(os, map)("disclaim failed: " RANGEFMT " errno=(%s)",
>>> 314: RANGEFMTARGS(p, (long)maxDisclaimSize),
>>
>> Wait
On Fri, 29 Mar 2024 07:56:10 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 50:
>>
>>> 48: #undef malloc
>>> 49: extern void *malloc(size_t) asm("vec_malloc");
>>> 50: #endif
>>
>> This
On Thu, 28 Mar 2024 16:57:00 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus t
On Fri, 29 Mar 2024 07:18:47 GMT, Thomas Stuefe wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the J
On Thu, 28 Mar 2024 16:50:20 GMT, Joachim Kern wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the o
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie wrote:
> We should match the building of jspawnhelper in
> make/modules/java.base/Launcher.gmk with the usage for all unix platforms in
> src/java.base/unix/classes/java/lang/ProcessImpl.java.
>
> Granted, the list of OSes in the makefile amo
On Fri, 16 Feb 2024 04:46:24 GMT, Kim Barrett wrote:
> > Unfortunately this will break my workflow on Linux - I use clang to build
> > on Ubuntu 20.04, which is not that old, but it ships with clang 12. This is
> > not a deal breaker, just annoying.
>
> That's unfortunate, but I think the [[no
On Mon, 5 Feb 2024 09:44:02 GMT, Magnus Ihse Bursie wrote:
> > Sure, you can always install a newer GCC than the system one, but it's
> > another thing that makes it harder for people to build OpenJDK. Having said
> > that, C++17 is nice to have.
>
> @theRealAph I am still just hearing hand-wa
On Thu, 15 Feb 2024 15:54:56 GMT, Magnus Ihse Bursie wrote:
> > I would like it if toolchain version bumps were discussed somewhere else
> > first, not in a PR. (And apologies if it was and I missed that discussion).
>
> Yes, it definitely was. I posted a separate [mail to
> build-dev](https:/
On Thu, 11 Jan 2024 13:23:45 GMT, Julian Waters wrote:
>> Compile the JDK as C++17, enabling the use of all C++17 language features
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Require clang 13 in toolchain.m4
Just on
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of Clang
> to be used for building OpenJDK from 3.5 to 13.
>
> This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for
> that. A minimum of Clang 13 als
On Thu, 25 Jan 2024 12:02:35 GMT, Aleksey Shipilev wrote:
> When looking at [JDK-8324647](https://bugs.openjdk.org/browse/JDK-8324647), I
> was surprised to see that GHA has this output:
>
>
> Running test 'jtreg:test/lib-test:tier1'
> /home/runner/work/jdk/jdk/test/lib-test/TEST.groups: group
On Fri, 15 Dec 2023 16:20:02 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Tue, 28 Nov 2023 18:15:56 GMT, Aleksey Shipilev wrote:
> In current GHA, `hotspot_compiler` testing takes a long time, and often takes
> the longest. On MacOS and Windows it routinely takes 60..80 minutes, while
> other test groups run in 30..40 minutes. This often drags the total wall
> cl
On Fri, 24 Nov 2023 09:51:07 GMT, Daniel Jeliński wrote:
>> test/failure_handler/src/share/conf/windows.properties line 60:
>>
>>> 58:
>>> 59: native.core.app=cdb
>>> 60: native.core.args=-c ".dump /ma core.%p;qd" -p %p
>>
>> Just to double check that this is the right option. `/ma` terminates
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote:
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user mode process. *
> *
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev wrote:
>> Looking at why GHA did not catch
>> [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it
>> builds hotspot, I realized we do not configure the build with gtest, which
>> means we skip the build checks for gtest
can cause really rare but
> tricky problems when combining static assembly and C++ code (See e.g.
> JDK-8288719).
>
> I propose to always specify `-marm` as default, unless an ABI profile is
> given, to prevent such errors.
>
> Thanks to @marchof for testing this.
Thomas Stuefe
On Fri, 27 Oct 2023 11:59:59 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Wed, 1 Nov 2023 06:58:23 GMT, David Holmes wrote:
>> I've removed the goto, but would like to wait until Thomas is back
>
> No response from @tstuefe but I think the empty block is pointless and we
> should just check `if (!InterceptOSException) {`.
Sure, remove the empty block.
---
On Tue, 31 Oct 2023 08:37:44 GMT, Julian Waters wrote:
>> Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely, so
>> hadn't noticed the discussion there. Not sure why this is using a literal 0
>> rather than `(T) '\n'` as in that PR?
>>
>> So the literal "0" (or previously,
See [JDK-8288719](https://bugs.openjdk.org/browse/JDK-8288719) and subsequent
[discussion](https://mail.openjdk.org/pipermail/build-dev/2022-May/034635.html)
back in 2022.
On Arm, we can generate either arm- or thumb-code (`-marm` or `-mthumb`).
At the moment, if we don't specify an ABI profil
On Fri, 27 Oct 2023 11:49:16 GMT, Andrew Haley wrote:
> > One more thought, it would be good to add the FTZ_mode_enabled check to
> > `os::run_periodic_checks()`.
> > We already do signal handler checks there, and it is the right place to
> > check for "global things third party native code may
On Thu, 26 Oct 2023 14:17:02 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Thu, 26 Oct 2023 14:17:02 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Mon, 9 Oct 2023 10:21:58 GMT, Frederic Thevenet
wrote:
>> When building OpenJDK on Windows using "--with-native-debug-info=external",
>> the resulting debug symbols are saved in files located in the same folder as
>> the corresponding executable or library and named by swapping the extensio
On Wed, 11 Oct 2023 17:20:18 GMT, Andrew Haley wrote:
>> src/hotspot/os/bsd/os_bsd.cpp line 976:
>>
>>> 974: // same architecture as Hotspot is running on
>>> 975:
>>> 976: void *os::Bsd::dlopen_helper(const char *filename, int mode) {
>>
>> I thought BSD is switching to clang.
>
> What differ
On Wed, 11 Oct 2023 13:36:01 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Wed, 11 Oct 2023 13:38:57 GMT, Andrew Haley wrote:
> > I'm seeing one automated test failure on Linux x86, which I don't
> > understand because I've excluded that test for generic-i586. If anyone
> > understands this, please shout up.
>
> For avoidance of doubt, the test doesn't run locally
On Wed, 11 Oct 2023 02:18:15 GMT, Julian Waters wrote:
> Once integrated, this is going to spam everyone on GitHub with Windows test
> failures until the issue is fixed separately :/ (Could we perhaps split the
> test out into another change?)
I don't think @fthevenet plans on checking in a br
1 - 100 of 190 matches
Mail list logo