[libcxx] r268709 - Fix errors in documentation

Author: ericwf Date: Thu May 5 23:49:30 2016 New Revision: 268709 URL: http://llvm.org/viewvc/llvm-project?rev=268709&view=rev Log: Fix errors in documentation Modified: libcxx/trunk/docs/UsingLibcxx.rst Modified: libcxx/trunk/docs/UsingLibcxx.rst URL: http://llvm.org/viewvc/llvm-project/l

[libclc] r268708 - math: Add fdim implementation

Author: awatry Date: Thu May 5 22:34:45 2016 New Revision: 268708 URL: http://llvm.org/viewvc/llvm-project?rev=268708&view=rev Log: math: Add fdim implementation Based on the amd-builtin, but explicitly vectorized for all sizes (not just float4), and includes a vectorized double implementation.

[PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

flx created this revision. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. Also trigger the check in the following case: void foo() { ExpensiveToCopy Obj; const auto UnnecessaryCopy = Obj.constReference(); Obj.onlyUsedAsConst(); } i.e. when the obj

Re: [PATCH] D19865: [clang-tidy] - PerformanceUnnecesaryCopyInitialization - only trigger for decl stmts with single VarDecl.

flx added a comment. In http://reviews.llvm.org/D19865#419905, @flx wrote: > In http://reviews.llvm.org/D19865#419830, @alexfh wrote: > > > Is it a workaround to avoid breaking the code by incorrect fixes? > > > Yes. We can't simply change the type of DeclStmt when we only look one of the > VarD

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after the minor fixes. Thank you for the patch. Comment at: include/__threading_support:38 @@ +37,3 @@ +{ +pthread_mutexattr_t attr; +int ec = pthread_mutexattr_i

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. Attach a new patch with the comments Comment at: lib/CodeGen/BackendUtil.cpp:799-831 @@ +798,35 @@ + // Embed the bitcode for the llvm module. + std::string Data; + ArrayRef ModuleData; + Triple T(M->getTargetTriple()); + if (CGOpts.getEmbedBitcod

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 56371. steven_wu marked 2 inline comments as done. steven_wu added a comment. Add comments to address the feedback fromt the review. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/cl

Re: [PATCH] D19993: Fixed cppcoreguidelines-pro-type-member-init when checking records with indirect fields

On Thu, May 5, 2016 at 4:44 PM, Michael Miller via cfe-commits < cfe-commits@lists.llvm.org> wrote: > michael_miller added inline comments. > > > Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:31 > @@ +30,3 @@ > +// Convenience utility to get a RecordDecl from

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

rsmith added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:799-831 @@ +798,35 @@ + // Embed the bitcode for the llvm module. + std::string Data; + ArrayRef ModuleData; + Triple T(M->getTargetTriple()); + if (CGOpts.getEmbedBitcode() != CodeGenOptions::Embed_Marker)

Re: [PATCH] D19993: Fixed cppcoreguidelines-pro-type-member-init when checking records with indirect fields

michael_miller added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:31 @@ +30,3 @@ +// Convenience utility to get a RecordDecl from a QualType. +const RecordDecl *getCanonicalRecordDecl(const QualType &Type) { + if (const auto *RT = Type.getC

Re: [PATCH] D19993: Fixed cppcoreguidelines-pro-type-member-init when checking records with indirect fields

alexfh added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:31 @@ +30,3 @@ +// Convenience utility to get a RecordDecl from a QualType. +const RecordDecl *getCanonicalRecordDecl(const QualType &Type) { + if (const auto *RT = Type.getCanonical

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu updated this revision to Diff 56367. steven_wu added a comment. Format update according to review. http://reviews.llvm.org/D17392 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def include/clang/Frontend/CodeGen

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:769-770 @@ +768,4 @@ +void clang::EmbedBitcode(llvm::Module *M, const CodeGenOptions &CGOpts, + llvm::MemoryBufferRef Buf) +{ + if (CGOpts.getEmbedBitcode() == CodeGenOptions::Embed_O

Re: [PATCH] D19829: [scan-build] fix dead store warnings emitted on clang code base

rtrieu added inline comments. Comment at: lib/Sema/SemaExpr.cpp:9629 @@ -9628,3 +9628,3 @@ // Track if the current expression is the result of a derefence, and if the // next checked expression is the result of a derefence. bool IsDereference = false; Add

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

rsmith added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:769-770 @@ +768,4 @@ +void clang::EmbedBitcode(llvm::Module *M, const CodeGenOptions &CGOpts, + llvm::MemoryBufferRef Buf) +{ + if (CGOpts.getEmbedBitcode() == CodeGenOptions::Embed_Off)

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

rsmith added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:235 @@ +234,3 @@ +UndefinedBehaviorSanitizer adds static check data for each check unless it is +in trap mode. This check data includes the full file name. option +``-fsanitize-undefined-strip-path-compo

Re: [PATCH] D19996: New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE

On Thu, May 5, 2016 at 2:31 PM, Rafael Espíndola wrote: > Is there a gcc option or they just assume they are targeting the > linker that was around when gcc was built? It is done at configure time, the linker is checked for copy relocations support. I recently saw a request to replace this with

Re: [PATCH] D19996: New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE

Is there a gcc option or they just assume they are targeting the linker that was around when gcc was built? > + if (Args.hasFlag(options::OPT_mpiecopyrelocs, > options::OPT_mno_piecopyrelocs, > + false)) { > +CmdArgs.push_back("-piecopyrelocs"); > + } you don't need the

[PATCH] D19996: New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE

tmsriram created this revision. tmsriram added a reviewer: rnk. tmsriram added subscribers: cfe-commits, davidxl, rafael. With linker copy relocations, PIE can generate better code for external global variable accesses. This patch adds a new option to clang to specify this. Please see http://

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

rtrieu added inline comments. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); dblaikie wrote: > Should this be a condition, or just an assertion?

r268685 - [CMake] Removing LLVM_ENABLE_TIMESTAMPS from the cache files

Author: cbieneman Date: Thu May 5 16:08:41 2016 New Revision: 268685 URL: http://llvm.org/viewvc/llvm-project?rev=268685&view=rev Log: [CMake] Removing LLVM_ENABLE_TIMESTAMPS from the cache files Since the option was removed in r268670, the cache scripts should stop referring to it. Modified:

Re: [PATCH] D19902: [ProfileData] (clang) Use Error in InstrProf and Coverage

vsk updated this revision to Diff 56346. vsk added a comment. - Handle an ECError we can see come out of opening a memory buffer. http://reviews.llvm.org/D19902 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenPGO.cpp lib/Frontend/CompilerInvocation.cpp Index: lib/Frontend/Compile

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

yaxunl added inline comments. Comment at: lib/Sema/SemaCast.cpp:2317 @@ +2316,3 @@ +// OpenCL v2.0 s6.13.10 - Allow casts from '0' to event_t type. +if (Self.getLangOpts().OpenCL && DestType->isEventT()) { + llvm::APSInt intValue; yaxunl wrote: > tste

Re: [PATCH] D19990: [CUDA] Implement __ldg using intrinsics.

jlebar added inline comments. Comment at: include/clang/Basic/BuiltinsNVPTX.def:569-603 @@ -568,1 +568,37 @@ +// __ldg. This is not implemented as a builtin by nvcc. +BUILTIN(__nvvm_ldg_c, "ccC*", "") +BUILTIN(__nvvm_ldg_s, "ssC*", "") +BUILTIN(__nvvm_ldg_i, "iiC*", "") +BUILTI

Re: [PATCH] D19990: [CUDA] Implement __ldg using intrinsics.

jlebar added inline comments. Comment at: include/clang/Basic/BuiltinsNVPTX.def:569-603 @@ -568,1 +568,37 @@ +// __ldg. This is not implemented as a builtin by nvcc. +BUILTIN(__nvvm_ldg_c, "ccC*", "") +BUILTIN(__nvvm_ldg_s, "ssC*", "") +BUILTIN(__nvvm_ldg_i, "iiC*", "") +BUILTI

[PATCH] D19993: Fixed cppcoreguidelines-pro-type-member-init when checking records with indirect fields

michael_miller created this revision. michael_miller added reviewers: hokein, aaron.ballman, alexfh. michael_miller added a subscriber: cfe-commits. Fixed a crash in cppcoreguidelines-pro-type-member-init when checking record types with indirect fields pre-C++11. Fixed handling of indirect fields

Re: [PATCH] D19990: [CUDA] Implement __ldg using intrinsics.

majnemer added a subscriber: majnemer. Comment at: include/clang/Basic/BuiltinsNVPTX.def:569-603 @@ -568,1 +568,37 @@ +// __ldg. This is not implemented as a builtin by nvcc. +BUILTIN(__nvvm_ldg_c, "ccC*", "") +BUILTIN(__nvvm_ldg_s, "ssC*", "") +BUILTIN(__nvvm_ldg_i, "iiC*", ""

[PATCH] D19992: [libcxx] Prefer C++14 over C++11 when building libc++experimental.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Currently libc++experimental builds with C++11. This patch changes that to C++14 when supported by the compiler. Although nothing currently requires C++14 the upcoming implementation woul

r268674 - Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings.

Author: eugenezelenko Date: Thu May 5 15:15:31 2016 New Revision: 268674 URL: http://llvm.org/viewvc/llvm-project?rev=268674&view=rev Log: Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings. Differential revision: http://reviews.llvm.org/D19947 Modified:

Re: [PATCH] D19947: [Clang] Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL268674: Fix some Clang-tidy readability-simplify-boolean-expr and Include What You… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D19947?vs=56226&id=56337#toc Repositor

Re: [PATCH] D19959: [scan-build] fix warning emitted on Clang Driver code baseFix a "logic error" warning of the type Called c++ object pointer isnull" reported by Clang Static Analyzer on the file:-

Apelete Seketeli via cfe-commits writes: > apelete created this revision. > apelete added reviewers: kevin.qin, rsmith. > apelete added a subscriber: cfe-commits. > > Signed-off-by: Apelete Seketeli > > http://reviews.llvm.org/D19959 > > Files: > lib/Driver/Tools.cpp > > Index: lib/Driver/Tools

[PATCH] D19990: [CUDA] Implement __ldg using intrinsics.

jlebar created this revision. jlebar added reviewers: tra, rsmith. jlebar added subscribers: cfe-commits, jhen. Herald added a subscriber: jholewinski. Previously it was implemented as inline asm in the CUDA headers. This change allows us to use the [addr+imm] addressing mode when executing ld.gl

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

jfb added inline comments. Comment at: lib/Transforms/IPO/MergeFunctions.cpp:147 @@ -146,3 +146,3 @@ struct Config : ValueMapConfig { -enum { FollowRAUW = false }; +enum { FollowRAUW = 0 }; }; This change should go to ValueMap, I think it should be m

r268665 - Add forgotten test from r268594.

Author: rsmith Date: Thu May 5 14:16:58 2016 New Revision: 268665 URL: http://llvm.org/viewvc/llvm-project?rev=268665&view=rev Log: Add forgotten test from r268594. Added: cfe/trunk/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p7.cpp Added: cfe/trunk/test/CXX/dcl.dcl/basic.namespace/nam

r268664 - Add a FixItHint for the new diagnostic for a non-class-scope using-declaration that names a class-scope enumerator.

Author: rsmith Date: Thu May 5 14:16:15 2016 New Revision: 268664 URL: http://llvm.org/viewvc/llvm-project?rev=268664&view=rev Log: Add a FixItHint for the new diagnostic for a non-class-scope using-declaration that names a class-scope enumerator. Modified: cfe/trunk/include/clang/Basic/Dia

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Quuxplusone added a subscriber: Quuxplusone. Quuxplusone added a comment. It seems like this proposed diagnostic and fixit, statistically speaking, is *never* correct. In the cases where there is a code issue to be corrected, the diagnosable issue really seems to involve dataflow analysis: "Her

r268663 - Some release note updates for C++ language acceptance changes since Clang 3.8.

Author: rsmith Date: Thu May 5 13:40:37 2016 New Revision: 268663 URL: http://llvm.org/viewvc/llvm-project?rev=268663&view=rev Log: Some release note updates for C++ language acceptance changes since Clang 3.8. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.

Re: r268594 - Fix implementation of C++'s restrictions on using-declarations referring to enumerators:

On Thu, May 5, 2016 at 11:21 AM, Reid Kleckner wrote: > On Thu, May 5, 2016 at 11:15 AM, Richard Smith > wrote: > >> Given that GCC rejects this code (and has done for as long as it's >> accepted the Enum::Member syntax), I don't expect the problems to be too >> widespread. If they are, we could

Re: [PATCH] D19754: Allow 'nodebug' on local variables

On Thu, May 5, 2016 at 8:50 AM, Robinson, Paul wrote: > This would be a great conversation to have at the social, sadly I will > have to miss it this month. > Yeah, I don't often make it along to them, unfortunately. > > >> dblaikie wrote: > >>> Doesn't look like the const case is any differen

[clang-tools-extra] r268659 - [Documentation] List Clang-tidy checks alphabetically.

Author: eugenezelenko Date: Thu May 5 13:25:53 2016 New Revision: 268659 URL: http://llvm.org/viewvc/llvm-project?rev=268659&view=rev Log: [Documentation] List Clang-tidy checks alphabetically. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-extra/tru

Re: r268594 - Fix implementation of C++'s restrictions on using-declarations referring to enumerators:

On Thu, May 5, 2016 at 11:15 AM, Richard Smith wrote: > Given that GCC rejects this code (and has done for as long as it's > accepted the Enum::Member syntax), I don't expect the problems to be too > widespread. If they are, we could trivially accept this as an extension; it > seems like a pointl

Re: r268594 - Fix implementation of C++'s restrictions on using-declarations referring to enumerators:

On Thu, May 5, 2016 at 10:40 AM, Reid Kleckner wrote: > FYI, this change broke bionic, which has this exact pattern: > > https://android.googlesource.com/platform/bionic/+/master/tools/relocation_packer/src/debug.h#84 > > struct A { > enum E { > X = 3 > }; > }; > typedef A::E T; > using T

Re: [PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

dblaikie added a subscriber: dblaikie. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300 @@ -299,2 +299,3 @@ + assert(SM && "SourceManager is NULL, cannot iterate through the diagnostics"); This assertion seems to be equivalent to replacing the pr

Re: [PATCH] D19959: [scan-build] fix warning emitted on Clang Driver code baseFix a "logic error" warning of the type Called c++ object pointer isnull" reported by Clang Static Analyzer on the file:-

Should this be a test, or just an assertion? On Thu, May 5, 2016 at 2:34 AM, Apelete Seketeli via cfe-commits < cfe-commits@lists.llvm.org> wrote: > apelete created this revision. > apelete added reviewers: kevin.qin, rsmith. > apelete added a subscriber: cfe-commits. > > Signed-off-by: Apelete S

Re: [PATCH] D19960: [scan-build] fix warnings emitted on Clang CodeGen code base

dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1317 @@ -1316,2 +1316,3 @@ } + assert(V && "constant must be not NULL at this point"); TemplateParams.push_back(DBuilder.createTemplateValueParameter( It looks like this ass

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

dblaikie added a subscriber: dblaikie. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); Should this be a condition, or just an assertion?

Re: r268594 - Fix implementation of C++'s restrictions on using-declarations referring to enumerators:

FYI, this change broke bionic, which has this exact pattern: https://android.googlesource.com/platform/bionic/+/master/tools/relocation_packer/src/debug.h#84 struct A { enum E { X = 3 }; }; typedef A::E T; using T::X; I expect users are going to have lots of issues with this, and it proba

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added a comment. "pi" clangclang "ng" http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D19918: AMDGPU/SI: Use amdgpu_kernel calling convention for OpenCL kernels.

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

szdominik added a comment. I think the main success is that we don't warn here: const char* A[2] = {"a", "b" "c"); The problem is, as you said, not remove already supported cases (such as when the parent is not a vardecl (but also an initListExpr)). But I'll implement, and we'll see it. htt

Re: [PATCH] D19952: AMDGPU: Use lld as the linker again

This revision was automatically updated to reflect the committed changes. Closed by commit rL268648: AMDGPU: Use lld as the linker again (authored by tstellar). Changed prior to commit: http://reviews.llvm.org/D19952?vs=56231&id=56307#toc Repository: rL LLVM http://reviews.llvm.org/D19952

r268648 - AMDGPU: Use lld as the linker again

Author: tstellar Date: Thu May 5 12:03:41 2016 New Revision: 268648 URL: http://llvm.org/viewvc/llvm-project?rev=268648&view=rev Log: AMDGPU: Use lld as the linker again Summary: Now that LLVM is emitting version 2 of the AMD code object, we can start using lld again for linking instead of our c

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r268642 - [CMake][Apple-stage2] Don't link with -fno-pie

Author: cbieneman Date: Thu May 5 11:31:28 2016 New Revision: 268642 URL: http://llvm.org/viewvc/llvm-project?rev=268642&view=rev Log: [CMake][Apple-stage2] Don't link with -fno-pie On Darwin the default is to build PIC and link PIE. We shouldn't need to override that in the Apple Clang distrib

Re: [PATCH] D19952: AMDGPU: Use lld as the linker again

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D19952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D19947: [Clang] Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm nice improvement with getFlag()! Repository: rL LLVM http://reviews.llvm.org/D19947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19979: [analyzer] ScopeContext - initial implementation

a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, dcoughlin, bshastry. a.sidorin added a subscriber: cfe-commits. This patch enables ScopeContext to track variable lifetime. It is RFC mostly since the work on its dependencies is still not finished and it lacks some tests. Pr

r268637 - [Hexagon] Add a testcase for __builtin_HEXAGON_A2_tfrpi

Author: kparzysz Date: Thu May 5 10:55:54 2016 New Revision: 268637 URL: http://llvm.org/viewvc/llvm-project?rev=268637&view=rev Log: [Hexagon] Add a testcase for __builtin_HEXAGON_A2_tfrpi Modified: cfe/trunk/test/CodeGen/builtins-hexagon.c Modified: cfe/trunk/test/CodeGen/builtins-hexagon

Re: [PATCH] D17820: Clang Code Completion Filtering

benlangmuir added a comment. LGTM with one comment about the doxygen comments, but you should probably wait to hear from @akyrtzi too. Comment at: include/clang/Sema/CodeCompleteConsumer.h:916 @@ +915,3 @@ + /// \name Code-completion filtering + //@{ + /// \brief Check if th

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM FYI, we will also want to update `getAddrOfCXXCatchHandler` and `getThrowInfo` to correctly handle `__unaligned`. http://reviews.llvm.org/D19654 _

RE: [PATCH] D19754: Allow 'nodebug' on local variables

This would be a great conversation to have at the social, sadly I will have to miss it this month. >> dblaikie wrote: >>> Doesn't look like the const case is any different from the non-const >>> case, is it? >> Given a white-box analysis of the compiler internals, you are correct; >> this is in co

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

etienneb added a comment. In http://reviews.llvm.org/D19769#422317, @szdominik wrote: > The original size is available - but from the decleration, not from the > initListExpr. Let do the copy paste (correctly): clang-query> match namedDecl(hasName("listA")) Match #1: Binding for "

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

sbenza added inline comments. Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102 @@ +101,3 @@ + static clang::CastKind getCastKind(llvm::StringRef AttrKind) { +return llvm::StringSwitch(AttrKind) + .Case("CK_Dependent", CK_Dependent) etienneb wrote: >

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

filcab updated this revision to Diff 56289. filcab added a comment. Improve Windows support http://reviews.llvm.org/D19666 Files: docs/UndefinedBehaviorSanitizer.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGExpr.cpp lib/Driver/Tools.cpp

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

yaxunl added a comment. In http://reviews.llvm.org/D19932#421961, @pxli168 wrote: > Could we output a generic function in CodeGen? > This seems to have no big difference to have a lot of declaration in an > opencl c header file. What return type and argument type to use would you suggest for

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added a comment. In http://reviews.llvm.org/D18369#421963, @pxli168 wrote: > If we want to save some space, could we use some macro to expand the gentype > or some script to expand the gentype into each types when the clang is build? We need to balance between space and readability. Whe

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

szdominik added a comment. The original size is available - but from the decleration, not from the initListExpr. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:106 @@ +105,3 @@ + if (InitializerList->hasArrayFiller()) { + diag(InitializerList->getExprLoc(), +

[PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The second check failed, the initializer wasn't renamed. http://reviews.llvm.org/D19957 Files: clang-rename/USRLocFinder.cpp test/clang-rename/FieldTest.cpp Index: test/clang-rename/FieldTest.cpp ==

Re: [PATCH] D16962: clang-tidy: avoid std::bind

Modernize it is then. The check currently only catches std::bind but further work can address that. Jon > On 4 May 2016, at 22:40, Arthur O'Dwyer wrote: > >> On Wed, May 4, 2016 at 1:43 PM, Aaron Ballman via cfe-commits >> wrote: >> jbcoe wrote: >> > aaron.ballman wrote: >> > > I believe we

Re: [PATCH] D19952: AMDGPU: Use lld as the linker again

rafael added a subscriber: rafael. rafael added a comment. lgtm http://reviews.llvm.org/D19952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16962: clang-tidy: avoid std::bind

jbcoe removed a reviewer: djasper. jbcoe updated this revision to Diff 56273. jbcoe added a comment. Move to modernize. Rename to `avoid-bind` as a later patch will add support for `boost::bind`, `std::bind1st` etc. http://reviews.llvm.org/D16962 Files: clang-tidy/modernize/AvoidBindCheck.cp

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

filcab added a comment. In http://reviews.llvm.org/D19666#422150, @ygribov wrote: > Can we have generic option for other sanitizers? Do other sanitizers emit paths this way? For ASan, for example, we end up emitting them only when there are global constructors involved, where we'd emit an __as

r268625 - Add a test for PR26076.

Author: nico Date: Thu May 5 06:51:22 2016 New Revision: 268625 URL: http://llvm.org/viewvc/llvm-project?rev=268625&view=rev Log: Add a test for PR26076. r262056 accidentally fixed this. Add a test to ensure it doesn't regress. Modified: cfe/trunk/test/CodeGenCXX/dllexport.cpp Modified: c

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

ygribov added a subscriber: ygribov. ygribov added a comment. Can we have generic option for other sanitizers? http://reviews.llvm.org/D19666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

filcab updated this revision to Diff 56262. filcab added a comment. Remove .data() call http://reviews.llvm.org/D19666 Files: docs/UndefinedBehaviorSanitizer.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGExpr.cpp lib/Driver/Tools.cpp lib

Re: [PATCH] D19667: [ubsan] Minimize size of data for type_mismatch

filcab updated this revision to Diff 56261. filcab added a comment. Update catch-undef-behavior.c http://reviews.llvm.org/D19667 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/catch-undef-behavior.c Index: test/CodeGen/catch-undef-behavior.c

[PATCH] D19963: [scan-build] fix warnings emitted on Clang Frontend code baseFix "Logic error" warnings of the type "Called C++ object pointer isnull" reported by Clang Static Analyzer on the followin

apelete created this revision. apelete added reviewers: akyrtzi, rsmith. apelete added a subscriber: cfe-commits. Signed-off-by: Apelete Seketeli http://reviews.llvm.org/D19963 Files: lib/Frontend/CompilerInstance.cpp Index: lib/Frontend/CompilerInstance.cpp =

Re: [Diffusion] rL268585: [modules] Enforce the rules that an explicit or partial specialization must be

chapuni added subscribers: cfe-commits, chapuni. /cfe/trunk/include/clang/Sema/Sema.h:1898 This method doesn't return anything. Tweaked in r268621. [-Wdocumentation] Users: rsmith (Author) http://reviews.llvm.org/rL268585 ___ cfe-commits mailing

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 56259. apelete added a comment. [scan-build] fix warnings emitted on Clang Format code base Changes since last revision: - split patch into Format unit to ease review process. http://reviews.llvm.org/D19385 Files: lib/Format/AffectedRangeManager.cpp l

r268621 - Sema.h: Prune a redundant \return. [-Wdocumentation]

Author: chapuni Date: Thu May 5 05:29:11 2016 New Revision: 268621 URL: http://llvm.org/viewvc/llvm-project?rev=268621&view=rev Log: Sema.h: Prune a redundant \return. [-Wdocumentation] Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

andreybokhanko added a comment. David, just noticed that your first question doesn't have a redefinition. For this program: __unaligned int unaligned_foo3() { return 0; } auto z = unaligned_foo3(); Both MS and us mangle z the same: ?z@@3HA Yours, Andrey http://reviews.llvm.org/D19654 ___

[PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

apelete created this revision. apelete added a reviewer: zaks.anna. apelete added a subscriber: cfe-commits. This patch fixes a few "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the following files: - lib/StaticAnalyzer/Checkers/Nullab

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

andreybokhanko marked an inline comment as done. Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584 @@ -1579,2 +1582,4 @@ case QMM_Result: +// Presence of __unaligned qualifier shouldn't affect mangling here. +Quals.removeUnaligned(); if ((!IsPointer && Quals) || is

[PATCH] D19960: [scan-build] fix warnings emitted on Clang CodeGen code base

apelete created this revision. apelete added reviewers: dblaikie, pcc. apelete added a subscriber: cfe-commits. Fix "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the following files: - lib/CodeGen/CGDebugInfo.cpp, - lib/CodeGen/CodeGen

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 56253. apelete added a comment. [scan-build] fix warnings emitted on Clang Sema code base Changes since last revision: - split patch into Sema changes unit to ease review process, - cherry-pick Sema changes from http://reviews.llvm.org/D19084, - cherry-pick

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek added a comment. Updated the diff with changes http://reviews.llvm.org/D19105 http://reviews.llvm.org/D18821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Prazek updated this revision to Diff 56250. Prazek added a comment. Herald added a reviewer: tstellarAMD. Herald added subscribers: jfb, mzolotukhin, dsanders, arsenm, MatzeB. It seems that is doing it's work right now. I will have to change some places to post it to llvm like: - changing functi

[PATCH] D19959: [scan-build] fix warning emitted on Clang Driver code baseFix a "logic error" warning of the type Called c++ object pointer isnull" reported by Clang Static Analyzer on the file:- lib/

apelete created this revision. apelete added reviewers: kevin.qin, rsmith. apelete added a subscriber: cfe-commits. Signed-off-by: Apelete Seketeli http://reviews.llvm.org/D19959 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp =

Re: [PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete updated this revision to Diff 56248. apelete added a comment. [scan-build] fix warnings emitted on Clang AST code base Changes since last revision: - split patch into AST changes unit to ease review process. http://reviews.llvm.org/D19084 Files: lib/AST/ASTDiagnostic.cpp lib/AST/D

r268618 - [OPENMP 4.5] Codegen for 'lastprivate' clauses in 'taskloop' directives.

Author: abataev Date: Thu May 5 03:46:22 2016 New Revision: 268618 URL: http://llvm.org/viewvc/llvm-project?rev=268618&view=rev Log: [OPENMP 4.5] Codegen for 'lastprivate' clauses in 'taskloop' directives. OpenMP 4.5 adds taskloop/taskloop simd directives. These directives allow to use lastpriva

[libcxx] r268614 - Fix sphinx build. This is a temporary solution.

Author: ericwf Date: Thu May 5 03:12:25 2016 New Revision: 268614 URL: http://llvm.org/viewvc/llvm-project?rev=268614&view=rev Log: Fix sphinx build. This is a temporary solution. Modified: libcxx/trunk/docs/TestingLibcxx.rst Modified: libcxx/trunk/docs/TestingLibcxx.rst URL: http://llvm.o