rnkovacs updated this revision to Diff 152627.
rnkovacs marked an inline comment as done.
rnkovacs added a comment.
Fixed variable name inside the visitor.
I also clang-formatted the file, sorry for any line number shifting.
https://reviews.llvm.org/D48522
Files:
lib/StaticAnalyzer/Checkers/A
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov, dcoughlin.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
+ Cleaned up test file a bit.
Repository:
rC Clang
https://reviews.llvm.org/D48532
Fil
balazske updated this revision to Diff 152632.
balazske added a comment.
[ASTImporter] Fixed test code in ASTImporter tests.
Reformatted some test code, changed to use isDescendant.
Repository:
rC Clang
https://reviews.llvm.org/D47459
Files:
unittests/AST/ASTImporterTest.cpp
Index: unitt
balazske marked 2 inline comments as done.
balazske added a comment.
Some of the source code was reformatted for more consistency. At least a part
of the code is now better formatted.
Repository:
rC Clang
https://reviews.llvm.org/D47459
___
cfe-
r.stahl updated this revision to Diff 152633.
r.stahl marked 5 inline comments as done.
r.stahl added a comment.
improved code quality; added nested macro test. it "works", but is disabled
because it revealed another bug: the function end location is not imported.
will send a patch
Repository:
r.stahl marked an inline comment as done.
r.stahl added inline comments.
Comment at: lib/AST/ASTImporter.cpp:7058
+const SrcMgr::ExpansionInfo &FromEx = FromSLoc.getExpansion();
+SourceLocation ToSpLoc = Import(FromEx.getSpellingLoc());
+SourceLocation ToExLocS = Impo
balazske updated this revision to Diff 152634.
balazske added a comment.
Small fixes.
Repository:
rC Clang
https://reviews.llvm.org/D47450
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/injected-class-name-decl/Inputs/inject1.cpp
test/ASTMerge/injected-class-name-decl/Inputs/inject2.cpp
ioeric updated this revision to Diff 152636.
ioeric marked an inline comment as done.
ioeric added a comment.
- Add DefaultFallbackStyle
Repository:
rC Clang
https://reviews.llvm.org/D48492
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
tools/clang-format/ClangFormat.cpp
ioeric added inline comments.
Comment at: tools/clang-format/ClangFormat.cpp:67
static cl::opt
FallbackStyle("fallback-style",
cl::desc("The name of the predefined style used as a\n"
sammccall wrote:
> My only question is if we want to do the sam
chill added a comment.
In https://reviews.llvm.org/D46013#1140336, @t.p.northover wrote:
> I'm fine with the ABI changes, but I'm not very convinced by the
> "NaturalAlignment" name.
I'd rather not put target names in API functions. The meaning of that field is
pretty target
independent ("ali
chill added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:5055
+ Alignment = getContext().getTypeNaturalAlign(Ty);
+ Alignment = std::min(std::max(Alignment, 64u), 128u);
+} else {
t.p.northover wrote:
> I think the max/min logic is more c
t.p.northover added a comment.
> I'd rather not put target names in API functions. The meaning of that field
> is pretty target independent ("alignment of type, before alignment
> adjustments")
Except that rule only applies to aggregates. Scalar types get their alignment
adjusted anyway I beli
krasimir created this revision.
Herald added a subscriber: cfe-commits.
The case of end-of-file comments was formatted badly:
key: value
# end-of-file comment
This patch fixes that formatting:
key: value
# end-of-file comment
Repository:
rC Clang
https://reviews.llvm.org/D48539
ank added a comment.
Is there any chance to get this change or a similar one in so we get same
behaviour as in release_40, even though it does not correct all of the problems?
Repository:
rC Clang
https://reviews.llvm.org/D45719
___
cfe-commits
Author: krasimir
Date: Mon Jun 25 04:08:24 2018
New Revision: 335449
URL: http://llvm.org/viewvc/llvm-project?rev=335449&view=rev
Log:
[clang-format] Fix end-of-file comments text proto formatting
Summary:
The case of end-of-file comments was formatted badly:
```
key: value
# end-of-file comm
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335449: [clang-format] Fix end-of-file comments text proto
formatting (authored by krasimir, committed by ).
Herald added
klimek added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
ank wrote:
> klimek wrote:
> > What would be interesting is tests that:
> > a) have another val
martong updated this revision to Diff 152660.
martong marked 2 inline comments as done.
martong added a comment.
- Clang format the test code snippet.
Repository:
rC Clang
https://reviews.llvm.org/D47534
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
==
Author: martong
Date: Mon Jun 25 04:38:43 2018
New Revision: 335455
URL: http://llvm.org/viewvc/llvm-project?rev=335455&view=rev
Log:
[ASTImporter] Add new tests about templated-described swing
Summary:
Add a new test about importing a partial specialization (of a class). Also,
this patch adds n
hans updated this revision to Diff 152659.
hans added a comment.
Added special-casing for explicit template instantiations, and missing test
case suggested by Nico.
Please take another look.
https://reviews.llvm.org/D48426
Files:
include/clang/AST/ExternalASTSource.h
include/clang/Basic/L
martong added a comment.
I addressed the comments, thanks for the review!
Repository:
rC Clang
https://reviews.llvm.org/D47534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335455: [ASTImporter] Add new tests about
templated-described swing (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47534
F
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
Author: ioeric
Date: Mon Jun 25 04:50:11 2018
New Revision: 335458
URL: http://llvm.org/viewvc/llvm-project?rev=335458&view=rev
Log:
[clangd] Always remove dots before converting paths to URIs in symbol collector.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: c
yamaguchi updated this revision to Diff 152664.
yamaguchi added a comment.
use %clang_cc1 instead of %clang
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
clang/test/Modules/In
ebevhan added a comment.
Would it be possible to add some form of target hook (perhaps to
CodeGenABIInfo, which is already accessed with `getTargetHooks`) for
fixed-point operations (maybe even some conversions)? As I've mentioned
earlier, we emit both IR and intrinsics for many of these operat
thakis added a comment.
Still looks good, ship it! One more suggestion about additional test coverage
(but maybe it's already there and I'm just missing it).
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template void __declspec(dllexport)
explicitInstantiationDefAfterDecl(
aaron.ballman added inline comments.
Comment at: clang-tidy/cert/CERTTidyModule.cpp:44
"cert-dcl54-cpp");
-CheckFactories.registerCheck(
-"cert-dcl58-cpp");
+
CheckFactories.registerCheck("cert-dcl58-cpp");
CheckFactories.registerCheck(
-
aaron.ballman added inline comments.
Herald added a subscriber: the_o.
Comment at: lib/Sema/SemaDeclAttr.cpp:5280
+ // Check the attribute arguments.
+ if (AL.getNumArgs() > 1) {
+S.Diag(AL.getLoc(), diag::err_attribute_too_many_arguments)
apazos wrote:
> a
krasimir created this revision.
Herald added a subscriber: cfe-commits.
In C++ code snippets of the form `@field` are common. This makes clang-format
keep them together in text protos, whereas before it would break them.
Repository:
rC Clang
https://reviews.llvm.org/D48543
Files:
lib/Forma
Author: krasimir
Date: Mon Jun 25 05:43:12 2018
New Revision: 335459
URL: http://llvm.org/viewvc/llvm-project?rev=335459&view=rev
Log:
[clang-format] Keep @message together in text protos
Summary:
In C++ code snippets of the form `@field` are common. This makes clang-format
keep them together in
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335459: [clang-format] Keep @message together in text protos
(authored by krasimir, committed by ).
Changed prior to comm
hans added inline comments.
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template void __declspec(dllexport)
explicitInstantiationDefAfterDecl(T) {}
+extern template void explicitInstantiationDefAfterDecl(int);
+
thakis wrote:
> This has two interesting cases
ank added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
klimek wrote:
> ank wrote:
> > klimek wrote:
> > > What would be interesting is tests that:
> > >
thakis added inline comments.
Comment at: test/CodeGen/pch-dllexport.cpp:55
+template void __declspec(dllexport)
explicitInstantiationDefAfterDecl(T) {}
+extern template void explicitInstantiationDefAfterDecl(int);
+
hans wrote:
> thakis wrote:
> > This has two
martong updated this revision to Diff 152674.
martong added a comment.
- Update commit comment and fix broken format in a comment.
Repository:
rC Clang
https://reviews.llvm.org/D47367
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/Language.cpp
unittests/AST/Language.h
Index: u
Author: martong
Date: Mon Jun 25 06:04:37 2018
New Revision: 335464
URL: http://llvm.org/viewvc/llvm-project?rev=335464&view=rev
Log:
[ASTImporter] Add ms compatibility to tests which use the TestBase
Summary:
In order to avoid build failures on MS, we use -fms-compatibility too in
the tests whic
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335464: [ASTImporter] Add ms compatibility to tests which
use the TestBase (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47367?vs=152674&id=152675#toc
Reposit
Author: hans
Date: Mon Jun 25 06:23:49 2018
New Revision: 335466
URL: http://llvm.org/viewvc/llvm-project?rev=335466&view=rev
Log:
[clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)
With MSVC, PCH files are created along with an object file that needs to
be linked into
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335466: [clang-cl] Don't emit dllexport inline
functions etc. from pch files (PR37801) (authored by hans, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48426
Files:
include/clang/AS
chill updated this revision to Diff 152679.
chill added a comment.
Update: use "unadjusted alignment" instead of "natural alignment", rename
things accordingly.
https://reviews.llvm.org/D46013
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecordLayout.h
lib/AST/ASTContext.cpp
marco-c added a comment.
In https://reviews.llvm.org/D45454#1070884, @belleyb wrote:
> @chh I had a chance to try out your proposed changes. It's not causing us any
> trouble. In fact, `__gcov_flush()` is not even used at all (at least in LLVM
> 5.0.1).. I can recompile llvm, compiler_rt and cl
arichardson created this revision.
arichardson added a reviewer: atanasyan.
Herald added subscribers: cfe-commits, sdardis, emaste.
Repository:
rC Clang
https://reviews.llvm.org/D48549
Files:
lib/Basic/Targets/Mips.cpp
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Dr
erik.pilkington added a comment.
Ping! If it'd make this easier to review, I'd be happy to split this up a bit.
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. the only minor nit
Comment at: lib/Driver/ToolChains/FreeBSD.cpp:321
// back to '/usr/lib' if it doesn't exist.
- if ((Triple.getArch() == llvm::Triple::x86 |
martong updated this revision to Diff 152691.
martong marked 3 inline comments as done.
martong added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
test/AST
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:2021
+
+TEST_P(ImportFriendFunctions,
+ DISABLED_ImportFriendFunctionRedeclChainDefWithClass_ImportTheProto) {
a_sidorin wrote:
> Could you add comments why these tests are disable
Author: martong
Date: Mon Jun 25 07:41:58 2018
New Revision: 335480
URL: http://llvm.org/viewvc/llvm-project?rev=335480&view=rev
Log:
[ASTImporter] Import the whole redecl chain of functions
Summary:
With this patch when any `FunctionDecl` of a redeclaration chain is imported
then we bring in the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335480: [ASTImporter] Import the whole redecl chain of
functions (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47532?vs=152691&id=152693#toc
Repository:
rC
arichardson updated this revision to Diff 152696.
arichardson added a comment.
Ran clang-format on the diff
Repository:
rC Clang
https://reviews.llvm.org/D48549
Files:
lib/Basic/Targets/Mips.cpp
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/Arch/M
gregrodgers added a comment.
Why not provide a specific list of --hip-device-lib= for VDI builds? I am not
sure about defining functions inside headers instead of using a hip bc lib.
Repository:
rC Clang
https://reviews.llvm.org/D48455
___
cfe
labath added subscribers: aprantl, labath.
labath added a comment.
This has broken the LLDB bot
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/25132.
Could you take a look?
Repository:
rC Clang
https://reviews.llvm.org/D47532
_
Author: abataev
Date: Mon Jun 25 08:32:05 2018
New Revision: 335483
URL: http://llvm.org/viewvc/llvm-project?rev=335483&view=rev
Log:
[OPENMP] Do not consider address constant vars as possibly
threadprivate.
Do not delay emission of the address constant variables in OpenMP mode
as they cannot be
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
Repository:
rC Clang
https://reviews.llvm.org/D48532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
xazax.hun added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:10
const CharT *c_str();
+ const CharT *data();
};
Note that these methods are const according to the standard. Even if it does
not make any difference for this check we
klimek added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
ank wrote:
> klimek wrote:
> > ank wrote:
> > > klimek wrote:
> > > > What would be interesting
martong updated this revision to Diff 152703.
martong added a comment.
- Rebase from master.
Repository:
rC Clang
https://reviews.llvm.org/D47632
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclBase.h
lib/AST/ASTImporter.cpp
lib/AST/ExternalASTMerger.cpp
Index: lib/AST/
MTC updated this revision to Diff 152702.
MTC added a comment.
Sorry for the long long delay, I was on the Dragon Boat Festival a few days ago.
This update has two parts:
- Use the `matchesName` to match the AST node with the specified name,
`matchesName` use regex to match the specified name.
martong added a comment.
@labath
Sure, looking into it.
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martong
Date: Mon Jun 25 09:25:30 2018
New Revision: 335491
URL: http://llvm.org/viewvc/llvm-project?rev=335491&view=rev
Log:
Revert "[ASTImporter] Import the whole redecl chain of functions"
This reverts commit r335480.
Modified:
cfe/trunk/include/clang/AST/ASTImporter.h
cfe/tru
martong added a comment.
This is not trivial to fix. Reverting until we can reproduce and fix it.
Reverted with commit: r335491
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: ioeric
Date: Mon Jun 25 09:29:19 2018
New Revision: 335492
URL: http://llvm.org/viewvc/llvm-project?rev=335492&view=rev
Log:
[clang-format] Add a default format style that can be used by users of
`getStyle`
Summary:
Tools that reformat code often call `getStyle` to decide the format styl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335492: [clang-format] Add a default format style that can
be used by users of… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335495: Use Triple::isMIPS() instead of enumerating all
Triples. NFC (authored by arichardson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48549?vs=152696&id=152713#toc
Repositor
Author: arichardson
Date: Mon Jun 25 09:49:52 2018
New Revision: 335495
URL: http://llvm.org/viewvc/llvm-project?rev=335495&view=rev
Log:
Use Triple::isMIPS() instead of enumerating all Triples. NFC
Reviewed By: atanasyan
Differential Revision: https://reviews.llvm.org/D48549
Modified:
cfe/
chh added a comment.
In https://reviews.llvm.org/D45454#1142197, @marco-c wrote:
> In https://reviews.llvm.org/D45454#1070884, @belleyb wrote:
>
> > @chh I had a chance to try out your proposed changes. It's not causing us
> > any trouble. In fact, `__gcov_flush()` is not even used at all (at le
rnkovacs updated this revision to Diff 152719.
rnkovacs added a comment.
Fixed the constness of `c_str()` in the test file.
https://reviews.llvm.org/D48522
Files:
lib/StaticAnalyzer/Checkers/AllocationState.h
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
lib/StaticAnalyzer
Author: paquette
Date: Mon Jun 25 10:27:51 2018
New Revision: 335503
URL: http://llvm.org/viewvc/llvm-project?rev=335503&view=rev
Log:
[MachineOutliner] Make last of -moutline/-mno-outline win
The expected behaviour of command-line flags to clang is to have
the last of -m(whatever) and -mno-(what
Author: paquette
Date: Mon Jun 25 10:36:05 2018
New Revision: 335504
URL: http://llvm.org/viewvc/llvm-project?rev=335504&view=rev
Log:
[MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is
passed
Pass -enable-linkonceodr-outlining by default when LTO is enabled.
The ou
Author: morehouse
Date: Mon Jun 25 11:01:51 2018
New Revision: 335507
URL: http://llvm.org/viewvc/llvm-project?rev=335507&view=rev
Log:
[CMake] Fix install-cxx target.
Was broken by r334477.
Modified:
libcxx/trunk/include/CMakeLists.txt
Modified: libcxx/trunk/include/CMakeLists.txt
URL:
ht
krytarowski added a comment.
ping^2
Repository:
rL LLVM
https://reviews.llvm.org/D47814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shuaiwang added a comment.
Could someone help commit this now that the build issue with header include is
fixed? Thanks a lot!
(meanwhile I'm requesting commit access)
In https://reviews.llvm.org/D45679#1132327, @alexfh wrote:
> In https://reviews.llvm.org/D45679#1132086, @JonasToth wrote:
>
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335510: [WebAssembly] Add no-prototype attribute to
prototype-less C functions (authored by sbc, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
Author: sbc
Date: Mon Jun 25 11:47:32 2018
New Revision: 335510
URL: http://llvm.org/viewvc/llvm-project?rev=335510&view=rev
Log:
[WebAssembly] Add no-prototype attribute to prototype-less C functions
The WebAssembly backend in particular benefits from being
able to distinguish between varargs fu
rnkovacs updated this revision to Diff 152737.
rnkovacs marked an inline comment as done.
https://reviews.llvm.org/D48532
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
test/Analysis/dangling-internal-buffer.cpp
Index: test/Analysis/dangling-internal-buffer.cpp
rnkovacs added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:10
const CharT *c_str();
+ const CharT *data();
};
xazax.hun wrote:
> Note that these methods are const according to the standard. Even if it does
> not make any differen
On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> multiple comments in the code indicate that the attribute order was
> surprising and probably has lead to bugs, and will lead to bugs in the
> future. The order had to be explicitly reversed to a
vlad.tsyrklevich accepted this revision.
vlad.tsyrklevich added a comment.
This revision is now accepted and ready to land.
I think it would be clearer to replace uses of 'member function pointer' with
'pointer to member function'; however, a google search shows that the usage of
both terms is b
baloghadamsoftware updated this revision to Diff 152752.
baloghadamsoftware added a comment.
Comment fixed, assertions inserted, new tests added.
https://reviews.llvm.org/D35110
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
lib/StaticAnalyzer/Core/RangeCon
echristo added subscribers: dlj, echristo.
echristo added a comment.
I've added a couple of inline comments here - between this and the comments in
the post-commit review from dlj it seems like we might want to revert this for
now and figure out the best way forward.
Thanks!
-eric
=
On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi,
>>
>> multiple comments in the code indicate that the attribute order was
>> surprising and
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
Hi all,
We finally finished a self-contained first version of our implementation of
alternative transport layer for macOS based on XPC.
To en
pcc added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1413
+ FD->getType(), Context.getRecordType(Base).getTypePtr()));
+ F->addTypeMetadata(0, Id);
+}
vlad.tsyrklevich wrote:
> It'd be nice to have a test that reaches t
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
This is a self-contained pair of utility functions for the XPC transport layer.
It's not dependent on but following the refactoring patch:
http
jlebar added a comment.
@rsmith friendly ping on this one.
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
Implementation of alternative transport layer for macOS based on XPC.
Based on these two other patches:
https://reviews.llvm.org/D48559
https:/
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
Previously we were using default logic when building Linux runtimes
in Fuchsia toolchain, but that leads to various issues due to how
the CMake logic in compiler-rt for determining the p
phosek created this revision.
phosek added reviewers: mcgrathr, juliehockett, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
Now that the structure of Fuchsia SDK has been formalized, we no
longer need to pass all the different CFLAGS/LDFLAGS to the CMake
build separately, we can sim
jkorous added a comment.
Followed by these two patches:
[clangd] JSON <-> XPC conversions
https://reviews.llvm.org/D48560
[clangd] XPC transport layer
https://reviews.llvm.org/D48562
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48559
arphaman added inline comments.
Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51
+ dlHandle, "clangd_xpc_get_bundle_identifier");
+ xpc_connection_t conn =
+ xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL);
We should probably
srhines added a comment.
Rui, I added you to this review (and the other corresponding one), as you
reviewed ecbeckmann's original work here. Can you take a quick look at these?
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D48459
___
cf
When reverting things, please say why in the commit message. (In this case,
apparently because it broke the lldb buildbots?)
On Mon, Jun 25, 2018 at 12:30 PM Gabor Marton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: martong
> Date: Mon Jun 25 09:25:30 2018
> New Revision: 335491
Hi Nico,
Yes, I reverted because it broke one of the lldb build bots.
Next time I'll include the reason in the revert commit.
Gábor
On Mon, 25 Jun 2018, 22:50 Nico Weber, wrote:
> When reverting things, please say why in the commit message. (In this
> case, apparently because it broke the lld
erichkeane added inline comments.
Comment at: test/Sema/attr-target-mv.c:98
int __attribute__((target("sse4.2"))) diff_cc(void);
-// expected-error@+1 {{multiversioned function declaration has a different
calling convention}}
+// expected-error@+1 {{attribute 'target' multivers
rsmith added a comment.
This patch appears to have at least caused us to process attributes too many
times in some cases. For example:
__attribute__((noreturn,noinline,unused)) void f();
before your patch gives this with `clang -Xclang -ast-dump`:
`-FunctionDecl 0xccef1e0 <:1:1, col:50> co
smeenai added reviewers: beanz, phosek.
smeenai added a comment.
I think it might be more appropriate to pass NO_SYSTEM_ENVIRONMENT_PATH to
find_package in case CMAKE_SYSROOT or CMAKE_CROSSCOMPILING are set? That way,
we won't search the host system for libxml2 in those cases, but we'll still be
ahatanak added a reviewer: jlebar.
ahatanak added a subscriber: jlebar.
ahatanak added a comment.
ping.
@jlebar, is the change I made to call-host-fn-from-device.cu correct?
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits ma
jlebar added a comment.
> @jlebar, is the change I made to call-host-fn-from-device.cu correct?
I don't think so -- that's a change in overloading behavior afaict.
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
2018-06-25 14:20 GMT-05:00 Richard Smith :
> (I'm not sure what the problem is, but as a data point, Sema::checkCall
> iterates over the FormatAttrs in order, so it's possible that changing the
> order may have triggered a new warning. That may be due to a pre-existing
> order-dependence bug, or it
1 - 100 of 152 matches
Mail list logo
