[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm created this revision. arsenm added reviewers: scanon, spatel, cameron.mcinally, andrew.w.kaylor, tra, jlebar, Anastasia, yaxunl. Herald added subscribers: hiraditya, kristof.beyls, tpr, nhaehnle, wdng, jvesely, jholewinski. Herald added a project: LLVM. arsenm added parent revisions:

Buildbot numbers for the week of 10/27/2019 - 11/02/2019

Hello everyone, Below are some buildbot numbers for the last week of 10/27/2019 - 11/02/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 10/20/2019 - 10/26/2019

Hello everyone, Below are some buildbot numbers for the week of 10/20/2019 - 10/26/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 10/06/2019 - 10/12/2019

Hello everyone, Below are some buildbot numbers for the week of 10/06/2019 - 10/12/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 10/13/2019 - 10/19/2019

Hello everyone, Below are some buildbot numbers for the week of 10/13/2019 - 10/19/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 09/29/2019 - 10/05/2019

Hello everyone, Below are some buildbot numbers for the week of 09/29/2019 - 10/05/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69875: Allow "callbr" to return non-void values

void created this revision. void added reviewers: jyknight, nickdesaulniers, hfinkel. void added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. void abandoned this revision. THIS IS A WIP! Remove the restrictions that preventing "callbr" from returning

[PATCH] D69876: Allow output constraints on "asm goto"

void created this revision. void added reviewers: jyknight, nickdesaulniers, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. THIS IS A WIP! Remove the restrictions that preventing "asm goto" from returning non-void values. The value returned by "asm goto" is only

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added inline comments. Comment at: clang/test/Driver/debug-default-version.c:9-17 +// The -isysroot is used as a hack to avoid LIT messing with the SDKROOT +// environment variable which indirecty overrides the version in the target +// triple used here. +// RUN: %clang

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - but maybe give it a day to see if anyone else has further thoughts/that you've addressed their feedback too. Comment at:

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 227986. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. LLVM stuff only + unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files:

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 227985. jdoerfert added a comment. More updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

NoQ added a comment. Given that i roughly remember what the previous comment was about and i wanted to comment on this: you should totally move `evalCall` for any functions you need from `StdCLibraryFunctionsChecker` to this checker, given that your checker is more specialized. That said, you

[PATCH] D69872: Improve modernize-avoid-bind to support more types of expressions

zturner created this revision. zturner added reviewers: aaron.ballman, jbcoe. Previously modernize-avoid-bind only supported the case where the function to call was a FunctionDecl. This patch makes it support arbitrary expressions, including functors, member functions, and combinations

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); ABataev wrote: >

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227977. cmtice added a comment. Rename flag to -fdebug-default-version; add help text, mentioning DWARF. Update tests to use -### and add assembler tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); jdoerfert wrote: >

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1068 + Warning<"in functions '#pragma STDC FENV_ACCESS ON' is supported only " + "in topmost block, ignoring pragma">, InGroup; "'#pragma STDC FENV_ACCESS ON'

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

Meinersbur added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:215 LANGOPT(OpenMPCUDAMode, 1, 0, "Generate code for OpenMP pragmas in SIMT/SPMD mode") +LANGOPT(OpenMPNewCodegen , 1, 0, "Use the experimental OpenMP-IR-Builder codegen path.")

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. In D69853#1734760 , @jdoerfert wrote: > In D69853#1734620 , @ABataev wrote: > > > Again, better to split into 2 patches, one for LLVM and one for clang. > > > I split the other patch, but

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

efriedma added a comment. > while failing on 8-bit atomic operations as there is no hardware support That's weird; it should be possible to emulate 8-bit atomic operations on top of 64-bit cmpxchg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector +

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

gokturk created this revision. gokturk added reviewers: ilya-biryukov, nridge, kadircet, beanz, compnerd. Herald added subscribers: cfe-commits, usaxena95, s.egerton, lenary, PkmX, jfb, arphaman, jkorous, simoncook, mgorny. Herald added a project: clang. The CheckAtomic module performs two tests

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert added a comment. In D69853#1734620 , @ABataev wrote: > Again, better to split into 2 patches, one for LLVM and one for clang. I split the other patch, but this one cannot be split in a reasonable (=testable) manner. Splitting a patch only to

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Looks okay to me. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice marked an inline comment as done. cmtice added a comment. Yes, I will change the flag name back to debug-default-version, and add help text mentioning dwarf. I'm in the process of trying to re-do the test cases as required (I'm a bit new to this so it's taking me a bit to figure this

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:1955 Flags<[CC1Option]>; +def fdwarf_default_version: Joined<["-"], "fdwarf-default-version=">, Group; def fdebug_prefix_map_EQ probinson wrote: > Probably should have

[clang] 39573da - Revert "[analyzer] Add test directory for scan-build."

Author: Volodymyr Sapsai Date: 2019-11-05T14:03:36-08:00 New Revision: 39573daa76f23b93bda1437157cf78fb3d1003e2 URL: https://github.com/llvm/llvm-project/commit/39573daa76f23b93bda1437157cf78fb3d1003e2 DIFF:

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); jdoerfert wrote: >

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227960. mibintc retitled this revision from "Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector +

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", +

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

merge_guards_bot added a comment. Build result: pass - 59867 tests passed, 0 failed and 768 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Just a small typo in comment. Otherwise, great job! Comment at: clang/lib/Format/TokenAnnotator.cpp:1369 + static bool isDeductionGuide(FormatToken ) { +//

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", +

[clang] ee10d93 - Fix typo so that '-O0' is correctly specified

Author: Bill Wendling Date: 2019-11-05T13:15:55-08:00 New Revision: ee10d93449eccfd3b6e6ae8f02551b1a03a4 URL: https://github.com/llvm/llvm-project/commit/ee10d93449eccfd3b6e6ae8f02551b1a03a4 DIFF: https://github.com/llvm/llvm-project/commit/ee10d93449eccfd3b6e6ae8f02551b1a03a4.diff

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6171 + + if (DwarfVersion == 0) +DwarfVersion = ParseDwarfDefaultVersion(getToolChain(), Args); MaskRay wrote: > lang=cpp > if (DwarfVersion == 0) { > DwarfVersion =

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added inline comments. Comment at: clang/include/clang/Driver/Options.td:1955 Flags<[CC1Option]>; +def fdebug_default_version: Joined<["-"], "fdebug-default-version=">, Group; def fdebug_prefix_map_EQ dblaikie wrote: > probinson wrote: > > If this

[clang] dcec2ac - [OPENMP50]Simplify processing of context selector scores.

Author: Alexey Bataev Date: 2019-11-05T15:59:22-05:00 New Revision: dcec2ac4f353c3813f45392dbd0b4d3c5ee66e06 URL: https://github.com/llvm/llvm-project/commit/dcec2ac4f353c3813f45392dbd0b4d3c5ee66e06 DIFF: https://github.com/llvm/llvm-project/commit/dcec2ac4f353c3813f45392dbd0b4d3c5ee66e06.diff

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227954. cmtice added a comment. Make second call to ParseDwarfDefaultVersion unconditional (to match the first and avoid errors with -Werror). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files:

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added a comment. The test is in the right place, now it needs to behave more like other driver tests. Sorry if it feels like I'm whaling on you, but the driver is a bit of a peculiar beast with an atypical testing mode. Taming it is harder than it looks. Comment

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. For the record, I double-checked and if we use the flag and don't check for it (i.e. if we move the parsing inside the EmitDwarf is True block) then -Werror does indeed complain about an unused command line argument. CHANGES SINCE LAST ACTION

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. > burden with the upstream We are the part of mainstream and have 4 developers in LLVM + few others contributing. We run the NetBSD buildbot that builds and runs test of LLD. http://lab.llvm.org:8014/builders/netbsd-amd64 Repository: rG LLVM Github Monorepo

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

MyDeveloperDay added a comment. In D69854#1734222 , @merge_guards_bot wrote: > Build result: fail - 33803 tests passed, 1 failed and 462 were skipped. > > failed: LLVM.Object/macho-invalid.test > > Log files: console-log.txt >

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227952. MyDeveloperDay marked an inline comment as done. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Ensure the deduction guides follow a template Add additional test cases raised

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added inline comments. Comment at: clang/test/Driver/dwarf-default-version.c:1 +// RUN: %clang -target x86_64-linux-gnu -fdwarf-default-version=4 -gdwarf-2 -S -emit-llvm -o - %s | FileCheck %s --check-prefix=DWARF2 +// RUN: %clang -target x86_64-linux-gnu -gdwarf-3

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. I don't want to diverge this patch on offtopic or general discussion. Does it look good for landing? We need this support to be functional out of the box and as a part of LLVM. E.g. `clang -fuse-ld=` currently tries to call `ld.lld`, with this patch it will go

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

ABataev added a comment. Again, better to split into 2 patches, one for LLVM and one for clang. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector +

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3237 +// If the user specified a default DWARF version, that takes precedence +// over the platform default. lang=cpp if (DefaultDWARFVersion) { // If the

[PATCH] D69481: [Sema] Fixes templated friend member assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rG743461090a20: [Sema] Fixes templated friend member assertion (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69481/new/

[clang] 7434610 - [Sema] Fixes templated friend member assertion

Author: Mark de Wever Date: 2019-11-05T21:46:42+01:00 New Revision: 743461090a2027058cd438ed643ed5ed939cf1ca URL: https://github.com/llvm/llvm-project/commit/743461090a2027058cd438ed643ed5ed939cf1ca DIFF: https://github.com/llvm/llvm-project/commit/743461090a2027058cd438ed643ed5ed939cf1ca.diff

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 227948. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Addressed review comments, simplified some changes, moved file, ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/

[PATCH] D69866: [clang-tools-extra] [cmake] Add install target for clangd-indexer

mmpozulp created this revision. mmpozulp added reviewers: ilya-biryukov, mgorny. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Currently if you run 'ninja && ninja install' clangd-indexer will build but it won't install.

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. dblaikie: The code, as written, parses the dwarf default version flag, whether or not DWARFVersion is 0, i.e. whether or not a -gdwarf-N flag was passed. It only USES the value if there's no overriding value. CHANGES SINCE LAST ACTION

[PATCH] D69781: [analyzer] Add test directory for scan-build

thakis added a comment. If CLANG_INSTALL_SCANBUILD=NO, then this tries to run scan-build from PATH, where it might not exist. Does this need some lit feature to check if scan-build is being copied to the bin dir by the build system? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:1955 Flags<[CC1Option]>; +def fdebug_default_version: Joined<["-"], "fdebug-default-version=">, Group; def fdebug_prefix_map_EQ probinson wrote: > If this is specifically the

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_new_codegen : Flag<["-"], "fopenmp-new-codegen">, Group,

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks for patiently working through all this review. I'm happy with this now. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5063

[PATCH] D50360: [Concepts] Requires Expressions

saar.raz added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:1021-1052 +ExprResult TransformRequiresExpr(RequiresExpr *E) { + LocalInstantiationScope Scope(SemaRef, /*CombineWithOuterScope=*/true); + return

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

JonChesterfield added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknown) + 1); I wonder if

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. Ok, I think the upload was correct this time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227942. cmtice added a comment. re-try upload again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice added a comment. Hmmm...I'm having upload issues. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3250 // -gline-directives-only supported only for the DWARF debug info. if (DWARFVersion == 0 && DebugInfoKind == codegenoptions::DebugDirectivesOnly)

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227940. cmtice added a comment. Try uploading correct diff file? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. In D68578#1700652 , @tra wrote: > This patch proposes changing the source-level name for the stub. > Unfortunately the way it attempt to implement it is by doing the renaming > during mangling phase itself. This appears to be the

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

thakis added a comment. In D69760#1734524 , @thakis wrote: > We currently do cross builds of chrome/win on linux, and this breaks that. > > As far as I know, no linker other than lld-link is able to write PDB files, > so when targeting windows-msvc we

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

thakis added a comment. We currently do cross builds of chrome/win on linux, and this breaks that. As far as I know, no linker other than lld-link is able to write PDB files, so when targeting windows-msvc we definitely shouldn't change the current behavior. I don't have an opinion on

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:226 .str(); + } else if (Comment.startswith("//")) { Is this empty line necessary? Repository: rG LLVM Github Monorepo

[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a220de9e9ca: [HIP] Fix visibility for extern device variables. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63020/new/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added a comment. In D69822#1734255 , @cmtice wrote: > Made requested changes: > > - renamed option to be dwarf-specific > - fixed spelling & blank line issues > - only set version if emit-dwarf is true > - move test to Driver directory > > I

[clang] 0a220de - [HIP] Fix visibility for 'extern' device variables.

Author: Michael Liao Date: 2019-11-05T14:19:32-05:00 New Revision: 0a220de9e9ca3e6786df6c03fd37668815805c62 URL: https://github.com/llvm/llvm-project/commit/0a220de9e9ca3e6786df6c03fd37668815805c62 DIFF: https://github.com/llvm/llvm-project/commit/0a220de9e9ca3e6786df6c03fd37668815805c62.diff

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173 + } + + // Builds of compiler-rt on bare-metal targets are specialized by specific CodaFi wrote: > phosek wrote: > > Would it be possible to support the [per-target

[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

yaxunl accepted this revision. yaxunl added a subscriber: scchan. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! @scchan This may fix the undefined symbol in work item struct issue at -O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

yaxunl added a comment. In D69826#1734324 , @hliao wrote: > In D69826#1734296 , @yaxunl wrote: > > > I am a little bit concerned that user may have such code: > > > > struct A { int *p; } > > __global__

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:1643 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_new_codegen : Flag<["-"], "fopenmp-new-codegen">, Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>,

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

MaskRay added a comment. In D69755#1731420 , @krytarowski wrote: > In D69755#1731394 , @MaskRay wrote: > > > I still have the feeling that such configurations should be added to > > clangDriver/gcc specs or a

[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

hliao added a comment. Sam, could you review this? Even though it has no functionality issue so far, from the code sequence, once there's an `addrspacecast` is inserted, we lose the chance to set target specific attributes if any. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69766/new/ https://reviews.llvm.org/D69766 ___

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz updated this revision to Diff 227917. ekatz added a comment. Fixed requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 Files: clang/lib/Lex/LiteralSupport.cpp llvm/include/llvm/ADT/APFloat.h

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao added a comment. In D69826#1734296 , @yaxunl wrote: > I am a little bit concerned that user may have such code: > > struct A { int *p; } > __global__ kernel(A a) { > int x; > a.p = > f(a); > } > > > @arsenm what happens if a

[clang-tools-extra] 87e0cb4 - [clangd] Implement semantic highlightings via findExplicitReferences

Author: Ilya Biryukov Date: 2019-11-05T19:15:24+01:00 New Revision: 87e0cb4f1ad299c87c3e26676a9b31b3caf58921 URL: https://github.com/llvm/llvm-project/commit/87e0cb4f1ad299c87c3e26676a9b31b3caf58921 DIFF: https://github.com/llvm/llvm-project/commit/87e0cb4f1ad299c87c3e26676a9b31b3caf58921.diff

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz marked 2 inline comments as done. ekatz added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:273 + if (p != end) +return createError("Invalid exponent in exponent"); arsenm wrote: > Error message sounds like nonsense It is actually

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added a comment. In D69785#1734292 , @jdoerfert wrote: > In D69785#1734205 , @ABataev wrote: > > > Also, I think it would better to split LLVM part and clang part into > > separate patches. > > > What do

[PATCH] D69858: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, huntergr, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - fadda & faddv - fminv, fmaxv, fminnmv & fmaxnmv -

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

yaxunl added a comment. I am a little bit concerned that user may have such code: struct A { int *p; } __global__ kernel(A a) { int x; a.p = f(a); } @arsenm what happens if a private pointer is mis-used as a global pointer? I am wondering if we should coerce byval struct

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG87e0cb4f1ad2: [clangd] Implement semantic highlightings via findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

rnk accepted this revision. rnk added a comment. In D69763#1733382 , @Ericson2314 wrote: > I am curious, how did this work since there is no longer an `lld-link2`? Were > these tests failing or not being run? These tests don't actually need to run the

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added a comment. FWIW, *I will enable the new pass in some tests before this goes in* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 ___ cfe-commits

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D69785#1734205 , @ABataev wrote: > Also, I think it would better to split LLVM part and clang part into separate > patches. What do you mean exactly and why?

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15140e4bacf9: [hip] Enable pointer argument lowering through coercing type. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added a comment. In D69813#1734193 , @Szelethus wrote: > Hmm, so this checker is rather a collection of CERT rule checkers, right? > Shouldn't the checker name contain the actual rule name (STR31-C)? User > interfacewise, I would much prefer

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 227910. cmtice marked 9 inline comments as done. cmtice added a comment. Made requested changes: - renamed option to be dwarf-specific - fixed spelling & blank line issues - only set version if emit-dwarf is true - move test to Driver directory I *think* I

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 227909. Tyker added a comment. @rsmith Changes: - Rebased on recent master. - Adapted this patch to constexpr destructors. - Fixed issues with handling of temporaries. - Improve Tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/

[PATCH] D69826: [hip] Enable pointer argument lowering through coercing type.

hliao updated this revision to Diff 227908. hliao marked an inline comment as done. hliao added a comment. Add host-side checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69826/new/ https://reviews.llvm.org/D69826 Files:

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:757 + lex(Content, LangOpts, [&](const clang::Token , const SourceManager ) { +if (Tok.getKind()

[clang] 15140e4 - [hip] Enable pointer argument lowering through coercing type.

Author: Michael Liao Date: 2019-11-05T13:05:05-05:00 New Revision: 15140e4bacf94fbc509e5a139909aefcd1cc3363 URL: https://github.com/llvm/llvm-project/commit/15140e4bacf94fbc509e5a139909aefcd1cc3363 DIFF: https://github.com/llvm/llvm-project/commit/15140e4bacf94fbc509e5a139909aefcd1cc3363.diff

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

rnk added a comment. > I think a better distinguisher would be whether clang was invoked as > clang[++] or clang-cl (i.e. driver mode). I think Martin said most of what I wanted to say. Making this dependent on the driver mode seems reasonable and would be the easier way forward. If you still

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:107 +if (!Index) + return NoIndexProvided; + hokein wrote: > ilya-biryukov wrote: > > Why isn't this a scope enum in the first place? > this is tricky, the

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

merge_guards_bot added a comment. Build result: fail - 33803 tests passed, 1 failed and 462 were skipped. failed: LLVM.Object/macho-invalid.test Log files: console-log.txt , CMakeCache.txt

  1   2   >