[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4177 + auto x1 = [[X(1)]]; + auto x2 = [[X(1, '2')]]; +} Please also add tests tha

[clang] 28b9ace - [clang] Remove a stray semicolon, fixing pedantic GCC warnings. NFC.

Author: Martin Storsjö Date: 2020-09-08T09:26:39+03:00 New Revision: 28b9ace85f6871cdb48f1483314d8342e099b136 URL: https://github.com/llvm/llvm-project/commit/28b9ace85f6871cdb48f1483314d8342e099b136 DIFF: https://github.com/llvm/llvm-project/commit/28b9ace85f6871cdb48f1483314d8342e099b136.diff

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

eduucaldas updated this revision to Diff 290410. eduucaldas added a comment. Add tests for constructor calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87249/new/ https://reviews.llvm.org/D87249 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[clang] 7907e55 - [Sema] fix /gr warning test case

Author: Zequan Wu Date: 2020-09-07T20:55:11-07:00 New Revision: 7907e5516a418fec29137beed3ff985f40e04f17 URL: https://github.com/llvm/llvm-project/commit/7907e5516a418fec29137beed3ff985f40e04f17 DIFF: https://github.com/llvm/llvm-project/commit/7907e5516a418fec29137beed3ff985f40e04f17.diff LOG

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. In D66564#2257635 , @aaron.ballman wrote: > In D66564#2256482 , @ffrankies wrote: > >> In D66564#2256424 , @Eugene.Zelenko >> wrote: >> >>> In D6

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies updated this revision to Diff 290396. ffrankies added a comment. Rebased, changed import in `StructPackAlignCheck.h` from `../ClangTidy.h` to `../ClangTidyCheck.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tools-e

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

steven.zhang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10054 + + case Intrinsic::ppc_altivec_mtvsrbm: { +// The llvm.ppc.altivec.mtvsrbm intrinsic can correspond to two different Can we handle this inside the .td ? i.e. c

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

This revision was automatically updated to reflect the committed changes. Closed by commit rG35f708a3c9ff: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290381. bc-lee added a comment. Fix the example to match the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge updated this revision to Diff 290379. nridge added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87257/new/ https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp clang/lib/Index/Ind

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge added a reviewer: hokein. nridge added a comment. I did try to add a test to `clang/test/Index/Core/index-source.cpp`, however the output of `c-index-test` does not seem to be changed by adding this reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87218/new/ https://reviews.llvm.org/D87218 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG. Please wait a bit for @efriedma's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87218/new/ https://reviews.llvm.org/D87218

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e782bf8090c: [Sema][MSVC] warn at dynamic_cast when /GR- is given (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D8636

[clang] 3e782bf - [Sema][MSVC] warn at dynamic_cast when /GR- is given

Author: Zequan Wu Date: 2020-09-07T16:46:58-07:00 New Revision: 3e782bf8090c80e6d75e62cd52c9ed32715cbcdd URL: https://github.com/llvm/llvm-project/commit/3e782bf8090c80e6d75e62cd52c9ed32715cbcdd DIFF: https://github.com/llvm/llvm-project/commit/3e782bf8090c80e6d75e62cd52c9ed32715cbcdd.diff LOG

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82726/new/ https://reviews.llvm.org/D82726

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

craig.topper added a comment. In D87218#2259972 , @MaskRay wrote: > I think this is correct, but does their performance matter? > `llvm/IR/RuntimeLibcalls.def` does not define them (they cannot be produced > by llvm). Targets either emit popcount & 1 or

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

MaskRay added a comment. I think this is correct, but does their performance matter? llvm/IR/RuntimeLibcalls.def do not define them (they cannot be produced by llvm). Targets either emit popcount & 1 or detect the idiom and emit an optimized parity (x86 after PR46954) Repository: rG LLVM Gi

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/c

[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. To make this patch more acceptable I could also add a `Visit` function for `DecompositionDecl` and `MSGuidDecl` such that the current behaviour is preserved (I won't be able to test it though since these implicit AST nodes are not visited). Repository: rG LLVM Gi

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD added inline comments. Comment at: clang/include/clang/Format/Format.h:1705 + /// \endcode + bool JavaStaticImportAfterImport; + bc-lee wrote: > JakeMerdichAMD wrote: > > 3 things here: > > > > 1. Did you mix up the true and false cases? > > 2.

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. In D86089#2256139 , @richard.barton.arm wrote: > Another random thought that just came to me: what does the new driver do when > you invoke it with no input files or options? I could imagine a few sensible > outcomes (error:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290337. awarzynski marked 2 inline comments as done. awarzynski added a comment. - Adddressed comments from @richard.barton.arm - Added FC1Option to ClangFlags (and made other related changes) - Added missing code to check return codes from subcommands (fla

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

riccibruno added a comment. > This change allow a CallExpr to have optional FPOptionsOverride object, Should this be `CastExpr` instead? > stored in trailing storage. The implementaion is made similar to the way > used in CallExpr. Nit, but that's not really similar. In the `CallExpr` case the

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

amosnier accepted this revision. amosnier added a comment. This revision is now accepted and ready to land. I'm not sure I'm supposed to accept a revision, but apparently I'm authorized to do so. And I'm obviously biased since I wrote the bug report. While looking for candidates close to the tar

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

gribozavr2 added a comment. Please also add tests for calls to constructors without arguments and calls to implicit constructors 1 argument, as requested in https://reviews.llvm.org/D86700. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87249/new/

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137 +// Ignore the implicit default constructs. +if ((S->getNumArgs() == 0 || isa(S->getArg(0))) && +S->getParenOrBraceRange().isInvalid()) eduucaldas wrote: > g

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

rjmccall added a comment. Minor request, but otherwise LGTM. Comment at: clang/lib/Analysis/BodyFarm.cpp:188 + const_cast(Arg), nullptr, VK_RValue, + FPOptionsOverride()); } Can these call sites

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

adamcz added a reviewer: kadircet. adamcz added a comment. Hey Kadir What do you think about this change? This addresses https://github.com/clangd/clangd/issues/519, but I'm not entirely convinced this is a good idea. Let me know if you have an opinion on this. Repository: rG LLVM Github Mo

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87250/new/ https://reviews.llvm.org/D87250 ___

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

adamcz created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. adamcz requested review of this revision. When looking for compile commands for file of type X, other files of type X will be preferred over files of any other type, regardless of score. However,

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290331. eduucaldas added a comment. - Rename tests - Add FIXMEs for init-declarators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Synta

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

RKSimon created this revision. RKSimon added reviewers: ABataev, doctorpangloss. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. RKSimon requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fixes issue noticed by sta

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4042 + +TEST_P(SyntaxTreeTest, ExplicitConversion_ZeroArguments) { + if (!GetParam().isCXX()) { gribozavr2 wrote: > This is not a conversion, this is an explicit const

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137 +// Ignore the implicit default constructs. +if ((S->getNumArgs() == 0 || isa(S->getArg(0))) && +S->getParenOrBraceRange().isInvalid()) gribozavr2 wrote: > I

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290328. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/T

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290327. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/T

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Do not visit `CXXDefaultArgExpr` - To build `CallArguments` nodes, just go through non-default arguments

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. The `LLVM_ENABLE_WARNINGS` variable is read only within `HandleLLVMOptions.cmake`. Outside declarations/defaults have effect only when `HandleLLVMOptions` is loaded, one way or another. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper abandoned this revision. craig.topper added a comment. This got replaced by D85765 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48 +// Ignores the implicit `CXXConstructExpr` for copy/move constructors generated +// by the compiler, as well as in implicit conversions like the one wrapp

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM But please add a -triple parameter to the test files, and check the dynamic_cast behavior in each case before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. @lebedev.ri `clang/CMakeLists.txt` contains `include(HandleLLVMOptions)` for its standalone build, I think this covers the issue you're pointing out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://revi

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

lebedev.ri added a comment. This is not nessesairy correct, at least the clang can be built in standalone mode, not as part of monorepo checkout (i.e. it's `clang/cmakelists.txt` is the root cmakelists, not `llvm/cmakelists.txt`'s) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. In D86671#2259443 , @dougpuob wrote: > In D86671#2259364 , @njames93 wrote: > >> Did you upload this incorrectly again, context is missing and seems to be a >> relative diff from a previou

[PATCH] D87244: [clang] Add fix-it for -Wreorder-ctor.

adamcz updated this revision to Diff 290313. adamcz added a comment. Add a missing const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87244/new/ https://reviews.llvm.org/D87244 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/warn-reo

[PATCH] D87244: [clang] Add fix-it for -Wreorder-ctor.

adamcz updated this revision to Diff 290312. adamcz added a comment. fixed comment typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87244/new/ https://reviews.llvm.org/D87244 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/warn-reor

[PATCH] D87244: [clang] Add fix-it for -Wreorder-ctor.

adamcz created this revision. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. adamcz requested review of this revision. This version is very limited. It does not work when comments are present anywhere in the initializer list, since we do not have a good way to associ

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione created this revision. Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits, mgorny. Herald added a reviewer: DavidTruby. Herald added projects: clang, libunwind, LLVM. Herald added a reviewer: libunwind. kastiglione requested review of this revision. Repository: rG LL

[PATCH] D86877: [Clang][Driver] Use full path to builtins in bare-metal toolchain

tambre added a comment. phosek: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86877/new/ https://reviews.llvm.org/D86877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

sepavloff added a comment. Any feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85960/new/ https://reviews.llvm.org/D85960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2259364 , @njames93 wrote: > Did you upload this incorrectly again, context is missing and seems to be a > relative diff from a previous version of this patch? Sorry for it, I think it's my bad. It is possible that I m

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290303. bc-lee added a comment. Some comments have been corrected and a unittest has been added in FormatTest.ParsesConfigurationBools Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.ll

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1136 + bool WalkUpFromCXXConstructExpr(CXXConstructExpr *S) { +// Ignore the implicit default constructs. +if ((S->getNumArgs() == 0 || isa(S->getArg(0

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

martong marked an inline comment as done. martong added a comment. In D87239#2259345 , @steakhal wrote: > I completely agree with you. > I plan to further refactor the CStringChecker, but the related patches are > pretty much stuck :D > > I think this wor

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps updated this revision to Diff 290301. alanphipps added a comment. - Rename isLeafCondition() to isInstrumentedCondition() and rephrase associated comments - Add branch regions on C++ range-based loops CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84467/new/ https://reviews.l

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked an inline comment as done. alanphipps added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4359 + /// condition (i.e. no "&&" or "||"). + static bool isLeafCondition(const Expr *C); + vsk wrote: > alanphipps wrote: > > vsk wr

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong added a comment. In D87081#2258637 , @Szelethus wrote: > The patch looks great, in fact, it demonstrates how well thought out your > summary crafting machinery is. > > In D87081#2258579 , @martong wrote: >

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8248c2af9497: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies (authored by martong). Changed prior to commit: https://reviews

[clang] 8248c2a - [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

Author: Gabor Marton Date: 2020-09-07T17:56:26+02:00 New Revision: 8248c2af94975912b14e7e0cb414fcbb82c77123 URL: https://github.com/llvm/llvm-project/commit/8248c2af94975912b14e7e0cb414fcbb82c77123 DIFF: https://github.com/llvm/llvm-project/commit/8248c2af94975912b14e7e0cb414fcbb82c77123.diff

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2027 + + .. code-block:: java + true: MyDeveloperDay wrote: > The ClangFormatStyleOptions.rst is generated using > doc/tools/dump_format_style.py which reads Format.h and genera

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd01280587d97: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions (authored by martong). Changed prior to commit: https://reviews.llvm.org/D84415?vs=289970&id=290296#toc Reposit

[clang] d012805 - [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

Author: Gabor Marton Date: 2020-09-07T17:47:01+02:00 New Revision: d01280587d97eb02d37da37666afd3e4d57c9336 URL: https://github.com/llvm/llvm-project/commit/d01280587d97eb02d37da37666afd3e4d57c9336 DIFF: https://github.com/llvm/llvm-project/commit/d01280587d97eb02d37da37666afd3e4d57c9336.diff

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. In D85611#2230481 , @aaron.ballman wrote: > In D85611#2218144 , @aaron.ballman > wrote: > >> Ping > > Ping x2 I realize it's performance review time for some folks and their schedul

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus added a comment. In D86135#2259325 , @steakhal wrote: > Perfectly clear, thank you. However, I would still rely on the others to > accept this :| > > BTW why does the `plist-macros-with-expansion.cpp.plist` change? It makes the > diff somewhat

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. Did you upload this incorrectly again, context is missing and seems to be a relative diff from a previous version of this patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is exactly how I imagines weak dependencies to work. LGTM on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87240/new/ https:/

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD requested changes to this revision. JakeMerdichAMD added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1705 + /// \endcode + bool JavaStaticImportAfterImport; + 3 things here: 1.

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

martong created this revision. martong added reviewers: Szelethus, balazske, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald ad

[PATCH] D87138: [analyzer][NFC] Introduce refactoring of PthreadLockChecker

steakhal accepted this revision. steakhal added a comment. Seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87138/new/ https://reviews.llvm.org/D87138 ___ cfe-commits mailing list cfe-comm

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

steakhal added a comment. I completely agree with you. I plan to further refactor the CStringChecker, but the related patches are pretty much stuck :D I think this workaround is fine for now. You might as well extend the corresponding parts of the CStringChecker to make the modelling more preci

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:805-817 + return IsASCII ? "^" : (const char *)u8"\u2548"; case LineChar::RangeMid: - return IsASCII ? "|" : u8"\u2503"; + return IsASCII ? "|" : (const char *)u8"\u2503";

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added a comment. In D78938#2258557 , @jhenderson wrote: > Not that I have anything particularly against this, but won't this likely rot > fairly rapidly? It's not like LLVM is even on C++17 let alone C++20 yet, so > trying to make it work like th

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

martong created this revision. martong added reviewers: Szelethus, balazske, NoQ, vsavchenko. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald ad

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

JakeMerdichAMD added a comment. I can see the use of this, but I am also wary that ignoring style options will lead to people producing different results on different versions of clang-format. This is both because having set-or-unset an option will naturally lead to different code and also that

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

steakhal added a comment. Perfectly clear, thank you. However, I would still rely on the others to accept this :| BTW why does the `plist-macros-with-expansion.cpp.plist` change? It makes the diff somewhat noisy :s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86135/new/ https://revi

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

steakhal added a comment. I have checked only your test, but the readability of the reports should be improved. You frequently refer to previous events, such as `This lock has already been unlocked`, `This lock has already been acquired`, etc. It isn't clear to the reader where do you refer to.

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. Ping @OikawaKirie . How should we proceed? I would happily participate in creating a minimal repro for this, but I need at least one crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://reviews.llvm.org

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added inline comments. Comment at: llvm/include/llvm/Support/CfgTraits.h:51 + + operator bool() const { return ptr != nullptr; } + dblaikie wrote: > `operator bool` should be `explicit` Done. Comment at: llvm/include/llvm/Support/CfgT

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal added a comment. In D86874#2259105 , @Szelethus wrote: > I can only imagine how long it took for you to write all this, because > reading it wasn't that short either. Thank you so much! It really gave me a > perspective on how you see this probl

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

grimar added a comment. I am not familar with `clang-format`, but have a few comments inlined about the rest. I think the new `setIgnoreUnknown` YAMLlib API is probably OK generally. I'd perhaps call it differently, e.g. `setAllowUnknownKeys` though. Also, I think you need to add a unit testing

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

steakhal added a comment. In D86874#2256249 , @martong wrote: >> Calculation of the RegionRawOffsetV2 >> >> >> Let's see how does these subscript expressions used during the calculation >> of the `RegionRawOffsetV2`: >

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

dmantipov updated this revision to Diff 290281. dmantipov added a comment. Add trivial {/etc,/usr/lib}/os-release parser and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87187/new/ https://reviews.llvm.org/D87187 Files: clang/include

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus updated this revision to Diff 290280. Szelethus marked 4 inline comments as done. Szelethus added a comment. Added a line about D78933 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86533/new/ https://reviews.llvm.org/D86533 Files: clang/do

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:453 + equal or known to be non-equal. + +- Added :ref:`on-demand parsing ` capability to Cross Translation ASDenysPetrov wrote: > I've added the patch "Reasoning about comparison expressio

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a subscriber: grimar. fodinabor added a comment. Thank you so far for the feedback! maybe you can give further guidance on the comments on the comments :) As of the git history it seems that @grimar did some work on YAML error handling.. Comment at: clang/tool

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) + dnsampaio wrote: > ostannard wrote: > > Why is this a negative option, w

[PATCH] D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer

Szelethus added a comment. I can only imagine how long it took for you to write all this, because reading it wasn't that short either. Thank you so much! It really gave me a perspective on how you see this problem, as well as what is actually happening (and should happen) in the checker. In D8

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86097/new/ https://reviews.llvm.org/D86097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 2853ae3 - [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

Author: Simon Pilgrim Date: 2020-09-07T13:54:12+01:00 New Revision: 2853ae3c1b8174e3660424ffac45922601f700ee URL: https://github.com/llvm/llvm-project/commit/2853ae3c1b8174e3660424ffac45922601f700ee DIFF: https://github.com/llvm/llvm-project/commit/2853ae3c1b8174e3660424ffac45922601f700ee.diff

[PATCH] D87101: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2853ae3c1b81: [X86] Update SSE/AVX ABS intrinsics to emit llvm.abs.* (PR46851) (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES

[clang] 23f700c - Revert "[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations."

Author: Raphael Isemann Date: 2020-09-07T14:50:13+02:00 New Revision: 23f700c785a141355fa6d022552aafc73135bf5d URL: https://github.com/llvm/llvm-project/commit/23f700c785a141355fa6d022552aafc73135bf5d DIFF: https://github.com/llvm/llvm-project/commit/23f700c785a141355fa6d022552aafc73135bf5d.dif

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. In D80878#2258942 , @riccibruno wrote: > And what if deserialization is forced? That's a good point. That should indeed continue to work with the

[PATCH] D86631: [Fixed Point] Add fixed-point to floating point cast types and consteval.

ebevhan updated this revision to Diff 290266. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86631/new/ https://reviews.llvm.org/D86631 Files: clang/include/clang/AST/OperationKinds.def clang/lib/AST/Expr.cpp

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan updated this revision to Diff 290267. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48-50 +// Ignores the implicit `CXXConstructExpr` for copy/move constructors generated +// by the compiler, as well as in implicit conversions like the one wrapping `1` +// in `X x = 1;`. --

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

eduucaldas updated this revision to Diff 290261. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87229/new/ https://reviews.llvm.org/D87229 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290260. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

  1   2   >