[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good, but please wait for MyDeveloperDay’s opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

byronhe added a comment. Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding such as utf8 ， I am curious why there is a `isAlphanumeric` limit in `BreakableLineCommentSection::BreakableLineCommentSection()` ? I want to make some contribution to make it support utf8, what

[clang-tools-extra] 9c4a168 - [clangd] Fix clangd crash when including a header

Author: Queen Dela Cruz Date: 2021-09-16T10:27:15+02:00 New Revision: 9c4a1686d7c487fff8e63fa67e64623eea8986d5 URL: https://github.com/llvm/llvm-project/commit/9c4a1686d7c487fff8e63fa67e64623eea8986d5 DIFF: https://github.com/llvm/llvm-project/commit/9c4a1686d7c487fff8e63fa67e64623eea8986d5.dif

[PATCH] D108045: [clangd] Fix clangd crash when including a header

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4a1686d7c4: [clangd] Fix clangd crash when including a header (authored by qdelacru, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a comment. Hi @Anastasia, could you submit this patch for me (I don’t have commit access)? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144

[clang] 96ec9b6 - [Analyzer] ConversionChecker: track back the cast expression

Author: Gabor Marton Date: 2021-09-16T11:42:54+02:00 New Revision: 96ec9b6ff2f0bb9078306e3857f09974603ccbe4 URL: https://github.com/llvm/llvm-project/commit/96ec9b6ff2f0bb9078306e3857f09974603ccbe4 DIFF: https://github.com/llvm/llvm-project/commit/96ec9b6ff2f0bb9078306e3857f09974603ccbe4.diff

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG96ec9b6ff2f0: [Analyzer] ConversionChecker: track back the cast expression (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109836/new/

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. I dont have commit access, would someone be able to commit on my behalf? Thank You. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

martong added a comment. In D109836#3002811 , @steakhal wrote: > LGTM. > Thanks for fixing this. Thanks for the review! > Should this checker remain in alpha in its current form? > WDYT? @all There is no clear explanation for this checker being alpha.

[clang] 005fc11 - [PGO] Change ThinLTO test for targets with loop unrolling disabled

Author: Sherwin da Cruz Date: 2021-09-16T11:13:16+01:00 New Revision: 005fc11ebdd6e1af29efee3d7c5da86f56138414 URL: https://github.com/llvm/llvm-project/commit/005fc11ebdd6e1af29efee3d7c5da86f56138414 DIFF: https://github.com/llvm/llvm-project/commit/005fc11ebdd6e1af29efee3d7c5da86f56138414.dif

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG005fc11ebdd6: [PGO] Change ThinLTO test for targets with loop unrolling disabled (authored by Sherwin da Cruz <59867245+sherwin...@users.noreply.github.com>, committed by thopre). Repository: rG LLVM G

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. In D109828#3002495 , @thakis wrote: > In D109828#3002114 , @hans wrote: > >> The /winsysroot part makes sense to

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. In D92257#3003281 , @byronhe wrote: > Hi guys，i found `SpacesInLineCommentPrefix` does not support other encoding > such as utf8 ， > I am curious why there is a `isAlphanumeric` limit in > `BreakableLineCommentSection::Bre

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. I missed the most important step! 8. Add LLVM contributor to your CV. No seriously I mean it. I interview people all the time, if I saw that on a CV, it would immediately start a conversation about what/who/why you did it. (allowing me to look up your contributi

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109874 Files: clang/include/cl

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna planned changes to this revision. Topotuna added a comment. Current change is an initial draft. More code refactoring will be performed and change summary provided in near future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109874/new/

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

luismarques added a comment. I was trying to put this patch through its paces but it no longer applies. Can you please rebase it? It seems this is nearly there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D10

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___ cfe-commits mailing list cfe-comm

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. I think this is reasonable, but it's missing test coverage. Can you add some tests to `clang/test/Sema` to demonstrate that we purposefully do not issue a diagnostic when the cleanup attribute is used? Repository:

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22410 + ");", + Style); +} Can you assert the cases it won't do (given your description it seem like it would do it for all before ) cases) ``` i

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

luismarques added a comment. Regarding D74399 , cmake on a fedora RISC-V host still detects a generic triple: -- LLVM host triple: riscv64-unknown-linux-gnu -- LLVM default target triple: riscv64-unknown-linux-gnu as opposed to the `gcc -dumpmachine` triple

[clang] 951f362 - [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

Author: Nico Weber Date: 2021-09-16T07:42:32-04:00 New Revision: 951f362e2560fe1c9c05f487107fd9882d45d867 URL: https://github.com/llvm/llvm-project/commit/951f362e2560fe1c9c05f487107fd9882d45d867 DIFF: https://github.com/llvm/llvm-project/commit/951f362e2560fe1c9c05f487107fd9882d45d867.diff LO

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG951f362e2560: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it (authored by thakis). Herald added a project: clang. Changed prior to c

[PATCH] D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG054e331d9dbd: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github

[clang] 054e331 - [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-16T12:48:01+01:00 New Revision: 054e331d9dbd3ce98b19625b75ba38dd9ebc34cc URL: https://github.com/llvm/llvm-project/commit/054e331d9dbd3ce98b19625b75ba38dd9ebc34cc DIFF: https://github.com/llvm/llvm-project/commit/054e331d9dbd3ce98b19625b75ba38dd9ebc34cc.dif

[clang] 1bd5ea9 - [ARM] Mitigate the cve-2021-35465 security vulnurability.

Author: Alexandros Lamprineas Date: 2021-09-16T12:56:43+01:00 New Revision: 1bd5ea968e9262a09512a64bca1624818640bc5b URL: https://github.com/llvm/llvm-project/commit/1bd5ea968e9262a09512a64bca1624818640bc5b DIFF: https://github.com/llvm/llvm-project/commit/1bd5ea968e9262a09512a64bca1624818640bc

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd5ea968e92: [ARM] Mitigate the cve-2021-35465 security vulnurability. (authored by labrinea). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109854: Support Unicode 14 identifiers

aaron.ballman added a comment. Thanks for this! Can you add a test case that shows we now accept some Unicode 14 characters that Clang previously would have rejected (with a comment explaining what's being tested)? Comment at: clang/lib/Lex/UnicodeCharSets.h:13 // Unicode

[clang] 05ea321 - [clang-cl] Fix test after 951f362e256 on systems where default target isn't x86_64

Author: Nico Weber Date: 2021-09-16T08:43:58-04:00 New Revision: 05ea321f716390abda1632cca71dc9441662cf62 URL: https://github.com/llvm/llvm-project/commit/05ea321f716390abda1632cca71dc9441662cf62 DIFF: https://github.com/llvm/llvm-project/commit/05ea321f716390abda1632cca71dc9441662cf62.diff LO

[clang] ab41eef - [NewPM] Use a separate struct for ModuleMemorySanitizerPass

Author: Bjorn Pettersson Date: 2021-09-16T14:58:42+02:00 New Revision: ab41eef9aca3ad5e9321e045a57d36e288a75d17 URL: https://github.com/llvm/llvm-project/commit/ab41eef9aca3ad5e9321e045a57d36e288a75d17 DIFF: https://github.com/llvm/llvm-project/commit/ab41eef9aca3ad5e9321e045a57d36e288a75d17.di

[clang] 8f86166 - [NewPM] Use a separate struct for ModuleThreadSanitizerPass

Author: Bjorn Pettersson Date: 2021-09-16T14:58:42+02:00 New Revision: 8f8616655c4d643d73601c6bf4b492fb9d3b52c8 URL: https://github.com/llvm/llvm-project/commit/8f8616655c4d643d73601c6bf4b492fb9d3b52c8 DIFF: https://github.com/llvm/llvm-project/commit/8f8616655c4d643d73601c6bf4b492fb9d3b52c8.di

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 ___ cfe-com

[PATCH] D109854: Support Unicode 14 identifiers

cor3ntin updated this revision to Diff 372915. cor3ntin added a comment. Added some tests for randomly choosen Unicode 14 codepoints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109854/new/ https://reviews.llvm.org/D109854 Files: clang/lib/Lex/

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp Index:

[clang] 1b0a71c - [PowerPC][AIX] Add support for varargs for complex types on AIX

Author: Zarko Todorovski Date: 2021-09-16T09:38:03-04:00 New Revision: 1b0a71c5fc052322a45a8cb9a9fcaa2c36105b89 URL: https://github.com/llvm/llvm-project/commit/1b0a71c5fc052322a45a8cb9a9fcaa2c36105b89 DIFF: https://github.com/llvm/llvm-project/commit/1b0a71c5fc052322a45a8cb9a9fcaa2c36105b89.di

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0a71c5fc05: [PowerPC][AIX] Add support for varargs for complex types on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new

[PATCH] D109880: [clangd] PreamblePatch should be no-op if includes arent patched

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Don't create a useless function

[clang] 45a7383 - Increase expected line number for ExtDebugInfo.cpp

Author: Jake Egan Date: 2021-09-16T10:03:01-04:00 New Revision: 45a738363ee39754a0e93d9f779bda2cad83fa18 URL: https://github.com/llvm/llvm-project/commit/45a738363ee39754a0e93d9f779bda2cad83fa18 DIFF: https://github.com/llvm/llvm-project/commit/45a738363ee39754a0e93d9f779bda2cad83fa18.diff LOG

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45a738363ee3: Increase expected line number for ExtDebugInfo.cpp (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:74 + + llvm::Optional Index; + StringRef URI; You have a `using namespace llvm;` at the top of the file, so all these `llvm::` nested name specifiers can be removed. =

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added a comment. Seems like conflict with D108187 , will update after testing :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 _

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Doesn't install clang-tidy chec

[PATCH] D109854: Support Unicode 14 identifiers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor comment on comments that I'll handle when I land this. Comment at: clang/test/Lexer/unicode.c:37-41 +extern int \u1B4C; //BALINESE LETTER

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

kadircet updated this revision to Diff 372938. kadircet added a comment. - Disable IncludeFixer too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109884/new/ https://reviews.llvm.org/D109884 Files: clang-tools-extra/clangd/ParsedAST.cpp clang

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

sammccall added a comment. Great! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:295 llvm::MemoryBuffer::getMemBufferCopy(Inputs.Contents, Filename), VFS, - ASTDiags); + PreserveDiags ? static_cast(ASTDiags) +: static_cast(DropDiags)); -

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 372939. kito-cheng added a comment. Changes: - Rebase to `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 Files: clang/include/clang/Basic/DiagnosticComm

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:464 - - TU.AdditionalFiles["a.h"] = ""; - TU.AdditionalFiles["b.h"] = ""; sammccall wrote: > Why are these tests deleted? they rely on the fact that clang-tidy che

[PATCH] D109880: [clangd] PreamblePatch should be no-op if includes arent patched

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:462 BaselineScan->TextualDirectives != ModifiedScan->TextualDirectives; - if (!IncludesChanged && !Directi

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:464 - - TU.AdditionalFiles["a.h"] = ""; - TU.AdditionalFiles["b.h"] = ""; kadir

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

kadircet updated this revision to Diff 372943. kadircet marked 2 inline comments as done. kadircet added a comment. - Get rid of static_casts - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109884/new/ https://reviews.llvm.org/D1098

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 372946. Jake-Egan added a comment. Revert last ExtDebugInfo.cpp change because https://reviews.llvm.org/rG45a738363ee39754a0e93d9f779bda2cad83fa18 has been committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

kadircet updated this revision to Diff 372947. kadircet added a comment. - Revert revert of IncludeFixer changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109884/new/ https://reviews.llvm.org/D109884 Files: clang-tools-extra/clangd/ParsedAST

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

catenacyber added a comment. Should I propose a simple patch to bump INSTR_PROF_RAW_VERSION ? Or will it be part of something bigger, taken care of by someone else ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/ https://reviews.llvm.org

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added a comment. I think you may try fixing the following line: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp#L97 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.l

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can you please please merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

dbhaskaran created this revision. dbhaskaran added reviewers: pdhaliwal, csigg, JonChesterfield. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mges

[clang-tools-extra] ea79b77 - [clangd] Dont work on diags if we are not going to emit

Author: Kadir Cetinkaya Date: 2021-09-16T16:50:42+02:00 New Revision: ea79b77da3eeba926e16c3dd8a4f6626c139e185 URL: https://github.com/llvm/llvm-project/commit/ea79b77da3eeba926e16c3dd8a4f6626c139e185 DIFF: https://github.com/llvm/llvm-project/commit/ea79b77da3eeba926e16c3dd8a4f6626c139e185.dif

[PATCH] D109884: [clangd] Dont work on diags if we are not going to emit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea79b77da3ee: [clangd] Dont work on diags if we are not going to emit (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] abe8b35 - Fix vtbl field addr space

Author: Yaxun (Sam) Liu Date: 2021-09-16T10:57:31-04:00 New Revision: abe8b354e37d8d6a163a6402d8e68ddcfc462dfc URL: https://github.com/llvm/llvm-project/commit/abe8b354e37d8d6a163a6402d8e68ddcfc462dfc DIFF: https://github.com/llvm/llvm-project/commit/abe8b354e37d8d6a163a6402d8e68ddcfc462dfc.dif

[PATCH] D109841: Fix vtbl field addr space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabe8b354e37d: Fix vtbl field addr space (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna updated this revision to Diff 372937. Topotuna edited the summary of this revision. Topotuna added reviewers: olestrohm, Anastasia. Topotuna added a comment. Code refactored inside `clang/lib/AST/Expr.cpp`. Commit message added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1098

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1423-1426 +ObjCMethodList InstanceMethods; +ObjCMethodList FactoryMethods; +llvm::DenseSet AddedInstanceMethods; +llvm::DenseSet AddedFactoryMethods; dexonsmith wrote: > Do th

[clang-tools-extra] 64fe045 - [clangd] PreamblePatch should be no-op if includes arent patched

Author: Kadir Cetinkaya Date: 2021-09-16T17:11:31+02:00 New Revision: 64fe0458866d7bcadacb776a1fa7d827ba8ab916 URL: https://github.com/llvm/llvm-project/commit/64fe0458866d7bcadacb776a1fa7d827ba8ab916 DIFF: https://github.com/llvm/llvm-project/commit/64fe0458866d7bcadacb776a1fa7d827ba8ab916.dif

[PATCH] D109880: [clangd] PreamblePatch should be no-op if includes arent patched

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG64fe0458866d: [clangd] PreamblePatch should be no-op if includes arent patched (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D10988

[clang] 720766a - Remove trailing whitespace in ASTReaderDecl.cpp

Author: Erich Keane Date: 2021-09-16T08:23:28-07:00 New Revision: 720766a50cab7a143f0aa04e3ae344769072511d URL: https://github.com/llvm/llvm-project/commit/720766a50cab7a143f0aa04e3ae344769072511d DIFF: https://github.com/llvm/llvm-project/commit/720766a50cab7a143f0aa04e3ae344769072511d.diff L

[PATCH] D109894: [clangd] Bail-out when an empty compile flag is encountered

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd

[clang] f670c5a - Add a new frontend flag `-fswift-async-fp={auto|always|never}`

Author: Arnold Schwaighofer Date: 2021-09-16T08:48:51-07:00 New Revision: f670c5aeeef09cd7b88e72cf8c1f2505d044a8ea URL: https://github.com/llvm/llvm-project/commit/f670c5aeeef09cd7b88e72cf8c1f2505d044a8ea DIFF: https://github.com/llvm/llvm-project/commit/f670c5aeeef09cd7b88e72cf8c1f2505d044a8ea

[PATCH] D109451: Summary: Introduce a new frontend flag `-fswift-async-fp={auto|always|never}` that controls how code generation sets the Swift extended async frame info bit. There are three possibili

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf670c5aeeef0: Add a new frontend flag `-fswift-async-fp={auto|always|never}` (authored by aschwaighofer). Changed prior to commit: https://reviews

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

urnathan added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3198-3199 // lookups will find it. MergeDC->makeDeclVisibleInContextImpl(New, /*Internal*/true); +if (isa(New) && Name.getAsString() == "std") + if (!Reader.getSema()->StdName

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

MaskRay added a comment. In D109727#3003498 , @luismarques wrote: > Regarding D74399 , cmake on a fedora RISC-V > host still detects a generic triple: > > -- LLVM host triple: riscv64-unknown-linux-gnu > -- LLVM defa

[clang] 003fed8 - [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

Author: Matthew Voss Date: 2021-09-16T09:20:05-07:00 New Revision: 003fed8269b3f6d2b1618b670fc73d28972999e4 URL: https://github.com/llvm/llvm-project/commit/003fed8269b3f6d2b1618b670fc73d28972999e4 DIFF: https://github.com/llvm/llvm-project/commit/003fed8269b3f6d2b1618b670fc73d28972999e4.diff

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c (authored by ormris). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/n

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. @yaxunl Under what criteria should an alias not be removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing

[clang] 976d474 - [OpenMP] Support construct trait set for Clang

Author: cchen Date: 2021-09-16T11:34:31-05:00 New Revision: 976d474bec357d7712884ce4691be45d247325bd URL: https://github.com/llvm/llvm-project/commit/976d474bec357d7712884ce4691be45d247325bd DIFF: https://github.com/llvm/llvm-project/commit/976d474bec357d7712884ce4691be45d247325bd.diff LOG: [O

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG976d474bec35: [OpenMP] Support construct trait set for Clang (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372979. csmulhern marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/cl

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22410 + ");", + Style); +} MyDeveloperDay wrote: > Can you assert the cases it won't do (given your descript

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

rmaz created this revision. rmaz added reviewers: dexonsmith, manmanren, vsapsai. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This refactor changes the GlobalMethodPool to a class that contains the DenseMap of methods. This is to a

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS If you add so many RUN lines at once, please use unittests instead. This wo

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

dim added a comment. I can at least confirm that both the original test case for bug 51862 (from https://github.com/Macaulay2/frobby ) and the reduced test case compile successfully with this patch added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan updated this revision to Diff 372984. Jake-Egan added a comment. Added missing tests: clang/test/Modules/ModuleDebugInfoDwoId.cpp clang/test/PCH/externally-retained.m clang/test/PCH/pending-ids.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

gregmiller added a comment. Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your

[clang] aefb81a - Removing some spurious whitespace; NFC

Author: Aaron Ballman Date: 2021-09-16T13:14:08-04:00 New Revision: aefb81a33a6d44048186010677eb1c0e6c6cac12 URL: https://github.com/llvm/llvm-project/commit/aefb81a33a6d44048186010677eb1c0e6c6cac12 DIFF: https://github.com/llvm/llvm-project/commit/aefb81a33a6d44048186010677eb1c0e6c6cac12.diff

[clang] c5f480f - [OpenMP] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off build after D109635

Author: Fangrui Song Date: 2021-09-16T10:19:35-07:00 New Revision: c5f480fcbec04f46a9cfcad08914665ff83d8d8a URL: https://github.com/llvm/llvm-project/commit/c5f480fcbec04f46a9cfcad08914665ff83d8d8a DIFF: https://github.com/llvm/llvm-project/commit/c5f480fcbec04f46a9cfcad08914665ff83d8d8a.diff

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

MaskRay added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:741 +llvm::omp::TraitProperty Top = ConstructTraits.pop_back_val(); +assert(Top == Trait && "Something left a trait on the stack!"); + } I fixed -Wunused-variable in c5f

[clang] afb6223 - Support Unicode 14 identifiers

Author: Corentin Jabot Date: 2021-09-16T13:21:27-04:00 New Revision: afb6223bc53034973379863d08cbee322149569e URL: https://github.com/llvm/llvm-project/commit/afb6223bc53034973379863d08cbee322149569e DIFF: https://github.com/llvm/llvm-project/commit/afb6223bc53034973379863d08cbee322149569e.diff

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks for splitting this out -- left some comments inline, LGTM after that. Comment at: clang/include/clang/Sema/Sema.h:1422-1427 /// Method Pool - allows efficie

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c319fdc6b3: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR… (authored by gAlfonso-bit, committed by Mordante). Herald added a project: LLDB. Herald added a reviewer: libunwin

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

JonChesterfield added a comment. Dropping PATHS /opt/rocm from the openmp parts will break people using an existing rocm install with trunk llvm. I think it would be reasonable to look at whatever ROCM_PATH is set to instead of assuming /opt/rocm. Is that a variable we can pass to find_package?

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

Quuxplusone added a comment. FWIW, this is almost entirely above my pay grade. Getting rid of that extra bool parameter throughout //looks// awesome, though. :) I do think it might be a good idea to include one or two tests that actually run all the way through codegen, e.g. https://godbolt.org

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 372989. ilyakuteev marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/

[clang-tools-extra] f1e8ceb - docs: correct SPHNIX document reference

Author: Saleem Abdulrasool Date: 2021-09-16T17:43:59Z New Revision: f1e8ceb3054a02f4225ff7ab74cde10b70826707 URL: https://github.com/llvm/llvm-project/commit/f1e8ceb3054a02f4225ff7ab74cde10b70826707 DIFF: https://github.com/llvm/llvm-project/commit/f1e8ceb3054a02f4225ff7ab74cde10b70826707.diff

[PATCH] D109854: Support Unicode 14 identifiers

aaron.ballman closed this revision. aaron.ballman added a comment. I committed this on your behalf in afb6223bc53034973379863d08cbee322149569e , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

rmaz updated this revision to Diff 372999. rmaz added a comment. - keep `std::pair`, but move to `GlobalMethodPool::Lists` - add `const` - `val` -> `&&Val` - move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109898/new/ https://reviews.ll

[clang] 22f01cd - [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Author: Jake Egan Date: 2021-09-16T14:04:42-04:00 New Revision: 22f01cd4fc5d2a02a156722e1dab0398fc860e74 URL: https://github.com/llvm/llvm-project/commit/22f01cd4fc5d2a02a156722e1dab0398fc860e74 DIFF: https://github.com/llvm/llvm-project/commit/22f01cd4fc5d2a02a156722e1dab0398fc860e74.diff LOG

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

This revision was automatically updated to reflect the committed changes. Closed by commit rG22f01cd4fc5d: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

ye-luo requested changes to this revision. ye-luo added a comment. This revision now requires changes to proceed. The fallback opt/rocm is desired. If a module system needs to point to the specific rocm installation. Set CMAKE_PREFIX_PATH= in the module file. If you would like to honor ROCM_PATH

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap created this revision. Conanap added reviewers: PowerPC, nemanjai, saghir. Conanap added projects: PowerPC, LLVM, clang. Herald added subscribers: kbarton, hiraditya. Conanap requested review of this revision. This patch removes the uneccessary mf/mtvsr generated in conjunction with xscvdp

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 373009. Conanap added a comment. Removed unintended change, moved pattern to more appropriate location, reduced added complexity to 600 as it still works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 F

  1   2   >