[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm (one minor comment issue noted below). Thanks! Comment at: clang/test/CodeGen/thinlto-funcattr-prop.ll:17 -; CHECK: ^2 = gv: (guid: 13959900437860518209,

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

saiislam added a comment. In D110083#3019010 , @MyDeveloperDay wrote: > Do you mind if I fix the build failures by encasing the codelike section in a > .. code::? > > diff --git a/clang/docs/ClangOffloadBundler.rst >

[PATCH] D110282: [PowerPC] SemaChecking for darn family of builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG840afbde48e9: [PowerPC] SemaChecking for darn family of builtins (authored by Conanap). Changed prior to commit:

[clang] 840afbd - [PowerPC] SemaChecking for darn family of builtins

Author: Albion Fung Date: 2021-09-23T23:38:59-05:00 New Revision: 840afbde48e90213028174fdba715e10aa39dd85 URL: https://github.com/llvm/llvm-project/commit/840afbde48e90213028174fdba715e10aa39dd85 DIFF: https://github.com/llvm/llvm-project/commit/840afbde48e90213028174fdba715e10aa39dd85.diff

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

pirama added a reviewer: nickdesaulniers. pirama added a subscriber: nickdesaulniers. pirama added a comment. @nickdesaulniers I presume this is still necessary? See https://reviews.llvm.org/D53463 for why we added this. (The Android kernel build does not use the Android triple.)

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

modimo added inline comments. Comment at: clang/test/CodeGen/thinlto-funcattr-prop.ll:16 + +; CHECK: ^2 = gv: (guid: 13959900437860518209, summaries: (function: (module: ^0, flags: (linkage: external, visibility: default, notEligibleToImport: 0, live: 1, dsoLocal: 1,

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

modimo updated this revision to Diff 374723. modimo marked 3 inline comments as done. modimo added a comment. Address follow-ups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 Files:

[clang] 165926a - Fix that same path separator issue again...

Author: David Blaikie Date: 2021-09-23T21:15:01-07:00 New Revision: 165926aa4ce9f05572cf8828210a1af5ce286bdb URL: https://github.com/llvm/llvm-project/commit/165926aa4ce9f05572cf8828210a1af5ce286bdb DIFF: https://github.com/llvm/llvm-project/commit/165926aa4ce9f05572cf8828210a1af5ce286bdb.diff

[clang] 8d9ddd4 - DebugInfo: STN: Handle unreconstitutable types in function types

Author: David Blaikie Date: 2021-09-23T21:13:16-07:00 New Revision: 8d9ddd4f509c54d05a38427d7999c061d88ca35c URL: https://github.com/llvm/llvm-project/commit/8d9ddd4f509c54d05a38427d7999c061d88ca35c DIFF: https://github.com/llvm/llvm-project/commit/8d9ddd4f509c54d05a38427d7999c061d88ca35c.diff

[PATCH] D110359: [clang-format] ensure clang-format command-line argument sets up the default left/right qualifier ordering

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Just fix what clang-format tells you to. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110359/new/ https://reviews.llvm.org/D110359

[clang] e70082e - Remove non-portable directory separator from test

Author: David Blaikie Date: 2021-09-23T20:47:19-07:00 New Revision: e70082e9add7e82e580148fbd4c0a5a832763cb6 URL: https://github.com/llvm/llvm-project/commit/e70082e9add7e82e580148fbd4c0a5a832763cb6 DIFF: https://github.com/llvm/llvm-project/commit/e70082e9add7e82e580148fbd4c0a5a832763cb6.diff

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

MaskRay added a comment. You may need to check whether the Android clang has correct `clang -dumpmachine`. If not, specify `LLVM_HOST_TRIPLE` explicitly in CMake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110379/new/

[PATCH] D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=

MaskRay created this revision. MaskRay added reviewers: pirama, srhines. Herald added subscribers: danielkiss, kristof.beyls. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These values allow, for example, `--target=aarch64` and

[clang] 25ac0d3 - DebugInfo: Implement the -gsimple-template-names functionality

Author: David Blaikie Date: 2021-09-23T19:58:32-07:00 New Revision: 25ac0d3c73d68c017546eb622ba7632c6b581bfb URL: https://github.com/llvm/llvm-project/commit/25ac0d3c73d68c017546eb622ba7632c6b581bfb DIFF: https://github.com/llvm/llvm-project/commit/25ac0d3c73d68c017546eb622ba7632c6b581bfb.diff

[clang] afab3c4 - [Driver] Default Generic_GCC x86 to -fasynchronous-unwind-tables

Author: Fangrui Song Date: 2021-09-23T19:39:50-07:00 New Revision: afab3c488f0c86af87e262cc7454e04de18e3e6a URL: https://github.com/llvm/llvm-project/commit/afab3c488f0c86af87e262cc7454e04de18e3e6a DIFF: https://github.com/llvm/llvm-project/commit/afab3c488f0c86af87e262cc7454e04de18e3e6a.diff

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); jdoerfert wrote: > arsenm wrote: > > Why is there a special

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#3018045 , @ldionne wrote: > This sounds more reasonable to me, however we need to ship `` in > libc++ before we enable this, or else we're going to start suggesting that > users include `` when we don't have it.

[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

pengfei updated this revision to Diff 374704. pengfei added a comment. Move mask to the second to last operand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110336/new/ https://reviews.llvm.org/D110336 Files:

[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2021 TARGET_BUILTIN(__builtin_ia32_vfmaddcph256_maskz, "V8fV8fV8fV8fUc", "ncV:256:", "avx512fp16,avx512vl") -TARGET_BUILTIN(__builtin_ia32_vfmaddcph512_mask, "V16fV16fV16fV16fUsIi",

[PATCH] D109322: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c:8 -// // CHECK-RV64-LABEL: @test_vadd_vv_i8mf8( Please pre-commit this change to reduce noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek updated this revision to Diff 374699. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. There isn't enough information in the test to determine whether this adequately improves code generation (in fact, whether it improves code generation at all).

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:144 +} else { + CmdArgs.push_back("--as-needed"); +} as-needed needs push-state as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

nemanjai added a comment. This broke buildbots that have -Werror specified. I pushed in a fix in https://reviews.llvm.org/rG76d845cb169f048cb6f2176c3e7a6534dc5af097. Also, please consider formatting your commit messages to prevent wrapping. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 76d845c - [clang-format] Fix unittest failures with -Werror

Author: Nemanja Ivanovic Date: 2021-09-23T18:24:39-05:00 New Revision: 76d845cb169f048cb6f2176c3e7a6534dc5af097 URL: https://github.com/llvm/llvm-project/commit/76d845cb169f048cb6f2176c3e7a6534dc5af097 DIFF:

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109975/new/ https://reviews.llvm.org/D109975

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek updated this revision to Diff 374690. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp

[clang] 7647a84 - Fix -fno-unwind-tables -fasynchronous-unwind-tables to emit unwind tables

Author: Fangrui Song Date: 2021-09-23T16:15:40-07:00 New Revision: 7647a8413be55568a8a80fae379a872b7359f5b5 URL: https://github.com/llvm/llvm-project/commit/7647a8413be55568a8a80fae379a872b7359f5b5 DIFF: https://github.com/llvm/llvm-project/commit/7647a8413be55568a8a80fae379a872b7359f5b5.diff

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:495 + const QualType , + bool Underlying = false) { const auto = AST.getSourceManager();

[PATCH] D110371: [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9d1a679a1c9: [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES

[clang] e9d1a67 - [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker.

Author: Hongtao Yu Date: 2021-09-23T15:50:40-07:00 New Revision: e9d1a679a1c9cb309aea8c5d944e55865d38b867 URL: https://github.com/llvm/llvm-project/commit/e9d1a679a1c9cb309aea8c5d944e55865d38b867 DIFF: https://github.com/llvm/llvm-project/commit/e9d1a679a1c9cb309aea8c5d944e55865d38b867.diff

[PATCH] D110371: [CSSPGO] Do not pass -fpseudo-probe-for-profiling to the linker.

hoy created this revision. Herald added subscribers: ormris, modimo, wenlei, steven_wu, hiraditya. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The correponding linker switch has been removed by https://reviews.llvm.org/D110209, so

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3019070 , @sammccall wrote: > A few comments on the behavior & clangd changes. I can't say I understand > enough about how deduction is implemented to give a proper review of the guts > :-( Thanks! > In general

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); arsenm wrote: > Why is there a special AllocaInsertPt iterator

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75fb1ee794e: [clangd] Support `#pragma mark` in the outline (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/

[clang] d75fb1e - [clangd] Support `#pragma mark` in the outline

Author: David Goldman Date: 2021-09-23T17:13:30-04:00 New Revision: d75fb1ee794e94a011e88739df84c359c987a65b URL: https://github.com/llvm/llvm-project/commit/d75fb1ee794e94a011e88739df84c359c987a65b DIFF: https://github.com/llvm/llvm-project/commit/d75fb1ee794e94a011e88739df84c359c987a65b.diff

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); Why is there a special AllocaInsertPt iterator in the first place?

[clang] 5fcde57 - [clang-format] NFC ensure Penality variable is passed back with Fixes

Author: mydeveloperday Date: 2021-09-23T22:05:20+01:00 New Revision: 5fcde57b73fbc068c51f55a80894a6ef208d4afd URL: https://github.com/llvm/llvm-project/commit/5fcde57b73fbc068c51f55a80894a6ef208d4afd DIFF:

[PATCH] D110359: [clang-format] ensure clang-format command-line argument sets up the default left/right qualifier ordering

MyDeveloperDay updated this revision to Diff 374660. MyDeveloperDay added a comment. Rename the ConstAlignment variable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110359/new/ https://reviews.llvm.org/D110359 Files: clang/tools/clang-format/ClangFormat.cpp Index:

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau updated this revision to Diff 374654. qchateau added a comment. - Rebase - Add cli argument to set the cache size - Reduce default cache size to 1 (to allow fast open/close/reopen) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97417/new/

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

chrish_ericsson_atx added a comment. I believe this exposed another odd issue where a true positive (enabled by this commit) disappears when unrelated code is not present. Bug filed as: https://bugs.llvm.org/show_bug.cgi?id=51950. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110359: [clang-format] [NFC] ensure clang-format command-line argument sets up the default left/right qualifier ordering

MyDeveloperDay updated this revision to Diff 374652. MyDeveloperDay added a comment. Allow passing of desired qualifier order on the command line clang-format --qualifier-alignment="const static type volatile" test_file.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110359/new/

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

sammccall added a comment. A few comments on the behavior & clangd changes. I can't say I understand enough about how deduction is implemented to give a proper review of the guts :-( In general eliminating type-parameter-0-0 is great and retaining sugar gives us more options for display.

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#3018830 , @ldionne wrote: > In D109408#2996128 , @zhouyizhou > wrote: > >> In D109408#2996092 , @Quuxplusone >> wrote: >> >>> I

[PATCH] D110359: [clang-format] [NFC] ensure clang-format command-line argument sets up the default left/right qualifier ordering

MyDeveloperDay added a comment. This is to support D69764: [clang-format] Add Left/Right Const fixer capability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110359/new/ https://reviews.llvm.org/D110359

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. FYI Included one more typo fix in ExecutorAddress.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110260/new/ https://reviews.llvm.org/D110260 ___ cfe-commits mailing list

[PATCH] D110359: [clang-format] [NFC] ensure clang-format command-line argument sets up the default left/right qualifier ordering

MyDeveloperDay created this revision. MyDeveloperDay added a reviewer: HazardyKnusperkeks. MyDeveloperDay added a project: clang-format. MyDeveloperDay requested review of this revision. Herald added a project: clang. When specifying the alignment direction on the command line ensure we set up

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG767b328e506e: [ORC] Minor renaming and typo fixes (NFC) (authored by sgraenitz). Changed prior to commit:

[clang] 767b328 - [ORC] Minor renaming and typo fixes (NFC)

Author: Stefan Gränitz Date: 2021-09-23T21:33:34+02:00 New Revision: 767b328e506ef069ecbb89b7cc9e2da7f8f84c6c URL: https://github.com/llvm/llvm-project/commit/767b328e506ef069ecbb89b7cc9e2da7f8f84c6c DIFF:

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374644. tra added a comment. Sort push/pop_macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581 + CmdArgs.push_back("--push-state"); + CmdArgs.push_back("--as-needed"); if (OnlyLibstdcxxStatic) MaskRay wrote: > The --as-needed change should be dropped from

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

MyDeveloperDay added a comment. Do you mind if I fix the build failures by encasing the codelike section in a .. code::? diff --git a/clang/docs/ClangOffloadBundler.rst b/clang/docs/ClangOffloadBundler.rst index 312c45602c99..ac4c5b51904f 100644 --- a/clang/docs/ClangOffloadBundler.rst

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374642. tra added a comment. Disable sparse ops for pre-sm_60 GPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa44ab1702539: [clang-format] Add Left/Right Const fixer capability (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES

[clang] a44ab17 - [clang-format] Add Left/Right Const fixer capability

Author: mydeveloperday Date: 2021-09-23T20:00:33+01:00 New Revision: a44ab1702539c9ef3aea292e23cfbff17897bdbd URL: https://github.com/llvm/llvm-project/commit/a44ab1702539c9ef3aea292e23cfbff17897bdbd DIFF:

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. @MaskRay Do you think we should gate the use of this feature on `-fbinutils-version=` or `-fuse-ld=lld`? It'd be nice if the owner of `clang-ppc64le-rhel` builder could update the binutils version but I'm not sure how feasible is it. Repository: rG LLVM Github

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. If there are no other objections I'm going to land this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong added a comment. I had to move the definition of `ConstraintAssignor` after the definition of `RangeConstraintManager` b/c I am using `assumeSymNE` in the new logic. Unfortunately, the diff does not show clearly the changes inside the moved hunk, so I try to indicate the important

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong created this revision. martong added reviewers: NoQ, vsavchenko, steakhal, Szelethus, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb added a comment. @dblaikie yeah, the problem(s) seemed easier and smaller :( Basically, we have two issues with local scopes here: (1) function-scoped entities like static variables, type definitions/typedefs, etc have incorrect (empty) parent DIE if the function containing them was

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Let's give it a first shot. When it has landed maybe I find the time to look into the attributes. ;) Comment at:

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

ychen added a comment. In D103938#3018588 , @aaron.ballman wrote: > In D103938#3013503 , @thakis wrote: > >> This flags this code from absl: >> >> template > typename std::enable_if::value, >>

[clang] 5933726 - Revert "Diagnose -Wunused-value based on CFG reachability"

Author: Yuanfang Chen Date: 2021-09-23T11:12:00-07:00 New Revision: 59337263ab45d7657ee901eb5525a21967c46265 URL: https://github.com/llvm/llvm-project/commit/59337263ab45d7657ee901eb5525a21967c46265 DIFF: https://github.com/llvm/llvm-project/commit/59337263ab45d7657ee901eb5525a21967c46265.diff

[PATCH] D110336: [X86][FP16] Add more builtins to avoid multi evaluation problems & add 2 missed intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2021 TARGET_BUILTIN(__builtin_ia32_vfmaddcph256_maskz, "V8fV8fV8fV8fUc", "ncV:256:", "avx512fp16,avx512vl") -TARGET_BUILTIN(__builtin_ia32_vfmaddcph512_mask, "V16fV16fV16fV16fUsIi",

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. In D106030#3018754 , @aeubanks wrote: > Would it be ok to split this into two attributes, dontcall-warn and > dontcall-error? So we rely less on the Clang AST when determining if a > dontcall call should be emitted as a

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov updated this revision to Diff 374625. mizvekov added a comment. adjust column number on cert-static-object-exception test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 Files:

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f519825ba56: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2f51982 - [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

Author: Thomas Lively Date: 2021-09-23T11:01:36-07:00 New Revision: 2f519825ba56cc2377ef9fbf1514944215ed9d0d URL: https://github.com/llvm/llvm-project/commit/2f519825ba56cc2377ef9fbf1514944215ed9d0d DIFF: https://github.com/llvm/llvm-project/commit/2f519825ba56cc2377ef9fbf1514944215ed9d0d.diff

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

ldionne added a comment. In D109408#2996128 , @zhouyizhou wrote: > In D109408#2996092 , @Quuxplusone > wrote: > >> I was going to land this just now, but then realized that I've lost the >> thread of why we're

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Problem is fixed with D110345 , Thank you very much for quick fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110260/new/ https://reviews.llvm.org/D110260

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 ___

[PATCH] D108567: Implement #pragma clang final extension

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but please wait a bit before landing in case @rsmith has concerns. Comment at: clang/test/Lexer/final-macro.c:14 +// expected-warning@+2{{macro

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aeubanks added a comment. Would it be ok to split this into two attributes, dontcall-warn and dontcall-error? So we rely less on the Clang AST when determining if a dontcall call should be emitted as a warning or an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374614. Conanap added a comment. Added P7 and P8 run lines for BE CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files:

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones updated this revision to Diff 374609. edward-jones added a comment. Herald added a subscriber: achieveartificialintelligence. Changes here: - Merged the separate attributes overlaycall and overlaydata into a single overlay attribute (though I may need to undo this to match the

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374610. quinnp added a comment. Addressing review comment about ISelLowering of `test_data_class`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files:

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

tlively updated this revision to Diff 374606. tlively added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110295/new/ https://reviews.llvm.org/D110295 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. In D110260#3018555 , @sgraenitz wrote: > Interesting, it does work for me now on macOS with both, shared libs on and > off. Can you please check if you get something like this as well: > > ➜ nm

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374605. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374604. tra added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov created this revision. Herald added a subscriber: jdoerfert. mizvekov updated this revision to Diff 374246. mizvekov added a comment. mizvekov updated this revision to Diff 374365. Herald added subscribers: kbarton, nemanjai. mizvekov updated this revision to Diff 374395. Herald added

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

dblaikie added a comment. There have been a few different patches going around related to mis-scoped things - imported entities and types, maybe other things too? (static variables? Or has that already been fixed now) Perhaps some summary of the state of all these patches sent to

[PATCH] D110315: [Sema] Fix a null pointer reference crash.

thakis added a comment. Fixed in https://github.com/llvm/llvm-project/commit/8ecf3660f2de3b88d10db0fd52d0bc80bda33dcc , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110315/new/ https://reviews.llvm.org/D110315

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:65 - return cast(Op.getGlobal()); + return dyn_cast(Op.getGlobal()); } gandhi21299 wrote: > arsenm wrote: > > I think this is not the right place for this. If

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:65 - return cast(Op.getGlobal()); + return dyn_cast(Op.getGlobal()); } arsenm wrote: > I think this is not the right place for this. If we can determine

[PATCH] D110289: [libc++] Remove unused macro in __config

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6126faba060: [libc++] Remove unused macro in __config (authored

[clang-tools-extra] e6126fa - [libc++] Remove unused macro in __config

Author: Louis Dionne Date: 2021-09-23T13:09:32-04:00 New Revision: e6126faba060d5341dae6c5cc99a22a80d8c4d23 URL: https://github.com/llvm/llvm-project/commit/e6126faba060d5341dae6c5cc99a22a80d8c4d23 DIFF: https://github.com/llvm/llvm-project/commit/e6126faba060d5341dae6c5cc99a22a80d8c4d23.diff

[PATCH] D110289: [libc++] Remove unused macro in __config

ldionne accepted this revision as: libc++. ldionne added a comment. Other CI failures appear unrelated to the change, so I'm shipping this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110289/new/ https://reviews.llvm.org/D110289

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

tra added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:116-117 + // Enums corresponding to clang options for linking bitcode, i.e., + // -mlink-builtin-bitcode or -mlink-bitcode-file + enum BitCodeLinkOpt { It appears that what we

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

aaron.ballman added a comment. In D103938#3013503 , @thakis wrote: > This flags this code from absl: > > template typename std::enable_if::value, > int>::type = > (GenT{}, 0)> > constexpr FlagDefaultArg DefaultArg(int) {

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUResourceUsageAnalysis.cpp:65 - return cast(Op.getGlobal()); + return dyn_cast(Op.getGlobal()); } I think this is not the right place for this. If we can determine the callee function,

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz added a comment. In D110260#3018412 , @xgupta wrote: > Yeah we need testcases, now it says > > JIT session error: Symbols not found: [ return1 ] > JIT session error: Failed to materialize symbols: { (main, { foo_body }) } > Unable to lazily

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

thakis added a comment. In D103938#3013503 , @thakis wrote: > This flags this code from absl: Did you see this comment? Looks like this relanded, but it still warns there even though it has an effect there I think (?) Repository: rG LLVM Github

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

martong added a comment. In D104285#3018257 , @ASDenysPetrov wrote: > @martong > BTW, this patch is the first one in the stack. There are also D107339 > and D108032 > . You could

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson added a comment. In D110276#3016312 , @tejohnson wrote: > In D110276#3016295 , @thakis wrote: > >> Oh, the win failure >>

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D110260#3018110 , @sgraenitz wrote: > Thanks @xgupta for your note! The parameter passed to > `EPCIndirectionUtils::Create()` in the example was

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap marked 3 inline comments as done. Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:8 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \ +; RUN: -mcpu=pwr7 < %s | FileCheck %s + kamaub wrote: > It

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374578. Conanap added a comment. Updated test cases, fixed a typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9912fe4eac9: [PowerPC] Add range checks for P10 Vector Builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f9912fe - [PowerPC] Add range checks for P10 Vector Builtins

Author: Quinn Pham Date: 2021-09-23T11:05:49-05:00 New Revision: f9912fe4eac91f27965c22d015b3109c5158d050 URL: https://github.com/llvm/llvm-project/commit/f9912fe4eac91f27965c22d015b3109c5158d050 DIFF: https://github.com/llvm/llvm-project/commit/f9912fe4eac91f27965c22d015b3109c5158d050.diff

  1   2   >