[PATCH] D135558: [Clang][NFC]Use isa instead of dyn_cast in shouldAddReversedEqEq

liaolucy abandoned this revision. liaolucy added a comment. In D135558#3848649 , @tbaeder wrote: > This was fixed as > https://github.com/llvm/llvm-project/commit/6c49d5db30227d21e929bb12dc046c36ede67fad. > Note that for such patches, you don't need to

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3847396 , @tarunprabhu wrote: > Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. Thanks for the update! > I still cannot reproduce the build failure on my end. @MatsPetersson tested > this patch an

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. In D129156#3848692 , @awarzynski wrote: > In D129156#3847396 , @tarunprabhu > wrote: > >> Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. > > Thanks for the update! >

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3848704 , @clementval wrote: >>> I still cannot reproduce the build failure on my end. @MatsPetersson tested >>> this patch and the tests passed. >> >> @MatsPetersson & @clementval , could you share you build comma

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. > FAOD: I think this should not be about "who's patches" - but about the > compilation model and command lines that we want to end up with. BTW, in the current context, when I say "my" and "your", I just want to refer the corresponding things. There is no means to off

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3848745 , @ChuanqiXu wrote: >> FAOD: I think this should not be about "who's patches" - but about the >> compilation model and command lines that we want to end up with. > > BTW, in the current context, when I say "my" a

[PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > although those changes don't actually test the code path changed here Yeah I'm just cargo culting on that one so it doesn't look strange that a few are missing. If we're going

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

tschuett added a comment. Clang header modules started with implicit builds and module caches. Apple is moving too explicit builds. There are all kinds of problems with implicit module builds. I believe that C++20 modules shouldn't make the same mistake. CHANGES SINCE LAST ACTION https://rev

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein updated this revision to Diff 466729. hokein marked an inline comment as done. hokein added a comment. add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135440/new/ https://reviews.llvm.org/D135440 Files: clang/include/clang/Basic/

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3848822 , @tschuett wrote: > Clang header modules started with implicit builds and module caches. Apple is > moving too explicit builds. There are all kinds of problems with implicit > module builds. I believe that C++2

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

tschuett added a comment. In D134267#3848838 , @iains wrote: > In D134267#3848822 , @tschuett > wrote: > >> Clang header modules started with implicit builds and module caches. Apple >> is moving too explicit bu

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein added a comment. In D135440#3847720 , @nickdesaulniers wrote: > Is it worth it and possible to fully decompose `LocalSLocEntryTable` into > arrays of its constituent parts, and only construct a `SLocEntry` when > necessary? Fully decomposing `L

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 466731. ckandeler added a comment. Template parameters are definitions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHig

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3848793 , @iains wrote: > In D134267#3848745 , @ChuanqiXu > wrote: > >>> FAOD: I think this should not be about "who's patches" - but about the >>> compilation model and com

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3848822 , @tschuett wrote: > Clang header modules started with implicit builds and module caches. Apple is > moving too explicit builds. There are all kinds of problems with implicit > module builds. I believe that

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3848862 , @ChuanqiXu wrote: > In D134267#3848793 , @iains wrote: > >> In D134267#3848745 , @ChuanqiXu >> wrote: >> FAOD: I think th

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3848876 , @iains wrote: > If we are going to **//require//** the serialisation/deserialisation for > correctness then IMO we should have an error for an incorrect compilation. Of course. > I still feel that deseria

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3848883 , @ChuanqiXu wrote: > In D134267#3848876 , @iains wrote: > >> If we are going to **//require//** the serialisation/deserialisation for >> correctness then IMO we should h

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3848958 , @iains wrote: > In D134267#3848883 , @ChuanqiXu > wrote: > >> In D134267#3848876 , @iains wrote: >> >>> If we are going to

[PATCH] D129156: Add -fpass-plugin option to Flang

Leporacanthicus added a comment. > @MatsPetersson & @clementval , could you share you build command so that the > failure can be reproduced before this re-lands? I can't share the same command that I used, because it's some old CMAKE command that I no longer have in my history. But I tested thi

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3848974 , @ChuanqiXu wrote: > In D134267#3848958 , @iains wrote: > >> In D134267#3848883 , @ChuanqiXu >> wrote: >> >>> In D134267#384887

[PATCH] D135657: add time traces for loading PCH files

Trass3r created this revision. Herald added a project: All. Trass3r requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fills gaps in the time trace when precompiled headers are involved. Repository: rG LLVM Github Monorepo https://reviews

[clang] 6547565 - [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

Author: wanglei Date: 2022-10-11T18:12:37+08:00 New Revision: 6547565e7bdcd9c3f683ad196b62d08c7061fdf1 URL: https://github.com/llvm/llvm-project/commit/6547565e7bdcd9c3f683ad196b62d08c7061fdf1 DIFF: https://github.com/llvm/llvm-project/commit/6547565e7bdcd9c3f683ad196b62d08c7061fdf1.diff LOG:

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6547565e7bdc: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for… (authored by wangleiat, committed by SixWeining). Repositor

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

thakis added a comment. This seems to break check-clamg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

royjacobson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1476 is false. Note this trait will also return false when the initialization of ``T`` from ``U`` is ill-formed. +* ``__reference_constructs_from_temporary(T, U)`` (C++) royjac

[clang] b32a1bd - Revert "[clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch"

Author: Weining Lu Date: 2022-10-11T19:21:28+08:00 New Revision: b32a1bdf42b0be59d02876874b6764b4700ee7d7 URL: https://github.com/llvm/llvm-project/commit/b32a1bdf42b0be59d02876874b6764b4700ee7d7 DIFF: https://github.com/llvm/llvm-project/commit/b32a1bdf42b0be59d02876874b6764b4700ee7d7.diff LO

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

SixWeining reopened this revision. SixWeining added a comment. This revision is now accepted and ready to land. This breaks test: Preprocessor/init-loongarch.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D1355

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466767. DmitryPolukhin added a comment. Added testcase for clang-tidy diagnostics as with --warnings-as-errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat added a comment. In D135526#3849117 , @thakis wrote: > This seems to break check-clang: http://45.33.8.238/linux/88687/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks a lot, I'll fix it right away. Repo

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin added a comment. In D135367#3842950 , @njames93 wrote: > LGTM, just maybe include a test case where a warning from a clang-tidy check > is promoted to an error as well. Thank you for the review! I've added a test case for clang-tidy check

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 466766. domada edited the summary of this revision. domada added a comment. 1. Modified generation of align assumptions. OMPIRBuilder generates now only assumptions calls. The arguments of the assumption calls are generated by Clang. 2. Added integration test

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. This is ok, but see the note I added about object-file compatibility. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:646-647 + If there are no initalizers at all (and also

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked an inline comment as done. domada added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2640 if (UseOMPIRBuilder) { +llvm::DenseMap AlignedVars; // Emit the associated statement and get its loop representation. ---

[PATCH] D134654: [clang] Detect header loops

urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; philnik wrote: > aaron.ballman wrote:

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 466774. domada marked an inline comment as done. domada added a comment. 1. Update description of AlignedVars argument CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/lib/CodeGen/CGStmtOpenMP

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked an inline comment as done. domada added inline comments. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1871 + } +} +TEST_F(OpenMPIRBuilderTest, ApplySimdlen) { jdoerfert wrote: > This doesn't actually test that 2 assumes with alignmen

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat updated this revision to Diff 466775. wangleiat added a comment. Fix `Preprocessor/init-loongarch.c` test failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 Files: clang/lib/Basic/Targets

[PATCH] D134475: Add C++11 attribute msvc::constexpr

aaron.ballman added a subscriber: cpplearner. aaron.ballman added a comment. Pulling a comment out of https://reviews.llvm.org/D133853 that's relevant here: In D133853#3844851 , @cpplearner wrote: > In D133853#3808674

[clang] 42b7079 - Reland "[Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC"

Author: Weining Lu Date: 2022-10-11T19:51:48+08:00 New Revision: 42b70793a1df473be9c78b4141d3f3cedcbac988 URL: https://github.com/llvm/llvm-project/commit/42b70793a1df473be9c78b4141d3f3cedcbac988 DIFF: https://github.com/llvm/llvm-project/commit/42b70793a1df473be9c78b4141d3f3cedcbac988.diff LO

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42b70793a1df: Reland "[Clang][LoongArch] Add inline asm support fo

[PATCH] D134475: Add C++11 attribute msvc::constexpr

aaron.ballman added a comment. In D134475#3829583 , @RIscRIpt wrote: >> TODO: I think, I'll need to read more about constexpr for functions in >> standard (and LLVM code), to add relevant restrictions here. > > In the standard I was able to find the foll

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdefe7c07f0db: Reland "[clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth… (authored by wangleiat, committed by SixWeining). Repo

[clang] defe7c0 - Reland "[clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch"

Author: wanglei Date: 2022-10-11T20:36:09+08:00 New Revision: defe7c07f0db9d18a59087dd7aaf7becb38595b2 URL: https://github.com/llvm/llvm-project/commit/defe7c07f0db9d18a59087dd7aaf7becb38595b2 DIFF: https://github.com/llvm/llvm-project/commit/defe7c07f0db9d18a59087dd7aaf7becb38595b2.diff LOG:

[PATCH] D135335: [HLSL] Add Resource kind for HLSLResourceAttr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135335/new/ https://reviews.llvm.org/D135335

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus added a comment. Some early results: https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?review-status=Unreviewed&review-status=Confirmed%20bug&detection-status=New&detection-status=Reopened&detection-status=Unresolved&is-unique=on&run=%2acxxnew_baseline&newcheck=%2acxxne

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d859a1cdee3: [libclang] CIndex: Visit UsingTypeLoc as TypeRef (authored by kiloalphaindia, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 5d859a1 - [libclang] CIndex: Visit UsingTypeLoc as TypeRef

Author: Kai Stierand Date: 2022-10-11T15:01:31+02:00 New Revision: 5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b URL: https://github.com/llvm/llvm-project/commit/5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b DIFF: https://github.com/llvm/llvm-project/commit/5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b.diff

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.cpp:39 + assert(It != SrcMap.end()); + It--; // We want the offset *before* the given one. return It->second; While I think the comment here is correct, the decrement itself certainly i

[PATCH] D135384: [AIX] Enable the use of the -pg flag

cebowleratibm added inline comments. Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:38 +const std::string &targetTriple = M.getTargetTriple(); +if (targetTriple.find("powerpc-ibm-aix") == std::string::npos || +targetTriple.find("powerpc64-ibm-aix"

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3848728 , @awarzynski wrote: > Thanks Valentin! Switching between generators will definitely change the > order in which libraries will built (and, AFAIK, the order is > non-deterministic to begin with). I will t

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a comment. >> In D129755#3842744 , @hans wrote: >> >>> >> >> I'll give you some time to reply before I reland, but I can't see a bug >> here. For the next time, as already pointed out, give the involved people >> some time to reply b

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Adding the clang-vendors group for awareness of potential disruptions from these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/ https://reviews.llvm.

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3846591 , @erichkeane wrote: > In D126907#3844788 , @BertalanD > wrote: > >> Hi @erichkeane, >> >> This change broke compilation of this program >> (https://godbolt.org/z/

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

stuij created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC behavior regarding defining __SOFTFP__ when (implicitly) specifying -mfloat-abi=so

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. To the original point I was making about implicit modules (which might've been my own confusion due to the term being brought up in D134269 ): Implicit modules is the situation where the compiler, finding that it needs a module while

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

yaxunl added a comment. I am not sure whether it is a good idea to allow gfx90A in `--offload-arch`, since it is not documented in LLVM AMDGPU usage. @b-sumner @arsenm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135614/new/ https://reviews.llvm.

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

arsenm added a comment. I don't really have an opinion here. I'd probably lean towards a "did you mean" kind of warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135614/new/ https://reviews.llvm.org/D135614 ___

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

probinson added inline comments. Comment at: clang/test/Frontend/frame-diags.c:1 +// TODO: This is not really a functional test yet, and needs to be rewritten. +// currently its just a copy of backend-diagnostics.c, and all of the run/test I know this is a draf

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; tbaeder wrote: > cor3ntin wrote: > > tahonermann wrote: > > > As others already noted, additional testing of multicharacter literals > > > and UCNs (including named universal

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

b-sumner added a comment. I don't particularly see a need for this. I am not opposed to a "did you mean" in the error diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135614/new/ https://reviews.llvm.org/D135614

[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

b-sumner added a comment. Also, we may want to use uppercase for other purposes in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135614/new/ https://reviews.llvm.org/D135614 ___ cfe-commits m

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth added inline comments. Comment at: clang/test/Frontend/frame-diags.c:1 +// TODO: This is not really a functional test yet, and needs to be rewritten. +// currently its just a copy of backend-diagnostics.c, and all of the run/test probinson wrote: > I

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. (trying not derail this discussion further) - Yes, the alternate solution proposed for the "Hello World" case would work with the module mapper interface. However, the initial discussion was simply about being able to produce both the .PCM and .O artefacts from one invoc

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

tschuett added a comment. What really worries me that you are talking about one phase compilation and there is a module cache. Even if it is one phase compilation you must pass all dependent modules on the command line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134267/new/ https:/

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

tschuett added a comment. The one phase compilation should work with `-fno-implicit-modules`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134267/new/ https://reviews.llvm.org/D134267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dblaikie added a comment. Because I was looking, some other `assert(0)` -> `llvm_unreachable` cleanups (though, yes, even the earliest cleanups include some assert(0) -> report_fatal_error, but for externally/user-reachable failures, like invalid bitcode, I think). Some of these are more blanke

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. In D134267#3849673 , @iains wrote: > (trying not derail this discussion further) > > - Yes, the alternate solution proposed for the "Hello World" case would work > with the module mapper interface. However, the initial discussi

[PATCH] D135682: Fix false positive related to handling of [[noreturn]] function pointers

arseniy-sonar created this revision. arseniy-sonar added reviewers: xazax.hun, martong, NoQ, Szelethus, steakhal. arseniy-sonar added a project: clang. Herald added a subscriber: rnkovacs. Herald added a project: All. arseniy-sonar requested review of this revision. Herald added a subscriber: cfe-c

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tahonermann added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; cor3ntin wrote: > tbaeder wrote: > > cor3ntin wrote: > > > tahonermann wrote: > > > > As others already noted, additional testing of multicharacter literals > > > > and UCN

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

aaron.ballman added a comment. In D135551#3847962 , @dblaikie wrote: > In D135551#3847607 , @aaron.ballman > wrote: > >> In D135551#3847444 , @dblaikie >> wrote: >> >>>

[PATCH] D135682: Fix false positive related to handling of [[noreturn]] function pointers

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. I already reviewed this downstream. I'll let someone else approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135682/new/ https://reviews.l

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; tahonermann wrote: > cor3ntin wrote: > > tbaeder wrote: > > > cor3ntin wrote: > > > > tahonermann wrote: > > > > > As others already noted, additional testing of multicharacter

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dblaikie added a comment. >> Generally LLVM's pretty hard to fathom in a non-asserts build anyway, right? >> (that's the first thing any of us do is reproduce with an assertions build >> that may fail miles away from where a crash occurred because an invariant >> was violated much earlier) - th

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3849712 , @dblaikie wrote: > In D134267#3849673 , @iains wrote: > >> >> - I do not think this patch fully addresses the issue of harmonising GCC and >> clang's command lines

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

aaron.ballman added a comment. In D135551#3849816 , @dblaikie wrote: >>> Generally LLVM's pretty hard to fathom in a non-asserts build anyway, >>> right? (that's the first thing any of us do is reproduce with an assertions >>> build that may fail miles

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue &createTop() { +return takeOwnership(std::make_unique()); + } gribozavr2 wrote: > ymandel wrote: > > xazax.hun wrote: > > > gri

[PATCH] D135335: [HLSL] Add Resource kind for HLSLResourceAttr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb267ac49e764: [HLSL] Add Resource kind for HLSLResourceAttr. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135335/new/ https://re

[clang] b267ac4 - [HLSL] Add Resource kind for HLSLResourceAttr.

Author: Xiang Li Date: 2022-10-11T09:41:14-07:00 New Revision: b267ac49e764c65322cf772647ff26d6732e5134 URL: https://github.com/llvm/llvm-project/commit/b267ac49e764c65322cf772647ff26d6732e5134 DIFF: https://github.com/llvm/llvm-project/commit/b267ac49e764c65322cf772647ff26d6732e5134.diff LOG:

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

inclyc added a comment. > - Prefer llvm_report_error() in any circumstance under which a code path is > functionally possible to reach, but only in erroneous executions that signify > a mistake on the part of the LLVM developer elsewhere in the program. > - Prefer llvm_unreachable() in any circu

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

aaron.ballman added a comment. In D135551#3849944 , @inclyc wrote: >> - Prefer llvm_report_error() in any circumstance under which a code path is >> functionally possible to reach, but only in erroneous executions that >> signify a mistake on the part o

[PATCH] D135696: [pseudo] Document disambiguation design progress

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Need to take a break from this, so write down where we got

[PATCH] D135696: [pseudo] Document disambiguation design progress

sammccall added a comment. The diagrams are rendered by github's markdown view. My favorite offline tool to preview them is the "Markdown Preview Mermaid Support" VSCode extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135696/new/ https://

[PATCH] D135384: [AIX] Enable the use of the -pg flag

francii updated this revision to Diff 466852. francii added a comment. Updated target triple check to use isOSAIX() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/test/CodeGen/mcount-aix.c

[clang] 2c94f75 - [clang-format] update --files help description

Author: Yuanfang Chen Date: 2022-10-11T10:25:04-07:00 New Revision: 2c94f75f00af16b6b4c2336e5cbfd8187d8bf33c URL: https://github.com/llvm/llvm-project/commit/2c94f75f00af16b6b4c2336e5cbfd8187d8bf33c DIFF: https://github.com/llvm/llvm-project/commit/2c94f75f00af16b6b4c2336e5cbfd8187d8bf33c.diff

[PATCH] D135115: [clang-format] update --files help description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c94f75f00af: [clang-format] update --files help description (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ODRDiagsEmitter.h:119 + /// Diagnose ODR mismatch in attributes between 2 Decl. + /// Comment at: clang/lib/AST/ODRDiagsEm

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

rjmccall added a comment. This seems be to a genuine target difference, right? PPC64 has this ABI rule: > An aggregate or union smaller than one doubleword in size is padded so that > it appears in the least significant bits of the doubleword. which overrides the standard rule for passing aggr

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

erichkeane added a comment. Most of my concerns change based on the feedback others have given, so after those are dealt with, I'll do another depever view. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:852 +def err_module_odr_violation_attribute : Error< + "%q0

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 466858. brettw added a comment. Fixed -Wall issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp c

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw reopened this revision. brettw added a comment. This revision is now accepted and ready to land. New patch up to fix warnings that caused the revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 __

[PATCH] D135490: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. Ok with me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135490/new/ https://reviews.llvm.org/D135490 ___

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

inclyc added a comment. In D135551#3849983 , @aaron.ballman wrote: > In D135551#3849944 , @inclyc wrote: > >>> - Prefer llvm_report_error() in any circumstance under which a code path is >>> functionally possibl

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added a comment. Looks good to me except for one nit. And the test still fails on Windows for some reason. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1612 + time_t TT = *getPreprocessorOpts().SourceDateEpoch; + std::tm *TM = std::gmtime(&TT); Result

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 466862. rymiel marked an inline comment as done. rymiel added a comment. Handle UDLs with and without spaces Thank you @owenpan, I was not actually aware UDLs without spaces were valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20036 Style.Language = FormatStyle::LK_Cpp; + CHECK_PARSE_BOOL(AlignRequiresClauseBody); CHECK_PARSE_BOOL(AlignTrailingComments); owenp

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:139 + // ref-note {{in call to 'foo()'}} +}; The other thing I think we need some tests for are constructor and destructor calls where the `this`

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. In D129755#3849540 , @aaron.ballman wrote: >>> In D129755#3842744 , @hans wrote: >>> >>> >>> I'll give you some time to reply before I reland, but I can't see a bug >>> here. For the

  1   2   3   >