[PATCH] D146501: [clang-format] Don't format already formatted integer literals

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a bug in `

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav created this revision. chaitanyav added a reviewer: tbaeder. Herald added a project: All. chaitanyav requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/61518 Repository: rG LLVM

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav added a comment. test.cpp:2:34: error: excess elements in scalar initializer _Complex double dd = {1.0, 2.0 , 3.0}; ^~~ test.cpp:3:32: error: excess elements in scalar initializer _Complex float fd = {1.0, 2.0, 3.0, 4.0, 5.0};

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D124351#4207501 , @eandrews wrote: > This patch causes an assertion when the attribute argument is an integer > constant expression - https://godbolt.org/z/osKx5ejMb and has resulted in > test fails downstream since any attr

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

uabelho added a comment. The improved verification found this: https://github.com/llvm/llvm-project/issues/61574 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146003/new/ https://reviews.llvm.org/D146003 __

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of `StmtToEnvMap`, we pass an `AnalysisC

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov added a comment. In D146426#4207423 , @shafik wrote: > As I noted in the bug report not doing `D.setInvalidType();` does fix this > bug and seems harmless since the error diagnostic should prevent us from > getting to codegen but it is not

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

kadircet added a comment. > To fix the issue, we keep the file handles open during the lifetime of their > corresponding UniqueID instances. Since handles will live longer now, this > requires particular attention when performing some file actions, such as file > deletions. I am a little worri

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay added a comment. What I'd really like to see, is... in the event that `IndentWidth` is set and I do NOTset `DesignatedInitializerIndentWidth` , then `DesignatedInitializerIndentWidth` would inherit from that (not the default as you have here), if I set IndentWidth to 3 Design

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21918-21927 + verifyFormat("Result doSomething(Promise promise) {\n" + " return promise.then(\n" + " [this, obj = std::move(s)](int evaluated) mutable {\n" +

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet updated this revision to Diff 506887. hazohelet added a comment. Herald added a subscriber: jplehr. Rebase and Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142800/new/ https://reviews.llvm.org/D142800 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diag

[PATCH] D145435: Choose style (file) from within code for use in IDEs

MyDeveloperDay added a comment. I'm kind of with @owenpan on this one, I don't hate the feature, but I think it goes against the sprit of "clang-format", we are only the custodians here (for now), I don't want to break too much the ethos of the original authors which I think was to help end the

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

MyDeveloperDay added a comment. Do we have any unit tests for this that we can pump a shed load of examples at? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146501/new/ https://reviews.llvm.org/D146501

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146434/new/ https://reviews.llvm.org/D146434 ___

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

tbaeder added a comment. I think the problem is that in https://github.com/llvm/llvm-project/blob/25ca26e0da2e1f80d62f71807828762691a049ac/clang/lib/Sema/SemaInit.cpp#L1532-L1541, the code checks for `Index != 2` and then handles it as a single scalar initializer. Repository: rG LLVM Github

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146403/new/ https://reviews.llvm.org/D146403 ___

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 506894. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:31 - /// there isn't one. - /// FIXME: Ensure that the result can't be null and return a const

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The crash happened because the transfer fucntion

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:399 +template +ValueT &getValueFromDecl(ASTContext &ASTCtx, const Environment &Env, +

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme updated this revision to Diff 506913. mboehme added a comment. Add back comment that I inadvertently deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.llvm.org/D146507 Files: clang/include/clang/Analysis/

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:31 - /// there isn't one. - /// FIXME: Ensure that the result can't be null and return a const reference. - virtual const Environment *getEnvironment(const Stmt &S) const = 0;

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:52 + /// Returns whether `B` is reachable from the entry block. + bool isBlockReachable(const CFGBlock *B) const { +return BlockReachable

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme updated this revision to Diff 506917. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146514/new/ https://reviews.llvm.org/D146514 Files: clang/include/clang/Analysis/FlowSen

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:399 +template +ValueT &getValueFromDecl(ASTContext &ASTCtx, const Environment &Env, + llvm::StringRef Name) {

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme updated this revision to Diff 506919. mboehme marked an inline comment as done. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146514/new/ https://reviews.llvm.org/D146514 Fil

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:52 + /// Returns whether `B` is reachable from the entry block. + bool isBlockReachable(const CFGBlock *B) const { +return Bl

[PATCH] D146422: [NFC] Fix typo in comment

zero9178 accepted this revision. zero9178 added a comment. This revision is now accepted and ready to land. LGTM. The Windows CI failure you can probably ignore, seems to be just a flaky test or maybe some other recent change that caused it. Do Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1304 + std::unique_ptr a; + a->foo(std::move(a)); +} PiotrZSL wrote: > mboehme wrote: > > PiotrZSL wrote: > > > What about scenario like this: > >

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3288 +This builtin is restrcted to work on x86 and arm targets currently. When support +for the builtin is added for new targets, the manual should be updated accordingly. + xiongji9

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

eandrews added a comment. In D124351#4208842 , @cor3ntin wrote: > In D124351#4207501 , @eandrews > wrote: > >> This patch causes an assertion when the attribute argument is an integer >> constant expression - ht

[PATCH] D146422: [NFC] Fix typo in comment

1lyasm added a comment. In D146422#4209249 , @zero9178 wrote: > LGTM. The Windows CI failure you can probably ignore, seems to be just a > flaky test or maybe some other recent change that caused it. Do you need me > to commit this for you? Yes, Ilyas

[clang] 64276ee - [clang][NFC] Fix typo in comment

Author: Ilyas Mustafazade Date: 2023-03-21T13:32:05+01:00 New Revision: 64276eec7ed07e762ef90c248a36cbafdcd7bd81 URL: https://github.com/llvm/llvm-project/commit/64276eec7ed07e762ef90c248a36cbafdcd7bd81 DIFF: https://github.com/llvm/llvm-project/commit/64276eec7ed07e762ef90c248a36cbafdcd7bd81.d

[PATCH] D146422: [NFC] Fix typo in comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64276eec7ed0: [clang][NFC] Fix typo in comment (authored by 1lyasm, committed by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

hans added a comment. This makes me nervous as well. I think it also doesn't fit well with developers' expectations of UniqueID, changing it from a simple piece of data to something which interacts with the OS in a pretty deep way. I don't have specific examples, but I'm sure it will bite us so

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

ymandel accepted this revision. ymandel added a comment. Nice! Thank you. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:174-175 + if (RHSVal == nullptr) { +// If the RHS isn't reachable, this implies that if we end up evaluating +// this Binary

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aaron.ballman added a comment. FWIW, I'm also nervous about this change. Keeping the file handle open changes the ways in which you can access the file from other processes (or within the same process), so I'd expect this to cause some heartache, possibly for downstreams as well as Clang users.

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz created this revision. kiwixz added a reviewer: njames93. kiwixz added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. kiwixz requested review of this revision. Herald added a subscriber: cfe-commits. Since commit 5d12

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1304 + std::unique_ptr a; + a->foo(std::move(a)); +} mboehme wrote: > PiotrZSL wrote: > > mboehme wrote: > > > PiotrZSL wrote: > > > > What about

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov updated this revision to Diff 506934. ilya-biryukov added a comment. - Add a test for block pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146426/new/ https://reviews.llvm.org/D146426 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:48 + if constexpr (D>0) { +// expected-warning@+6{{statement attribute 'always_inline' has higher precedence than function attribute 'noinline'}} +// expected-note@#NO_DEP{{conflicting a

[clang] 282cae0 - [Sema] Fix crash on __fp16 parameters in template instantiations

Author: Ilya Biryukov Date: 2023-03-21T14:06:46+01:00 New Revision: 282cae0b9a602267ad7ef622f770066491332a11 URL: https://github.com/llvm/llvm-project/commit/282cae0b9a602267ad7ef622f770066491332a11 DIFF: https://github.com/llvm/llvm-project/commit/282cae0b9a602267ad7ef622f770066491332a11.diff

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG282cae0b9a60: [Sema] Fix crash on __fp16 parameters in template instantiations (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo C

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov added a comment. I landed the fix to unbreak our crashes and explored a bit of the alternative solution. Digging a bit deeper, trying to always set non-null parameters causes ~30 test failures, but the ones I looked at so far look more localized and should be fixable. Some starte

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

aganea added a comment. Fair enough. There are several choices forward: either we mark the issue as "Will Not Fix" or I can try only scoping this patch to only keep the handle for network drives/paths. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:957 + // pipeline already cleaned up the frontend output. + if (Phase != ThinOrFullLTOPhase::ThinLTOPostLink

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

kadircet added a comment. In D146490#4209495 , @aganea wrote: > Fair enough. There are several choices forward: either we mark the issue as > "Will Not Fix" or I can try only scoping this patch to only keep the handle > open for network drives/paths. An

[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

mstorsjo added a comment. In D146490#4209495 , @aganea wrote: > Fair enough. There are several choices forward: either we mark the issue as > "Will Not Fix" or I can try only scoping this patch to only keep the handle > for network drives/paths. Any oth

[clang] 155abd0 - [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC

Author: Maryam Moghadas Date: 2023-03-21T08:51:25-05:00 New Revision: 155abd0678ab8c9f7d11ee175a3ce7a33d107c67 URL: https://github.com/llvm/llvm-project/commit/155abd0678ab8c9f7d11ee175a3ce7a33d107c67 DIFF: https://github.com/llvm/llvm-project/commit/155abd0678ab8c9f7d11ee175a3ce7a33d107c67.dif

[PATCH] D145506: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC

This revision was automatically updated to reflect the committed changes. Closed by commit rG155abd0678ab: [PowerPC] Emit warn_deprecated_lax_vec_conv_all warning only for PPC (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1455

[clang] 88e5206 - Reland [clang][ASTImport] Add support for import of empty records

Author: Pavel Kosov Date: 2023-03-21T17:26:36+03:00 New Revision: 88e5206f2c96a34e23a4d63f0a38afb2db044f0a URL: https://github.com/llvm/llvm-project/commit/88e5206f2c96a34e23a4d63f0a38afb2db044f0a DIFF: https://github.com/llvm/llvm-project/commit/88e5206f2c96a34e23a4d63f0a38afb2db044f0a.diff L

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

aaron.ballman added a comment. In D146426#4208960 , @ilya-biryukov wrote: > In D146426#4207423 , @shafik wrote: > >> As I noted in the bug report not doing `D.setInvalidType();` does fix this >> bug and seems ha

[PATCH] D146527: [dataflow] Log flow condition to the correct stream.

sammccall created this revision. sammccall added a reviewer: mboehme. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposit

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd updated this revision to Diff 506978. compnerd added a comment. Update to include additional behaviour and reference `INCLUDE` and `LIB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146165/new/ https://reviews.llvm.org/D146165 Files:

[clang] 270a6a2 - No longer issue pedantic warning about pre-c++2b compat

Author: Aaron Ballman Date: 2023-03-21T10:51:53-04:00 New Revision: 270a6a2824e3b42bd87acc986732a8b8f0765be7 URL: https://github.com/llvm/llvm-project/commit/270a6a2824e3b42bd87acc986732a8b8f0765be7 DIFF: https://github.com/llvm/llvm-project/commit/270a6a2824e3b42bd87acc986732a8b8f0765be7.diff

[PATCH] D146323: inline stmt attribute diagnosing in templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146323/new/ https://reviews.llvm.org/D146323 ___ cfe-commits

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

sammccall added a comment. In D145843#4207466 , @kadircet wrote: > In D145843#4207101 , @nridge wrote: > >> My understanding is that a more elaborate configuration scheme has been >> proposed in https://github.co

[clang] 514e435 - inline stmt attribute diagnosing in templates

Author: Erich Keane Date: 2023-03-21T08:16:52-07:00 New Revision: 514e4359a543ea778c7fee6908a9c6eb10d0ccd9 URL: https://github.com/llvm/llvm-project/commit/514e4359a543ea778c7fee6908a9c6eb10d0ccd9 DIFF: https://github.com/llvm/llvm-project/commit/514e4359a543ea778c7fee6908a9c6eb10d0ccd9.diff L

[PATCH] D146323: inline stmt attribute diagnosing in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG514e4359a543: inline stmt attribute diagnosing in templates (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D146165: docs: add some documentation on Windows SDK search

hans added a comment. Nice, thanks for taking the time to expand on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146165/new/ https://reviews.llvm.org/D146165 ___ cfe-commits mailing list cfe-commi

[clang] 01d05bd - Add warning test to make buildbots happy after 514e4359

Author: Erich Keane Date: 2023-03-21T08:34:48-07:00 New Revision: 01d05bd407bb49801393098f76d1af1c769c217c URL: https://github.com/llvm/llvm-project/commit/01d05bd407bb49801393098f76d1af1c769c217c DIFF: https://github.com/llvm/llvm-project/commit/01d05bd407bb49801393098f76d1af1c769c217c.diff L

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, asb, fedor.sergeev, krytarowski. Herald added a reviewer: aaron.ballman. Herald added a project: All. ipriyanshi1708 updated this revision to Diff 506994. ipriyanshi1708 added a comment. ipriyanshi1708

[clang] 67852bf - Fix switch warning from 514e4359a

Author: Erich Keane Date: 2023-03-21T08:52:15-07:00 New Revision: 67852bff588285b2dcf1eaa0c42389d297430465 URL: https://github.com/llvm/llvm-project/commit/67852bff588285b2dcf1eaa0c42389d297430465 DIFF: https://github.com/llvm/llvm-project/commit/67852bff588285b2dcf1eaa0c42389d297430465.diff L

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 507001. skatrak added a comment. Address reviewers comments and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075 Files: clang/include/clang/Driver/Optio

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak marked 4 inline comments as done. skatrak added a comment. Thank you for the feedback! I'll wait for confirmation before landing this patch, in case there are further comments relating to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

xazax.hun added a comment. This fix looks good for me for this particular problem, but I wonder whether the solution is general enough. In case the analysis figures out that a call would not return (e.g., the `value` method is called on a provably empty optional, and it would throw instead of r

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a regresion introduced by D124351 . Attributes of lambda call operator were evaluate

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

cor3ntin added a comment. Whether the assertion itself in `getCurLambda` is still pertinent, despite no test depending on it does require more analysis. This comment in SemaExprCXX.cpp dissuaded to try to do more surgery as part of this fix, and in some way, that assertion firing helped us disc

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

steakhal created this revision. steakhal added reviewers: xazax.hun, NoQ. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project: All. steak

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; I'm curious if this works if we encounter a forward declaration, early exit here, th

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

steakhal added a comment. I think this one also deserves backporting to clang-16.0.1 @xazax.hun Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146538/new/ https://reviews.llvm.org/D146538 ___ cfe-commits

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Ugh :/ I wonder if we should also open tickets on GitHub to reduce the chance of forgetting addressing the root cause for these. What do you think? Repository: rG LLVM Github Monorep

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

chaitanyav added a comment. It will fall through to scalar type to do field wise initialization _Complex double gx = {1.0}; _Complex double dx = {}; I think i get what you are saying, we can directly say that it has excess elements without having to do the field wise initialization.

[clang] b904e68 - No longer issue static lambda pedantic warning for pre-c++2b compat

Author: Aaron Ballman Date: 2023-03-21T12:49:45-04:00 New Revision: b904e68f13ba7d4f4aa86a3495e2441c99247671 URL: https://github.com/llvm/llvm-project/commit/b904e68f13ba7d4f4aa86a3495e2441c99247671 DIFF: https://github.com/llvm/llvm-project/commit/b904e68f13ba7d4f4aa86a3495e2441c99247671.diff

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507026. tblah added a comment. Added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

eandrews added a comment. > Attributes of lambda call operator were evaluated in the context of the > closure object type rather than its operator, Just for my understanding, what did this affect with regards to the if guard for assert? CurContext or something else? I suspected it had something

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

awarzynski added a comment. Thanks for the updates! I advice against using UPPER case in filenames. Please bear in mind that on Windows and MacOS filenames are case insensitive. It's just less hassle to stick to lower case. Comment at: flang/lib/Frontend/FrontendActions.cpp:

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 507029. ivanmurashko added a comment. The change addresses comments from D145228 . The only one header is copied as a part of the installation. As result the diff contains the minimal changes required to integrated clan

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. > If we consider the bare minimum with the only goal to build outside LLVM > source tree then we don’t need to copy all internal headers. At the case the > D145302 can be modified and we can end up > with the only one header that

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:214 void SARIFDiagnostic::emitIncludeLocation(FullSourceLoc Loc, PresumedLoc PLoc) { - assert(false && "Not implemented in SARIF mode"); + SarifRule Rule = SarifRule::create().setRuleId(std::to_str

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added inline comments. Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:2 +! Test -flang-experimental-hlfir flag +! RUN: %flang_fc1 -flang-experimental-hlfir -emit-fir -o - %s | FileCheck %s + Could you also add a `RUN` line like this: ``

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 507034. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang-to

[PATCH] D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists

steakhal added a comment. In D146538#4210037 , @xazax.hun wrote: > Ugh :/ > > I wonder if we should also open tickets on GitHub to reduce the chance of > forgetting addressing the root cause for these. What do you think? Thanks for the quick review! I

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:1099 + const SourceManager &SM = AST.getSourceManager(); + llvm::SmallVector Headers = + include_cleaner::headersForSymbol(Sym, SM, AST.getPragmaIncludes()); h

[PATCH] D146535: [Clang] Fix evaluation of parameters of lambda call operator attributes

cor3ntin added a comment. In D146535#4210198 , @eandrews wrote: >> Attributes of lambda call operator were evaluated in the context of the >> closure object type rather than its operator, > > Just for my understanding, what did this affect with regards t

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

tmatheson added a comment. Looks sensible but I don't fully understand the context of the change. Please could you explain more what is wrong with the current behaviour, and which parts of the AAPCS you are referring to. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5811 +

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. > Can this be solved at the build-system level, without changing the source > code in ways that aren't otherwise useful? > For example, with a `CLANG_TIDY_EXTRA_CHECKS` cmake variable that adds more > deps? This seems like it could also work for the `clang-tidy` bin

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

argentite updated this revision to Diff 507046. argentite marked 3 inline comments as done. argentite edited the summary of this revision. argentite added a comment. Added a simple test and removed the automatic OS specific library filenames Full name/path of the library must be provided. This ma

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507048. paulkirth added a comment. Split out save/restore tests for SCS into its own file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks updated this revision to Diff 507052. aeubanks added a comment. assert not full lto postlink Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 Files: clang/test/CodeGen/thinlto-distributed-newpm.

[PATCH] D145265: [WIP][Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 507053. aeubanks added a comment. Herald added subscribers: cfe-commits, ormris, wenlei, steven_wu. Herald added a project: clang. rebase, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:62 -MF.getFunction(), -"Shadow Call Stack cannot be combined with Save/Restore LibCalls."}); return; ❤ Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146497: libclang: Pass Clang install directory to driver via argv[0].

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a nit and a question, but can you add a release note when you land to let users know about the changes? Comment at: clang/tools/libclang/CIndex.cpp:4

[PATCH] D146552: [Clang][OpenMP] Enable device-mapped constexpr class members to not be optimized out

doru1004 created this revision. doru1004 added reviewers: ronl, carlo.bertolli, jhuber6, jdoerfert, gregrodgers, dhruvachak. doru1004 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald adde

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/LanguageExtensions.rst:2393 +particular object (so for example, it's never correct to call this function +passing the addresses of fields in the sa

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

asb added a comment. In principle I think this is good, but I see two considerations: 1. Sam was right that there's an ability to change the register after the fact, but 2.5 years have passed since then. We should make a good faith attempt to see if any downstream users are relying on the curre

[PATCH] D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:2539 +def fno_omit_frame_pointer : Flag<["-"], "fno-omit-frame-pointer">, Group, + HelpText<"Help to produce better stack traces during debugging">; defm operator_names : BoolFOption<"operator-

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall updated this revision to Diff 507067. sammccall marked 2 inline comments as done. sammccall retitled this revision from "[FlowSensitive][WIP] log analysis progress for debugging purposes" to "[FlowSensitive] Log analysis progress for debugging purposes". sammccall edited the summary of

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall added a reviewer: xazax.hun. sammccall added a comment. Herald added a subscriber: rnkovacs. Thanks! I cleaned up a bit and added tests, as well as a `-dataflow-log` flag to make this easy to access when running unit tests, tidy checks etc. The HTML experiments seem to have validated th

  1   2   >