[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > I mean we can transform `QualifiedTemplateName` to `DependentTemplateName` > and this is what this patch does. But that goes against the natural flow of template instantiation. We can't go back from non-dependent into dependent. We can't transform a regular TemplateName back

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > I still don't understand why you are saying we didn't or can't build a > DependentTemplateSpecializationType instead. I mean we can transform `QualifiedTemplateName` to `DependentTemplateName` and this is what this patch does. If we build a `DependentTemplateName` instead of

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-06-22 Thread via cfe-commits
goldsteinn wrote: Rebased (after we remove `writeonly` support). https://github.com/llvm/llvm-project/pull/91101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-22 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-06-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/91101 >From 939ff721b72a109df7c6cf27c2698360063d40e5 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Sat, 4 May 2024 18:12:34 -0500 Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter

[clang] [HLSL][clang] Add elementwise builtins for trig intrinsics (PR #95999)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/392 Here is the relevant piece

[clang] [HLSL][clang] Add elementwise builtins for trig intrinsics (PR #95999)

2024-06-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/95999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f73ac21 - [HLSL][clang] Add elementwise builtins for trig intrinsics (#95999)

2024-06-22 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-06-22T17:17:34-07:00 New Revision: f73ac218a666e2017565f2210b47332ddcf55f00 URL: https://github.com/llvm/llvm-project/commit/f73ac218a666e2017565f2210b47332ddcf55f00 DIFF: https://github.com/llvm/llvm-project/commit/f73ac218a666e2017565f2210b47332ddcf55f00.diff

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-22 Thread Fangrui Song via cfe-commits
MaskRay wrote: > I suspect this is the root cause that some modules related test are failing > on armv8-quick. It passes with commit > [12c0281](https://github.com/llvm/llvm-project/commit/12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e) > >

[clang] f3005d5 - [Serialization] Change input file content hash from size_t to uint64_t

2024-06-22 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-22T14:21:36-07:00 New Revision: f3005d5b86ca947977f6056552b2a4648b9f0460 URL: https://github.com/llvm/llvm-project/commit/f3005d5b86ca947977f6056552b2a4648b9f0460 DIFF: https://github.com/llvm/llvm-project/commit/f3005d5b86ca947977f6056552b2a4648b9f0460.diff

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-22 Thread Paul Heidekrüger via cfe-commits
https://github.com/PBHDK updated https://github.com/llvm/llvm-project/pull/95220 From 37292995de0c5aa87408586749795a97468d4725 Mon Sep 17 00:00:00 2001 From: Sebastian Wolf Date: Wed, 17 Apr 2024 16:16:35 +0200 Subject: [PATCH 01/22] Enforce SL.con.3: Add check to replace operator[] with at()

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
nico wrote: (I now ported ade28a77ed17760bf2fde57c6571b69489b0bac0 to the GN build in 3ba7599842be. Again, apologies for missing this – the GN build shouldn't affect other people. But I'm kind of glad it did since I found several GN-unrelated issues both here and on #93928. Feel free to do

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -127,16 +133,86 @@ std::string getFormatString() { // GetMainExecutable (since some platforms don't support taking the // address of main, and some platforms can't implement GetMainExecutable // without being given the address of a function in the main executable).

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -0,0 +1,21 @@ +#include "Calculator.h" +#include nico wrote: Tests must be freestanding and cannot include system headers. https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -182,23 +258,9 @@ Example usage for a project using a compile commands database: {"index.js", "index_json.js"}}; if (Format == "html") { -void *MainAddr = (void *)(intptr_t)GetExecutablePath; -std::string ClangDocPath = GetExecutablePath(argv[0],

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -0,0 +1,358 @@ +// RUN: rm -rf %t && mkdir -p %t/docs %t/build +// RUN: sed 's|$test_dir|%/S|g' %S/Inputs/basic-project/database_template.json > %t/build/compile_commands.json +// RUN: clang-doc --format=html --output=%t/docs --executor=all-TUs %t/build/compile_commands.json

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -0,0 +1,2 @@ +// RUN: clang-doc --format=html --executor=standalone %s -output=%t/docs | FileCheck %s +// CHECK: Using default asset: {{.*}}{{[\/]}}share{{[\/]}}clang nico wrote: A test that only tests for logspam doesn't seem very useful. I would've

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -127,16 +133,86 @@ std::string getFormatString() { // GetMainExecutable (since some platforms don't support taking the // address of main, and some platforms can't implement GetMainExecutable // without being given the address of a function in the main executable).

[clang] f5b93ae - [clang] Fix -Wsign-compare in 32-bit builds

2024-06-22 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-22T13:40:05-07:00 New Revision: f5b93ae5884dd72bd145576344e4e685cf5e URL: https://github.com/llvm/llvm-project/commit/f5b93ae5884dd72bd145576344e4e685cf5e DIFF: https://github.com/llvm/llvm-project/commit/f5b93ae5884dd72bd145576344e4e685cf5e.diff

[clang] [Clang] Simplify release notes and remove irrelevant comment (PR #96407)

2024-06-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Gábor Spaits (spaits) Changes As discussed before with @cor3ntin before (https://github.com/llvm/llvm-project/pull/94752) here is the simplification of the release note written for the previously mentioned PR and the removal of a

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
@@ -182,23 +258,9 @@ Example usage for a project using a compile commands database: {"index.js", "index_json.js"}}; if (Format == "html") { -void *MainAddr = (void *)(intptr_t)GetExecutablePath; -std::string ClangDocPath = GetExecutablePath(argv[0],

[clang] [Clang] Simplify release notes and remove irrelevant comment (PR #96407)

2024-06-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/96407 As discussed before with @cor3ntin before (https://github.com/llvm/llvm-project/pull/94752) here is the simplification of the release note written for the previously mentioned PR and the removal of a comment

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
nico wrote: Ah, I see now, the failing test is also very new (70ec8419dd7), and it depends on ade28a77ed177 which the GN build doesn't yet have. But my bot points at this change here for breaking that fairly new end-to-end test. I think it's probably because absence of the css file wasn't an

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-22 Thread Nico Weber via cfe-commits
nico wrote: Sorry, I'm confused, how is this build-system dependent? The patch doesn't change any cmake files, and it changes the behavior of an existing test. I'm not saying it can't be build-system dependent, but it isn't clear to me why it is. Do you have a few more words on what's

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-22 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. Looks OK - one minor nit, I'd probably avoid defining CLANG_TRAP_PREFIX as a macro, but instead as an inline or some other form of constant https://github.com/llvm/llvm-project/pull/79230 ___

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-22 Thread David Blaikie via cfe-commits
@@ -27,6 +27,9 @@ namespace llvm { } } +// Prefix of the name of the artificial inline frame. +#define CLANG_TRAP_PREFIX "__clang_trap_msg" dwblaikie wrote: inline StringRef? usual reasons to avoid macros, etc

[clang] [HLSL][clang] Add elementwise builtins for trig intrinsics (PR #95999)

2024-06-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/95999 >From 632ec448202a111a313536ffbf22589499dd214b Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Tue, 18 Jun 2024 17:47:13 -0400 Subject: [PATCH] [HLSL][clang] Add elementwise builtins for trig intrinsics This

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-06-22 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/96301 >From b964923b9610c9cd53e4d1de8f5d51d8fcebc78c Mon Sep 17 00:00:00 2001 From: Rajveer Date: Fri, 21 Jun 2024 18:26:36 +0530 Subject: [PATCH] [clang] Allow class with anonymous union member to be

[clang] [HLSL][clang] Add elementwise builtins for trig intrinsics (PR #95999)

2024-06-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6621505a1eb5428b13d2d29f377050624ef5531c bb837fd791d627fceffb73eaac70b8f4db2f4dda

[clang] [HLSL][clang] Add elementwise builtins for trig intrinsics (PR #95999)

2024-06-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/95999 >From bb837fd791d627fceffb73eaac70b8f4db2f4dda Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Tue, 18 Jun 2024 17:47:13 -0400 Subject: [PATCH] [HLSL][clang] Add elementwise builtins for trig intrinsics This

[clang] [Clang][Driver] Expose `-fno-eliminate-unused-debug-types` to clang-cl (PR #95259)

2024-06-22 Thread David Blaikie via cfe-commits
dwblaikie wrote: I will say, `-fno-eliminate-unused-debug-types` is a really heavy hammer that makes debug info much larger - and my understanding was that games tended to have trouble with large debug builds, so I'd be surprised if this was a great path forward. Do you have a small example

[clang] [Clang][Driver] Expose `-fno-eliminate-unused-debug-types` to clang-cl (PR #95259)

2024-06-22 Thread David Blaikie via cfe-commits
dwblaikie wrote: Yes, the initializers do have to be lazyily evaluated to be a conforming C++ compiler. eg: this code must compile without error so far as I understand: ``` template struct t1 { static constexpr int x = 3 / Value; }; t1<0> v1; ``` Though it seems MSVC doesn't implement this

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/96396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6621505 - [clang-format] Don't count template template parameter as declaration (#96396)

2024-06-22 Thread via cfe-commits
Author: Emilia Kond Date: 2024-06-22T21:16:51+03:00 New Revision: 6621505a1eb5428b13d2d29f377050624ef5531c URL: https://github.com/llvm/llvm-project/commit/6621505a1eb5428b13d2d29f377050624ef5531c DIFF: https://github.com/llvm/llvm-project/commit/6621505a1eb5428b13d2d29f377050624ef5531c.diff

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/96396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2024-06-22 Thread A. Jiang via cfe-commits
frederick-vs-ja wrote: @Endilll I think it's ready now. Sorry for late replying again. https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2024-06-22 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/68846 >From c38259bd70993a96a35ce4f94790e420847786e2 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Sun, 23 Jun 2024 01:39:42 +0800 Subject: [PATCH] [Docs][Clang] DR status for C++23-era papers in

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-22 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: I have no idea about why it corrupts StringMap. Sad :( ![image](https://github.com/llvm/llvm-project/assets/15650457/fd427068-6ca0-4ecb-a340-48c51e5629a6) https://github.com/llvm/llvm-project/pull/94352 ___ cfe-commits mailing list

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2024-06-22 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-22 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][utils] Remove ClangDataFormat.py for now (PR #96385)

2024-06-22 Thread Michael Buch via cfe-commits
Michael137 wrote: > LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running > on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/18/builds/384 > > Here is the relevant piece

[clang] 170c194 - [clang][Interp] Fix CFStringMakeConstantString etc. evaluation

2024-06-22 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-22T18:54:42+02:00 New Revision: 170c194ec19c76deee33d8aa8b288368c574f7a0 URL: https://github.com/llvm/llvm-project/commit/170c194ec19c76deee33d8aa8b288368c574f7a0 DIFF: https://github.com/llvm/llvm-project/commit/170c194ec19c76deee33d8aa8b288368c574f7a0.diff

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-22 Thread Michał Górny via cfe-commits
mgorny wrote: Also hit it on 32-bit x86; filed #96379 before I managed to bisect it. https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][utils] Remove ClangDataFormat.py for now (PR #96385)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/384 Here is the relevant piece of the build log

[clang] 0fccae9 - [clang][utils] Remove ClangDataFormat.py for now (#96385)

2024-06-22 Thread via cfe-commits
Author: Michael Buch Date: 2024-06-22T17:07:01+01:00 New Revision: 0fccae9d8e64f3b0f415946000d6ca79ae1255db URL: https://github.com/llvm/llvm-project/commit/0fccae9d8e64f3b0f415946000d6ca79ae1255db DIFF: https://github.com/llvm/llvm-project/commit/0fccae9d8e64f3b0f415946000d6ca79ae1255db.diff

[clang] [clang][utils] Remove ClangDataFormat.py for now (PR #96385)

2024-06-22 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/96385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] inherit GD to let the codegen add kcfi type for ifunc (PR #96400)

2024-06-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (aokblast) Changes In FreeBSD, we use ifunc to select best performance function in load time. However, the resolver is also a function itself but not been tagged kcfi by clang. The problems is caused by ``` if (D)

[clang] [clang] inherit GD to let the codegen add kcfi type for ifunc (PR #96400)

2024-06-22 Thread via cfe-commits
https://github.com/aokblast created https://github.com/llvm/llvm-project/pull/96400 In FreeBSD, we use ifunc to select best performance function in load time. However, the resolver is also a function itself but not been tagged kcfi by clang. The problems is caused by ``` if (D)

[clang] [clang][utils] Remove ClangDataFormat.py for now (PR #96385)

2024-06-22 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/96385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Emilia Kond (rymiel) Changes Reapply 4a7bf42a9b83144db8a11ac06cce4da21166e6a2 which was reverted in 34d44eb41dfbbbf01712719558b02763334fbeb3 Not sure why there are tests elsewhere in clang that rely on the output of clang-format, but

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > @mizvekov After looking into the code, I think we should transform qualifier > in TST. Consider the following code: So the NNS is already dependent, that's great. I still don't understand why you are saying we didn't or can't build a DependentTemplateSpecializationType

[clang] [clang-format] Don't count template template parameter as declaration (PR #96396)

2024-06-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel created https://github.com/llvm/llvm-project/pull/96396 Reapply 4a7bf42a9b83144db8a11ac06cce4da21166e6a2 which was reverted in 34d44eb41dfbbbf01712719558b02763334fbeb3 Not sure why there are tests elsewhere in clang that rely on the output of clang-format, but they

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 4e9e322a82e636783d2ba0ccda92f3547d557a64 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed ---

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 8359bac8e59c6b5ebc6500042dc473c3f4245c08 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed ---

[clang] Revert "[clang-format] Don't count template template parameter as declaration" (PR #96388)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/382 Here is the relevant piece of the build log

[clang] Adjust MSVC version range for ARM64 build performance regression (PR #90731)

2024-06-22 Thread Alexander Smarus via cfe-commits
lxbndr wrote: Rebased on latest main. Let's see what CI say. https://github.com/llvm/llvm-project/pull/90731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adjust MSVC version range for ARM64 build performance regression (PR #90731)

2024-06-22 Thread Alexander Smarus via cfe-commits
https://github.com/lxbndr updated https://github.com/llvm/llvm-project/pull/90731 >From 52fe3d377e5f6a0388f102b82283529253d4ab4c Mon Sep 17 00:00:00 2001 From: Alexander Smarus Date: Wed, 1 May 2024 16:43:04 +0300 Subject: [PATCH] Adjust MSVC version range for ARM64 build performance

[clang] Revert "[clang-format] Don't count template template parameter as declaration" (PR #96388)

2024-06-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Mehdi Amini (joker-eph) Changes Reverts llvm/llvm-project#95025 ; many bots are broken --- Full diff: https://github.com/llvm/llvm-project/pull/96388.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp

[clang] Revert "[clang-format] Don't count template template parameter as declaration" (PR #96388)

2024-06-22 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/96388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34d44eb - Revert "[clang-format] Don't count template template parameter as declaration" (#96388)

2024-06-22 Thread via cfe-commits
Author: Mehdi Amini Date: 2024-06-22T14:18:59+02:00 New Revision: 34d44eb41dfbbbf01712719558b02763334fbeb3 URL: https://github.com/llvm/llvm-project/commit/34d44eb41dfbbbf01712719558b02763334fbeb3 DIFF: https://github.com/llvm/llvm-project/commit/34d44eb41dfbbbf01712719558b02763334fbeb3.diff

[clang] Revert "[clang-format] Don't count template template parameter as declaration" (PR #96388)

2024-06-22 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/96388 Reverts llvm/llvm-project#95025 ; many bots are broken >From b9ceb93bc8d7fe75365f0d9002ed8b48a0884c85 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sat, 22 Jun 2024 14:18:31 +0200 Subject: [PATCH]

[clang] [llvm] [LLVM] Fix incorrect alignment on AMDGPU variadics (PR #96370)

2024-06-22 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Incrementing by align is just a bug, of course the size is the real value. > Whether we want to continue wasting space is another not-correctness > discussion Struct padding is pretty universal, AMDGPU seems the odd one out here. I wouldn't mind it so much if it didn't

[clang] [llvm] [LLVM] Fix incorrect alignment on AMDGPU variadics (PR #96370)

2024-06-22 Thread Matt Arsenault via cfe-commits
arsenm wrote: Incrementing by align is just a bug, of course the size is the real value. Whether we want to continue wasting space is another not-correctness discussion https://github.com/llvm/llvm-project/pull/96370 ___ cfe-commits mailing list

[clang] [llvm] [LLVM] Fix incorrect alignment on AMDGPU variadics (PR #96370)

2024-06-22 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Here, because the minimum alignment is 4, we will only increment the > > buffer by 4, > > It should be incrementing by the size? 4 byte aligned access of 8 byte type > should work fine Guess that's an AMD thing, so I'm going to assume that @JonChesterfield wrote this

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-msan` running on `sanitizer-buildbot6` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/164/builds/324 Here is the

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 4b1d55c56f969e926645a856ba67e289776326a8 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed ---

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/684 Here is the

[clang] [clang][utils] Remove ClangDataFormat.py for now (PR #96385)

2024-06-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes This formatter doesn't currently provide much value. It only formats `SourceLocation` and `QualType`. The only formatting it does for `QualType` is call `getAsString()` on it. The main motivator for the

[clang] [clang][utils] Remove ClangDataFormat.py for now (PR #96385)

2024-06-22 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/96385 This formatter doesn't currently provide much value. It only formats `SourceLocation` and `QualType`. The only formatting it does for `QualType` is call `getAsString()` on it. The main motivator for the

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/506 Here is the

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/459 Here is the relevant

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/378 Here is the relevant piece

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/450 Here

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-cmake-x86_64-avx512-linux` running on `avx512-intel64` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/433 Here is the relevant

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/444 Here is the

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/500 Here is the

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/659 Here is the

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/428 Here is the relevant piece of

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/848 Here is

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
jcsxky wrote: @mizvekov After looking into the code, I think we should transform qualifier in TST. Consider the following code: ```cpp template t1::template t2 f1(); void f2() { f1(); } ``` `TemplateSpecializationType` of `t2` whose `Template` is a `QualifiedTemplateName`(`t1::`) will be

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ve-ninja` running on `hpce-ve-main` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/12/builds/510 Here is the relevant piece of the build log for the

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `clang` at step 6 "Add check check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/577 Here is

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/636

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-22 Thread Mital Ashok via cfe-commits
MitalAshok wrote: Could you knock out a related bug at the same time: ```c++ template struct X { char arr[1]; }; extern X* p, *q; //X inst; void f() { __atomic_exchange(p, p, q, __ATOMIC_RELAXED); } ``` With the line commented out, currently this crashes, but in Clang 18 and with your

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/95025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a7bf42 - [clang-format] Don't count template template parameter as declaration (#95025)

2024-06-22 Thread via cfe-commits
Author: Emilia Kond Date: 2024-06-22T12:51:36+03:00 New Revision: 4a7bf42a9b83144db8a11ac06cce4da21166e6a2 URL: https://github.com/llvm/llvm-project/commit/4a7bf42a9b83144db8a11ac06cce4da21166e6a2 DIFF: https://github.com/llvm/llvm-project/commit/4a7bf42a9b83144db8a11ac06cce4da21166e6a2.diff

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/95025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread Emilia Kond via cfe-commits
@@ -1269,10 +1269,17 @@ class AnnotatingParser { if (CurrentToken && CurrentToken->is(tok::less)) { CurrentToken->setType(TT_TemplateOpener); next(); - if (!parseAngle()) + TemplateDeclarationDepth++; + if (!parseAngle()) { +

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-22 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/95025 >From 6fc09d022a0e4e395a1b8e17166641dffc7c12eb Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Mon, 10 Jun 2024 22:17:29 +0300 Subject: [PATCH 1/5] [clang-format] Don't count template template parameter as

[clang] [libclang/python] Refactor enum usage (PR #95608)

2024-06-22 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: @Endilll are you taking a look at this, and/or should I ask other reviewers? https://github.com/llvm/llvm-project/pull/95608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [TBAA] Emit int TBAA metadata on FP math libcalls (PR #96025)

2024-06-22 Thread via cfe-commits
https://github.com/vfdff edited https://github.com/llvm/llvm-project/pull/96025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Emit int TBAA metadata on FP math libcalls (PR #96025)

2024-06-22 Thread via cfe-commits
@@ -707,7 +707,34 @@ static RValue emitLibraryCall(CodeGenFunction , const FunctionDecl *FD, const CallExpr *E, llvm::Constant *calleeValue) { CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E); CGCallee callee =

[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-22 Thread Danny Mösch via cfe-commits
@@ -125,6 +125,9 @@ Improvements to clang-tidy - Added argument `--exclude-header-filter` and config option `ExcludeHeaderFilterRegex` to exclude headers from analysis via a RegEx. +- Added argument `--allow-no-checks` to suppress "no checks enabled" error + when

[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-22 Thread Danny Mösch via cfe-commits
https://github.com/SimplyDanny edited https://github.com/llvm/llvm-project/pull/96122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-22 Thread Danny Mösch via cfe-commits
https://github.com/SimplyDanny approved this pull request. https://github.com/llvm/llvm-project/pull/96122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-06-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: In addition to the issue noted on buildbots, this also caused failed tests on i386: https://github.com/mstorsjo/llvm-mingw/actions/runs/9606458336/job/26504129718#step:8:1501 There seem to be a couple of different errors there: ``` bit-int.c:72:19: runtime error: implicit

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 70928fcec829b6cb02fd9fe19b214518c872eea6 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed ---

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-22 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 8327ee1afef04480a1a18eef169f24906e432e87 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed ---

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-22 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/94352 >From ff839bef048a65760f4cd0e9abafe11cfebd9362 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 4 Jun 2024 21:08:27 +0800 Subject: [PATCH 1/6] [RISCV] Add support for getHostCPUFeatures using hwprobe

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-22 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/94352 >From ff839bef048a65760f4cd0e9abafe11cfebd9362 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 4 Jun 2024 21:08:27 +0800 Subject: [PATCH 1/5] [RISCV] Add support for getHostCPUFeatures using hwprobe

  1   2   >