[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a subscriber: everythingfunctional. awarzynski added a comment. In D125788#4556324 , @MaskRay wrote: > If you continue this work, consider landing this rename in multiple phases, > e.g. > > - Use lit substitutions instead of `flang-new`

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

MaskRay added a comment. Herald added a subscriber: jplehr. If you continue this work, consider landing this rename in multiple phases, e.g. - Use lit substitutions instead of `flang-new` and other preparatory stuff so that the next step has very little change - change flang-new to flang and

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski abandoned this revision. awarzynski added a comment. In D125788#3622274 , @clementval wrote: > There are open discussion so wait for other to confirm or not. I was under the impression that we did discuss this extensively in our community

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 441643. awarzynski added a comment. Add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added a comment. In D125788#3621744 , @awarzynski wrote: > We discussed this in our call on Monday and agreed to go ahead provided that > this change is technically sound. IIUC, this has now been confirmed: > >> Overall the patch looks ok

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, awarzynski wrote: > richard.barton.arm wrote: > >

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, richard.barton.arm wrote: > clementval wrote: > >

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

richard.barton.arm added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, clementval wrote: > This is counter

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval requested changes to this revision. clementval added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"},

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Thank your for reviewing @clementval ! In D125788#3621585 , @clementval wrote: > Shouldn't we just wait until we can make the permanent renaming so we do not > add unnecessary cmake option? This was discussed in one of our

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added a comment. Overall the patch looks ok from a technical point. Shouldn't we just wait until we can make the permanent renaming so we do not add unnecessary cmake option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 440283. awarzynski added a comment. Incorporate @clementval 's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, clementval wrote: > Why do we need two lines here?

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

clementval added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:185 {"flang", "--driver-mode=flang"}, + {"flang-new", "--driver-mode=flang"}, {"clang-dxc", "--driver-mode=dxc"}, Why do we need two lines here? Shouldn't we have a

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3612533 , @peixin wrote: > In summary: > >> If you want to use the updated name, flang, set FLANG_USE_LEGACY_NAME to ON >> when configuring LLVM Flang. > > OFF? Updated, thanks! Repository: rG LLVM Github

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

peixin added a comment. In summary: > If you want to use the updated name, flang, set FLANG_USE_LEGACY_NAME to ON > when configuring LLVM Flang. OFF? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 435564. awarzynski added a comment. Add the `FLANG_USE_LEGACY_NAME` cmake option that will control the name of the driver executable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In the call yesterday it was proposed that we add a CMake option that will control the name of the driver. I suggest adding `FLANG_USE_LEGACY_NAME`: - when set to `ON`, the driver binary will be called `flang-new`, - when set to `OFF`, the driver binary will be

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3547494 , @sscalpone wrote: > I'm fine with removing or renaming the existing flang shell script. In D125788#3547656 , @rouson wrote: > On Mon, May 30, 2022 at 2:39 AM

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. On Mon, May 30, 2022 at 2:39 AM Andrzej Warzynski via Phabricator wrote: > 1. Lets rename `flang` as `flang-to-external-fc` regardless of what's decided > for `flang-new`. That would already be a huge step forward (and > would > reflect accurately what the bash

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. I'm fine with removing or renaming the existing flang shell script. My proposal is not to wait for a 100% pass rate. My proposal is to wait until the messages for unimplemented features are converted to TODOs that reference the program's source line and that legal

Re: [PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

On Mon, May 30, 2022 at 2:39 AM Andrzej Warzynski via Phabricator < revi...@reviews.llvm.org> wrote: > > 1. Lets rename `flang` as `flang-to-external-fc` regardless of what's > decided for `flang-new`. That would already be a huge step forward (and > would reflect accurately what the bash wrapper

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Thank you all for your comments and apologies for going radio silent - I was away for a few days. I've identified 2 threads emerging from your comments: **1. flang vs flang-new** @sscalpone, if I understand correctly, you are suggesting that any tool named `flang`

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. Recommend that you contact NAG for more info on the test suite. Here's the only reference that I could find: https://fortran-lang.discourse.group/t/fortran-compiler-testing-framework/1573/10 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. +1 @kiranchandramohan I have access to the NAG Fortran compiler and find it very helpful for checking standard conformance. I was unaware of the NAG test suite and don't see any mention of it online. Is it an official product that can be purchased? Repository: rG

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan added a comment. In D125788#3535199 , @sscalpone wrote: > My proposal is: > > If the compiler compiles it, it ought to run. > If the compiler can't compile it, it ought to clearly say why. > > 1. All tests of legal Fortran that compile

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

peixin added a comment. In D125788#3535199 , @sscalpone wrote: > My proposal is: > > If the compiler compiles it, it ought to run. > If the compiler can't compile it, it ought to clearly say why. > > 1. All tests of legal Fortran that compile & link must

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. My proposal is: If the compiler compiles it, it ought to run. If the compiler can't compile it, it ought to clearly say why. 1. All tests of legal Fortran that compile & link must also execute correctly (which excludes tests that expect to catch a problem at runtime)

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. In D125788#3534482 , @sscalpone wrote: > My belief is that we should wait until f18 hits a reasonable quality bar for > executables before making flang-new the default. My reasoning seems not to > have carried the day. It

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

sscalpone added a comment. My belief is that we should wait until f18 hits a reasonable quality bar for executables before making flang-new the default. My reasoning seems not to have carried the day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. Summary updated :) In D125788#3524338 , @kiranchandramohan wrote: > I think it is a driver flag `-flang-experimental-exec`. I was only requesting > the add this information to the patch summary. If you feel it should be >

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 430604. awarzynski added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan added a comment. In D125788#3523408 , @shraiysh wrote: >> With this change the flang driver will not generate an executable unless it >> is built with an option. > > Okay, thank you for the clarification. Is this a cmake option and?

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

rouson added a comment. I think this is an exciting step. I hope it gets approved. Although it's technically true that this could appear to be a regression for current flang script users, the ultimate compilation currently happens by invoking an external compiler so most current flang script

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

shraiysh added a comment. > With this change the flang driver will not generate an executable unless it > is built with an option. Okay, thank you for the clarification. Is this a cmake option and? Are we documenting this somewhere except this patch summary, like on the flang documentation or

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan added a comment. In D125788#3523259 , @shraiysh wrote: >> clarify that execution is still restricted to developers via a flag. > > Just confirming what this means: After this patch, would `flang sample.f90` > generate an executable? If

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

shraiysh added a comment. > clarify that execution is still restricted to developers via a flag. Just confirming what this means: After this patch, would `flang sample.f90` generate an executable? If not, how to generate an executable using `flang-new`? If yes, does this mean that if I just

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 430379. awarzynski added a comment. Rename `flang-to-gfortran` as `flang-to-external-fc` I will also make this change depend on https://reviews.llvm.org/D125832 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3519403 , @DavidSpickett wrote: > Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me > know if/when the first half of the change goes in. https://reviews.llvm.org/D125832 for "patch 1".

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. In the call on Monday, it was mentioned that the original users of the flang script have moved on to using a custom driver. It will be a good idea to, -> wait for

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

h-vetinari added a comment. Very happy to see this finally happening! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 ___ cfe-commits mailing list

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

DavidSpickett added a comment. Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me know if/when the first half of the change goes in. I'll leave it to others to approve the change overall. I do think being able to do `./bin/flang` and get the right flang will save a

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3519297 , @DavidSpickett wrote: > Can we expect the current `flang-new`, soon to be `flang` to also cope with > these tests (I have no expectations myself here, fine if not) or should we > move the bots to use

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

DavidSpickett added a comment. Do you know how this will work with the llvm-testsuite runs that currrently use gfortran for codegen? Here is one we have: https://lab.llvm.org/buildbot/#/builders/179/builds/3694 Currently: 2022-05-17 13:06:53 INFO: Execute: /usr/bin/cmake

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski created this revision. awarzynski added reviewers: rovka, jeanPerier, peixin, kiranktp, Leporacanthicus, dpalermo, ekieri, schweitz, shraiysh, h-vetinari, rouson. Herald added a subscriber: mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: clementval. Herald added