[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:205 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXVNNIINT8, "avxvnniint8") X86_FEATURE (AVXVNNI, "avxvnni") skan wrote: >

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2098 +TARGET_BUILTIN(__builtin_ia32_vpdpbssd128, "V4iV4iV4iV4i", "ncV:128:", "avxvnniint8") +TARGET_BUILTIN(__builtin_ia32_vpdpbssd256, "V8iV8iV8iV8i", "ncV:256:", "avxvnniint8")

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

skan added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:205 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXVNNIINT8, "avxvnniint8") X86_FEATURE (AVXVNNI, "avxvnni") Move it after AVXVNNI

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. > Its not a priority, but if you are ever bored and want to do some cleaning > then it help! I see. Then we are on the same side. I'll clean if I had time after landing these patches. Repository: rG LLVM Github Monorepo

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added a comment. In D135938#3867170 , @FreddyYe wrote: > I get your point of "close to each other" and updated. And I merged the > Disasm tests, while I didn't merge the MC tests because it is not so > convenient to do. See latest updated. > >

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:146 avxvnniintrin.h + avxvnniint8intrin.h bmi2intrin.h Move it before `avxvnniintrin.h` for the order? Comment at: llvm/lib/Support/X86TargetParser.cpp:584

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote: > > > Are there tests

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + FreddyYe wrote: > craig.topper wrote: > > Are there tests for commuting? > Hi

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > Are there tests for commuting? Hi Craig, Can you show an

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. In D135938#3864521 , @RKSimon wrote: > Can you fix the MC + disasm test file names - drop att/intel and ensure you > test both syntaxes for 32 and 64 bits. > > Ideally the 32/64 bit

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added a comment. Can you fix the MC + disasm test file names - drop att/intel and ensure you test both syntaxes for 32 and 64 bits. Ideally the 32/64 bit names should be close to each other in a file list (e.g. avx-vnni-int8-32.s + avx-vnni-int8-64.s ?) Repository: rG LLVM Github

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8141 + i128mem, X86vpdpbssd, SchedWriteVecIMul.XMM, + 1>, T8XD; + defm VPDPBSSDY : avx_dotprod_rm<0x50,"vpdpbssd", v8i32,

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe updated this revision to Diff 468398. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 Files: clang/docs/ReleaseNotes.rst

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt:1 +# RUN: llvm-mc --disassemble %s -triple=i686 | FileCheck %s + RKSimon wrote: > I think we'd be better off merging the

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:553 - Fix 32-bit ``__fastcall`` and ``__vectorcall`` ABI mismatch with MSVC. +- Support ISA of ``AVX-VNNI-INT8``. Please add a bullet list of the added intrinsics

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 4 inline comments as done. FreddyYe added a comment. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 ___ cfe-commits mailing

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added a comment. I'm out of machines next two days. Sorry for late address in advance... I'll update next Monday. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added inline comments. Comment at: clang/test/CodeGen/avxvnniint8-builtins.c:1 +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avxvnniint8 -emit-llvm -o - -Wall -Werror | FileCheck %s +

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__AVXVNNIINT8__"); + Builder.defineMacro("__AVXVNNIINT8_SUPPORTED__"); if (HasAVXVNNI) Why is this define needed? Comment at: