On Mon, 18 Mar 2024 20:50:59 GMT, Damon Nguyen wrote:
> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
> no longer an applet. Added test instructions related to the linked JBS issue.
This pu
> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
> no longer an applet. Added test instructions related to the linked JBS issue.
Damon Nguyen has updated the pull request incrementally with on
On Fri, 22 Mar 2024 22:15:48 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
> D
> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
> no longer an applet. Added test instructions related to the linked JBS issue.
Damon Nguyen has updated the pull request incrementally with on
On Fri, 22 Mar 2024 21:05:09 GMT, Sergey Bylokhov wrote:
> > Instantiating JFileChooser on EDT adds complexity for no benefit. The
> > JFileChooser is still accessed concurrently from several threads, including
> > Swing internal thread.
>
> But still, this is a common requirement to create UI
On Fri, 22 Mar 2024 09:01:01 GMT, Tejesh R wrote:
>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 144:
>
>> 142: public void performTest() throws InterruptedException,
>> InvocationTargetException {
>> 143: robot.setAutoDelay(100);
On Fri, 22 Mar 2024 07:02:05 GMT, Prasanta Sadhukhan
wrote:
>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42:
>
>> 40: public class bug4385611 {
>> 41: static JButton bt1, bt2;
>> 42: static final ImageIcon icon32x32 = new
>> Image
On Fri, 22 Mar 2024 09:04:28 GMT, Tejesh R wrote:
>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 165:
>
>> 163: robot.hitKey(KeyEvent.VK_M);
>> 164: robot.hitKey(KeyEvent.VK_N);
>> 165: robot.hitKey(KeyEvent.VK_O);
>
>
On Fri, 22 Mar 2024 06:57:12 GMT, Prasanta Sadhukhan
wrote:
>> Clean up and opensource five tests.
>
> test/jdk/javax/swing/InputVerifier/bug4774166.java line 44:
>
>> 42: * @summary InputVerifier should be called after a window loses and then
>> regains focus
>> 43: * @library /javax/swing/
On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung wrote:
> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
Ideally the Instruction window and Test window
On Tue, 19 Mar 2024 17:03:25 GMT, Alexey Ivanov wrote:
>Instantiating JFileChooser on EDT adds complexity for no benefit. The
>JFileChooser is still accessed concurrently from several threads, including
>Swing internal thread.
But still, this is a common requirement to create UI components on
On Thu, 14 Mar 2024 20:13:58 GMT, Sergey Bylokhov wrote:
> This is a request to forward port the test added by the
> [JDK-8241307](https://bugs.openjdk.org/browse/JDK-8241307) with inverted
> condition - jdk jdk11 the marlin should be used by default.
This pull request has now been integrated.
On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung wrote:
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
@alisenchung The original test works on Windows. Is it on macOS that nothing is
shown ?
On Wed, 20 Mar 2024 21:30:53 GMT, Larry Cable wrote:
> [https://bugs.openjdk.org/browse/JDK-8321428](url)
looks good except for
(1) that blank line
(2) skara would like you to rename the PR to match the bug + approved CSR.
src/java.desktop/share/classes/java/beans/beancontext/package-info.java
[https://bugs.openjdk.org/browse/JDK-8321428](url)
-
Commit messages:
- 83020930: added @Deprecated and @SuppressWarnings to depreciate
java.beans.beancontext
Changes: https://git.openjdk.org/jdk/pull/18413/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18413&range=00
I
On Fri, 22 Mar 2024 20:03:17 GMT, Alisen Chung wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 34:
>
>> 32: *
On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to
>> main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
> D
Convert java/awt/print/PageFormat/SetOrient.html applet test to main using
PassFailJFrame.
-
Commit messages:
- 8328719 Initial test conversion
Changes: https://git.openjdk.org/jdk/pull/18462/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18462&range=00
Issue: https://b
Convert
java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html
applet test to main using PassFailJFrame
-
Commit messages:
- 8328827 Initial test conversion
Changes: https://git.openjdk.org/jdk/pull/18461/files
Webrev: https://webrevs.openjdk.org/?r
On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to
>> main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 22 Mar 2024 17:28:10 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47:
>>
>>> 45: frame.setContentPane(panel);
>>> 46: frame.pack();
>>> 47: frame.setVisible(true);
>>
>> frame dispose is not req
On Fri, 22 Mar 2024 08:45:15 GMT, Damon Nguyen wrote:
> Same for me. Looks like it's not an issue with the test and rather a bug that
> hasn't been fixed yet. I found
> [JDK-8065647](https://bugs.openjdk.org/browse/JDK-8065647) which I think is
> related to this. Seems to be filed after the bu
> Convert java/awt/print/bug8023392/bug8023392.html applet test to main using
> PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Move test out of extra dir
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Fri, 22 Mar 2024 15:20:02 GMT, Alexey Ivanov wrote:
> I somewhat dislike that the test completes too quickly when I use my mouse.
> Yes, you warn the tester the test is semi-automatic, yet I'd prefer giving
> the tester more time.
>
> Technically, one event with `e.getWheelRotation() != 0`
On Thu, 14 Mar 2024 19:50:18 GMT, Harshitha Onkar wrote:
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/j
On Fri, 22 Mar 2024 11:25:10 GMT, Tejesh R wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47:
>
>> 45:
On Fri, 22 Mar 2024 16:54:49 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
Convert java/awt/print/bug8023392/bug8023392.html applet test to main using
PassFailJFrame
-
Commit messages:
- Initial test conversion
Changes: https://git.openjdk.org/jdk/pull/18458/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18458&range=00
Issue: https://bugs.open
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
Phil Race has updated the pull request incrementally with one additional commit
sin
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
This pull request has now been
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
OK, I've removed the problem li
On Fri, 22 Mar 2024 17:17:17 GMT, Phil Race wrote:
>> This previously closed test is cleaned up, opened and fixed to work on hidpi
>> at fractional scales.
>> It has unrelated problems on macOS 14 and is problem listed there (as it was
>> when it was a closed test).
>
> Phil Race has updated th
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has updated the pull request
On Fri, 22 Mar 2024 15:31:48 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed the forcePass logic, updated instructions
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java l
> Test is now passing in mac..Several iterations of the test passed in CI
> system..link in JBS...deproblemlisted...
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
spacing
-
Changes:
- all: https://git.openjdk.
On Mon, 18 Mar 2024 20:36:53 GMT, Alexander Zuev wrote:
> Convert test to a main based;
> Move test to an appropriate folder;
> Remove old files;
This pull request has now been integrated.
Changeset: b7a51dd0
Author:Alexander Zuev
URL:
https://git.openjdk.org/jdk/commit/b7a51dd0e8d5
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
test/jdk/java/awt/Dialog/JaWSTe
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
test/jdk/java/awt/Dialog/JaWSTe
Removing applet usage from manual JFileChooser tests
The original test is failing (nothing shows up in the JFileChooser), but this
change does replace the applet usage with PassFailJFrame
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/18456/files
Webre
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
Looks good to me.
I agree with
> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;
Alexander Zuev has updated the pull request incrementally with two additional
commits since the last revision:
- Moving toolkit checkto the beginning of the main method.
- Update test/jdk/java/awt/FileDialog/
On Mon, 18 Mar 2024 20:45:03 GMT, Alexander Zuev wrote:
> Convert test to main manual;
> Move test to appropriate folder;
> Delete old files;
This pull request has now been integrated.
Changeset: 739957ca
Author:Alexander Zuev
URL:
https://git.openjdk.org/jdk/commit/739957ca1e3b9ac9
On Thu, 21 Mar 2024 19:53:48 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
On Thu, 21 Mar 2024 19:53:48 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
On Thu, 21 Mar 2024 13:02:29 GMT, Alexander Zvegintsev
wrote:
> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
> `delay` fixes the issue.
>
> Manual and CI testing looks good.
This pull request has now been integrated.
Changeset: 638708ca
Author:Alexander Zv
> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
> `delay` fixes the issue.
>
> Manual and CI testing looks good.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
Add @requires (os.family != "win
On Fri, 22 Mar 2024 05:15:38 GMT, Alexander Zuev wrote:
>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Got rid of the test wind
On Fri, 22 Mar 2024 10:49:13 GMT, Julian Waters wrote:
>> bot-keep-alive
>>
>> @TheShermanTanker Did you understand the remaining changes that Phil has
>> requested? Do you think you'll be able to fix this?
>
> @magicus Phil doesn't seem to be responding to my queries, I'm not too sure
> what
On Sat, 20 Jan 2024 00:40:40 GMT, Phil Race wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 79 commits:
>>
>> - Merge branch 'openjdk:master' into patch-10
>> - Merge branch 'openjdk:master' into patch-10
On Thu, 21 Mar 2024 17:56:14 GMT, Phil Race wrote:
>> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
>> line 110:
>>
>>> 108: } catch (UnsupportedFlavorException | IOException e) {
>>> 109: e.printStackTrace();
>>> 110: }
>>
On Sat, 20 Jan 2024 00:32:19 GMT, Phil Race wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 79 commits:
>>
>> - Merge branch 'openjdk:master' into patch-10
>> - Merge branch 'openjdk:master' into patch-10
On Fri, 3 Nov 2023 02:39:26 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 61:
>>
>>> 59:
>>> 60: jfieldID AwtPrintDialog::pageID;
>>> 61:
>>
>> where and why did this come from ?
>
> This came from below, all I did was move it up and out of
On Sun, 3 Dec 2023 15:37:47 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Frame.cpp line 1641:
>>
>>> 1639: }
>>> 1640: }
>>> 1641:
>>
>> A possible improvement later (and for a future RFE) would be to use RAII for
>> deletion and then get rid of
On Wed, 20 Mar 2024 06:38:59 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Fri, 22 Mar 2024 08:48:35 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to
>> main using PassFailJFrame for the instructions.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev wrote:
> Clean up and opensource five tests.
test/jdk/javax/swing/InputVerifier/bug4774166.java line 144:
> 142: public void performTest() throws InterruptedException,
> InvocationTargetException {
> 143: robot.setAutoDelay(100);
> 1
On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar wrote:
> Few closed manual applet JFileChooser tests convereted to PassFailJFrame
> based manual test.
This pull request has now been integrated.
Changeset: 528efe20
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/528ef
On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar wrote:
> Few closed manual applet JFileChooser tests convereted to PassFailJFrame
> based manual test.
Looks good to me.
-
Marked as reviewed by tr (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18447#pullrequestreview-19
On Mon, 18 Mar 2024 15:55:15 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 84 commits:
>>
>> - Merge branch 'openjdk:master' into patch-10
>> - awt_Window.cpp
>> - awt_Frame.cpp
On Fri, 22 Mar 2024 09:55:46 GMT, Prasanta Sadhukhan
wrote:
> Test is now passing in mac..Several iterations of the test passed in CI
> system..link in JBS...deproblemlisted...
test/jdk/java/awt/Frame/DisposeParentGC/DisposeParentGC.java line 1:
> 1: /*
Since these lines are unchanged, I cou
On Thu, 21 Mar 2024 09:04:19 GMT, Prasanta Sadhukhan
wrote:
> Couple closed manual applet text/html/CSS tests are converted to main based
> and opensourced
This pull request has now been integrated.
Changeset: cd534f81
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/com
On Fri, 22 Mar 2024 10:02:49 GMT, Tejesh R wrote:
>> Convert and open source these manual applet test to main based:
>> java/awt/Frame/MegaIconTest/MegaIconTest.html
>> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
>> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
>> java/awt
On Fri, 22 Mar 2024 08:55:26 GMT, Abhishek Kumar wrote:
> Few closed manual applet JFileChooser tests convereted to PassFailJFrame
> based manual test.
Marked as reviewed by psadhukhan (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18447#pullrequestreview-1954414137
> Convert and open source these manual applet test to main based:
> java/awt/Frame/MegaIconTest/MegaIconTest.html
> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
Tejesh R
Test is now passing in mac..Several iterations of the test passed in CI
system..link in JBS...deproblemlisted...
-
Commit messages:
- 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java
fails for Mac only
Changes: https://git.openjdk.org/jdk/pull/18449/files
Convert and open source these manual applet test to main based:
java/awt/Frame/MegaIconTest/MegaIconTest.html
java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html
-
Com
On Thu, 21 Mar 2024 10:46:41 GMT, Abhishek Kumar wrote:
> Few manual closed applet test converted to automated and open sourced.
This pull request has now been integrated.
Changeset: 38e3cda4
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/38e3cda4420ef921cc6e43cb18338
On Thu, 21 Mar 2024 17:36:40 GMT, Abhishek Kumar wrote:
>> Few manual closed applet test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove getContentPane usage
Looks fine for
On Fri, 22 Mar 2024 09:12:27 GMT, Tejesh R wrote:
>> Don't think so. Test is all about CTRL+I pressed, if it fails that means
>> event is not triggered.
>
> Not for failure case, I meant for Pass case.
Anyways, Test passed will be recorded in jtr file.
-
PR Review Comment: https:/
On Fri, 22 Mar 2024 08:56:49 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 86:
>>
>>> 84: if (!iPressed) {
>>> 85: throw new RuntimeException("Test failed: CTRL+I not
>>> pressed.");
>>> 86: }
>>
>> Console print menti
Few closed manual applet JFileChooser tests convereted to PassFailJFrame based
manual test.
-
Commit messages:
- Applet test conerted to main manual and open sourced
Changes: https://git.openjdk.org/jdk/pull/18447/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18447&range
On Fri, 22 Mar 2024 07:17:00 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove getContentPane usage
>
> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 75:
>
>> 73: robot.mouse
On Fri, 22 Mar 2024 01:23:40 GMT, Harshitha Onkar wrote:
> @DamonGuy Tested on macOS, JColorChooser DnD doesn't seem to work on it.
Same for me. Looks like it's not an issue with the test and rather a bug that
hasn't been fixed yet. I found
[JDK-8065647](https://bugs.openjdk.org/browse/JDK-806
> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
> using PassFailJFrame for the instructions.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
-
Changes:
- all: http
On Thu, 21 Mar 2024 17:36:40 GMT, Abhishek Kumar wrote:
>> Few manual closed applet test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove getContentPane usage
test/jdk/javax
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev wrote:
> Clean up and opensource five tests.
test/jdk/javax/swing/InputVerifier/bug4774166.java line 44:
> 42: * @summary InputVerifier should be called after a window loses and then
> regains focus
> 43: * @library /javax/swing/regtesthelpers
77 matches
Mail list logo
