> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Tue, 23 Apr 2024 14:25:22 GMT, Magnus Ihse Bursie wrote:
> There's a huge amount of changes for just hsdis... You might have to separate
> out the infrastructure changes that seem to amount to most of the changes
> here.
>
> This is going to take me a while to get through.
Sorry, it's
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote:
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
>
WIP
This changeset contains hsdis for Windows/gcc Port. It supports both the
binutils and capstone backends, though the LLVM backend is left out due to
compatibility issues encountered during the build. Currently, which gcc
distributions are supported is still to be clarified, as several,
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
On Tue, 23 Apr 2024 05:02:53 GMT, Tejesh R wrote:
> > Do you mind if I shorten the subject of the bug? _Printing JTable throws
> > InternalError: HTHEME is null_?
>
> Sure, it's better to shorten it. And since its only for windows L, it can
> be mentioned in subject I guess.
I've updated the
On Tue, 23 Apr 2024 11:02:48 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a
On Tue, 23 Apr 2024 10:34:32 GMT, Alexey Ivanov wrote:
>> Means only till openThemeImpl return value and not further up the hierarchy ?
>
> Yes, only the low-level methods until it's put into a map.
Yeah, sounds good. Will do that.
-
PR Review Comment:
On Tue, 23 Apr 2024 10:30:49 GMT, Tejesh R wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 110:
>>
>>> 108:// See documentation for SetWindowTheme on MSDN.
>>> 109:setWindowTheme(widget.substring(0, i));
>>> 110:theme =
On Tue, 23 Apr 2024 10:23:33 GMT, Tejesh R wrote:
>> I didn't get the need for helper method?
>
> Ok, I got it. And I have updated. But if we want to change `theme` to `long`,
> then I guess we have to do it every calling function I guess. So is it better
> to leave it as `Long` ?
I still
On Tue, 23 Apr 2024 10:31:02 GMT, Alexey Ivanov wrote:
>> Ok, I got it. And I have updated. But if we want to change `theme` to
>> `long`, then I guess we have to do it every calling function I guess. So is
>> it better to leave it as `Long` ?
>
> I still think we should change `Long` to
On Tue, 23 Apr 2024 10:24:22 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 110:
>
>> 108://
On Tue, 23 Apr 2024 10:19:40 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Tue, 23 Apr 2024 07:11:30 GMT, Tejesh R wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 117:
>>
>>> 115:if (theme == null || theme == 0) {
>>> 116:theme = openTheme(widget, defaultDPI);
>>> 117:}
>>
>> `theme` can't be `null`
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFailJFrame.builder is used.
Tejesh R has updated the
On Tue, 23 Apr 2024 06:44:32 GMT, Abhishek Kumar wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>>
On Mon, 22 Apr 2024 21:49:54 GMT, Damon Nguyen wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
On Sat, 11 Nov 2023 12:32:15 GMT, Jan Trukenmüller wrote:
>> The MIDI file parser misinterprets events without status byte when they
>> appear directly after a Meta of SysEx event.
>>
>> For my bugfix I had to decide between two possible solutions:
>> - Strict solution: Throw an
On Mon, 22 Apr 2024 21:41:12 GMT, Damon Nguyen wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
On Mon, 22 Apr 2024 16:03:12 GMT, Alisen Chung wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard
>> navigation is tested in each OS and according it's current implementation
>> the instructions has been updated (Few has been removed and few has been
>> updated).
On Mon, 22 Apr 2024 15:09:37 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved failure handling inside openThemeImpl method
>
> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java
On Tue, 23 Apr 2024 02:25:57 GMT, Alexander Zuev wrote:
>> I replaced reflection with using an accessor
>> @azuev-java please review
>
> The problem with this fix is that on the test example attached to the bug any
> attempt of navigation trough the items of JTree whole voice over is enabled
>
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
>
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith
29 matches
Mail list logo
