On Thu, 25 Jul 2024 09:18:50 GMT, Alexey Ivanov wrote:
>> After I integrated
>> [JDK-8326734](https://bugs.openjdk.org/browse/JDK-8326734), there's no way
>> to remove text decoration from an HTML element. The most common HTML element
>> is `` which is usually rendered _underlined_. You could
On Thu, 16 May 2024 04:27:25 GMT, Sergey Bylokhov wrote:
>> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
>> verify that the cmm id of the icc profile is properly reported. Before
>> JDK-8321489 we always report 'lcms' as a cmm id.
>
> Sergey Bylokhov has updated the
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith Kann
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote:
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
Marked as reviewed by dmarkov (Reviewe
On Tue, 2 Apr 2024 10:29:45 GMT, Alexey Ivanov wrote:
> Update the problem-list entry for `
> javax/swing/JFileChooser/8194044/FileSystemRootTest.java` to refer to
> [JDK-8327236](https://bugs.openjdk.org/browse/JDK-8327236) under which the
> failure with `"root drive reported as false"` is tr
On Tue, 12 Mar 2024 16:48:28 GMT, Alexey Ivanov wrote:
>> The test is converted to use `PassFailJFrame`.
>>
>> I confirmed the updated test reproduce the original problem described in
>> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
>> displayed as missing glyphs
On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov wrote:
> Updated several tests to avoid potential failure with recent LCMS update and
> non-LCMS generated profile.
This pull request has now been integrated.
Changeset: 1f43fa0f
Author:Dmitry Markov
URL:
https://git.openjdk.o
On Mon, 11 Mar 2024 23:02:53 GMT, Phil Race wrote:
> Converts the manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
>
> Added requires windows since it seems very w
On Fri, 8 Mar 2024 01:09:27 GMT, Sergey Bylokhov wrote:
>> I agree, I reverted almost all changes except the ones in tolerance for
>> non-LCMS profiles. That values need to be updated to make the test pass on
>> JDKs (e.g. JDK 8u, etc) where non-LCMS profiles are used
>
> Could you please clari
> Updated several tests to avoid potential failure with recent LCMS update and
> non-LCMS generated profile.
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Tolerance update
-
Changes:
- all: https://git.openj
On Tue, 5 Mar 2024 03:49:01 GMT, Sergey Bylokhov wrote:
>> test/jdk/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java line 63:
>>
>>> 61: 10.5, // GRAY
>>> 62: 215.0, // PYCC
>>> 63: 56.0// CIEXYZ
>>
>> All this change will delete all information about
Updated several tests to avoid potential failure with recent LCMS update and
non-LCMS generated profile.
-
Commit messages:
- 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles
were generated by LCMS
Changes: https://git.openjdk.org/jdk/pull/18097/files
Webr
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote:
>> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a
>> single *Print* button as its test UI. To simplify the UI, I used the new
>> `splitUI` method from #17845.
>>
>> In addition to it, I refactored the test:
>>
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote:
> This enhancement adds three methods to `PassFailJFrame.Builder`:
>
> 1. **`splitUIRight`** to display test UI to the right of the instructions;
> 2. **`splitUIBottom`** to display test UI to the bottom of the instructions;
> 3. `splitUI`:
On Thu, 26 Oct 2023 06:11:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Mon, 23 Oct 2023 03:28:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have added additional CountDownLatch for making sure button is visible
>> before proceeding,(observe this was one of the key reason for failure) so
>> this helps to improve test case stability. Modifi
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified _a
On Mon, 24 Jul 2023 00:38:52 GMT, Sergey Bylokhov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added test cases, fixed spacing
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line
> 98
On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Fri, 23 Jun 2023 20:24:21 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Wed, 21 Jun 2023 16:12:46 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line
>> 48:
>>
>>> 46: public class MaximizedToIconified
>>> 47: {
>>> 48: static volatile int lastFrameState;
>>
>> What is the purpose of test change? Can yo
On Tue, 20 Jun 2023 20:08:20 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Wed, 14 Jun 2023 20:09:45 GMT, Phil Race wrote:
> I don't like the idea of a delay in either of the ways discussed here. And
> although I do think that its much better to wait for delivery of an event,
> I'm not sure I understand the windowState listener proposal. How do you know
> in this
On Wed, 14 Jun 2023 18:25:31 GMT, Harshitha Onkar wrote:
> Minor Javadoc change for since tag in Container.java
Marked as reviewed by dmarkov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14474#pullrequestreview-1480151433
On Mon, 12 Jun 2023 22:29:25 GMT, Alisen Chung wrote:
>> added displayChanged call to CPlatformWindow when frame first needs to
>> deiconify or unmaximize
>> All client tests passed after change
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the l
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
If I got it right the switching to `ICONIFIED`/`MAXIMIZED_BOTH` state takes
more time on macOS 13 than
On Tue, 30 May 2023 18:41:38 GMT, Alisen Chung wrote:
> added displayChanged call to CPlatformWindow when frame first needs to
> deiconify or unmaximize
> All client tests passed after change
Changes requested by dmarkov (Reviewer).
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWin
On Thu, 11 May 2023 16:50:00 GMT, Alexey Ivanov wrote:
> > The new version of the test fails for me on macOS because CTRL + DOWN key
> > combination is reserved by the operating system. It is necessary to disable
> > "Application windows" system key shortcut to execute the test without
> > fai
On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> Noticed this test case not verifying all the cases which is intended.
> Modified it for improving the coverage for 3 type of popups (menu, context
> menu and combobox).
>
> Evaluating conditions:
> 1. Not e
On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> Noticed this test case not verifying all the cases which is intended.
> Modified it for improving the coverage for 3 type of popups (menu, context
> menu and combobox).
>
> Evaluating conditions:
> 1. Not e
On Thu, 4 May 2023 17:36:33 GMT, Rajat Mahajan wrote:
>> **Problem:**
>>
>> On pressing the Copy button we keep waiting in AWT-EventQueue thread in
>> reconstruct() function as we detect that we have missing information for the
>> animated image since we are copying single frame at a time.
>>
On Wed, 12 Apr 2023 16:13:13 GMT, Harshitha Onkar wrote:
>> There are a few deprecated Cocoa NSEvent names currently in use in JDK.
>>
>> https://github.com/openjdk/jdk/blob/jdk-21+17/src/java.desktop/macosx/classes/sun/lwawt/macosx/CocoaConstants.java
>> https://developer.apple.com/documentatio
On Tue, 11 Apr 2023 23:04:16 GMT, Harshitha Onkar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> copyright year & formatting update
>
> test/jdk/java/awt/Mouse/MacTouchPressEventModifiers/MouseMacTouchPressEven
On Tue, 11 Apr 2023 23:05:23 GMT, Harshitha Onkar wrote:
>> There are a few deprecated Cocoa NSEvent names currently in use in JDK.
>>
>> https://github.com/openjdk/jdk/blob/jdk-21+17/src/java.desktop/macosx/classes/sun/lwawt/macosx/CocoaConstants.java
>> https://developer.apple.com/documentatio
On Tue, 4 Apr 2023 15:46:36 GMT, Dmitry Markov wrote:
> Port the fix from the upstream/HarfBuzz repo.
>
> More info can be obtained here:
> https://github.com/harfbuzz/harfbuzz/discussions/4188
> https://github.com/harfbuzz/harfbuzz/commit/04a47932a3844f7e73e3af8b05fb98c8b54f
On Tue, 4 Apr 2023 15:46:36 GMT, Dmitry Markov wrote:
> Port the fix from the upstream/HarfBuzz repo.
>
> More info can be obtained here:
> https://github.com/harfbuzz/harfbuzz/discussions/4188
> https://github.com/harfbuzz/harfbuzz/commit/04a47932a3844f7e73e3af8b05fb98c8b54fb
On Tue, 4 Apr 2023 21:56:12 GMT, Sergey Bylokhov wrote:
> I don't see why we need this in mainline. I'd prefer to not have it unless we
> need it.
I believe it is better to have all JDK branches in sync if it's possible.
This change is harmless and as Sergey mentioned it would simplify backpor
Port the fix from the upstream/HarfBuzz repo.
More info can be obtained here:
https://github.com/harfbuzz/harfbuzz/discussions/4188
https://github.com/harfbuzz/harfbuzz/commit/04a47932a3844f7e73e3af8b05fb98c8b54fb779
-
Commit messages:
- 8305527: HarfBuzz: Remove trailing comma fro
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote:
> Added the section devoted to client UI test which use Robot API
This pull request has now been integrated.
Changeset: a10d5ac6
Author: Dmitry Markov
URL:
https://git.openjdk.org/jdk/com
On Tue, 28 Feb 2023 16:45:36 GMT, Alexey Ivanov wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> doc/testing.md line 668:
>
>> 666: Additional information
> Added the section devoted to client UI test which use Robot API
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Fix link
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12772/files
- new: ht
On Tue, 28 Feb 2023 14:00:21 GMT, Erik Joelsson wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review findings
>
> doc/testing.md line 666:
>
>> 664: the `Foregroun
> Added the section devoted to client UI test which use Robot API
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12772/files
- new: ht
On Mon, 27 Feb 2023 20:52:52 GMT, Sergey Bylokhov wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review findings
>
> doc/testing.md line 664:
>
>> 662: select Registr
On Mon, 27 Feb 2023 18:49:15 GMT, Alexey Ivanov wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review findings
>
> doc/testing.md line 616:
>
>> 614: system key short
On Mon, 27 Feb 2023 21:11:33 GMT, Alexey Ivanov wrote:
>> doc/testing.html line 621:
>>
>>> 619: the following apps are allowed to control your computer:
>>> 620: Java and Terminal. If the tests are run from
>>> 621: an IDE, the IDE should be granted this permission too.
>>
>> You can mention t
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote:
> Added the section devoted to client UI test which use Robot API
@aivanov-jdk @mrserb Thanks for review. I have updated the text based on your
suggestions. Please have a look at the new version.
-
PR: https://git.openjdk.
> Added the section devoted to client UI test which use Robot API
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Fix review findings
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12772/files
- new: ht
Added the section devoted to client UI test which use Robot API
-
Commit messages:
- 8303130: Document required Accessibility permissions on macOS
Changes: https://git.openjdk.org/jdk/pull/12772/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12772&range=00
Issue: https://
On Tue, 20 Sep 2022 16:34:41 GMT, Alexey Ivanov wrote:
> Remove *the "Classpath" exception* from tests in `javax/swing`. The tests
> should not have it.
Marked as reviewed by dmarkov (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10360
On Tue, 20 Sep 2022 16:38:45 GMT, Alexey Ivanov wrote:
> Remove *the "Classpath" exception* from tests in `javax/awt`. The tests
> should not have it.
Marked as reviewed by dmarkov (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10361
On Mon, 27 Jun 2022 07:01:35 GMT, Prasanta Sadhukhan
wrote:
> In macos, popups does not overlap taskbar unlike windows, as can be seen here
> in "Settings"
> so we can omit this test from macOS run.
>
> 