On Sat, 8 Jun 2024 00:49:29 GMT, Alisen Chung wrote:
>> test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:
>>
>>> 57: });
>>> 58: robot.waitForIdle();
>>> 59: robot.delay(1000);
>>
>> Suggestion:
>>
>> robot.setAutoDelay(100);
>>
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with one additional
On Mon, 10 Jun 2024 20:01:47 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with one additional
On Fri, 7 Jun 2024 21:19:41 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
On Fri, 7 Jun 2024 23:14:47 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test based on feedback
>
> test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:
>
>> 57:
On Fri, 7 Jun 2024 21:19:41 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
On Fri, 7 Jun 2024 07:35:19 GMT, Prasanta Sadhukhan
wrote:
>> Alisen Chung has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - update copyright years
>> - automated test
>> - changed test to automatic
>
> test/jdk/javax/swing/JPopupMe
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with one additional
On Fri, 7 Jun 2024 21:03:58 GMT, Alisen Chung wrote:
>> Although there's one more issue it seems where in native, after popup is
>> shown when right mouse button (or CTRL+left mouse button) is pressed, if you
>> release the mouse the popup vanishes which I noticed in Notes, Mail but it
>> does
On Fri, 7 Jun 2024 07:40:01 GMT, Prasanta Sadhukhan
wrote:
>> looks good..
>
> Although there's one more issue it seems where in native, after popup is
> shown when right mouse button (or CTRL+left mouse button) is pressed, if you
> release the mouse the popup vanishes which I noticed in Notes
On Fri, 7 Jun 2024 07:20:35 GMT, Prasanta Sadhukhan
wrote:
>> I believe only MouseEvents can be popup triggers. I checked in MouseEvent
>> that there is a field for popup triggers and no such field in KeyEvent.
>>
>> The isPopupTrigger method here also previously checked button down masks
>>
On Thu, 6 Jun 2024 18:28:12 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
On Thu, 6 Jun 2024 18:41:16 GMT, Alisen Chung wrote:
>> src/java.desktop/macosx/classes/sun/lwawt/macosx/NSEvent.java line 276:
>>
>>> 274: && jeventType != MouseEvent.MOUSE_RELEASED) {
>>> 275: return false;
>>> 276: }
>>
>> Just to double check, are the onl
On Thu, 6 Jun 2024 18:28:12 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
On Thu, 6 Jun 2024 18:18:14 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add event check in popup trigger
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/NSEvent.java line 276:
>
>> 274:
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with three additiona
On Thu, 6 Jun 2024 16:08:31 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
On Thu, 6 Jun 2024 16:08:31 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan
wrote:
>> Alisen Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> co
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with one additional
On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan
wrote:
> I guess it needs to be understood why it is not failing in windows and linux
> and only reproducible in macos. The fix in BasicLookAndFeel is not
> appropriate in my opinion as that shared code will be exercised in windows
> and lin
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with two additional
On Thu, 6 Jun 2024 05:26:53 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering the popup
>
> Alisen Chung h
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request with a new target base due to a me
On Wed, 5 Jun 2024 23:33:21 GMT, Alisen Chung wrote:
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Fix works as expected
Issue is a mouse drag will trigger a popup in macos, but not in linux or
windows.
The solution is to add a check for a mouse pressed event to show popup and
prevent mouse entered events from triggering the popup
-
Commit messages:
- fix trailing whitespace in instructions string
-
27 matches
Mail list logo
