On 2 August 2012 04:10, Edison Su wrote:
>
>
>> -Original Message-
>> From: Rohit Yadav [mailto:rohit.ya...@citrix.com]
>> Sent: Wednesday, August 01, 2012 1:29 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: non-committer workflow
>>
>>
>> > Hi,
>> >
>> > Prasanna and I've b
Hi Rohit,
I have already created the RB wiki for our team. Could you please post your
findings there if anything is not covered.
http://wiki.cloudstack.org/display/gen/Review+Board
Also, please let me know are you able to post your review through command line?
The last issue I have found befor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6279/#review9740
---
You also need to put the global config change in the
schema-currentVe
On Wed, Aug 1, 2012 at 9:09 PM, Chiradeep Vittal
wrote:
> It appears that the WSDL-based toolset is being deprecated by AWS [1].
>
> Currently the EC2 API layer implements both the WSDL interface as well as
> the Query API.
> However the Query API is not well tested.
> Furthermore the implemented
On Wed, Aug 1, 2012 at 10:15 PM, Mice Xia wrote:
> I can translate simplified Chinese resources.
> Before that I want to know the scope of this task, do ' internationalization'
> mean i18n (extracting messages to resource files, etc), or L10n (translation
> resources files to other languages), o
Thanks for the info. I have not been able to get this to work on my KVM backed
cloud, but I will keep trying.
Normally when I recycle SS, it just ignores all templates stored on it. This is
even with fresh DB installs where there is no way unique names will be
duplicated.
Thanks
Sent from my
I can translate simplified Chinese resources.
Before that I want to know the scope of this task, do ' internationalization'
mean i18n (extracting messages to resource files, etc), or L10n (translation
resources files to other languages), or both of them?
-Original Message-
I would like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6279/
---
Review request for cloudstack and Alena Prokharchyk.
Description
---
change
On 7/31/12 1:02 AM, "Wido den Hollander" wrote:
>
>
>On 07/31/2012 02:32 AM, Kelcey Damage (BBITS) wrote:
>> It would be great if we could look at creating a system (even just a
>>utility
>> script) that would allow us to re-attach a secondary storage server and
>> salvage existing templates ho
Edison,
Thanks for your clarification.
It's very clear now. Cloudstack does not care about how hypervisor access PS,
admin can configure a separate NIC on hypervisors only for primary storage
access if necessary.
Regards
Mice
-Original Message-
From: Edison Su [mailto:edison...@citrix.
+1 (non-binding)
there's no value to maintaining crufty code no-one wants
On Wed, Aug 1, 2012 at 6:09 PM, Chiradeep Vittal <
chiradeep.vit...@citrix.com> wrote:
> It appears that the WSDL-based toolset is being deprecated by AWS [1].
>
> Currently the EC2 API layer implements both the WSDL inter
On 2 August 2012 08:11, Ewan Mellor wrote:
>
> > The problem with that is that entire features that are not developed
> > within the project have a different process for inclusion.
> > Particularly when they are features that multiple people have
> > collaborated on externally.
>
> Could you defi
It appears that the WSDL-based toolset is being deprecated by AWS [1].
Currently the EC2 API layer implements both the WSDL interface as well as
the Query API.
However the Query API is not well tested.
Furthermore the implemented WSDL is of 2010-08 vintage.
Does it make sense to likewise deprecat
> On Aug. 1, 2012, 9:08 p.m., edison su wrote:
> > Do you miss the LibvirtVifDriver file? And, please separate the network
> > code from libvirtcomputingresource.
Ah, Yes. Thanks for the review. I will work on separating out the network code
and will submit patches.
- Tomoe
---
> -Original Message-
> From: Ewan Mellor
> Sent: Wednesday, August 01, 2012 5:02 PM
> To: cloudstack-dev@incubator.apache.org; Saksham Srivastava
> Cc: Edison Su
> Subject: RE: Review Request: Removing obsolete JUnit test file and
> disabling calls to cleanup.sql from upgrade tests.
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6300/#review9733
---
Ship it!
Ship It!
- Kelven Yang
On Aug. 1, 2012, 9:14 p.m., Venkat
> -Original Message-
> From: Mice Xia [mailto:mice_...@tcloudcomputing.com]
> Sent: Wednesday, August 01, 2012 4:52 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Regarding storage network
>
>
> Hi, All
>
> This has been discussed in a previous thread but i did not get the
> c
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Wednesday, August 01, 2012 5:00 PM
> To: cloudstack-dev@incubator.apache.org; Saksham Srivastava
> Cc: Edison Su
> Subject: Re: Review Request: Removing obsolete JUnit test file and
> disabling calls to cleanup.sql fro
On Wed, Aug 1, 2012 at 7:58 PM, Saksham Srivastava
wrote:
>
>
>> On Aug. 1, 2012, 11:29 p.m., edison su wrote:
>> > Could you use the following to skip upgrade test cases?
>> > diff --git a/build/developer.xml b/build/developer.xml
>> > index bfe496d..4e4a5aa 100755
>> > --- a/build/developer.xml
> On Aug. 1, 2012, 11:29 p.m., edison su wrote:
> > Could you use the following to skip upgrade test cases?
> > diff --git a/build/developer.xml b/build/developer.xml
> > index bfe496d..4e4a5aa 100755
> > --- a/build/developer.xml
> > +++ b/build/developer.xml
> > @@ -325,6 +325,7 @@
> >
Hi, All
This has been discussed in a previous thread but i did not get the conclusion
so here i started a new one.
In CS 2.2.y,for xenserver there is a storage network dedicated for traffic
between hypervisor and primary storage, users can separate this traffic from
others simply by assigning
> On Aug. 1, 2012, 10:26 p.m., edison su wrote:
> > The request o response is null, is not because they are null, it's because,
> > the loglevel set on the command class or member of command class. Take
> > GetHostStatsCommand as an example, it has set loglevel as
> > @LogLevel(Log4jLevel.Trac
On 02/08/2012, at 7:23 AM, Ewan Mellor wrote:
> We are using a shared ASF install of Review Board, yes. That doesn't have to
> be the case though -- it's up to us to decide which tools we want to use.
>
> Of course, the cost of going from zero mods to 1 is going to be large,
> because someon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6283/#review9729
---
Could you use the following to skip upgrade test cases?
diff --git a/b
> -Original Message-
> From: Rohit Yadav [mailto:rohit.ya...@citrix.com]
> Sent: Wednesday, August 01, 2012 1:29 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: non-committer workflow
>
>
> > Hi,
> >
> > Prasanna and I've been playing with the
> http://downloads.reviewboard.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6287/#review9726
---
The request o response is null, is not because they are null, it's bec
build/deploy/production/agent/storagehdpatch has been removed.
> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, August 01, 2012 12:02 PM
> To:
> Subject: Re: [DISCUSS] Build directory license header issues
>
> Well that certainly solves the
> -Original Message-
> From: David Nalley [mailto:da...@gnsa.us]
> Sent: Wednesday, August 01, 2012 3:05 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Review Request: Merge Kelven's VPC code for Vmware into
> asf vpc branch
>
> On Wed, Aug 1, 2012 at 5:55 PM, Ewan Mellor
> w
On Wed, Aug 1, 2012 at 5:55 PM, Ewan Mellor wrote:
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Wednesday, August 01, 2012 2:39 PM
>> To:
>> Cc: David Nalley; Kelven Yang; Alena Prokharchyk
>> Subject: Re: Review Request: Merge Kelven's VPC code
s/not/now
It is clean.
On Wed, Aug 1, 2012 at 10:32 AM, Chip Childers
wrote:
> I figured it out.
>
> This folder is not reporting as clean in RAT.
>
> https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/agent-simulator.txt
>
> -chip
> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, August 01, 2012 2:39 PM
> To:
> Cc: David Nalley; Kelven Yang; Alena Prokharchyk
> Subject: Re: Review Request: Merge Kelven's VPC code for Vmware into
> asf vpc branch
>
> On Aug 1, 2012, at
On Aug 1, 2012, at 5:21 PM, Vijayendra Bhamidipati
wrote:
> Hi David,
>
> This is Kelven's code that he checked in to the 3.0.x branch - I'm only
> merging it to the asf branch. After the recent code re-org, cherry-picking
> the patches wouldn't work, so I had to merge the code for each file.
> On Aug. 1, 2012, 9:15 p.m., David Nalley wrote:
> > Whose code is this? The description says it is Kelven's.
> >
This is Kelven's code that he checked in to the 3.0.x branch - I'm only merging
it to the asf branch. After the recent code re-org, cherry-picking the patches
wouldn't work, so I
We are using a shared ASF install of Review Board, yes. That doesn't have to
be the case though -- it's up to us to decide which tools we want to use.
Of course, the cost of going from zero mods to 1 is going to be large, because
someone would need to volunteer to install and manage our own ins
Hi David,
This is Kelven's code that he checked in to the 3.0.x branch - I'm only merging
it to the asf branch. After the recent code re-org, cherry-picking the patches
wouldn't work, so I had to merge the code for each file.
Regards,
Vijay
-Original Message-
From: David Nalley [mailto
Can someone please review this request from Saksham? Our unit tests
(http://jenkins.cloudstack.org/job/junit-test/) are currently showing 60
failures, and I'd like to get that number down so that we can see the real
situation.
Thanks,
Ewan.
> -Original Message-
> From: Saksham Sriv
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6300/#review9715
---
Whose code is this? The description says it is Kelven's.
- David Na
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6300/
---
Review request for cloudstack, Alena Prokharchyk and Kelven Yang.
Description
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6285/#review9714
---
Do you miss the LibvirtVifDriver file? And, please separate the networ
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6284/#review9713
---
Ship it!
Ship It!
- edison su
On Aug. 1, 2012, 3:46 p.m., Tomoe Su
Hi Rajesh,
From: Rajesh Battala [rajesh.batt...@citrix.com]
Sent: Wednesday, August 01, 2012 8:46 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: non-committer workflow
Rohit,
Pradeep had played and tweaked the same tools for our team. If you are
> Hi,
>
> Prasanna and I've been playing with the
> http://downloads.reviewboard.org/releases/RBTools/0.4/RBTools-0.4.1.tar.gz
> tool for posting the reviews via a command line utility.
I've a fork of the original tool that works for me:
https://github.com/bhaisaab/RBTool
Usage: http://wiki.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6299/
---
Review request for cloudstack.
Description
---
A dummy patch to test post-r
> > So part of me says, silencing merge/cherrypick commits is the way to
> go, but
> > there is a part of me that says that having to hide all of that means
> we are
> > doing something wrong; and the part of me that is concerned with what
> is
> > going on really does want to see all of that.
>
> So part of me says, silencing merge/cherrypick commits is the way to go, but
> there is a part of me that says that having to hide all of that means we are
> doing something wrong; and the part of me that is concerned with what is
> going on really does want to see all of that.
I don't like the
Well that certainly solves the problem!
- chip
Sent from my iPhone.
On Aug 1, 2012, at 2:53 PM, Edison Su wrote:
>
>
>> -Original Message-
>> From: Chip Childers [mailto:chip.child...@sungard.com]
>> Sent: Wednesday, August 01, 2012 8:39 AM
>> To: cloudstack-dev@incubator.apache.org
>>
> -Original Message-
> From: Chip Childers [mailto:chip.child...@sungard.com]
> Sent: Wednesday, August 01, 2012 8:39 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: [DISCUSS] Build directory license header issues
>
> RAT is now reporting [1] only a couple of issues in the build
> -Original Message-
> From: Wido den Hollander [mailto:w...@widodh.nl]
> Sent: Wednesday, August 01, 2012 4:38 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Fail attaching volume to a virtual machine
>
> On 08/01/2012 05:54 AM, Tommy Aditya Lawanto wrote:
> > @edison :
> >
The next Apache CloudStack release will be 4.0. This will include all of the
features currently in Cloud Platform's 3.0.x series, plus some re-architecting
to meet Apache policy. It's the re-architecting that's taking the time, but
we're aiming for September 4 for that release, pending Apache
RAT is not reporting no issues with this folder:
https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/client.txt
-chip
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6287/
---
(Updated Aug. 1, 2012, 5:18 p.m.)
Review request for cloudstack.
Summary (upda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6287/
---
Review request for cloudstack.
Description
---
Do not fill the agent log wi
On Wed, Aug 1, 2012 at 12:47 PM, sebgoa wrote:
>
> On Aug 1, 2012, at 10:29 AM, Joe Brockmeier wrote:
>>>
>>
>> It's different in that the submitter has to go to Review Board and
>> create an account, etc.
>>
>> If it's a one-off minor patch, a fair number of people are likely to
>> just say "meh"
On Aug 1, 2012, at 10:29 AM, Joe Brockmeier wrote:
>>
>
> It's different in that the submitter has to go to Review Board and
> create an account, etc.
>
> If it's a one-off minor patch, a fair number of people are likely to
> just say "meh" and drop it. Forcing people to use Review Board means
On Fri, Jul 27, 2012 at 10:13 AM, Chiradeep Vittal
wrote:
>
>
> On 7/25/12 10:52 PM, "Ishimoto, Ryu" wrote:
>
>>On Mon, Jun 4, 2012 at 3:02 PM, Chiradeep Vittal <
>>chiradeep.vit...@citrix.com> wrote:
>>
>>>
>>> Also note that in order to support hotplug and hot-detach of nics, we
>>>need
>>> com
Let us know when you revisit. When I quickly read your spec it seemed that it
would be fairly straightforward to enable some of the autoscaling api
documented at:
http://docs.amazonwebservices.com/AutoScaling/latest/APIReference/Welcome.html?r=8301
-Sebastien
On Aug 1, 2012, at 10:15 AM, Ram G
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6285/
---
Review request for cloudstack and Chiradeep Vittal.
Description
---
POC VIF
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6284/
---
Review request for cloudstack.
Description
---
Another clean up for unneces
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6283/
---
Review request for cloudstack.
Summary (updated)
-
Removing obs
RAT is now reporting [1] only a couple of issues in the build
directory, but they are a difficult situation to resolve. Please take
a look at the issues below and provide your comments.
These scripts / config files are licensed with the CDDL. We have a
problem here, since CDDL is classified as a
Rohit,
Pradeep had played and tweaked the same tools for our team. If you are going
to share about the tool, you can talk to Pradeep to share more stuff about it .
Thanks
Rajesh Battala
-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@citrix.com]
Sent: Wednesday, August 01,
One point of clarification - we're using a shared ASF install, no? There's been
a few questions this week about adding functionality, I don't think it's gonna
be quite that easy….
On Aug 1, 2012, at 7:40 AM, Abhinandan Prateek wrote:
Can review board software be programmed so that it does not r
On 07/31/2012 11:46 PM, David Nalley wrote:
Hi folks,
Just a quick update on this. I created the deps-ctrl branch off of
master now that I actually have something to show.
If you take a look under deps you'll see it looks pretty bare. I've
removed a number of the jars.
There's also a few new a
Can review board software be programmed so that it does not remove author
information from the submitted patches.
This will make it easy to submit patches and will avoid user error where author
information get replaced.
-abhi
>-Original Message-
>From: Nitin Mehta [mailto:nitin.me...@cit
Hi,
Prasanna and I've been playing with the
http://downloads.reviewboard.org/releases/RBTools/0.4/RBTools-0.4.1.tar.gz tool
for posting the reviews via a command line utility.
We can tweak the script easily so when you submit a review request, the
original git formatted patch is uploaded to so
I figured it out.
This folder is not reporting as clean in RAT.
https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/agent-simulator.txt
-chip
On Wed, Aug 1, 2012 at 10:26 AM, David Nalley wrote:
> On Wed, Aug 1, 2012 at 10:20 AM, Chip Childers
> wrote:
>> The agent-simulator
On Wed, Aug 01, 2012 at 06:26:38PM +0530, Prasanna Santhanam wrote:
> On Wed, Aug 01, 2012 at 08:42:51AM -0400, Rohit Yadav wrote:
> I agree Reviewboard has extra workflow involved but it integrates the
> review comments closely with the mailing list so it isn't as different
> from patches in the
On Wed, Aug 1, 2012 at 10:20 AM, Chip Childers
wrote:
> The agent-simulator folder is being reported as "clean" by RAT now,
> with two exceptions:
>
> ***
>
> Unapproved licenses:
>
> agent-simulator/db/create-schema-simulator.sql
> agent-simulator/scripts/zucchini/
RAT is reporting that both of these folders are now compliant:
https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/agent.txt
https://raw.github.com/chipchilders/asf_cloudstack_RAT_results/master/api.txt
-chip
The agent-simulator folder is being reported as "clean" by RAT now,
with two exceptions:
***
Unapproved licenses:
agent-simulator/db/create-schema-simulator.sql
agent-simulator/scripts/zucchini/zucchini.configuration.sql
***
Those fil
Makes sense Sebastien. Currently we are in the final leg of AutoScale feature
implementation. We can revisit this topic some time soon. Also we had some
prior discussions on this feature to be more vendor-agnostic.
Thanks,
Ram
> -Original Message-
> From: sebgoa [mailto:run...@gmail.co
I've been cleaning license headers in the awsapi folder, and I'm left
with a short list of files that I need the community's advice on.
Here are the outstanding issues:
- awsapi/waf
- awsapi/packages/config/debian/rules
I think we only need to include the copyright notices from these files
withi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6278/#review9687
---
Ship it!
Merging the patch with asf/autoscale as per Vijay's request.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6278/#review9686
---
Ship it!
The new error message looks fine. Please ship!
- Vijay Venk
On Wed, Aug 01, 2012 at 09:07:07AM -0400, Wido den Hollander wrote:
> >
> > This was tried in the past and backfired when non-committers send
> > through patches that get formatted by mail clients and have CRLF
> > issues when applied by the committer.
> >
>
> I think this happens when people atta
>
> I'm still very new to the project, but I found it very difficult to
> follow up what's going on because patches are in separate places.
> I'd argue there should be one single workflow so that we can better
> keep track of the status.
This is interesting feedback.
I was hoping we'd keep the bar
On Wed, Aug 1, 2012 at 9:56 PM, Prasanna Santhanam
wrote:
> On Wed, Aug 01, 2012 at 08:42:51AM -0400, Rohit Yadav wrote:
>>
>> On Aug 1, 2012, at 5:46 PM, Wido den Hollander wrote:
>>
>> > On 08/01/2012 04:50 AM, Alex Huang wrote:
>> >>> So currently, there are three ways for a patch to be receiv
On 08/01/2012 02:56 PM, Prasanna Santhanam wrote:
On Wed, Aug 01, 2012 at 08:42:51AM -0400, Rohit Yadav wrote:
On Aug 1, 2012, at 5:46 PM, Wido den Hollander wrote:
On 08/01/2012 04:50 AM, Alex Huang wrote:
So currently, there are three ways for a patch to be received:
1. Email (see the wor
Hi Prasanna,
On Aug 1, 2012, at 6:26 PM, Prasanna Santhanam
wrote:
> On Wed, Aug 01, 2012 at 08:42:51AM -0400, Rohit Yadav wrote:
>>
>> On Aug 1, 2012, at 5:46 PM, Wido den Hollander wrote:
>>
>>> On 08/01/2012 04:50 AM, Alex Huang wrote:
> So currently, there are three ways for a patch
Pranav,
got it, thanks, this configuration intends to urlencode response (though i have
no idea why there is such a requirement), however the description is a little
bit misleading, i'll patch it later
Regards
Mice
-Original Message-
From: Pranav Saxena [mailto:pranav.sax...@citrix.com
On Wed, Aug 01, 2012 at 08:42:51AM -0400, Rohit Yadav wrote:
>
> On Aug 1, 2012, at 5:46 PM, Wido den Hollander wrote:
>
> > On 08/01/2012 04:50 AM, Alex Huang wrote:
> >>> So currently, there are three ways for a patch to be received:
> >>> 1. Email (see the workflow Wido proposed) 2. Reviewboa
> On July 31, 2012, 9:27 a.m., Prasanna Santhanam wrote:
> > Bug Report: http://bugs.cloudstack.org/browse/CS-15776
> >
> > Saw quite a few whitespace changes as well. Ran a pychecker on the patch
> > and it looks fine.
> >
> >
>
> Tomoe Sugihara wrote:
> Actually the bug report was simil
On Aug 1, 2012, at 5:46 PM, Wido den Hollander wrote:
> On 08/01/2012 04:50 AM, Alex Huang wrote:
>>> So currently, there are three ways for a patch to be received:
>>> 1. Email (see the workflow Wido proposed) 2. Reviewboard 3. Submitted
>>> with a bug.
>>>
>>> Email and ReviewBoard are the mo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6278/
---
Review request for cloudstack, Murali Reddy, Pranav Saxena, and Vijay
Venkatachal
On 08/01/2012 04:50 AM, Alex Huang wrote:
So currently, there are three ways for a patch to be received:
1. Email (see the workflow Wido proposed) 2. Reviewboard 3. Submitted
with a bug.
Email and ReviewBoard are the most visible, and it seems most people are
using ReviewBoard rather than email.
According to the current scenario, Admin/domain-admin can update resource limit
to the value lower than the current resource count. Wouldn’t it be appropriate
to inform admin about this behavior and not to apply the lower limit. My
concern is that if, for example, a user has 5 instances and adm
On 08/01/2012 03:41 AM, Ewan Mellor wrote:
Sold, thanks John.
We're scheduled to finish the general development phase on Friday 10 August, so some time
between Friday afternoon and Monday morning we should create a release branch and bump
all the version numbers to some "4.0 prerelease" number
On 08/01/2012 05:54 AM, Tommy Aditya Lawanto wrote:
@edison :
Okay i have follow the instructions from your link. Does this mean i have to
submit bug to bugs.cloudstack.org also? (i upload agent.log on pastebin.com for
now)
- I use KVM Host Cent OS 6.2
- my libvirt version is 0.9.4
- Here i
Hi Mice ,
I am not sure , if the global configuration parameter could be removed from the
UI but I happened to come across this bug -
http://bugs.cloudstack.org/browse/CS-9697
Perhaps this might give you a brief idea about it.
Regards,
Pranav
-Original Message-
From: Mice Xia [mailto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6275/#review9683
---
Ship it!
Ship It!
- Pranav Saxena
On Aug. 1, 2012, 7:50 a.m., Deep
On Wed, Aug 01, 2012 at 06:41:11AM -0400, Deepak Garg wrote:
>
> HI All,
>
> How can we send dependent patches for review ?
>
> E.g. If we have two bugs A and B and a patch is already sent for
> bug A for review. Now I want to continue working on the patch for B
> which depends on the code chan
Hi,
Yes, you could attach the patch submitted for the first bug as the 'parent
diff' (http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/).
Thank you,
Likitha
-Original Message-
From: Deepak Garg [mailto:deepak.g...@citrix.com]
Sent: Wednesday, August 01, 2012 4:11 PM
T
I think we shouldn’t make this change. Since resources can always be destroyed
I would want to give the admin flexibility to set the resource limit to a value
lower than the current count of resources an account has.
At best you can inform admin that he is trying to set the resource limit to a
HI All,
How can we send dependent patches for review ?
E.g. If we have two bugs A and B and a patch is already sent for bug A for
review. Now I want to continue working on the patch for B which depends on the
code changes for A.
So if the patch for B is prepared before A gets into the repo,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6276/#review9681
---
1. Would it not be better to inform the admin of the current resource
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6229/
---
(Updated Aug. 1, 2012, 8:33 a.m.)
Review request for cloudstack and Abhinandan P
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6275/#review9678
---
Ship it!
Message correction looks fine! Please ship!
- Vijay Venkata
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6276/
---
Review request for cloudstack.
Description
---
If an account already has 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6275/
---
Review request for cloudstack, Murali Reddy and Pranav Saxena.
Description
-
99 matches
Mail list logo
