[Cmake-commits] CMake branch, next, updated. v3.6.0-rc3-590-gc664b95

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c664b95b08f793808d881ed08919bfa1a7fce409 commit c664b95b08f793808d881ed08919bfa1a7fce409 Merge: 0172bc1 f05f5b0 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Tue Jun 28 17:06:15 2016 -0400 Commit:

Re: [cmake-developers] Status of pre-compiled headers

On Mon, Jun 27, 2016 at 5:24 PM, Daniel Pfeifer <dan...@pfeifer-mail.de> wrote: > On Mon, Jun 27, 2016 at 5:09 PM, Brad King <brad.k...@kitware.com> wrote: >> On 06/24/2016 12:19 PM, Oleh Kravchenko wrote: >>> As far as I can see from issue tracker and the mail lis

Re: [cmake-developers] Status of pre-compiled headers

On Mon, Jun 27, 2016 at 5:09 PM, Brad King wrote: > On 06/24/2016 12:19 PM, Oleh Kravchenko wrote: >> As far as I can see from issue tracker and the mail list archives of >> "precompiled headers" feature we are still struggling for solution. >>

Re: [cmake-developers] libuv in cmake (was: daemon-mode meeting last Tuesday)

On Mon, Jun 27, 2016 at 5:02 PM, Brad King wrote: > On 06/24/2016 04:12 AM, Tobias Hunger wrote: >>> Please think about adding libuv earlier. As Brad wrote before, libuv >>> could replace some #ifdef code that we currently have >> >> Feel free to merge it at your own pace.

Re: [cmake-developers] daemon-mode meeting last Tuesday

On Fri, Jun 24, 2016 at 5:24 PM, Tobias Hunger <tobias.hun...@gmail.com> wrote: > Hi Daniel, > > On Fri, Jun 24, 2016 at 5:08 PM, Daniel Pfeifer <dan...@pfeifer-mail.de> > wrote: >>>> Currently cmake-gui supports switching generators, build trees, e

Re: [cmake-developers] daemon-mode meeting last Tuesday

On Fri, Jun 24, 2016 at 4:56 PM, Tobias Hunger wrote: > Hi Brad, > > On Thu, Jun 23, 2016 at 10:46 PM, Brad King wrote: >>> * This is currently used to set sourcedirectory, builddirectory and >>> generator. >>> >>> These three should be

Re: [cmake-developers] daemon-mode meeting last Tuesday

On Thu, Jun 23, 2016 at 2:27 PM, Tobias Hunger wrote: > * We both think it only makes sense to merge the infrastructure part into > cmake (if it passes review first of course) once we have some > functionality > that is genuinely useful. So we want to aim at having

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc3-525-g41a5113

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=41a51131f9a253459577cbe4562be5dd368a517d commit 41a51131f9a253459577cbe4562be5dd368a517d Merge: 272f159 8fd49ae Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Fri Jun 24 02:00:52 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc3-504-g622d3b3

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=622d3b3f10d01ba1ee8dd221ef45675761b9f8da commit 622d3b3f10d01ba1ee8dd221ef45675761b9f8da Merge: 6c354f7 69a6db4 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Thu Jun 23 01:16:00 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc3-502-g6c354f7

b0ec43081d commit 6c354f79f218d1115d8e3d7fb97f77b0ec43081d Merge: 224e195 4c9925b Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Wed Jun 22 19:06:15 2016 -0400 Commit: CMake Topic Stage <kwro...@kitware.com> CommitDate: Wed Jun 22 19:06:15 2016 -0400 Merge to

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-473-g8773905

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8773905db61f266558ec0c949e0e05e11b7dd496 commit 8773905db61f266558ec0c949e0e05e11b7dd496 Merge: 3ee00cc 8ddbd4c Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Mon Jun 20 17:23:50 2

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-397-g3817aa9

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3817aa9ae5796ac3cf971b843b85b5b2ee12d9d1 commit 3817aa9ae5796ac3cf971b843b85b5b2ee12d9d1 Merge: 94a1d96 64157fa Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Fri Jun 17 15:53:23 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-389-ge8815ce

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e8815ce7d7e0d22b759627bd5c97ee46b83d05dc commit e8815ce7d7e0d22b759627bd5c97ee46b83d05dc Merge: ef86b0e a1ae023 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Fri Jun 17 14:51:22 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-356-g85bdd35

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=85bdd3582b2a771107b1552c978aac50deff0868 commit 85bdd3582b2a771107b1552c978aac50deff0868 Merge: 7f71c4e e6326db Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Thu Jun 16 18:18:34 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-352-g6493db0

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6493db09edb969b292538b4011bd9075d956063d commit 6493db09edb969b292538b4011bd9075d956063d Merge: c3e9f73 a3e364a Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Thu Jun 16 14:57:04 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-315-g5ce786e

ns in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ce786e3d810391c2ed259e2ac0bad2d8ac5a9eb commit 5ce786e3d810391c2ed259e2ac0bad2d8ac5a9eb Merge: ff2a74b d645b03 Author: Daniel Pfeifer <dan...@pf

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-312-gff2a74b

g/gitweb?p=cmake.git;a=commitdiff;h=ff2a74b6fa5c9d13647e61cee90d0699661416c4 commit ff2a74b6fa5c9d13647e61cee90d0699661416c4 Merge: 6efb921 ed5fa48 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Tue Jun 14 17:32:06 2016 -0400 Commit: CMake Topic Stage <kwro...@kitware.com>

Re: [cmake-developers] Questions about coding conventions

On Tue, Jun 14, 2016 at 3:14 PM, Brad King wrote: > On 06/13/2016 10:16 AM, Brad King wrote: >>> Can't `std::ifstream` and `std::ofstream` be used directly? It seams >>> that kwsys does some workarounds >> >> Yes, std::{o,f}stream can be used directly. > > On second

[cmake-developers] fixup! Remove redundant arguments from fstream constructors

This is a fixup for the std-fstream topic. From 1d52cfe88e98738a1f1172cd1723a07ac579d2eb Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Tue, 14 Jun 2016 09:47:46 +0200 Subject: [PATCH] fixup! Remove redundant arguments from fstream constructors --- Tests/Alias

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-302-g41ecb26

e: c563a2b 5dee16e Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Mon Jun 13 17:05:24 2016 -0400 Commit: CMake Topic Stage <kwro...@kitware.com> CommitDate: Mon Jun 13 17:05:24 2016 -0400 Merge topic 'std-fstream' into next 5dee16ea Access std::

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc2-298-gc563a2b

g/gitweb?p=cmake.git;a=commitdiff;h=c563a2b5e188497f89af55d0bc758172c0505350 commit c563a2b5e188497f89af55d0bc758172c0505350 Merge: 86b38f8 6c1abff Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Mon Jun 13 16:48:55 2016 -0400 Commit: CMake Topic Stage <kwro...@kitware.com>

Re: [cmake-developers] Questions about coding conventions

On Mon, Jun 13, 2016 at 2:09 PM, Ben Boeckel <ben.boec...@kitware.com> wrote: > On Mon, Jun 13, 2016 at 00:03:29 +0200, Daniel Pfeifer wrote: >> Can you show an example? To be clear: We are looking for a function, >> that has a code path for `str == NULL` and a *different* c

Re: [cmake-developers] Questions about coding conventions

On Sun, Jun 12, 2016 at 4:26 PM, Ben Boeckel <ben.boec...@kitware.com> wrote: > On Fri, Jun 10, 2016 at 15:30:05 +0200, Daniel Pfeifer wrote: >> Passing and returning strings: We have `const char*`, `std::string`, >> and `std::string const&`. Unifying this can affect perfo

[cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use

Hi, now that we have integrated include-what-you-use, clang-tidy, and just recently also a mechanism for link-what-you-use, it is time we start eating our own dog food. https://en.wikipedia.org/wiki/Eating_your_own_dog_food I have set up a dashboard build where all three mechanisms are enabled:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc1-235-ged95d2c

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ed95d2c9aed1241d30c45a32fce775a8977cba77 commit ed95d2c9aed1241d30c45a32fce775a8977cba77 Merge: d6df33e 757b0ff Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Sat Jun 11 03:49:32 2016 -0400 Commit:

Re: [cmake-developers] Questions about coding conventions

On Fri, Jun 10, 2016 at 3:43 PM, Brad King <brad.k...@kitware.com> wrote: > On 06/10/2016 09:30 AM, Daniel Pfeifer wrote: >> By looking at the CMake source code, there are some inconsistencies >> regarding coding conventions. This is not a big problem and fixing >>

Re: [cmake-developers] Questions about coding conventions

On Fri, Jun 10, 2016 at 5:19 PM, Tobias Hunger <tobias.hun...@qt.io> wrote: > On Fr, 2016-06-10 at 16:34 +0200, Daniel Pfeifer wrote: >> If used consistently, it indicates that you are dealing with a member. >> I personally prefer `this->` over `m_`. With semantic sy

Re: [cmake-developers] Review request: extract-cmMessenger branch

On Fri, Jun 10, 2016 at 8:17 PM, Stephen Kelly wrote: > Tobias Hunger wrote: >> Forcing messages into one consistent format will be a pain, agreed, but >> continuing to add messages in whatever form the developer likes at the >> time of writing the code is even worse. CMake

Re: [cmake-developers] Questions about coding conventions

On Fri, Jun 10, 2016 at 4:16 PM, Tobias Hunger <tobias.hun...@qt.io> wrote: > On Fr, 2016-06-10 at 15:30 +0200, Daniel Pfeifer wrote: >> Naming conventions: Classes are named cmLikeThis. Member functions >> and member variables are named LikeThis. Local variables are named

[cmake-developers] Questions about coding conventions

Hi, By looking at the CMake source code, there are some inconsistencies regarding coding conventions. This is not a big problem and fixing them probably does not have a high priority. I would like to know what conventions to follow for new code. Formatting: No longer an issue. A .clang-format is

Re: [cmake-developers] Review request: extract-cmMessenger branch

On Thu, Jun 9, 2016 at 2:17 PM, Brad King wrote: > On 06/09/2016 05:06 AM, Tobias Hunger wrote: >> CMake Error at src/1/app/CMakeLists.txt:70 (add_custom_target): >> Cannot find source file: >> >> unknownFile.qml >> >> Tried extensions .c .C .c++ .cc .cpp .cxx .m .M

Re: [cmake-developers] Review request: extract-cmMessenger branch

On Thu, Jan 28, 2016 at 10:42 PM, Stephen Kelly wrote: > > Hi, > > I have pushed a extract-cmMessenger branch to my clone: > > https://github.com/steveire/CMake/commits/extract-cmMessenger I have rebased it to master and cherry-picked some minor changes. Once those minor

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc1-153-g7c99e0f

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7c99e0fa021fcade3968d3ab75fb0bff5b04d809 commit 7c99e0fa021fcade3968d3ab75fb0bff5b04d809 Merge: bcce79e 6692961 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Wed Jun 8 18:12:36 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc1-151-gbcce79e

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bcce79e9b7de4ae5fba7e7a1139586ccdf5c77e3 commit bcce79e9b7de4ae5fba7e7a1139586ccdf5c77e3 Merge: 03a75bf 1537d22 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Wed Jun 8 18:07:33 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc1-149-g03a75bf

g/gitweb?p=cmake.git;a=commitdiff;h=03a75bf379f0af616975da7421ea95ee669ee8b9 commit 03a75bf379f0af616975da7421ea95ee669ee8b9 Merge: 7e7dd8b 9f25fc4 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Wed Jun 8 17:17:09 2016 -0400 Commit: CMake Topic Stage <kwro...@kitware.com> Co

Re: [cmake-developers] CMake daemon-mode

On Mon, Jun 6, 2016 at 7:24 PM, Brad King wrote: > On 06/06/2016 11:39 AM, Tobias Hunger wrote: > >> A big chunk of Stephen's work has not even landed in my branch yet. Since >> cmake >> reformated all the source in the meantime it is a bit tedious to apply >> patches >>

Re: [cmake-developers] CMake daemon-mode

On Mon, Jun 6, 2016 at 5:39 PM, Tobias Hunger wrote: > Please help to support your use-cases. A while ago I wrote a graphical cache editor in GTK: https://github.com/purpleKarrot/cmake-gtk The tool reads the cache and provides a graphical view to modify it. It can then write

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc1-86-gad2630e

ns in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ad2630e2526f5761385bc1164b6919d2556a3be6 commit ad2630e2526f5761385bc1164b6919d2556a3be6 Merge: d05f196 fa277b2 Author: Daniel Pfeifer <dan...@pf

Re: [cmake-developers] Developer tasks - Refactoring

On Sun, Jun 5, 2016 at 2:15 PM, Stephen Kelly <steve...@gmail.com> wrote: > On 05/19/2016 11:27 PM, Daniel Pfeifer wrote: >> On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly <steve...@gmail.com> wrote: >>> 1) Make cmLocalGenerator not inherit cmOutputCon

[Cmake-commits] CMake branch, next, updated. v3.5.2-856-g92be372

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=92be3722167d1aafe48714a4ae114fbd4545270f commit 92be3722167d1aafe48714a4ae114fbd4545270f Merge: 7095d70 c6220de Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Thu Jun 2 15:36:51 2016 -0400 Commit:

Re: [cmake-developers] Some trivial patches

On Thu, Jun 2, 2016 at 11:15 AM, Tobias Hunger wrote: > On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote: >> On 06/01/2016 05:04 AM, Tobias Hunger wrote: >> > Attached you will find a couple of really small changes that add const to a >> > method and fix a couple of typos in

[cmake-developers] fixup! Simplify boolean expressions

My "Simplify boolean expressions" refactoring caused C4800 warnings for MSVC builds. A fixup is attached, as I cannot ssh at the moment. From ece15fe51c46cb93823ccd8a54243d35ebdc0d3c Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Thu, 2 Jun 201

[Cmake-commits] CMake branch, next, updated. v3.5.2-819-gddd74ff

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ddd74ff94ba85c04382f33e01915350d65464682 commit ddd74ff94ba85c04382f33e01915350d65464682 Merge: 9f6fe2f 9c77135 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Wed Jun 1 17:39:57 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.5.2-1600-g10c3943

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=10c39437bb51bae38c8c6b72b205fed81dfea561 commit 10c39437bb51bae38c8c6b72b205fed81dfea561 Merge: c731294 1b2bb93 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Thu May 26 16:54:09 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.5.2-1598-gc731294

ns in full, below. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c731294ce32e05fb4af93e18e4d7ed85bd105041 commit c731294ce32e05fb4af93e18e4d7ed85bd105041 Merge: df332cc 27ead96 Author: Daniel Pfeifer <dan...@pf

[Cmake-commits] CMake branch, next, updated. v3.5.2-1553-g0365580

751a9009b3 commit 03655800e9142fd2e0b8a1db025fb5751a9009b3 Merge: e35490d 5784747 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Tue May 24 17:31:33 2016 -0400 Commit: CMake Topic Stage <kwro...@kitware.com> CommitDate: Tue May 24 17:31:33 2016 -0400 Merge topic '

[Cmake-commits] CMake branch, next, updated. v3.5.2-1531-g43d02bf

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=43d02bf54b86076ffa4ad0bb30b087a51c0b860e commit 43d02bf54b86076ffa4ad0bb30b087a51c0b860e Merge: 201e524 b3f4057 Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Tue May 24 02:19:54 2016 -0400 Commit:

[Cmake-commits] CMake branch, next, updated. v3.5.2-1529-g201e524

ow. - Log - https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=201e5242dfc8e3dd1af8bb5ffca76a61226c9195 commit 201e5242dfc8e3dd1af8bb5ffca76a61226c9195 Merge: 75f46e9 b5b362e Author: Daniel Pfeifer <dan...@pfeifer-mail.de> AuthorDate: Mon May 23 15:04:38 2016 -0400 Commit:

Re: [cmake-developers] Developer tasks - Refactoring

On Thu, May 19, 2016 at 11:18 PM Daniel Pfeifer <dan...@pfeifer-mail.de> wrote: > On Wed, Feb 10, 2016 at 12:15 AM Stephen Kelly <steve...@gmail.com> wrote: > >> 1) Make cmLocalGenerator not inherit cmOutputConverter >> * Change enums like cmLocalGenerato

Re: [cmake-developers] Developer tasks - Refactoring

On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly wrote: > 1) Make cmLocalGenerator not inherit cmOutputConverter > * Change enums like cmLocalGenerator::START_OUTPUT with sed. See > >https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eac15298 > > for a similar sed

Re: [cmake-developers] Developer tasks - Refactoring

17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Thu, 19 May 2016 23:11:40 +0200 Subject: [PATCH] Use enums defined in cmOutputConverter using their fully qualified name. Mostly automated: values=("RelativeRoot" "NONE" "FULL" "HOME"

Re: [cmake-developers] [ANNOUNCE] CMake C++ coding style transition

On Thu, May 12, 2016 at 7:58 AM, Brad King wrote: > Hi Folks, > > As discussed previously on the developer list: > > Code style auto-formatting > http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/14969 > >

Re: [cmake-developers] Code style auto-formatting

On Mon, May 9, 2016 at 11:14 AM, Brad King wrote: > On 05/02/2016 10:08 AM, Brad King wrote: >> Next I'll look at the style updates themselves. > > I've made some more preparatory commits: > > Isolate formatted streaming blocks with clang-format off/on >

Re: [cmake-developers] Code style auto-formatting

On Mon, May 9, 2016 at 11:31 AM, Rolf Eike Beer wrote: > Am Montag, 9. Mai 2016, 13:14:17 schrieb Brad King: >> On 05/02/2016 10:08 AM, Brad King wrote: >> > Next I'll look at the style updates themselves. >> >> I've made some more preparatory commits: > > […] >> Remove

Re: [cmake-developers] Integration of clang-tidy

wrote: > On 04/27/2016 06:48 PM, Daniel Pfeifer wrote: >> It is unrelated. Clang-Tidy picks the interesting pieces from the >> compiler command line and ignores the rest. Whether cc is given or not >> makes no difference. >> But maybe we should leave the decision what

Re: [cmake-developers] Code style auto-formatting

ptions from the .clang-format files. IncludeCategories and Standard should stay as they are. cheers, Daniel From 452087a4b9f05742aed38040ab8d9b970fd05719 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Wed, 27 Apr 2016 22:47:02 +0200 Subject: [PATCH 1/3] CursesD

Re: [cmake-developers] Integration of clang-tidy

On Wed, Apr 27, 2016 at 3:10 PM, Brad King <brad.k...@kitware.com> wrote: > On 04/26/2016 05:32 PM, Daniel Pfeifer wrote: >> This is a follow up patch: > > Thanks. > >> -tidy_cmd.insert(tidy_cmd.end(), orig_cmd.begin()+1, orig_cmd.end()); >> +

Re: [cmake-developers] Integration of clang-tidy

On Wed, Apr 27, 2016 at 10:47 PM, Gregor Jasny <gja...@googlemail.com> wrote: > Hallo Daniel, > > On 09/04/16 00:31, Daniel Pfeifer wrote: >> I implemented the integration of `clang-tidy` along the lines of the >> `include-what-you-use` integration. >> There is a

Re: [cmake-developers] Integration of clang-tidy

On Mon, Apr 11, 2016 at 5:26 PM, Brad King <brad.k...@kitware.com> wrote: > On 04/08/2016 06:31 PM, Daniel Pfeifer wrote: >> I implemented the integration of `clang-tidy` along the lines of the >> `include-what-you-use` integration. >> There is a new `_

[cmake-developers] Integration of clang-tidy

output is recognized by CTest's diagnostic parser. I haven't checked how they look on CDash. cheers, Daniel From c1996b295d2e49134b6f5ef2be690588e5bf2732 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer <dan...@pfeifer-mail.de> Date: Fri, 8 Apr 2016 22:09:27 +0200 Subject: [PATCH] Provide

Re: [cmake-developers] more use of cmXMLWriter

On Mon, Mar 21, 2016 at 3:39 PM Brad King <brad.k...@kitware.com> wrote: > On 03/19/2016 05:08 PM, Daniel Pfeifer wrote: > > I ported some more generators to cmXMLWriter. > > Thanks. I've applied and merged to 'next' for testing: > > cmXMLWriter: overload Element(

Re: [cmake-developers] CMake daemon for user tools

On Wed, Jan 20, 2016 at 10:03 PM, Stephen Kelly wrote: > Milian Wolff wrote: > >>> I'm concerned that the memory usage of a daemon implementing the proposed >>> capabilities may be too large to be practical (at least without a major >>> redesign of certain structures that tend

Re: [cmake-developers] Profile Cmake scripts

>sys 0m20.268s > > Make generation: >real 4m45.089s >user 2m56.117s >sys 0m17.481s > > Ninja generation: > real 2m48.585s > user 2m30.712s > sys 0m6.313s Generators for Xcode and Visual Studio have to generate more files. From 46a5639a27bab0b227b4

Re: [cmake-developers] Restriction on target types for GraphViz dependency graph generation

On Wed, Dec 16, 2015 at 5:20 AM, Andrey Mishchenko wrote: > Hi, > > I noticed that the automatic dependency graph generation in CMake targeting > GraphViz only considers targets of certain types. In particular, it only > adds nodes for executables and shared, static, and

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

> On Friday, December 4, 2015, Daniel Pfeifer <dan...@pfeifer-mail.de> wrote: >> >> My working branch is here: >> https://github.com/purpleKarrot/CMake/commits/pch >> >> Feel free to comment, evaluate, contribute. >> >> I am nut fully dec

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

On Fri, Dec 4, 2015 at 9:19 PM, David Cole wrote: > Right, I was talking about the pch-binary. > > Why would CMake even need to generate a header file for pre-compiled > headers? Why not just allow the user to say which of his header files > should be the one to use for

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

On Fri, Dec 4, 2015 at 11:32 PM, David Cole wrote: > Makes sense. > > Can I inject my own "#include " into > the generated stream, or otherwise inject something into it? You should be able to do: target_include_directories(your_target PUBLIC public PRIVATE private )

Re: [cmake-developers] Code style auto-formatting

On Tue, Nov 17, 2015 at 10:12 PM, Robert Dailey wrote: > On Tue, Nov 17, 2015 at 6:57 AM, Paul Smith wrote: >> On Tue, 2015-11-17 at 08:14 +, Stuermer, Michael SP/HZA-ZSEP wrote: >>> In short, there is no fully automated style checking. If

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

en you are free to help with review, testing, and additional generators. Which generators are the most important for you? -- Daniel > Cheers, > Taylor > > On Fri, Mar 20, 2015 at 3:56 PM, Daniel Pfeifer <dan...@pfeifer-mail.de> > wrote: >> >> On Fri, Mar 20, 2015 at

Re: [cmake-developers] CTest XML outputs unsafe content

by cmXMLWriter, this may lead to some double encodings. I have attached two patches that remove all uses of cmXMLSafe from CTest. -- Daniel From 6a5962c671373f0c4e90080abc7b7fe7cf731f77 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer dan...@pfeifer-mail.de Date: Thu, 16 Jul 2015 21:47:29 +0200 Subject: [PATCH 01

[cmake-developers] [PATCH] fixup: CTest-side support for compiler version

Commit a5aa23 added support for reporting a compiler version to CDash (but with a hardcoded version number: the version of the compiler that was used to compile CMake). From 594c46c8f25e520d0fad984a4a00c228132cdea1 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer dan...@pfeifer-mail.de Date: Tue, 11

[cmake-developers] topic 'ctest-change-id'

Hi, The new element `ChangeId` is added to Build.xml and Test.xml. Did you consider adding it as an attribute in `cmCTest::StartXML` instead? That would make this (very useful) information available in all xml files. cheers, Daniel -- Powered by www.kitware.com Please keep messages on-topic

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

On Mon, Jul 6, 2015 at 8:41 PM, Brad King brad.k...@kitware.com wrote: On 07/04/2015 06:27 PM, Daniel Pfeifer wrote: Attached is a patch that adds a subcommand string(APPEND). This allows to write string(APPEND string_variable some string) instead of set(string_variable ${string_variable

Re: [cmake-developers] PATCH: add subcommand string(APPEND)

On Mon, Jul 6, 2015 at 10:55 PM, James Bigler jamesbig...@gmail.com wrote: list(APPEND) requires at least one element argument, right? No, see https://github.com/Kitware/CMake/blob/master/Source/cmListCommand.cxx#L236 -- Powered by www.kitware.com Please keep messages on-topic and check the

[cmake-developers] CTest: hide progress ticks in verbose output

the progress ticks when the output is shown (-VV). Cheers, Daniel From 31290dd36fff5fd88a66069d962a9e3c80746525 Mon Sep 17 00:00:00 2001 From: Daniel Pfeifer dan...@pfeifer-mail.de Date: Fri, 3 Jul 2015 22:52:23 +0200 Subject: [PATCH] CTest: hide progress ticks in verbose output --- Source/CTest

Re: [cmake-developers] A policy for Policies

On Sun, Jun 7, 2015 at 7:09 PM, Mike Gelfand mike...@mikedld.com wrote: On Sat, June 6, 2015 13:36, Stephen Kelly wrote: Code for Policies is also often complex. I often encounter Policies which are ancient and which get in the way of code clean up generally. Exactly the reason I don't

[cmake-developers] Composability of INTERFACE properties and custom targets

Hi, in a project, I have to generate some C++ header files at build time. Targets that use these header files need to know the directory of the generated files and depend on the custom target that in turn depends on the generated files. Example: target_include_directories(lib PRIVATE

[cmake-developers] cmXMLWriter

Hi, I wrote a simple XML writer (cmXMLWriter) that takes care of indentation, escaping, and balancing of end tags. I also ported all of CTest's XML generation to cmXMLWriter. https://github.com/purpleKarrot/CMake/commits/xmlwriter Please review and potentially apply. cheers, Daniel --

Re: [cmake-developers] Regarding the 'run-include-what-you-use' topic

On Wed, May 20, 2015 at 7:34 PM, Bill Hoffman bill.hoff...@kitware.com wrote: I looked quickly at the clang-tidy docs and it looks interesting. I see it is setup to use the compile_commands.json file. Originally we looked at running iwyu using that file. However, it became quickly evident

[cmake-developers] Regarding the 'run-include-what-you-use' topic

Hi Brad, Hi Bill, I think it is great that CMake gains support for IWYU. Without having tested it, I think the current implementation is compatible with other static analyzers like for examle clang-tidy. I think this is not good. If the options can be used for other tools than IWYU, the option

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

On Fri, Mar 20, 2015 at 6:35 PM, Amine Khaldi amine.kha...@reactos.org wrote: Two requests please: * The option to use existing headers instead of autogenerated ones. That is an implementation detail. It should not make a difference whether the precompiled header is used through your existing

Re: [cmake-developers] RFC: CMake precompiled header support and custom compiler based implementation

On Wed, Mar 4, 2015 at 8:53 PM, Brad King brad.k...@kitware.com wrote: On 03/03/2015 07:43 AM, Adam Strzelecki wrote: On 03/01/2015 08:02 PM, Ben Boeckel wrote: On 02/28/2015 11:59 AM, Adam Strzelecki wrote: target_precompiled_header(target path/to/precompiled_header.h)

[cmake-developers] Minimal compiler requirements for CMake itself

Hi, I would like to know what the oldest versions of GCC and Visual Studio are that should be able to compile the CMake source code. I was unable to find any information about that. I expected the oldest supported version of Visual Studio to be 6.0, but that one fails to build CMake. Don't get

Re: [cmake-developers] [CMake] target_include_directories target issue

FWD to developers list. I think this is a documentation issue. Luis Felipe Dominguez Vega lfdoming...@estudiantes.uci.cu schrieb am Mon Nov 17 2014 at 5:42:55 PM: I can't see into the source code of cmake, into the cmTargetIncludeDirectoriesCommand.cxx somethink like import the

Re: [cmake-developers] cmake-gui icons

2014-10-27 21:33 GMT+01:00 Ben Boeckel ben.boec...@kitware.com: On Mon, Oct 27, 2014 at 11:59:09 -0600, Orion Poplawski wrote: Trying to bring a bit more attention to this: Fedora is pushing to have higher resolution icons for the applications. There already is CMakeSetup128.png, but

Re: [cmake-developers] Modern cross-platform buildsystem design requirements

Hi Steve, 2014-09-10 0:32 GMT+02:00 Stephen Kelly steve...@gmail.com: I wonder what a cmake-based buildsystem would look like for a collection of executables/targets which should be built for multiple ... I would generalize even more and finish the sentence with options at once. This

Re: [cmake-developers] LZMA support

2014-07-30 15:58 GMT+02:00 Brad King brad.k...@kitware.com: On 07/23/2014 10:43 AM, Brad King wrote: I've merged the topic to 'next' for testing, but without the CPack or ExternalProject pieces. Likely some more portability fixes will be required after testing on the dashboard. Once that

[cmake-developers] LZMA support

Hi, In my liblzma branch (https://github.com/purpleKarrot/CMake/commits/liblzma), I did the following: * add the liblzma source from XZ Utils * make it compile with CMake (by adding CMakeLists.txt etc.) * make it compile in VC6 (by porting the source from C99 to C90) * make cmlibarchive use

Re: [cmake-developers] Optional dependencies in target INTERFACE

2014-06-30 10:18 GMT+02:00 Stephen Kelly steve...@gmail.com: Hello, QtSQL provides abstracted access to database data. It does not depend on QtGui or QtWidgets. It also provides the header-only qsqlrelationaldelegate.h. The contents of that header depend on QtWidgets, and are wrapped in

Re: [cmake-developers] Compiler features/extensions remaining/future issues

2014-06-15 22:24 GMT+02:00 Stephen Kelly steve...@gmail.com: Brad King wrote: On 06/13/2014 05:19 AM, Stephen Kelly wrote: 11) WriteCompilerDetectionHeader vs GenerateExportHeader IMO these two modules are solving orthogonal problems and should not be mixed. I'm not sure I agree.

Re: [cmake-developers] RFC: add version to project() call

2014/1/14 Brad King brad.k...@kitware.com: On 01/13/2014 01:38 PM, Alexander Neundorf wrote: does this require a policy now ? Somebody could set Foo_VERSION_MAJOR in the toplevel subdir, and have a project(Foo) call in a subdir, which would now unset Foo_VERSION_MAJOR. The same for

Re: [cmake-developers] RFC: add version to project() call

2014/1/14 Matthew Woehlke mw_tr...@users.sourceforge.net: On 2014-01-14 10:37, Brad King wrote: On 01/13/2014 01:38 PM, Alexander Neundorf wrote: does this require a policy now ? Somebody could set Foo_VERSION_MAJOR in the toplevel subdir, and have a project(Foo) call in a subdir, which

Re: [cmake-developers] Additional properties for PCH support

2013/11/26 Stephen Kelly steve...@gmail.com: Peter Kuemmel wrote: So, is this the right way to improve the pch situation? I don't know anything about PCH, but Daniel Pfeifer has a branch here: https://github.com/purpleKarrot/CMake/tree/WIP-PCH-Support Thanks for pointing at this branch. I

Re: [cmake-developers] Converting CMake documentation to reStructuredText and Sphinx

2013/10/11 Brad King brad.k...@kitware.com: On 10/11/2013 01:09 AM, Daniel Pfeifer wrote: Will it still be able to generate DocBook, so companies can include the documentation in their handbook? It can generate whatever Sphinx can generate. IIRC Sphinx does not currently support DocBook

[cmake-developers] (naming-)convention for ALIAS and INTERFACE targets

Hi Steve and all, we restarted the CMake-ification of molularized Boost with modern CMake features here: https://github.com/boost-cmake/boost-cmake We want to be able to build all Boost libraries together, but also each library on its own. Am I correct that in both cases we use the :: name in

Re: [cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013/9/3 Daniel Pfeifer dan...@pfeifer-mail.de: 2013/9/3 Brad King brad.k...@kitware.com: On 09/03/2013 03:39 AM, Daniel Pfeifer wrote: According to http://www.cmake.org/Bug/view.php?id=12930#c30721, WindowsAppContainer will not pass /ZW to the command line. Hence, setting VS_WINRT_EXTENSIONS

Re: [cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013/9/2 Brad King brad.k...@kitware.com: On 09/02/2013 11:42 AM, Daniel Pfeifer wrote: The target property VS_WINRT_EXTENSIONS is documented as: Can be set to enable C++/CX language extensions. Is that really what this property does? [snip] So my question again: Does VS_WINRT_EXTENSIONS

Re: [cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

2013/9/3 Brad King brad.k...@kitware.com: On 09/03/2013 03:39 AM, Daniel Pfeifer wrote: According to http://www.cmake.org/Bug/view.php?id=12930#c30721, WindowsAppContainer will not pass /ZW to the command line. Hence, setting VS_WINRT_EXTENSIONS will not enable C++/CX and the documentation

Re: [cmake-developers] INTERFACE_LIBRARY target type

4) The target_* commands always need to be invoked with an explicit INTERFACE option. Maybe PUBLIC should be allowed too (providing the same effect)? I don't really have a rationale. I just wrote PUBLIC a few times by accident. That might be a hint for a more intuitive interface. -- Powered

[cmake-developers] confusing documentation: VS_WINRT_EXTENSIONS

Hi, The target property VS_WINRT_EXTENSIONS is documented as: Can be set to enable C++/CX language extensions. Is that really what this property does? I am trying to build a C++ project (no C++/CX) for ARM with Visual Studio 2012. As an example, I took the following code:

<    1   2   3   >