On Monday 25 March 2013 13:14:33 Brad King wrote:
On 03/25/2013 12:28 PM, Matthew Woehlke wrote:
these must now be explicitly specified with INCLUDE_JARS. Other named
arguments are SOURCES (optional, to 'reset' to listing sources after
'INCLUDE_JARS'), OUTPUT_DIR, OUTPUT_NAME, VERSION and
On Tuesday 26 March 2013 10:33:03 Andreas Schneider wrote:
On Monday 25 March 2013 13:14:33 Brad King wrote:
On 03/25/2013 12:28 PM, Matthew Woehlke wrote:
these must now be explicitly specified with INCLUDE_JARS. Other named
arguments are SOURCES (optional, to 'reset' to listing sources
On 03/25/2013 05:20 PM, Matthew Woehlke wrote:
Actually, there is a fourth option: I could write a patch that ONLY adds
INCLUDE_JARS and doesn't touch the rest of the logic. This might be a
more reasonable avenue for adding jar dependency support without
changing the historic behavior.
On 2013-03-26 08:16, Brad King wrote:
On 03/25/2013 05:20 PM, Matthew Woehlke wrote:
Actually, there is a fourth option: I could write a patch that ONLY adds
INCLUDE_JARS and doesn't touch the rest of the logic. This might be a
more reasonable avenue for adding jar dependency support without
On 03/26/2013 12:25 PM, Matthew Woehlke wrote:
Done. Please note that I re-pushed the branch such that the end result
is the same, but it is now broken into two commits, the first one adding
just INCLUDE_JARS. So presumably only the first commit is wanted, and
the second can be left along
Brad King wrote:
@@ -190,6 +198,8 @@
# (To distribute this file outside of CMake, substitute the full
# License text for the above reference.)
+include(CMakeParseArguments)
+
function (__java_copy_file src dest comment)
add_custom_command(
OUTPUT ${dest}
This should
On 2013-03-26 13:05, Rolf Eike Beer wrote:
Brad King wrote:
@@ -190,6 +198,8 @@
# (To distribute this file outside of CMake, substitute the full
# License text for the above reference.)
+include(CMakeParseArguments)
+
function (__java_copy_file src dest comment)
On 03/26/2013 01:35 PM, Matthew Woehlke wrote:
This should probably be
include(${CMAKE_CURRENT_LIST_DIR}/CMakeParseArguments.cmake)
...or 'include(${CMAKE_ROOT}/Modules/CMakeParseArguments.cmake)'?
*Most* of the find modules appear to use CMAKE_CURRENT_LIST_DIR, but
there are some (not
I have pushed a branch (use-java-use-parse-arguments) to stage that
converts add_jar to using cmake_parse_arguments. This partly revers the
previous change to accept jars and jar targets as sources for 'linking';
these must now be explicitly specified with INCLUDE_JARS. Other named
arguments
On 03/25/2013 12:28 PM, Matthew Woehlke wrote:
these must now be explicitly specified with INCLUDE_JARS. Other named
arguments are SOURCES (optional, to 'reset' to listing sources after
'INCLUDE_JARS'), OUTPUT_DIR, OUTPUT_NAME, VERSION and ENTRY_POINT. These
supersede the old variables,
On 2013-03-25 13:14, Brad King wrote:
On 03/25/2013 12:28 PM, Matthew Woehlke wrote:
I'm on the fence if this should target 2.8.11. On the plus side, it
means the historic behavior of ignoring jar files listed as sources will
be preserved. On the down side, it is late in the cycle and this is a
On 03/25/2013 01:46 PM, Matthew Woehlke wrote:
As is:
- Pros: add_jar accepts jars as it was apparently intended to, as
'source' arguments
- Cons: maybe not optimal interface, must support this going forward
Even after the proposed interface goes in we will still have to
support the
On 2013-03-25 14:07, Brad King wrote:
On 03/25/2013 01:46 PM, Matthew Woehlke wrote:
As is:
- Pros: add_jar accepts jars as it was apparently intended to, as
'source' arguments
- Cons: maybe not optimal interface, must support this going forward
Even after the proposed interface goes in we
13 matches
Mail list logo
