eladkal commented on PR #36017:
URL: https://github.com/apache/airflow/pull/36017#issuecomment-1837095465
> add min_airflow_version = 2.7.1 for cohere provider - seems that importlib
limitation in airflow (<5) is incompatible with cohere's (>=6) - and it was
only removed in 2.7.1 (https://g
yiqijiu commented on issue #35979:
URL: https://github.com/apache/airflow/issues/35979#issuecomment-1837105736
I need you to provide the complete DAG (Directed Acyclic Graph) code. Given
my past experience (which could be wrong here), you probably haven't added
UTF-8 encoding declaration in
potiuk commented on PR #36011:
URL: https://github.com/apache/airflow/pull/36011#issuecomment-1837109759
I added a bit more complete solution - including docker-in-docker we use in
our tests. That should cover all kinds of use cases - it got really complicated
with rootless docker, MacOS De
potiuk commented on PR #36017:
URL: https://github.com/apache/airflow/pull/36017#issuecomment-1837110662
> I think the PR you linked is wrong? Why do you claim that cohere provider
needs Airflow>=2.7.1? I don't see anything binding that provider to newer core
versions (unlike `common.fs
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412777390
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last ve
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412777390
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last ve
hussein-awala commented on PR #36000:
URL: https://github.com/apache/airflow/pull/36000#issuecomment-1837113368
> We should only allow fixed set of placeholders - not a "Free placeholder"
= only alow "%s" or "?" - nothing else.
>
> The problem with such an input provided by the user w
potiuk merged PR #36011:
URL: https://github.com/apache/airflow/pull/36011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412785049
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only la
potiuk commented on PR #36000:
URL: https://github.com/apache/airflow/pull/36000#issuecomment-1837124823
> Makes sense! We can achieve this easily by adding a list of whitelisted
placeholders in each provider, and checking if the provided placeholder exists
in this list.
Yes. Easy to
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837125248
> I am not so sure why this is happening. Any idea?
Becaasue we also need to import in the method where we use it (locally).
--
This is an automated message from the Apache Git S
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1412785989
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && ta
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837126097
> > I am not so sure why this is happening. Any idea?
>
> Becaasue we also need to import in the method where we use it (locally).
Thank you for the hint. Working on it
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1412787254
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
potiuk opened a new pull request, #36022:
URL: https://github.com/apache/airflow/pull/36022
This change codifies and explains assumptions and decisions made by Airflow
maintainers with regards to capabilities of DAG Authors.
While DAG authors are pretty powerful and capable actors in
hussein-awala commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1412794481
##
docs/apache-airflow/security/security_model.rst:
##
@@ -97,10 +97,74 @@ capabilities authenticated users may have:
For more information on the capabilitie
potiuk commented on PR #35210:
URL: https://github.com/apache/airflow/pull/35210#issuecomment-1837140121
Hey @hussein-awala @jscheffl -> I've proposed
https://github.com/apache/airflow/pull/36022 (subject to feedback and
discussion - describing the way I understand the current model of DAG
potiuk commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1412794928
##
docs/apache-airflow/security/security_model.rst:
##
@@ -97,10 +97,74 @@ capabilities authenticated users may have:
For more information on the capabilities of au
potiuk commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1412794928
##
docs/apache-airflow/security/security_model.rst:
##
@@ -97,10 +97,74 @@ capabilities authenticated users may have:
For more information on the capabilities of au
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412795261
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last ve
potiuk opened a new pull request, #36023:
URL: https://github.com/apache/airflow/pull/36023
Our security policy was quite a bit too long and to unstructured to provide
good guideline for the Security Reporters. It was basically a wall of text
where - even if you wanted - you could not easil
pankajkoti commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1412798224
##
docs/apache-airflow/security/security_model.rst:
##
@@ -97,10 +97,74 @@ capabilities authenticated users may have:
For more information on the capabilities o
pankajkoti commented on code in PR #36023:
URL: https://github.com/apache/airflow/pull/36023#discussion_r1412801677
##
.pre-commit-config.yaml:
##
@@ -33,7 +33,7 @@ repos:
- id: doctoc
name: Add TOC for Markdown and RST files
files:
-
^CONTRIBU
potiuk commented on code in PR #36022:
URL: https://github.com/apache/airflow/pull/36022#discussion_r1412807320
##
docs/apache-airflow/security/security_model.rst:
##
@@ -97,10 +97,74 @@ capabilities authenticated users may have:
For more information on the capabilities of au
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412807489
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only la
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837160279
> the `subprocess.run` should be replaced with `run_command` from utils
Somehow I forgot to push the commit :/
Pushed the latest changes now. Should be ok
--
This is
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809042
##
dev/breeze/src/airflow_breeze/utils/common_options.py:
##
@@ -557,6 +557,13 @@ def _set_default_from_parent(ctx: click.core.Context,
option: click.core.Option,
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809252
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references(site
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809497
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references(site
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837164035
Few nits regaring usability/parameters color-coding communication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809587
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references(site
pateash commented on issue #35911:
URL: https://github.com/apache/airflow/issues/35911#issuecomment-1837166929
Currently it's possible to set this option inside Spark connection, but we
should have the ability to override it if needed using operator arguments.
https://github.com/apache/ai
syun64 opened a new pull request, #36024:
URL: https://github.com/apache/airflow/pull/36024
closes #32816
### Summary
This PR introduces Dag SLAs as a part of **AIP-57 Refactor SLA Feature**.
After many discussions, the community has voted to introduce new
syun64 commented on PR #33532:
URL: https://github.com/apache/airflow/pull/33532#issuecomment-1837185098
This PR was based on an old branch, and got into a messy state after many
iterations of rebasing. Closed in favor of
https://github.com/apache/airflow/pull/36024
--
This is an automat
syun64 closed pull request #33532: [Draft] Implement Dag SLAs
URL: https://github.com/apache/airflow/pull/33532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tirkarthi opened a new pull request, #36025:
URL: https://github.com/apache/airflow/pull/36025
Use dropdown instead of button to select log attempt when there are more
than 10 retries.
Less than 10 retries
![image](https://github.com/apache/airflow/assets/3972343/8242f9d3-fe58
jscheffl opened a new pull request, #36026:
URL: https://github.com/apache/airflow/pull/36026
This PR changes the web UI trigger form to be shown always when calling via
GET. Before it was possible to "accidentally" make a trigger when no form
parameters were specified in a DAG and you pass
eladkal commented on PR #36017:
URL: https://github.com/apache/airflow/pull/36017#issuecomment-1837206336
FYI @kaxil @ephraimbuddy @utkarsharma2
`ERROR: Cannot install apache-airflow-providers-cohere,
apache-airflow==2.6.1 and cohere==4.37 because these package versions have
conflict
eladkal commented on issue #35974:
URL: https://github.com/apache/airflow/issues/35974#issuecomment-1837210762
trigger rules check only **direct** upstream. Task `f` trigger rule will not
check tasks `c, b`
--
This is an automated message from the Apache Git Service.
To respond to the mes
jscheffl commented on code in PR #36025:
URL: https://github.com/apache/airflow/pull/36025#discussion_r1412846228
##
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##
@@ -193,24 +197,44 @@ const Logs = ({
{tryNumber !== undefined && (
<>
syun64 commented on code in PR #36024:
URL: https://github.com/apache/airflow/pull/36024#discussion_r1412846622
##
tests/ti_deps/deps/test_not_previously_skipped_dep.py:
##
@@ -113,7 +113,7 @@ def test_parent_skip_branch(session, dag_maker):
"""
A simple DAG with a Bra
eladkal commented on PR #36017:
URL: https://github.com/apache/airflow/pull/36017#issuecomment-1837215881
> The cohere provider can't work with Airflow 2.6 unless using Python 3.9
due to version of importlib
OK thanks to @potiuk we may have workaround for this
https://github.c
potiuk opened a new pull request, #36027:
URL: https://github.com/apache/airflow/pull/36027
Pipx 1.3.0 has a bug https://github.com/pypa/pipx/issues/1122 that makes our
CI fail. Temporary limiting the version until the issue is fixed should
mitigate the problem
potiuk commented on PR #36027:
URL: https://github.com/apache/airflow/pull/36027#issuecomment-1837217917
I need to merge it to main to be effective - so this one won't succeed. but
it works and nicely limites `pipx` and installs breeze.
--
This is an automated message from the Apache Git
potiuk merged PR #36027:
URL: https://github.com/apache/airflow/pull/36027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 7f049aa868 Temporary limit pipx to let our CI work
eladkal commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1412851278
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
eladkal commented on issue #35911:
URL: https://github.com/apache/airflow/issues/35911#issuecomment-1837226981
> Currently it's possible to set this option inside Spark connection, but we
should have the ability to override it if needed using operator arguments.
So do we have a task t
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837228436
Thank you. I am making the usability improvements now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412853907
##
dev/breeze/src/airflow_breeze/utils/common_options.py:
##
@@ -557,6 +557,13 @@ def _set_default_from_parent(ctx: click.core.Context,
option: click.core.Option
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412854219
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412854334
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837229473
@potiuk just pushed a fix adding your comments. Compiles fine 👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
tirkarthi commented on code in PR #36025:
URL: https://github.com/apache/airflow/pull/36025#discussion_r1412854868
##
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##
@@ -193,24 +197,44 @@ const Logs = ({
{tryNumber !== undefined && (
<>
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837243001
ALMOST :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
avkirilishin opened a new pull request, #36028:
URL: https://github.com/apache/airflow/pull/36028
closes: https://github.com/apache/airflow/issues/35288
before:
https://github.com/apache/airflow/assets/54231417/a319a68a-3f35-492b-b6c4-736e37acde6c";>
after: redirect to the ho
hussein-awala opened a new pull request, #36029:
URL: https://github.com/apache/airflow/pull/36029
related: #35210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
jscheffl merged PR #36026:
URL: https://github.com/apache/airflow/pull/36026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
This is an automated email from the ASF dual-hosted git repository.
jscheffl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f5d802791f Change Trigger UI to use HTTP POST in
github-actions[bot] closed pull request #34898: Update dags.rst
URL: https://github.com/apache/airflow/pull/34898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
github-actions[bot] closed pull request #34896: Adding payload arg as a
templated field for Synapse SparkBatchOperator
URL: https://github.com/apache/airflow/pull/34896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] closed pull request #34700: Add `deferred_as_active` param
to consider deferred state as an active state
URL: https://github.com/apache/airflow/pull/34700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
github-actions[bot] commented on PR #34379:
URL: https://github.com/apache/airflow/pull/34379#issuecomment-1837287936
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #34121:
URL: https://github.com/apache/airflow/pull/34121#issuecomment-1837287948
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #33930:
URL: https://github.com/apache/airflow/pull/33930#issuecomment-1837287955
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
potiuk merged PR #35970:
URL: https://github.com/apache/airflow/pull/35970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 9c168b76e8 New breeze command to clean up previous
potiuk merged PR #36025:
URL: https://github.com/apache/airflow/pull/36025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk closed issue #35889: New logs tab is broken for tasks with high retries
URL: https://github.com/apache/airflow/issues/35889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 9c168b76e8 New breeze command to clean up previous provider artifacts
(#35970)
add fd0988369b Use dropdown instea
potiuk merged PR #36028:
URL: https://github.com/apache/airflow/pull/36028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk closed issue #34058: UI Grid error when DAG has been removed
URL: https://github.com/apache/airflow/issues/34058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 549fac30ee 34058: Fix UI Grid error when DAG has be
zhangw commented on issue #35998:
URL: https://github.com/apache/airflow/issues/35998#issuecomment-1837308308
> Don't use `days_ago`. It's a bad practice from Airlow 1.10 which we since
fixed in all (I believe) our examples and documentations. `days_ago`
effectively calculates new start_dat
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 6fb3bd0c97 Updating con
uranusjr commented on PR #35887:
URL: https://github.com/apache/airflow/pull/35887#issuecomment-1837326874
I did some additional debugging and it seems like the root issue is croniter
does not take account `fold` (or Pendulum’s transition rule, they’re
fundamentally the same thing) correctl
uranusjr commented on PR #30083:
URL: https://github.com/apache/airflow/pull/30083#issuecomment-1837327166
I posted some details in #35887. Unfortunately I don’t think it is
technically possible to fix this in Airflow.
--
This is an automated message from the Apache Git Service.
To respon
uranusjr commented on PR #35887:
URL: https://github.com/apache/airflow/pull/35887#issuecomment-1837328505
A minor plus is I found a bug in CPython while debugging this.
https://github.com/python/cpython/issues/112638
--
This is an automated message from the Apache Git Service.
To respond
eladkal commented on code in PR #36029:
URL: https://github.com/apache/airflow/pull/36029#discussion_r1413006394
##
airflow/migrations/versions/0132_2_8_0_add_priority_weight_strategy_to_task_.py:
##
@@ -37,9 +37,18 @@
def upgrade():
+json_type = sa.JSON
+conn = op.
pankajkoti commented on code in PR #36014:
URL: https://github.com/apache/airflow/pull/36014#discussion_r1413018967
##
tests/providers/openai/hooks/test_openai.py:
##
@@ -16,48 +16,58 @@
# under the License.
from __future__ import annotations
-from unittest.mock import Mock,
pankajkoti commented on code in PR #35919:
URL: https://github.com/apache/airflow/pull/35919#discussion_r1413019398
##
airflow/providers/weaviate/hooks/weaviate.py:
##
@@ -112,22 +117,170 @@ def test_connection(self) -> tuple[bool, str]:
self.log.error("Error testin
81 matches
Mail list logo
