Re: [I] Status of testing Providers that were prepared on May 12, 2024 [airflow]

2024-05-13 Thread via GitHub
e-galan commented on issue #39578: URL: https://github.com/apache/airflow/issues/39578#issuecomment-2109406571 #39018 and #37693 work as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Determine needs_expansion at time of serialization [airflow]

2024-05-13 Thread via GitHub
dstandish opened a new pull request, #39604: URL: https://github.com/apache/airflow/pull/39604 This way we do not necessarily need to also pass the dag and do the evaluation on the server side. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on PR #39592: URL: https://github.com/apache/airflow/pull/39592#issuecomment-2109333423 > This is an awesome PR! Super thorough and ticks all the boxes. We'll use this as an example for future folks, great work! 😃 Thank you so much for reviewing this 😄 , Applie

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599409573 ## tests/system/providers/amazon/aws/example_comprehend.py: ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599409105 ## tests/providers/amazon/aws/operators/test_comprehend.py: ## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599408724 ## airflow/providers/amazon/aws/operators/comprehend.py: ## @@ -0,0 +1,195 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599402592 ## airflow/providers/amazon/aws/operators/comprehend.py: ## @@ -0,0 +1,195 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599399872 ## airflow/providers/amazon/aws/operators/comprehend.py: ## @@ -0,0 +1,195 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] Add indexes on dag_id column in refencing tables to speed up deletion of dag records [airflow]

2024-05-13 Thread via GitHub
uranusjr commented on code in PR #39526: URL: https://github.com/apache/airflow/pull/39526#discussion_r1599395810 ## airflow/migrations/versions/0143_2_9_2_add_index_on_dag_id_in_referencing_tables.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) un

(airflow) branch main updated (975337a50a -> 05b6b741cb)

2024-05-13 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 975337a50a Skip get_current_task_instance_session if use_internal_api (#39595) add 05b6b741cb Use TracebackSes

Re: [PR] Use TracebackSession when internal API configured and getting current session [airflow]

2024-05-13 Thread via GitHub
dstandish merged PR #39600: URL: https://github.com/apache/airflow/pull/39600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[PR] Fixed issue of new dag getting old dataset events. [airflow]

2024-05-13 Thread via GitHub
tosheer opened a new pull request, #39603: URL: https://github.com/apache/airflow/pull/39603 If a new dataset triggreed DAG is created for an already existing dataset. (Dataset has already existing dataset events) DAG see all dataset events from very first event for dataset. -- This is a

Re: [PR] Fixed issue of new dag getting old dataset events. [airflow]

2024-05-13 Thread via GitHub
boring-cyborg[bot] commented on PR #39603: URL: https://github.com/apache/airflow/pull/39603#issuecomment-2109292111 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

Re: [I] XComObjectStorageBackend returns the S3 path during deserialization instead of the data [airflow]

2024-05-13 Thread via GitHub
boring-cyborg[bot] commented on issue #39602: URL: https://github.com/apache/airflow/issues/39602#issuecomment-2109288119 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] XComObjectStorageBackend returns the S3 path during deserialization instead of the data [airflow]

2024-05-13 Thread via GitHub
Uture opened a new issue, #39602: URL: https://github.com/apache/airflow/issues/39602 ### Apache Airflow version 2.9.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? After configuring the object storage as XCom backend

Re: [I] Airflow DAG Task Exits with Return Code 1 [airflow]

2024-05-13 Thread via GitHub
boring-cyborg[bot] commented on issue #39601: URL: https://github.com/apache/airflow/issues/39601#issuecomment-2109280337 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Airflow DAG Task Exits with Return Code 1 [airflow]

2024-05-13 Thread via GitHub
dineshkumar20 opened a new issue, #39601: URL: https://github.com/apache/airflow/issues/39601 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.8.4 ### What happened? ```py #t

Re: [I] Making `mssql` provider to support only `mssql+pymssql` dialect [airflow]

2024-05-13 Thread via GitHub
rawwar commented on issue #39586: URL: https://github.com/apache/airflow/issues/39586#issuecomment-2109259439 @Taragolis , requesting your comments on this. I was working on updating `mssql` provider to use `sqlalchemy_url` property in `get_uri` and got the idea for this issue. --

Re: [PR] add missing conn_id to string representation of ObjectStoragePath [airflow]

2024-05-13 Thread via GitHub
eladkal commented on PR #39313: URL: https://github.com/apache/airflow/pull/39313#issuecomment-2109243198 > Hello @eladkal 🙂 > > Very sorry for the late poke about this but is there a chance to include a 1.3.2 release of the common io provider with this bugfix in the current wave of

[PR] Use TracebackSession when internal API configured and getting current session [airflow]

2024-05-13 Thread via GitHub
dstandish opened a new pull request, #39600: URL: https://github.com/apache/airflow/pull/39600 We shouldn't use this session; this class will tell you where it came from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(airflow) branch main updated: Skip get_current_task_instance_session if use_internal_api (#39595)

2024-05-13 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 975337a50a Skip get_current_task_instance_sessio

Re: [PR] Skip get_current_task_instance_session if use_internal_api [airflow]

2024-05-13 Thread via GitHub
dstandish merged PR #39595: URL: https://github.com/apache/airflow/pull/39595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Fix stacklevel for _log_state helper (#39596)

2024-05-13 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6b2839942b Fix stacklevel for _log_state helper (

Re: [PR] Fix stacklevel for _log_state helper [airflow]

2024-05-13 Thread via GitHub
uranusjr merged PR #39596: URL: https://github.com/apache/airflow/pull/39596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Resolve deprecation warnings in Azure FileShare-to-GCS tests [airflow]

2024-05-13 Thread via GitHub
josh-fell commented on code in PR #39599: URL: https://github.com/apache/airflow/pull/39599#discussion_r1599332161 ## airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py: ## @@ -63,13 +65,14 @@ class AzureFileShareToGCSOperator(BaseOperator): Service Acco

Re: [PR] Resolve deprecation warnings in Azure FileShare-to-GCS tests [airflow]

2024-05-13 Thread via GitHub
josh-fell commented on code in PR #39599: URL: https://github.com/apache/airflow/pull/39599#discussion_r1599328193 ## airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py: ## @@ -94,8 +97,8 @@ def __init__( self.share_name = share_name self.direct

Re: [PR] Resolve deprecation warnings in Azure FileShare-to-GCS tests [airflow]

2024-05-13 Thread via GitHub
josh-fell commented on code in PR #39599: URL: https://github.com/apache/airflow/pull/39599#discussion_r1599327703 ## airflow/providers/google/cloud/transfers/azure_fileshare_to_gcs.py: ## @@ -63,13 +65,14 @@ class AzureFileShareToGCSOperator(BaseOperator): Service Acco

[PR] Resolve deprecation warnings in Azure FileShare-to-GCS tests [airflow]

2024-05-13 Thread via GitHub
josh-fell opened a new pull request, #39599: URL: https://github.com/apache/airflow/pull/39599 Related: #39485 AzureFileShareToGCSOperator has a deprecated parameter, `directory_name`, which was replaced by `directory_path`. This PR updates system and unit tests as well as operator d

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1599301829 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [I] Scheduler fails to schedule DagRuns due to persistent DAG record lock [airflow]

2024-05-13 Thread via GitHub
Kenny1217 commented on issue #36920: URL: https://github.com/apache/airflow/issues/36920#issuecomment-2109162541 We were having the issue with Airflow 2.8.3 but ever since we upgraded to Airflow to 2.9.0 we haven't seen the issue again. This could be just luck since it only happens randomly

Re: [PR] add missing conn_id to string representation of ObjectStoragePath [airflow]

2024-05-13 Thread via GitHub
Lee-W commented on PR #39313: URL: https://github.com/apache/airflow/pull/39313#issuecomment-2109151480 > Hello @eladkal 🙂 > > Very sorry for the late poke about this but is there a chance to include a 1.3.2 release of the common io provider with this bugfix in the current wave of re

Re: [PR] Fix typo in Auth Manager docs [airflow]

2024-05-13 Thread via GitHub
josh-fell commented on PR #39598: URL: https://github.com/apache/airflow/pull/39598#issuecomment-2109151338 Congrats on your first PR 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Fix typo in Auth Manager docs [airflow]

2024-05-13 Thread via GitHub
boring-cyborg[bot] commented on PR #39598: URL: https://github.com/apache/airflow/pull/39598#issuecomment-2109145848 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated: Fix typo in Auth Manager docs (#39598)

2024-05-13 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ba94328857 Fix typo in Auth Manager docs (#39598)

Re: [PR] Fix typo in Auth Manager docs [airflow]

2024-05-13 Thread via GitHub
josh-fell merged PR #39598: URL: https://github.com/apache/airflow/pull/39598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Update example AzureContainerInstancesOperator (#39466)

2024-05-13 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ecf6e57e27 Update example AzureContainerInstances

Re: [PR] Update example AzureContainerInstancesOperator [airflow]

2024-05-13 Thread via GitHub
josh-fell merged PR #39466: URL: https://github.com/apache/airflow/pull/39466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Improve logging readability with DockerOperator [airflow]

2024-05-13 Thread via GitHub
github-actions[bot] closed pull request #38008: Improve logging readability with DockerOperator URL: https://github.com/apache/airflow/pull/38008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] sla_miss_callback is not working with 5 input parameters as official document, only dag_id 1 input is allowed, no enough context for alert [airflow]

2024-05-13 Thread via GitHub
github-actions[bot] commented on issue #38931: URL: https://github.com/apache/airflow/issues/38931#issuecomment-2109035884 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

Re: [I] Dynamic mapped tasks group arguments are interpreted as MappedArgument when provided to classic operators [airflow]

2024-05-13 Thread via GitHub
joshtree41 commented on issue #39222: URL: https://github.com/apache/airflow/issues/39222#issuecomment-2109022868 Noticing this issue as well, tested a task group with task flow API and the arguments get picked up properly, but when passed to traditional operators they don't get picked up p

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
o-nikolas commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599187322 ## airflow/providers/amazon/aws/operators/comprehend.py: ## @@ -0,0 +1,195 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor l

Re: [PR] Fix typo in Auth Manager docs [airflow]

2024-05-13 Thread via GitHub
boring-cyborg[bot] commented on PR #39598: URL: https://github.com/apache/airflow/pull/39598#issuecomment-2108968633 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Fix typo in Auth Manager docs [airflow]

2024-05-13 Thread via GitHub
tomakita opened a new pull request, #39598: URL: https://github.com/apache/airflow/pull/39598 Fixed a minor typo in the `apache-airflow` docs for Auth Managers. This is my first commit -- let me know if I did something wrong, and I'll fix it ASAP :) --- **^ Add

(airflow) branch main updated: Fix spelling satiny -> sanity (#39594)

2024-05-13 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4a59276187 Fix spelling satiny -> sanity (#3

Re: [PR] Fix spelling satiny -> sanity [airflow]

2024-05-13 Thread via GitHub
jedcunningham merged PR #39594: URL: https://github.com/apache/airflow/pull/39594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[PR] Fix stacklevel for _log_state helper [airflow]

2024-05-13 Thread via GitHub
dstandish opened a new pull request, #39596: URL: https://github.com/apache/airflow/pull/39596 This is necessary to show what line the helper was invoked from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(airflow) branch main updated: Remove compat code for 2.7.0 - its now the min Airflow version (#39591)

2024-05-13 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e3897dcbed Remove compat code for 2.7.0 - it

Re: [PR] Remove compat code for 2.7.0 - its now the min Airflow version [airflow]

2024-05-13 Thread via GitHub
jedcunningham merged PR #39591: URL: https://github.com/apache/airflow/pull/39591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[PR] Skip get_current_task_instance_session if use_internal_api [airflow]

2024-05-13 Thread via GitHub
dstandish opened a new pull request, #39595: URL: https://github.com/apache/airflow/pull/39595 We don't need a session when configured to use the internal API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] Fix spelling satiny -> sanity [airflow]

2024-05-13 Thread via GitHub
dstandish opened a new pull request, #39594: URL: https://github.com/apache/airflow/pull/39594 That is all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Handle task adoption for batch executor [airflow]

2024-05-13 Thread via GitHub
hussein-awala commented on code in PR #39590: URL: https://github.com/apache/airflow/pull/39590#discussion_r1599119239 ## airflow/providers/amazon/aws/executors/batch/batch_executor.py: ## @@ -306,14 +307,22 @@ def attempt_submit_jobs(self): self.pending_job

Re: [PR] Allow FTPHook to change port number [airflow]

2024-05-13 Thread via GitHub
vincbeck commented on code in PR #39465: URL: https://github.com/apache/airflow/pull/39465#discussion_r1599058827 ## airflow/providers/ftp/hooks/ftp.py: ## @@ -58,7 +58,11 @@ def get_conn(self) -> ftplib.FTP: if self.conn is None: params = self.get_connecti

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599023840 ## tests/system/providers/amazon/aws/example_comprehend.py: ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [I] Status of testing Providers that were prepared on May 12, 2024 [airflow]

2024-05-13 Thread via GitHub
dondaum commented on issue #39578: URL: https://github.com/apache/airflow/issues/39578#issuecomment-2108697474 #38961 is good ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
vincbeck commented on code in PR #39592: URL: https://github.com/apache/airflow/pull/39592#discussion_r1599010536 ## tests/system/providers/amazon/aws/example_comprehend.py: ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Chart: Allow AWS ECS Executor [airflow]

2024-05-13 Thread via GitHub
jedcunningham commented on PR #38524: URL: https://github.com/apache/airflow/pull/38524#issuecomment-2108682949 For rbac I think thinking of [this](https://github.com/apache/airflow/blob/ce4e8477f1972400dda228f802e8f501de5dbe49/chart/templates/rbac/pod-launcher-rolebinding.yaml#L24-L25), bu

[PR] Introduce Amazon Comprehend Service [airflow]

2024-05-13 Thread via GitHub
gopidesupavan opened a new pull request, #39592: URL: https://github.com/apache/airflow/pull/39592 Added Amazon Comprehend Start Pii Entities Detection Job Operator Doc, Hook, Operator, Sensor, Trigger, Waiter, Unit Test, System Test. At present it supports only Pii

[PR] Remove compat code for 2.7.0 - its now the min Airflow version [airflow]

2024-05-13 Thread via GitHub
jedcunningham opened a new pull request, #39591: URL: https://github.com/apache/airflow/pull/39591 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] AIP-61 - Support task adoption for hybrid executors [airflow]

2024-05-13 Thread via GitHub
o-nikolas merged PR #39531: URL: https://github.com/apache/airflow/pull/39531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Task adoption for hybrid executors (#39531)

2024-05-13 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3e229d8df5 Task adoption for hybrid executors (#3

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
o-nikolas commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598853590 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) #

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598842673 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Move Kubernetes cli to provider package [airflow]

2024-05-13 Thread via GitHub
shahar1 commented on code in PR #39587: URL: https://github.com/apache/airflow/pull/39587#discussion_r1598825622 ## airflow/cli/commands/kubernetes_command.py: ## @@ -36,6 +37,12 @@ from airflow.utils.cli import get_dag from airflow.utils.providers_configuration_loader import

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
o-nikolas commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598821701 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) #

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598811009 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -367,6 +368,7 @@ def test_stopped_tasks(self): class TestAwsEcsExecutor: """Tests the AWS

Re: [PR] Amazon Bedrock - Retrieve and RetrieveAndGenerate [airflow]

2024-05-13 Thread via GitHub
ferruzzi commented on code in PR #39500: URL: https://github.com/apache/airflow/pull/39500#discussion_r1598804403 ## tests/system/providers/amazon/aws/example_bedrock_knowledge_base.py: ## @@ -480,6 +483,24 @@ def delete_opensearch_policies(collection_name: str): ) # [

Re: [PR] Update example AzureContainerInstancesOperator [airflow]

2024-05-13 Thread via GitHub
Kylea650 commented on PR #39466: URL: https://github.com/apache/airflow/pull/39466#issuecomment-2108288124 > Can you fix static checks? Should be good now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] mypy errors - Argument 1 has incompatible type "XComArg" [airflow]

2024-05-13 Thread via GitHub
jonathan-ostrander commented on issue #39514: URL: https://github.com/apache/airflow/issues/39514#issuecomment-2108281294 This was solved by https://github.com/apache/airflow/pull/26023 but that code was moved under the `dev` directory by https://github.com/apache/airflow/pull/28498. AFAIK

(airflow) branch main updated: chore: Add more OpenLineage logs to facilitate debugging (#39136)

2024-05-13 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8bc6c32366 chore: Add more OpenLineage logs to

Re: [PR] [OpenLineage] Add more debug logs to facilitate debugging [airflow]

2024-05-13 Thread via GitHub
mobuchowski merged PR #39136: URL: https://github.com/apache/airflow/pull/39136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

[PR] Handle task adoption for batch executor [airflow]

2024-05-13 Thread via GitHub
vincbeck opened a new pull request, #39590: URL: https://github.com/apache/airflow/pull/39590 Add the feature to adopt abandoned tasks in the Batch executor. Similar to #37786 but with Batch. --- **^ Add meaningful description above** Read the **[Pull

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
o-nikolas commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598727430 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -367,6 +368,7 @@ def test_stopped_tasks(self): class TestAwsEcsExecutor: """Tests the

Re: [I] Status of testing Providers that were prepared on May 12, 2024 [airflow]

2024-05-13 Thread via GitHub
wlinamchurch commented on issue #39578: URL: https://github.com/apache/airflow/issues/39578#issuecomment-2108122956 https://github.com/apache/airflow/pull/38911 works as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Add `parameters` as template field for SqlSensor [airflow]

2024-05-13 Thread via GitHub
josh-fell merged PR #39588: URL: https://github.com/apache/airflow/pull/39588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated (dc61da2509 -> ce4e8477f1)

2024-05-13 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from dc61da2509 remove extra return (#39582) add ce4e8477f1 Add `parameters` as template field for SqlSensor (#39588)

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on PR #39513: URL: https://github.com/apache/airflow/pull/39513#issuecomment-2108101776 ![image](https://github.com/apache/airflow/assets/595491/0b199e24-82ee-46fd-8404-4cfd7e8032c8) -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on PR #39513: URL: https://github.com/apache/airflow/pull/39513#issuecomment-2108099753 All good and green here :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Failure on editing a Variable [airflow]

2024-05-13 Thread via GitHub
raphaelauv commented on issue #39581: URL: https://github.com/apache/airflow/issues/39581#issuecomment-2108091448 I also seen this bug before 2.9.1 with LDAP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[I] UI bug with `DAG Docs` display in `DAG Run` Triggering page [airflow]

2024-05-13 Thread via GitHub
pedro-cf opened a new issue, #39589: URL: https://github.com/apache/airflow/issues/39589 ### Apache Airflow version 2.9.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When triggering a `DAG Run` of a `DAG` that inclu

[PR] Add `parameters` as template field for SqlSensor [airflow]

2024-05-13 Thread via GitHub
josh-fell opened a new pull request, #39588: URL: https://github.com/apache/airflow/pull/39588 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix `xmlsec` version pin [airflow]

2024-05-13 Thread via GitHub
vincbeck commented on PR #39528: URL: https://github.com/apache/airflow/pull/39528#issuecomment-2107990207 Sorry I was away for the week so I could not really help here. As mentioned by Jed, the only reason `xmlsec` was part of the image is because it is a dependency of `python3-saml`. We d

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598628805 ## tests/providers/smtp/notifications/test_smtp.py: ## @@ -129,7 +133,7 @@ def test_notifier_with_defaults(self, mock_smtphook_hook, create_task_instance):

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598627080 ## tests/providers/openlineage/plugins/test_openlineage.py: ## @@ -131,7 +131,7 @@ def teardown_method(self): ), ], ) -def test_plugin_d

Re: [PR] Fix custom actions in security manager `has_access` [airflow]

2024-05-13 Thread via GitHub
vincbeck commented on PR #39421: URL: https://github.com/apache/airflow/pull/39421#issuecomment-2107860287 My bad! Thanks for fixing it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598615598 ## tests/providers/openlineage/plugins/test_openlineage.py: ## @@ -131,7 +131,7 @@ def teardown_method(self): ), ], ) -def test_plugin_d

Re: [I] ExternalPythonOperator Jinja template rendering exception when op_kwargs dictionary value contain special characters [airflow]

2024-05-13 Thread via GitHub
potiuk commented on issue #39584: URL: https://github.com/apache/airflow/issues/39584#issuecomment-2107822246 > @potiuk , I think the solution for this is not a code fix. Rather, update the documentation to inform users that the values passed to `op_args` and `op_kwargs` should follow jinja

Re: [PR] Fix Pod Number Exception in the sync mode if reattach_on_restart parameter is False [airflow]

2024-05-13 Thread via GitHub
e-galan commented on code in PR #39329: URL: https://github.com/apache/airflow/pull/39329#discussion_r1598602503 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -1129,6 +1142,36 @@ def dry_run(self) -> None: def execute_complete(self, context: Context, event: d

Re: [PR] Fix Pod Number Exception in the sync mode if reattach_on_restart parameter is False [airflow]

2024-05-13 Thread via GitHub
e-galan commented on code in PR #39329: URL: https://github.com/apache/airflow/pull/39329#discussion_r1598601888 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -1129,6 +1142,36 @@ def dry_run(self) -> None: def execute_complete(self, context: Context, event: d

[PR] Move Kubernetes cli to provider package [airflow]

2024-05-13 Thread via GitHub
romsharon98 opened a new pull request, #39587: URL: https://github.com/apache/airflow/pull/39587 closes: https://github.com/apache/airflow/issues/39199 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apac

Re: [PR] Chart: Enable templating in extraContainers and extraInitContainers [airflow]

2024-05-13 Thread via GitHub
mewa commented on PR #38507: URL: https://github.com/apache/airflow/pull/38507#issuecomment-2107640878 Rebased on main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] ExternalPythonOperator Jinja template rendering exception when op_kwargs dictionary value contain special characters [airflow]

2024-05-13 Thread via GitHub
rawwar commented on issue #39584: URL: https://github.com/apache/airflow/issues/39584#issuecomment-2107594170 @potiuk , I think the solution for this is not a code fix. Rather, update the documentation to inform users that the values passed to `op_args` and `op_kwargs` should follow jinja s

Re: [I] ExternalPythonOperator Jinja template rendering exception when op_kwargs dictionary value contain special characters [airflow]

2024-05-13 Thread via GitHub
rawwar commented on issue #39584: URL: https://github.com/apache/airflow/issues/39584#issuecomment-2107580559 I looked into this, and the following is my analysis. This error will happen whenever we are parsing values using `jinja_env.from_string(value)` . This happens when the string

Re: [PR] add missing conn_id to string representation of ObjectStoragePath [airflow]

2024-05-13 Thread via GitHub
TJaniF commented on PR #39313: URL: https://github.com/apache/airflow/pull/39313#issuecomment-2107515331 Hello @eladkal 🙂 Very sorry for the late poke about this but is there a chance to include a 1.3.2 release of the common io provider with this bugfix in the current wave of releas

Re: [I] Status of testing Providers that were prepared on May 12, 2024 [airflow]

2024-05-13 Thread via GitHub
VladaZakharova commented on issue #39578: URL: https://github.com/apache/airflow/issues/39578#issuecomment-2107454520 Hi! https://github.com/apache/airflow/pull/39206 works as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] ExternalPythonOperator Jinja template rendering exception when op_kwargs dictionary value contain special characters [airflow]

2024-05-13 Thread via GitHub
rawwar commented on issue #39584: URL: https://github.com/apache/airflow/issues/39584#issuecomment-2107431272 I was able to replicate the issue. But, I am not sure if this is a valid issue. I was also able to replicate this for a usual PythonOperator. Because, all jinja template variables

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598335884 ## tests/providers/openlineage/plugins/test_openlineage.py: ## @@ -131,7 +131,7 @@ def teardown_method(self): ), ], ) -def test_plugin_d

Re: [PR] Run unit tests with airflow installed from packages [airflow]

2024-05-13 Thread via GitHub
potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598335884 ## tests/providers/openlineage/plugins/test_openlineage.py: ## @@ -131,7 +131,7 @@ def teardown_method(self): ), ], ) -def test_plugin_d

[I] Making `mssql` provider to support only `mssql+pymssql` dialect [airflow]

2024-05-13 Thread via GitHub
rawwar opened a new issue, #39586: URL: https://github.com/apache/airflow/issues/39586 ### Description Currently, we allow users to pass dialect via `sqlalchemy_scheme` extra field of the `mssql` connections. I am proposing to remove this field as it is not possible to support multip

Re: [PR] Fix Mark Instance state buttons stay disabled if user lacks permission (#37451) [airflow]

2024-05-13 Thread via GitHub
RodrigoGanancia commented on PR #38732: URL: https://github.com/apache/airflow/pull/38732#issuecomment-2107277260 Hey, the code is now ready, since the fix is pretty simple I removed the test case which was not needed. I'm sorry for the latest commit, It's my first time contributing and I m

Re: [PR] Pin google-cloud-bigquery to < 3.21.0 [airflow]

2024-05-13 Thread via GitHub
potiuk commented on PR #39583: URL: https://github.com/apache/airflow/pull/39583#issuecomment-2107275224 FYI. Whenever we put upper-binding, we should always make a comment and add link to the issue that should remain open - describing the problem. Ideally maybe even opening it in the offen

  1   2   >