vincbeck merged PR #34317:
URL: https://github.com/apache/airflow/pull/34317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1361283764
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1361283427
##
airflow/auth/managers/fab/fab_auth_manager.py:
##
@@ -65,22 +79,24 @@
CLICommand,
)
-_MAP_METHOD_NAME_TO_FAB_ACTION_NAME: dict[ResourceMethod, str
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1360872279
##
airflow/auth/managers/fab/fab_auth_manager.py:
##
@@ -65,22 +79,24 @@
CLICommand,
)
-_MAP_METHOD_NAME_TO_FAB_ACTION_NAME: dict[ResourceMethod, str
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1360871612
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_rea
potiuk commented on PR #34317:
URL: https://github.com/apache/airflow/pull/34317#issuecomment-1763096270
Re-reviewed, only few comments left. Also possibly
https://github.com/apache/airflow/pull/34942 should be merged first.
--
This is an automated message from the Apache Git Service.
To
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359507817
##
airflow/auth/managers/fab/fab_auth_manager.py:
##
@@ -65,22 +79,24 @@
CLICommand,
)
-_MAP_METHOD_NAME_TO_FAB_ACTION_NAME: dict[ResourceMethod, str]
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359507417
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359506835
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1359505166
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_reada
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1358699380
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1358503642
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1358577475
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1358503642
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1358254738
##
airflow/www/security_manager.py:
##
@@ -738,24 +633,9 @@ def create_perm_vm_for_all_dag(self) -> None:
def check_authorization(
self,
perms
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357189276
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357188838
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -527,13 +497,8 @@ def post_clear_task_instances(*, dag_id: str, session:
Session = NEW_SESSION)
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357188653
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -461,13 +436,8 @@ def get_task_instances_batch(session: Session =
NEW_SESSION) -> APIResponse:
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357188155
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.AC
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357158265
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_rea
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357158265
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_rea
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357150789
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357126074
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357045707
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.AC
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1356999376
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1356003454
##
airflow/www/security_manager.py:
##
@@ -738,24 +633,9 @@ def create_perm_vm_for_all_dag(self) -> None:
def check_authorization(
self,
perms:
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355994191
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_reada
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355994191
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_reada
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355994191
##
airflow/www/security_manager.py:
##
@@ -269,125 +272,47 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_reada
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355927810
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355974367
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355941755
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8sc
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355941755
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8sc
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355941755
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8sc
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355927810
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355925044
##
airflow/api_connexion/endpoints/xcom_endpoint.py:
##
@@ -39,14 +39,7 @@
from airflow.api_connexion.types import APIResponse
-@security.requires_access(
-
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355923325
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355894015
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355917769
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355917769
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355917769
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355917769
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355907725
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -646,13 +606,8 @@ def patch_task_instance(
return task_instance_reference_schema.dump(ti)
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355907009
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -527,13 +497,8 @@ def post_clear_task_instances(*, dag_id: str, session:
Session = NEW_SESSION) ->
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355902071
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -461,13 +436,8 @@ def get_task_instances_batch(session: Session =
NEW_SESSION) -> APIResponse:
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355894015
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355894015
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355894015
##
airflow/api_connexion/endpoints/task_instance_endpoint.py:
##
@@ -61,13 +61,8 @@
T = TypeVar("T")
-@security.requires_access(
-[
-(permissions.ACTI
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355579389
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355579727
##
airflow/api_connexion/endpoints/task_endpoint.py:
##
@@ -22,21 +22,16 @@
from airflow.api_connexion import security
from airflow.api_connexion.exceptions import
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355567508
##
airflow/api_connexion/endpoints/task_endpoint.py:
##
@@ -22,21 +22,16 @@
from airflow.api_connexion import security
from airflow.api_connexion.exceptions import
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r138587
##
airflow/api_connexion/endpoints/task_endpoint.py:
##
@@ -22,21 +22,16 @@
from airflow.api_connexion import security
from airflow.api_connexion.exceptions import
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355177606
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1354608628
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,13 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1354604953
##
airflow/api_connexion/security.py:
##
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1354594447
##
airflow/api_connexion/endpoints/task_endpoint.py:
##
@@ -22,21 +22,16 @@
from airflow.api_connexion import security
from airflow.api_connexion.exceptions import
vincbeck commented on PR #34317:
URL: https://github.com/apache/airflow/pull/34317#issuecomment-1755733216
Comments are addressed and CI is green, reviews would be appreciated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347982536
##
airflow/www/security_manager.py:
##
@@ -268,125 +271,53 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_rea
vincbeck commented on PR #34317:
URL: https://github.com/apache/airflow/pull/34317#issuecomment-1749648918
> I think this is OK (a lot to read, won’t be surprised if I missed
anything). Some coding things…
Thanks a lot for the review!
--
This is an automated message from the Apache
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347965402
##
airflow/www/extensions/init_jinja_globals.py:
##
@@ -69,10 +70,17 @@ def prepare_jinja_globals():
"git_version": git_version,
"k8s_or_k8
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347964115
##
airflow/www/security_manager.py:
##
@@ -738,24 +639,13 @@ def create_perm_vm_for_all_dag(self) -> None:
def check_authorization(
self,
perm
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347963150
##
airflow/www/views.py:
##
@@ -3908,9 +3909,11 @@ class DagFilter(BaseFilter):
"""Filter using DagIDs."""
def apply(self, query, func):
-if get_
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347905048
##
airflow/www/security_manager.py:
##
@@ -268,125 +271,53 @@ def get_user_roles(user=None):
user = g.user
return user.roles
-def get_rea
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347839635
##
airflow/api_connexion/endpoints/plugin_endpoint.py:
##
@@ -22,13 +22,12 @@
from airflow.api_connexion.parameters import check_limit, format_parameters
from airf
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347826079
##
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##
@@ -111,13 +102,8 @@ def get_dag_run(*, dag_id: str, dag_run_id: str, session:
Session = NEW_SESSION)
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347823415
##
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##
@@ -76,12 +77,7 @@
RESOURCE_EVENT_PREFIX = "dag_run"
-@security.requires_access(
-[
-(per
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347821224
##
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##
@@ -76,12 +77,7 @@
RESOURCE_EVENT_PREFIX = "dag_run"
-@security.requires_access(
-[
-(per
vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1347821224
##
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##
@@ -76,12 +77,7 @@
RESOURCE_EVENT_PREFIX = "dag_run"
-@security.requires_access(
-[
-(per
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1346978348
##
airflow/api_connexion/endpoints/plugin_endpoint.py:
##
@@ -22,13 +22,12 @@
from airflow.api_connexion.parameters import check_limit, format_parameters
from airf
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1346976365
##
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##
@@ -111,13 +102,8 @@ def get_dag_run(*, dag_id: str, dag_run_id: str, session:
Session = NEW_SESSION)
uranusjr commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1346974337
##
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##
@@ -76,12 +77,7 @@
RESOURCE_EVENT_PREFIX = "dag_run"
-@security.requires_access(
-[
-(per
vincbeck commented on PR #34317:
URL: https://github.com/apache/airflow/pull/34317#issuecomment-1745380219
All comments are addressed. Reviews are welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
72 matches
Mail list logo
