libenchao commented on PR #2835:
URL: https://github.com/apache/calcite/pull/2835#issuecomment-1208826446
merging now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r939600845
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -42,14 +43,18 @@
/**
* Planner rule that creates a {@code SemiJoin} from a
* {@link
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r939600749
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##
@@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,
libenchao commented on PR #2835:
URL: https://github.com/apache/calcite/pull/2835#issuecomment-1207316952
LGTM, will merge after 48 hours if no more objections arise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jacques-n closed pull request #2625: [wip] Introduce a new generic visitor
stateless visitor pattern that RelShuttle can extend.
URL: https://github.com/apache/calcite/pull/2625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jacques-n commented on PR #2625:
URL: https://github.com/apache/calcite/pull/2625#issuecomment-1207293001
Abandoning as no clear solution was found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jacques-n closed pull request #2603: [CALCITE-4882] Introduce new Lambda-based
Metadata framework
URL: https://github.com/apache/calcite/pull/2603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jacques-n commented on PR #2603:
URL: https://github.com/apache/calcite/pull/2603#issuecomment-1207292762
Abandoning this work as there was too much contention around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jacques-n closed pull request #2641: [CALCITE-4934] Deploy snapshots releases
on master merge
URL: https://github.com/apache/calcite/pull/2641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jacques-n commented on PR #2641:
URL: https://github.com/apache/calcite/pull/2641#issuecomment-1207292068
Abandoning due to another version being done by another committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
asolimando commented on code in PR #2866:
URL: https://github.com/apache/calcite/pull/2866#discussion_r938842167
##
site/README.md:
##
@@ -93,3 +93,11 @@ You can preview your work while working on the site.
The web server will be started on
libenchao closed pull request #2834: [CALCITE-5192] CodeGenerationBenchmark
throws IllegalStateException
URL: https://github.com/apache/calcite/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
libenchao commented on PR #2834:
URL: https://github.com/apache/calcite/pull/2834#issuecomment-1205918303
merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
libenchao opened a new pull request, #2866:
URL: https://github.com/apache/calcite/pull/2866
Add a section about how to release the site content in site/README.md, to
avoid staled js/css files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
libenchao commented on PR #2834:
URL: https://github.com/apache/calcite/pull/2834#issuecomment-1205395198
@zabetak Thanks for your review comments, they are helpful, I've addressed
both of them.
--
This is an automated message from the Apache Git Service.
To respond to the message,
zabetak commented on code in PR #2834:
URL: https://github.com/apache/calcite/pull/2834#discussion_r937520689
##
ubenchmark/src/jmh/java/org/apache/calcite/adapter/enumerable/CodeGenerationBenchmark.java:
##
@@ -183,23 +184,25 @@ public void setup() {
info.javaCode =
libenchao closed pull request #2843: [CALCITE-5178] Single column with ROW type
generates wrong plan
URL: https://github.com/apache/calcite/pull/2843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
libenchao commented on PR #2843:
URL: https://github.com/apache/calcite/pull/2843#issuecomment-1204630187
merging now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sdreynolds opened a new pull request, #2865:
URL: https://github.com/apache/calcite/pull/2865
## Why:
There are two common weakness vuln:
1. https://cwe.mitre.org/data/definitions/522.html
2. https://cwe.mitre.org/data/definitions/200.html
This is fixed in:
asereda-gs merged PR #2858:
URL: https://github.com/apache/calcite/pull/2858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
akash-pawar1 commented on PR #2864:
URL: https://github.com/apache/calcite/pull/2864#issuecomment-1202020550
closing as target branch is incorrect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
akash-pawar1 closed pull request #2864: Ravtdbq 60 table name and column name
are same
URL: https://github.com/apache/calcite/pull/2864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beyond1920 commented on PR #2606:
URL: https://github.com/apache/calcite/pull/2606#issuecomment-1200439061
Hi @tmostak , the pr is merged in main branch, would be released in 1.31.0
version.
Any feedback is welcome.
--
This is an automated message from the Apache Git Service.
To
GavinRay97 commented on PR #2116:
URL: https://github.com/apache/calcite/pull/2116#issuecomment-1200013442
This is a super valuable PR, just wanted to bring it up again and also give
some feedback on it:
I rebased this locally off of main today and built it, it works except in
keatn opened a new pull request, #2863:
URL: https://github.com/apache/calcite/pull/2863
Actually fixes date expansion. I realized the error only occurs if you
re-build the parser, so my previous fix wasn't actually a fix.
--
This is an automated message from the Apache Git Service.
keatn closed pull request #2863: Keaton fix date expansion
URL: https://github.com/apache/calcite/pull/2863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
zabetak commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r933008816
##
site/_docs/history.md:
##
@@ -28,15 +28,66 @@ For a full list of releases, see
Downloads are available on the
[downloads page]({{ site.baseurl }}/downloads/).
julianhyde opened a new pull request, #2862:
URL: https://github.com/apache/calcite/pull/2862
This PR is currently a test case, not a fix. Do not merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zabetak merged PR #2861:
URL: https://github.com/apache/calcite/pull/2861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aymeric-dispa commented on code in PR #2860:
URL: https://github.com/apache/calcite/pull/2860#discussion_r931248326
##
core/src/main/java/org/apache/calcite/sql/dialect/FireboltSqlDialect.java:
##
@@ -196,4 +197,18 @@ public FireboltSqlDialect(Context context) {
}
}
rubenada merged PR #181:
URL: https://github.com/apache/calcite-avatica/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chunweilei commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r927340694
##
site/_docs/history.md:
##
@@ -29,9 +29,77 @@ Downloads are available on the
[downloads page]({{ site.baseurl }}/downloads/).
{% comment %}
-##
chunweilei commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r927340694
##
site/_docs/history.md:
##
@@ -29,9 +29,77 @@ Downloads are available on the
[downloads page]({{ site.baseurl }}/downloads/).
{% comment %}
-##
JiajunBernoulli commented on code in PR #2860:
URL: https://github.com/apache/calcite/pull/2860#discussion_r929471146
##
core/src/main/java/org/apache/calcite/sql/dialect/FireboltSqlDialect.java:
##
@@ -196,4 +197,18 @@ public FireboltSqlDialect(Context context) {
}
zabetak commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r928981043
##
site/_docs/history.md:
##
@@ -46,19 +114,195 @@ other software versions as specified in gradle.properties.
New features
{: #new-features-1-31-0}
+*
aymeric-dispa closed pull request #2859: [CALCITE-5217] Add support for
INTERVAL qualifier for Firebolt
URL: https://github.com/apache/calcite/pull/2859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
asereda-gs commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r927217307
##
site/_docs/history.md:
##
@@ -46,19 +106,193 @@ other software versions as specified in gradle.properties.
New features
{: #new-features-1-31-0}
+*
rubenada commented on PR #2858:
URL: https://github.com/apache/calcite/pull/2858#issuecomment-1191207601
Thanks for producing the release notes @asereda-gs , I have left some minor
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rubenada commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r926409802
##
site/_docs/history.md:
##
@@ -46,19 +106,193 @@ other software versions as specified in gradle.properties.
New features
{: #new-features-1-31-0}
+*
rubenada commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r926407386
##
site/_docs/history.md:
##
@@ -29,9 +29,69 @@ Downloads are available on the
[downloads page]({{ site.baseurl }}/downloads/).
{% comment %}
-##
rubenada commented on code in PR #2858:
URL: https://github.com/apache/calcite/pull/2858#discussion_r926403912
##
site/_docs/history.md:
##
@@ -46,19 +106,193 @@ other software versions as specified in gradle.properties.
New features
{: #new-features-1-31-0}
+*
zabetak commented on code in PR #2813:
URL: https://github.com/apache/calcite/pull/2813#discussion_r925409690
##
core/src/main/java/org/apache/calcite/rel/RelNode.java:
##
@@ -152,8 +152,27 @@ public interface RelNode extends RelOptNode, Cloneable {
* expression but also
keatn closed pull request #2857: Unreserves width bucket
URL: https://github.com/apache/calcite/pull/2857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
JiajunBernoulli commented on PR #2847:
URL: https://github.com/apache/calcite/pull/2847#issuecomment-1188749238
@beyond1920 , Would you please review the PR? You left a comment on
https://github.com/apache/calcite/pull/2615. (The PR is from that PR)
Thank you very much~
--
beyond1920 merged PR #2856:
URL: https://github.com/apache/calcite/pull/2856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
beyond1920 commented on PR #2844:
URL: https://github.com/apache/calcite/pull/2844#issuecomment-1188526060
Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
beyond1920 closed pull request #2844: [CALCITE-4865] Allow table functions to
be polymorphic
URL: https://github.com/apache/calcite/pull/2844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ian-bertolacci commented on PR #2813:
URL: https://github.com/apache/calcite/pull/2813#issuecomment-1187728836
@libenchao @zabetak thanks for the update! Good to hear this is in a good
and ready state. My understanding is that 1.31 has been delayed by other
issues; is there a possiblity
beyond1920 commented on PR #2844:
URL: https://github.com/apache/calcite/pull/2844#issuecomment-1186889579
Hi, @danny0405 @julianhyde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hailin0 commented on code in PR #2855:
URL: https://github.com/apache/calcite/pull/2855#discussion_r922942312
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##
@@ -436,11 +436,13 @@ private RelDataType getTightestCommonTypeOrThrow(
chunweilei merged PR #2851:
URL: https://github.com/apache/calcite/pull/2851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chunweilei commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r922935228
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -42,14 +43,18 @@
/**
* Planner rule that creates a {@code SemiJoin} from a
* {@link
chunweilei commented on code in PR #2855:
URL: https://github.com/apache/calcite/pull/2855#discussion_r922932458
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##
@@ -436,11 +436,13 @@ private RelDataType getTightestCommonTypeOrThrow(
hailin0 opened a new pull request, #2855:
URL: https://github.com/apache/calcite/pull/2855
https://issues.apache.org/jira/browse/CALCITE-5214
The following test:
```java
//org.apache.calcite.test.SqlToRelConverterTest
@Test void testUnionNullableImplicitTypeCoercion() {
ian-bertolacci commented on PR #2813:
URL: https://github.com/apache/calcite/pull/2813#issuecomment-1185869138
Hello, what is the status of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dssysolyatin commented on code in PR #2712:
URL: https://github.com/apache/calcite/pull/2712#discussion_r921892665
##
core/src/main/java/org/apache/calcite/rel/core/Collect.java:
##
@@ -132,6 +133,47 @@ public static Collect create(RelNode input,
fieldName,
rubenada commented on code in PR #2712:
URL: https://github.com/apache/calcite/pull/2712#discussion_r921216844
##
core/src/main/java/org/apache/calcite/rel/core/Collect.java:
##
@@ -132,6 +133,47 @@ public static Collect create(RelNode input,
fieldName,
dssysolyatin commented on code in PR #2712:
URL: https://github.com/apache/calcite/pull/2712#discussion_r920992279
##
core/src/main/java/org/apache/calcite/rel/core/Collect.java:
##
@@ -132,6 +133,47 @@ public static Collect create(RelNode input,
fieldName,
rubenada commented on code in PR #2712:
URL: https://github.com/apache/calcite/pull/2712#discussion_r920896164
##
core/src/main/java/org/apache/calcite/rel/core/Collect.java:
##
@@ -132,6 +133,47 @@ public static Collect create(RelNode input,
fieldName,
JiajunBernoulli commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r918551024
##
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml:
##
@@ -2936,7 +2936,7 @@ values (10, 'Fred')]]>
JiajunBernoulli commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r918550342
##
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml:
##
@@ -2885,7 +2885,7 @@ LogicalTableModify(table=[[CATALOG, SALES, EMPDEFAULTS]],
JiajunBernoulli commented on code in PR #2847:
URL: https://github.com/apache/calcite/pull/2847#discussion_r918549135
##
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml:
##
@@ -2897,7 +2897,7 @@ LogicalTableModify(table=[[SALES, EMPDEFAULTS]],
JiajunBernoulli commented on PR #2847:
URL: https://github.com/apache/calcite/pull/2847#issuecomment-1181315028
@danny0405 , Would you please review the pull request that is from
[CALCITE-4897](https://github.com/apache/calcite/pull/2615)?
Thanks you very much~
--
This is an
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r917343155
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r917343155
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r917343155
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r917319093
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
abhishek-das-gupta opened a new pull request, #2853:
URL: https://github.com/apache/calcite/pull/2853
Instead of first row expression's datatype, SARG datatype should consider
datatype
of every row expression present in the `IN` clause and should return the
most general of a
set of
beyond1920 commented on PR #2844:
URL: https://github.com/apache/calcite/pull/2844#issuecomment-1177525405
@danny0405 Thanks for your review.
I've updated pull request to address your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message,
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r915788510
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -1564,6 +1564,50 @@ public void _testLikeAndSimilarFails() {
.fails("No match
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r915658421
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -958,7 +960,17 @@ private static List elseArgs(int count) {
private static
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r915649928
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -1371,13 +1373,153 @@ private void substituteSubQuery(Blackboard bb,
SubQuery
beyond1920 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r915648465
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r915379084
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -42,14 +43,18 @@
/**
* Planner rule that creates a {@code SemiJoin} from a
* {@link
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r915375337
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##
@@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,
rubenada commented on PR #2851:
URL: https://github.com/apache/calcite/pull/2851#issuecomment-1175893656
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
joshuamaurice commented on PR #2852:
URL: https://github.com/apache/calcite/pull/2852#issuecomment-1175867217
Also, already made the bug.
https://issues.apache.org/jira/browse/CALCITE-5204
On Wed, Jul 6, 2022 at 12:16 AM Joshua Maurice ***@***.***>
wrote:
> Hi Alessandro
joshuamaurice commented on PR #2852:
URL: https://github.com/apache/calcite/pull/2852#issuecomment-1175866878
Hi Alessandro Solimando,
Ok, thanks. Will do
On Wed, Jul 6, 2022 at 12:09 AM Alessandro Solimando <
***@***.***> wrote:
> Hi @joshuamaurice
asolimando commented on PR #2852:
URL: https://github.com/apache/calcite/pull/2852#issuecomment-1175860897
Hi @joshuamaurice, I don't know why the PR was closed without any comments,
this should not happen.
I haven't looked at the fix, but for each non-trivial change (e.g., fixing a
joshuamaurice commented on PR #2852:
URL: https://github.com/apache/calcite/pull/2852#issuecomment-1175828625
Hi. I see the pull requested was closed (denied). I'm sorry. I'm new to
Apache Calcite and github, and I don't know the proper etiquette. Should I file
a bug in github first for
joshuamaurice opened a new pull request, #2852:
URL: https://github.com/apache/calcite/pull/2852
For array of array of int (nested arrays), the Rep of one of the arrays is
PRIMITIVE_INT, not MULTISET. This breaks when calling ResultSet.getObject,
failing in the array-accessor with the
keatn closed pull request #2850: Keaton/qualify support
URL: https://github.com/apache/calcite/pull/2850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rubenada commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913813782
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##
@@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,
rubenada commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913797879
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -42,14 +43,18 @@
/**
* Planner rule that creates a {@code SemiJoin} from a
* {@link
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913762560
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java:
##
@@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input,
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913754054
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -42,14 +43,18 @@
/**
* Planner rule that creates a {@code SemiJoin} from a
* {@link
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913751422
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -4164,6 +4164,77 @@ void checkPeriodPredicate(Checker checker) {
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913752126
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -1564,6 +1564,50 @@ public void _testLikeAndSimilarFails() {
.fails("No match
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913751422
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -4164,6 +4164,77 @@ void checkPeriodPredicate(Checker checker) {
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913749876
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -958,7 +960,17 @@ private static List elseArgs(int count) {
private static
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r913747509
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -232,6 +237,79 @@ default JoinToSemiJoinRuleConfig
withOperandFor(Class joinClass,
}
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913747288
##
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##
@@ -1371,13 +1373,153 @@ private void substituteSubQuery(Blackboard bb,
SubQuery
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913742664
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913741092
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913741092
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -3380,6 +3384,66 @@ protected void validateFrom(
getNamespaceOrThrow(node,
libenchao merged PR #2849:
URL: https://github.com/apache/calcite/pull/2849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913733981
##
core/src/main/java/org/apache/calcite/sql/TableCharacteristic.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913732009
##
core/src/main/java/org/apache/calcite/sql/SqlTableFunction.java:
##
@@ -30,4 +32,17 @@ public interface SqlTableFunction {
* @return strategy to infer the row
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913727713
##
core/src/main/java/org/apache/calcite/sql/SqlSetSemanticsTableOperator.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
danny0405 commented on code in PR #2844:
URL: https://github.com/apache/calcite/pull/2844#discussion_r913726617
##
core/src/main/java/org/apache/calcite/sql/SqlSetSemanticsTableOperator.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
1001 - 1100 of 18124 matches
Mail list logo
