absurdfarce merged PR #1936:
URL: https://github.com/apache/cassandra-java-driver/pull/1936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
absurdfarce commented on code in PR #1936:
URL:
https://github.com/apache/cassandra-java-driver/pull/1936#discussion_r1631441587
##
Jenkinsfile:
##
@@ -411,14 +411,14 @@ pipeline {
triggers {
// schedules only run against release branches (i.e. 3.x, 4.x, 4.5.x, etc.)
adutra commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1631420991
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java:
##
@@ -318,4 +330,42 @@ protected int
christianaistleitner opened a new pull request, #1938:
URL: https://github.com/apache/cassandra-java-driver/pull/1938
Hi, this PR fixes the warning log spam when cancelling queries after the
maximum orphan limit has been reached.
```
2024-06-04 05:36:38 UTC WARNING []
[<>,
absurdfarce commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1628509853
##
core/src/main/java/com/datastax/oss/driver/internal/core/metadata/DistanceEvent.java:
##
@@ -29,11 +31,16 @@
@Immutable
public class
bschoening opened a new pull request, #1937:
URL: https://github.com/apache/cassandra-java-driver/pull/1937
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
absurdfarce commented on code in PR #1936:
URL:
https://github.com/apache/cassandra-java-driver/pull/1936#discussion_r1626163120
##
Jenkinsfile:
##
@@ -414,11 +414,11 @@ pipeline {
# Every weeknight (Monday - Friday) around 2:00 AM
### JDK8 tests against 2.1,
absurdfarce commented on code in PR #1936:
URL:
https://github.com/apache/cassandra-java-driver/pull/1936#discussion_r1626163120
##
Jenkinsfile:
##
@@ -414,11 +414,11 @@ pipeline {
# Every weeknight (Monday - Friday) around 2:00 AM
### JDK8 tests against 2.1,
absurdfarce commented on code in PR #1936:
URL:
https://github.com/apache/cassandra-java-driver/pull/1936#discussion_r1626161031
##
Jenkinsfile:
##
@@ -414,11 +414,11 @@ pipeline {
# Every weeknight (Monday - Friday) around 2:00 AM
### JDK8 tests against 2.1,
absurdfarce merged PR #1934:
URL: https://github.com/apache/cassandra-java-driver/pull/1934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
absurdfarce commented on PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#issuecomment-2145894890
Yup, this looks good to me. Thanks @lukasz-antoniak!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lukasz-antoniak opened a new pull request, #1935:
URL: https://github.com/apache/cassandra-java-driver/pull/1935
JIRA Links:
- https://datastax-oss.atlassian.net/browse/JAVA-3109
- https://datastax-oss.atlassian.net/browse/JAVA-2980
--
This is an automated message from the Apache
lukasz-antoniak commented on PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2142203185
Any optimisation is fine. The changes you proposed make code cleaner and the
initialisation of execution profile easier to follow. Let us just address one
comment
chibenwa commented on PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2142174927
For the record https://github.com/apache/cassandra-java-driver/pull/1622
being merge the remaining resolveExecutionProfile only accounts for .07% of
Apache James CPU
chibenwa commented on PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2142165069
I forced push this PR in order to remove the now merged commit.
Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond
chibenwa closed pull request #1622: Conversions: resolveExecutionProfile only
when needed
URL: https://github.com/apache/cassandra-java-driver/pull/1622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chibenwa opened a new pull request, #1623:
URL: https://github.com/apache/cassandra-java-driver/pull/1623
Those repeated calls account for a non-negligible portion of my application
CPU (0.6%) and can definitly be a final field so that it gets resolved only
once per CqlRequestHandler.
lukasz-antoniak commented on PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2141940006
I think you closed the wrong PR. This one is mostly fine :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chibenwa commented on PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2141936438
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chibenwa closed pull request #1623: Limit calls to
Conversions.resolveExecutionProfile
URL: https://github.com/apache/cassandra-java-driver/pull/1623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lukasz-antoniak commented on PR #1623:
URL:
https://github.com/apache/cassandra-java-driver/pull/1623#issuecomment-2141774747
Do you mind closing
https://github.com/apache/cassandra-java-driver/pull/1622, as from what I see,
this PR contains those changes?
--
This is an automated
absurdfarce commented on PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#issuecomment-2137762352
Excellent, thanks for making those final changes so quickly
@lukasz-antoniak! With your most recent work I believe we have all the code
changes we need to get this
absurdfarce commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1619129238
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1618670454
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1618668119
##
integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/SchemaIT.java:
##
@@ -254,6 +254,20 @@ public void
absurdfarce commented on PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#issuecomment-2135844487
Agree with @tolbertam ; well done @lukasz-antoniak! There are a few nits
I'd like to see cleaned up but once those are in place I think I'm a as well.
--
This is
absurdfarce commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1617689369
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
absurdfarce commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1617673427
##
integration-tests/src/test/java/com/datastax/oss/driver/core/metadata/SchemaIT.java:
##
@@ -254,6 +254,20 @@ public void
lukasz-antoniak commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2135352720
Good work @ajweave, sorry to keep you waiting. Two things to consider from
my end. Feel free to disagree since both are more of coding style category.
In
lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1615556869
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/CcmBridge.java:
##
@@ -199,7 +199,7 @@ public Version
akhaku commented on PR #1607:
URL:
https://github.com/apache/cassandra-java-driver/pull/1607#issuecomment-2132044855
Sure, done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
akhaku commented on PR #1635:
URL:
https://github.com/apache/cassandra-java-driver/pull/1635#issuecomment-2131730576
Awesome, thank you for doing that work for me Lukasz! I added it in a new
integration test since I couldn't find another existing one that fit. Also
rebased.
The
tolbertam commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1614216360
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/SchemaChangeSynchronizer.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the
tolbertam commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1614198117
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/BaseCcmRule.java:
##
@@ -38,7 +38,7 @@ public abstract class BaseCcmRule extends
SiyaoIsHiding closed pull request #1915: CASSANDRA-19451: An Option of Latency
Sensitive Load Balancing Policy
URL: https://github.com/apache/cassandra-java-driver/pull/1915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SiyaoIsHiding commented on PR #1915:
URL:
https://github.com/apache/cassandra-java-driver/pull/1915#issuecomment-2130416305
Closed cuz we ended up publishing an artifact for it:
https://github.com/datastax/java-driver-policies
--
This is an automated message from the Apache Git Service.
lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613817782
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/BaseCcmRule.java:
##
@@ -38,7 +38,7 @@ public abstract class BaseCcmRule
lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613810398
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
lukasz-antoniak commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613809842
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/SchemaChangeSynchronizer.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the
tolbertam commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613635010
##
test-infra/src/main/java/com/datastax/oss/driver/api/testinfra/ccm/BaseCcmRule.java:
##
@@ -38,7 +38,7 @@ public abstract class BaseCcmRule extends
tolbertam commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613633816
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
tolbertam commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613624741
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
tolbertam commented on code in PR #1934:
URL:
https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1613633816
##
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java:
##
@@ -34,23 +34,27 @@
import
lukasz-antoniak opened a new pull request, #1934:
URL: https://github.com/apache/cassandra-java-driver/pull/1934
JIRA link: https://issues.apache.org/jira/browse/CASSANDRA-19635
PR contains necessary changes to run integration tests with Apache Cassandra
5.0-beta1. Developers can run
bbotella commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1611749908
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##
@@ -258,28 +269,17 @@ private void
lukasz-antoniak commented on PR #1607:
URL:
https://github.com/apache/cassandra-java-driver/pull/1607#issuecomment-2122499865
Shall we also add `@CheckReturnValue` to `Statement#setNowInSeconds(int)`?
All Implementations are immutable and create new object.
```java
@NonNull
lukasz-antoniak commented on PR #1635:
URL:
https://github.com/apache/cassandra-java-driver/pull/1635#issuecomment-2122314815
I've had hard time trying to replicate this issue. Attempts to ignore schema
updates on control connection did not replicate the problem. In fact,
absurdfarce merged PR #1933:
URL: https://github.com/apache/cassandra-java-driver/pull/1933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
absurdfarce commented on PR #1933:
URL:
https://github.com/apache/cassandra-java-driver/pull/1933#issuecomment-2118056886
Thanks for the follow-up @nitinitt !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
frankgh merged PR #59:
URL: https://github.com/apache/cassandra-analytics/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yifan-c commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597650872
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##
@@ -486,20 +496,23
yifan-c commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597648858
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##
@@ -428,9 +436,11 @@
frankgh commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597633049
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##
@@ -486,20 +496,23
frankgh commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597632737
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##
@@ -428,9 +436,11 @@
frankgh commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597630564
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##
@@ -486,20 +496,23
yifan-c commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597549593
##
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##
@@ -428,9 +436,11 @@
frankgh merged PR #58:
URL: https://github.com/apache/cassandra-analytics/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1596024998
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -52,20 +68,23 @@ default void onSuccess(
* @param
ajweave commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1596015592
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
* @param
absurdfarce commented on PR #1929:
URL:
https://github.com/apache/cassandra-java-driver/pull/1929#issuecomment-2103041959
This functionality has been implemented in #1932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
absurdfarce closed pull request #1929: CASSANDRA-19568: Jennkins pipeline's
default Java version for Jabba has changed
URL: https://github.com/apache/cassandra-java-driver/pull/1929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
adutra commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1595217254
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -52,20 +68,23 @@ default void onSuccess(
* @param
absurdfarce merged PR #1932:
URL: https://github.com/apache/cassandra-java-driver/pull/1932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2101687257
Thanks @absurdfarce! I have addressed the 2 minor documentation comments as
part of: https://github.com/apache/cassandra-java-driver/pull/1933/files
--
This is an
nitinitt opened a new pull request, #1933:
URL: https://github.com/apache/cassandra-java-driver/pull/1933
This PR is to address code review comment in merged
[PR](https://github.com/apache/cassandra-java-driver/pull/1896)
-
frankgh opened a new pull request, #58:
URL: https://github.com/apache/cassandra-analytics/pull/58
…ith null values
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRA-19626
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ajweave commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2101654238
Sorry for the delay. I will get this done tomorrow. I appreciate the
attention here.
--
This is an automated message from the Apache Git Service.
To respond to the
SiyaoIsHiding commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2101624573
May you please merge apache/4.x to your branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1594781483
##
core/src/main/java/com/datastax/dse/driver/internal/core/cql/continuous/ContinuousRequestHandlerBase.java:
##
@@ -1590,18 +1597,20 @@ private
5 opened a new pull request, #57:
URL: https://github.com/apache/cassandra-analytics/pull/57
Introduce the initial Gradle configuration for integration of Cassandra
Analytics with SonarCube for code analysis
--
This is an automated message from the Apache Git Service.
To respond to the
absurdfarce opened a new pull request, #1932:
URL: https://github.com/apache/cassandra-java-driver/pull/1932
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
absurdfarce merged PR #1896:
URL: https://github.com/apache/cassandra-java-driver/pull/1896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2101007620
Thanks @nitinitt, this looks great! I concur that this commit looks like it
contains all the fixes we've been discussing so we are ready to get this guy
in! Big
absurdfarce commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1585228162
##
core/src/main/resources/reference.conf:
##
@@ -574,6 +574,11 @@ datastax-java-driver {
# Modifiable at runtime: no
# Overridable in
michaelsembwever commented on PR #1931:
URL:
https://github.com/apache/cassandra-java-driver/pull/1931#issuecomment-2100603793
what's the CASSANDRA ticket for this ?
i will test this downstream here:
-
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2099492321
Thanks @absurdfarce for the guidance and the patience. I have squashed and
force pushed and here is how git log looks to e:
```
Author: Nitin Chhabra
Date: Thu
SiyaoIsHiding commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1593183103
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java:
##
@@ -96,14 +99,38 @@ public class
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2099192505
Excellent, that looks great @nitinitt! Thanks for jumping on that so
quickly!
As for your question: we do indeed plan on merging this ticket before the
next
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2098926296
> @nitinitt Probably the most straightforward way to incorporate the changes
would be to get a patch file from the other PR and then apply that patch to
this PR. You can
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2098596820
@nitinitt Probably the most straightforward way to incorporate the changes
would be to get a patch file from the other PR and then apply that patch to
this PR. You
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2097545011
Thanks @tolbertam and @absurdfarce for taking the time and helping to
simplify the code with [refactored
PR](https://github.com/absurdfarce/cassandra-java-driver/pull/1
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2097402276
Apologies @nitinitt , I know this has taken a long time to get to... I
really appreciate your patience.
Overall I'm pretty positive on the change but I'm a bit
tolbertam commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1591774161
##
core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java:
##
@@ -892,6 +892,16 @@ public String toString() {
tolbertam commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1591773768
##
core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java:
##
@@ -982,7 +982,13 @@ public enum DefaultDriverOption
SiyaoIsHiding opened a new pull request, #1931:
URL: https://github.com/apache/cassandra-java-driver/pull/1931
The current PR is only about the `ANN OF` in the `QueryBuiler`, not anything
else yet. I would appreciate it if this PR undergo an initial review, which
will help my future
yifan-c merged PR #56:
URL: https://github.com/apache/cassandra-analytics/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yifan-c opened a new pull request, #56:
URL: https://github.com/apache/cassandra-analytics/pull/56
The patch updates the analytics code to consume the latest sidecar client
after CASSANDRASC-127
Patch by Yifan Cai; Reviewed by Francisco Guerrero for CASSANDRA-19616
--
This is an
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1587797662
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
*
absurdfarce commented on code in PR #1915:
URL:
https://github.com/apache/cassandra-java-driver/pull/1915#discussion_r1587128032
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/LatencySensitiveLoadBalancingPolicy.java:
##
@@ -0,0 +1,275 @@
+/*
Review
SiyaoIsHiding closed pull request #1736: JAVA-3129: Change Snappy version and
corresponding manual page
URL: https://github.com/apache/cassandra-java-driver/pull/1736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
SiyaoIsHiding commented on code in PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#discussion_r1586980425
##
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##
@@ -148,16 +204,17 @@ default void onNodeSuccess(
*
SiyaoIsHiding closed pull request #1927: CASSANDRA-19562:
DefaultLoadBalancingPolicy considers a TimeOut as a response
URL: https://github.com/apache/cassandra-java-driver/pull/1927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
absurdfarce commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-2087323844
Ping @SiyaoIsHiding for (hopefully) another review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
absurdfarce closed pull request #1735: JAVA-3131: Add #retrieve method to
EndPoint for when caller does not …
URL: https://github.com/apache/cassandra-java-driver/pull/1735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
absurdfarce commented on PR #1735:
URL:
https://github.com/apache/cassandra-java-driver/pull/1735#issuecomment-2081935262
Replaced by https://github.com/apache/cassandra-java-driver/pull/1919.
Review comments will be handled there.
--
This is an automated message from the Apache Git
arjunashok commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1581469217
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/stats/JobStatsPublisher.java:
##
@@ -30,8 +30,9 @@ public interface
arjunashok commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1581459225
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -135,12 +135,11 @@ private void
arjunashok commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1581455845
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##
@@ -217,16 +228,15 @@ private void
frankgh commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1581241000
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -135,12 +135,11 @@ private void
arjunashok commented on PR #55:
URL:
https://github.com/apache/cassandra-analytics/pull/55#issuecomment-2078473648
Closing as duplicate of https://github.com/apache/cassandra-analytics/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please
1 - 100 of 1140 matches
Mail list logo
