[GitHub] liuzx32 opened a new issue #10984: Some wrong with training on yarn!?

2018-05-16 Thread GitBox
liuzx32 opened a new issue #10984: Some wrong with training on yarn!? URL: https://github.com/apache/incubator-mxnet/issues/10984 ../../tools/launch.py -n 2 -s 2 --cluster=local python train_mnist.py --network lenet --kv-store dist_sync, run successful. So I adjust --cluster=yarn to mxne

[GitHub] haojin2 commented on issue #10981: build ends with error : elemwise_binary_op-inl.h:78:3574: error: expected primary-expression before ‘template’

2018-05-16 Thread GitBox
haojin2 commented on issue #10981: build ends with error : elemwise_binary_op-inl.h:78:3574: error: expected primary-expression before ‘template’ URL: https://github.com/apache/incubator-mxnet/issues/10981#issuecomment-389749310 @phoenixbai A quick solution to this is to upgrade your CUDA

[GitHub] eric-haibin-lin commented on issue #10981: build ends with error : elemwise_binary_op-inl.h:78:3574: error: expected primary-expression before ‘template’

2018-05-16 Thread GitBox
eric-haibin-lin commented on issue #10981: build ends with error : elemwise_binary_op-inl.h:78:3574: error: expected primary-expression before ‘template’ URL: https://github.com/apache/incubator-mxnet/issues/10981#issuecomment-389748559 @haojin2 -

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188841316 ## File path: src/operator/nn/control_flow.cc ## @@ -0,0 +1,594 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188507205 ## File path: src/c_api/c_api_symbolic.cc ## @@ -344,6 +345,33 @@ int MXSymbolGetAtomicSymbolName(AtomicSymbolCreator c

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188508037 ## File path: src/executor/exec_pass.h ## @@ -64,6 +64,9 @@ class OpExecutor { OpContext op_ctx; /*! \brief virtua

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188505156 ## File path: python/mxnet/symbol/contrib.py ## @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188782087 ## File path: src/operator/nn/control_flow.cc ## @@ -0,0 +1,594 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188511608 ## File path: src/operator/nn/control_flow.cc ## @@ -0,0 +1,594 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188507490 ## File path: src/c_api/c_api_symbolic.cc ## @@ -344,6 +345,33 @@ int MXSymbolGetAtomicSymbolName(AtomicSymbolCreator c

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188506820 ## File path: python/mxnet/symbol/contrib.py ## @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188504970 ## File path: python/mxnet/symbol/contrib.py ## @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188506678 ## File path: python/mxnet/symbol/contrib.py ## @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188506709 ## File path: python/mxnet/symbol/contrib.py ## @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188838801 ## File path: src/operator/nn/control_flow.cc ## @@ -0,0 +1,594 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188505538 ## File path: python/mxnet/symbol/contrib.py ## @@ -91,3 +98,99 @@ def rand_zipfian(true_classes, num_sampled, range_max

[GitHub] reminisce commented on a change in pull request #10451: [WIP] Add Foreach

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10451: [WIP] Add Foreach URL: https://github.com/apache/incubator-mxnet/pull/10451#discussion_r188840339 ## File path: src/operator/nn/control_flow.cc ## @@ -0,0 +1,594 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] eric-haibin-lin opened a new pull request #10983: [MXNET-427] Fix trainer.load_state by removing param_dict from optimizer state pickle

2018-05-16 Thread GitBox
eric-haibin-lin opened a new pull request #10983: [MXNET-427] Fix trainer.load_state by removing param_dict from optimizer state pickle URL: https://github.com/apache/incubator-mxnet/pull/10983 ## Description ## See JIRA item for more details. @piiswrong @szha please review. ## Ch

[GitHub] pengzhao-intel commented on issue #10933: remove unnecessary checks on convolution parameters

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10933: remove unnecessary checks on convolution parameters URL: https://github.com/apache/incubator-mxnet/pull/10933#issuecomment-389746651 @zheng-da @piiswrong tiny change to remove unnecessary code, please help take a review. --

[GitHub] szha opened a new pull request #10982: fix rnn layer kernel forward

2018-05-16 Thread GitBox
szha opened a new pull request #10982: fix rnn layer kernel forward URL: https://github.com/apache/incubator-mxnet/pull/10982 ## Description ## fix rnn layer condition for kernel forward. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for you

[GitHub] chinakook commented on issue #10972: Gluon's PReLU is very slow and a fix to it

2018-05-16 Thread GitBox
chinakook commented on issue #10972: Gluon's PReLU is very slow and a fix to it URL: https://github.com/apache/incubator-mxnet/issues/10972#issuecomment-389741834 I think it's no need to broadcast when multiply a scalar and a matrix. May some other operation is more suitable for this kind

[GitHub] ThomasDelteil commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
ThomasDelteil commented on issue #10979: Fix bugs in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389741368 :+1: for the descriptive title and PR description This is an automated message from

[GitHub] szha commented on issue #9686: APIs that might be a good idea to break in 2.0

2018-05-16 Thread GitBox
szha commented on issue #9686: APIs that might be a good idea to break in 2.0 URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-389740264 contrib.ctc_loss should make into supported operator. This is an

[GitHub] yifeim commented on a change in pull request #10946: Remove kvstore calls from FM example

2018-05-16 Thread GitBox
yifeim commented on a change in pull request #10946: Remove kvstore calls from FM example URL: https://github.com/apache/incubator-mxnet/pull/10946#discussion_r188834985 ## File path: example/sparse/factorization_machine/train.py ## @@ -75,6 +76,16 @@ assert(args.data

[GitHub] eric-haibin-lin commented on a change in pull request #10946: Remove kvstore calls from FM example

2018-05-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #10946: Remove kvstore calls from FM example URL: https://github.com/apache/incubator-mxnet/pull/10946#discussion_r188834717 ## File path: example/sparse/factorization_machine/train.py ## @@ -75,6 +76,16 @@ assert(

[GitHub] eric-haibin-lin closed issue #10950: The negative samples shall be other classes?

2018-05-16 Thread GitBox
eric-haibin-lin closed issue #10950: The negative samples shall be other classes? URL: https://github.com/apache/incubator-mxnet/issues/10950 This is an automated message from the Apache Git Service. To respond to the messag

[incubator-mxnet] branch master updated: Sampling negative samples other classes only (#10980)

2018-05-16 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 632f514 Sampling negative samples othe

[GitHub] eric-haibin-lin closed pull request #10980: Sampling negative samples other classes only

2018-05-16 Thread GitBox
eric-haibin-lin closed pull request #10980: Sampling negative samples other classes only URL: https://github.com/apache/incubator-mxnet/pull/10980 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] chaoyuaw commented on issue #10980: Sampling negative samples other classes only

2018-05-16 Thread GitBox
chaoyuaw commented on issue #10980: Sampling negative samples other classes only URL: https://github.com/apache/incubator-mxnet/pull/10980#issuecomment-389737007 Thank you @jonbakerfish ! This PR looks good to me. This is an

[GitHub] zhanghang1989 commented on issue #10536: [MXNET-317] Add Data Parallel

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10536: [MXNET-317] Add Data Parallel URL: https://github.com/apache/incubator-mxnet/pull/10536#issuecomment-389736213 I have finished editing this repo. Could you start reviewing? @eric-haibin-lin @piiswrong Please see the deployed docs http://mxnet-ci-doc

[GitHub] anirudhacharya closed pull request #10909: ONNX Documentation change.

2018-05-16 Thread GitBox
anirudhacharya closed pull request #10909: ONNX Documentation change. URL: https://github.com/apache/incubator-mxnet/pull/10909 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] anirudhacharya commented on issue #10909: ONNX Documentation change.

2018-05-16 Thread GitBox
anirudhacharya commented on issue #10909: ONNX Documentation change. URL: https://github.com/apache/incubator-mxnet/pull/10909#issuecomment-389736048 included in this PR - https://github.com/apache/incubator-mxnet/pull/10512 T

[incubator-mxnet] branch master updated: [MXNET-309] [ONNX-MXNet] Model Metadata API (#10512)

2018-05-16 Thread anirudh2290
This is an automated email from the ASF dual-hosted git repository. anirudh2290 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 7641759 [MXNET-309] [ONNX-MXNet]

[GitHub] anirudh2290 closed pull request #10512: [MXNET-309] [ONNX-MXNet] Model Metadata API

2018-05-16 Thread GitBox
anirudh2290 closed pull request #10512: [MXNET-309] [ONNX-MXNet] Model Metadata API URL: https://github.com/apache/incubator-mxnet/pull/10512 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] mrkumar83 commented on issue #10957: Make inner transform activation configurable for LSTMCell

2018-05-16 Thread GitBox
mrkumar83 commented on issue #10957: Make inner transform activation configurable for LSTMCell URL: https://github.com/apache/incubator-mxnet/pull/10957#issuecomment-389722273 Added parameters, recurrent_activation and activation. ---

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-05-16 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 87b677d Bump the publish ti

[GitHub] phoenixbai opened a new issue #10981: build ends with error : elemwise_binary_op-inl.h:78:3574: error: expected primary-expression before ‘template’

2018-05-16 Thread GitBox
phoenixbai opened a new issue #10981: build ends with error : elemwise_binary_op-inl.h:78:3574: error: expected primary-expression before ‘template’ URL: https://github.com/apache/incubator-mxnet/issues/10981 ## Description I tried to build from source, and it exits with error below:

[GitHub] chinakook commented on issue #10972: Gluon's PReLU is very slow and a fix to it

2018-05-16 Thread GitBox
chinakook commented on issue #10972: Gluon's PReLU is very slow and a fix to it URL: https://github.com/apache/incubator-mxnet/issues/10972#issuecomment-389720576 Yes, I investigated the leakyrelu-inl.h source code. There are indeed a broadcast operation when the shape of param 'alpha' is

[GitHub] xinyu-intel commented on issue #10613: Add Windows MKLDNN Building Instruction

2018-05-16 Thread GitBox
xinyu-intel commented on issue #10613: Add Windows MKLDNN Building Instruction URL: https://github.com/apache/incubator-mxnet/pull/10613#issuecomment-389716125 @zheng-da @marcoabreu hi, please help review this pr. Thanks! Thi

[GitHub] jonbakerfish commented on issue #10950: The negative samples shall be other classes?

2018-05-16 Thread GitBox
jonbakerfish commented on issue #10950: The negative samples shall be other classes? URL: https://github.com/apache/incubator-mxnet/issues/10950#issuecomment-389712212 Hi @chaoyuaw , a PR is created https://github.com/apache/incubator-mxnet/pull/10980. Please have a look. Thanks. --

[GitHub] jonbakerfish opened a new pull request #10980: Sampling negative samples other classes only

2018-05-16 Thread GitBox
jonbakerfish opened a new pull request #10980: Sampling negative samples other classes only URL: https://github.com/apache/incubator-mxnet/pull/10980 ## Description ## The original code will have a chance to sample negative samples from the same class of the anchors ---

[GitHub] aaronmarkham commented on issue #10978: removed script tags that are being interpreted as html

2018-05-16 Thread GitBox
aaronmarkham commented on issue #10978: removed script tags that are being interpreted as html URL: https://github.com/apache/incubator-mxnet/pull/10978#issuecomment-389710197 FYI, local builds show that the page is being interpreted just fine and tags are being properly escaped and even r

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-389709407 @piiswrong @zhreshold I have added the unit tests. Please see the updates. Thanks! ---

[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389707273 @zheng-da Could you add more descriptions (or change title) in order to make the PR readable? please try the case a3c, `const mkldnn::memory

[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389707273 @zheng-da Could you add more descriptions (or change title) in order to make the PR readable? please try the case a3c, GetMKLDNNData will re

[GitHub] pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
pengzhao-intel commented on issue #10979: Fix bugs in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10979#issuecomment-389707273 @zheng-da Could you add more descriptions (or change title) in order to make the PR readable?

[GitHub] azai91 commented on issue #10836: mxnet-mkldnn(v1.2.0) to use whole CPU cores on machines without hyperthreading

2018-05-16 Thread GitBox
azai91 commented on issue #10836: mxnet-mkldnn(v1.2.0) to use whole CPU cores on machines without hyperthreading URL: https://github.com/apache/incubator-mxnet/issues/10836#issuecomment-389704315 Is there any issue with just using the following to get the number of cores? ``` #in

[GitHub] yifeim commented on a change in pull request #10946: Remove kvstore calls from FM example

2018-05-16 Thread GitBox
yifeim commented on a change in pull request #10946: Remove kvstore calls from FM example URL: https://github.com/apache/incubator-mxnet/pull/10946#discussion_r188799809 ## File path: example/sparse/factorization_machine/train.py ## @@ -75,6 +76,16 @@ assert(args.data

[GitHub] azai91 commented on issue #10836: mxnet-mkldnn(v1.2.0) to use whole CPU cores on machines without hyperthreading

2018-05-16 Thread GitBox
azai91 commented on issue #10836: mxnet-mkldnn(v1.2.0) to use whole CPU cores on machines without hyperthreading URL: https://github.com/apache/incubator-mxnet/issues/10836#issuecomment-389704315 Is there any issue with just using the following to get the number of cores? ``` #in

[GitHub] zheng-da opened a new pull request #10979: Fix bugs in MKLDNN.

2018-05-16 Thread GitBox
zheng-da opened a new pull request #10979: Fix bugs in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10979 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR

[GitHub] ThomasDelteil commented on issue #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on issue #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial URL: https://github.com/apache/incubator-mxnet/pull/10959#issuecomment-389695869 @indhub Thanks for the review! I have updated accordingly I have linked to 2 fine-tuning tutorials which co

[GitHub] ThomasDelteil commented on issue #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on issue #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial URL: https://github.com/apache/incubator-mxnet/pull/10959#issuecomment-389695869 @indhub Thanks for the review! I have updated accordingly I have linked to 2 fine-tuning tutorials which co

[GitHub] indhub commented on a change in pull request #10956: [MXNET-307] Fix flaky tutorial tests from CI

2018-05-16 Thread GitBox
indhub commented on a change in pull request #10956: [MXNET-307] Fix flaky tutorial tests from CI URL: https://github.com/apache/incubator-mxnet/pull/10956#discussion_r188796904 ## File path: docs/tutorials/python/predict_image.md ## @@ -1,33 +1,28 @@ # Predict with pre-t

[GitHub] indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial

2018-05-16 Thread GitBox
indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial URL: https://github.com/apache/incubator-mxnet/pull/10959#discussion_r188791651 ## File path: docs/tutorials/gluon/pretrained_models.md ## @@ -0,0 +1,373 @@ + +# Usi

[GitHub] indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial

2018-05-16 Thread GitBox
indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial URL: https://github.com/apache/incubator-mxnet/pull/10959#discussion_r188788759 ## File path: docs/tutorials/gluon/pretrained_models.md ## @@ -0,0 +1,373 @@ + +# Usi

[GitHub] indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial

2018-05-16 Thread GitBox
indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial URL: https://github.com/apache/incubator-mxnet/pull/10959#discussion_r188792363 ## File path: docs/tutorials/gluon/pretrained_models.md ## @@ -0,0 +1,373 @@ + +# Usi

[GitHub] indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial

2018-05-16 Thread GitBox
indhub commented on a change in pull request #10959: [MXNET-423] Gluon Model Zoo Pre Trained Model tutorial URL: https://github.com/apache/incubator-mxnet/pull/10959#discussion_r188791808 ## File path: docs/tutorials/gluon/pretrained_models.md ## @@ -0,0 +1,373 @@ + +# Usi

[GitHub] aaronmarkham opened a new pull request #10978: removed script tags that are being interpreted as html

2018-05-16 Thread GitBox
aaronmarkham opened a new pull request #10978: removed script tags that are being interpreted as html URL: https://github.com/apache/incubator-mxnet/pull/10978 ## Description ## Minor bug fix for docs rendered on the site. Markdown with tags in them are being converted to working

[GitHub] zhanghang1989 commented on a change in pull request #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on a change in pull request #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#discussion_r188783355 ## File path: tests/python/unittest/test_operator.py ## @@ -6018,6 +6019,24 @@ def test_context_num_gpus():

[GitHub] zhreshold commented on a change in pull request #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhreshold commented on a change in pull request #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#discussion_r188774784 ## File path: src/operator/contrib/roi_align.cu ## @@ -0,0 +1,496 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] zhreshold commented on a change in pull request #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhreshold commented on a change in pull request #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#discussion_r188775054 ## File path: src/operator/contrib/roi_align.cu ## @@ -0,0 +1,496 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] zhreshold commented on a change in pull request #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhreshold commented on a change in pull request #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#discussion_r188777217 ## File path: tests/python/unittest/test_operator.py ## @@ -6018,6 +6019,24 @@ def test_context_num_gpus():

[GitHub] ankkhedia commented on issue #10969: Mxnet dynamic graphs achieve scoure code

2018-05-16 Thread GitBox
ankkhedia commented on issue #10969: Mxnet dynamic graphs achieve scoure code URL: https://github.com/apache/incubator-mxnet/issues/10969#issuecomment-389655622 Hi @qichaotang Could you please confirm if the query got answered and close the issue. @sandeep-krishnamurthy Please t

[GitHub] marcoabreu commented on issue #10961: [MXNET-10896] [MXNET-10901] Fix test_sparse_mathematical_core sensitivity to scipy v1.1

2018-05-16 Thread GitBox
marcoabreu commented on issue #10961: [MXNET-10896] [MXNET-10901] Fix test_sparse_mathematical_core sensitivity to scipy v1.1 URL: https://github.com/apache/incubator-mxnet/pull/10961#issuecomment-389663152 Sorry, on the phone right now. It's in CI/docker/install and then in CentOS and U

[GitHub] ankkhedia commented on issue #10948: get stuck with subprocess in multithread

2018-05-16 Thread GitBox
ankkhedia commented on issue #10948: get stuck with subprocess in multithread URL: https://github.com/apache/incubator-mxnet/issues/10948#issuecomment-389662914 @sandeep-krishnamurthy Could you please tag issue as python and bug -

[GitHub] ankkhedia commented on issue #10964: linalg_potri() Error: linalg_impl.h:606: Check failed: ret == 0 (3 vs. 0) spotri failed in lapack on cpu.

2018-05-16 Thread GitBox
ankkhedia commented on issue #10964: linalg_potri() Error: linalg_impl.h:606: Check failed: ret == 0 (3 vs. 0) spotri failed in lapack on cpu. URL: https://github.com/apache/incubator-mxnet/issues/10964#issuecomment-389662341 @sxksxy Hope your issue got resolved. @sandeep-krishnamurthy

[GitHub] ankkhedia commented on issue #10952: The params can't be saved as expected when using --model-prefix for all the training script belonging to example/image-classification

2018-05-16 Thread GitBox
ankkhedia commented on issue #10952: The params can't be saved as expected when using --model-prefix for all the training script belonging to example/image-classification URL: https://github.com/apache/incubator-mxnet/issues/10952#issuecomment-389661435 @sandeep-krishnamurthy Could you pl

[GitHub] ankkhedia commented on issue #10950: The negative samples shall be other classes?

2018-05-16 Thread GitBox
ankkhedia commented on issue #10950: The negative samples shall be other classes? URL: https://github.com/apache/incubator-mxnet/issues/10950#issuecomment-389660473 @sandeep-krishnamurthy Could you please tag this as Call for Contribution --

[GitHub] ankkhedia commented on issue #10965: How to show the ctc loss?

2018-05-16 Thread GitBox
ankkhedia commented on issue #10965: How to show the ctc loss? URL: https://github.com/apache/incubator-mxnet/issues/10965#issuecomment-389659600 @maybepossible , Could you please post your question on discuss.mxnet.io ? We handle questions through that forum. @sandeep-krishnamurthy

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-389658263 @piiswrong @zhreshold Could you please review this PR for adapting ROI Aligh from Caffe2. Thanks!

[GitHub] ankkhedia commented on issue #10967: Is the doc for launch.py parameters outdated?

2018-05-16 Thread GitBox
ankkhedia commented on issue #10967: Is the doc for launch.py parameters outdated? URL: https://github.com/apache/incubator-mxnet/issues/10967#issuecomment-389657260 @sandeep-krishnamurthy Could you please tag this as Question and Documentation ---

[GitHub] ankkhedia commented on issue #10968: Discuss about NDArray::Save and NDArray::Load

2018-05-16 Thread GitBox
ankkhedia commented on issue #10968: Discuss about NDArray::Save and NDArray::Load URL: https://github.com/apache/incubator-mxnet/issues/10968#issuecomment-389656689 @sandeep-krishnamurthy Could you please tag this issue as Discussion and NDArray -

[GitHub] marcoabreu commented on issue #10975: avoid importing docker_cache if feature is not used

2018-05-16 Thread GitBox
marcoabreu commented on issue #10975: avoid importing docker_cache if feature is not used URL: https://github.com/apache/incubator-mxnet/pull/10975#issuecomment-389656578 Please fill in the template This is an automated mess

[GitHub] ankkhedia commented on issue #10969: Mxnet dynamic graphs achieve scoure code

2018-05-16 Thread GitBox
ankkhedia commented on issue #10969: Mxnet dynamic graphs achieve scoure code URL: https://github.com/apache/incubator-mxnet/issues/10969#issuecomment-389655622 Hi @qichaotang Could you please confirm if they query got answered and close the issue. @sandeep-krishnamurthy Please

[GitHub] reminisce commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

2018-05-16 Thread GitBox
reminisce commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r188752161 ## File path: include/mxnet/c_api.h ## @@ -1423,13 +1423,15 @@ MXNET_DLL int MXSymbolIn

[GitHub] DickJC123 commented on issue #10961: [MXNET-10896] [MXNET-10901] Fix test_sparse_mathematical_core sensitivity to scipy v1.1

2018-05-16 Thread GitBox
DickJC123 commented on issue #10961: [MXNET-10896] [MXNET-10901] Fix test_sparse_mathematical_core sensitivity to scipy v1.1 URL: https://github.com/apache/incubator-mxnet/pull/10961#issuecomment-389644489 A search for scipy in the MXNet repo shows many pip installs that don't set the vers

[GitHub] DickJC123 opened a new issue #10977: test_kvstore_gpu.py:test_rsp_push_pull fails when run on a system with only one GPU

2018-05-16 Thread GitBox
DickJC123 opened a new issue #10977: test_kvstore_gpu.py:test_rsp_push_pull fails when run on a system with only one GPU URL: https://github.com/apache/incubator-mxnet/issues/10977 ## Description The test test_rsp_push_pull fails when it attempts to create and use context mx.gpu(1) even

[GitHub] szha commented on a change in pull request #10311: [MXNET-107]Fused GRU implementation for CPU

2018-05-16 Thread GitBox
szha commented on a change in pull request #10311: [MXNET-107]Fused GRU implementation for CPU URL: https://github.com/apache/incubator-mxnet/pull/10311#discussion_r188739189 ## File path: python/mxnet/gluon/rnn/rnn_layer.py ## @@ -186,11 +186,13 @@ def forward(self, input

[GitHub] zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align

2018-05-16 Thread GitBox
zhanghang1989 commented on issue #10852: [MXNET-411] Add ROI Align URL: https://github.com/apache/incubator-mxnet/pull/10852#issuecomment-389631589 The docs are generated here http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-10852/9/api/python/ndarray/contrib.html?highlight=roi#

[GitHub] mbaijal commented on a change in pull request #10938: Add Apachev2 License for contrib

2018-05-16 Thread GitBox
mbaijal commented on a change in pull request #10938: Add Apachev2 License for contrib URL: https://github.com/apache/incubator-mxnet/pull/10938#discussion_r188735823 ## File path: src/operator/contrib/psroi_pooling-inl.h ## @@ -1,7 +1,23 @@ +/* + * Licensed to the Apache

[GitHub] szha commented on issue #10972: Gluon's PReLU is very slow and a fix to it

2018-05-16 Thread GitBox
szha commented on issue #10972: Gluon's PReLU is very slow and a fix to it URL: https://github.com/apache/incubator-mxnet/issues/10972#issuecomment-389624639 These two implementations are different in terms of the number of parameters. The performance hit likely comes from the broadcast op

[GitHub] sxksxy commented on issue #10964: linalg_potri() Error: linalg_impl.h:606: Check failed: ret == 0 (3 vs. 0) spotri failed in lapack on cpu.

2018-05-16 Thread GitBox
sxksxy commented on issue #10964: linalg_potri() Error: linalg_impl.h:606: Check failed: ret == 0 (3 vs. 0) spotri failed in lapack on cpu. URL: https://github.com/apache/incubator-mxnet/issues/10964#issuecomment-389623976 thanks for your reply! @asmushetzel @piiswrong --

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188728964 ## File path: example/distributed_training/README.md ## @@ -0,0 +1,231 @@ +# Distributed Tr

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188730608 ## File path: example/distributed_training/README.md ## @@ -0,0 +1,231 @@ +# Distributed Tr

[GitHub] szha closed pull request #10940: [WIP] Fused LSTM Cell

2018-05-16 Thread GitBox
szha closed pull request #10940: [WIP] Fused LSTM Cell URL: https://github.com/apache/incubator-mxnet/pull/10940 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (f

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188728690 ## File path: example/distributed_training/README.md ## @@ -0,0 +1,231 @@ +# Distributed Tr

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188728190 ## File path: example/distributed_training/README.md ## @@ -0,0 +1,231 @@ +# Distributed Tr

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188729724 ## File path: example/distributed_training/README.md ## @@ -0,0 +1,231 @@ +# Distributed Tr

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188730509 ## File path: example/distributed_training/README.md ## @@ -0,0 +1,231 @@ +# Distributed Tr

[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188727936 ## File path: docs/tutorials/index.md ## @@ -38,6 +38,7 @@ Select API:  * [Visual Ques

[GitHub] szha commented on issue #10940: [WIP] Fused LSTM Cell

2018-05-16 Thread GitBox
szha commented on issue #10940: [WIP] Fused LSTM Cell URL: https://github.com/apache/incubator-mxnet/pull/10940#issuecomment-389623496 Considering the trade-off with flexibility, I think the performance gain (even if I fix the loss of performance on parameter concatenation) will be margina

[GitHub] asmushetzel commented on issue #10964: linalg_potri() Error: linalg_impl.h:606: Check failed: ret == 0 (3 vs. 0) spotri failed in lapack on cpu.

2018-05-16 Thread GitBox
asmushetzel commented on issue #10964: linalg_potri() Error: linalg_impl.h:606: Check failed: ret == 0 (3 vs. 0) spotri failed in lapack on cpu. URL: https://github.com/apache/incubator-mxnet/issues/10964#issuecomment-389622020 potri computes the inverse based on the Cholesky decomposition

[GitHub] marcoabreu closed issue #10960: CI bug R-CPU no space left on device

2018-05-16 Thread GitBox
marcoabreu closed issue #10960: CI bug R-CPU no space left on device URL: https://github.com/apache/incubator-mxnet/issues/10960 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] marcoabreu commented on issue #10960: CI bug R-CPU no space left on device

2018-05-16 Thread GitBox
marcoabreu commented on issue #10960: CI bug R-CPU no space left on device URL: https://github.com/apache/incubator-mxnet/issues/10960#issuecomment-389619596 This was before autoscaling. This is unrelated - our docker images filled up the disk. Should be solved now ---

[GitHub] ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM URL: https://github.com/apache/incubator-mxnet/pull/10900#discussion_r188721635 ## File path: docs/tutorials/vision/cnn_visualization.md ## @@ -0,0

[GitHub] ThomasDelteil commented on issue #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM

2018-05-16 Thread GitBox
ThomasDelteil commented on issue #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM URL: https://github.com/apache/incubator-mxnet/pull/10900#issuecomment-389617143 Awesome tutorial @indhub! Makes me wonder if the visualization could make its way to the contrib packag

[GitHub] ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM URL: https://github.com/apache/incubator-mxnet/pull/10900#discussion_r188717579 ## File path: docs/tutorials/vision/cnn_visualization.md ## @@ -0,0

[GitHub] ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM URL: https://github.com/apache/incubator-mxnet/pull/10900#discussion_r188720460 ## File path: docs/tutorials/vision/cnn_visualization.md ## @@ -0,0

[GitHub] ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM URL: https://github.com/apache/incubator-mxnet/pull/10900#discussion_r188720295 ## File path: docs/tutorials/vision/cnn_visualization.md ## @@ -0,0

[GitHub] ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM

2018-05-16 Thread GitBox
ThomasDelteil commented on a change in pull request #10900: [MXNET-414] Tutorial on visualizing CNN decisions using Grad-CAM URL: https://github.com/apache/incubator-mxnet/pull/10900#discussion_r188724209 ## File path: docs/tutorials/vision/cnn_visualization.md ## @@ -0,0

  1   2   >