[GitHub] [pinot] vvivekiyer opened a new pull request #8446: Add DocIdSetOprator to explain plan

vvivekiyer opened a new pull request #8446: URL: https://github.com/apache/pinot/pull/8446 ## Description The current implementation of explain plan skips creating an entry for DocIdSetOperator. This PR adds it. Testing: * Modified ExplainPlanQueriesTest to reflect the change

[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r839286532 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java ## @@ -75,9 +94,26 @

[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r839292161 ## File path: pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java ## @@ -58,25 +60,37 @@ @JsonIgnoreProperties(ignoreUn

[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r839295778 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceTagPoolSelector.java ## @@ -48,52 +51,108

[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r839303449 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java ## @@ -51,16 +52,34

[GitHub] [pinot] siddharthteotia commented on pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

siddharthteotia commented on pull request #8441: URL: https://github.com/apache/pinot/pull/8441#issuecomment-1084240228 @jasperjiaguo you might also want to review this PR considering you are changing similar code for another purpose -- This is an automated message from the Apache Git Se

[GitHub] [pinot] codecov-commenter commented on pull request #8446: Add DocIdSetOprator to explain plan

codecov-commenter commented on pull request #8446: URL: https://github.com/apache/pinot/pull/8446#issuecomment-1084244026 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8446?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] richardstartin commented on a change in pull request #8343: Timestamp type index

richardstartin commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839328979 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -563,6 +569,55 @@ private Broker

[GitHub] [pinot] richardstartin commented on a change in pull request #8343: Timestamp type index

richardstartin commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839329982 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -563,6 +569,55 @@ private Broker

[GitHub] [pinot] xiangfu0 opened a new pull request #8447: Make codestyle keep line break when reformat the code

xiangfu0 opened a new pull request #8447: URL: https://github.com/apache/pinot/pull/8447 ## Description So it won't join lines when reformating a file. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[GitHub] [pinot] xiangfu0 merged pull request #8447: Make codestyle keep line break when reformat the code

xiangfu0 merged pull request #8447: URL: https://github.com/apache/pinot/pull/8447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated: Make codestyle keep line break when reformat the code (#8447)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c6f0762 Make codestyle keep line break when ref

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839342126 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -563,6 +569,55 @@ private BrokerRespon

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839342393 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -563,6 +569,55 @@ private BrokerRespon

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839344775 ## File path: pinot-common/src/test/java/org/apache/pinot/common/request/RequestContextUtilsTest.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to the Apache

Error while running notifications feature from .asf.yaml in pinot-site!

An error occurred while running notifications feature in .asf.yaml!: Invalid notification target 'notificati...@pinot.apache.org'. Must be a valid @pinot.apache.org list! - To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

svn commit: r53476 - /release/pinot/apache-pinot-0.9.1/

Author: xiangfu Date: Thu Mar 31 09:29:30 2022 New Revision: 53476 Log: Remove release pinot 0.9.1 Removed: release/pinot/apache-pinot-0.9.1/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional com

svn commit: r53477 - /release/pinot/apache-pinot-0.9.2/

Author: xiangfu Date: Thu Mar 31 09:29:36 2022 New Revision: 53477 Log: Remove release pinot 0.9.2 Removed: release/pinot/apache-pinot-0.9.2/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional com

svn commit: r53478 - /release/pinot/apache-pinot-0.9.3/

Author: xiangfu Date: Thu Mar 31 09:29:42 2022 New Revision: 53478 Log: Remove release pinot 0.9.3 Removed: release/pinot/apache-pinot-0.9.3/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional com

[GitHub] [pinot] richardstartin commented on pull request #8343: Timestamp type index

richardstartin commented on pull request #8343: URL: https://github.com/apache/pinot/pull/8343#issuecomment-1084374222 Thinking about it more, the time transforms are indeed costly so storing the values makes sense for this use case, which can be extended to many time conversion functions.

[GitHub] [pinot] richardstartin commented on a change in pull request #8384: Implement Native Text Operator

richardstartin commented on a change in pull request #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r839477249 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -170,17 +

[GitHub] [pinot] richardstartin commented on a change in pull request #8384: Implement Native Text Operator

richardstartin commented on a change in pull request #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r839480217 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/nativefst/NativeTextIndexCreator.java ## @@ -0,0 +1,173 @@ +/**

[GitHub] [pinot] siddharthteotia commented on issue #8418: Expose BigDecimal as a Pinot data type

siddharthteotia commented on issue #8418: URL: https://github.com/apache/pinot/issues/8418#issuecomment-1084678094 Hi @KKcorps - I will take a look at the PR today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8412: add pinot-query-runtime

codecov-commenter edited a comment on pull request #8412: URL: https://github.com/apache/pinot/pull/8412#issuecomment-1079168510 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8412?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] kmozaid commented on pull request #8255: Added multi column partitioning for offline table

kmozaid commented on pull request #8255: URL: https://github.com/apache/pinot/pull/8255#issuecomment-108483 Hi @Jackie-Jiang Could you please check this PR if it can be merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] Jackie-Jiang commented on issue #8437: Support multiple response formats in Broker SQL API

Jackie-Jiang commented on issue #8437: URL: https://github.com/apache/pinot/issues/8437#issuecomment-1084853463 The idea is really good. Suggest making the `ResponseWriter` pluggable, and we provide some default impl -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pinot] Jackie-Jiang commented on issue #8439: helm chart and tpl for extras config.

Jackie-Jiang commented on issue #8439: URL: https://github.com/apache/pinot/issues/8439#issuecomment-1084859663 @walterddr @xiangfu0 Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pinot] Jackie-Jiang merged pull request #8448: Fix a typo in BaseBrokerRequestHandler

Jackie-Jiang merged pull request #8448: URL: https://github.com/apache/pinot/pull/8448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated (c6f0762 -> 91c9ce4)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from c6f0762 Make codestyle keep line break when reformat the code (#8447) add 91c9ce4 Fix a typo in BaseBrokerReque

[GitHub] [pinot] ashishkf opened a new issue #8449: Issue with broker timeout handling results in ArrayOutOfBoundsException

ashishkf opened a new issue #8449: URL: https://github.com/apache/pinot/issues/8449 It seems getTopRecords called from the public method finish is invoked without a read lock. We are seeing an issue where we get ArrayIndexOutOfBoundsException when running a query that involves ConcurrentI

[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r839893027 ## File path: pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitions.java ## @@ -58,25 +60,37 @@ @JsonIgnoreProperties(ignoreUn

[GitHub] [pinot] jasperjiaguo commented on a change in pull request #8036: Add new compat test cases and data (#7235)

jasperjiaguo commented on a change in pull request #8036: URL: https://github.com/apache/pinot/pull/8036#discussion_r839895888 ## File path: pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java ## @@ -72,16 +75,44 @@ public void setExpectedResultsFil

[GitHub] [pinot] jasperjiaguo commented on a change in pull request #8036: Add new compat test cases and data (#7235)

jasperjiaguo commented on a change in pull request #8036: URL: https://github.com/apache/pinot/pull/8036#discussion_r839895888 ## File path: pinot-compatibility-verifier/src/main/java/org/apache/pinot/compat/QueryOp.java ## @@ -72,16 +75,44 @@ public void setExpectedResultsFil

[pinot] branch retain-instance-sequence updated (072da30 -> 59b3fc5)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch retain-instance-sequence in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 072da30 Add retainInstancesSequence feature to table rebalance to minimize data movement between ins

[GitHub] [pinot] vvivekiyer commented on pull request #8446: Add DocIdSetOprator to explain plan

vvivekiyer commented on pull request #8446: URL: https://github.com/apache/pinot/pull/8446#issuecomment-1084976788 @siddharthteotia please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pinot] Jackie-Jiang opened a new pull request #8450: Fix the group-by reduce handling when query times out

Jackie-Jiang opened a new pull request #8450: URL: https://github.com/apache/pinot/pull/8450 Fix #8449 When broker times out, there are multiple places not handled properly: - Should check the return value of `CountDownLatch.await()` to identify if the query times out - `Futur

[GitHub] [pinot] xiangfu0 commented on issue #8439: helm chart and tpl for extras config.

xiangfu0 commented on issue #8439: URL: https://github.com/apache/pinot/issues/8439#issuecomment-1085042680 we can model users' credentials as a list then loop and add them into controller/broker/server/minion extraConfigs. -- This is an automated message from the Apache Git Service. To

[pinot] branch helix-1.0 updated (34cf23c -> 4e7bfae)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. omit 34cf23c Upgrade Helix to 1.0.2 add ebd20a4 Add commonly used math, string and date scalar functions in Pinot

[pinot] branch helix-1.0 updated (4e7bfae -> 99f17ce)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 4e7bfae Upgrade Helix to 1.0.2 add 878cf75 Update master branch with the next release pom changes (#8432)

[GitHub] [pinot] xiangfu0 opened a new pull request #8451: Rewrite PinotQuery based on expression hints at segment level

xiangfu0 opened a new pull request #8451: URL: https://github.com/apache/pinot/pull/8451 ## Description Rewrite PinotQuery based on expression hints at segment level ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Serve

[GitHub] [pinot] xiangfu0 opened a new pull request #8452: Adding min/max value for column stats during segment creation

xiangfu0 opened a new pull request #8452: URL: https://github.com/apache/pinot/pull/8452 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-incompat**, a

[GitHub] [pinot] Jackie-Jiang commented on pull request #8452: Adding missing min/max value for column stats during segment creation

Jackie-Jiang commented on pull request #8452: URL: https://github.com/apache/pinot/pull/8452#issuecomment-1085098046 Ideally we should add a test to catch the missing fields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pinot] xiangfu0 commented on pull request #8452: Adding missing min/max value for column stats during segment creation

xiangfu0 commented on pull request #8452: URL: https://github.com/apache/pinot/pull/8452#issuecomment-1085116412 > Ideally we should add a test to catch the missing fields These are newly added stats, which were missed from the previous PR: https://github.com/apache/pinot/pull/8442

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8325: [WIP] Upgrade Helix to 1.0.2 in Pinot (not ready yet)

codecov-commenter edited a comment on pull request #8325: URL: https://github.com/apache/pinot/pull/8325#issuecomment-1062639928 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8452: Adding missing min/max value for column stats during segment creation

codecov-commenter commented on pull request #8452: URL: https://github.com/apache/pinot/pull/8452#issuecomment-1085134021 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter commented on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

codecov-commenter commented on pull request #8451: URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8452: Adding missing min/max value for column stats during segment creation

codecov-commenter edited a comment on pull request #8452: URL: https://github.com/apache/pinot/pull/8452#issuecomment-1085134021 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8450: Fix the group-by reduce handling when query times out

codecov-commenter commented on pull request #8450: URL: https://github.com/apache/pinot/pull/8450#issuecomment-1085138407 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8452: Adding missing min/max value for column stats during segment creation

codecov-commenter edited a comment on pull request #8452: URL: https://github.com/apache/pinot/pull/8452#issuecomment-1085134021 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

codecov-commenter edited a comment on pull request #8451: URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

codecov-commenter edited a comment on pull request #8451: URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8452: Adding missing min/max value for column stats during segment creation

codecov-commenter edited a comment on pull request #8452: URL: https://github.com/apache/pinot/pull/8452#issuecomment-1085134021 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8452?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] xiangfu0 merged pull request #8452: Adding missing min/max value for column stats during segment creation

xiangfu0 merged pull request #8452: URL: https://github.com/apache/pinot/pull/8452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated: Adding min/max value for column stats during segment creation (#8452)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 86958b6 Adding min/max value for column stats d

[GitHub] [pinot] PrachiKhobragade commented on a change in pull request #8443: Fix ChildTraceId in multithreaded environment

PrachiKhobragade commented on a change in pull request #8443: URL: https://github.com/apache/pinot/pull/8443#discussion_r840046378 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/trace/TraceContext.java ## @@ -67,7 +68,7 @@ JsonNode toJson() { final St

[GitHub] [pinot] richardstartin opened a new issue #8453: Evaluate cheap filters before expensive filters

richardstartin opened a new issue #8453: URL: https://github.com/apache/pinot/issues/8453 The plan for the query below is extremely inefficient: ```sql select * from githubEvents where repo_name like 'FeedScale%' and type = 'PullRequestEvent' limit 100 ``` | Operator | O

[GitHub] [pinot] richardstartin commented on a change in pull request #8443: Fix ChildTraceId in multithreaded environment

richardstartin commented on a change in pull request #8443: URL: https://github.com/apache/pinot/pull/8443#discussion_r840059306 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/trace/TraceContext.java ## @@ -67,7 +68,7 @@ JsonNode toJson() { final Stri

[GitHub] [pinot] richardstartin commented on a change in pull request #8443: Fix ChildTraceId in multithreaded environment

richardstartin commented on a change in pull request #8443: URL: https://github.com/apache/pinot/pull/8443#discussion_r840059632 ## File path: pinot-core/src/test/java/org/apache/pinot/core/util/trace/TraceContextTest.java ## @@ -102,19 +102,21 @@ public void runJob() { f

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

codecov-commenter edited a comment on pull request #8451: URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8443: Fix ChildTraceId in multithreaded environment

codecov-commenter commented on pull request #8443: URL: https://github.com/apache/pinot/pull/8443#issuecomment-1085188406 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] Jackie-Jiang commented on issue #8453: Evaluate cheap filters before expensive filters

Jackie-Jiang commented on issue #8453: URL: https://github.com/apache/pinot/issues/8453#issuecomment-1085194696 The operator name is a little bit misleading. For this query, we will first evaluate the `type='PullRequestEvent'` predicate using inverted index, and get a bitmap; then pass the

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

codecov-commenter edited a comment on pull request #8451: URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8443: Fix ChildTraceId in multithreaded environment

codecov-commenter edited a comment on pull request #8443: URL: https://github.com/apache/pinot/pull/8443#issuecomment-1085188406 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8325: [WIP] Upgrade Helix to 1.0.2 in Pinot (not ready yet)

codecov-commenter edited a comment on pull request #8325: URL: https://github.com/apache/pinot/pull/8325#issuecomment-1062639928 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

codecov-commenter edited a comment on pull request #8451: URL: https://github.com/apache/pinot/pull/8451#issuecomment-1085134336 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on pull request #8446: Add DocIdSetOprator to explain plan

Jackie-Jiang commented on pull request #8446: URL: https://github.com/apache/pinot/pull/8446#issuecomment-1085207237 @amrishlal Did you intentionally skip the `DocIdSetOperator`, or that one missing unexpectedly? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] Jackie-Jiang merged pull request #8450: Fix the group-by reduce handling when query times out

Jackie-Jiang merged pull request #8450: URL: https://github.com/apache/pinot/pull/8450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] Jackie-Jiang closed issue #8449: Issue with broker timeout handling results in ArrayOutOfBoundsException

Jackie-Jiang closed issue #8449: URL: https://github.com/apache/pinot/issues/8449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated: Fix the group-by reduce handling when query times out (#8450)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8dcb255 Fix the group-by reduce handling when qu

[GitHub] [pinot] PrachiKhobragade commented on a change in pull request #8443: Fix ChildTraceId in multithreaded environment

PrachiKhobragade commented on a change in pull request #8443: URL: https://github.com/apache/pinot/pull/8443#discussion_r840091721 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/trace/TraceContext.java ## @@ -67,7 +68,7 @@ JsonNode toJson() { final St

[GitHub] [pinot] navina opened a new pull request #8454: Adding a constructor override to PullRequestMergedEventsStream

navina opened a new pull request #8454: URL: https://github.com/apache/pinot/pull/8454 ## Description Adding a constructor override that accepts a `File` object for schema file, instead of file name -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pinot] amrishlal commented on pull request #8446: Add DocIdSetOprator to explain plan

amrishlal commented on pull request #8446: URL: https://github.com/apache/pinot/pull/8446#issuecomment-1085214751 > @amrishlal Did you intentionally skip the `DocIdSetOperator`, or that one missing unexpectedly? Yes it was skipped intentionally but there wasn't any strong reason behi

[GitHub] [pinot] amrishlal edited a comment on pull request #8446: Add DocIdSetOprator to explain plan

amrishlal edited a comment on pull request #8446: URL: https://github.com/apache/pinot/pull/8446#issuecomment-1085214751 > @amrishlal Did you intentionally skip the `DocIdSetOperator`, or that one missing unexpectedly? Yes it was skipped intentionally but there wasn't any strong reas

[GitHub] [pinot] Jackie-Jiang commented on issue #8423: The race condition that TableDataManager is removed during segment download because of incorrect segment count.

Jackie-Jiang commented on issue #8423: URL: https://github.com/apache/pinot/issues/8423#issuecomment-1085217649 @jadami10 @mcvsubbu The root cause is the effect of combining #6608 and #7961 When #6608 is introduced, there is no side effect of closing and recreating the table data manager

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8445: add metric for largest segment size

Jackie-Jiang commented on a change in pull request #8445: URL: https://github.com/apache/pinot/pull/8445#discussion_r840098406 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java ## @@ -70,6 +70,8 @@ @Deprecated // Instead use TABLE

[GitHub] [pinot] ashishkf commented on a change in pull request #8450: Fix the group-by reduce handling when query times out

ashishkf commented on a change in pull request #8450: URL: https://github.com/apache/pinot/pull/8450#discussion_r840101972 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/BrokerReduceServiceTest.java ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8445: add metric for largest segment size

Jackie-Jiang commented on a change in pull request #8445: URL: https://github.com/apache/pinot/pull/8445#discussion_r840102621 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java ## @@ -99,6 +99,13 @@ public TableSizeDetails getTa

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8450: Fix the group-by reduce handling when query times out

Jackie-Jiang commented on a change in pull request #8450: URL: https://github.com/apache/pinot/pull/8450#discussion_r840105562 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/reduce/BrokerReduceServiceTest.java ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Ap

[GitHub] [pinot] codecov-commenter commented on pull request #8454: Adding a constructor override to PullRequestMergedEventsStream

codecov-commenter commented on pull request #8454: URL: https://github.com/apache/pinot/pull/8454#issuecomment-1085231714 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] vvivekiyer commented on pull request #8446: Add DocIdSetOprator to explain plan

vvivekiyer commented on pull request #8446: URL: https://github.com/apache/pinot/pull/8446#issuecomment-1085231884 Just wanted to add - based on the discussion [here](https://github.com/apache/pinot/pull/7568/files#diff-1dcc87e413bf4799252d074cd6b263e5cfc6d3b79b3b5390ea5de5949c9b1a6e) (Doc

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8454: Adding a constructor override to PullRequestMergedEventsStream

codecov-commenter edited a comment on pull request #8454: URL: https://github.com/apache/pinot/pull/8454#issuecomment-1085231714 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8443: Fix ChildTraceId in multithreaded environment

codecov-commenter edited a comment on pull request #8443: URL: https://github.com/apache/pinot/pull/8443#issuecomment-1085188406 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] Jackie-Jiang commented on pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

Jackie-Jiang commented on pull request #8441: URL: https://github.com/apache/pinot/pull/8441#issuecomment-1085241390 I don't follow why we need to store the pool to instances mapping in the ZK. Essentially what we need is to pass the existing instance partitions to the `InstanceReplicaGrou

[GitHub] [pinot] Jackie-Jiang commented on pull request #8255: Added multi column partitioning for offline table

Jackie-Jiang commented on pull request #8255: URL: https://github.com/apache/pinot/pull/8255#issuecomment-1085245168 @kmozaid This is a great feature, and I want to ensure it can work end-to-end. With the `SegmentPrunerTest`, it ensures the pruner itself works, but multiple partitioning co

[GitHub] [pinot] siddharthteotia merged pull request #8446: Add DocIdSetOprator to explain plan

siddharthteotia merged pull request #8446: URL: https://github.com/apache/pinot/pull/8446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[pinot] branch master updated: Add DocIdSetOprator to explain plan (#8446)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8a7a64d Add DocIdSetOprator to explain plan

[GitHub] [pinot] richardstartin commented on issue #8453: Evaluate cheap filters before expensive filters

richardstartin commented on issue #8453: URL: https://github.com/apache/pinot/issues/8453#issuecomment-1085256163 Yes, this is quite misleading, either the plan should reflect the linking of filters done in AndDocIdSet or the code should be refactored to make it easier to describe the exec

[GitHub] [pinot] Jackie-Jiang commented on pull request #8443: Fix ChildTraceId in multithreaded environment

Jackie-Jiang commented on pull request #8443: URL: https://github.com/apache/pinot/pull/8443#issuecomment-1085256595 Just checked the code: `Trace` is attached to the scheduler thread, but multiple worker threads can register child Traces under the same parent Trace, so the fix is valid

[GitHub] [pinot] snleee merged pull request #8443: Fix ChildTraceId in multithreaded environment

snleee merged pull request #8443: URL: https://github.com/apache/pinot/pull/8443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[pinot] branch master updated (8a7a64d -> 94a869b)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 8a7a64d Add DocIdSetOprator to explain plan (#8446) add 94a869b Fix ChildTraceId when using multiple child threa

[GitHub] [pinot] sajjad-moradi opened a new pull request #8455: Make the PR template simpler

sajjad-moradi opened a new pull request #8455: URL: https://github.com/apache/pinot/pull/8455 Nowadays people usually don't follow the current PR template. They either delete the whole thing and add the description text, or they add the description on top of the prefilled template.

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8451: Rewrite PinotQuery based on expression hints at instance/segment level

Jackie-Jiang commented on a change in pull request #8451: URL: https://github.com/apache/pinot/pull/8451#discussion_r840124465 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/RangePredicate.java ## @@ -138,4 +138,12 @@ public String t

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8255: Added multi column partitioning for offline table

codecov-commenter edited a comment on pull request #8255: URL: https://github.com/apache/pinot/pull/8255#issuecomment-1053995197 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8255?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] jtao15 commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jtao15 commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r840126785 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java ## @@ -145,6 +145,8 @@ public RebalanceRe

[GitHub] [pinot] npawar merged pull request #8454: Adding a constructor override to PullRequestMergedEventsStream

npawar merged pull request #8454: URL: https://github.com/apache/pinot/pull/8454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[pinot] branch master updated: adding a constructor override (#8454)

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d454acd adding a constructor override (#8454)

[GitHub] [pinot] kmozaid commented on pull request #8255: Added multi column partitioning for offline table

kmozaid commented on pull request #8255: URL: https://github.com/apache/pinot/pull/8255#issuecomment-1085336560 Thanks @Jackie-Jiang , Sure, Let me add integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pinot] jackjlli commented on a change in pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on a change in pull request #8441: URL: https://github.com/apache/pinot/pull/8441#discussion_r840196170 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java ## @@ -145,6 +145,8 @@ public Rebalance

[GitHub] [pinot] jackjlli commented on pull request #8441: Add retainInstancesSequence feature to table rebalance to minimize data movement between instances

jackjlli commented on pull request #8441: URL: https://github.com/apache/pinot/pull/8441#issuecomment-1085383347 > I don't follow why we need to store the pool to instances mapping in the ZK. Essentially what we need is to pass the existing instance partitions to the `InstanceReplicaGroupP

[GitHub] [pinot] atris commented on a change in pull request #8384: Implement Native Text Operator

atris commented on a change in pull request #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r840221406 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/text/NativeTextIndexReader.java ## @@ -0,0 +1,141 @@ +/*

  1   2   >