Re: [I] Producer callback is unable to utilise python raise to propagate errors [pulsar-client-python]

2023-12-27 Thread via GitHub
Samreay commented on issue #184: URL: https://github.com/apache/pulsar-client-python/issues/184#issuecomment-1870915794 So one of the goals for getting async working properly for my use case was that is seems the python producer can do batching but only with `send_async` and not `send`.

Re: [I] Producer callback is unable to utilise python raise to propagate errors [pulsar-client-python]

2023-12-27 Thread via GitHub
BewareMyPower commented on issue #184: URL: https://github.com/apache/pulsar-client-python/issues/184#issuecomment-1870909386 Did you mean the batch receive? Currently there is no good way in Pulsar to receive a batch as a whole. There is a `batchReceive` API in Java client and C++ client

Re: [I] Producer callback is unable to utilise python raise to propagate errors [pulsar-client-python]

2023-12-27 Thread via GitHub
Samreay commented on issue #184: URL: https://github.com/apache/pulsar-client-python/issues/184#issuecomment-1870896735 A bit more context: Right now, if I have 100 messages to send and want actual error handling to exist, I either use my workaround or have to spend most of my ti

Re: [PR] [improve][admin] getMessageById gets message by batch index [pulsar]

2023-12-27 Thread via GitHub
nodece commented on PR #21813: URL: https://github.com/apache/pulsar/pull/21813#issuecomment-1870887378 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [improve][admin] getMessageById gets message by batch index [pulsar]

2023-12-27 Thread via GitHub
nodece commented on PR #21813: URL: https://github.com/apache/pulsar/pull/21813#issuecomment-1870880104 Related PR: https://github.com/apache/pulsar/pull/19827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

(pulsar-client-python) branch main updated: Document the requirement for the send_async method (#186)

2023-12-27 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new d2fb04e Document the requirement for the

Re: [PR] Document the requirement for the send_async method [pulsar-client-python]

2023-12-27 Thread via GitHub
BewareMyPower merged PR #186: URL: https://github.com/apache/pulsar-client-python/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[PR] Document the requirement for the send_async method [pulsar-client-python]

2023-12-27 Thread via GitHub
BewareMyPower opened a new pull request, #186: URL: https://github.com/apache/pulsar-client-python/pull/186 See https://github.com/apache/pulsar-client-python/issues/184 It should be documented that the callback should not throw any exception when passed to `send_async`. -- This is

Re: [PR] [improve][pip] PIP-328: Add a topicDeleteProtectionEnable configuration option. [pulsar]

2023-12-27 Thread via GitHub
crossoverJie closed pull request #21800: [improve][pip] PIP-328: Add a topicDeleteProtectionEnable configuration option. URL: https://github.com/apache/pulsar/pull/21800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [Grafana] Add jvm grafana dashboard with instance [pulsar]

2023-12-27 Thread via GitHub
XuQianJin-Stars opened a new pull request, #21814: URL: https://github.com/apache/pulsar/pull/21814 ### Motivation before: ![image](https://github.com/apache/pulsar/assets/10494131/e8cd7c7d-c645-4a98-805e-d7a29a22351c) after: ![image](https://github.com/apache/pulsar

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2023-12-27 Thread via GitHub
poorbarcode commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1437399278 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3157,4 +3163,49 @@ public void testProduceChangesWithEncryptionRequire

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2023-12-27 Thread via GitHub
poorbarcode commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1437398917 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3061,39 +3062,67 @@ public CompletableFuture onPoliciesUpd

Re: [PR] [improve][broker] defer the ownership checks if the owner is inactive (ExtensibleLoadManager) [pulsar]

2023-12-27 Thread via GitHub
dragosvictor commented on code in PR #21811: URL: https://github.com/apache/pulsar/pull/21811#discussion_r1437366512 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java: ## @@ -487,6 +487,30 @@ public boolean is

Re: [PR] [improve][broker] defer the ownership checks if the owner is inactive (ExtensibleLoadManager) [pulsar]

2023-12-27 Thread via GitHub
dragosvictor commented on PR #21811: URL: https://github.com/apache/pulsar/pull/21811#issuecomment-1870836294 Looks good to me, only had cosmetic recommendations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1437379860 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java: ## @@ -106,5 +108,16 @@ public void markDeleteFailed

[PR] [improve][admin] getMessageById gets message by batch index [pulsar]

2023-12-27 Thread via GitHub
nodece opened a new pull request, #21813: URL: https://github.com/apache/pulsar/pull/21813 ### Motivation When the message is a batch message, the `org.apache.pulsar.client.admin.Topics#getMessageByIdAsync(java.lang.String, long, long)` only returns the first message from the batch m

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1437377668 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java: ## @@ -3157,4 +3163,49 @@ public void testProduceChangesWithEncryptionRequi

[PR] [improve] EFFECTIVELY_ONCE mode support input topic batching [pulsar]

2023-12-27 Thread via GitHub
graysonzeng opened a new pull request, #21812: URL: https://github.com/apache/pulsar/pull/21812 Fixes #17061 Main Issue: #17061 ### Motivation The batch message will generate the same sequence ID in the function, which will cause a large a

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2023-12-27 Thread via GitHub
codecov-commenter commented on PR #21810: URL: https://github.com/apache/pulsar/pull/21810#issuecomment-1870787418 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix][txn] Avoid message redelivering when consumer changes [pulsar]

2023-12-27 Thread via GitHub
liangyepianzhou closed pull request #21776: [fix][txn] Avoid message redelivering when consumer changes URL: https://github.com/apache/pulsar/pull/21776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [fix][txn] Avoid message redelivering when consumer changes [pulsar]

2023-12-27 Thread via GitHub
liangyepianzhou commented on PR #21776: URL: https://github.com/apache/pulsar/pull/21776#issuecomment-1870771401 Close this Pull Request. Because we can not protect the sequentiality of the message in this way. We hope to seek more sophisticated solutions to this problem in the future. --

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2023-12-27 Thread via GitHub
poorbarcode closed pull request #21810: [fix] [broker] Update topic policies as much as possible when some ex was thrown URL: https://github.com/apache/pulsar/pull/21810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [improve][broker] defer the ownership checks if the owner is inactive (ExtensibleLoadManager) [pulsar]

2023-12-27 Thread via GitHub
heesung-sn opened a new pull request, #21811: URL: https://github.com/apache/pulsar/pull/21811 ### Motivation When a broker shutdown or gets killed, the leader broker will get notified and soon reassign the orphan bundle ownerships. Meanwhile, the ownership loo

Re: [I] Producer callback is unable to utilise python raise to propagate errors [pulsar-client-python]

2023-12-27 Thread via GitHub
Samreay commented on issue #184: URL: https://github.com/apache/pulsar-client-python/issues/184#issuecomment-1870664088 The workaround I have is more advanced than the one I posted above, and has proper concurrency when async sending multiple messages (unlike my example which sends one mes

[PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2023-12-27 Thread via GitHub
poorbarcode opened a new pull request, #21810: URL: https://github.com/apache/pulsar/pull/21810 ### Motivation After the topic policies update, there are many components will be updated one by one even if the config of components has not been modified. There is a demo of the componen

(pulsar) branch master updated: [improve] [broker] PIP-299-part-1: Stop dispatch messages if the individual acks will be lost in the persistent storage (#21423)

2023-12-27 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8ff32dbf9eb [improve] [broker] PIP-299-part-1: S

Re: [PR] [improve] [broker] PIP-299-part-1: Stop dispatch messages if the individual acks will be lost in the persistent storage [pulsar]

2023-12-27 Thread via GitHub
poorbarcode merged PR #21423: URL: https://github.com/apache/pulsar/pull/21423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [I] [Bug] Building a custom docker image is stuck [pulsar]

2023-12-27 Thread via GitHub
compuguy commented on issue #21100: URL: https://github.com/apache/pulsar/issues/21100#issuecomment-1870556461 Any updates on this, I think the previous merge requests mentioned in my last comment resolve this issue? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [fix] Pulsar spout fails to unsubscribe and close consumers on a shared subscription [pulsar-adapters]

2023-12-27 Thread via GitHub
merlimat commented on code in PR #56: URL: https://github.com/apache/pulsar-adapters/pull/56#discussion_r1437153408 ## pulsar-storm/src/main/java/org/apache/pulsar/storm/PulsarSpout.java: ## @@ -454,7 +454,7 @@ public void close() throws PulsarClientException { @Overr

Re: [PR] [improve][broker] Improve isTopicPublishRateExceeded to uniformly check publish rate [pulsar]

2023-12-27 Thread via GitHub
nodece closed pull request #21734: [improve][broker] Improve isTopicPublishRateExceeded to uniformly check publish rate URL: https://github.com/apache/pulsar/pull/21734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(pulsar) branch branch-3.1 updated: [fix][broker] Fixed the ExtensibleLoadManagerImpl internal system getTopic failure when the leadership changes #21764 (#21801)

2023-12-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 39b69a3cb08 [fix][broker] Fixed the Exte

Re: [PR] [fix][broker] Fixed the ExtensibleLoadManagerImpl internal system getTopic failure when the leadership changes #21764 [pulsar]

2023-12-27 Thread via GitHub
merlimat merged PR #21801: URL: https://github.com/apache/pulsar/pull/21801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [I] Producer callback is unable to utilise python raise to propagate errors [pulsar-client-python]

2023-12-27 Thread via GitHub
merlimat commented on issue #184: URL: https://github.com/apache/pulsar-client-python/issues/184#issuecomment-1870419432 @Samreay The question is also for which reason you are using `send_async()` instead of the plain `send`. While the send is blocking, it won't be holding the GIL,

Re: [PR] [improve] [broker] PIP-299-part-1: Stop dispatch messages if the individual acks will be lost in the persistent storage [pulsar]

2023-12-27 Thread via GitHub
poorbarcode commented on code in PR #21423: URL: https://github.com/apache/pulsar/pull/21423#discussion_r1437093831 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -996,6 +1055,23 @@ public void addUnAc

Re: [PR] [fix][broker] Fixed the ExtensibleLoadManagerImpl internal system getTopic failure when the leadership changes #21764 [pulsar]

2023-12-27 Thread via GitHub
Technoboy- commented on PR #21801: URL: https://github.com/apache/pulsar/pull/21801#issuecomment-1870332642 I have fixed the failed test. Rebase and force push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
codecov-commenter commented on PR #21745: URL: https://github.com/apache/pulsar/pull/21745#issuecomment-1870330102 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21745?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

(pulsar) branch branch-3.1 updated: Fix testNoCleanupOffloadLedgerWhenMetadataExceptionHappens

2023-12-27 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new d2765505331 Fix testNoCleanupOffloadL

(pulsar) branch branch-3.2 created (now 2d5762402f3)

2023-12-27 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git at 2d5762402f3 [fix][sec] Bump google.golang.org/grpc from 1.38.0 to 1.56.3 in /pulsar-function-go (#21444) No n

Re: [PR] [fix][test] Fix auto recovery test thread leak problem. [pulsar]

2023-12-27 Thread via GitHub
horizonzy commented on code in PR #21797: URL: https://github.com/apache/pulsar/pull/21797#discussion_r1437045716 ## managed-ledger/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java: ## @@ -288,6 +288,7 @@ protected void stopBKCluster() throws Exception {

Re: [PR] [improve] [broker] PIP-299-part-1: Stop dispatch messages if the individual acks will be lost in the persistent storage [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on code in PR #21423: URL: https://github.com/apache/pulsar/pull/21423#discussion_r1437035119 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -996,6 +1055,23 @@ public void addUn

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1437019133 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
BewareMyPower commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1437015705 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClea

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
BewareMyPower commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1437006985 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1231,37 +1232,56 @@ private void asyncDeleteCursorWithCl

Re: [PR] [fix][txn] Avoid message redelivering when consumer changes [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on PR #21776: URL: https://github.com/apache/pulsar/pull/21776#issuecomment-1870259666 > 1. Exclusive > Problem: > Ack task is in process. Acking for msg 1,2,3 with transaction1. > Old consumer disconnects. > New consumer connects. > Cursor is rewoun

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
BewareMyPower commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1437006985 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1231,37 +1232,56 @@ private void asyncDeleteCursorWithCl

Re: [I] Pulsar manager backend failed to start on v0.4.0 [pulsar-helm-chart]

2023-12-27 Thread via GitHub
shlomitubul commented on issue #365: URL: https://github.com/apache/pulsar-helm-chart/issues/365#issuecomment-1870256449 I did try to run it on OpenShift but it didn't work (I add the ENV var), the backend kept crashing -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436889749 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436996424 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436996424 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
BewareMyPower commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436982457 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClea

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
BewareMyPower commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436976157 ## pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java: ## @@ -2012,4 +2014,70 @@ public void testCompactionDuplicate() throws Exception

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
poorbarcode commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436950722 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearD

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436941093 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436941093 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [I] The pulsar-proxy fails to start with 401 when deploying with Pulsar 3.1.1 [pulsar-helm-chart]

2023-12-27 Thread via GitHub
hadican commented on issue #403: URL: https://github.com/apache/pulsar-helm-chart/issues/403#issuecomment-1870170518 I'm getting this too. I think something changed at 3.x When you enable auth, `status.html` expects JWT token too. IMHO, health check files should be skipped. Fo

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
poorbarcode commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436918987 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearD

Re: [PR] [fix][broker] Fix multiple race conditions in topic unloading and loading [pulsar]

2023-12-27 Thread via GitHub
lhotari commented on PR #20540: URL: https://github.com/apache/pulsar/pull/20540#issuecomment-1870160236 This test app ends up with a topic being fenced: https://github.com/lhotari/pulsar-playground/blob/master/src/main/java/com/github/lhotari/pulsar/playground/TestScenarioUnloading.java ,

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
poorbarcode commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436918987 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearD

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436861554 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java: ## @@ -106,5 +108,16 @@ public void markDeleteFailed(Manag

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436861554 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java: ## @@ -106,5 +108,16 @@ public void markDeleteFailed(Manag

Re: [I] [Bug] java.lang.NoSuchMethodError: int com.scurrilous.circe.checksum.Crc32cIntChecksum.computeChecksum [pulsar]

2023-12-27 Thread via GitHub
lhotari commented on issue #20915: URL: https://github.com/apache/pulsar/issues/20915#issuecomment-1870145539 For Gradle and shadow plugin, this is the workaround: https://github.com/apache/bookkeeper/issues/3511 -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [fix][broker]One topic can be close multiple times concurrently [pulsar]

2023-12-27 Thread via GitHub
lhotari commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-1870134869 @poorbarcode please rebase this PR. I guess this is still relevant and in the same category as #20540 . -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436889749 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClearDelay

Re: [PR] [improve][pip] PIP-321 Split the responsibilities of namespace replication-clusters [pulsar]

2023-12-27 Thread via GitHub
liangyepianzhou commented on code in PR #21648: URL: https://github.com/apache/pulsar/pull/21648#discussion_r1436884302 ## pip/pip-321.md: ## @@ -0,0 +1,241 @@ +# PIP-321: Split the responsibilities of namespace replication-clusters + +# Background knowledge + +Pulsar's geo-repl

(pulsar-client-go) branch master updated: [Improve] Update connection.lastDataReceivedTime when it is ready (#1145)

2023-12-27 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 443072bf [Improve] Update connection.la

Re: [PR] [Improve] update connection.lastDataReceivedTime when connection is ready [pulsar-client-go]

2023-12-27 Thread via GitHub
tisonkun merged PR #1145: URL: https://github.com/apache/pulsar-client-go/pull/1145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [I] [Bug] pulsar-perf report OOM after long-time test [pulsar]

2023-12-27 Thread via GitHub
wuyanzan closed issue #21705: [Bug] pulsar-perf report OOM after long-time test URL: https://github.com/apache/pulsar/issues/21705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] [Bug] pulsar-perf report OOM after long-time test [pulsar]

2023-12-27 Thread via GitHub
wuyanzan commented on issue #21705: URL: https://github.com/apache/pulsar/issues/21705#issuecomment-1870099289 https://github.com/apache/pulsar/pull/20914 it's already fixed . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[I] [Bug] [worker] ProducerFencedException:Topic has an existing exclusive producer [pulsar]

2023-12-27 Thread via GitHub
wuyanzan opened a new issue, #21809: URL: https://github.com/apache/pulsar/issues/21809 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version 3.1.0 ### Minimal reproduce step

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
coderzc commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436861554 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PulsarCompactorSubscription.java: ## @@ -106,5 +108,16 @@ public void markDeleteFailed(Manag

Re: [PR] [improve][pip] PIP-321 Split the responsibilities of namespace replication-clusters [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on code in PR #21648: URL: https://github.com/apache/pulsar/pull/21648#discussion_r1436842208 ## pip/pip-321.md: ## @@ -0,0 +1,285 @@ +# PIP-321: Split the responsibilities of namespace replication-clusters + +# Background knowledge + +Pulsar's geo-replic

Re: [PR] [improve][pip] PIP-321 Split the responsibilities of namespace replication-clusters [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on code in PR #21648: URL: https://github.com/apache/pulsar/pull/21648#discussion_r1436842208 ## pip/pip-321.md: ## @@ -0,0 +1,285 @@ +# PIP-321: Split the responsibilities of namespace replication-clusters + +# Background knowledge + +Pulsar's geo-replic

Re: [PR] [fix][broker] Delete compacted ledger when topic is deleted [pulsar]

2023-12-27 Thread via GitHub
codelipenghui commented on code in PR #21745: URL: https://github.com/apache/pulsar/pull/21745#discussion_r1436839434 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1220,7 +1221,7 @@ private void asyncDeleteCursorWithClea