[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035811#comment-14035811 ] Hudson commented on HADOOP-10660: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1805 (

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035702#comment-14035702 ] Hudson commented on HADOOP-10660: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1778 (See

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035583#comment-14035583 ] Hudson commented on HADOOP-10660: - FAILURE: Integrated in Hadoop-Yarn-trunk #587 (See [

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035556#comment-14035556 ] Hudson commented on HADOOP-10660: - SUCCESS: Integrated in Hadoop-trunk-Commit #5722 (See

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035511#comment-14035511 ] Ravi Prakash commented on HADOOP-10660: --- +1. Will commit momentarily. Thanks [~air

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034143#comment-14034143 ] Hadoop QA commented on HADOOP-10660: {color:green}+1 overall{color}. Here are the r

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034087#comment-14034087 ] Hadoop QA commented on HADOOP-10660: {color:green}+1 overall{color}. Here are the r

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034006#comment-14034006 ] Hadoop QA commented on HADOOP-10660: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033856#comment-14033856 ] Ted Yu commented on HADOOP-10660: - I logged HADOOP-10715 for making GraphiteSink#setWrit

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033836#comment-14033836 ] Chen He commented on HADOOP-10660: -- Hi [~tedyu], I did. But I do not know his context

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033821#comment-14033821 ] Ted Yu commented on HADOOP-10660: - [~airbots]: You can put Ravi's code in TestGraphiteMe

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033765#comment-14033765 ] Chen He commented on HADOOP-10660: -- Hi [~raviprak], would you mind provide error messag

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033569#comment-14033569 ] Ravi Prakash commented on HADOOP-10660: --- 1. I should have picked it up in HADOOP-9

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031386#comment-14031386 ] Ted Yu commented on HADOOP-10660: - [~raviprak]: What do you think of patch v3 ? > Graph

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029904#comment-14029904 ] ASF GitHub Bot commented on HADOOP-10660: - Github user babak-altiscale closed th

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029687#comment-14029687 ] Babak Behzad commented on HADOOP-10660: --- I just finished testing this patch on my

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029672#comment-14029672 ] ASF GitHub Bot commented on HADOOP-10660: - GitHub user babak-altiscale opened a

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029452#comment-14029452 ] Babak Behzad commented on HADOOP-10660: --- No, thanks [~ted_yu], I am currently in t

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029442#comment-14029442 ] Ted Yu commented on HADOOP-10660: - [~babakbehzad]: Is there anything Chen He and myself

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029440#comment-14029440 ] Ted Yu commented on HADOOP-10660: - [~ babakbehzad]: Is there anything Chen He and myself

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025558#comment-14025558 ] Ted Yu commented on HADOOP-10660: - Socket has isClosed() which can be used to check the

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025496#comment-14025496 ] Ted Yu commented on HADOOP-10660: - I tried to find the source code for StreamEncoder. Bu

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025440#comment-14025440 ] Ravi Prakash commented on HADOOP-10660: --- Thanks Ted! That makes sense. Perhaps we

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025440#comment-14025440 ] Ravi Prakash commented on HADOOP-10660: --- Thanks Ted! That makes sense. Perhaps we

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025359#comment-14025359 ] Babak Behzad commented on HADOOP-10660: --- Thanks [~airbots] and [~ted_yu]. We have

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025353#comment-14025353 ] Hadoop QA commented on HADOOP-10660: {color:green}+1 overall{color}. Here are the r

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025350#comment-14025350 ] Hadoop QA commented on HADOOP-10660: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025344#comment-14025344 ] Ted Yu commented on HADOOP-10660: - [~raviprak]: Is there any question that I haven't ans

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025325#comment-14025325 ] Ted Yu commented on HADOOP-10660: - The close of socket should be enclosed in finally blo

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020250#comment-14020250 ] Chen He commented on HADOOP-10660: -- The failed unit test is because of HADOOP-10668 >

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020214#comment-14020214 ] Hadoop QA commented on HADOOP-10660: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020152#comment-14020152 ] Ted Yu commented on HADOOP-10660: - writer field of GraphiteSink points to OutputStreamWr

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020144#comment-14020144 ] Chen He commented on HADOOP-10660: -- Patch updated. Socket is closed since it is set to

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020105#comment-14020105 ] Hadoop QA commented on HADOOP-10660: {color:green}+1 overall{color}. Here are the r

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020024#comment-14020024 ] Ted Yu commented on HADOOP-10660: - {code} +} else { + throw new

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020014#comment-14020014 ] Chen He commented on HADOOP-10660: -- Thank you for the suggestions, [~raviprak] and [~te

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019998#comment-14019998 ] Ted Yu commented on HADOOP-10660: - bq. the GraphiteSink is closed but the writer is stil

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019974#comment-14019974 ] Chen He commented on HADOOP-10660: -- Is there probability that the GraphiteSink is close

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019966#comment-14019966 ] Ted Yu commented on HADOOP-10660: - See the following javadoc in MetricsSink.java : {code

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019951#comment-14019951 ] Ravi Prakash commented on HADOOP-10660: --- Ted: I'm afraid I don't see where close()

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019868#comment-14019868 ] Chen He commented on HADOOP-10660: -- is this patch ok? :) > GraphiteSink should impleme

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018921#comment-14018921 ] Ted Yu commented on HADOOP-10660: - {code} public class FileSink implements MetricsSink,

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018904#comment-14018904 ] Babak Behzad commented on HADOOP-10660: --- A couple of colleagues and I contributed

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018813#comment-14018813 ] Chen He commented on HADOOP-10660: -- The unit test failure is because of HADOOP-10664.

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017970#comment-14017970 ] Chen He commented on HADOOP-10660: -- The unit test failure is caused by hostname is null

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017932#comment-14017932 ] Ted Yu commented on HADOOP-10660: - Should socket become a member of GraphiteSink and be

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017930#comment-14017930 ] Chen He commented on HADOOP-10660: -- The TestNetUtils fails on trunk without my patch.

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017900#comment-14017900 ] Hadoop QA commented on HADOOP-10660: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017335#comment-14017335 ] Ted Yu commented on HADOOP-10660: - You can find the file here: hadoop-common-project/had

[jira] [Commented] (HADOOP-10660) GraphiteSink should implement Closeable

[ https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017320#comment-14017320 ] Chen He commented on HADOOP-10660: -- I have a question, [~tedyu]. I did not find Graphit