Re: [lang] Proposal (2): isEmpty

2003-07-20 Thread Henri Yandell
Hmm. It wasn't in 1.0.1 javadocs. One thing we're lacking now I look at the source are javadoc @since tags. http://jakarta.apache.org/commons/lang/api/org/apache/commons/lang/StringUtils.html Hen On Sun, 20 Jul 2003, Stephen Colebourne wrote: isWhitespace() still exists, but returns false

cvs commit: jakarta-commons/modeler/src/test/org/apache/commons/modeler RegistryTestCase.java

2003-07-20 Thread ggregory
ggregory2003/07/20 00:25:58 Modified:modeler/src/test/org/apache/commons/modeler RegistryTestCase.java Log: Organize Imports. Revision ChangesPath 1.7 +6 -6

cvs commit: jakarta-commons/modeler/src/java/org/apache/commons/modeler/mbeans MBeanProxy.java SimpleRemoteConnector.java

2003-07-20 Thread ggregory
ggregory2003/07/20 00:35:14 Modified:modeler/src/java/org/apache/commons/modeler/modules MbeansSource.java MbeansDescriptorsSerSource.java ModelerSource.java MbeansDescriptorsDynamicMBeanSource.java

cvs commit: jakarta-commons/modeler/src/test/org/apache/commons/modeler/demo Demo.java

2003-07-20 Thread ggregory
ggregory2003/07/20 00:35:45 Modified:modeler/src/test/org/apache/commons/modeler/demo Demo.java Log: Organzie import statements. Revision ChangesPath 1.2 +6 -4 jakarta-commons/modeler/src/test/org/apache/commons/modeler/demo/Demo.java Index: Demo.java

RE: [modeler] cleanup imports

2003-07-20 Thread Gary Gregory
Hello, I've taken the liberty to organize the [modeler] imports. FYI, I did not apply the patch but simply used Eclipse's Organize Imports feature. Also, FYI, here are the other compiler warnings noted by Eclispe: SeverityDescription ResourceIn Folder Location

[lang] How should StringUtils.indexOfAny handle in search string?

2003-07-20 Thread Phil Steitz
Currently, StringUtils.indexOfAny(str, searchStrings) returns 0 if searchStrings contains , but we return -1 if it contains null. Is this the way we want it to work? We should add javadoc in any case. One more thing. I really like the examples in the javadoc, but in some cases they might be

Re: [lang] StringUtils isEmpty summary(2)

2003-07-20 Thread Stephen Colebourne
I think that the basic request here is for a version of StringUtils that throws NPE on null input. This seems perfectly acceptable as a requirement, but it is different to the main StringUtils requirement of quiet null handling. For a 2.1/3.0 release, I would be happy to see a StringUtilsNPE (or

Re: [lang] How should StringUtils.indexOfAny handle in search string?

2003-07-20 Thread Stephen Colebourne
- Original Message - From: Phil Steitz [EMAIL PROTECTED] Currently, StringUtils.indexOfAny(str, searchStrings) returns 0 if searchStrings contains , but we return -1 if it contains null. Is this the way we want it to work? We should add javadoc in any case. I guess it has to be.

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang NumberUtils.java

2003-07-20 Thread scolebourne
scolebourne2003/07/20 03:24:49 Modified:lang/src/java/org/apache/commons/lang NumberUtils.java Log: Fix wrong javadoc Revision ChangesPath 1.12 +3 -3 jakarta-commons/lang/src/java/org/apache/commons/lang/NumberUtils.java Index: NumberUtils.java

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang StringUtils.java

2003-07-20 Thread scolebourne
scolebourne2003/07/20 03:29:22 Modified:lang/src/test/org/apache/commons/lang StringUtilsTest.java lang/src/java/org/apache/commons/lang StringUtils.java Log: Add new method center(String, int, char) to complete API Rework padding internals Example javadoc

RE: [lang] StringUtils isEmpty summary(2)

2003-07-20 Thread Laird J. Nelson
-Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] I think that the basic request here is for a version of StringUtils that throws NPE on null input. How about either: * StringUtils becomes an instance class that is configured at construction time:

RE: [lang] StringUtils isEmpty summary(2)

2003-07-20 Thread Laird J. Nelson
-Original Message- From: Laird J. Nelson [mailto:[EMAIL PROTECTED] How about either: (First of all, let me also say that I am merely a lurker on this issue and am throwing out ideas for the fun of it, not because I want to hold up anything, or cause trouble. :-)) * StringUtils

Bug report for Commons [2003/07/20]

2003-07-20 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang StringUtils.java

2003-07-20 Thread scolebourne
scolebourne2003/07/20 07:47:29 Modified:lang/src/test/org/apache/commons/lang StringUtilsTest.java lang/src/java/org/apache/commons/lang StringUtils.java Log: Add summary javadoc section to StringUtils class Rename reverseDelimitedString to reverseDelimited

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang StringUtils.java

2003-07-20 Thread scolebourne
scolebourne2003/07/20 08:29:45 Modified:lang/src/test/org/apache/commons/lang StringUtilsSubstringTest.java lang/src/java/org/apache/commons/lang StringUtils.java Log: Add more javadoc example code Ensure empty string behaviour documented in

RE: [lang] How should StringUtils.indexOfAny handle in search string?

2003-07-20 Thread Gary Gregory
The convention could perhaps also bracket template like things with itemplate/i, as in: /** * Blah Blah codeFoo.bar(iinputValue/i);/code Blah Blah. */ Gary -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Sunday, July 20, 2003 02:21 To: Jakarta Commons

Re: [lang] StringUtils.isEmpty summary (3)

2003-07-20 Thread Todd Jonker
On 7/20/03 12:25 PM, [EMAIL PROTECTED] wrote: For a 2.1/3.0 release a StringUtilsNPE could be added to provide the harsh null behaviour (null input - NPE) I'd like to note that if one wants NPEs, one can usually write code like str.length() == 0 instead of StringUtilsNPE.isEmpty()

DO NOT REPLY [Bug 21633] - [CODEC] IndexOutOfBoundsException when encoding non-ASCII characters

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21633. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: [lang] StringUtils.isEmpty summary (3)

2003-07-20 Thread Gary Gregory
Hello All, This as been quite a topic! I am starting to think that we could perhaps consider: (1) Release 2.0 with as little change as possible in this area, in particular make sure we are backwards compatible. (I am not looking forward to checking the logic of all my senders of isEmpty, etc...)

cvs commit: jakarta-commons/lang/src/test/org/apache/commons/lang/math RandomUtilsTest.java

2003-07-20 Thread ggregory
ggregory2003/07/20 11:58:46 Modified:lang/src/test/org/apache/commons/lang/math RandomUtilsTest.java Log: Severity Description ResourceIn Folder Location Creation Time Superfluous semicolon RandomUtilsTest.java

cvs commit: jakarta-commons/codec/src/java/org/apache/commons/codec/base64 Base64.java

2003-07-20 Thread ggregory
ggregory2003/07/20 12:09:03 Modified:codec/src/java/org/apache/commons/codec/base64 Base64.java Log: Javadoc typo. Revision ChangesPath 1.4 +455 -455 jakarta-commons/codec/src/java/org/apache/commons/codec/base64/Base64.java Index: Base64.java

DO NOT REPLY [Bug 21748] New: - BasicDataSource.close() throws NPE

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21748. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 21750] New: - [lang] StringUtils javadoc and test enhancements

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21750. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 21750] - [lang] StringUtils javadoc and test enhancements

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21750. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

RE: DO NOT REPLY [Bug 21748] New: - BasicDataSource.close() throws NPE

2003-07-20 Thread Noel J. Bergman
This is an easy fix, but since it would be my first commit to this project, I just want to see what the group preference is. The basic problem is this: public void close() throws SQLException { GenericObjectPool oldpool = connectionPool; connectionPool = null;

Re: [lang] How should StringUtils.indexOfAny handle in search string?

2003-07-20 Thread Phil Steitz
Phil Steitz wrote: Currently, StringUtils.indexOfAny(str, searchStrings) returns 0 if searchStrings contains , but we return -1 if it contains null. Is this the way we want it to work? We should add javadoc in any case. One more thing. I really like the examples in the javadoc, but in some

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang StringUtils.java

2003-07-20 Thread scolebourne
scolebourne2003/07/20 16:57:26 Modified:lang/src/test/org/apache/commons/lang StringUtilsEqualsIndexOfTest.java StringUtilsTest.java StringUtilsSubstringTest.java lang/src/java/org/apache/commons/lang StringUtils.java Log:

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang StringUtils.java

2003-07-20 Thread scolebourne
scolebourne2003/07/20 17:41:13 Modified:lang/src/test/org/apache/commons/lang StringUtilsSubstringTest.java lang/src/java/org/apache/commons/lang StringUtils.java Log: Update Javadoc examples Change mid() to accept invalid startPos

DO NOT REPLY [Bug 21750] - [lang] StringUtils javadoc and test enhancements

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21750. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 21750] - [lang] StringUtils javadoc and test enhancements

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21750. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

[lang] 2.0 RC2?

2003-07-20 Thread Stephen Colebourne
Well I'm done. - StringUtils and other classes are sorted with respect to null handling (absorbing as many as possible). - IsEmpty/IsBlank is coded and present. And highlighted in release notes. - Javadoc code examples have been put into most StringUtils methods. There are a few left if someone

Re: [DBCP] AbandonedTrace - Connection Recovery

2003-07-20 Thread Glenn Nielsen
Noel J. Bergman wrote: It appears clear that there are two camps, each with fairly strong views. Personally, I believe that both camps can be accomodated in a way that should satisfy both. DBCP should focus on core pooling behavior related to connections and prepared statements, and leave policy

Re: [Resources] When is the next release?

2003-07-20 Thread James Mitchell
Unless I did something wrong, my search for issues on bugzilla turns up nothing, and I'm not sure what to make of issueTrackingUrl in project.xml. Does it mean that we should be using http://nagoya.apache.org/scarab/servlet/scarab/ or is it something that was just carried over when someone was

DO NOT REPLY [Bug 21758] New: - [lang] lang.builder classes javadoc edits (mostly typo fixes)

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 21758] - [lang] lang.builder classes javadoc edits (mostly typo fixes)

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-commons/modeler/src/java/org/apache/commons/modeler/util IntrospectionUtils.java

2003-07-20 Thread craigmcc
craigmcc2003/07/20 21:43:17 Modified:modeler/src/java/org/apache/commons/modeler BaseModelMBean.java modeler/src/java/org/apache/commons/modeler/modules MbeansSource.java ModelerSource.java

cvs commit: jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl CollectionResourcesBase.java PropertyResources.java PropertyResourcesFactory.java ResourceBundleResources.java ResourceBundleResourcesFactory.java WebappPropertyResources.java WebappPropertyResourcesFactory.java WebappXMLResources.java WebappXMLResourcesFactory.java XMLResources.java XMLResourcesFactory.java

2003-07-20 Thread craigmcc
craigmcc2003/07/20 21:57:22 Modified:resources/src/java/org/apache/commons/resources/impl CollectionResourcesBase.java PropertyResources.java PropertyResourcesFactory.java ResourceBundleResources.java

DO NOT REPLY [Bug 21758] - [lang] lang.builder classes javadoc edits (mostly typo fixes)

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: [DBCP] AbandonedTrace - Connection Recovery

2003-07-20 Thread David Graham
I fess up, I am the guilty party who added the ability to trace abandoned connections and recover them. ;-) Sorry to jump in late on this. I have been busy with other things. The motivation behind this was to allow a servlet container to continue operating normally even if you have

Image downloads...

2003-07-20 Thread Jan Gonsalves
Hey guys (and ladies), quick question. I've been using HttpClient for about 4 months now. I feel pretty comfortable with using it to do many things. My question is a simple one. If I have an image I need to download (www.SomeProvider.com/PICTURES/somePic.jpg), how do I get it? I've had to

Re: Image downloads... - Nevermind

2003-07-20 Thread Jan Gonsalves
Sorry, I didn't realize the fileName I was passing in had several spaces tacked on the end of it. Guess that causes goofy things to happen. Thanks anyways. Jan Jan Gonsalves wrote: Hey guys (and ladies), quick question. I've been using HttpClient for about 4 months now. I feel pretty

DO NOT REPLY [Bug 21754] - NullPointerException when releasing connection

2003-07-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21754. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.