[PATCH 20/24] peer: Add the logic for signaling PeersChanged() relevantly

2014-03-21 Thread Tomasz Bursztyka
A peer is added only when it gets registered to dbus, and is said to be removed if only it is already registered to dbus. --- src/peer.c | 111 + 1 file changed, 111 insertions(+) diff --git a/src/peer.c b/src/peer.c index 77a71f2..b949d

[PATCH 18/24] dbus: Factorize a useful functions for changed objects

2014-03-21 Thread Tomasz Bursztyka
This is currently used only in service.c to signal ServicesChanged() but it will be useful also in peer.c to signal PeersChanged(), thus factorizing this code. --- src/connman.h | 4 +++- src/dbus.c| 19 +++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/co

[PATCH 21/24] wifi: Handle gsupplicant peer event and link the core logic for peers

2014-03-21 Thread Tomasz Bursztyka
Just handling properly peer_found and peer_lost callbacks accordingly, creating or destroying peers. The core logic will know when and what to signal through Manager API's PeersChanged(). --- plugins/wifi.c | 37 + 1 file changed, 37 insertions(+) diff --git a/

[PATCH 22/24] client: Add basic support for P2P peers related signal and method

2014-03-21 Thread Tomasz Bursztyka
Handle PeersChanged() signal and GetPeers() method from Manager API relevantly. --- Makefile.am | 1 + client/commands.c | 140 -- client/peers.c| 123 +++ client/peers.h| 39 ++

Re: Removing saved networks

2014-03-21 Thread Tomasz Bursztyka
Hi, ConnMan itself does not provide any means to solve this, and afaik there is no plan to do so. But it can be actually fixed easily from outside, with a script in a cron-job. I believe Patrik has made such a script, which removes old networks based on their timestamps (so it's tweakable).

Re: How to set the hardware clock from the current system time.

2014-03-25 Thread Tomasz Bursztyka
Hi, But Ossama has some ideas: -- Patrik's comment assumes that automatic time updates are enabled in Connman and/or NTP is configured. I don't believe his comment applies when automatic updates are*disabled*. In that case, the user will set the time manuall

[PATCH v2 00/24] Introduction of WiFi P2P support

2014-03-27 Thread Tomasz Bursztyka
New version of the patchset, changes against: v1: - Jukka and Patrik comments applied. - corner case of p2p enabling/disabling fixed - proper scan stopped given to technology: by type rather than by device. Please review, Tomasz Bursztyka (24): doc: Add an

[PATCH 01/24] doc: Add an overview documentation about WiFi P2P in ConnMan

2014-03-27 Thread Tomasz Bursztyka
This document explains how to access such feature in ConnMan and quickly how the nasty details are hidden from application point of view and silently handled by ConnMan itself. --- doc/wifi-p2p-overview.txt | 54 +++ 1 file changed, 54 insertions(+) cre

[PATCH 02/24] src: Add a new service type for P2P but only used as a technology

2014-03-27 Thread Tomasz Bursztyka
In order to differentiate P2P technology and wifi by their types, let's add a new service type. This is not very clean since P2P technology is never ever going to generate any service (as struct connman_service), but there is currently no other way since technology type is tight to a CONNMAN_SERVI

[PATCH 04/24] technology: Move down dbus registration related functions for futur work

2014-03-27 Thread Tomasz Bursztyka
P2P technology driver registration will create the technology on the fly, thus will need to use technology_get(). Useless function comments are removed as well. --- src/technology.c | 158 +-- 1 file changed, 72 insertions(+), 86 deletions(-) d

[PATCH 05/24] technology: Add P2P technology support

2014-03-27 Thread Tomasz Bursztyka
P2P technology is specific in a way it will not own any device due to the fact it is a child technology of wifi technology: wifi technology will own the devices then. Thus, when registering the P2P technology driver, it actually means: a wifi device supports P2P, leading to create directly the P2P

[PATCH 03/24] technology: Check if a driver does not exist already before registration

2014-03-27 Thread Tomasz Bursztyka
If this works for any kind of driver, it will be useful in case of P2P driver mostly. --- src/technology.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/technology.c b/src/technology.c index 76f936a..e2de923 100644 --- a/src/technology.c +++ b/src/technology.c @@ -141,6 +141,11 @@ i

[PATCH 09/24] gsupplicant: Add a mechanism to know whether P2P is supported or not

2014-03-27 Thread Tomasz Bursztyka
By default, support is false but if P2P "Flush()" method gets a non-erroneous reply: it will be set to true. This tests at once if: - wpa_supplicant has been built with p2p support, then Flush() should exist so no error should come as a reply. - the device supports p2p, then Flush() should not r

[PATCH 06/24] technology: Move up Powered related functions for future work

2014-03-27 Thread Tomasz Bursztyka
In case of P2P technology - since this one is not tight to any devices - when enabling/disabling it from DBus, the signal about Powered being changed will be raised automatically. --- src/technology.c | 134 +++ 1 file changed, 67 insertions(+),

[PATCH 10/24] wifi: Add support for (un)registering P2P technology if present

2014-03-27 Thread Tomasz Bursztyka
Since P2P is dependent over wifi technology, it will get its technology registered by this one if only one of the interface supports it. Following the same logic, once an interface is removed the wifi technology will check if the P2P technology is still supported by - at least one of - the other in

[PATCH 11/24] gsupplicant: Add function to start/stop P2P discovery process

2014-03-27 Thread Tomasz Bursztyka
It will be up to the wifi plugin to decide when to stop such process. --- gsupplicant/gsupplicant.h | 6 +++ gsupplicant/supplicant.c | 107 +++--- 2 files changed, 106 insertions(+), 7 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gs

[PATCH 08/24] technology: Handle specific case of replying to a p2p scan

2014-03-27 Thread Tomasz Bursztyka
Since p2p technology does not own any devices, but wifi does, when wifi devices delcare a "scan done", it will check relevantly if it's not a p2p scan which ended. --- include/device.h | 2 +- plugins/bluetooth_legacy.c | 6 -- plugins/wifi.c | 25 +++---

[PATCH 07/24] technology: Handle enabling/disabling P2P technology properly

2014-03-27 Thread Tomasz Bursztyka
P2P is not tight to any devices, thus the need of automatically triggering the proper enabling/disabling function which will in turn send the signal about Powered being changed accordingly. --- src/technology.c | 33 + 1 file changed, 33 insertions(+) diff --git a/

[PATCH 13/24] wifi: Handling P2P find when relevant service type is given to scan

2014-03-27 Thread Tomasz Bursztyka
Once started, wifi plugin will run a timeout to trigger a stop by itself. --- plugins/wifi.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/plugins/wifi.c b/plugins/wifi.c index cbb2dd8..85e4400 100644 --- a/plugins/wifi.c +++ b/plug

[PATCH 12/24] device: Detail the service type to the scanning method

2014-03-27 Thread Tomasz Bursztyka
It's actually about differentiating the technology, which will be useful when requesting a scan from P2P technology. Since this technology is the child of wifi technology, it will get a scan triggered through the same scanning method. It will be up to the wifi plugin to differentiate what to do acc

[PATCH 22/24] client: Add basic support for P2P peers related signal and method

2014-03-27 Thread Tomasz Bursztyka
Handle PeersChanged() signal and GetPeers() method from Manager API relevantly. --- Makefile.am | 1 + client/commands.c | 115 +- client/peers.c| 122 ++ client/peers.h| 38 +++

[PATCH 20/24] peer: Add the logic for signaling PeersChanged() relevantly

2014-03-27 Thread Tomasz Bursztyka
A peer is added only when it gets registered to dbus, and is said to be removed if only it is already registered to dbus. --- src/peer.c | 111 + 1 file changed, 111 insertions(+) diff --git a/src/peer.c b/src/peer.c index 77a71f2..b949d

[PATCH 15/24] peer: Add basic core logic for P2P peer objects

2014-03-27 Thread Tomasz Bursztyka
Basic peer structure and attributes. --- Makefile.am| 4 +- include/dbus.h | 1 + include/peer.h | 45 + src/connman.h | 5 ++ src/main.c | 2 + src/peer.c | 150 + 6 files changed, 205 insertions(+), 2 d

[PATCH 17/24] manager: Improve the API with P2P peers related method and signal

2014-03-27 Thread Tomasz Bursztyka
PeersChanged() signal is declared but not implemented thus will currently never be fired up at this point. --- src/manager.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/manager.c b/src/manager.c index 803f6ce..b31ab4c 100644 --- a/src/manager.c +++ b/src/mana

[PATCH 14/24] gsupplicant: Add the logic handling P2P peers related events/properties

2014-03-27 Thread Tomasz Bursztyka
Listen to DeviceFound and DeviceLost. From there it gets the Peer path and properties, store it into the interface object and call relevant peer_found/peer_lost callbacks provided by the wifi plugin. Due to the fact wpa_supplicant might not (it's a bug) send the device address, the peer identifier

[PATCH 19/24] service: Use the dbus helper to add an object path array to a message

2014-03-27 Thread Tomasz Bursztyka
Such helper will be used also in for peer.c --- src/service.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/service.c b/src/service.c index 2bdfc61..54790a4 100644 --- a/src/service.c +++ b/src/service.c @@ -4324,10 +4324,14 @@ static void append_remov

[PATCH 16/24] peer: Add necessary functions to get the properties through DBus

2014-03-27 Thread Tomasz Bursztyka
This will be useful for the Manager API GetPeers() method and PeersChanged() signal. Note that State and IPv4 are provided, but as disconnected for the first, and empty for the second. --- src/connman.h | 2 ++ src/peer.c| 36 2 files changed, 38 insertio

[PATCH 18/24] dbus: Factorize a useful functions for changed objects

2014-03-27 Thread Tomasz Bursztyka
This is currently used only in service.c to signal ServicesChanged() but it will be useful also in peer.c to signal PeersChanged(), thus factorizing this code. --- src/connman.h | 4 +++- src/dbus.c| 19 +++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/co

[PATCH 21/24] wifi: Handle gsupplicant peer event and link the core logic for peers

2014-03-27 Thread Tomasz Bursztyka
Just handling properly peer_found and peer_lost callbacks accordingly, creating or destroying peers. The core logic will know when and what to signal through Manager API's PeersChanged(). --- plugins/wifi.c | 37 + 1 file changed, 37 insertions(+) diff --git a/

[PATCH 24/24] client: Add support to printout one specific peer

2014-03-27 Thread Tomasz Bursztyka
With the logic of connmanctl, this requires GetProperties() method to be supported on Peer API side. --- client/commands.c | 66 ++- 1 file changed, 56 insertions(+), 10 deletions(-) diff --git a/client/commands.c b/client/commands.c index 7881c

[PATCH 23/24] peer: Add and implement support for obsolete GetProperties method

2014-03-27 Thread Tomasz Bursztyka
GetProperties() is declared as obsolete but might be useful in certain occasion. --- doc/peer-api.txt | 12 +++- src/peer.c | 20 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/doc/peer-api.txt b/doc/peer-api.txt index c54d785..e38066f 100644 ---

Re: [PATCH 14/24] gsupplicant: Add the logic handling P2P peers related events/properties

2014-03-28 Thread Tomasz Bursztyka
Hi, Due to the fact wpa_supplicant might not (it's a bug) send the device address, the peer identifier will be constructed on its name in this case. I have a suggestion that maybe we can get the device address from the obj_path temporarily. You know, name is not unique to distinguish the diffe

Re: [PATCH 14/24] gsupplicant: Add the logic handling P2P peers related events/properties

2014-03-28 Thread Tomasz Bursztyka
Hi, I have an another question, this patch only use a remote device address as a identifier, it may doesn't work well when mutli-p2p interface. maybe this question is too early this time, but the case about mutli-p2p interface is a reasonable. so what I mean is that using a combination of lo

Re: [PATCH 08/24] technology: Handle specific case of replying to a p2p scan

2014-03-31 Thread Tomasz Bursztyka
Indeed, I did not notice it since patch 12 add proper include, since I have reworked the full patchset and not one by one. Have to fix patch 7 (other issue) Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo

Re: Access Point mode set freq

2014-03-31 Thread Tomasz Bursztyka
Hi, There was some initial work on Advanced Channel Selection in wpa_supplicant, s/Advanced/Automatic Currently, only hostapd supports it. I did a q&d patch to support it into wpa_supplicant as well however ACS feature has an asynchronous logic, which does not fit into wpa_s's AP logic curr

[PATCH 07/24] technology: Handle enabling/disabling P2P technology properly

2014-04-01 Thread Tomasz Bursztyka
P2P is not tight to any devices, thus the need of automatically triggering the proper enabling/disabling function which will in turn send the signal about Powered being changed accordingly. --- src/technology.c | 32 1 file changed, 32 insertions(+) diff --git a/s

[PATCH v3 00/24] Introduction of WiFi P2P support

2014-04-01 Thread Tomasz Bursztyka
. - corner case of p2p enabling/disabling fixed - proper scan stopped given to technology: by type rather than by device. Please review, Tomasz Bursztyka (24): doc: Add an overview documentation about WiFi P2P in ConnMan src: Add a new service type for P2P but only

[PATCH 04/24] technology: Move down dbus registration related functions for futur work

2014-04-01 Thread Tomasz Bursztyka
P2P technology driver registration will create the technology on the fly, thus will need to use technology_get(). Useless function comments are removed as well. --- src/technology.c | 158 +-- 1 file changed, 72 insertions(+), 86 deletions(-) d

[PATCH 03/24] technology: Check if a driver does not exist already before registration

2014-04-01 Thread Tomasz Bursztyka
If this works for any kind of driver, it will be useful in case of P2P driver mostly. --- src/technology.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/technology.c b/src/technology.c index 76f936a..e2de923 100644 --- a/src/technology.c +++ b/src/technology.c @@ -141,6 +141,11 @@ i

[PATCH 08/24] technology: Handle specific case of replying to a p2p scan

2014-04-01 Thread Tomasz Bursztyka
Since p2p technology does not own any devices, but wifi does, when wifi devices delcare a "scan done", it will check relevantly if it's not a p2p scan which ended. --- include/device.h | 3 ++- plugins/bluetooth_legacy.c | 6 -- plugins/wifi.c | 25 +++--

[PATCH 06/24] technology: Move up Powered related functions for future work

2014-04-01 Thread Tomasz Bursztyka
In case of P2P technology - since this one is not tight to any devices - when enabling/disabling it from DBus, the signal about Powered being changed will be raised automatically. --- src/technology.c | 134 +++ 1 file changed, 67 insertions(+),

[PATCH 10/24] wifi: Add support for (un)registering P2P technology if present

2014-04-01 Thread Tomasz Bursztyka
Since P2P is dependent over wifi technology, it will get its technology registered by this one if only one of the interface supports it. Following the same logic, once an interface is removed the wifi technology will check if the P2P technology is still supported by - at least one of - the other in

[PATCH 05/24] technology: Add P2P technology support

2014-04-01 Thread Tomasz Bursztyka
P2P technology is specific in a way it will not own any device due to the fact it is a child technology of wifi technology: wifi technology will own the devices then. Thus, when registering the P2P technology driver, it actually means: a wifi device supports P2P, leading to create directly the P2P

[PATCH 01/24] doc: Add an overview documentation about WiFi P2P in ConnMan

2014-04-01 Thread Tomasz Bursztyka
This document explains how to access such feature in ConnMan and quickly how the nasty details are hidden from application point of view and silently handled by ConnMan itself. --- doc/wifi-p2p-overview.txt | 54 +++ 1 file changed, 54 insertions(+) cre

[PATCH 09/24] gsupplicant: Add a mechanism to know whether P2P is supported or not

2014-04-01 Thread Tomasz Bursztyka
By default, support is false but if P2P "Flush()" method gets a non-erroneous reply: it will be set to true. This tests at once if: - wpa_supplicant has been built with p2p support, then Flush() should exist so no error should come as a reply. - the device supports p2p, then Flush() should not r

[PATCH 02/24] src: Add a new service type for P2P but only used as a technology

2014-04-01 Thread Tomasz Bursztyka
In order to differentiate P2P technology and wifi by their types, let's add a new service type. This is not very clean since P2P technology is never ever going to generate any service (as struct connman_service), but there is currently no other way since technology type is tight to a CONNMAN_SERVI

[PATCH 15/24] peer: Add basic core logic for P2P peer objects

2014-04-01 Thread Tomasz Bursztyka
Basic peer structure and attributes. --- Makefile.am| 4 +- include/dbus.h | 1 + include/peer.h | 45 + src/connman.h | 5 ++ src/main.c | 2 + src/peer.c | 150 + 6 files changed, 205 insertions(+), 2 d

[PATCH 12/24] device: Detail the service type to the scanning method

2014-04-01 Thread Tomasz Bursztyka
It's actually about differentiating the technology, which will be useful when requesting a scan from P2P technology. Since this technology is the child of wifi technology, it will get a scan triggered through the same scanning method. It will be up to the wifi plugin to differentiate what to do acc

[PATCH 11/24] gsupplicant: Add function to start/stop P2P discovery process

2014-04-01 Thread Tomasz Bursztyka
It will be up to the wifi plugin to decide when to stop such process. --- gsupplicant/gsupplicant.h | 6 +++ gsupplicant/supplicant.c | 107 +++--- 2 files changed, 106 insertions(+), 7 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gs

[PATCH 18/24] dbus: Factorize a useful functions for changed objects

2014-04-01 Thread Tomasz Bursztyka
This is currently used only in service.c to signal ServicesChanged() but it will be useful also in peer.c to signal PeersChanged(), thus factorizing this code. --- src/connman.h | 4 +++- src/dbus.c| 19 +++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/co

[PATCH 14/24] gsupplicant: Add the logic handling P2P peers related events/properties

2014-04-01 Thread Tomasz Bursztyka
Listen to DeviceFound and DeviceLost. From there it gets the Peer path and properties, store it into the interface object and call relevant peer_found/peer_lost callbacks provided by the wifi plugin. Due to the fact wpa_supplicant might not (it's a bug) send the device address, the peer identifier

[PATCH 16/24] peer: Add necessary functions to get the properties through DBus

2014-04-01 Thread Tomasz Bursztyka
This will be useful for the Manager API GetPeers() method and PeersChanged() signal. Note that State and IPv4 are provided, but as disconnected for the first, and empty for the second. --- src/connman.h | 2 ++ src/peer.c| 36 2 files changed, 38 insertio

[PATCH 19/24] service: Use the dbus helper to add an object path array to a message

2014-04-01 Thread Tomasz Bursztyka
Such helper will be used also in for peer.c --- src/service.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/service.c b/src/service.c index 2bdfc61..54790a4 100644 --- a/src/service.c +++ b/src/service.c @@ -4324,10 +4324,14 @@ static void append_remov

[PATCH 13/24] wifi: Handling P2P find when relevant service type is given to scan

2014-04-01 Thread Tomasz Bursztyka
Once started, wifi plugin will run a timeout to trigger a stop by itself. --- plugins/wifi.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/plugins/wifi.c b/plugins/wifi.c index cbb2dd8..85e4400 100644 --- a/plugins/wifi.c +++ b/plug

[PATCH 20/24] peer: Add the logic for signaling PeersChanged() relevantly

2014-04-01 Thread Tomasz Bursztyka
A peer is added only when it gets registered to dbus, and is said to be removed if only it is already registered to dbus. --- src/peer.c | 111 + 1 file changed, 111 insertions(+) diff --git a/src/peer.c b/src/peer.c index 77a71f2..b949d

[PATCH 17/24] manager: Improve the API with P2P peers related method and signal

2014-04-01 Thread Tomasz Bursztyka
PeersChanged() signal is declared but not implemented thus will currently never be fired up at this point. --- src/manager.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/manager.c b/src/manager.c index 803f6ce..b31ab4c 100644 --- a/src/manager.c +++ b/src/mana

[PATCH 24/24] client: Add support to printout one specific peer

2014-04-01 Thread Tomasz Bursztyka
With the logic of connmanctl, this requires GetProperties() method to be supported on Peer API side. --- client/commands.c | 66 ++- 1 file changed, 56 insertions(+), 10 deletions(-) diff --git a/client/commands.c b/client/commands.c index 7881c

[PATCH 21/24] wifi: Handle gsupplicant peer event and link the core logic for peers

2014-04-01 Thread Tomasz Bursztyka
Just handling properly peer_found and peer_lost callbacks accordingly, creating or destroying peers. The core logic will know when and what to signal through Manager API's PeersChanged(). --- plugins/wifi.c | 37 + 1 file changed, 37 insertions(+) diff --git a/

[PATCH 22/24] client: Add basic support for P2P peers related signal and method

2014-04-01 Thread Tomasz Bursztyka
Handle PeersChanged() signal and GetPeers() method from Manager API relevantly. --- Makefile.am | 1 + client/commands.c | 115 +- client/peers.c| 122 ++ client/peers.h| 38 +++

[PATCH 23/24] peer: Add and implement support for obsolete GetProperties method

2014-04-01 Thread Tomasz Bursztyka
GetProperties() is declared as obsolete but might be useful in certain occasion. --- doc/peer-api.txt | 12 +++- src/peer.c | 20 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/doc/peer-api.txt b/doc/peer-api.txt index c54d785..e38066f 100644 ---

[PATCH 01/24] doc: Add an overview documentation about WiFi P2P in ConnMan

2014-04-01 Thread Tomasz Bursztyka
This document explains how to access such feature in ConnMan and quickly how the nasty details are hidden from application point of view and silently handled by ConnMan itself. --- doc/wifi-p2p-overview.txt | 54 +++ 1 file changed, 54 insertions(+) cre

Re: 'Not supported' message

2014-04-02 Thread Tomasz Bursztyka
Hi Cliff, Got to see you logs and something is weird: there is no messages coming from plugins/wifi.c You did not filtered out the logs, did you? Would be interesting to see gsupplicant's output as well. Could you retest and get the log this way: CONNMAN_SUPPLICANT_DEBUG=1 connmand -n -d &> c

[PATCH] gsupplicant: Output a relevant warning about P2P support

2014-04-03 Thread Tomasz Bursztyka
Identify which part does not support P2P: wpa_supplicant or the interface itself. --- gsupplicant/supplicant.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 39ff2f1..da33aed 100644 --- a/gsupplicant/supplicant.

[PATCH v2] gsupplicant: Output a relevant warning about P2P support

2014-04-03 Thread Tomasz Bursztyka
Identify which part does not support P2P: wpa_supplicant or the interface itself. --- gsupplicant/supplicant.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index cd35012..9734e48 100644 --- a/gsupplicant/supplican

Re: 'Not supported' message

2014-04-04 Thread Tomasz Bursztyka
Hi Cliff, >Got to see you logs and something is weird: there is no messages coming >from plugins/wifi.c >You did not filtered out the logs, did you? No, not at all, but what is strange is that I have no plugins dir and hence no wifi.c! Maybe you built all as builtin. But in your case I don't

Re: [PATCH 1/1] Fix p2p driver probe

2014-04-04 Thread Tomasz Bursztyka
Hi Eduardo, + struct connman_technology *technology; Useless var, see below. for (list = driver_list; list; list = list->next) { if (list->data == driver) @@ -1254,8 +1255,11 @@ int connman_technology_driver_register(struct connman_technology_driver *driver)

[PATCH] technology: Do not refcount P2P technology as it is dependent on wifi

2014-04-04 Thread Tomasz Bursztyka
P2P technology exists if only wifi technology exists and does not own any devices. Thus it's unnecessary to refcount it more than once. Reported by Eduardo Abinader --- src/technology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/technology.c b/src/technology.c inde

Re: 'Not supported' message

2014-04-06 Thread Tomasz Bursztyka
Hi Cliff, >Do you have a wifi technology appearing in connmanctl ? (technologies >command) Yes, 'connmanctl technologies' gives: /net/connman/technology/wifi Name = WiFi Type = wifi Powered = True Connected = False Tethering = False ConnMan should not show up wifi technology

Re: 'Not supported' message

2014-04-07 Thread Tomasz Bursztyka
Ok then it's really weird: ConnMan should not show up the wifi technology in this case. Let's revisit this from scratch: - give me your hardware specification of the wifi card - what kernel version? - get the latest version of ConnMan from git (1.23), built it with bootstrap-configure (adapt

Re: 'Not supported' message

2014-04-07 Thread Tomasz Bursztyka
Hi, I'm sending four attachments to your email to avoid mailing to the list. But I think I have the reason why I had no wifi; Connman is soft blocking the card when it starts. If I unblock using rfkill, I can scan and connect! Log 1 is with card blocked, Log 2 after I unblock. So how is thi

Re: 'Not supported' message

2014-04-08 Thread Tomasz Bursztyka
Hi Cliff, But if I run 'wpa_supplicant -Dnl80211 -iwlan0 -c/etc/wpa_supplicant.conf' and then 'connmand -n -d' from the connman source, I get the familiar 'Error /net/connman/technology/wifi: Not supported' Again there is no soft blocking anymore - why I don't know. Never run wpa_supplicant

Re: 'Not supported' message

2014-04-09 Thread Tomasz Bursztyka
Hi Cliff, No, but if I start supplicant manually, then I can connect, otherwise I get the error. For some reason connman is not requesting supplicant. Still starting connman from source dir. ConnMan does not request supplicant, it requests its dbus interface. And if wpa_supplicant is proper

Re: Access Point mode set freq

2014-04-09 Thread Tomasz Bursztyka
Hi Michael, Sorry for the late answer Can you point me to your patch in wpa_supplicant? Here: http://lists.shmoo.com/pipermail/hostap/2013-September/028460.html But it probably does not apply anymore. And there had been a lot more patches around ACS recently, and one disabling the interface

Re: 'Not supported' message

2014-04-09 Thread Tomasz Bursztyka
Hi Cliff, Okay, so let's get this right. Supplicant is started by D-bus when Connman contacts D-bus? So there is no need for start up files for supplicant or any of that? Is there anyway Connman could be at fault here by not contacting D-bus properly? No it works properly. There is surely

Re: WiFi Tethering question

2014-04-10 Thread Tomasz Bursztyka
Hi, so what can I do if client device want to connect the AP using WPS >method(both PBC and PIN)? WPS is not supported on the tethering interface. It requires some amount of planning and work to implement. wpa_supplicant's AP mode exposes the necessary parameters to set this up. It would requ

Re: 'Not supported' message

2014-04-11 Thread Tomasz Bursztyka
Hi Cliff, As you're aware one can install four .service files with supplicant. /lib/systemd/system/wpa_supplicant.service has to be enabled if D-Bus interface was built into wpa_supplicant, so that wpa_supplicant D-Bus interface can be started at boot instead of being automatically activated

Re: [PATCH] Configurable IPv4/6-status urls & support for http-status response code 204 for online checks.

2014-04-17 Thread Tomasz Bursztyka
Hi Pasi, Could you resend the patch, through git send-email, so it's under the proper format? With a proper commit message and so on. My comments below. Mostly code style issues but also one fix that should be in another patch: --- diff --git a/include/setting.h b/include/setting.h index a

Re: [PATCH 2/2] Avoid network duplicate unref for eth_dev_remote

2014-04-17 Thread Tomasz Bursztyka
Hi Eduardo, Network unreference is already being done by free_network, called by g_hash_table_remove. This patche prevents from an invalid read during nework removal. I would be curious to see your valgrind output. The reference ethernet.c is removing is the one which is set when the network

Re: [PATCH 2/2] Avoid network duplicate unref for eth_dev_remote

2014-04-17 Thread Tomasz Bursztyka
Hi Eduardo, As you mentioned, the network reference device is freeing is the the one it creates, in this case, it is created in eth_newlink. I could not see any network referenced by eth which is not via device, so that's the reason I patched by removing network_unref and letting device manage i

Re: [PATCH 2/2] Avoid network duplicate unref for eth_dev_remote

2014-04-17 Thread Tomasz Bursztyka
Thanks, Now it's possible to pin point which part is bogus: - connman_network_create() network 0x749d890 - connman_network_ref_debug() 0x749d890 name Wired ref 2 by src/device.c:858:connman_device_add_network() - connman_network_ref_debug() 0x749d890 name Wired ref 3 by src/service.c:6670:upda

[PATCH] ntp: Reset the source id after removal

2014-05-09 Thread Tomasz Bursztyka
Fixes this issue: connmand[3288]: src/ntp.c:__connman_ntp_stop() (connmand:3288): GLib-CRITICAL **: Source ID 144 was not found when attempting to remove it --- src/ntp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ntp.c b/src/ntp.c index c3bef65..e72bc1a 100644 ---

[PATCH v2] ntp: Reset the source id after removal

2014-05-09 Thread Tomasz Bursztyka
Fixes this issue: connmand[3288]: src/ntp.c:__connman_ntp_stop() (connmand:3288): GLib-CRITICAL **: Source ID 144 was not found when attempting to remove it --- src/ntp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ntp.c b/src/ntp.c index c3bef65..b4fe63a 10064

[PATCH 3/3] wifi: Check the returned code when registering the P2P technology driver

2014-05-12 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- plugins/wifi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index e169692..2dd5dc4 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -2025,8 +2025,8 @@ static void p2p_support(GSupplicantInterface *interfac

[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-12 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- gsupplicant/supplicant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 2be773e..b8c89ad 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2427,10 +2427,12 @@ sta

[PATCH 0/3] Various fixes around P2P

2014-05-12 Thread Tomasz Bursztyka
Thanks to Daniel Wagner and his Coverity report, here are 3 fixes on P2P support Tomasz Bursztyka (3): gsupplicant: Fix an emptyness test on an array technology: Fix a false positive null dereference wifi: Check the returned code when registering the P2P technology driver gsupplicant

[PATCH 2/3] technology: Fix a false positive null dereference

2014-05-12 Thread Tomasz Bursztyka
P2P technology cannot exist without wifi technology, so if P2P is present, wifi is present as well. Thus what coverity thinks is a null dereference is a false positive here. Reported by Daniel Wagner --- src/technology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tec

[PATCH] test: Improve p2p-on-supplicant test script for P2P connection

2014-05-12 Thread Tomasz Bursztyka
- Provide a device name for the local p2p device - join or negociate for a group according to distant peer - GroupFinished signal handler added by Eduardo Abinader --- test/p2p-on-supplicant | 175 +++-- 1 file changed, 156 insertions(+), 19 deletion

Re: [PATCH 2/2] test: Arg parsing for p2p-on-supplication

2014-05-13 Thread Tomasz Bursztyka
Hi Eduardo, Minor issue: @@ -100,37 +105,33 @@ class Wpa_s: bus.add_signal_receiver(self.__InterfaceRemoved, path=WPA_PATH, signal_name='InterfaceRemoved') self.__reset() + +self.debug = False unnecessary since it's done below alre

[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- gsupplicant/supplicant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 8a16663..b483f9b 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2411,10 +2411,12 @@ sta

[PATCH 0/3 v2] Various fixes around P2P

2014-05-14 Thread Tomasz Bursztyka
My first version of the patchset was made on top of up-coming patches... Tomasz Bursztyka (3): gsupplicant: Fix an emptyness test on an array technology: Fix a false positive null dereference wifi: Check the returned code when registering the P2P technology driver gsupplicant

[PATCH 3/3] wifi: Check the returned code when registering the P2P technology driver

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- plugins/wifi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 7c412ef..988ca1a 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1885,8 +1885,11 @@ static void p2p_support(GSupplicantInterface *inte

[PATCH 2/3] technology: Fix a false positive null dereference

2014-05-14 Thread Tomasz Bursztyka
P2P technology cannot exist without wifi technology, so if P2P is present, wifi is present as well. Thus what coverity thinks is a null dereference is a false positive here. Reported by Daniel Wagner --- src/technology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tec

Re: Unreachable favorite network

2014-05-14 Thread Tomasz Bursztyka
Hi Julien, Often they think they remove all the favorite networks in the UI list, and they don't understand that some networks are still stored. What do they want to do? Selectively removing some known networks, or removing all known ones? If it's the later, a small script could just do that

Re: Connman crashes when loosing network

2014-05-15 Thread Tomasz Bursztyka
Hi Marcel, I narrowed the problem down to this. In function handle_multi_line (gweb.c:809) a call is made to g_hash_table_lookup but session->result.last_key is NULL. (gdb) print session->result.last_key $1 = (gchar *) 0x0 Is there anything I can do to help you guys further? Interesting. It

[PATCH] gweb: Do not lookup for a NULL key in a hash table

2014-05-15 Thread Tomasz Bursztyka
At this position, no key might have been provided yet. Reported by Marcel Mulder --- Hi Marcel, Does that helps? Btw the logs you provided are missing the gweb parts. Could you run connman like: CONNMAN_WEB_DEBUG=1 connmnand Thanks, gweb/gweb.c | 3 +++ 1 file changed, 3 insertions(+) dif

Re: Connman crashes when loosing network

2014-05-16 Thread Tomasz Bursztyka
Hi Marcel, connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header] connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header] connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header] connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header

Re: Connman crashes when loosing network

2014-05-21 Thread Tomasz Bursztyka
Hi Marcel, Your patch works but that basically skips all multi line headers, so I think you have some coding to do;-) If you want to support multi line headers of course. Sure, the patch was just to verify the crash origin. There is indeed a bit of work to get it right now. Thanks for repo

Re: [PATCH] Change the threshold for background scanning, -45 is actually very good RSSI.

2014-06-17 Thread Tomasz Bursztyka
Hi Pasi, How did you evaluated that -65dbm is better than -45dbm? On scanning events amount? -65 is usually already low signal. (relatively to the noise however) Depends on what you are trying to achieve, a better user experience (better connectivity) or better battery life. I bet such backgro

Re: [PATCH] Change the threshold for background scanning, -45 is actually very good RSSI.

2014-06-18 Thread Tomasz Bursztyka
Hi Pasi, With quite many Qualcomm based Android devices WCNSS settings have: gNeighborLookupThreshold=76 gNeighborReassocThreshold=81 So having -65dBm instead of -45dBm should be still reasonable. Depends on the chip, antenna, driver... It's really particular to all hw. Myself at 3m, I have

Re: Configuring DHCP Server

2014-06-18 Thread Tomasz Bursztyka
Hi, Have you built connman with dnsproxy support? Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

<    1   2   3   4   5   6   7   8   9   10   >