Re: RFR: 8225061: Performance regression in Regex

Hi Naoto, thanks for reviewing! /Claes On 2019-06-01 02:23, naoto.s...@oracle.com wrote: Hi Claes, Looks good to me. Thanks for catching this on so quickly! Naoto On 5/31/19 5:13 PM, Claes Redestad wrote: Hi, recent Unicode 12.1 updates caused a noticeable regression to Mac OS X build

Re: RFR: 8225061: Performance regression in Regex

Hi Claes, Looks good to me. Thanks for catching this on so quickly! Naoto On 5/31/19 5:13 PM, Claes Redestad wrote: Hi, recent Unicode 12.1 updates caused a noticeable regression to Mac OS X build times. Quoting Naoto: "The regression was caused by the call to Grapheme.nextBoundary() in

RFR: 8225061: Performance regression in Regex

Hi, recent Unicode 12.1 updates caused a noticeable regression to Mac OS X build times. Quoting Naoto: "The regression was caused by the call to Grapheme.nextBoundary() in NFCCharProperty.match() method, which got slower with the fix to JDK-8221431 / JDK-8222978 (Unicode 12.1 / Grapheme 12.0

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

> On May 31, 2019, at 2:19 AM, David Holmes wrote: > > Hi Kim, > > This seems reasonable to me. > > Thanks, > David Thanks. > > On 31/05/2019 7:04 am, Kim Barrett wrote: >>> On May 30, 2019, at 3:58 PM, Roger Riggs wrote: >>> >>> Hi Kim, >>> >>> To ensure you see some messages in the

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

> On May 31, 2019, at 9:33 AM, Daniel D. Daugherty > wrote: > > Thumbs up. > > Dan Thanks. > > > On 5/31/19 8:02 AM, Roger Riggs wrote: >> +1 >> >> On 5/31/19 2:19 AM, David Holmes wrote: >>> Hi Kim, >>> >>> This seems reasonable to me. >>> >>> Thanks, >>> David >>> >>> On 31/05/2019

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

> On May 31, 2019, at 8:02 AM, Roger Riggs wrote: > > +1 Thanks. > > On 5/31/19 2:19 AM, David Holmes wrote: >> Hi Kim, >> >> This seems reasonable to me. >> >> Thanks, >> David >> >> On 31/05/2019 7:04 am, Kim Barrett wrote: On May 30, 2019, at 3:58 PM, Roger Riggs wrote:

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

> On May 31, 2019, at 12:32 PM, Alan Bateman wrote: > > On 29/05/2019 13:16, Langer, Christoph wrote: >> Hi Alan, >> >>> The table items in L119-150 look fine, we just need to avoid really long >>> lines One minor comment on L123 is that it might be clearer if you drop >>> "created" from the

Re: RFR [XS,docs] JDK-8225129: Fix minor HTML issues in java.naming

Looks fine. Mandy On 5/31/19 10:37 AM, Jonathan Gibbons wrote: Please review another round of fixes for HTML issues, this time in java.naming. As with the management APIs, there were some inconsistencies in the ranks for the headings, which have been addressed.  The log with the simplified

Re: RFR [XS,docs] JDK-8225129: Fix minor HTML issues in java.naming

+1 > On May 31, 2019, at 1:37 PM, Jonathan Gibbons > wrote: > >

RFR [XS,docs] JDK-8225129: Fix minor HTML issues in java.naming

Please review another round of fixes for HTML issues, this time in java.naming. As with the management APIs, there were some inconsistencies in the ranks for the headings, which have been addressed.  The log with the simplified diff listing is attached. -- Jon JBS:

Re: RFR 8220238 : Enhancing j.l.Runtime/System::gc specification with an explicit 'no guarantee' statement

Hi Martin, True, calling System.gc() and then checking for its hoped-for/expected side-effects is the norm. But its robustness depends on a combination of gc implementation behavior and the particular side-effect expected: allocation, reference processing, etc. Roger On 05/30/2019 01:30 PM,

Re: 8225117: java/math/BigInteger/SymmetricRangeTests.java fails with ParseException

Look fine Brian; cheers, -Joe On 5/31/2019 8:33 AM, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8225117 For SymmetricRangeTests the @ignore action tag needs to be after @library but before @run. For

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 29/05/2019 13:16, Langer, Christoph wrote: Hi Alan, The table items in L119-150 look fine, we just need to avoid really long lines One minor comment on L123 is that it might be clearer if you drop "created" from the sentence. L48-78 is a "wall of text" and links that I don't think will be

jpackage https://jdk.java.net/jpackage/ page error

Incorrect link to https://bugs.openjdk.java.net/browse/JDK-8205991 "Cannot start application (WinLauncher) if path contains non-ascii character" in notes section Link to https://bugs.openjdk.java.net/browse/JDK-8204991 "PPC64: Fix jtreg RTM tests after "8203305: Improve TM detection for enabling

8225117: java/math/BigInteger/SymmetricRangeTests.java fails with ParseException

https://bugs.openjdk.java.net/browse/JDK-8225117 For SymmetricRangeTests the @ignore action tag needs to be after @library but before @run. For StringConstructorOverflow the test is OK as is, but move the @ignore to just before @run for

RE: RFR [XS/docs] JDK-8225094: Fix minor HTML issues in jdk.zipfs

+1 > -Original Message- > From: core-libs-dev On Behalf > Of Jonathan Gibbons > Sent: Freitag, 31. Mai 2019 03:07 > To: core-libs-dev@openjdk.java.net > Subject: RFR [XS/docs] JDK-8225094: Fix minor HTML issues in jdk.zipfs > > Please review a simple docs fix for jdk.zipfs

Re: RFR (s): 8217412 deprecate rmic for removal

+1 On 05/30/2019 09:10 PM, Stuart Marks wrote: Hi all, Please review this patch and CSR request for upgrading the deprecation status of the rmic to from ordinary to terminal (i.e., conceptually set forRemoval=true, though there are no actual annotations involved here). There are no code

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

Thumbs up. Dan On 5/31/19 8:02 AM, Roger Riggs wrote: +1 On 5/31/19 2:19 AM, David Holmes wrote: Hi Kim, This seems reasonable to me. Thanks, David On 31/05/2019 7:04 am, Kim Barrett wrote: On May 30, 2019, at 3:58 PM, Roger Riggs wrote: Hi Kim, To ensure you see some messages in

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

+1 On 5/31/19 2:19 AM, David Holmes wrote: Hi Kim, This seems reasonable to me. Thanks, David On 31/05/2019 7:04 am, Kim Barrett wrote: On May 30, 2019, at 3:58 PM, Roger Riggs wrote: Hi Kim, To ensure you see some messages in the case of timeouts, it would be useful to call

Re: RFR [XS/docs] JDK-8225094: Fix minor HTML issues in jdk.zipfs

looks OK Jon > On May 30, 2019, at 9:07 PM, Jonathan Gibbons > wrote: > > Please review a simple docs fix for jdk.zipfs module-info.java. > > The ranks of the headings are updated to close up the gaps, and a couple of > superfluous are removed. > > Webrev link below, but the patch is small

RFR: 8224975: CSR: Implement JEP 352

Could I please have reviews for the following CSR which details the changes needed for the JEP 352 implementation task: CSR JIRA: https://bugs.openjdk.java.net/browse/JDK-8224975 I'm still hoping to target this for JDK13. The OpenJDK Project Lead explained that this CSR needs to be reviewed

RE: [11u] RFR (Backport): 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, backport looks good. Best regards, Martin > -Original Message- > From: jdk-updates-dev On > Behalf Of Langer, Christoph > Sent: Freitag, 24. Mai 2019 09:52 > To: jdk-updates-...@openjdk.java.net > Cc: core-libs-dev > Subject: [11u] RFR (Backport): 8223553: Fix code

Re: RFR: 8219149: ProcessTools.ProcessBuilder should print timing info for subprocesses

Hi Kim, This seems reasonable to me. Thanks, David On 31/05/2019 7:04 am, Kim Barrett wrote: On May 30, 2019, at 3:58 PM, Roger Riggs wrote: Hi Kim, To ensure you see some messages in the case of timeouts, it would be useful to call System.out.flush() after printing the message in