Nice.
I think deleting code should be like hazard pay, double the normal hourly wage,
but deleting Makefile lines should be triple wage. :) Looks great to me. Not
that I use this makefile much anymore.
-kto
On Aug 27, 2013, at 4:17 PM, Mike Duigou wrote:
> Hello all;
>
> I have updated the
On Mar 1, 2013, at 6:44 AM, Alan Bateman wrote:
>> It's hard to find something more standard than stddef.h.
>>
> It's hard to find something as non-standard as Windows. My point was we just
> need to double check that this builds okay on Windows, which is does.
The only issue I have seen with
+if [ ! -f ${_testclasses} ]
needs to be
+if [ ! -d ${_testclasses} ]
-kto
On Feb 12, 2013, at 9:38 AM, Chris Hegarty wrote:
> Dmitry,
>
> This test is now failing on several platforms, on jdk8 and 7u-dev
>
> ---
>
> result: Passed. Compilation successful
>
> #section:shell
> --
On Feb 23, 2013, at 12:12 PM, Alan Bateman wrote:
> On 23/02/2013 18:06, Martin Buchholz wrote:
>> I am actually encountering this in openjdk7 with the old build system.
>> I can repro the problem in openjdk8 with the old build system, but not the
>> new one.
>>
>> I don't know if you consider
; Kelly,
>>
>> Do you have an idea why I didn't see this failure under jprt?
>>
>> http://sthjprt.se.oracle.com/archives/2013/02/2013-02-08-192233.dsamerso.tl/
>>
>> -Dmitry
>>
>>
>> On 2013-02-12 21:52, Kelly O'Hair wro
Looks fine to me.
-kto
On Feb 1, 2013, at 6:40 AM, Chris Hegarty wrote:
> [ to build-dev and core-libs-dev, expect reviewer from either, but will
> integrate through jdk8/tl ]
>
> This issue is mainly of interest to Oracle engineers, but it effects the
> public hgforest script.
>
> When hgfo
I don't use these netbeans projects, but the changes seem fine to me.
The copyright on the new files says 2007, I assume they need to say 2013?
-kto
On Jan 30, 2013, at 12:24 PM, Mike Duigou wrote:
> This issue still needs a reviewer.
>
> Mike
>
> On Jan 22 2013, at 13:27 , Mike Duigou wrote:
But the build uses applescript, preventing builds via ssh.
But I commend this effort, I consider it important that our testing is as
robust as possible.
-kto
On Jan 25, 2013, at 7:37 AM, Rob McKenna wrote:
> Had a chat with Alexey off list. Since 7162111 is indeed required to get
> these tes
Looks good.
-kto
On Jan 8, 2013, at 6:07 AM, Erik Joelsson wrote:
> Five classes which in jigsaw will be located in the base module currently
> have their native headers generated in a special way (explicitly with javah).
> This was because the base module could not be made dependent on the co
FYI...
After shutting down JPRT I found two systems with ActivationGroupInit java
processes running.
I am assuming that a test case has fired them up and forgotten about them???
Not sure why JPRT did not kill them automatically...
-kto
jprtadm@sc11136053:~> jps -l -m
11651 sun.tools.jps.Jps
On Dec 21, 2012, at 5:01 PM, David Holmes wrote:
> On 22/12/2012 10:11 AM, Kelly O'Hair wrote:
>> On Dec 21, 2012, at 3:27 PM, David Holmes wrote:
>>>> On JarReorder.java, it seems like you have just deleted a warning that
>>>> someone explicitly asked for
On Dec 21, 2012, at 3:27 PM, David Holmes wrote:
> On 22/12/2012 1:18 AM, Kelly O'Hair wrote:
>>
>> On Dec 20, 2012, at 10:18 PM, David Holmes wrote:
>>
>>> webrevs:
>>>
>>> top-level repo:http://cr.openjdk.java.net/~dholmes/8004265/webrev
On Dec 20, 2012, at 10:18 PM, David Holmes wrote:
> webrevs:
>
> top-level repo: http://cr.openjdk.java.net/~dholmes/8004265/webrev.top/
These comments in Main.gmk don't seem to make sense:
117 # Note: This double-colon rule is intentional, to support
118 # custom make file integration.
119
This file was added by me, to the jdk repo, mostly for reading class files.
But as I recall (it was a while ago) the idea was that this file would describe
the classfile format for the jdk being released.
As I recall, the hotspot sources never exported anything like this, certainly
not something
Looks good to me.
-kto
On Nov 13, 2012, at 9:26 PM, Jonathan Gibbons wrote:
> See http://cr.openjdk.java.net/~jjg/8000404/webrev/
>
> A while back, we added a new annotation javax.tools.GenerateNativeHeader, to
> mark classes that contained constants of interest to native code, such that
> to
On Nov 4, 2012, at 2:04 AM, David Holmes wrote:
> On 3/11/2012 3:27 AM, Kelly O'Hair wrote:
>> All changes to JDK sources require a CR, an OpenJDK author name, and a
>> review by a second OpenJDK author.
>> So although you can automate the preparation of th
Include me on any review requests for these things, I'll be happy to be a
reviewer.
-kto
On Nov 2, 2012, at 1:08 PM, Steve Sides wrote:
> On 11/2/2012 9:47 AM, Kelly O'Hair wrote:
>>
>> It looked fine to me.
>>
>> One of the reasons this has fallen
All changes to JDK sources require a CR, an OpenJDK author name, and a review
by a second OpenJDK author.
So although you can automate the preparation of the commit, you cannot fully
automate this process.
There have been many discussions over the years about automating various
changes, anythin
It looked fine to me.
One of the reasons this has fallen through the cracks so much is because nobody
has any time to do it.
Completely automating it is risky, and it needs to be reviewed. So it needs an
official owner and
someone to automate the whole thing as much as possible.
My recommendati
If someone is doing a partial build (without langtools) the import jdk is used
for javac compilation, not the boot jdk javac.
This has not changed.
The boot jdk javac is only used to build langtools and the hotspot
serviceability agent.
-kto
On Oct 31, 2012, at 7:22 PM, David Holmes wrote:
>
intent of the change, since a
>> number of .m files in the AWT were changed to use THIS_FILE.
>>
>> -- Scott K.
>>
>> On Sep 6, 2012, at 9:30 AM, Kelly O'Hair wrote:
>>
>>>
>>> Just FYI...
>>>
>>> these build changes
Just FYI...
these build changes do touch sources in various teams, please let me know if
you have issues with these changes.
-kto
Begin forwarded message:
> From: "Kelly O'Hair"
> Subject: Need reviewers: more predictable binaries
> Date: September 5, 2012 9:0
On Jul 30, 2012, at 2:43 PM, David Holmes wrote:
>> Ah!, oh sorry that won't fly this is c code :-( , not c++, MSC does not
>> allow it.
>
> Wow that is unbelievable! for-loop variable declarations are part of C99 :(
Until recently we told the Solaris compilers to not allow any C99 features so
Something seems strange here:
http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
It's like someone was avoiding overall quotes, but using them to add spaces
somehow...
I sure would like to get rid of this shell logic, seems like there are lots
repeated
On Jun 11, 2012, at 5:44 AM, Tom Hawtin wrote:
>
>
> On 07/06/2012 21:39, Joe Darcy wrote:
>> I'd like to see some "()" on this line!
>>
>> 470 ClassLoader cl = cc != null ? cc.getClassLoader() : null;
>
> It's `a==b ? c : d` is such an incredibly common idiom in Java, and generally
> unambi
I am seeing this testcase fail on Windows 32&64bit and 32bit Linux&Solaris X86
java/lang/Math/WorstCaseTests.java
Does anyone know anything about this?
-kto
--
TEST: java/lang/Math/WorstCaseTests.java
JDK under test: (/tmp/jprt/P1/020333.khazra/test
Change looks fine to me.
-kto
On May 18, 2012, at 3:04 PM, Kumar Srinivasan wrote:
> Hi,
>
> Fixed CR reference in test.
>
> http://cr.openjdk.java.net/~ksrini/7170087/
>
> The original changset for reference.
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f68c854fa584
>
> Thanks in advance.
>
Looks fine.
-kto
On Apr 22, 2012, at 8:51 AM, Alan Bateman wrote:
>
> I need a reviewer for a trivial change to get jdk8/tl building on Mac again.
> Jim's changes for 7130404 [1] change the os.arch variable to "x86_64" to be
> compatible with Apple's JDK but the change-set doesn't add a jvm.c
Looks fine to me.
-kto
On Apr 10, 2012, at 8:39 PM, Joe Wang wrote:
> After removing the jaxp source drop bundle process, refer to 7150324, the
> source structure needs to be changed to be consistent with that of jdk7. I
> will rename jdk8/jaxp/src/share/classes to jdk8/jaxp/src before updatin
On Mar 27, 2012, at 2:26 AM, Alan Bateman wrote:
> On 27/03/2012 05:21, David Holmes wrote:
>>
>> It's a little disconcerting that 10 seconds is not enough time, but we have
>> so many timing issues these days it is not that surprising. :(
> The machines in question are relatively beefy but the
Looks ok to me.
-kto
On Feb 20, 2012, at 4:46 AM, Alan Bateman wrote:
>
> When Kelly setup the ProblemList file to exclude tests then he initially
> excluded dozens of tests that he observed failing on platform or in some
> configuration. We've been chipping away at these issues since then bu
releases. I wanted to make it easy to bring in a new component version, and
just as easily
back it out. Having them in separate repos has it's positives.
-kto
>
>>
>> --Joe
>>
>> On 12/24/2011 8:56 AM, Kelly O'Hair wrote:
>>> Looks great to me.
&
Change looks fine, but the jax-ws team needs to place this zip bundle at
http://download.java.net/glassfish/components/jax-ws/openjdk/jdk8
-kto
On Feb 15, 2012, at 9:23 AM, Alan Bateman wrote:
>
> The current JAX-WS has a residual dependency on com.sun.mirror that breaks
> SKIP_BOOT_CYCLE=fal
Looks good.
Glad to see the ProblemList.txt file get trimmed down.
-kto
On Feb 12, 2012, at 9:45 AM, Alan Bateman wrote:
>
> It's time to sync up jdk/test/ProblemList.txt again. As a reminder, this is
> the file that serves as the exclude list when running the tests via Makefile
> ("cd jdk/t
I'm seeing all kinds of messages like:
bit length overflow
code 12 bits 6->7
bit length overflow
code 5 bits 6->7
bit length overflow
code 5 bits 6->7
When ever a jdk7u or jdk8 fastdebug built jdk is used.
It appears to be coming from here:
jdk/src/share/native/java/util/zip/zlib-1.2.5/trees
; My grep of a current JDK 8 build log for 64 bit Linux shows the only malloc
> warnings
> are in hotspot management code. So I am waiting for the proof of the real
> problem
>
> And I can speak for 2d, and if there's 2D files touched I would like to see
> any changes
>
On Jan 18, 2012, at 12:19 AM, Jonathan Lu wrote:
> Hi core-libs-dev,
>
> I found that for some native code of OpenJDK code base, malloc() is used
> without including header file stdlib.h, such as following files,
> ./src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c
> ./src/solaris/native/s
On Jan 8, 2012, at 3:35 PM, David Holmes wrote:
> Hi Kelly,
>
> On 7/01/2012 4:35 AM, Kelly O'Hair wrote:
>> Still need a reviewer for this small change. Any volunteers?
>
> Seems okay. Did we determine how they went missing in the first place?
A long long time ago
Still need a reviewer for this small change. Any volunteers?
-kto
Begin forwarded message:
> From: "Kelly O'Hair"
> Subject: Need reviewer: ant script bug in jaxws
> Date: January 4, 2012 17:59:32 PM PST
> To: core-libs-dev Libs
> Cc: miroslav@oracle.com
&g
For jdk8. Had this on my CR list for a long time. :^(
Need reviewer. This is an ant script change in jaxws
Minor issue of missing files:
META-INF/mailcap.default
META-INF/mimetypes.default
In the dist/lib/classes.jar file created by the jaxws build and delivered into
the jdk.
7096063: /M
On Dec 31, 2011, at 2:31 AM, Alan Bateman wrote:
> On 31/12/2011 01:31, Kelly O'Hair wrote:
>> Just wondering if anyone has seen this testcase failure.
>> I'm using Fedora 9 x86.
>>
>> -kto
>> :
>>
>> Test DatagramChannel to INET
So you have a review from me.
I think you need to send this CR/webrev and request for approval to the
jdk7u-...@openjdk.java.net alias for 7u4
Or did you do that already? Hopefully we can fix this drop stuff before
12/12/12 and the end of the world. 8^{
-kto
On Dec 30, 2011, at 10:11 AM, J
Just wondering if anyone has seen this testcase failure.
I'm using Fedora 9 x86.
-kto
--
TEST: java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
JDK under test:
(/tmp/jprt/P1/143001.jprovino/testproduct/linux_i586_2.6-product)
openjd
Two repositories use this drops mechanism, jaxp and jaxws, when both are
changed, I will address the readme file.
-kto
On Dec 28, 2011, at 10:00 AM, Gary Adams wrote:
> I see in the webrev the removal of drops.dir from the ant build.xml.
> Should similar updates be applied to README-builds.htm
;s how our dev/test
> process is set up.
>
> --Joe
>
> On 12/24/2011 8:56 AM, Kelly O'Hair wrote:
>> Looks great to me.
>>
>> There is still the issue of making sure the right people (like you :^) are
>> the ones patching this code, so we know
>>
Looks great to me.
There is still the issue of making sure the right people (like you :^) are the
ones patching this code, so we know
what we have matches the public JAXP project.
-kto
On Dec 23, 2011, at 1:27 PM, Joe Wang wrote:
> Hi All,
>
> We have prepared a jaxp update for 7u4. The liste
On Dec 12, 2011, at 3:02 AM, Alan Bateman wrote:
> On 11/12/2011 21:48, Kelly O'Hair wrote:
>> Re-organized the testing targets, moved jdk_tools1 out of the default test
>> targets.
>>
>> Running "cd test&& make" should run the default
Re-organized the testing targets, moved jdk_tools1 out of the default test
targets.
Running "cd test && make" should run the default test list, and should be 100%
pass, in theory.
(Note: Use of the jdk/test/Makefile utilizes jtreg with a default set of
options running a default
set of tests wh
Looks ok to me.
-kto
On Nov 22, 2011, at 10:55 PM, David Holmes wrote:
> We need to make an adjustment to the link instructions used for libjava in
> embedded builds, as defined in Defs-embedded.gmk
>
> webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/
>
> Summary: system soft-float
On Nov 16, 2011, at 8:56 AM, Alan Bateman wrote:
> On 16/11/2011 16:29, Gary Adams wrote:
>>
>> The jtreg tests that use othervm along with a timeout argument should be
>> fairly reliable in getting a consistent result. The tests that did not
>> specify
>> othervm may run into problems, if they
On Nov 16, 2011, at 8:29 AM, Gary Adams wrote:
>
> The jtreg tests that use othervm along with a timeout argument should be
> fairly reliable in getting a consistent result. The tests that did not specify
> othervm may run into problems, if they are run concurrently with other tests.
>
> Here's
Please keep in mind that this was a very small, obviously safe, one line change.
More significant changes could take longer. Just to set expectations. ;^)
-kto
On Oct 11, 2011, at 8:40 AM, Steve Poole wrote:
> On Mon, 2011-10-10 at 08:04 -0700, Kumar Srinivasan wrote:
>
> That was quick! Thank
.
-kto
On Oct 10, 2011, at 4:34 PM, Neil Richards wrote:
> On Mon, 2011-10-10 at 16:27 +0200, Kelly O'Hair wrote:
>> This patch looks fine to me.
>>
>> Have you been working with anyone to get your contributions pushed in?
>>
>> -kto
>>
>
> Hi K
This patch looks fine to me.
Have you been working with anyone to get your contributions pushed in?
-kto
On Oct 10, 2011, at 2:58 PM, Steve Poole wrote:
> hi all,
>
> Please find attached a trivial patch to remove an unused variable in
> jdk/src/solaris/bin/java_md.c
>
> The present of the va
This one failed on Solaris 10u6 sparc, look familiar to anyone?
-kto
--
TEST: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java
JDK under test:
(/tmp/jprt/P1/001456.jprtadm/testproduct/solaris_sparc_5.10-product)
openjdk version
Anyone seen this testcase failure before?
-kto
--
TEST: java/util/Locale/Bug6989440.java
JDK under test:
(/tmp/jprt/P1/001456.jprtadm/testproduct/solaris_i586_5.10-product)
openjdk version "1.8.0-internal"
OpenJDK Runtime Environment (build 1.8.0-i
On Sep 30, 2011, at 6:28 PM, Alan Bateman wrote:
> Kelly O'Hair wrote:
>> Has anyone seen this testcase fail like this?
>>
>> FAILED: java/nio/channels/FileChannel/Transfers.java
>>
>> ACTION: main -- Failed. Execution failed: `main' threw exception:
Has anyone seen this testcase fail like this?
FAILED: java/nio/channels/FileChannel/Transfers.java
ACTION: main -- Failed. Execution failed: `main' threw exception:
java.lang.RuntimeException: Some tests failed
REASON: Assumed action based on file name: run main Transfers
TIME: 3.337 seconds
On Sep 19, 2011, at 10:05 PM, David Holmes wrote:
> Thanks Alan. Other failures haven't shown up thus far so for now we'll just
> address these ones (it improves the pass rate somewhat :) ).
>
> Could I get a second review from someone in serviceability?
They look fine to me.
-kto
>
> Thank
t jdk_sound to its correct alphabetical position.
>
> Thanks
> Max
>
>
> On 09/07/2011 02:30 AM, Kelly O'Hair wrote:
>> Looks fine.
>>
>> But the files make/jprt.properties in both the root repository and the jdk
>> repository
>> will minor
On Sep 7, 2011, at 4:07 AM, Alan Bateman wrote:
> Weijun Wang wrote:
>> Updated:
>>
>> root: http://cr.openjdk.java.net/~weijun/7087428/control/webrev.00/
>> jdk: http://cr.openjdk.java.net/~weijun/7087428/webrev.01/
>>
>> I also update Makefile to put jdk_sound to its correct alphabetical posi
Looks fine.
But the files make/jprt.properties in both the root repository and the jdk
repository
will minor changes to add jdk_sound as a new test for JPRT.
You can place it in the jprt.make.rule.all.test.targets list.
-kto
On Sep 6, 2011, at 8:12 AM, Weijun Wang wrote:
> Hi Kelly
>
> Webrev
On Jul 27, 2011, at 4:28 PM, Dr Andrew John Hughes wrote:
> On 11:58 Wed 27 Jul , Kelly O'Hair wrote:
>>
>> On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote:
>>
>>> Hi,
>>>
>>> Can someone please tell me why:
>>>
On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote:
> Hi,
>
> Can someone please tell me why:
>
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf4edfcd7119
>
> reverted my earlier fix:
>
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80368890a2a0
>
> without any discussion?
My apologies,
Looks ok to me.
-kto
On Jul 18, 2011, at 2:48 PM, Kumar Srinivasan wrote:
> Hi,
>
> Please review
> http://cr.openjdk.java.net/~ksrini/7067922
>
> Thanks
> Kumar
>
Looks fine to me.
-kto
On Jul 15, 2011, at 2:48 PM, Kumar Srinivasan wrote:
> Updated the webrev.
>
> http://cr.openjdk.java.net/~ksrini/7062969/webrev/
>
> Thanks
> Kumar
>
>> On 7/15/2011 11:38 AM, Kumar Srinivasan wrote:
>>> Hello,
>>>
>>> http://cr.openjdk.java.net/~ksrini/7062969/
>>>
Heads up. The jdk7/tl forest has a new jaxp source drop dependency.
7044493: Incorrectly formated GPL headers in JDK7 JAXP source drop
http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bdf77cbd9958
The new source drop bundle is called:
jaxp145_01.zip
So if you have your own ALT_DROPS_DIR cache, y
Heads up. The jdk7/tl forest has a new jaxws source drop dependency.
Will likely be integrated into b144.
7042773: Integrate JAXWS 2.2.4 update to JDK7
http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/6d59d563f187
The new jaxws source drop bundle is called:
jdk7-jaxws2_2_4-b02-2011_05_09.zip
So
Heads up. The jdk7/tl forest has a new jaxp source drop dependency.
7040147: jaxp 1.4.5 jdk7 integration
http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/30129a58aacc
The new jaxws source drop bundle is called:
jaxp-1_4_5.zip
So if you have your own ALT_DROPS_DIR cache, you need to add these files:
ooks fne. ;^)
-kto
On Apr 12, 2011, at 10:57 AM, Lance Andersen - Oracle wrote:
> Hi folks,
>
> Looking for a reviewer for the following simple change to ResultSet to
> address CR 7007772
>
> hg diff
> diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java
> --- a/src/share/classes/ja
7034918: Integrate JAX-WS 2.2.4-b01 in to JDK 7
http://cr.openjdk.java.net/~ohair/openjdk7/jaxws-7034918/webrev/
More details on the changes here:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7034918
The new jaxws source drop bundle is called:
jdk7-jaxws2_2_4-b01-2011_04_08.zip
So if
Looks fine to me.
-kto
On Apr 7, 2011, at 12:05 PM, Kumar Srinivasan wrote:
> Hi,
>
> This fixes a build issue in non-product builds, with the fix for 7033954.
> During the pack200 build the wrong mapfile is picked up due to the
> idiosyncrasy of the makefile. Thus the fix is simply and explici
And the big man in the sky opens his book of good deeds, looks up Lance, and
adds
"4/7/2011 - Lance fixed warning errors". ;^)
Thanks!
-kto
On Apr 7, 2011, at 6:48 AM, Lance Andersen - Oracle wrote:
> Hi all,
>
> This is a request for a review of the changes to remove the lint warnings for
On Mar 29, 2011, at 6:48 AM, Alan Bateman wrote:
> Kelly O'Hair wrote:
>> I'll admit that I'm not following this C code horribly well, but overall it
>> does look much cleaner.
>> As well as I can follow it, it looks good.
>>
>> In the Makefile
I'll admit that I'm not following this C code horribly well, but overall it
does look much cleaner.
As well as I can follow it, it looks good.
In the Makefile, could we get some comments as to why the lib's are needed and
also some
comments as to what the delayload means and why it is important?
Looks good to me.
-kto
On Mar 7, 2011, at 11:39 AM, Rama Pulavarthi wrote:
> Thanks for the review. We had to make additional changes to run the
> tests. Hopefully this is the final webrev for this issue.
>
> Please review this new webrev which also has changes to
> jdk/test/Makefile to run th
Need reviewer for change in jaxp source drop bundle
7023289: jaxp 1.4.5 development jdk7 2nd integration
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/
Joe or someone from the JAXP team may want to comment on the specific changes
in this new
source bundle.
-kto
Makefile change is fine. Sorry I wasn't able to look at the code
changes.
-kto
On Feb 24, 2011, at 10:30 AM, Mandy Chung wrote:
7016707: Remove the BootClassLoaderHook for jkernel support
Webrev at:
http://cr.openjdk.java.net/~mchung/7016707/webrev.00/
The sun.jkernel.* classes have been
Ok with me.
-kto
On Feb 21, 2011, at 10:57 AM, Mike Duigou wrote:
Hi All;
I need a quick review for a very minor issue. An EnumSet unit test,
EnumSetBash.java, is currently disabled but the bug which caused it
to be disabled seems to no longer be reproducible. It is theorized
that it ha
Not sure about a policy, but yes typically we require the previous JDK
release to be
the "boot" jdk. However, the policy, if you want to call it that, has
relaxed a bit, it does
need to be a previously released jdk.
We require a jdk6u14 or newer for jdk7, and I suspect the newer jdk6
update
On Dec 17, 2010, at 12:06 PM, Joe Darcy wrote:
On 12/17/2010 11:57 AM, Stuart Marks wrote:
On 12/17/10 6:54 AM, Paul Benedict wrote:
Do it as two commits (one for diamond, the other for line
formatting)
that way you can keep the work separate. You may even want 2 Sun
tracking issue in case
On Dec 16, 2010, at 12:45 AM, Alan Bateman wrote:
Stuart Marks wrote:
Hi all,
As Joe Darcy mentioned yesterday [1], I'm working on updating the
JDK libraries to use the new JDK 7 Coin features. The first feature
is the diamond operator [2]. This first round of changes includes
java.lang
Looks good to me. Thanks for doing this.
-kto
On Nov 18, 2010, at 2:03 PM, Xueming Shen wrote:
Alan, Kelly,
Would you please help review the patch that tries to address those
compiler warning
in zip area?
http://cr.openjdk.java.net/~sherman/6989471/webrev
I added some comments to docume
So some of these changes are using the new jdk7 language features?
(diamond operator)
Is this a first, or is this happening already? Just curious.
http://cr.openjdk.java.net/~ksrini/6990106/webrev.00/src/share/classes/com/sun/java/util/jar/pack/Attribute.java.sdiff.html
460 return
On Nov 9, 2010, at 3:42 AM, Alan Eliasen wrote:
On 11/09/2010 03:13 AM, Alan Bateman wrote:
The web-discuss mailing list is the place for infrastructure
discussion.
As it happens, someone started a discussion about this issue just a
few
days ago:
http://mail.openjdk.java.net/pipermail/web
, Kelly O'Hair wrote:
Anyone seen this failure before... The very latest jdk7/tl/jdk
repo
I'm testing Windows XP & VS2010 builds:
Created ../../../build/windows-i586/tmp/sun/java.util.zip/zip/
obj_gO/zip.lcf
C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll -out:../../../build/
window
Anyone seen this failure before... The very latest jdk7/tl/jdk repo
I'm testing Windows XP & VS2010 builds:
Created ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/
zip.lcf
C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll -out:../../../build/windows-
i586/tmp/sun/java.util.zip/zip/ob
Looks fine.
-kto
On Oct 7, 2010, at 11:20 AM, Alan Bateman wrote:
Another small patch to address a few compiler warnings, this time
with the old type inference verifier (libverify) when doing debug
builds. This is debug code that isn't compiled in when doing product
builds.
-Alan.
d
On Oct 6, 2010, at 2:28 PM, Mandy Chung wrote:
On 10/06/10 13:37, Alan Bateman wrote:
This batch eliminates a bunch of compiler warnings from the native
code:
http://cr.openjdk.java.net/~alanb/6989466/webrev/
Looks good to me. I will defer to your build to verify if there is
any rema
This looks ok to me. If it gets past a JPRT build on all platforms I
think it's golden.
Thank you. May your fortune cookies always be positive. ;^)
-kto
On Oct 6, 2010, at 1:37 PM, Alan Bateman wrote:
This batch eliminates a bunch of compiler warnings from the native
code:
http://cr.ope
Looks ok to me.
Maybe your comment should be added to the test? Might explain the code
better.
-kto
On Oct 6, 2010, at 9:18 AM, Alan Bateman wrote:
The fix for 6981138 a few weeks ago added another test to test/java/
lang/ProcessBuilder/Basic.java. That test is failing on Solaris
becau
On Aug 2, 2010, at 2:52 PM, Martin Buchholz wrote:
Hi Chris (or others),
Here's a fix for a little bug I introduced in jdk7-b94
http://bugs.sun.com/view_bug.do?bug_id=6955504
6955504: (str) String[Builder/Buffer].append(char[],int,int) throws
OutOfMemoryError in b94
http://cr.openjdk.java.
Good idea.
-kto
On Jul 26, 2010, at 8:43 AM, Frances Ho wrote:
This is great! Can you let us know what your schedule so I can try to
setup a corelib conversation? Thanks.
_Frances
On 7/23/2010 4:33 PM, Martin Buchholz wrote:
A number of us folks who contribute to core libraries (myself, D
Need a reviewer:
6967036: Need to fix links with // in Javadoc comments
http://cr.openjdk.java.net/~ohair/openjdk7/links-6967036/webrev/
-kto
Joe,
Looks like I need to undo the removal of the sun/nio/cs/ext classes
from rt.jar
(they supposedly belonged in charsets.jar). Control builds of jdk7-tl
are broken.
Apparently in the short time that they have been in jdk7 rt.jar, we
seem to have
created a dependency on some of the sun/n
6933622: Duplicate class files in rt.jar and charsets.jar
6895003: JarReorder is not excluding a requested file.
6939022: Source code adjustments for parfait compilation
http://cr.openjdk.java.net/~ohair/openjdk7/jar-reorder/webrev/
The first two changes are related. Excluding items with JarReo
On Jun 20, 2010, at 1:49 AM, Alan Bateman wrote:
Kelly O'Hair wrote:
Looks great to me.
Thanks to everyone for fixing tests like this.
People should keep in mind that some of the test batches in the jdk/
test/Makefile
do NOT run in samevm mode at all, e.g. jdk_awt, jdk_beans2,
jdk_b
Looks great to me.
Thanks to everyone for fixing tests like this.
People should keep in mind that some of the test batches in the jdk/
test/Makefile
do NOT run in samevm mode at all, e.g. jdk_awt, jdk_beans2,
jdk_beans3, jdk_management1,
jdk_management2, jdk_nio2, jdk_nio3, jdk_rmi, jdk_secur
Looks great to me.
-kto
On Jun 15, 2010, at 4:13 PM, Mandy Chung wrote:
Hi Kelly,
Can you review the test fix for:
6961518: TEST_BUG: add @run main/othervm in tests that call
setSecurityManager
Webrev at:
http://cr.openjdk.java.net/~mchung/6961518/webrev.00/
Thanks
Mandy
It's been a while since I worked with this stuff, but I would have
done a:
jclass cls = env->FindClass("Test");
Which, if I recall, FindClass actually initializes the class.
Just a stab in the dark.
-kto
On Jun 9, 2010, at 12:39 PM, Martin Buchholz wrote:
David, Thanks for the bug arc
1 - 100 of 138 matches
Mail list logo
