Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

review > process! I'd rather leave it in; I think I added it at some point in response to a clarification request from JCK. > Thank you for putting in the extra working examples. That will really help > users pick the right patterns. Yes. It's interesting new API that deserves some exampl

Re: RFR: 8166840: Synthetic bridge constructor in ArrayList$Itr blocks inlining

https://bugs.openjdk.java.net/browse/JDK-8166840 > Webrev: http://cr.openjdk.java.net/~redestad/8166840/webrev.01/ > > Thanks! > > /Claes > > [1] > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-September/024407.html -- <http://www.oracle.com/> D

Re: RFR: 8166287: MultiReleaseJarAPI.isMultiReleaseJar(): failure java.nio.file.AccessDeniedException: custom-mr.jar

our nightly hotspot testing, I intend to push this to jdk9/hs - > unless anyone objects. > > Thanks! > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

Hello, reviews, please ... ? Thanks, Michael > Am 26.09.2016 um 21:01 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Hi John, all, > > thank you very much for your reviews - may I ask for a second round? > > The updated webrev is at > http://cr.op

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

which was List::iterator. That was intended to corresponding > to the for-each syntax, and it is hard (and probably non-performant) to ask > the user to rebuild a MH for Iterable::iterator at each use site for > iteratedLoop. > > — John -- <http://www.oracle.com/> Dr.

Re: RFR(L): 8161211: better inlining support for loop bytecode intrinsics

Hi John, thank you for your review. Comments on your suggestions are inlined. > Am 22.09.2016 um 20:04 schrieb John Rose <john.r.r...@oracle.com>: > On Sep 22, 2016, at 12:23 AM, Michael Haupt <michael.ha...@oracle.com > <mailto:michael.ha...@oracle.com>> wrote: &

Re: RFR(L): 8161211: better inlining support for loop bytecode intrinsics

Transform key = Transform.of(Transform.BMH_AS_ARRAY, size); >> +LambdaForm form = getInCache(key); >> +if (form != null) { >> +return form; >> + } >> >> Please, add an assert to ensure the cached LF has the same constraint as >> re

Re: MethodHandle loop body parameters and Stream.reduce accumulator parameters are not in the same order

dex, array); > instead of >value = body(index, value, array); > > the other loop combinators do not be to be changed. > > cheers, > Rémi > ___ > mlvm-dev mailing list > mlvm-...@openjdk.java.net > http://mail.openjdk.ja

RFR(L): 8161211: better inlining support for loop bytecode intrinsics

oop.Invoke.whileLoop 146.039 8.573 MethodHandlesWhileLoop.Invoke.whileLoop 10 240.963 21.088 MethodHandlesWhileLoop.Invoke.whileLoop 100 2092.671 159.016 -- <http://www.oracle.com/> Dr.

Re: RFR: 8164451: Generate all zero and identity forms at link time

eneration > during java.lang.invoke bootstrap. > > Thanks! > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.

RFR(S): 8164102: MethodHandles.countedLoop/4 works incorrect for start/end = Integer.MAX_VALUE

were chosen. The fix - passing the decremented counter value to the predicate as well as the body - is temporary, as a larger overhaul of the JEP 274 API is under way as part of the fix to JDK-8151179. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal

Re: RFR: 8164044: Generate corresponding simple DelegatingMethodHandles when generating a DirectMethodHandle

om LF and tuck away in a map we only create and initialize when > actually debugging). > > This patch removes 11 out of the 39 classes generated on first use of the > StringConcatFactory in a simple test, amounting to a ~10ms speedup on my > machine. > > Thanks! > >

Re: RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

... anyone, please? :-) Thanks, Michael > Am 12.08.2016 um 02:27 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Dear all, > > please review this change. > Bug: https://bugs.openjdk.java.net/browse/JDK-8151179 > Webrev: http://cr.openjdk.java.ne

Re: RFR: 8163946: java/lang/String/concat/WithSecurityManager.java fails after 8163878

g the MAX_ARITY constant to MethodHandleStatics > avoids the issue and might be sensible to do regardless. > > bug: https://bugs.openjdk.java.net/browse/JDK-8163946 > webrev: http://cr.openjdk.java.net/~redestad/8163946/webrev.01/ > > Thanks! > > /Claes -- <http://www.oracle.com/

RFR(L): 8151179: address issues raised by JCK team on JEP 274 API

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland

Re: RFR: 8163878: Remove unnecessary bridge methods, allocations in java.lang.invoke

se/JDK-8163878 > > All in all -45K executed bytecodes and 9 fewer loaded classes in my favored > startup test. > > Thanks! > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 20

Re: RFR: 8163814: JDK build has been failing after 8163373

8163373, breaking the build. > > Please approve pushing it under this bug ID ASAP: > http://cr.openjdk.java.net/~redestad/8163373/webrev.02/src/java.base/share/classes/java/lang/invoke/GenerateJLIClassesHelper.java.html > > Thanks, and sorry > > /Claes > -- <http:/

Re: RFR(S): 8161212: Test times out: java/lang/invoke/LoopCombinatorLongSignatureTest.java

Hi Claes, thank you. Of course you're right about the -run option; I've replaced this with a -D interface and pushed that version. Best, Michael > Am 18.07.2016 um 12:57 schrieb Claes Redestad <claes.redes...@oracle.com>: > > Hi, > > On 2016-07-13 15:12, Michael Hau

RFR(S): 8161212: Test times out: java/lang/invoke/LoopCombinatorLongSignatureTest.java

, running the constructed loop should be optional. The fix disables running the loop by default and introduces a -run option that can be used if the loop should actually be run. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +

Re: RFR 8160885 Unsafe.compareAndExchangeDouble/FloatAcquire should defer to compareAndExchangeLong/IntAcquire

> Double.doubleToRawLongBits(x)); > +long w = compareAndExchangeLongAcquire(o, offset, > + > Double.doubleToRawLongBits(expected), > + > Double.doubleToRawLongBits(x)); >

Re: RFR(S): 8160717: MethodHandles.loop() does not check for excessive signature

le.com>: > > > > On 2016-07-06 16:05, Paul Sandoz wrote: >> >>> On 6 Jul 2016, at 13:31, Claes Redestad <claes.redes...@oracle.com> wrote: >>> >>> >>> >>> On 2016-07-06 12:45, Paul Sandoz wrote: >>>> >>&

Re: RFR(S): 8160717: MethodHandles.loop() does not check for excessive signature

nge, maybe we should seek to improve > robustness by asking the ASM project to add more distinctive exceptions, say, > create a MethodTooLargeException or similar, in which case we could change > the catch to be more specific. Four thumbs up: domain-specific meaningful exceptions are A G

Re: RFR(S): 8160717: MethodHandles.loop() does not check for excessive signature

le idioms in a row. When a problem arises only during class file generation, it will not be easy to trace that back to the problematic intrinsic. Also, inlining at LF level is conceivable, complicating the matter further. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Pr

Re: RFR(S): 8160717: MethodHandles.loop() does not check for excessive signature

too large. In many other cases it is justified to bail altogether with an InternalError. Wrapping cw.toClassBytes() is a first approximation. Best, Michael > Am 06.07.2016 um 11:30 schrieb Paul Sandoz <paul.san...@oracle.com>: > > >> On 6 Jul 2016, at 10:43, Michael Haupt &

Re: RFR(S): 8160717: MethodHandles.loop() does not check for excessive signature

sionUID is enforced in the build. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergas

RFR(S): 8160717: MethodHandles.loop() does not check for excessive signature

ll be logged to the console. The PerfCounter java.lang.invoke.failedLambdaFormCompilations tracks failing LF compilations. It can be printed with jstat -J-Djstat.showUnsupported=true -snap -a file:// Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Tec

Re: RFR of JDK-8160866: IntPrimitiveOpsTests.java still in ProblemList.txt while related bug has been closed

K-8160866 > webrev: http://cr.openjdk.java.net/~mli/8160866/webrev.00/ > > Thank you > -Hamlin -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team

Re: RFR(L): 8143211: provide bytecode intrinsics for loop and try/finally executors

<http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. &

Re: RFR(L): 8143211: provide bytecode intrinsics for loop and try/finally executors

Another thought: what if loop state is so large it overflows 65k locals > limit? I don't see any checks of clauses array size in MHs.loop(). This is filed as a bug: https://bugs.openjdk.java.net/browse/JDK-8160717. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haup

Re: RFR(L): 8143211: provide bytecode intrinsics for loop and try/finally executors

... small correction: the FC extension for this RFE has been *requested*. Best, Michael > Am 29.06.2016 um 11:49 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Hi again, > > as there have been no comments on the .01 version, I have updated it in place

Re: RFR(L): 8143211: provide bytecode intrinsics for loop and try/finally executors

* deal with necessary further improvements as performance bugs Reviews please! :-) Thanks, Michael > Am 23.06.2016 um 16:43 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Dear all, > > thank you, Claes, Vladimir, and Paul, for your reviews. See > http://cr.

Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

Hi Shilpi, in that case, please make sure to give the test that already covers the IAE a @bug annotation for this issue. Thanks, Michael > Am 27.06.2016 um 17:18 schrieb "shilpi.rast...@oracle.com" > : > > Thanks Michael and Paul for comments!! > > Yes we already

Re: RFR[9]: 8158169: MethodHandles.dropArgumentsToMatch(...)

astogi/8158169/webrev.00/ > > Thanks, > Shilpi -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbau

Re: RFR(L): 8143211: provide bytecode intrinsics for loop and try/finally executors

being piggybacked on this one: * Removing IntrinsicMethodHandle. * Taking care of Transform cache cleanup. Best, Michael > Am 16.06.2016 um 15:17 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Dear all, > > please review this change. > RFE: https://bugs.openjdk.jav

RFR(L): 8143211: provide bytecode intrinsics for loop and try/finally executors

ttp://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

browse/JDK-8158510 to include new >>>> test cases. >>>> >>>> Regards, >>>> Shilpi >>>>>> >>>>>> cheers >>>>>> /Joel >>>>>> >>>>>> On Tue, 31 May 2016 at 17:49 shilpi.rast...@oracle

Re: RFR: 8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist

gt; Hannes > -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE

Re: RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

Hi Shilpi, CCC approval is in. My review is lower-case, so another one is needed ere I can sponsor the push. Best, Michael > Am 02.06.2016 um 14:53 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Hi Shilpi, > > lower-case thumbs up. Please obtain CCC app

Re: RFR[9]: 8156868 MethodHandles.zero(Class) doc issues

gt;> Please see http://cr.openjdk.java.net/~srastogi/8156868/webrev.02/ >> > > +1 > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools

Re: RFR(M): 8156915: introduce MethodHandle factory for array length

k/rev/fd39cefc5c8f#l3.13 > arrayConstructor has @since 9, but arrayLength() not. > > Uwe -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschl

RFR(XS): 8157590: MethodHandles.arrayLength() lacks @since tag, implementation throws wrong exception

Dear all, please review this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8157590 Webrev: http://cr.openjdk.java.net/~mhaupt/8157590/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: RFR(M): 8156915: introduce MethodHandle factory for array length

for all three?) > > Thanks, > Stanislav > > On 18.05.2016 10:52, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> RFE: https://bugs.openjdk.java.net/browse/JDK-8156915 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8156915/webre

Re: RFR(M): 8156915: introduce MethodHandle factory for array length

roblem diagnostics. > > Otherwise, looks good! > > Best regards, > Vladimir Ivanov > > On 5/18/16 10:52 AM, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> RFE: https://bugs.openjdk.java.net/browse/JDK-8156915 >> Webrev: htt

Re: MethodHandle for array length

Apache Lucene PMC / Committer > Bremen, Germany > http://lucene.apache.org/ > >> -Original Message- >> From: Uwe Schindler [mailto:uschind...@apache.org] >> Sent: Friday, May 13, 2016 11:55 AM >> To: 'Remi Forax' <fo...@univ-mlv.fr> >> Cc:

Re: MethodHandle for array length

eature but it seems that Michael was >> faster than me, >> https://bugs.openjdk.java.net/browse/JDK-8156915 >> >> regards, >> Rémi >> >> - Mail original - >>> De: "Uwe Schindler" <uschind...@apache.org> >>&

RFR(M): 8156915: introduce MethodHandle factory for array length

Dear all, please review this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8156915 Webrev: http://cr.openjdk.java.net/~mhaupt/8156915/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: MethodHandle for array length

umStep); assertEquals(Iterate.MT_sum, loop.type()); assertEquals(21, loop.invoke(new Integer[]{1, 2, 3, 4, 5, 6})); } ... where MH_sumIterator is a handle to this method: static Iterator sumIterator(Integer[] a) { return Arrays.asList(a).iterator(); } Best, Michael -- <http://www

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

t;>>> Solution: Changed anonymous class package name with the package name >>>> of its host class. >>>> >>>> Two approaches to solve this- >>>> 1. Parse .class and get the class name index form constant pool and >>>> patch it with

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

rmTest.java" StatusError Parse > Exception: [-esa]: vm option(s) found, need to specify /othervm > > Thanks, > Shilpi > > On 5/11/2016 6:47 PM, Michael Haupt wrote: >> Hi Shilpi, >> >> not a review - the bug mentions that this issue is fixed in Jake a

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

name index form constant pool and patch it > with new name > http://cr.openjdk.java.net/~srastogi/8149574/webrev.05/ > > 2. Create class with new name (With ASM) > http://cr.openjdk.java.net/~srastogi/8149574/webrev.06/ > > Which approach is better? > > Thanks, > Shilpi &

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

t; > Please review one small fix for > > https://bugs.openjdk.java.net/browse/JDK-8155791 > http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ > > Thanks, > Shilpi -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331

RFR(S): 8155106: MHs.Lookup.findConstructor returns handles for array classes

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8155106 Webrev: http://cr.openjdk.java.net/~mhaupt/8155106/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: RFR(S): 8154754: MethodHandles.countedLoop errors in deriving loop arguments, result type, and local state

> looks good to me. resultType == void.class ? zero(void.class) : > identity(resultType) appears twice and unconditionally used at least once, > thus could be profitably extracted to a variable for readability/imaginary > performance gain. Thanks! /Claes > > On 2016-04-20 15:

Re: RFR(S): 8154751: MethodHandles.countedLoop does not accept empty bodies

anks! > > /Claes > > On 2016-04-20 15:13, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> Bug: https://bugs.openjdk.java.net/browse/JDK-8154751 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8154751/webrev.00/ >> >> Th

Re: RFR(S): 8152667: MHs.iteratedLoop(...) throws unexpected WMTE, disallows Iterator subclasses, generates inconsistent loop result type

> unconditionally but only used if iterator == null, thus could be refactored > into an if (iterator == null) ... else construct > > Thanks! > > /Claes > > On 2016-04-20 11:25, Michael Haupt wrote: >> Dear all, >> >> please review this change. >

RFR(S): 8154754: MethodHandles.countedLoop errors in deriving loop arguments, result type, and local state

/040386.html -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germa

RFR(S): 8154751: MethodHandles.countedLoop does not accept empty bodies

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8154751 Webrev: http://cr.openjdk.java.net/~mhaupt/8154751/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

RFR(S): 8152667: MHs.iteratedLoop(...) throws unexpected WMTE, disallows Iterator subclasses, generates inconsistent loop result type

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8152667 Webrev: http://cr.openjdk.java.net/~mhaupt/8152667/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

RFR(S): 8150956: j.l.i.MethodHandles.whileLoop(...) and .iteratedLoop(...) throw unexpected exceptions in the case of 'init' return type is void

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8150956 Webrev: http://cr.openjdk.java.net/~mhaupt/8150956/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

RFR(S): 8150824: Exceptions when omitting trailing arguments in cleanup

ttp://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V

RFR(S): 8153637: MethodHandles.countedLoop/3 initialises loop counter to 1 instead of 0

counter increment to the end of the loop (requires argument permutation). Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschla

Re: RFR 8151705 VarHandle.AccessMode enum names should conform to code style

1197 */ > 1198 public static AccessMode valueFromMethodName(String methodName) { > 1199 AccessMode am = methodNameToAccessMode.get(methodName); > 1200 if (am != null) return am; > 1201 throw new IllegalArgumentException("No Acces

Re: RFR 8151706: Update VarHandle implementation to use @Stable arrays

cally held on the associated VarHandle implementation. It should also be > possible to lazily create MemberName instances as required, rather than > aggressively doing so, which may further reduce initialization costs and > memory usage in common cases. > > Paul. -- <http://

Re: RFR 8152645 VarHandle lookup access control tests

cross module > boundaries. > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 |

Re: RFR 8150829: Enhanced drop-args, identity and default constant, varargs adjustment

et/browse/JDK-8150829 > http://cr.openjdk.java.net/~srastogi/8150829/webrev.04 > > > Thanks, > Shilpi -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangT

RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782

Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal

RFR(S): 8150782: findClass / accessClass throw unexpected exceptions

, the change contains some tests that illustrate these cases. CCC approval is pending. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn

Re: RFR(S): 8150957: j.l.i.MethodHandles.whileLoop(...) fails with IOOBE in the case 'init' is null, 'step' and 'pred' have parameters

el -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE

Re: RFR(M): 8150832: split T8139885 into several tests by functionality

> /Claes > > On 2016-03-02 13:46, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> RFE: https://bugs.openjdk.java.net/browse/JDK-8150832 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8150832/webrev.00 >> >> This is a re

RFR(M): 8150832: split T8139885 into several tests by functionality

declarative annotations were introduced where it made sense. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V

RFR(XS): 8150953: j.l.i.MethodHandles: example section in whileLoop(...) provides example for doWhileLoop

(). Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germa

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

ves. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

e filed the RFE here: https://bugs.openjdk.java.net/browse/JDK-8150832 A new webrev with the above changes (save the renaming) is at http://cr.openjdk.java.net/~mhaupt/8150635/webrev.01 Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Pho

Re: RFR(S): 8150825: MethodHandles.tryFinally throws IndexOutOfBoundsException for non-conforming parameter lists

d Reviewer request, and the naming having nagged me for a while, I'll do it at some point in the near future (probably by piggybacking the renaming onto something else). :-) Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200

RFR(S): 8150825: MethodHandles.tryFinally throws IndexOutOfBoundsException for non-conforming parameter lists

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V

RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

for details and examples. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 144

Re: RFR(S): 8143410: augment pseudo-code descriptions in MethodHandles API

Hi Paul, thanks - all right; I'll consider using "and" rather than "/" and push the result. Best, Michael > Am 23.02.2016 um 09:13 schrieb Paul Sandoz <paul.san...@oracle.com>: > >> >> On 23 Feb 2016, at 07:39, Michael Haupt <michael.ha...@orac

Re: RFR(S): 8143410: augment pseudo-code descriptions in MethodHandles API

ith the other > pseudocode examples? That might be more changes than you wanna apply in this > case :-) You're right, the naming should be consistent. I've applied this throughout. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phon

Re: RFR(S): 8150360: augment/correct MethodHandle API documentation

t; must…” ? thank you. Fixed and pushed. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbaue

RFR(S): 8143410: augment pseudo-code descriptions in MethodHandles API

: catchException(), collectArguments(), filterArguments(), filterReturnValue(), foldArguments(), and guardWithTest(). Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform

RFR(S): 8150360: augment/correct MethodHandle API documentation

() * MethodHandles.collectArguments(), .dropArguments(), .filterArguments(), .filterReturnValue(), .foldArguments(), .permuteArguments() Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Pl

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

p://cr.openjdk.java.net/~srastogi/8144931/webrev.03/ >> > > +1 > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deuts

Re: RFR: 8071368 Use more concrete types for NamedFunction constants in the code

t; Quoting John: "The use of erased types (any ref => Object) in the MH >>>> runtime is an artifact of bootstrapping difficulties, early in the >>>> project. I hope it is not necessary any more." >>>> >>>> Best regards, >>>&g

Re: RFR 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods

t; >> Same is not applicable for "Lookup.unreflect()". >> > > Ok. Thanks for checking. > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group |

Re: RFR 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

rote: >> Hi All, >> >> Please review the updated patch- >> >> http://cr.openjdk.java.net/~srastogi/8138578/webrev.01/ >> >> I verified Lookup.unreflectSpecial() also throws >> java.lang.IllegalAccessException so updated the JavaDoc. >> >&g

Re: API review of VarHandles

peed up low-magic Perl 5 code with over 300x performance gain.""" -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co

RFR(S): 8147078: MethodHandles.catchException does not enforce Throwable subtype

. The change adds the corresponding check, and a test. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. &a

RFR(S): 8146786: [TESTBUG] straighten out testability for several issues

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.c

RFR(XS): 8081512: Remove sun.invoke.anon classes, or move / co-locate them with tests

gt; Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Ora

Re: RFR(XS): 8081512: Remove sun.invoke.anon classes, or move / co-locate them with tests

(... please ignore the "and sponsor" part ...) > Am 08.12.2015 um 10:37 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Dear all, > > please review and sponsor this change. > RFE: https://bugs.openjdk.java.net/browse/JDK-8081512 > Webrev: http://cr.op

Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

t; few eagerly initialized functions that can be made lazily initialized, which > defers 6 classes from loading eagerly in startup tests that use lambdas > explicitly. > > Thanks! > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Techni

RFR(XS): 8072844: Use more efficient LambdaForm type representation

Dear all, please review this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8072844 Webrev: http://cr.openjdk.java.net/~mhaupt/8072844/webrev.00 Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: RFR(XS): 8072844: Use more efficient LambdaForm type representation

further analysis: it is used in LF bytecode generation and DMH creation only. I'll keep it out of this change but bear it in mind. Thanks, Michael > Am 03.12.2015 um 11:05 schrieb Michael Haupt <michael.ha...@oracle.com>: > > Dear all, > > please review this

Re: RFR(XS): 8072844: Use more efficient LambdaForm type representation

1279 static MemberName generateLambdaFormInterpreterEntryPoint(Type > rType, Type[] pTypes) { A MethodType is an apt abstraction for what is needed here; I don't think breaking it up into its components would help much. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member o

RFR(S): 8143343: add JEP 274 Javadoc tests to JavaDocExamplesTest

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.c

RFR(XS): 8076596: BytecodeDescriptor.parseMethod doesn't work during bootstrapping

bug. It is not reproducible in current 9-dev and jake builds. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V

Re: RFR: 8143131: Remove unused code from java.lang.invoke

.invoke: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8143131 > Webrev: http://cr.openjdk.java.net/~redestad/8143131/webrev.01/ > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 756

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

Hello, FYI, I've requested backport approval for this fix to 8u. http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-November/004540.html Best, Michael > Am 09.11.2015 um 16:28 schrieb Michael Haupt <michael.ha...@oracle.com>: > > ... thanks a lot, Peter and Vlad

RFR(S): 8143798: jck failures: api/java_lang/invoke/MethodHandle/index_MethodsTests[asSpreaderWMTE]: java.lang.VerifyError: Bad type on operand stack

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8143798 Webrev: http://cr.openjdk.java.net/~mhaupt/8143798/webrev.00/ The issue is an array iteration boundary bug in the JEP 274 implementation. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

s intentional (result type = loop variable type, rather than result type = loop variable). > I guess in the future there may be ample opporunity to specialize the generic > “loop” mechanism with LambdaForms? Yep: https://bugs.openjdk.java.net/browse/JDK-8143211 Best, Michael -- <h

  1   2   >