Re: hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates

2010-11-05 Thread Lance Andersen - Oracle
Hi Remi (and team), I made changes to SyncFactory and one other class for a similar error. Also cleaned up a couple of other minor issues in these classes. The webrev can be found at http://cr.openjdk.java.net/~lancea/6982530/ Thank you for catching the error. Regards Lance On Sep 5, 2010, at

Re: hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates

2010-11-06 Thread Lance Andersen - Oracle
Hi David, Thanks for the feedback. Please see below. On Nov 6, 2010, at 2:04 AM, David Schlosnagle wrote: > On Fri, Nov 5, 2010 at 5:51 PM, Lance Andersen - Oracle > wrote: >> >> Hi Remi (and team), >> I made changes to SyncFactory and one other class for a similar

Re: hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates

2010-11-11 Thread Lance Andersen - Oracle
Thank you Alan. Yes I am planning on doing additional clean up across the code utilizing a separate CR. Regards, Lance On Nov 11, 2010, at 4:59 AM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> Hi Remi (and team), >> >> I made changes to SyncFactory and one othe

Re: 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked

2010-11-16 Thread Lance Andersen - Oracle
Looks good to me Alan. Regards Lance On Nov 16, 2010, at 9:34 AM, Alan Bateman wrote: > I need a reviewer to a trivial drive-by fix to java.lang.Readable's javadoc. > > Thanks, > Alan. > > diff --git a/src/share/classes/java/lang/Readable.java > b/src/share/classes/java/lang/Readable.java > --

Re: Code review request for 7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"

2010-12-01 Thread Lance Andersen - Oracle
Hi Joe, Looks fine to me. -lance On Dec 1, 2010, at 12:24 PM, Joe Darcy wrote: > Hello. > > Please review my simple fix for > >7002594 "Math.max and Math.min should use floatToRawIntBits() to check for > -0.0" >http://cr.openjdk.java.net/~darcy/7002594.0/ > > Besides addressing the r

Re: 6993732: Remove the HPI

2011-01-04 Thread Lance Andersen - Oracle
looks fine to me Alan On Jan 4, 2011, at 8:50 AM, Alan Bateman wrote: > > The HPI is left over from bygone years where we had a portability layer and > needed to support green and native threading models. Some of the code has not > been used or maintained since the transition to HotSpot back in

Re: Crash in ntdll.dll due to JdbcOdbcConnection

2011-03-01 Thread Lance Andersen - Oracle
Alan is correct, we do not officially support the bridge, from: http://download.oracle.com/javase/6/docs/technotes/guides/jdbc/bridge.html: Status of the JDBC-ODBC Bridge The JDBC-ODBC Bridge should be considered a transitional solution. Sun Microsystems and DataDirect Technologies are working

Re: 7021987: native2ascii "file cannot be read" error message is broken

2011-03-02 Thread Lance Andersen - Oracle
looks fine Alan On Mar 2, 2011, at 10:12 AM, Alan Bateman wrote: > > I need a reviewer for a small regression in the native2ascii tool whereby its > error messages aren't as expected. Early in the jdk7 this code appears to > have been changed to address a "non-varargs call of varargs method" wa

Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-11 Thread Lance Andersen - Oracle
Hi, I have posted the diffs to DriverManager for review at http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes CopyOnWriteArrayList instead of the Vectors previously used. Regards, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Enginee

Re: Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-11 Thread Lance Andersen - Oracle
coming weeks, I will look at the javadoc changes that you suggest then (there are existing CRs on this) I do not mind moving the constructor, I just left it where it was since DriverManager was written, but happy to do so. Regards Lance > > -Ulf > > > Am 11.03.2011 21:03, sch

Re: Code review request for 7026898 DriverManager to now use CopyOnWriteArrayList

2011-03-12 Thread Lance Andersen - Oracle
Hi Dave, Yes it could be made final. This is just a hold over from the original code, but there is no reason that I cannot make it final. Regards Lance On Mar 11, 2011, at 6:26 PM, David Schlosnagle wrote: > On Fri, Mar 11, 2011 at 3:03 PM, Lance Andersen - Oracle > wrote: >> I

Review request for removal of lint warnings in DriverManager, CR 7034656

2011-04-07 Thread Lance Andersen - Oracle
Hi all, This is a request for a review of the changes to remove the lint warnings for DriverManager. The diff is at http://cr.openjdk.java.net/~lancea/7034656/. Thank you. Regards, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network

Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-11 Thread Lance Andersen - Oracle
Hi all, This is a request for a review of the changes to remove the lint warnings for javax.sql.rowset. The diff is at http://cr.openjdk.java.net/~lancea/7035615 Thank you. Regards, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network

Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-11 Thread Lance Andersen - Oracle
Hi Alan, thank you for the feedback. On Apr 11, 2011, at 2:19 PM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> Hi all, >> >> This is a request for a review of the changes to remove the lint warnings >> for javax.sql.rowset. The diff is at >> h

Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-11 Thread Lance Andersen - Oracle
Hi Joe, Alan, Thank you for your feedback Joe. On Apr 11, 2011, at 2:35 PM, Alan Bateman wrote: > joe.da...@oracle.com wrote: >> Hi Lance. >> >> The generification looks fine. Thank you Joe >> Separately I'd recommend considering replacing Vector with ArrayList and >> Hashtable with HashMap.

Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-11 Thread Lance Andersen - Oracle
On Apr 11, 2011, at 2:48 PM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> : >>> >>> PS: javac was updated recently to emit warnings for unreachable catch >>> clauses and one place that generates this warning is >>> src/share/classes

Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-11 Thread Lance Andersen - Oracle
Apr 11, 2011, at 2:48 PM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> : >>> >>> PS: javac was updated recently to emit warnings for unreachable catch >>> clauses and one place that generates this warning is >>> src/share/classes/com/sun/

Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-12 Thread Lance Andersen - Oracle
Hi Alan, http://cr.openjdk.java.net/~lancea/7035615/webrev.02/ has your suggested changes below. Regards Lance On Apr 12, 2011, at 4:08 AM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> Hi Alan, Joe >> >> >> I pushed the revised webrev out (webrev

Quick code review to address a couple typos in the javadoc for ResultSet, CR 7007772

2011-04-12 Thread Lance Andersen - Oracle
Hi folks, Looking for a reviewer for the following simple change to ResultSet to address CR 7007772 hg diff diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/ResultSet.java Tue Apr 12 12:25:15 2011 -0400 +++ b/src/share/classes/java/sql/ResultSet.jav

Review needed for 7036251, clarification to SQLPermission Constructors

2011-04-13 Thread Lance Andersen - Oracle
HI all, Need a reviewer for this minor update to the SQLPermission constructors which I missed when I added the updates for the new permission target names. Thank you. Regards, Lance hg diff diff -r 0bae251b548b src/share/classes/java/sql/SQLPermission.java --- a/src/share/classes/java/sql/SQ

Re: Review needed for 7036251, clarification to SQLPermission Constructors

2011-04-13 Thread Lance Andersen - Oracle
Hi Alan, thank you. Yes I will be going through all of JDBC to clean up the java docs in the coming weeks. Regards, lance On Apr 13, 2011, at 10:39 AM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> HI all, >> >> Need a reviewer for this minor update

Review needed for 7037085 : Add hashCode() to Timestamp to address Findbugs warning

2011-04-15 Thread Lance Andersen - Oracle
Hi all, Need a reviewer for the following minor change which adds hasCode() to Timestamp to address a Findbugs warning. Regards Lance hg diff diff -r d9248245a88c src/share/classes/java/sql/Timestamp.java --- a/src/share/classes/java/sql/Timestamp.java Wed Apr 13 11:21:36 2011 -0400 +++ b/src

Re: Review needed for 7037085 : Add hashCode() to Timestamp to address Findbugs warning

2011-04-15 Thread Lance Andersen - Oracle
. Regards Lance On Apr 15, 2011, at 3:37 PM, Eamonn McManus wrote: > This isn't wrong, but wouldn't it be simpler to just add or xor the nanos > field into the hashcode, rather than explicitly saying that you don't? > Éamonn > > On 15/4/11 8:54 PM, Lance Andersen

Re: Review needed for 7037085 : Add hashCode() to Timestamp to address Findbugs warning

2011-04-18 Thread Lance Andersen - Oracle
in the doc comment. > Éamonn > > On 15/4/11 9:45 PM, Lance Andersen - Oracle wrote: >> >> Hi Eamonn >> >> The javadocs for Timestamp have always specifically called the following >> blurb out in the class description. Based on some side discussions, it

Review request for 7038565, for a findbugs warning for BatchUpdateException

2011-04-22 Thread Lance Andersen - Oracle
Hi Folks, I am looking for a reviewer for this update to BatchUpdateException to address a findbugs issue for exposing a mutable object. The webrev is at http://cr.openjdk.java.net/~lancea/7038565/ Have a great weekend! Regards, lance Lance Andersen| Principal Member of Technical Staff | +1

Re: Review request for 7038565, for a findbugs warning for BatchUpdateException

2011-04-22 Thread Lance Andersen - Oracle
Hi Remi, Thank you for the feedback. On Apr 22, 2011, at 12:29 PM, Rémi Forax wrote: > On 04/22/2011 06:22 PM, Lance Andersen - Oracle wrote: >> Hi Folks, > > Hi Lance, > >> I am looking for a reviewer for this update to BatchUpdateException to >> address a

Re: Review request for 7038565, for a findbugs warning for BatchUpdateException

2011-04-22 Thread Lance Andersen - Oracle
Hi Remi, I pushed a revised webrev http://cr.openjdk.java.net/~lancea/7038565/webrev.01/ Regards, lance On Apr 22, 2011, at 2:22 PM, Rémi Forax wrote: > On 04/22/2011 06:51 PM, Lance Andersen - Oracle wrote: >> Hi Remi, >> >> Thank you for the feedback. > > [...]

Re: Review request for 7038565, for a findbugs warning for BatchUpdateException

2011-04-25 Thread Lance Andersen - Oracle
Regards, Lance On Apr 23, 2011, at 6:11 AM, David Holmes wrote: > Rémi Forax said the following on 04/23/11 04:22: >> On 04/22/2011 06:51 PM, Lance Andersen - Oracle wrote: >>>> >>>> You should use clone() instead of Arrays.copyOf. >>> >>> C

Re: Simple 1-line fix for 8027943 to fix serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImp

2013-11-07 Thread Lance Andersen - Oracle
+1 On Nov 7, 2013, at 4:59 PM, Mandy Chung wrote: > This reverts > com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl back to the > previous serial version. > > diff --git > a/src/share/classes/com/sun/corba/se/spi/orbutil/proxy/CompositeInvocationHandlerImpl.java > > b/src/sh

Re: RFR doc only typo in java.io.DataInput

2013-11-07 Thread Lance Andersen - Oracle
+1 On Nov 7, 2013, at 5:29 PM, roger riggs wrote: > Please review this straightforward typo correction: > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-doc-readlong-8024458/ > > Thanks, Roger > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Enginee

Re: JDK RFR to clean-up lint warnings in reflection implementation

2013-11-08 Thread Lance Andersen - Oracle
looks fine Joe On Nov 8, 2013, at 2:40 PM, Joe Darcy wrote: > Hello, > > Please review the simple patch below which addresses a handful of raw types > lint warning in the core reflection implementation code. > > (If memory serves, this code dates back from a time during the development of > JD

Re: JDK 8 RFR: more core libs raw warnings cleanup

2013-11-12 Thread Lance Andersen - Oracle
Looks Ok Joe On Nov 12, 2013, at 4:28 AM, Joe Darcy wrote: > Hello, > > Please review the patch below which would remove another batch of raw type > javac lint warnings from the core libraries. > > No signatures of public or protected methods in the Java SE specification > have been modified.

Re: RFR(2): 7174936: several String methods claim to always create new String

2013-11-12 Thread Lance Andersen - Oracle
The wording changes seem fine to me. Thanks for the specdiff as it made it much easier to review On Nov 12, 2013, at 11:43 AM, Stuart Marks wrote: > Hi all, > > Here's an updated version of the String spec change. Changes from the > previous version address comments made by Brent Christian an

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-12 Thread Lance Andersen - Oracle
+1 On Nov 12, 2013, at 2:29 PM, Mandy Chung wrote: > This is a simple code deletion in sun.misc.JavaAWTAccess and its > implementation class: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ > > This patch removes the methods from sun.misc.JavaAWTAccess that are

Re: RFR (JAXP): 8028111 : XML readers share the same entity expansion counter

2013-11-13 Thread Lance Andersen - Oracle
looks fine joe On Nov 13, 2013, at 3:02 PM, huizhe wang wrote: > Hi, > > The issue is that the limits applied to each processing process rather than > each file processing. This applies to not only StAX as reported, but also > other parsers and validators. The fix is to add reset to XMLSecurity

Re: RFR: JDK-8028631 - Improve the test coverage to the pathname handling on unix-like platforms

2013-11-19 Thread Lance Andersen - Oracle
The changes seem OK. I did not run the tests though On Nov 19, 2013, at 2:08 PM, Dan Xu wrote: > Hi All, > > We have java/io/pathNames/GeneralWin32.java testcase to do the general > exhaustive test of pathname handling on windows. I am adding a new test > GeneralSolaris.java to test the pathna

Re: RFR: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails

2013-11-19 Thread Lance Andersen - Oracle
looks fine On Nov 19, 2013, at 5:24 PM, Stuart Marks wrote: > Hi all, > > Please review this small fix for an intermittent timeout. Nothing seems to be > going wrong except that if the machine running the test is exceptionally > slow, spurious timeouts will occur. The solution is to raise the t

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread Lance Andersen - Oracle
looks OK Joe On Nov 26, 2013, at 5:27 PM, huizhe wang wrote: > > On 11/26/2013 1:59 PM, roger riggs wrote: >> Hi, >> >> I looked at that twice also.java.time had a similar situation. >> >> To get to the TCCL you need to call ServiceLoader.load(type). >> >> The FactoryFinder:348 findService

Review request 8029417: Minor javadoc cleanup for JDBC 4.2

2013-12-02 Thread Lance Andersen - Oracle
Hi all This is a review request for some minor javadoc clarifications for JDBC 4.2 based on some feedback that I received. The webrev can be found http://cr.openjdk.java.net/~lancea/8029417/webrev.00 Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java E

Re: RFR: 8029489: StringJoiner spec for setEmptyValue() and length() is malformatted

2013-12-03 Thread Lance Andersen - Oracle
looks OK On Dec 3, 2013, at 8:40 PM, Stuart Marks wrote: > Hi all, > > Please review the following small javadoc change. The StringJoiner doc for a > couple methods uses "i.e." in the first sentence, which screws up the javadoc > logic that pulls the first sentence into the Method Summary. This

Re: RFR: JDK-8028712 : Tidy warnings cleanup for java.sql package

2013-12-05 Thread Lance Andersen - Oracle
Hi Serge This looks OK. For --- old/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.587885460 + +++ new/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.435885464 + Please remove the following Package Specification • Specificat

Re: RFR (JAXP) 8029895 : XMLOutputFactory.newFactory(String, ClassLoader) - incorrect specification

2013-12-11 Thread Lance Andersen - Oracle
looks fine joe On Dec 11, 2013, at 4:10 PM, huizhe wang wrote: > > On 12/11/2013 12:21 PM, Alan Bateman wrote: >> On 11/12/2013 19:52, huizhe wang wrote: >>> Hi, >>> >>> This is a quick documentation change to fix an error in >>> javax.xml.stream.XMLOutputFactory: >>> >>> http://cr.openjdk.jav

Re: RFR (JAXP) 8029955 : AIOB in XMLEntityScanner.scanLiteral upon parsing literals with > 100 LF chars

2013-12-17 Thread Lance Andersen - Oracle
Joe, I thought this looked OK also On Dec 17, 2013, at 12:26 PM, huizhe wang wrote: > > On 12/17/2013 4:10 AM, Daniel Fuchs wrote: >> Hi Joe, >> >> The fix looks good - though I wonder at whether incrementing >> whiteSpaceLookup by a fix amount wouldn't be better than >> doubling its length.

Re: RFR: JDK-8028712 : Tidy warnings cleanup for java.sql package

2014-01-02 Thread Lance Andersen - Oracle
e the section below deleted, perhaps the change did not get pushed to where you generated the webrev from? > and replaced "br/" to "br" for compliance with html 3.2 > > > On 12/05/2013 10:39 PM, Lance Andersen - Oracle wrote: >> Hi Serge >> >> >&

Re: RFR java.time.Duration spec correction (8031103)

2014-01-06 Thread Lance Andersen - Oracle
looks fine Roger On Jan 6, 2014, at 2:09 PM, roger riggs wrote: > Please review this minor specification correction to the > java.time.Duration.toDays() and > toHours() methods. Only the javadoc is corrected, no code or tests are > affected. > > Webrev: > http://cr.openjdk.java.net/~rriggs/web

Re: JDK 9 RFR of JDK-8027063 SecurityManger.getClassContext returns a raw type

2014-01-06 Thread Lance Andersen - Oracle
+1 On Jan 6, 2014, at 3:53 PM, Joe Darcy wrote: > Hello, > > Please review the simple change to fix JDK-8027063 > SecurityManger.getClassContext returns a raw type, which changes a signature > of a protected method in SecurityManger to remove a use of raw types in the > core libraries: > > --

Re: JDK 9 RFR of JDK-8031210 Remove serial warning from java.lang.Enum

2014-01-06 Thread Lance Andersen - Oracle
+1 On Jan 6, 2014, at 4:41 PM, Joe Darcy wrote: > Hello, > > Please review the patch below to add a @SuppressWarning("serial") to > java.lang.Enum to resolve a lint warning in the core libraries. > > Thanks, > > -Joe > > --- a/src/share/classes/java/lang/Enum.javaMon Jan 06 11:48:32 2014

Re: RFR: JDK-8028726 - (prefs) Check src/solaris/native/java/util/FileSystemPreferences.c for JNI pending exceptions

2014-01-06 Thread Lance Andersen - Oracle
Dan, Looks OK, but line 914 which you did not change, notice the comments not sure if that is common in this code but seemed a bit off to me: 914 //// If at first, you don't succeed... On Jan 6, 2014, at 5:29 PM, Dan Xu wrote: > Hi All, > > Please review the simple fix for JNI

Re: RFR: JDK-8028726 - (prefs) Check src/solaris/native/java/util/FileSystemPreferences.c for JNI pending exceptions

2014-01-06 Thread Lance Andersen - Oracle
ileSystemPreferences.java is that it retries if anything fails. So I don't > touch L914 to keep its old logic un-changed. Please let me know if you have > some good suggestions. Thanks! > > -Dan > > > On 01/06/2014 02:35 PM, Lance Andersen - Oracle wrote: >>

Re: JDK 9 RFR of raw type lint fix to java.lang.management

2014-01-07 Thread Lance Andersen - Oracle
+1 On Jan 7, 2014, at 3:30 PM, Joe Darcy wrote: > Hello, > > Please review another minor lint fix of a raw type issues in the core > libraries: > >diff -r 2647b91dbc2a > src/share/classes/java/lang/management/ManagementFactory.java > --- a/src/share/classes/java/lang/management/ManagementF

Re: JDK 9 RFR of JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}

2014-01-07 Thread Lance Andersen - Oracle
looks good Joe On Jan 7, 2014, at 6:58 PM, Joe Darcy wrote: > Hello, > > Please review the fix below to address > >JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache} > > by a quick-and-dirty generification and deprecation of some very old classes > >http://cr.openjdk.ja

Re: RFR JDK 9: 8032502: java.time add @param tags to readObject

2014-01-22 Thread Lance Andersen - Oracle
looks fine Roger as am sure this will make the doclint warnings less On Jan 22, 2014, at 4:26 PM, roger riggs wrote: > Please review this javadoc improvement to add @param tags to readObject > > Webrev: > > http://cr.openjdk.java.net/~rriggs/webrev-time-param-8032502/ > > Thanks, Roger >

Re: RFR (JAXP): 8032392 : Spec: javax.xml.stream.XMLEventFactory/XMLOutputFactory/XMLInputFactory.newFactory(String, ClassLoader) referring to ServiceLoader.load(Class, ClassLoader)

2014-01-24 Thread Lance Andersen - Oracle
+1 On Jan 24, 2014, at 3:31 PM, huizhe wang wrote: > Hi, > > Please review a javadoc change to javax.xml.stream factories. This change > makes it clear that the two args ServiceLoader#load method is used when the > specified classLoader is not null. > > http://cr.openjdk.java.net/~joehw/jdk9/8

Re: RFR 8032221 Typo in java.util.date

2014-01-31 Thread Lance Andersen - Oracle
looks fine. getting rid of and , is something I guess we should look to do throughout all of our code? On Jan 31, 2014, at 1:33 PM, roger riggs wrote: > Please review a typo and javadoc cleanup for java.util.Date > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-date-typo-8032221/ >

Re: Review request for JDK-8030010: cleanup native code warnings

2014-02-12 Thread Lance Andersen - Oracle
Hi Mandy This looks OK to me On Feb 12, 2014, at 12:46 PM, Mandy Chung wrote: > This patch cleans up a few trivial native warnings (mainly remove local > unreferenced variable) > https://bugs.openjdk.java.net/browse/JDK-8030010 > > Webrev at: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs

Re: RFR [4682009] Typo in javadocs in javax/naming

2014-02-14 Thread Lance Andersen - Oracle
Looks fine. assume the will be addressed as part of a full sweep of javax/naming On Feb 14, 2014, at 2:48 PM, Ivan Gerasimov wrote: > Hello! > > May I please have a review of the fix? > > It's not meant to be a proof reading, I only fixed some obvious typos. > Some of them were reported at th

Re: RFR 9: 8035106 Typo in java.time.format.Parsed error message

2014-02-28 Thread Lance Andersen - Oracle
looks fine. Took me a moment to figure out the change but makes sense :-) On Feb 28, 2014, at 4:45 PM, roger riggs wrote: > Please review a typo correction in java.time.format.Parsed. > The exception message is corrected. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-parsed-typo-80351

Re: RFR 9: 8032491: DateTimeFormatter fixed width adjacent value parsing does not match spec

2014-02-28 Thread Lance Andersen - Oracle
Looks Ok. Kind of surprised the tck tests have no assertion details in the tests. Minor nit would have been nice to have even a minor comment for the new method DateTimeFormatterBuilder though that seems to be the norm in some scenarios for the smaller methods. On Feb 28, 2014, at 4:48 PM, r

Re: RFR (JAXP): 8035469 : Xerces Update: EncodingMap does not recognise Java-style encodings Cp1141-Cp1149

2014-02-28 Thread Lance Andersen - Oracle
Looks fine. On Feb 28, 2014, at 5:11 PM, David Li wrote: > Hi, > > This is an update from Xerces for a fixed encoding map entry in file > EncodingMap.java. For details, please refer to: > https://bugs.openjdk.java.net/browse/JDK-8035469 > > Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/803

Re: RFR 9: 8035813: Broken link in java.lang.Iterable

2014-02-28 Thread Lance Andersen - Oracle
+1 On Feb 28, 2014, at 5:25 PM, roger riggs wrote: > Please review this fix for a broken link in the javadoc. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-link-broken-8035813/ > > Thanks, Roger > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java En

Re: RFR (JAXP): 8035577: Xerces Update: impl/xpath/regex/RangeToken.java

2014-03-05 Thread Lance Andersen - Oracle
On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote: > nitpicking, > > (1) shouldn't the variable at #468 to be updated to "lch" instead of "uch" as > well? I would agree given you are now calling Character.toLowerCase > (2) StringBuilder can be used to replace the StringBuffer in toString(). Agree

Re: RFR (JAXP): 8035577: Xerces Update: impl/xpath/regex/RangeToken.java

2014-03-05 Thread Lance Andersen - Oracle
On Mar 5, 2014, at 5:10 PM, huizhe wang wrote: > > On 3/5/2014 12:46 PM, Lance Andersen - Oracle wrote: >> On Mar 5, 2014, at 3:37 PM, Xueming Shen wrote: >> >>> nitpicking, >>> >>> (1) shouldn't the variable at #468 to be updated to "lch

Re: RFR (JAXP): 8035577: Xerces Update: impl/xpath/regex/RangeToken.java

2014-03-20 Thread Lance Andersen - Oracle
I think this OK. The comments with the o--o did not do much for me though and found them a bit confusing but perhaps I need more coffee this morning ? Also, not sure we need the @author tag but I think its usage varies in the workspace Best Lance On Mar 19, 2014, at 7:10 PM, David Li wrote: >

Re: Review Request: JDK-8001565, (fs) Typo Path.endsWith(String) javadoc

2012-10-25 Thread Lance Andersen - Oracle
This fix is fine Dan Best Lance On Oct 25, 2012, at 5:45 PM, Dan Xu wrote: > Hi, > > Please help review the javadoc typo fix at, > http://cr.openjdk.java.net/~dxu/8001565/webrev/. Thanks! > > -Dan > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineerin

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-10-29 Thread Lance Andersen - Oracle
Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012, at 3:51 AM, Deven You wrote: > Hi Alan, > > The Java Spec does not mention the thread safe for JDBC API. But I see the > other code in SerialBlob/SerialClob have not consider it. > >

Review request for 8001536

2012-10-30 Thread Lance Andersen - Oracle
Hi, This is a request for review of http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds read/writeObject as well as clone methods to SerialXLob classes. All SQE tests passed, 1 failure in the RowSet JCK/TCK tests due to a bug in the test that the TCK team is aware of and will ad

Re: Review request for 8001536

2012-10-30 Thread Lance Andersen - Oracle
> Am 30.10.2012 17:25, schrieb Lance Andersen - Oracle: >> Hi, >> >> This is a request for review of >> http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds >> read/writeObject as well as clone methods to SerialXLob classes. >> >> All SQE te

Re: Review request for 8001536

2012-10-30 Thread Lance Andersen - Oracle
Hi Remi, Thank you for the feedback On Oct 30, 2012, at 2:05 PM, Remi Forax wrote: > On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote: >> Hi, >> >> This is a request for review of >> http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds >>

Re: Review request for 8001536

2012-10-30 Thread Lance Andersen - Oracle
ut having the subject of the request in clear text in the list view of the > email client would be a great help. > > -Ulf > > > Am 30.10.2012 19:28, schrieb Lance Andersen - Oracle: >> Hi Ulf, >> >> The bug is described below, it is just adding the read/w

Re: Review request for 8001536 updated

2012-10-31 Thread Lance Andersen - Oracle
Here is revised webrev taking into account Remi's suggestions http://cr.openjdk.java.net/~lancea/8001536/webrev.01/ Best, Lance On Oct 30, 2012, at 2:05 PM, Remi Forax wrote: > On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote: >> Hi, >> >> This is a requ

Re: 8002120: ProblemList.txt updates (11/2012)

2012-11-01 Thread Lance Andersen - Oracle
looks fine On Nov 1, 2012, at 5:12 PM, Alan Bateman wrote: > > I need a reviewer to remove 5 tests from the exclude list. 4 of the tests > were excluded temporarily during the perm gen removal work. The other one was > a compiler2 bug that is long fixed. > > While I was there I updated TEST.R

Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-02 Thread Lance Andersen - Oracle
This is similar to 8001536, just additional classes. This adds read/writeObject, equals, clone methods to additional SerialXXX classes SQE, JCK and JDBC Unit tests all pass. The webrev can be viewed at http://cr.openjdk.java.net/~lancea/8002212/webrev.00 Best Lance Lance Andersen| Principal M

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-02 Thread Lance Andersen - Oracle
Hi Remi, Thank you for the feedback On Nov 2, 2012, at 7:42 PM, Remi Forax wrote: > On 11/02/2012 11:57 PM, Lance Andersen - Oracle wrote: >> This is similar to 8001536, just additional classes. >> >> This adds read/writeObject, equals, clone methods to additional

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes -- Updated

2012-11-03 Thread Lance Andersen - Oracle
M, Lance Andersen - Oracle wrote: >> This is similar to 8001536, just additional classes. >> >> This adds read/writeObject, equals, clone methods to additional SerialXXX >> classes >> >> SQE, JCK and JDBC Unit tests all pass. >> >> The webrev can be

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-03 Thread Lance Andersen - Oracle
On Nov 3, 2012, at 11:14 AM, Remi Forax wrote: > On 11/03/2012 01:46 AM, Lance Andersen - Oracle wrote: >> Hi Remi, >> > [...] > >>> In SerialDataLink, do you really need readObject/writeObject given >>> that you call the default implementations. >>

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes -- Updated

2012-11-03 Thread Lance Andersen - Oracle
On Nov 3, 2012, at 11:34 AM, Remi Forax wrote: > On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote: >> I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01, >> taking into account the vast majority of Remi's suggestions. > > in SerialJ

Re: [PATCH FOR REVIEW] ResourceManager.getApplicationResources() does not close InputStreams

2012-11-07 Thread Lance Andersen - Oracle
Is there a reason the patch was not created originally leveraging try-with-resoruces as it seems like the perfect candidate from the webrev? I can create a bug for it, but I think I would prefer to see the patch take advantage of try-with-resoruces Best Lance On Nov 7, 2012, at 3:30 PM, Andrew

Re: [PATCH FOR REVIEW] ResourceManager.getApplicationResources() does not close InputStreams

2012-11-07 Thread Lance Andersen - Oracle
The bug number is 8003120 Best Lance On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote: > IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197 > > com.sun.naming.internal.ResourceManager.getApplicationResources() does not > close the input streams it gets from helper.getResourc

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-09 Thread Lance Andersen - Oracle
Frank, If you can please post the bug info here, I will take a look at your patch Best Lance On Nov 8, 2012, at 10:01 PM, Frank Ding wrote: > Hi guys, > We discovered a bug in CachedRowSetWriter.writeData method where incorrect > number of conflicts is reported. I searched in Oracle bug datab

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-13 Thread Lance Andersen - Oracle
tWriter.java:412) >at com.sun.rowset.CachedRowSetImpl.acceptChanges(CachedRowSetImpl.java:880) > > 5. In fact, there is only one conflicting row but 4 were reported. > > Best regards, > Frank > > On 11/9/2012 7:41 PM, Lance Andersen - Oracle wrote: >> Frank, >&g

Re: RFR: 8003380 - Compiler warnings in logging test code

2012-11-14 Thread Lance Andersen - Oracle
looks Ok. On Nov 14, 2012, at 4:15 PM, Jim Gish wrote: > Please review > http://cr.openjdk.java.net/~jgish/Bug8003380-logging-test-warnings/ > > > These are simple changes to eliminate compiler warnings from > java.util.

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-11-23 Thread Lance Andersen - Oracle
0/29/2012 06:39 PM, Lance Andersen - Oracle wrote: >> Hi Deven, >> >> I will address the needed updates a bit later. >> >> Thank you for your input >> >> Best >> Lance >> On Oct 29, 2012, at 3:51 AM, Deven You wrote: >> >>> Hi Al

Adding field to BatchUpdateException

2012-11-24 Thread Lance Andersen - Oracle
Hi, For JDBC 4.2, I am adding methods to allow for larger update counts (request from JDBC driver vendors) and because of this I have to tweak BatchUpdateException The Statement interface has the method int[] executeBatch() I am planning to add long[] executeLargeBatch(). To accomodate th

Re: Adding field to BatchUpdateException

2012-11-26 Thread Lance Andersen - Oracle
but I strongly suggest > documenting the correctness conditions regarding the updateCounts and > longUpdateCounts fields; I think that would ease reviewing the new > constructors and serialization code. > > Cheers, > > -Joe > > On 11/24/2012 2:05 PM, Lance Andersen - Oracl

Re: Adding field to BatchUpdateException

2012-11-26 Thread Lance Andersen - Oracle
; > I would throw an IllegalStateException if invoking e.g. getUpdateCounts on > integer overflow. > > -Ulf > > > Am 26.11.2012 20:44, schrieb Lance Andersen - Oracle: >> Hi Joe, >> >> Thank you for the sanity check. >> >> I had added the fo

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-30 Thread Lance Andersen - Oracle
: > Hi Lance, > Sorry for late response and thanks for your comment. You mean I can write a > jtreg test case that connects to Java DB? I can do that. > > Best regards, > Frank > > On 11/13/2012 10:13 PM, Lance Andersen - Oracle wrote: >> Hi Frank, >> >

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

2012-11-30 Thread Lance Andersen - Oracle
On Nov 30, 2012, at 4:58 AM, Chris Hegarty wrote: > > > On 30/11/2012 02:03, David Holmes wrote: >> On 30/11/2012 12:44 AM, Chris Hegarty wrote: >>> On 11/29/2012 05:50 AM, David Holmes wrote: ... I don't agree that we need to describe what the default implementation does,

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

2012-11-30 Thread Lance Andersen - Oracle
On Nov 30, 2012, at 7:56 AM, Remi Forax wrote: > On 11/30/2012 01:50 PM, Lance Andersen - Oracle wrote: >> On Nov 30, 2012, at 4:58 AM, Chris Hegarty wrote: >> >>> >>> On 30/11/2012 02:03, David Holmes wrote: >>>> On 30/11/2012 12:44 AM, Chris Hegar

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

2012-11-30 Thread Lance Andersen - Oracle
t; On Nov 30, 2012 9:54 AM, "Lance Andersen - Oracle" > wrote: > > On Nov 30, 2012, at 4:58 AM, Chris Hegarty wrote: > > > > > > > On 30/11/2012 02:03, David Holmes wrote: > >> On 30/11/2012 12:44 AM, Chris Hegarty wrote: > >>> On 11/

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-03 Thread Lance Andersen - Oracle
review it. By the way, the new Oracle bug > (internal id 2376620) submitted by me several days ago seems not having been > reviewed. Could you also help me on this? > > Best regards, > Frank > > > On 11/30/2012 8:40 PM, Lance Andersen - Oracle wrote: >> Hi Frank, &g

Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-04 Thread Lance Andersen - Oracle
All, Attached is the patch for: 8004374 based off the issue that Frank reported. for http://cr.openjdk.java.net/~lancea/8004374/webrev.00/ The TCK, SQE and the JDBC Unit Tests run clean. I added a new Unit Test to validate the issue. Frank, I did not use your fix as I was able to clean the

Re: Request for Review : CR#8004015 : [2nd pass] Add interface extends and defaults for basic functional interfaces

2012-12-05 Thread Lance Andersen - Oracle
I am still wondering if we need some sort of javadoc tag for default implementations so that it will stand out better and allow us to be consistent with how we specify this across Java SE and other APIs that leverage default methods. Has any thought been given to this? Best Lance On Dec 5, 20

signatures that are recorded for default methods

2012-12-06 Thread Lance Andersen - Oracle
Folks, Will the signatures for interfaces that are recorded by the TCKs for interfaces record the fact that a method includes a default method? or will it just record the method definition? I am assuming it will, but I know there has been discussion that a implementor could choose a different

Re: Request for review: JDK-8004337: java/sql tests aren't run in test/Makefile

2012-12-06 Thread Lance Andersen - Oracle
Looks fine Rob On Dec 6, 2012, at 4:22 PM, Rob McKenna wrote: > Hi folks, > > There's a missing folder in the jdk_other test target: > > http://cr.openjdk.java.net/~robm/8004337/webrev.01/ > > >-Rob Lance Andersen| Principal Member

Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-10 Thread Lance Andersen - Oracle
d. By the way, the newly added unit test is not > jtreg test case? > > Best regards, > Frank > > On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote: >> All, >> >> Attached is the patch for: 8004374 based off the issue that Frank reported. >> >>

Review request 8004357: Implement various methods in SerialBlob/Clob/Array and specify Thread Safety

2012-12-11 Thread Lance Andersen - Oracle
Need a reviewer for 8004357:Implement various methods in SerialBlob/Clob/Array and specify Thread Safety This defines thread safety adds missing methods to SerialBlob/Clob/Array The CCC request has been reviewed. The changes uncovered a couple of bugs in the JCK which the JCK team is goi

Re: RFR: javax.xml.datatype: Using ServiceLoader to load JAXP datatype factories (7169894: JAXP Plugability Layer: using service loader)

2012-12-12 Thread Lance Andersen - Oracle
+1 On Dec 12, 2012, at 8:08 AM, Daniel Fuchs wrote: > Hi, > > Please find below a refreshed webrev which adds a bit of cleanup > suggested by Paul. > > Instead of casting the result of newInstance() at several places, > we pass the expected base type to newInstance so that the cast > occurs only

Re: signatures that are recorded for default methods

2012-12-13 Thread Lance Andersen - Oracle
method is marked as default method >> but do not track the code in its default body >> (assuming that the body is not a part of a spec - API javadoc). >> >> (I've confirmed that with the signature test developer) >> >> Thanks, >> -leonid >&g

Re: signatures that are recorded for default methods

2012-12-13 Thread Lance Andersen - Oracle
the body is not a part of a spec - API javadoc). >>> >>> (I've confirmed that with the signature test developer) >>> >>> Thanks, >>> -leonid >>> >>> On 12/6/2012 9:01 AM, Lance Andersen - Oracle wrote: >>>> Folks

Re: RFR: 8005051: default methods for Iterator

2012-12-14 Thread Lance Andersen - Oracle
On Dec 14, 2012, at 7:28 AM, Alan Bateman wrote: > On 14/12/2012 01:24, Akhil Arora wrote: >> As part of the library lambdafication, this patch adds a forEach default >> method to Iterator, and converts remove() into a default method so that >> implementations of Iterator no longer have to over

<    1   2   3   >