Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v3]

2023-02-28 Thread Ravali Yatham
On Wed, 22 Feb 2023 07:24:48 GMT, Alan Bateman wrote: >> Ravali Yatham has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix Indentation > > src/java.base/share/classes/java/lang/reflect/Proxy.java line 881: > >> 879: if

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v3]

2023-02-28 Thread Ravali Yatham
> Added specific class loader object to proxy IllegalArgumentException from > which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 Ravali Yatham has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message [v2]

2023-02-28 Thread Ravali Yatham
> Added specific class loader object to proxy IllegalArgumentException from > which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 Ravali Yatham has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8302204: Optimize BigDecimal.divide

2023-02-28 Thread Xiaowei Lu
On Fri, 17 Feb 2023 15:24:26 GMT, Raffaello Giulietti wrote: >>> After making sure that `intVal` is even, and before attempting a division >>> by a power of 10, it might help to check if 5 divides `intVal` in the first >>> place. If it doesn't, there no point in performing the division. >>>

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-28 Thread Martin Doerr
On Fri, 24 Feb 2023 07:17:30 GMT, Jorn Vernee wrote: >> Some more remarks about other issues: >> - Uploaded my simple reproducer to >> [JDK-8303017](https://bugs.openjdk.org/browse/JDK-8303017) >> - Using oversized load / stores is problematic. Don't forget that OpenJDK >> still supports Big

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 23:55:52 GMT, Paul Sandoz wrote: >> Eirik Bjorsnos has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Uppercase Thorn is 0xDE >> - Update 'a' to 'A' and 'z' to 'Z' in comments > >

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v4]

2023-02-28 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 02:32:23 GMT, Xiaohong Gong wrote: >> Eirik Bjorsnos has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Adjust whitespace as suggested in review >> - Replace Blackhold.consume with return values > >

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v4]

2023-02-28 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-28 Thread Martin Doerr
On Tue, 28 Feb 2023 20:00:15 GMT, Jorn Vernee wrote: >> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove size restriction for structs. Add TODO for Big Endian. > > src/hotspot/cpu/ppc/upcallLinker_ppc.cpp line 240: >

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-02-28 Thread Joe Darcy
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-28 Thread Martin Doerr
On Tue, 28 Feb 2023 19:45:28 GMT, Jorn Vernee wrote: >> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove size restriction for structs. Add TODO for Big Endian. > > src/hotspot/cpu/ppc/downcallLinker_ppc.cpp line 133:

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-02-28 Thread Joe Darcy
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v5]

2023-02-28 Thread Martin Doerr
On Wed, 22 Feb 2023 20:25:07 GMT, Jorn Vernee wrote: >> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor cleanup. > > src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java > line 81: > >> 79:

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-28 Thread Martin Doerr
On Tue, 28 Feb 2023 16:54:50 GMT, Jorn Vernee wrote: >> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove size restriction for structs. Add TODO for Big Endian. > > src/hotspot/cpu/ppc/downcallLinker_ppc.cpp line 343:

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v5]

2023-02-28 Thread Martin Doerr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get > removed by

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-02-28 Thread Joe Darcy
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is

RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-02-28 Thread Joe Darcy
Last and certainly not least in the port of FDLIBM to Java, the transcendental methods for sin, cos, and tan. Some more tests are to be written in the StrictMath directory to verify that the StrictMath algorihtm for sin/cos/tan is being used rather than a different one. However, I wanted to

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-02-28 Thread Joe Darcy
On Wed, 1 Mar 2023 05:28:34 GMT, Joe Darcy wrote: > Last and certainly not least in the port of FDLIBM to Java, the > transcendental methods for sin, cos, and tan. > > Some more tests are to be written in the StrictMath directory to verify that > the StrictMath algorihtm for sin/cos/tan is

Re: RFR: 8299807: newStringNoRepl should avoid copying arrays for ASCII compatible charsets [v4]

2023-02-28 Thread Glavo
On Sat, 28 Jan 2023 19:54:32 GMT, Glavo wrote: >> This is the javadoc of `JavaLangAccess::newStringNoRepl`: >> >> >> /** >> * Constructs a new {@code String} by decoding the specified subarray of >> * bytes using the specified {@linkplain java.nio.charset.Charset >> charset}. >>

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v4]

2023-02-28 Thread Martin Doerr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little > Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". > > This PR does not include code for VaList support because it's supposed to get > removed by

Re: RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. [v5]

2023-02-28 Thread David Holmes
On Mon, 27 Feb 2023 23:11:27 GMT, Leonid Mesnik wrote: >> The solution proposed by Stefan K >> >> The startProcess() might wait forever for the expected line if the process >> exits (failed to start). It makes sense to just fail earlier in such cases. >> >> The fix also move >> 'output = new

Re: 8281301: Map.of() calls with null argument should throw more contextual information.

2023-02-28 Thread Stuart Marks
Sorry, it appears that you have fallen into a thicket of issues. [*] I'm usually fairly skeptical of these kinds of changes, as they often have more overhead than is apparent. Java requires all arguments to be /evaluated/ before the method is invoked. Evaluating a lambda includes loading and

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-02-28 Thread Stuart Marks
On Wed, 1 Mar 2023 01:32:39 GMT, Roger Riggs wrote: > For this PR, go ahead and integrate, since we've already spent the budget for > reviewing it. I'm ok with this, as Roger said, since we've all already looked at it. I'm not really interested in seeing 234 followup changes removing

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Xiaohong Gong
On Tue, 28 Feb 2023 23:08:29 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >>

Re: RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-02-28 Thread Iris Clark
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote: > The following typo: `@returnss` was reported on line _482 of Reflection > Factory.java_. > > In addition to fixing that, I have replaced multiple instances of `@returns` > with `@return` in the same file. Marked as reviewed by iris

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-02-28 Thread Roger Riggs
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote: > `LinkedList` is used as a field > `jdk.tools.jimage.JImageTask.OptionsValues#jimages` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred as more

Re: RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-02-28 Thread Martin Buchholz
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote: > The following typo: `@returnss` was reported on line _482 of Reflection > Factory.java_. > > In addition to fixing that, I have replaced multiple instances of `@returns` > with `@return` in the same file. Marked as reviewed by martin

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-02-28 Thread Mandy Chung
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote: > The following typo: `@returnss` was reported on line _482 of Reflection > Factory.java_. > > In addition to fixing that, I have replaced multiple instances of `@returns` > with `@return` in the same file. The change is okay. This is an

Re: RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-02-28 Thread Jaikiran Pai
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote: > The following typo: `@returnss` was reported on line _482 of Reflection > Factory.java_. > > In addition to fixing that, I have replaced multiple instances of `@returns` > with `@return` in the same file. Marked as reviewed by jpai

Integrated: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

2023-02-28 Thread Leonid Mesnik
On Fri, 24 Feb 2023 22:15:18 GMT, Leonid Mesnik wrote: > The solution proposed by Stefan K > > The startProcess() might wait forever for the expected line if the process > exits (failed to start). It makes sense to just fail earlier in such cases. > > The fix also move > 'output = new

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-02-28 Thread Stuart Marks
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote: > `LinkedList` is used as a field > `jdk.tools.jimage.JImageTask.OptionsValues#jimages` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred as more

Integrated: 8282319: java.util.Locale method to stream available Locales

2023-02-28 Thread Justin Lu
On Fri, 27 Jan 2023 21:48:26 GMT, Justin Lu wrote: > This PR adds a new method to java.util.Locale which returns Stream > > The contents of the Stream are composed of the same underlying elements as > Locale.getAvailableLocales(). > > This method allows streaming of the Locale array without

Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v2]

2023-02-28 Thread Brian Burkhalter
On Tue, 28 Feb 2023 17:10:51 GMT, Brian Burkhalter wrote: >> src/jdk.unsupported/share/classes/com/sun/nio/file/SensitivityWatchEventModifier.java >> line 40: >> >>> 38: * {@code WatchService} is used only on macOS and likely to be removed >>> 39: * in a future release when a version based

RFR: 8303405: fix @returnss typo in ReflectionFactory

2023-02-28 Thread Justin Lu
The following typo: `@returnss` was reported on line _482 of Reflection Factory.java_. In addition to fixing that, I have replaced multiple instances of `@returns` with `@return` in the same file. - Commit messages: - @return tag fix for methods Changes:

Re: RFR: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test [v5]

2023-02-28 Thread Stuart Marks
On Mon, 27 Feb 2023 14:04:42 GMT, Matthew Donovan wrote: >> Removed SSLSocketParametersTest.sh script (which just called a Java file) >> and configured the java code to run directly with jtreg > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Paul Sandoz
On Tue, 28 Feb 2023 23:08:29 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >>

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Sandhya Viswanathan
On Tue, 28 Feb 2023 23:08:29 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >>

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 23:11:35 GMT, Sandhya Viswanathan wrote: >> Eirik Bjorsnos has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Uppercase Thorn is 0xDE >> - Update 'a' to 'A' and 'z' to 'Z' in comments > > Looks good to me. Thanks,

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v2]

2023-02-28 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 22:19:46 GMT, Sandhya Viswanathan wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use GE, LE, NE operations instead of the lt,not combinations. Use >> uppercase in vectorized code to match

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v2]

2023-02-28 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v4]

2023-02-28 Thread Roger Riggs
On Tue, 28 Feb 2023 13:29:49 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove @throws

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Sandhya Viswanathan
On Tue, 28 Feb 2023 15:59:26 GMT, Eirik Bjorsnos wrote: > This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text >

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v3]

2023-02-28 Thread Raffaello Giulietti
On Tue, 28 Feb 2023 19:45:02 GMT, Stuart Marks wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) > > In concept, having APIs that search a

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v4]

2023-02-28 Thread Tagir F . Valeev
On Tue, 28 Feb 2023 13:29:49 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove @throws

Re: RFR: 8298619: java/io/File/GetXSpace.java is failing [v3]

2023-02-28 Thread Brian Burkhalter
On Wed, 22 Feb 2023 18:26:49 GMT, Brian Burkhalter wrote: >> There has definitely been a problem with quotas on Windows. I set up quotas >> on actual Windows 11 hardware and replicated the same failure. I am not sure >> how much lack of system quiescence is to blame, but there would be no harm

Re: JEP-198 - Lets start talking about JSON

2023-02-28 Thread Remi Forax
> From: "Brian Goetz" > To: "Ethan McCue" , "core-libs-dev" > > Sent: Tuesday, February 28, 2023 8:48:00 PM > Subject: Re: JEP-198 - Lets start talking about JSON > As you can probably imagine, I've been thinking about these topics for quite a > while, ever since we started working on records

8281301: Map.of() calls with null argument should throw more contextual information.

2023-02-28 Thread Sage Vaillancourt
Hi there. It's my first time posting to the development list, so please forgive any formatting errors. My proposed change is pretty small. Basically, a pattern I see with some frequency is calling Objects.requireNonNull(object, "objectName") before (or within) Map.of(), because otherwise there's

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Eric Caspole
On Tue, 28 Feb 2023 15:59:26 GMT, Eirik Bjorsnos wrote: > This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text >

Re: RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-02-28 Thread Jorn Vernee
On Thu, 23 Feb 2023 06:18:49 GMT, Martin Doerr wrote: >> Implementation of "Foreign Function & Memory API" for linux on Power (Little >> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification". >> >> This PR does not include code for VaList support because it's supposed to

Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v2]

2023-02-28 Thread Brian Burkhalter
On Tue, 28 Feb 2023 11:09:33 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8303175: Move @deprecated above @since; tweak verbiage > >

Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v3]

2023-02-28 Thread Brian Burkhalter
> Deprecate `SensitivityWatchEventModifier` for now instead of directly > removing it as proposed in #12626. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8303175: Change since value of @Deprecated annotation from 7 to 21

RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Eirik Bjorsnos
This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves as an example of how vectorization can be useful also in the area of text processing. It takes advantage of the fact that ASCII and Latin-1

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v3]

2023-02-28 Thread Stuart Marks
On Tue, 28 Feb 2023 13:31:56 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: JEP-198 - Lets start talking about JSON

2023-02-28 Thread Brian Goetz
As you can probably imagine, I've been thinking about these topics for quite a while, ever since we started working on records and pattern matching.  It sounds like a lot of your thoughts have followed a similar arc to ours. I'll share with you some of our thoughts, but I can't be engaging in

Re: RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. [v5]

2023-02-28 Thread Roger Riggs
On Mon, 27 Feb 2023 23:11:27 GMT, Leonid Mesnik wrote: >> The solution proposed by Stefan K >> >> The startProcess() might wait forever for the expected line if the process >> exits (failed to start). It makes sense to just fail earlier in such cases. >> >> The fix also move >> 'output = new

Integrated: 8303227: JniObjWithEnv should be NullablePointer compliant

2023-02-28 Thread Julian Waters
On Mon, 27 Feb 2023 08:19:53 GMT, Julian Waters wrote: > JniObjWithEnv is a struct that is commonly managed by std::unique_ptr. > Although it can support managing objects that are not raw pointers, any such > objects have to be >

Integrated: JDK-8302040: Port fdlibm sqrt to Java

2023-02-28 Thread Joe Darcy
On Thu, 23 Feb 2023 23:28:11 GMT, Joe Darcy wrote: > The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. This

Re: RFR: 8303227: JniObjWithEnv should be NullablePointer compliant

2023-02-28 Thread Alexey Semenyuk
On Mon, 27 Feb 2023 08:19:53 GMT, Julian Waters wrote: > JniObjWithEnv is a struct that is commonly managed by std::unique_ptr. > Although it can support managing objects that are not raw pointers, any such > objects have to be >

Re: RFR: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException

2023-02-28 Thread Naoto Sato
On Tue, 28 Feb 2023 00:07:05 GMT, Justin Lu wrote: > The method `java.util.Date.parse(String)` and as a result, constructor > `java.util.Date(String)` throw an `IllegalArgumentException`. This exception > is not properly referenced in the javadoc, and this PR simply adds the throws > javadoc

Re: JEP-198 - Lets start talking about JSON

2023-02-28 Thread Ethan McCue
Link to the proxy which I forgot to include https://gist.github.com/bowbahdoe/eb29d172351162408eab5e4ee9d84fec On Tue, Feb 28, 2023 at 12:16 PM Ethan McCue wrote: > As an update to my character arc, I documented and wrote up an explanation > for the prototype library I was working on.[1] > >

Re: JEP-198 - Lets start talking about JSON

2023-02-28 Thread Ethan McCue
As an update to my character arc, I documented and wrote up an explanation for the prototype library I was working on.[1] And I've gotten a good deal of feedback on reddit[2] and in private. I think its relevant to the conversation here in the sense of - There are more of rzwitserloot's

Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v2]

2023-02-28 Thread Brian Burkhalter
On Tue, 28 Feb 2023 11:24:59 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8303175: Move @deprecated above @since; tweak verbiage > >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 14:47:52 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 14:41:16 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: JDK-8302666: Replace CHM with VarHandle in ForeachOrderedTask [v5]

2023-02-28 Thread Paul Sandoz
On Tue, 28 Feb 2023 11:09:37 GMT, Viktor Klang wrote: >> I noticed when looking at the code that there was no real need to use a CHM >> to perform the tracking of activation in an ordered fashion on >> ForEachOrderedTask, but instead a VarHandle can be used, reducing >> allocations and

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:43:32 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: 8294982: Implementation of Classfile API [v28]

2023-02-28 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.

Integrated: 8303350: Fix mistyped {@code}

2023-02-28 Thread Pavel Rappo
On Tue, 28 Feb 2023 13:31:06 GMT, Pavel Rappo wrote: > Please review this trivial fix. This pull request has now been integrated. Changeset: dc5ea6ae Author:Pavel Rappo URL: https://git.openjdk.org/jdk/commit/dc5ea6aeb500d531b4ba49c8e95bf97744cc6c33 Stats: 6 lines in 3 files

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Maurizio Cimadamore
On Tue, 28 Feb 2023 14:33:58 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java >> line 38: >> >>> 36: private final List> attributes = new ArrayList<>(); >>> 37: >>> 38: public AttributeHolder() { >> >> default constructor > >

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Roger Riggs
On Tue, 28 Feb 2023 09:05:44 GMT, John Hendrikx wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903: >> >>> 1901: throw new OutOfMemoryError("Required length exceeds >>> implementation limit"); >>> 1902: } >>> 1903: int total = count

Re: RFR: 8303350: Fix mistyped {@code}

2023-02-28 Thread Jaikiran Pai
On Tue, 28 Feb 2023 13:31:06 GMT, Pavel Rappo wrote: > Please review this trivial fix. The changes look fine to me. - Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/12784

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:47:04 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 13:40:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: 8294982: Implementation of Classfile API [v20]

2023-02-28 Thread Adam Sotona
On Thu, 16 Feb 2023 12:55:06 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added 4-byte Unicode text to Utf8EntryTest > >

Re: RFR: 8303198: System and Runtime.exit() resilience to logging errors

2023-02-28 Thread Alan Bateman
On Tue, 28 Feb 2023 02:45:36 GMT, David Holmes wrote: > But does that logging include the thread identity? If multiple threads can > race to exit and all log, then the developer/user needs to know which logging > came from which thread. That's really up to the Logger and its configuration. If

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v5]

2023-02-28 Thread Andrey Turbanov
On Mon, 27 Feb 2023 18:26:51 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. >

RFR: 8303350: Fix mistyped {@code}

2023-02-28 Thread Pavel Rappo
Please review this trivial fix. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/12784/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12784=00 Issue: https://bugs.openjdk.org/browse/JDK-8303350 Stats: 6 lines in 3 files changed: 0 ins; 0 del;

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v3]

2023-02-28 Thread Raffaello Giulietti
On Tue, 28 Feb 2023 13:31:56 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v2]

2023-02-28 Thread Raffaello Giulietti
On Fri, 24 Feb 2023 17:45:23 GMT, Raffaello Giulietti wrote: >> Add an `indexOf()` variant allowing to specify both a lower and an upper >> bound on the search. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) [v3]

2023-02-28 Thread Raffaello Giulietti
> Add an `indexOf()` variant allowing to specify both a lower and an upper > bound on the search. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8302590: Add String.indexOf(int ch, int fromIndex, int toIndex) -

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Jim Laskey
On Tue, 28 Feb 2023 10:54:14 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize for empty CharSequence > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1837: > >>

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v4]

2023-02-28 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with two additional commits since the last revision: - Remove @throws IndexOutOfBoundsException - Change error report to use "is negative"

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Jim Laskey
On Tue, 28 Feb 2023 07:50:18 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize for empty CharSequence > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1879: > >>

Re: RFR: 8303227: JniObjWithEnv should be NullablePointer compliant

2023-02-28 Thread Julian Waters
On Mon, 27 Feb 2023 08:19:53 GMT, Julian Waters wrote: > JniObjWithEnv is a struct that is commonly managed by std::unique_ptr. > Although it can support managing objects that are not raw pointers, any such > objects have to be >

Re: RFR: 8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal [v2]

2023-02-28 Thread Alan Bateman
On Fri, 24 Feb 2023 19:04:33 GMT, Brian Burkhalter wrote: >> Deprecate `SensitivityWatchEventModifier` for now instead of directly >> removing it as proposed in #12626. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: JDK-8297605 DelayQueue javadoc is confusing

2023-02-28 Thread Viktor Klang
On Mon, 27 Feb 2023 20:09:12 GMT, Martin Buchholz wrote: >> Here's my attempt: >> >> >> * An unbounded {@linkplain BlockingQueue blocking queue} of {@link Delayed} >> * elements, in which an element generally becomes eligible for removal when >> its >> * delay has expired. >> * >> * An

Re: RFR: JDK-8302666: Replace CHM with VarHandle in ForeachOrderedTask [v5]

2023-02-28 Thread Viktor Klang
> I noticed when looking at the code that there was no real need to use a CHM > to perform the tracking of activation in an ordered fashion on > ForEachOrderedTask, but instead a VarHandle can be used, reducing allocations > and indirection. Viktor Klang has refreshed the contents of this pull

Re: RFR: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException

2023-02-28 Thread Lance Andersen
On Tue, 28 Feb 2023 00:07:05 GMT, Justin Lu wrote: > The method `java.util.Date.parse(String)` and as a result, constructor > `java.util.Date(String)` throw an `IllegalArgumentException`. This exception > is not properly referenced in the javadoc, and this PR simply adds the throws > javadoc

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Alan Bateman
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Optimize for empty

Re: RFR: JDK-8302666: Replace CHM with VarHandle in ForeachOrderedTask [v4]

2023-02-28 Thread Viktor Klang
On Tue, 28 Feb 2023 09:04:21 GMT, ExE Boss wrote: >> Viktor Klang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Updating copyright header of ForEachOps.java and removing unnecessary >> suppression of an

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Alan Bateman
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Optimize for empty

Re: RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

2023-02-28 Thread Andrey Turbanov
On Mon, 27 Feb 2023 22:59:42 GMT, Roger Riggs wrote: >> `LinkedList` is used as a field >> `jdk.tools.jimage.JImageTask.OptionsValues#jimages` >> It's created, filled (with `add`) and then iterated. No removes from the >> head or something like this. `ArrayList` should be preferred as more >>

Re: RFR: 8302872: Speed up StringLatin1.regionMatchesCI_UTF16

2023-02-28 Thread Eirik Bjorsnos
On Sat, 18 Feb 2023 18:22:49 GMT, Eirik Bjorsnos wrote: > This PR continues the efforts from #12632 to speed up case-insensitive string > matching. > > We now tackle case-insensitive comparison of mixed-coder strings, implemented > in `StringLatin1.regionMatchesCI_UTF16` > > Key insights: >

RFR: 8302872: Speed up StringLatin1.regionMatchesCI_UTF16

2023-02-28 Thread Eirik Bjorsnos
This PR continues the efforts from #12632 to speed up case-insensitive string matching. We now tackle case-insensitive comparison of mixed-coder strings, implemented in `StringLatin1.regionMatchesCI_UTF16` Key insights: - If the UTF16 code point is also in latin1 range, we can leverage

Re: RFR: JDK-8302666: Replace CHM with VarHandle in ForeachOrderedTask [v4]

2023-02-28 Thread ExE Boss
On Mon, 27 Feb 2023 09:14:56 GMT, Viktor Klang wrote: >> I noticed when looking at the code that there was no real need to use a CHM >> to perform the tracking of activation in an ordered fashion on >> ForEachOrderedTask, but instead a VarHandle can be used, reducing >> allocations and

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread John Hendrikx
On Tue, 28 Feb 2023 07:43:13 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize for empty CharSequence > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903: > >>

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v3]

2023-02-28 Thread Tagir F . Valeev
On Mon, 27 Feb 2023 13:30:47 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Optimize for empty

Re: RFR: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException

2023-02-28 Thread Alan Bateman
On Tue, 28 Feb 2023 00:07:05 GMT, Justin Lu wrote: > The method `java.util.Date.parse(String)` and as a result, constructor > `java.util.Date(String)` throw an `IllegalArgumentException`. This exception > is not properly referenced in the javadoc, and this PR simply adds the throws > javadoc