On Mon, 15 May 2023 14:48:58 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is caching
On Tue, 16 May 2023 01:34:45 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request with a new target bas
On Tue, 16 May 2023 01:34:45 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request with a new target bas
On Fri, 12 May 2023 12:47:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which addresses the issue
> noted in https://bugs.openjdk.org/browse/JDK-8307403?
>
> When we recently did a change in https://bugs.openjdk.org/browse/JDK-8299748,
> there was a oversight
> I fixed File.listRoots description.
> * remove "the insertion or ejection of removable media"
> * change "available" to "existing"
>
> Please review this change.
Nagata-Haruhito has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
On Mon, 15 May 2023 15:10:06 GMT, Volker Simonis wrote:
>> Can I please get a review of this test only change which addresses the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8307403?
>>
>> When we recently did a change in
>> https://bugs.openjdk.org/browse/JDK-8299748, there was a ov
On Fri, 12 May 2023 12:47:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which addresses the issue
> noted in https://bugs.openjdk.org/browse/JDK-8307403?
>
> When we recently did a change in https://bugs.openjdk.org/browse/JDK-8299748,
> there was a oversight
On Thu, 11 May 2023 15:40:50 GMT, Justin Lu wrote:
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cl
> Refactor the Platform class in jdk.jpackage to use the internal
> OperatingSystem, Architecture, and Version classes.
> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
> comparisons in the Platform class.
> The checks of the os.version are replaced but may not be needed if
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize th
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Fix link in snippet of File::toPath
-
Changes:
- all: https://git.openjdk
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The chec
On Fri, 12 May 2023 22:04:24 GMT, Alexander Matveev
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Minor source code style cleanup
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51:
>
On Sun, 14 May 2023 23:00:14 GMT, Joe Darcy wrote:
> Make the nested classes inside FdLibm.java consistently package-access,
> static and final.
This pull request has now been integrated.
Changeset: 7b0b9b57
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/7b0b9b570b5d6e90e
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
On Fri, 12 May 2023 12:47:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which addresses the issue
> noted in https://bugs.openjdk.org/browse/JDK-8307403?
>
> When we recently did a change in https://bugs.openjdk.org/browse/JDK-8299748,
> there was a oversight
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cleanup. No functionality is changed,
> the Locale equ
On Mon, 15 May 2023 14:48:58 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is caching
> Please review this javadoc only change which uses `@snippet` and `@linkplain`
> in i18n related util packages.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Use elipsis replacement in snippet tag recommended in JDK PR #13957
--
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Address reviewer comments since previous commit
-
Changes:
- all: https:/
On Mon, 15 May 2023 17:18:01 GMT, Jim Laskey wrote:
>> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 146:
>>
>>> 144:
>>> 145: if (Modifier.isStatic(mods) &&
>>> mainMethod.getDeclaringClass() != mainClass) {
>>> 146: System.err.println("W
On Sun, 14 May 2023 23:00:14 GMT, Joe Darcy wrote:
> Make the nested classes inside FdLibm.java consistently package-access,
> static and final.
Changes look good.
-
Marked as reviewed by smarks (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13972#pullrequestreview-14271
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Requested Changes #2
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13689/files
- new: ht
On Tue, 9 May 2023 21:46:51 GMT, Roger Riggs wrote:
> Launching of processes on Windows using `ProcessCreateW` with a Unicode
> character set requires the buffer to be writable. An access violation might
> occur if `ProcessCreateW` writes to the command line string. The current
> implementatio
On Fri, 21 Apr 2023 17:06:44 GMT, Roger Riggs wrote:
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem
> and Architecture instead of os.name and os.arch.
> They are direct replacements for the Platform enums except for UNKNOWN; its
> use is refactored to report er
On Mon, 15 May 2023 16:31:38 GMT, Thomas Stuefe wrote:
> The fact that this error is in there since JDK 13 is scary.
The error is there since ten years since the `posix_spawn` mechanism was
initially introduced with
[JDK-5049299](https://bugs.openjdk.org/browse/JDK-5049299) for JDK 8 and
down
On Mon, 15 May 2023 07:48:26 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 896:
>
>> 894:
On Mon, 15 May 2023 07:13:49 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 134:
>
>> 132:
>
On Fri, 12 May 2023 17:57:43 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829681
On Mon, 15 May 2023 06:38:48 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 146:
>
>> 144:
>
On Fri, 12 May 2023 17:57:43 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-829681
On Mon, 15 May 2023 06:45:45 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> test/jdk/tools/launcher/InstanceMainTest.java line 31:
>
>> 29: * @run main InstanceMainT
On Mon, 15 May 2023 14:34:13 GMT, Adam Sotona wrote:
>> I have to side with @liach here: `LinkedList` iteration is significantly
>> slower than `ArrayList` even though the computational complexity is
>> identical. Often by an integer factor. This is due to the sparseness of the
>> linked list
On Mon, 15 May 2023 06:31:40 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update VirtualParser.java
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 35:
>
>> 33: publ
On Sun, 14 May 2023 06:37:05 GMT, Alan Bateman wrote:
>>> > I'm just wondering where a developer might go to get a definitive list,
>>> > i.e. aside from this API note, how would they know that "-trad" or
>>> > "-traditional" can be used to configure the ordering.
>>> > Locale.forLanguageTag s
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
On Mon, 15 May 2023 12:31:49 GMT, Volker Simonis wrote:
> > Looks ok.
> > Is it practical to write a test for this situation? Can I assume you've
> > validated the improvement as a remedy for the observed hangs?
>
> I thought about a test but couldn't come up with a practical way to write it.
> This PR improves both the worst-case performance of `nextExponential` and
> `nextGaussian` and the distribution of output at the tails. It fixes the
> following imperfections:
>
> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a
> rounding error to accumulate at the ta
On Fri, 12 May 2023 12:47:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which addresses the issue
> noted in https://bugs.openjdk.org/browse/JDK-8307403?
>
> When we recently did a change in https://bugs.openjdk.org/browse/JDK-8299748,
> there was a oversight
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in `NameAndT
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a
On Mon, 15 May 2023 13:42:05 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>>
>>> 55: public void setup() throws IOException {
>>> 56: shared = new LinkedList<>();
>>> 57: unshared = new LinkedList<>();
>>
>> Linke
On Fri, 12 May 2023 13:19:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed jmh benchmark parameters
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>
>> 55:
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
On Sun, 14 May 2023 17:28:33 GMT, Thomas Stuefe wrote:
> Trying to understand this, and the scope of the problem:
>
> * Parent process opens "in" pipe.
>
> * Now owns read and write end of pipe.
>
> * Parent forks jspawnhelper.
>
> * jspawnhelper inherits handles. Now there ar
On Fri, 12 May 2023 21:37:36 GMT, Roger Riggs wrote:
> Looks ok.
>
> Is it practical to write a test for this situation? Can I assume you've
> validated the improvement as a remedy for the observed hangs?
I thought about a test but couldn't come up with a practical way to write it.
The JVM ha
On Fri, 17 Feb 2023 04:43:00 GMT, Xiaowei Lu wrote:
>> [JDK-8269667](https://bugs.openjdk.org/browse/JDK-8269667) has uncovered the
>> poor performance of BigDecimal.divide under certain circumstance.
>>
>> We confront similar situations when benchmarking Spark3 on TPC-DS test kit.
>> Accordin
On Mon, 15 May 2023 10:04:22 GMT, Chang Peng wrote:
> > This looks like it might be removed by loop opts. I think you might need a
> > blackhole somewhere.
>
> `m` will be updated in every iteration of this loop, so `m` is not a
> loop-invariants actually. I can see the assembly code of this l
On Sun, 14 May 2023 23:00:14 GMT, Joe Darcy wrote:
> Make the nested classes inside FdLibm.java consistently package-access,
> static and final.
LGTM
-
PR Comment: https://git.openjdk.org/jdk/pull/13972#issuecomment-1547571116
On Fri, 12 May 2023 13:19:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed jmh benchmark parameters
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>
>> 55:
On Mon, 15 May 2023 08:57:30 GMT, Andrew Haley wrote:
> This looks like it might be removed by loop opts. I think you might need a
> blackhole somewhere.
```m``` will be updated in every iteration of this loop, so ```m``` is not a
loop-invariants actually.
I can see the assembly code of this l
On Mon, 15 May 2023 08:56:37 GMT, Andrew Haley wrote:
> That makes sense. Is it likely that there are more of these combined
> operations on vector masks that could be matched? if so, it might make sense
> to do the job earlier, in the C2 optimizer.
Thanks for your review.
I have tried to opt
On Tue, 2 May 2023 12:23:23 GMT, Julian Waters wrote:
>> Windows no longer uses I64d anywhere in their newer compilers, instead using
>> the conforming lld specifiers. Minor cleanup here in JLI code to reflect that
>
> Julian Waters has updated the pull request incrementally with one additional
On Sat, 13 May 2023 14:11:11 GMT, Chen Liang wrote:
>> The jdk.internal.classfile.components package's interfaces have
>> implementations in their nested classes, which are implicitly public and
>> exported with the package. They are now moved to the impl package to avoid
>> unwanted exposures
On Mon, 15 May 2023 02:58:46 GMT, Chang Peng wrote:
> In Vector API Java level, vector mask is represented as a boolean array with
> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
> is loaded into vector register, e.g. Neon, the in-memory format will be
> converted
Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc` and
`PackageDesc` become obsolete after
[JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
All references to `jdk.internal.classfile.java.lang.constant.ModuleDesc` and
`jdk.internal.classfile.java.lang.constant
This PR make s390x to adapt the changes done in
[JDK-8276901](https://bugs.openjdk.org/browse/JDK-8276901) OR implements
UseHeavyMonitors.
[JDK-8291555](https://bugs.openjdk.org/browse/JDK-8291555) still needs Porting
effort. As for `LM_LIGHTWEIGHT` locking mode, code is Unimplemented.
--
On Thu, 11 May 2023 11:25:51 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update VirtualParser.java
src/java.base/share/
On Mon, 3 Apr 2023 16:58:15 GMT, Andrey Turbanov wrote:
> `Pattern.namedGroups` and `Matcher.namedGroups` contains only non-null
> values. It means instead of separate `containsKey`+`get` calls, we can use
> single `HashMap.get` call and then compare result with null.
> Result code is a bit sim
63 matches
Mail list logo
