On Thu, 18 May 2023 00:50:22 GMT, Naoto Sato wrote:
>>> Hello @naotoj . I'm not sure we can remove Solaris related charsets.
>>> Somebody may use them for text communication between Solaris.
>>
>> OK, maybe not now.
>>
>> I think the fix may be simplified by changing access for those
>> `Doub
Please review this PR which updates the Scientific Notation section of Decimal
Format. It aims to resolve
[JDK-8159023](https://bugs.openjdk.org/browse/JDK-8159023) as well as
[JDK-6282188](https://bugs.openjdk.org/browse/JDK-6282188).
**Scientific Notation** in Decimal Format contains the defi
On Fri, 19 May 2023 22:57:39 GMT, Maurizio Cimadamore
wrote:
> > This look much better. Can we strengthen the specification of
> > `canonicalLayouts` in accordance with the class specification
>
> We can't do more in that method javadoc, think, as that has to be general
> enough for all linke
On Fri, 19 May 2023 22:43:56 GMT, Paul Sandoz wrote:
> This look much better. Can we strengthen the specification of
> `canonicalLayouts` in accordance with the class specification
We can't do more in that method javadoc, think, as that has to be general
enough for all linkers. I think the ru
On Fri, 19 May 2023 22:20:32 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Address review comments
>> - More javadoc tweaks
>
> src/java.base/share/classes/java/lang/foreign/Linker.java
On Fri, 19 May 2023 21:13:24 GMT, Erik Joelsson wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Fri, 19 May 2023 11:08:10 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Fri, 19 May 2023 11:08:10 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
> I ran this patch in our internal build and test system and got failures on
> macos and windows.
Thanks a lot, @erikj79! I was going to ask your help for testing the patch.
> I think I know the cause for the mac failure, but the Windows
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote:
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Buil
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with o
Original description for JDK-8307194 change:
-
This PR is branched from the makefile changes for
https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
handling the JDK/hotspot static libraries:
- Build hotspot libjvm.a and JDK static libraries for
static-libs-image/sta
On Wed, 29 Mar 2023 01:40:36 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Tue, 16 May 2023 14:44:25 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add NONZERO check for downcall_stub_address_offset_in_bytes().
>
> src/java.base/share/classes/jdk/internal/forei
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Thu, 18 May 2023 19:44:01 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
On Fri, 19 May 2023 17:11:40 GMT, Alan Bateman wrote:
>> I don't think there is any chance that the factory method returns a Collator
>> that fails to meet the settings in the locale, because
>> setStrength()/setDecompositon() with valid values never fail. So the
>> returned instance will alwa
On Fri, 12 May 2023 17:56:12 GMT, Justin Lu wrote:
> Please review this trivial fix which updates the IANA data to version
> 5/11/2023. As the update only includes variant sub-tags, there is no impact
> to JDK tests. The update can be found
> [here](https://mm.icann.org/pipermail/ietf-language
On Fri, 19 May 2023 16:44:04 GMT, Naoto Sato wrote:
> I don't think there is any chance that the factory method returns a Collator
> that fails to meet the settings in the locale, because
> setStrength()/setDecompositon() with valid values never fail. So the returned
> instance will always hav
On Tue, 17 Jan 2023 15:55:40 GMT, Jan Lahoda wrote:
>> The pattern matching switches are using a bootstrap method
>> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch.
>> Basically, for a switch like:
>>
>> switch (obj) {
>> case String s when s.isEmpty() -> {}
>> case
On Fri, 19 May 2023 07:59:58 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a table for possible BCP47 values and their mappings
>
> src/java.base/share/classes/java/text/Collator.java line 2
On Fri, 19 May 2023 06:28:47 GMT, David Holmes wrote:
> > Sorry, but I don't understand this argument. If we do a short read we will
> > work with corrupted ChildStuff and SpawnInfo
> > structures. This can in the extreme case execute arbitrary code (e.g. if
> > ChildStuff.argv is not fully rea
On Fri, 19 May 2023 09:46:59 GMT, Matthias Baesken wrote:
>> MappedMemoryUtils.c can generate exceptions like those :
>> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>>at
>> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>>at java.ba
On Thu, 18 May 2023 21:33:53 GMT, Alexey Semenyuk wrote:
> > did we test jpackage on AIX system?
>
> I don't think so. What is the native packaging on this platform?
To the best of my knowledge, AIX uses `installp` and `rpm`.
-
PR Comment: https://git.openjdk.org/jdk/pull/13586#is
> Refactor the Platform class in jdk.jpackage to use the internal
> OperatingSystem, Architecture, and Version classes.
> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
> comparisons in the Platform class.
> The checks of the os.version are replaced but may not be needed if
On Tue, 16 May 2023 11:18:09 GMT, Maurizio Cimadamore
wrote:
> The FFM API exposes layout constants for Java primitives. Among those there
> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
> these layouts is set the same as their size (e.g. 8 bytes).
>
> This is o
On Wed, 10 May 2023 14:19:43 GMT, Martin Doerr wrote:
>> Implementation of "Foreign Function & Memory API" for linux on Power (Little
>> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>>
>> This PR does not include code for VaList support because it's supposed to
>>
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
On Fri, 19 May 2023 13:03:34 GMT, Adam Sotona wrote:
> Tier1 tests just passed on all platforms.
Okay, in that case we should get the change in because there is build breakage
right now.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14060#discussion_r1198940202
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
On Fri, 19 May 2023 12:35:47 GMT, Alan Bateman wrote:
>> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
>> compilation on windows.
>> Unfortunately MSVC does not support variable length arrays.
>> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
On Fri, 19 May 2023 13:01:37 GMT, Adam Sotona wrote:
>> test/jdk/tools/launcher/exeJliLaunchTest.c line 39:
>>
>>> 37: {
>>> 38: //avoid null-terminated array of arguments to test JDK-8303669
>>> 39: char **argv = malloc(sizeof(char *) * argc);
>>
>> If this is building on all platforms
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> - qualified enum constants are supported for case label
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
compilation on windows.
Unfortunately MSVC does not support variable length arrays.
This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
array allocation.
Please review.
Thanks,
Adam
-
Comm
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote:
>> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
>> files to specify `Locale.ROOT` to ensure that case conversion issues don't
>> occur,
>>
>> I didn't add any new tests but ran tier 1-3 with no issues
>
> Dar
On Fri, 19 May 2023 10:06:53 GMT, Maurizio Cimadamore
wrote:
>> The FFM API exposes layout constants for Java primitives. Among those there
>> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
>> these layouts is set the same as their size (e.g. 8 bytes).
>>
>> This
On Wed, 17 May 2023 13:53:55 GMT, Darragh Clarke wrote:
>> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
>> files to specify `Locale.ROOT` to ensure that case conversion issues don't
>> occur,
>>
>> I didn't add any new tests but ran tier 1-3 with no issues
>
> Dar
On Fri, 19 May 2023 10:50:39 GMT, Alan Bateman wrote:
> > May I push it now since it's a build breakage? Thanks.
>
> Yes, the change is trivial so please go ahead.
Thanks @AlanBateman .
-
PR Comment: https://git.openjdk.org/jdk/pull/14057#issuecomment-1554418471
On Fri, 19 May 2023 10:02:04 GMT, Jie Fu wrote:
> May I get review for this change which fixes the build broken with GCC8?
> Thanks.
This pull request has now been integrated.
Changeset: 690d3969
Author:Jie Fu
URL:
https://git.openjdk.org/jdk/commit/690d3969b80776bf896fbfbfac5eabe7d
On Wed, 17 May 2023 18:18:03 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
> This patch adds an instance method on `Linker`, namely
> `Linker::canonicalLayouts` which returns all the layouts known by the linker
> as implementing some ABI type. For instance, if I call this on my machine
> (Linux/x64) I get this:
>
>
> jshell> import java.lang.foreign.*;
>
> jshell> L
On Wed, 17 May 2023 18:18:03 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Fri, 19 May 2023 10:44:02 GMT, Jie Fu wrote:
> May I push it now since it's a build breakage? Thanks.
Yes, the change is trivial so please go ahead.
-
PR Comment: https://git.openjdk.org/jdk/pull/14057#issuecomment-1554390879
On Fri, 19 May 2023 10:12:52 GMT, Alan Bateman wrote:
> This looks okay
Thanks @AlanBateman for your quick review.
May I push it now since it's a build breakage?
Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/14057#issuecomment-1554383346
On Fri, 19 May 2023 09:46:59 GMT, Matthias Baesken wrote:
>> MappedMemoryUtils.c can generate exceptions like those :
>> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>>at
>> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>>at java.ba
On Fri, 19 May 2023 09:46:59 GMT, Matthias Baesken wrote:
>> MappedMemoryUtils.c can generate exceptions like those :
>> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>>at
>> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>>at java.ba
On Fri, 19 May 2023 10:02:04 GMT, Jie Fu wrote:
> May I get review for this change which fixes the build broken with GCC8?
> Thanks.
This looks okay
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14057#pullrequestreview-1434156403
May I get review for this change which fixes the build broken with GCC8?
Thanks.
-
Commit messages:
- 8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c
with GCC8
Changes: https://git.openjdk.org/jdk/pull/14057/files
Webrev: https://webrevs.openjdk.org/?repo=
> The FFM API exposes layout constants for Java primitives. Among those there
> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
> these layouts is set the same as their size (e.g. 8 bytes).
>
> This is obviously correct on 64-bit platforms, but on 32-bit platform it
On Fri, 19 May 2023 09:46:59 GMT, Matthias Baesken wrote:
>> MappedMemoryUtils.c can generate exceptions like those :
>> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>>at
>> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>>at java.ba
On Fri, 19 May 2023 06:58:49 GMT, Matthias Baesken wrote:
> MappedMemoryUtils.c can generate exceptions like those :
> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>at
> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>at java.base/ja
> MappedMemoryUtils.c can generate exceptions like those :
> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>at
> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>at java.base/java.nio.Buffer$2.force(Buffer.java:890)
>at
> java.b
On Wed, 17 May 2023 02:32:56 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request incrementally with th
> The FFM API exposes layout constants for Java primitives. Among those there
> are constants for `JAVA_LONG` and `JAVA_DOUBLE`. Currently, the alignment of
> these layouts is set the same as their size (e.g. 8 bytes).
>
> This is obviously correct on 64-bit platforms, but on 32-bit platform it
On Thu, 18 May 2023 15:44:15 GMT, Alan Bateman wrote:
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of
On Fri, 19 May 2023 09:09:05 GMT, Alan Bateman wrote:
> There is more significant work to do this area and I think we can look at it
> then.
That sounds reasonable to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/14047#issuecomment-1554277576
On Fri, 19 May 2023 08:46:24 GMT, Jaikiran Pai wrote:
> Would it be worth calling `expungeStaleEntries()` to do this cleanup even
> when a specific `ThreadContainer` is deregistered, in the implementation of
> method `deregisterContainer(...)`?
If there is a mix of usages where some are explic
On Fri, 19 May 2023 06:58:49 GMT, Matthias Baesken wrote:
> MappedMemoryUtils.c can generate exceptions like those :
> java.io.UncheckedIOException: java.io.IOException: Invalid argument
>at
> java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
>at java.base/ja
On Thu, 18 May 2023 15:44:15 GMT, Alan Bateman wrote:
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of
On Thu, 18 May 2023 15:44:15 GMT, Alan Bateman wrote:
> ThreadContainers is an internal class used to make thread pools and other
> groupings of threads discoverable for observability. Some refactoring in 2021
> (in the loom repo, and before integration) accidentally changed the creation
> of
ThreadContainers is an internal class used to make thread pools and other
groupings of threads discoverable for observability. Some refactoring in 2021
(in the loom repo, and before integration) accidentally changed the creation of
a weak reference so that it no longer associated with the refere
On Wed, 3 May 2023 12:03:34 GMT, Adam Sotona wrote:
> libjli/java.c's SelectVersion method receives argc and argv but ignores argc
> in some circumstances an instead checks if *argv == 0 in its while loop,
> which results in a segmentation fault if the provided array is not NULL
> terminated.
On Thu, 4 May 2023 09:17:05 GMT, Adam Sotona wrote:
>> libjli/java.c's SelectVersion method receives argc and argv but ignores argc
>> in some circumstances an instead checks if *argv == 0 in its while loop,
>> which results in a segmentation fault if the provided array is not NULL
>> terminat
On Wed, 29 Mar 2023 18:09:22 GMT, Raffaello Giulietti
wrote:
> When appropriate and useful, copies only the relevant portion of the
> `CharSequence` to the match result.
This pull request has now been integrated.
Changeset: 25868b95
Author:Raffaello Giulietti
URL:
https://git.open
On Thu, 18 May 2023 19:44:01 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
MappedMemoryUtils.c can generate exceptions like those :
java.io.UncheckedIOException: java.io.IOException: Invalid argument
at java.base/java.nio.MappedMemoryUtils.force(MappedMemoryUtils.java:105)
at java.base/java.nio.Buffer$2.force(Buffer.java:890)
at
java.base/jdk.interna
68 matches
Mail list logo
