On Mon, 25 Sep 2023 15:52:12 GMT, Aleksei Voitylov
wrote:
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
>
Hi,
The events for socket read and socket write retrieves the remote address even
in cases where the event didn't exceed the threshold. By moving the
shouldCommit check earlier, it can be avoided.
Testing: jdk/jdk/jfr
Thanks
Erik
-
Commit messages:
- Socket write event
-
On Mon, 25 Sep 2023 15:52:12 GMT, Aleksei Voitylov
wrote:
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
>
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000:
On Mon, 25 Sep 2023 15:52:12 GMT, Aleksei Voitylov
wrote:
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
>
On Mon, 25 Sep 2023 15:52:12 GMT, Aleksei Voitylov
wrote:
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
>
On Tue, 19 Sep 2023 01:01:14 GMT, Naoto Sato wrote:
> Fixed the failing (well, false-positive) test case. Made the following
> changes to the test:
>
> - Corrected the path to the mapping files directory
> - Made sure to fail if the directory path is incorrect
> - Took care of `GB18030` alias,
On Sat, 9 Sep 2023 00:02:20 GMT, Aggelos Biboudis
wrote:
> This PR finalizes the feature of unnamed variables and patterns.
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x]
On Mon, 25 Sep 2023 15:52:12 GMT, Aleksei Voitylov
wrote:
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
>
On Wed, 30 Aug 2023 02:01:38 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clean up parameters passed to arrayPartition; update the check to load
>> library
>
> Good. Thank you.
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Mon, 25 Sep 2023 16:44:01 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak support for restricted methods
>>
>> Reviewed-by: jvernee, pminborg
>
>
On Mon, 25 Sep 2023 15:09:09 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
This pull request has now been integrated.
Changeset: afa48333
Author:Mourad Abbay
Committer: Paul
On Mon, 25 Sep 2023 08:11:48 GMT, Per Minborg wrote:
> This PR proposes to add the @sealedGraph tag to
> `java.lang.reflect.Executable`.
Please update the copyright year before pushing.
-
Marked as reviewed by darcy (Reviewer).
PR Review:
test java.lang.String.RegionMatches1Tests fails on all platforms with
-XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
default. The fix is to return true immediately if len is negative, since for
negative length this condition will never be satisfied.
Testing: JCK,
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> distinct plain
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
On Fri, 22 Sep 2023 16:58:05 GMT, Maurizio Cimadamore
wrote:
>> Here you go:
>> https://cr.openjdk.org/~jvernee/FFM_22_PR_v1/java.base/java/lang/foreign/SegmentAllocator.html#allocateFrom(java.lang.foreign.ValueLayout,java.lang.foreign.MemorySegment,java.lang.foreign.ValueLayout,long,long)
>
>
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
8315532: Compiler Implementation for Unnamed Variables and Patterns
-
Commit messages:
- 8315532: Compiler Implementation for Unnamed Variables and Patterns
Changes: https://git.openjdk.org/jdk/pull/15649/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15649=00
Issue:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Sun, 24 Sep 2023 02:46:38 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> distinct plain
On Mon, 25 Sep 2023 12:28:06 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> fix logic error
>
> src/java.base/share/classes/java/util/Formatter.java line 2949:
>
>> 2947: }
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
This is the first draft of a patch for Primitive types in patterns, instanceof,
and switch (Preview).
Draft spec here:
https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
-
Commit messages:
- 8303374: Compiler Implementation for Primitive
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> distinct plain
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 12:06:52 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 12:28:40 GMT, Chen Liang wrote:
> In the constructor of String, many locations the user-supplied byte or char
> arrays are read multiple times with a plain memory access; if a user
> previously wrote to one of such locations out of happens-before order,
> distinct plain
In the constructor of String, many locations the user-supplied byte or char
arrays are read multiple times with a plain memory access; if a user previously
wrote to one of such locations out of happens-before order, distinct plain
memory reads may result in different unanticipated values.
The
On Mon, 25 Sep 2023 11:46:36 GMT, Claes Redestad wrote:
> > The reason why I split it into multiple small methods is to avoid a single
> > method codeSize > 325. After merging small methods, the performance will
> > decrease.
>
> Yes, I can refactor to keep the same structure and verify
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on
On Fri, 22 Sep 2023 22:46:43 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally
On Mon, 25 Sep 2023 07:41:24 GMT, Alan Bateman wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> new benchmark moved to vm/runtime folder.
>
> test/micro/org/openjdk/bench/java/util/NMTBenchmark.java line 24:
>
>>
> A new benchmark for measuring the NMT overhead in `summary` and `detail`
> modes.
> The tests are run using:
>
> make CONF=debug test TEST="micro:java.util.NMTBenchmark"
> MICRO="RESULTS_FORMAT=json"
>
> The results are written to a JSON file that can be visualized using [JMH
>
On Mon, 25 Sep 2023 11:36:10 GMT, 温绍锦 wrote:
> The reason why I split it into multiple small methods is to avoid a single
> method codeSize > 325. After merging small methods, the performance will
> decrease.
Yes, I can refactor to keep the same structure and verify performance is
neutral or
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 10:04:13 GMT, Chen Liang wrote:
>>> UTF8 decoder does not perform any internal state mutation during decoding;
>>
>> Are you sure? I think `CharsetDecoder::decode` will modify the `status`
>> field.
>
> right, it does have a `state` field.
CharsetDecoder is specified to
On Mon, 25 Sep 2023 09:53:47 GMT, Glavo wrote:
>> UTF8 decoder does not perform any internal state mutation during decoding;
>> in addition, if this field is static final, the decoder's error actions are
>> published when the class is initialized, while publishing in a final field
>> does not
On Sun, 24 Sep 2023 20:27:53 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
On Mon, 25 Sep 2023 09:47:15 GMT, Chen Liang wrote:
> UTF8 decoder does not perform any internal state mutation during decoding;
Are you sure? I think `CharsetDecoder::decode` will modify the `status` field.
-
PR Review Comment:
On Mon, 25 Sep 2023 09:40:00 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line
>> 71:
>>
>>> 69: private final class PropertiesFileDecoder extends CharsetDecoder {
>>> 70:
>>> 71: private final CharsetDecoder cdUTF_8 =
>>>
On Mon, 18 Sep 2023 14:41:14 GMT, Chen Liang wrote:
>> A few classes in `sun.util` package have non-final fields which could easily
>> be marked `final`.
>
> src/java.base/share/classes/sun/util/PropertyResourceBundleCharset.java line
> 71:
>
>> 69: private final class
This PR proposes to add the @sealedGraph tag to `java.lang.reflect.Executable`.
-
Commit messages:
- Add @SealedGraph to Executable
Changes: https://git.openjdk.org/jdk/pull/15897/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15897=00
Issue:
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote:
> A new benchmark for measuring the NMT overhead in `summary` and `detail`
> modes.
> The tests are run using:
>
> make CONF=debug test TEST="micro:java.util.NMTBenchmark"
> MICRO="RESULTS_FORMAT=json"
>
> The results are written to a
A new benchmark for measuring the NMT overhead in `summary` and `detail` modes.
The tests are run using:
make CONF=debug test TEST="micro:java.util.NMTBenchmark"
MICRO="RESULTS_FORMAT=json"
The results are written to a JSON file that can be visualized using [JMH
On Tue, 5 Sep 2023 07:53:36 GMT, Afshin Zafari wrote:
> A new benchmark for measuring the NMT overhead in `summary` and `detail`
> modes.
> The tests are run using:
>
> make CONF=debug test TEST="micro:java.util.NMTBenchmark"
> MICRO="RESULTS_FORMAT=json"
>
> The results are written to a
On Wed, 6 Sep 2023 19:56:10 GMT, Gerard Ziemski wrote:
> The test will not compile for me unless I add:
>
> `import java.util.concurrent.TimeUnit;`
Sorry, it was removed mistakenly before pushing the code. Now fixed.
> You said `The JSON file can be used for visualising the results.` Can you
On Tue, 19 Sep 2023 20:03:51 GMT, Naoto Sato wrote:
>> Fixed the failing (well, false-positive) test case. Made the following
>> changes to the test:
>>
>> - Corrected the path to the mapping files directory
>> - Made sure to fail if the directory path is incorrect
>> - Took care of `GB18030`
54 matches
Mail list logo
