Integrated: 8222884: ConcurrentClassDescLookup.java times out intermittently

2024-06-11 Thread Jaikiran Pai
On Tue, 11 Jun 2024 13:09:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which proposes to address > intermittent failures in > `test/jdk/java/io/Serializable/concurrentClassDescLookup/ConcurrentClassDescLookup.java`? > > This addresses

Re: RFR: 8222884: ConcurrentClassDescLookup.java times out intermittently

2024-06-11 Thread Jaikiran Pai
On Tue, 11 Jun 2024 13:09:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which proposes to address > intermittent failures in > `test/jdk/java/io/Serializable/concurrentClassDescLookup/ConcurrentClassDescLookup.java`? > > This addresses

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two

Re: RFR: 8332400: isspace argument should be a valid unsigned char [v2]

2024-06-11 Thread David Holmes
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote: >> ### Summary >> This change ensures we don't get undefined behavior when >> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). >> `isspace` accepts an `int` argument that "the application shall

RFR: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts

2024-06-11 Thread SendaoYan
Hi all, Currently, the testcase `test/jdk/tools/jlink/JLinkReproducibleTest.java` doesn't receive jvm options from jtreg. I think it's necessory to receive jvm options from jtreg. The change has been verified, only change the testacase, the risk is low. - Commit messages: -

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Shaojin Wen
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Shaojin Wen
On Tue, 11 Jun 2024 16:08:18 GMT, Emanuel Peter wrote: >> @eme64 TraceMergeStores are here, but I can't understand these assembly >> codes >> >> # JavaCode >> >> class AbstractStringBuilder { >> private AbstractStringBuilder appendNull() { >> int count = this.count; >>

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Naoto Sato
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alisen Chung
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some for Japanese), but > looks good

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alisen Chung
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties >> line 32: >> >>> 30: border.jobattributes=作业属性 >>> 31: border.media=介质 >>> 32: border.output=出纸 >> >> What triggered this ? Just someone noticing it and

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alisen Chung
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Withdrawn: 8329532: Add an internal MemoryLayout transformer

2024-06-11 Thread duke
On Tue, 2 Apr 2024 15:04:40 GMT, Per Minborg wrote: > This PR proposes to add an internal layout transformer that could be used to > transform MemoryLayout entities. For example, it would be possible to convert > a struct layout to use network order ((big-endian) instead of native byte >

Re: RFR: 8327793: Deprecate jstatd for removal [v4]

2024-06-11 Thread Sean Mullan
On Tue, 11 Jun 2024 21:05:43 GMT, Sean Mullan wrote: >> src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java line 84: >> >>> 82: >>> 83: System.err.println("Warning: jstatd is deprecated for removal >>> in a future release."); >>> 84: >> >> I think we've put "WARNING" in caps

Re: RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v2]

2024-06-11 Thread Roger Riggs
On Mon, 10 Jun 2024 04:08:41 GMT, Chen Liang wrote: >> Please review this patch that fixes a critical issue that breaks some Proxy >> usages. >> >> CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible >> package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such

Re: RFR: 8327793: Deprecate jstatd for removal [v4]

2024-06-11 Thread Sean Mullan
On Tue, 11 Jun 2024 19:35:18 GMT, Alan Bateman wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove annotations > > src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java line 84: > >> 82: >> 83:

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Sean Mullan
On Tue, 11 Jun 2024 16:51:11 GMT, Weijun Wang wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java > line 1436:

Re: RFR: 8327793: Deprecate jstatd for removal [v4]

2024-06-11 Thread Chris Plummer
On Tue, 11 Jun 2024 18:11:55 GMT, Kevin Walls wrote: >> jstatd is an RMI server application which monitors HotSpot VMs, and provides >> an interface to the monitoring tool jstat, for use across a remote RMI >> connection. >> >> RMI is not how modern applications communicate. It is an old

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-11 Thread Ferenc Rakoczi
On Tue, 11 Jun 2024 18:18:41 GMT, Daniel Jeliński wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 70: > >> 68: private long[] state = new

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Alexey Semenyuk
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8327793: Deprecate jstatd for removal [v4]

2024-06-11 Thread Alan Bateman
On Tue, 11 Jun 2024 18:11:55 GMT, Kevin Walls wrote: >> jstatd is an RMI server application which monitors HotSpot VMs, and provides >> an interface to the monitoring tool jstat, for use across a remote RMI >> connection. >> >> RMI is not how modern applications communicate. It is an old

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Damon Nguyen
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Damon Nguyen
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote: >> "Ausgabefächer" is the best German translation here. > > The reason for going with "Bereich (area)" instead of "Fach (compartment)" is > that an area is more general compared to a compartment. At least in German: > every "Fach" is a

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Weijun Wang
On Tue, 11 Jun 2024 18:04:45 GMT, Kevin Walls wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java >> line 1301: >> >>> 1299: } >>> 1300: }; >>> 1301: if (acc == null) { >> >> This is a comment to all

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-11 Thread Daniel Jeliński
On Tue, 11 Jun 2024 17:39:29 GMT, Vladimir Kozlov wrote: >> There is no other use.. That array is there for the sole purpose of holding >> the input as a long array before it gets xor-ed into the state. > > okay Could you try using MethodHandles instead of b2lLittle? Similar to what's used

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-11 Thread Daniel Jeliński
On Mon, 10 Jun 2024 15:01:55 GMT, Ferenc Rakoczi wrote: > This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. src/java.base/share/classes/sun/security/provider/SHA3.java line 70: > 68: private long[] state = new long[DM*DM];

Re: RFR: 8327793: Deprecate jstatd for removal [v4]

2024-06-11 Thread Kevin Walls
> jstatd is an RMI server application which monitors HotSpot VMs, and provides > an interface to the monitoring tool jstat, for use across a remote RMI > connection. > > RMI is not how modern applications communicate. It is an old transport with > long term security concerns, and configuration

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread David Lloyd
On Tue, Jun 11, 2024 at 12:57 PM Alan Bateman wrote: > > > On 11/06/2024 18:19, David Lloyd wrote: > > : > > I thought that might be where Alan was headed with this. I would support > this solution; it would solve the problem for conformant serialization > libraries. If a class has a

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 17:03:58 GMT, Weijun Wang wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java > line 1301:

Re: RFR: 8332400: isspace argument should be a valid unsigned char

2024-06-11 Thread Robert Toyonaga
On Wed, 5 Jun 2024 20:08:10 GMT, Robert Toyonaga wrote: > ### Summary > This change ensures we don't get undefined behavior when > calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). > `isspace` accepts an `int` argument that "the application shall

Re: RFR: 8332400: isspace argument should be a valid unsigned char [v2]

2024-06-11 Thread Robert Toyonaga
> ### Summary > This change ensures we don't get undefined behavior when > calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). > `isspace` accepts an `int` argument that "the application shall ensure is a > character representable as an unsigned char or

Re: RFR: 8327793: Deprecate jstatd for removal [v3]

2024-06-11 Thread Kevin Walls
> jstatd is an RMI server application which monitors HotSpot VMs, and provides > an interface to the monitoring tool jstat, for use across a remote RMI > connection. > > RMI is not how modern applications communicate. It is an old transport with > long term security concerns, and configuration

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Chris Plummer
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-11 Thread Vladimir Kozlov
On Tue, 11 Jun 2024 09:55:11 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Some microbenchmark data (the percentages are improvements in ops/sec): > Benchmark

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread Ron Pressler
> On 11 Jun 2024, at 18:19, David Lloyd wrote: > > I would support this solution; it would solve the problem for conformant > serialization libraries. If a class has a `readObject`/etc. then we use it - > we wouldn't care if it was "natural" or generated. This also gives us the > option to

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread Alan Bateman
On 11/06/2024 18:19, David Lloyd wrote: : I thought that might be where Alan was headed with this. I would support this solution; it would solve the problem for conformant serialization libraries. If a class has a `readObject`/etc. then we use it - we wouldn't care if it was "natural" or

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-11 Thread Vladimir Kozlov
On Tue, 11 Jun 2024 17:30:37 GMT, Ferenc Rakoczi wrote: >> Thank you for explanation. >> >> An other question. Is any other use of `longBuf` array after >> `implCompress0()` call which load values from it? Because Intrinsic code >> will not update it. > > There is no other use.. That array is

Integrated: 8333742: ProcessImpl and ProcessHandleImpl may mishandle processes that exit with code 259

2024-06-11 Thread Daniel Jeliński
On Thu, 6 Jun 2024 18:40:51 GMT, Daniel Jeliński wrote: > `GetExitCodeProcess` method is not reliable for checking if a process exited > already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but > the same value is returned when the process exited with code 259. In order to

RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix

2024-06-11 Thread Justin Lu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920) which corrects a bug where NumberFormat cannot successfully parse values in integer only mode, when the format expects a suffix. For example, // a format that expects a currency suffix var fmt =

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Justin Lu
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote: >> Yeah, I believe you're right. Noted as something else to file against the >> translation tool. > > Just out of curiosity, do we know why `\t` was attached in the first place? I > don't think it is with the original English properties. I

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread David Lloyd
On Tue, Jun 11, 2024 at 11:58 AM Ron Pressler wrote: > > > > On 11 Jun 2024, at 17:27, David Lloyd wrote: > > > > > > > > On Tue, Jun 11, 2024 at 10:17 AM Alan Bateman > wrote: > > On 06/06/2024 18:37, David Lloyd wrote: > >> Just bumping this one more time. I intend to start by opening a JIRA

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Naoto Sato
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote: >> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties >> line 278: >> >>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements >>> "{0}" verweist auf das nicht deklarierte

Re: RFR: 8327793: Deprecate jstatd for removal [v2]

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 16:54:36 GMT, Kevin Walls wrote: >> jstatd is an RMI server application which monitors HotSpot VMs, and provides >> an interface to the monitoring tool jstat, for use across a remote RMI >> connection. >> >> RMI is not how modern applications communicate. It is an old

Re: RFR: 8327793: Deprecate jstatd for removal [v2]

2024-06-11 Thread Alan Bateman
On Tue, 11 Jun 2024 16:54:36 GMT, Kevin Walls wrote: >> jstatd is an RMI server application which monitors HotSpot VMs, and provides >> an interface to the monitoring tool jstat, for use across a remote RMI >> connection. >> >> RMI is not how modern applications communicate. It is an old

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Weijun Wang
On Tue, 11 Jun 2024 16:18:23 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >>

Re: RFR: 8327793: Deprecate jstatd for removal

2024-06-11 Thread Alan Bateman
On Tue, 11 Jun 2024 16:52:13 GMT, Kevin Walls wrote: > Sure, happy to not add annotations in sun.jvmstat.monitor.remote > (RemoteHost.java, RemoteVm.java). Right, you can drop it from all the source files except for module-info.java. - PR Comment:

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread Ron Pressler
> On 11 Jun 2024, at 17:27, David Lloyd wrote: > > > > On Tue, Jun 11, 2024 at 10:17 AM Alan Bateman wrote: > On 06/06/2024 18:37, David Lloyd wrote: >> Just bumping this one more time. I intend to start by opening a JIRA to add >> the two proposed methods to `ReflectionFactory`, and go

Re: RFR: 8327793: Deprecate jstatd for removal

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 13:35:19 GMT, Alan Bateman wrote: > The sun.jvmstat.monitor.remote package is not exported so I don't think > adding `@Deprecated` makes sense. Sure, happy to not add annotations in sun.jvmstat.monitor.remote (RemoteHost.java, RemoteVm.java). - PR Comment:

Re: RFR: 8327793: Deprecate jstatd for removal [v2]

2024-06-11 Thread Kevin Walls
> jstatd is an RMI server application which monitors HotSpot VMs, and provides > an interface to the monitoring tool jstat, for use across a remote RMI > connection. > > RMI is not how modern applications communicate. It is an old transport with > long term security concerns, and configuration

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread David Lloyd
On Tue, Jun 11, 2024 at 11:38 AM Alan Bateman wrote: > > > On 11/06/2024 17:27, David Lloyd wrote: > > : > > Yes, all of the method-access methods on ReflectionFactory are used, not > just for readObject/writeObject but also readObjectNoData, readResolve, and > writeReplace, the constructor

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread Alan Bateman
On 11/06/2024 17:27, David Lloyd wrote: : Yes, all of the method-access methods on ReflectionFactory are used, not just for readObject/writeObject but also readObjectNoData, readResolve, and writeReplace, the constructor accessors, and the factory methods for OptionalDataException. We

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread David Lloyd
On Tue, Jun 11, 2024 at 10:17 AM Alan Bateman wrote: > On 06/06/2024 18:37, David Lloyd wrote: > > Just bumping this one more time. I intend to start by opening a JIRA to > add the two proposed methods to `ReflectionFactory`, and go from there. I > guess that we might need a JEP for the proposed

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-11 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v2]

2024-06-11 Thread Kevin Walls
On Tue, 11 Jun 2024 14:02:17 GMT, Sean Mullan wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More consistent style of calls and comments. > >

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 15:55:18 GMT, Shaojin Wen wrote: >> @wenshao have you published info about `TraceMergeStores` somewhere? It is >> very well possible that the optimization does not apply in your code. Then >> you would need to dig into the VM code and see why. > > @eme64 TraceMergeStores

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 12:11:21 GMT, Shaojin Wen wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert > > ([f96cde4e](https://git.openjdk.org/jdk/pull/19626/files/f96cde4e79e12e2ea46e6061f918a69f11d59985)) > >

Re: RFR: 8222884: ConcurrentClassDescLookup.java times out intermittently

2024-06-11 Thread Matthias Baesken
On Tue, 11 Jun 2024 13:09:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which proposes to address > intermittent failures in > `test/jdk/java/io/Serializable/concurrentClassDescLookup/ConcurrentClassDescLookup.java`? > > This addresses

Re: [External] : Re: New candidate JEP: 471: Deprecate the Memory-Access Methods in sun.misc.Unsafe for Removal

2024-06-11 Thread Alan Bateman
On 06/06/2024 18:37, David Lloyd wrote: Just bumping this one more time. I intend to start by opening a JIRA to add the two proposed methods to `ReflectionFactory`, and go from there. I guess that we might need a JEP for the proposed serialization restrictions, which is going to be

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v2]

2024-06-11 Thread Sean Mullan
On Mon, 10 Jun 2024 16:52:26 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >>

Re: RFR: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory. [v2]

2024-06-11 Thread Maurizio Cimadamore
On Tue, 11 Jun 2024 12:22:24 GMT, Per Minborg wrote: >> This PR proposes to explicitly state that returned segments form the >> `asSlice` and `reinterpret` method share memory regions with `this` memory >> segment. >> >> Note: The term "subset" means a true subset or the same set. > > Per

Re: RFR: 8222884: ConcurrentClassDescLookup.java times out intermittently

2024-06-11 Thread Roger Riggs
On Tue, 11 Jun 2024 13:09:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which proposes to address > intermittent failures in > `test/jdk/java/io/Serializable/concurrentClassDescLookup/ConcurrentClassDescLookup.java`? > > This addresses

Re: RFR: 8327793: Deprecate jstatd for removal

2024-06-11 Thread Alan Bateman
On Tue, 11 Jun 2024 13:09:06 GMT, Kevin Walls wrote: > jstatd is an RMI server application which monitors HotSpot VMs, and provides > an interface to the monitoring tool jstat, for use across a remote RMI > connection. > > RMI is not how modern applications communicate. It is an old transport

RFR: 8327793: Deprecate jstatd for removal

2024-06-11 Thread Kevin Walls
jstatd is an RMI server application which monitors HotSpot VMs, and provides an interface to the monitoring tool jstat, for use across a remote RMI connection. RMI is not how modern applications communicate. It is an old transport with long term security concerns, and configuration difficulties

RFR: 8222884: ConcurrentClassDescLookup.java times out intermittently

2024-06-11 Thread Jaikiran Pai
Can I please get a review of this test-only change which proposes to address intermittent failures in `test/jdk/java/io/Serializable/concurrentClassDescLookup/ConcurrentClassDescLookup.java`? This addresses https://bugs.openjdk.org/browse/JDK-8222884. As noted in that issue, the test in its

Re: RFR: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory. [v2]

2024-06-11 Thread Jorn Vernee
On Tue, 11 Jun 2024 12:22:24 GMT, Per Minborg wrote: >> This PR proposes to explicitly state that returned segments form the >> `asSlice` and `reinterpret` method share memory regions with `this` memory >> segment. >> >> Note: The term "subset" means a true subset or the same set. > > Per

Re: RFR: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory. [v2]

2024-06-11 Thread Per Minborg
> This PR proposes to explicitly state that returned segments form the > `asSlice` and `reinterpret` method share memory regions with `this` memory > segment. > > Note: The term "subset" means a true subset or the same set. Per Minborg has updated the pull request incrementally with one

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Shaojin Wen
On Tue, 11 Jun 2024 11:35:28 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v4]

2024-06-11 Thread Shaojin Wen
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into > primitive arrays by combining values ​​into larger stores. > > This PR rewrites the code of appendNull and append(boolean) methods so that > these two methods can be optimized by C2. Shaojin Wen has updated the

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Pavel Rappo
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The

Re: RFR: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.

2024-06-11 Thread Jorn Vernee
On Tue, 11 Jun 2024 09:18:23 GMT, Per Minborg wrote: > If a segment is reinterpreted to be larger than this segment, then the extra > memory is not a part of this segment's backing part. Another way to think about this is: a segment's backing region can be larger or smaller than the bounds

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v3]

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 05:42:27 GMT, Shaojin Wen wrote: >> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into >> primitive arrays by combining values ​​into larger stores. >> >> This PR rewrites the code of appendNull and append(boolean) methods so that >> these two

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 09:39:29 GMT, Shaojin Wen wrote: >> @wenshao This is just an assembly dump. You need to have some profiling data >> that tells you where the time is spent. I'm not going to do the analysis >> work for you, I'm sorry. I gave you some pointers as how to do that. If you >>

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null

2024-06-11 Thread Shaojin Wen
On Tue, 11 Jun 2024 09:32:14 GMT, Emanuel Peter wrote: >> @eme64 The assembly information is below, can you take a look and see if it >> can help you diagnose the problem? >> >> * JavaCode >> >> class AbstractStringBuilder { >> private AbstractStringBuilder appendNull() { >> int

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null

2024-06-11 Thread Emanuel Peter
On Tue, 11 Jun 2024 09:17:00 GMT, Shaojin Wen wrote: >> @wenshao >>> @eme64 It seems that when the following code uses StringUTF16.putChar, C2's >>> optimization is not as good as the manual merging and storage effect. >> >> As I asked above, you will need to provide some evidence / generated

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null

2024-06-11 Thread Shaojin Wen
On Tue, 11 Jun 2024 06:27:13 GMT, Emanuel Peter wrote: >> @eme64 It seems that when the following code uses StringUTF16.putChar, C2's >> optimization is not as good as the manual merging and storage effect. >> >> class AbstractStringBuilder { >> private AbstractStringBuilder appendNull() {

Re: RFR: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.

2024-06-11 Thread Per Minborg
On Mon, 10 Jun 2024 15:45:07 GMT, Per Minborg wrote: > This PR proposes to explicitly state that returned segments form the > `asSlice` and `reinterpret` method share memory regions with `this` memory > segment. > > Note: The term "subset" means a true subset or the same set. > In my

Re: RFR: 8332249: Micro-optimize Method.hashCode [v2]

2024-06-11 Thread Aleksey Shipilev
On Mon, 3 Jun 2024 18:00:35 GMT, Sean Gwizdak wrote: >> Improve the speed of Method.hashCode by caching the hashcode on first use. >> I've seen an application where Method.hashCode is a hot path, and this is a >> fairly simple speedup. The memory overhead is low. >> >> This addresses issue

Re: RFR: 8333358: java/io/IO/IO.java test fails intermittently [v2]

2024-06-11 Thread Pavel Rappo
> Please review this fix for an intermittent test failure. > > On some configurations, the default `expect` timeout of 10 seconds is > insufficient. It is increased to 20; it's hard to imagine a configuration for > which that new value would still be insufficient, but we'll see. > > Aside from

Re: RFR: 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.

2024-06-11 Thread Brandon Kolesar
On Mon, 10 Jun 2024 17:11:17 GMT, Jorn Vernee wrote: > > The term 'subset' doesn't feel right to me here, since we're only talking > > about a single memory region (not a set of memory region**s**). I suggest > > 'sub-region' instead. > > Actually, nvm, that doesn't work for `reinterpret`

RFR: 8333962: Obsolete OldSize

2024-06-11 Thread Albert Mingkun Yang
Obsolete OldSize and related code. An internal variable `OldSize` is kept to capture the capacity of old-gen size. - Commit messages: - obsolete-old-size Changes: https://git.openjdk.org/jdk/pull/19647/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19647=00 Issue:

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null

2024-06-11 Thread Emanuel Peter
On Mon, 10 Jun 2024 23:10:05 GMT, Shaojin Wen wrote: >> @wenshao >>> I think the performance of the Unsafe branch may be the best data for the >>> C2 optimizer. @eme64 can help me see if C2 can do it? >> >> Have you tried to see if the optimization actually was done/taken? You can >> use the

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove double quotes > > src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties > line 285: >

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties >> line 409: >> >>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl >>> ein nicht bedingtes Muster als auch ein Standardlabel

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Mon, 10 Jun 2024 22:48:13 GMT, Damon Nguyen wrote: >> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java >> line 325: >> >>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"}, >>> 324: {"unknown", "unbekannt"}, >>> 325:

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Christian Stein
On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein wrote: >> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties >> line 66: >> >>> 64: label.size=Göße: >>> 65: label.source=: >>> 66: label.outputbins=Aächer: >> >> How confident are we in this ? >> google translate says