On Mon, 20 Mar 2023 11:15:52 GMT, Adam Sotona wrote:
> Classfile API class hierarchy makes assumptions when class is not resolved
> and that may lead to silent generation of invalid stack maps. Only
> debug-level log information of case is actually provided.
>
> Propos
On Tue, 21 Mar 2023 11:31:54 GMT, Alan Bateman wrote:
>> It seems to be redundant as the following code does not expect it on stack
>> and loads it again as needed.
>
> Yes, I think so. If `java -XX:+UnlockDiagnosticVMOptions
> -XX:+BytecodeVerificationLocal -version` doesn't fail and you've
On Tue, 21 Mar 2023 09:45:56 GMT, Jaikiran Pai wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update
>> src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyIm
is not resolved
> instead.
>
> Thanks for review.
>
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
avoid repeated ClassHierarchyInfo of CD_Object instantiation in
StaticClassHierarchyResolver
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
removed obso
On Mon, 20 Mar 2023 19:53:29 GMT, Alan Bateman wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed SystemModulesClassGenerator.moduleInfos comment
>
> src/jdk.jlink/share/classes/jd
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 223 comm
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed SystemModulesClass
On Mon, 20 Mar 2023 11:07:23 GMT, Adam Sotona wrote:
>> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
>> proper privileges, with tests.
>>
>> This addition is useful in case classes at runtime are not loaded from the
>> syst
is not resolved
> instead.
>
> Thanks for review.
>
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java
Co-
On Fri, 17 Mar 2023 17:30:41 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 220 commits:
>>
>> - Merge branch 'master' into JDK-8294972-jlink-plugins
&
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added default to thro
Classfile API class hierarchy makes assumptions when class is not resolved and
that may lead to silent generation of invalid stack maps. Only debug-level log
information of case is actually provided.
Proposed patch throws IllegalArgumentException when the class is not resolved
instead.
Thanks
On Fri, 17 Mar 2023 18:18:48 GMT, Chen Liang wrote:
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
> proper privileges, with tests.
>
> This addition is useful in case classes at runtime are not loaded from the
> system class loader, such as Proxy. This is also
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 220 comm
On Fri, 17 Mar 2023 16:06:53 GMT, Naoto Sato wrote:
>> I've reverted `IncludeLocalesPlugin` to previous version, plus minor fixes
>> and together with #13067 the `IncludeLocalesPluginTest` is passing.
>> Thank you.
>
> The fix to `IncludeLocalesPlugin` has been integrated. @asotona would you
>
On Wed, 15 Mar 2023 08:44:34 GMT, Adam Sotona wrote:
> Massive parallel execution of parametrised CorpusTest junit tests revealed
> race condition in
> `ClassHierarchyImpl.CachedClassHierarchyResolver::getClassInfo`.
>
> The race condition may skip calculation of the Cla
On Fri, 17 Mar 2023 05:49:45 GMT, Jaikiran Pai wrote:
>> Massive parallel execution of parametrised CorpusTest junit tests revealed
>> race condition in
>> `ClassHierarchyImpl.CachedClassHierarchyResolver::getClassInfo`.
>>
>> The race condition may skip calculation of the ClassHierarchyInfo.
On Thu, 16 Mar 2023 20:45:24 GMT, Naoto Sato wrote:
>> I further clarified with Naoto and I now understand the problem.The
>> plugin intends to transform `.class` that implements `LocaleDataMetaInfo` in
>> `jdk.localedata` module. It's a bug in the plugin `--include-locales=*`
>> which
On Thu, 16 Mar 2023 21:49:28 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remaining cleanup in SystemModulesPlugin
>
> src/jdk.jlink/share/classes/jd
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with three additional
commits since the last revision:
- SystemModulesPlugin:
On Wed, 15 Mar 2023 04:09:04 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>>
On Thu, 9 Mar 2023 14:41:47 GMT, Chen Liang wrote:
>> Isn't the "unrelated process such as generating lambda forms" critical for
>> the `ProxyGenerator` functionality?
>
> More accurately, I mean the overhead generated by this:
>
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last
On Wed, 15 Mar 2023 04:09:04 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>>
On Sat, 11 Mar 2023 13:45:23 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 196 commits:
>>
>> - Merge branch 'master' into JDK-8294961-proxy
>> - Merge br
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the la
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
remaining cleanup i
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
implementation of
On Wed, 15 Mar 2023 22:31:01 GMT, Mandy Chung wrote:
> What was the issue with the previous revision?
The only conversion bug I found during the code reformat/revision was missing
`className.replace('/', '.')` and after that the test pass.
On Thu, 16 Mar 2023 02:43:39 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed SystemModulesPlugin
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plu
On Tue, 14 Mar 2023 16:34:59 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - long lines wrapped
>> - StripJavaDebugAttributesPlugin transformation fixed
>>
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixe
On Tue, 14 Mar 2023 18:00:51 GMT, Mandy Chung wrote:
>> Right, I'll fix it, thanks.
>
> Looks like `LineNumberTable` is not stripped even with
> `Option.processLineNumbers(false)`.
Yes, I forgot to transform code elements, where
`Classfile.Option.processLineNumbers(false)` option is applied.
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed StripJavaDebugA
Massive parallel execution of parametrised CorpusTest junit tests revealed race
condition in `ClassHierarchyImpl.CachedClassHierarchyResolver::getClassInfo`.
The race condition may skip calculation of the ClassHierarchyInfo. In this
specific case it caused SegmentScope not being identified as
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
This pull request has now been i
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit si
On Fri, 10 Mar 2023 22:14:00 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 208 commits:
>>
>> - Merge branch 'master' into JDK-8294972-jlink-plugins
>>
On Mon, 13 Mar 2023 14:51:08 GMT, Alan Bateman wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 208 commits:
>>
>> - Merge branch 'master' into JDK-8294972-jlink-plugins
>>
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with three additional
commits since the last revision:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with five additional
commits si
On Mon, 13 Mar 2023 18:54:11 GMT, Adam Sotona wrote:
> jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised parallel
> junit tests
>
> The root cause seems to be thread-unsafe lazy initialisation of
> `TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArray
lized helper array with switch expression.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
throwing IllegalArgumentException instead of IllegalStateException
-
Changes:
On Mon, 13 Mar 2023 19:04:45 GMT, liach wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> throwing IllegalArgumentException instead of IllegalStateException
>
> src/java.base/share/
On Mon, 13 Mar 2023 19:18:26 GMT, Mandy Chung wrote:
>>> I see, I'll move the "packages magic" back from Classfile API to the
>>> `ModuleInfoWriter` and correct the API accordingly.
>>
>> I would need to check the history in the jake repo but I think it dates from
>> a prototype version of
On Mon, 13 Mar 2023 08:13:44 GMT, liach wrote:
> Without this patch, the Classfile API tries to encode PrimitiveClassDesc as
> CONSTANT_Class_info and error in `toInternalName`.
Looks good, thanks for catching and fixing it.
-
Marked as reviewed by asotona (Committer).
PR:
jdk/classfile/CorpusTest.java rarely fails in 1 of 6754 parametrised parallel
junit tests
The root cause seems to be thread-unsafe lazy initialisation of
`TypeKind.newarraycodeToTypeTag` in `TypeKind::fromNewArrayCode`. Provided
patch replaces that lazy-initialized helper array with switch
On Mon, 13 Mar 2023 14:18:55 GMT, Alan Bateman wrote:
>> Or another approach for the specific use cases might be to use
>> `Classfile::buildModule` with empty list of packages and then provide custom
>> `ModulePackagesAttribute` to the handler directly.
>
>> `Classfile::buildModule` is a
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 209 comm
On Tue, 29 Nov 2022 12:27:15 GMT, Adam Sotona wrote:
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to
> instrument classes
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
This pull request has now been i
On Mon, 13 Mar 2023 13:43:22 GMT, Adam Sotona wrote:
>> Maybe the variants of Classfile.buildModule need to be looked at again. For
>> the usage here, buildModule(ModuleAttribute, Consumer)
>> would be more useful as it would allow all of the additional attributes
On Sat, 11 Mar 2023 17:00:18 GMT, Alan Bateman wrote:
>> `buildModules` is expected to be called with additional packages but instead
>> it's called with all packages including all exported and open packages.
>>
>>
>> /**
>> * Build a module descriptor into a byte array.
>> *
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to
> instrument classes
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase.
On Thu, 15 Dec 2022 14:56:03 GMT, Adam Sotona wrote:
> 8294966: Convert jdk.jartool/sun.tools.jar.FingerPrint to use the ClassFile
> API to parse JAR entries
>
> Please review.
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 25e7ac22
Author:
On Fri, 10 Mar 2023 14:28:09 GMT, liach wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>&g
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit si
On Fri, 10 Mar 2023 12:58:25 GMT, Jan Lahoda wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 193 commits:
>>
>> - Merge branch 'master' into JDK-8294974-jshell
>> - Merge br
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to
> instrument classes
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit si
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 208 comm
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to
> instrument classes
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase.
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar
> entries
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull
On Thu, 9 Mar 2023 11:33:13 GMT, Adam Sotona wrote:
> jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset:
On Fri, 10 Mar 2023 09:16:03 GMT, Eirik Bjorsnos wrote:
> This PR seems to have broken `make docs`
It has been fixed by https://github.com/openjdk/jdk/pull/12957
-
PR: https://git.openjdk.org/jdk/pull/11367
On Thu, 9 Mar 2023 18:19:17 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> FingerPrint.maybeNestedClass set final
>
> src/jdk.jartool/share/classes/sun/tools
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar
> entries
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit si
> 8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to
> instrument classes
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase.
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull
On Thu, 9 Mar 2023 22:05:55 GMT, Uwe Schindler wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase.
On Thu, 9 Mar 2023 18:36:05 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment
On Thu, 9 Mar 2023 19:41:28 GMT, liach wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>&g
> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar
> entries
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull
On Thu, 9 Mar 2023 18:16:49 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 197 commits:
>>
>> - Merge branch 'master' into JDK-8294966-jartool
>> - Merge br
On Thu, 9 Mar 2023 22:38:32 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 207 commits:
>>
>> - Merge branch 'master' into JDK-8294972-jlink-plugins
>>
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 207 comm
> jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/jdk.jlink/sh
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit si
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Thu, 9 Mar 2023 11:33:13 GMT, Adam Sotona wrote
On Fri, 25 Nov 2022 14:35:22 GMT, Adam Sotona wrote:
> java.base java.lang.Module uses ASM to load module-info.class and this patch
> converts it to use Classfile API.
This pull request has now been integrated.
Changeset: 595645c7
Author: Adam Sotona
URL:
https://git.openj
jdk.jlink internal plugins are heavily using ASM
This patch converts ASM calls to Classfile API.
Please review.
Thanks,
Adam
-
Commit messages:
- Merge branch 'master' into JDK-8294972-jlink-plugins
- renamed variables in SystemModulesPlugin
- 8294972: jdk.jlink internal plugins
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
jdk.jlink jdk.tools.jimage.JImageTask is using ASM
On Tue, 7 Mar 2023 20:47:31 GMT, Mandy Chung wrote:
>> 8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar
>> entries
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> src/jdk.jartool/share/classes/sun/tools/jar/FingerPrint.java
8294966: jdk.jartool sun.tools.jar.FingerPrint uses ASM to parse class jar
entries
This patch converts it to use Classfile API.
Please review.
Thanks,
Adam
-
Commit messages:
- Merge branch 'master' into JDK-8294966-jartool
- FingerPrint fixes
- Update
8294974: jdk.jshell jdk.jshell.execution.LocalExecutionControl uses ASM to
instrument classes
This patch converts it to use Classfile API.
Please review.
Thanks,
Adam
-
Commit messages:
- Merge branch 'master' into JDK-8294974-jshell
- Merge branch 'JDK-8294982' into JDK-8294974
On Wed, 1 Mar 2023 01:19:24 GMT, Mandy Chung wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
>
On Fri, 25 Nov 2022 14:43:32 GMT, Alan Bateman wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
>
8294962: java.base jdk.internal.module package uses ASM to modify and write
module-info.class.
This patch converts it to use Classfile API.
Please review.
Thanks,
Adam
-
Commit messages:
- Merge branch 'master' into JDK-8294962-internal-module
- fixed
On Sun, 19 Feb 2023 05:23:20 GMT, liach wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
java.base java.lang.Module uses ASM to load module-info.class and this patch
converts it to use Classfile API.
-
Commit messages:
- Merge branch 'master' into JDK-8294959-module
- Merge branch 'JDK-8294982' into JDK-8294959
- removed obsolete javadoc from implementation classes
se review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 195 commits:
- Merge branch 'master' into JDK-8294961-proxy
- Merge branch 'JDK-8294982' into JDK-8294961
- removed obsolete javad
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK
se review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains seven additional commits since
the last revision:
On Tue, 7 Mar 2023 15:48:58 GMT, Maurizio Cimadamore
wrote:
>> This is common practise across the whole implementation. Do you suggest to
>> remove all similar javadoc from all implementation classes?
>
> Well, if the javadoc simply states the name of the class it doesn't seem very
> useful.
internal/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
removed obsolete
internal/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
minor fix i
On Tue, 7 Mar 2023 16:06:17 GMT, Paul Sandoz wrote:
>> `Long:numberOfLeadingZeros` implementation uses more method calls,
>> conditional statements and binary operations. I would prefer to stick with
>> the current implementation for its speed and simplicity.
>
> `numberOfLeadingZeros` is an
internal/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- Ent
internal/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 183 c
701 - 800 of 1034 matches
Mail list logo
