On Fri, 17 Nov 2023 11:28:23 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adding @implSpec for Gatherer.andThen, plus adds
On Wed, 15 Nov 2023 22:46:03 GMT, Jorn Vernee wrote:
> See the JBS issue for an extended problem description.
>
> This patch changes the specification and implementation of
> `MethodHandles::byteArrayViewVarHandle`,
> `MethodHandles::byteBufferViewVarHandle`, `ByteBuffer::alignedSlice`, and
>
On 15/11/2023 17:13, Rob Spoor wrote:
Hello all,
I'm working on a module that makes working with FFM easier; think of
something like JNA. For instance, it allows creating structures
without having to manually manage var handles etc.
My module uses restricted mehods like AddressLayout.withTar
On Wed, 15 Nov 2023 18:33:47 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>>
>> This change is p
On Wed, 15 Nov 2023 17:50:48 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improvements after feedback
Really nicely done.
On Tue, 14 Nov 2023 16:35:53 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unpacking the rethrown exceptions from Gatherers.
On Tue, 14 Nov 2023 17:25:42 GMT, Darragh Clarke wrote:
>> Currently the `IsAlive` test occasionally times out.
>>
>> This PR changes the timeout from `10` to `25` which I think is an adequate
>> increase based on the failures I've seen. Though I'd be happy to change it
>> to another value if
On Tue, 14 Nov 2023 16:41:31 GMT, Darragh Clarke wrote:
> Currently the `IsAlive` test occasionally times out.
>
> This PR changes the timeout from `10` to `25` which I think is an adequate
> increase based on the failures I've seen. Though I'd be happy to change it to
> another value if someo
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>> Thi
On Mon, 13 Nov 2023 15:37:29 GMT, Severin Gehwolf wrote:
> It's not clear what you mean by that. Dropped from what? The CSR? Something
> else? The run-image based link needs the `--add-run-image-resources` plugin
> for it to work.
I mean the list of plugins that are listed by --list-plugins. I
On Mon, 13 Nov 2023 21:59:05 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primar
On Mon, 13 Nov 2023 19:41:48 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote:
> That would probably also involve taking existing documentation such as the
> note about not opening entries with "."/"..", and the POSIX permissions
> mappings? Would it make sense to split the rest of the changes in this PR
> from
On Fri, 10 Nov 2023 16:30:35 GMT, suchismith1993 wrote:
> There is not generic way of generating this. It needs a manual intervention
> and symbols are to be added on a need basis in future. Looks like a list to
> be maintained. I had tried adding comments to explain the list, but that
> cause
On Wed, 18 Oct 2023 17:37:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>> Thi
On Wed, 4 Oct 2023 20:35:25 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additi
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore
wrote:
> This simplePR tweaks the factory which wraps custom cleanup actions passed to
> `MemorySegment::reinterpret`, so that any exception thrown by the custom
> cleanup is swallowed when the arena is closed.
>
> This aligns the behavior
On Fri, 10 Nov 2023 09:32:17 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Multiple improvements to Gatherer and Gatherers
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Thu, 9 Nov 2023 09:42:41 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherers.java line 326:
>>
>>> 324:
>>> 325: /**
>>> 326: * Gathers elements into fixed-size windows. The last window may
>>> contain
>>
>> Returns a ...
>
> You mean "Returns a Gath
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/Gatherer.java line 38:
> 36: /**
> 37: * An intermediate operation that transforms a stream of input elements
> into a
> 38
On Wed, 8 Nov 2023 16:03:22 GMT, Ryan Wallace wrote:
> Added and tested and it still works as expected.
@ryawalla Would it be possible to update the PR description so there's a clear
summary on the updated proposal? I think it aligns the behavior with what
happens when a bad file path is speci
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16535#pullrequestreview-1718248698
On Tue, 7 Nov 2023 15:45:02 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 addi
On Tue, 7 Nov 2023 12:29:12 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Si
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
On Tue, 7 Nov 2023 02:10:29 GMT, Erik Gahlin wrote:
> I filed an issue to investigate if there is a problem with SOE, or if the OOM
> check is really needed now. https://bugs.openjdk.org/browse/JDK-8319579
>
> Regardless of outcome, It would be good to document the results of the
> investigati
On Mon, 6 Nov 2023 22:52:50 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
On Mon, 6 Nov 2023 20:22:43 GMT, Mandy Chung wrote:
>> This is a regression caused by JDK-8302791. IAE should be thrown when an
>> interface is not visible to the given class loader but NPE is thrown instead
>> when the loader is null. The boot loader has no name and so the fix will
>> pri
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Can you confirm that debug builds are passing with -XX:+UseZGC now?
-
PR Comment: https://git.openjdk.org/jdk/pull/16535#issuecomment-1797889256
On Mon, 6 Nov 2023 19:12:28 GMT, Mandy Chung wrote:
> This is a regression caused by JDK-8302791. IAE should be thrown when an
> interface is not visible to the given class loader but NPE is thrown instead
> when the loader is null. The boot loader has no name and so the fix will
> print `
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private sta
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing file
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing file
On Fri, 3 Nov 2023 15:29:25 GMT, Jim Laskey wrote:
>> Update String Templates for a second preview. With the addition of
>>
>> - Expression type and throws are determined from the `process` method of the
>> processor type and not the processor type.
>>
>> - Qualified `STR` and `RAW` are treate
On Mon, 16 Oct 2023 14:31:46 GMT, Jim Laskey wrote:
> Wasn't sure about that. Thx.
When in doubt, JEP 12. Alex provided good guidance for API authors on how
`@since` should be used with preview APIs.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16202#discussion_r13823929
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This do
On Fri, 3 Nov 2023 05:43:38 GMT, David Holmes wrote:
> I don't understand what this is trying to do. If any virtual thread has an
> uncaught exception then other virtual threads will throw it wrapped in a
> RuntimeException. But the first virtual thread that completes (normally or by
> throwin
On Thu, 2 Nov 2023 17:53:12 GMT, Jim Laskey wrote:
> I thought it was a clearer way to get rid of the side effect.
It means LauncherHelper.checkAndLoadMain description will need to be updated as
it says that it checks the public static void main method. But okay, I'll go
through what you have
On Thu, 2 Nov 2023 15:45:03 GMT, Jim Laskey wrote:
> Amazingly enough I seem to have the JNI straight on the first try.
Oh, I wasn't expecting that. My comment was suggesting we change
LauncherHelper.checkAndLoadMain to set both appClass and mainType after the
validate succeeds.
-
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Si
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Si
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote:
>> This change fixes two errors in inline HTML styles in the `java.lang`
>> package:
>>
>> - wrong CSS property name in `java.lang.String`
>> - CSS declaration terminated by colon instead of semicolon in
>> `java.lang.Thread`
>>
>>
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Si
On Tue, 31 Oct 2023 20:45:11 GMT, Calvin Cheung wrote:
> Do you prefer the `canArchive` setting be inside `if
> (CDS.isDumpingStaticArchive())` like the following?
>
> ```
> if (CDS.isDumpingStaticArchive())
> canArchive = true;
> ```
That's fine. It has been harmless to have canAr
On Wed, 1 Nov 2023 04:34:35 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
jdk_vector_sanity was added by JDK-8295970 to get some coverage in tier1. That
motivat
On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona wrote:
> JImageValidator has been recently converted to use ClassFile API and original
> weak validation of class files was replaced with full class verification.
> Unfortunately full class verification is too strong as it includes class
> assignabi
On Mon, 16 Oct 2023 16:31:04 GMT, Brian Burkhalter wrote:
> The CSR was created.
Thanks. I changed the "Compatibility Risk" to medium and expanded its
description to more clearly explain the compatibility risk to fix this long
standing issue.
-
PR Comment: https://git.openjdk.org
On Mon, 30 Oct 2023 15:07:49 GMT, Viktor Klang wrote:
>> Discussed with @DougLea and adjusting the queue capacity to at least the
>> number of participating threads seems like the most sensible fix.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since t
On Tue, 31 Oct 2023 06:17:34 GMT, Calvin Cheung wrote:
> I've added the following field in `ArchivedModuleGraph` so that the
> `get(String mainModuleName)` will check the `mainModule` before returning
> `archivedModuleGraph`. `private static String mainModule;` The `mainModule`
> field is also
On Tue, 31 Oct 2023 06:11:50 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Mon, 30 Oct 2023 17:16:54 GMT, Andrew Haley wrote:
>> The bug here is a thinko in `ScopedValue.scopedValueBindings()`.
>>
>> If the JVM runs out of resources, we throw a `VirtualMachineError`. Running
>> out of resources can happen at almost any time, and can happen while
>> `ScopedValue`'s
On Fri, 1 Sep 2023 08:29:41 GMT, Alan Bateman wrote:
>> I think you may have missed the comment in the JBS issue. Logging means
>> running potentially arbitrary code, doing this at Runtime.halt time is
>> problematic. I thought the conclusion from the work on Runtime.exit was
On Mon, 30 Oct 2023 15:57:23 GMT, Andrew Haley wrote:
> The bug here is a thinko in `ScopedValue.scopedValueBindings()`.
>
> If the JVM runs out of resources, we throw a `VirtualMachineError`. Running
> out of resources can happen at almost any time, and can happen while
> `ScopedValue`'s inte
On Fri, 27 Oct 2023 19:03:36 GMT, Calvin Cheung wrote:
> The `ArchivedModuleGraph.java` wasn't changed. So if `-m` is not specified,
> the `archivedModuleGraph` is non-null; if `-m` is specified, the
> `archivedModuleGraph` is null. So running `java -version`, the
> archivedModuleGraph is non-
On Fri, 27 Oct 2023 16:23:04 GMT, Calvin Cheung wrote:
> I reran the script you sent me few days ago and got the expected results with
> the latest changes. The checking of the main module name matches between dump
> time and runtime is performed in the VM code. If an archive (even the default
On Thu, 26 Oct 2023 21:08:07 GMT, Calvin Cheung wrote:
> I've pushed another update with the following changes:
>
> * in the VM code, skip archiving full module graph if there's an incubator
> module by checking if the ArchivedBootLayer::archivedBootLayer is available;
I think we still have th
On Sat, 22 Jul 2023 04:44:21 GMT, Stuart Marks wrote:
>> See https://bugs.java.com/bugdatabase/view_bug?bug_id=8305734 and
>> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8311905
>
> Hi, thanks for the background and the discussion of the alternatives. I'm not
> sure that drafting the
On Tue, 26 Sep 2023 14:57:58 GMT, Alan Bateman wrote:
>> Fixes the issue (hopefully) by resolving automatic modules and automatic
>> module dependencies after propagation of non-automatic transitive
>> dependencies. The module tests run.
>>
>> I also added a fe
On Wed, 25 Oct 2023 11:16:54 GMT, Jorn Vernee wrote:
>> The result of `FindClass` is a local JNI handle (in
>> `find_class_from_class_loader`, called from `jni_FindClass` [1]). As such,
>> we need to wrap the return value of `FindClass` in a global reference when
>> storing it inside fallbackL
On Wed, 25 Oct 2023 21:08:01 GMT, Leonid Mesnik wrote:
> The jtreg starts the main thread in a separate ThreadGroup and checks
> unhandled exceptions for this group. However, it doesn't catch all unhandled
> exceptions. There is a jtreg issue for this
> https://bugs.openjdk.org/browse/CODETOOL
On Tue, 24 Oct 2023 17:01:35 GMT, Jorn Vernee wrote:
> The result of `FindClass` is a local JNI handle (in
> `find_class_from_class_loader`, called from `jni_FindClass` [1]). As such, we
> need to wrap the return value of `FindClass` in a global reference when
> storing it inside fallbackLinke
On Mon, 23 Oct 2023 15:28:31 GMT, Viktor Klang wrote:
> Resolves a visibility issue in SubmissionPublisher by making the `waiter`
> member of BufferedSubscription *volatile*.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16313#pullrequestrev
On Mon, 23 Oct 2023 18:26:51 GMT, Raffaello Giulietti
wrote:
>> Please review this simple fix to restore the original exception message that
>> existed before [16050](https://github.com/openjdk/jdk/pull/16050).
>
> Raffaello Giulietti has updated the pull request incrementally with one
> addit
On Sat, 21 Oct 2023 10:56:01 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work, t
On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Sat, 21 Oct 2023 00:56:21 GMT, Joe Darcy wrote:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
The wording looks okay to me and I expect it will appear as an API note in
BigInteger.
However, for BigDecimal I suspect the h2 headings (for the next h
On Fri, 20 Oct 2023 20:24:26 GMT, Calvin Cheung wrote:
> I tried the above but got the following build error:
>
> ```
> Optimizing the exploded image
> Error occurred during initialization of boot layer
> java.lang.NullPointerException
> ExplodedImageOptimize.gmk:39: recipe for target
> '/scrat
On Sat, 21 Oct 2023 07:42:06 GMT, Alan Bateman wrote:
>>> Yes, because of the following code further up in the same method:
>>
>> I think what you are actually doing here is supporting archiving of the boot
>> layer when the main module transitively depends on an inc
On Sat, 21 Oct 2023 06:54:16 GMT, Alan Bateman wrote:
> > Yes, because of the following code further up in the same method:
>
> I think what you are actually doing here is supporting archiving of the boot
> layer when the main module transitively depends on an incubator modu
On Fri, 20 Oct 2023 20:22:31 GMT, Calvin Cheung wrote:
> Yes, because of the following code further up in the same method:
I think what you are actually doing here is supporting archiving of the boot
layer when the main module transitively depends on an incubator module. We
might have to add m
On Wed, 18 Oct 2023 15:59:13 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work, t
On Fri, 20 Oct 2023 13:35:59 GMT, Jorn Vernee wrote:
> Port over stylistic changes from the panama-foreign repo. The following PRs
> are included:
>
> - https://github.com/openjdk/panama-foreign/pull/863
> - https://github.com/openjdk/panama-foreign/pull/888
> - https://github.com/openjdk/panam
On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Thu, 19 Oct 2023 15:21:55 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Fri, 20 Oct 2023 13:59:16 GMT, Maurizio Cimadamore
wrote:
> This simple PR removes the extra verbiage from the javadoc of all the
> restricted methods.
> Since now javadoc will automatically generate better "bubbles" for restricted
> methods, this wording is no longer necessary.
Marked as
On 19/10/2023 14:12, Severin Gehwolf wrote:
Hi,
Could I please get some reviews on the CSR for a feature that would
allow runtime image-based jlinks (no need for the packaged modules -
jmods folder - being present)?
https://bugs.openjdk.org/browse/JDK-8317420
It would be particularly helpful t
On Thu, 19 Oct 2023 07:04:50 GMT, Chen Liang wrote:
> NoRepl means "no replication", which is not what these APIs are for.
I assume it's "no replace", meaning it reports the error rather than use the
coder's replacement value.
I agree it could be renamed but I think look at CodingErrorAction
On Wed, 18 Oct 2023 16:27:58 GMT, Roger Riggs wrote:
> The new usages that are driving this change would be better served by a
> method dedicated to creating latin1 strings from a caller provided byte
> array. The JavaLangAccess shared secret interface is already overused, but it
> is cleaner,
On 18/10/2023 15:55, Nandagiri, Ramadasu (NSDi) wrote:
Hi,
Please see the discussion in the following mails. One of the TCK test
cases, api/java_net/MulticastSocket/ClassLevel.html is failing on
NonStop platform as NonStop doesn't support IP_MULTICAST_ALL option.
We would like this test case
On Wed, 18 Oct 2023 10:09:29 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote:
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
> the main
On Thu, 5 Oct 2023 16:18:57 GMT, Ioi Lam wrote:
> Maybe we can add a new native method
> `jdk.internal.misc.CDS.isBuiltinModule(Module m)` which tests if
> `ModuleEntry::_location` starts with `"jrt:"`?
There isn't any really notion of "built-in module", they may be modules in the
run-time im
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote:
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
> the main
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote:
>> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to
>> use try...catch to handle CharacterCodingException and throw
>> IllegalArgumentException instead of CharacterCodingException to make the
>> calling code cleane
On Tue, 17 Oct 2023 03:09:09 GMT, Chen Liang wrote:
> The thrown CCE was intended for `Files.readString` and `Files.writeString`,
> and is in reality, only used by those 2 sites. However, you missed updating
> those sites, so they now throw IAE instead of CCE, which should be fixed.
Right, the
On Mon, 16 Oct 2023 13:41:55 GMT, Jim Laskey wrote:
> Update String Templates for a second preview. With the addition of
>
> - Expression type and throws are determined from the `process` method of the
> processor type and not the processor type.
>
> - Qualified `STR` and `RAW` are treated the
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote:
> The open nroff manpage files are out of sync with their closed markdown
> sources and need to be refreshed.
>
> The changes to apply are coming from:
>
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor
> to ea
On Fri, 13 Oct 2023 03:23:04 GMT, xpbob wrote:
> Big data processes often experience situations where the direct memory oom
> process is alive but not serving properly. If the direct memory is oom, code
> can notify the jvm. Can bring the following benefits:
> 1. Analysis of direct memory Java.
On Thu, 12 Oct 2023 14:16:55 GMT, Matthias Baesken wrote:
>> There are a few remaining places in java.base where the return value
>> NULL-check of malloc is missing. This should better be adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sinc
On Thu, 12 Oct 2023 12:17:27 GMT, Matthias Baesken wrote:
>> There are a few remaining places in java.base where the return value
>> NULL-check of malloc is missing. This should better be adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sinc
On Wed, 11 Oct 2023 13:07:08 GMT, Doug Lea wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>> addr
701 - 800 of 2032 matches
Mail list logo
