jdk) repository.
>
> The commit being backported was authored by Jaikiran Pai on 26 Jun 2023 and
> was reviewed by Alan Bateman.
>
> Thanks!
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/62#pullrequestreview-1498136891
On Mon, 26 Jun 2023 05:58:41 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which fixes a javadoc issue
> reported in https://bugs.openjdk.org/browse/JDK-8310868?
>
> I ran `make docs-image` locally with this change and the link is now
> correctly rendered in the
On Sun, 25 Jun 2023 12:20:14 GMT, 温绍锦 wrote:
>> @wenshao The patch has changed 19 times in the last 3 days, is it ready for
>> review now?
>
> @AlanBateman i have modified according to liach's suggestion, it's ready for
> review also.
> @wenshao I don't think this is feasible, for this uses a
On Fri, 23 Jun 2023 04:52:16 GMT, 温绍锦 wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> remove unused import
>
> Latest benchmark results (commit id
>
On Fri, 23 Jun 2023 16:30:15 GMT, Brian Burkhalter wrote:
> Add `package-info.java` for package `jdk.nio.mapmode`.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14628#pullrequestreview-1496355363
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt
On Fri, 23 Jun 2023 15:38:52 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/nio/X-Buffer.java.template line 484:
>>
>>> 482: * @throws ReadOnlyBufferException if target is a read only buffer,
>>> 483: * even if it is empty
>>> 484: * @since 1.5
>>
>> It
On Fri, 23 Jun 2023 09:37:47 GMT, Christian Stein wrote:
>> Please review this update to `java`'s help output for `--module-path`/`-p`.
>>
>> This PR also updates the output for the closely related
>> `--upgrade-module-path` option.
>>
>> Thanks in advance!
>
> Christian Stein has updated the
On Thu, 22 Jun 2023 22:52:23 GMT, Brian Burkhalter wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified
>> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional
On Thu, 22 Jun 2023 10:45:02 GMT, Alan Bateman wrote:
> 8309853: StructuredTaskScope.join description improvements
This pull request has now been integrated.
Changeset: e86d765b
Author: Alan Bateman
URL:
https://git.openjdk.org/jdk21/commit/e86d765b229d6cc2270dcc90b40252851e50c
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
src/java.sql/share/classes/java/sql/DriverManager.java line 658:
> 656: * (which is invoking this
On Wed, 21 Jun 2023 17:25:19 GMT, Joe Darcy wrote:
>> This method has an existing apiNote and implSpec. I suspect Joe meant to add
>> this sentence to the apiNote, not the implSpec.
>
> I did mean to add the cross-reference to Objects.toIdentityString to the
> implSpec section since earlier in
On Tue, 20 Jun 2023 17:13:26 GMT, Joe Darcy wrote:
> I had occasion to read over the javadoc sources in java.lang.Object recently
> and noticed a few items that could be updated.
>
> There are some new or expanded API notes referring to methods in
> java.util.Objects. I added these references
On Thu, 22 Jun 2023 00:33:33 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull
8309853: StructuredTaskScope.join description improvements
-
Commit messages:
- Backport 3661cdee1b20ab2868025637871d22bb30add6bd
Changes: https://git.openjdk.org/jdk21/pull/55/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21=55=00
Issue:
On Wed, 21 Jun 2023 15:48:30 GMT, Alan Bateman wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static
On Thu, 22 Jun 2023 00:13:06 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote:
> StructuredTaskScope's class description introduces the join method as waiting
> for all subtasks to finish but the API docs for join/joinUntil are phrased in
> terms of waiting for all threads to finish. ShutdownOnXXX join/
On Wed, 21 Jun 2023 16:59:22 GMT, Stuart Marks wrote:
> Are we using a convention of `implRead` or `readImpl`? Either is ok with me,
> but I think we had been using `readImpl` and similar elsewhere.
This code is already using implXXX so it's just be consistent.
-
PR Review
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static
On Wed, 21 Jun 2023 11:49:54 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/lang/Object.java line 260:
>>
>>> 258: * }
>>> 259: * The {@link java.util.Objects#toIdentityString(Object)
>>> 260: * Objects.toIdentityString} method returns the string for an
>>
>> That
On Wed, 21 Jun 2023 00:00:54 GMT, Joe Darcy wrote:
> Correct misstatement that the Class object for a primitive type can only be
> be access via fields like java.lang.Integer.TYPE.
src/java.base/share/classes/java/lang/Class.java line 823:
> 821: *
> 822: * @apiNote
> 823: *
On Tue, 20 Jun 2023 17:45:03 GMT, Mandy Chung wrote:
> Binary name is a long-standing behavior. It's a spec bug.
Yes, I view this PR as just specifying long standing behavior. The name used
for array class may be surprising but I don't think it can be changed.
-
PR Review
On Wed, 21 Jun 2023 07:28:54 GMT, 温绍锦 wrote:
> By optimizing the implementation of java.lang.Long#fastUUID, the performance
> of the java.util.UUID#toString method can be significantly improved.
>
> The following are the test results of JMH:
>
> Benchmark Mode Cnt
On Tue, 20 Jun 2023 19:15:35 GMT, Mandy Chung wrote:
>> Compact profiles are defined in Java SE 8 and are legacy in Java SE 9. jdeps
>> -profile option was deprecated for removal in JDK 21. This option can be
>> removed in JDK 22. Customers can use jdeps to find the set of modules
>> required
On Tue, 20 Jun 2023 13:54:15 GMT, Christian Stein wrote:
> Please review this update to `java`'s help output for `--module-path`/`-p`.
>
> This PR also updates the output for the closely related
> `--upgrade-module-path` option.
>
> Thanks in advance!
On Tue, 20 Jun 2023 00:57:46 GMT, Sean Mullan wrote:
> > Maybe you are thinking about the size of libsunec or non-technical issues
> > that meant it wasn't included by some distributions? There weren't an issue
> > with deciding which providers to include to java.base. I think the
> >
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor out security code to helper class
>> - Print aliases. Order Provider type/ser
On Mon, 19 Jun 2023 07:06:00 GMT, Axel Boldt-Christmas
wrote:
> > Hmmm... hopefully `vm.gc.ZSingelgen` is really `vm.gc.ZSinglegen`. If so
> > you might want to fix the PR description.
>
> What part are you worried about? When would `vm.gc.ZSingelgen` be invalid?
>
> Also what part of the PR
On Mon, 19 Jun 2023 05:46:34 GMT, Anthony Scarpino
wrote:
> From what I was told, the native library was one of the reasons it was not in
> the base pkg before modularization and just remained so afterwards.
Maybe you are thinking about the size of libsunec or non-technical issues that
meant
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote:
>> This PR clarifies the spec of the 3-arg Class::forName regarding the format
>> of the name for an array type which is of the form: one or more of "[" +
>> binary name of the element type + ";'.
>
> Mandy Chung has updated the pull
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino
wrote:
> This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has
> always been separate from the base module/pkg because of its dependence on a
> native library. That library was removed in JDK 16.
The proposed changes
On Fri, 16 Jun 2023 20:32:23 GMT, Weijun Wang wrote:
>> Hi,
>>
>> I need a code review for moving the contents of the jdk.crypto.ec module
>> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
>> java.base. EC has always been separate from the base module/pkg because of
On Thu, 15 Jun 2023 11:45:04 GMT, Andrew Haley wrote:
>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>>
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
>> error occurs it can not recover scoped values.
>>
>> Moving `runWith()` into the common
On Fri, 16 Jun 2023 11:54:52 GMT, Matthias Baesken wrote:
> Hi Alan, I adjusted / simplified the coding.
Thanks for taking the suggestion.
-
PR Comment: https://git.openjdk.org/jdk/pull/14515#issuecomment-1594595016
On Fri, 16 Jun 2023 11:59:39 GMT, Matthias Baesken wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>>
>>
On Fri, 16 Jun 2023 10:44:47 GMT, Matthias Baesken wrote:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output :
>
> java.lang.RuntimeException:
On Mon, 12 Jun 2023 05:03:28 GMT, Alan Bateman wrote:
>> Oliver Kopp has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five addi
On Fri, 16 Jun 2023 11:09:23 GMT, Sean Coffey wrote:
> Logged https://bugs.openjdk.org/browse/JDK-8310201 to track the Locale
> changes Alan.
Thanks, probably should treat this as a bug for JDK 21 so that a new addition
doesn't change behavior between 21 and 22.
-
PR Review
On Fri, 16 Jun 2023 11:14:38 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> -
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote:
> Thread.sleep has had quite a bit of churn recently to support virtual
> threads, add sleep(Duration), a JFR event, and the change the underlying
> implementation to support sub-millis precision. I think the changes have
> sett
On Thu, 15 Jun 2023 11:11:18 GMT, Andrew Haley wrote:
>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>>
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
>> error occurs it can not recover scoped values.
>>
>> Moving `runWith()` into the common
R event around
> the sleep, this avoids duplicate code in the 3 sleep methods.
> 2. Rename JVM_Sleep to JVM_SleepNanos to make it clear that it takes the
> sleep time in nanoseconds, esp. when Thread.sleep's parameter is milliseconds.
Alan Bateman has updated the pull request w
On Thu, 15 Jun 2023 02:38:08 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>>
On Thu, 15 Jun 2023 02:38:08 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>>
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 5 Jun 2023 19:44:35 GMT, Alan Bateman wrote:
> > I think we need to delay this until
> > [JDK-8309361](https://bugs.openjdk.org/browse/JDK-8309361) is resolved, in
> > case we would like to revert
> > [JDK-8305092](https://bugs.openjdk.org/browse/JDK-8305
On Thu, 15 Jun 2023 06:29:09 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.b
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 13 Jun 2023 17:57:36 GMT, Naoto Sato wrote:
> Replaced it with a ReentrantLock
The concern is that this is a system-wide lock and so creates the potential for
contention when many threads are bashing on Locale.of and other methods. Moving
to use the JDK's ReferenceKeyMap with a CHM,
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> -
On Wed, 14 Jun 2023 02:13:23 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>>
StructuredTaskScope's class description introduces the join method as waiting
for all subtasks to finish but the API docs for join/joinUntil are phrased in
terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil
inherit this description but would be clearer if their description
On Tue, 13 Jun 2023 15:53:07 GMT, Andrew Haley wrote:
>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>>
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
>> error occurs it can not recover scoped values.
>>
>> Moving `runWith()` into the common
On Mon, 12 Jun 2023 17:33:11 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
On Mon, 12 Jun 2023 11:30:19 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which moves the tests from
> under `test/jdk/sun/misc/URLClassPath` to
> `test/jdk/jdk/internal/loader/URLClassPath`? This addresses
> https://bugs.openjdk.org/browse/JDK-8309763.
>
>
On Mon, 12 Jun 2023 14:09:59 GMT, Andrew Haley wrote:
>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>>
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
>> error occurs it can not recover scoped values.
>>
>> Moving `runWith()` into the common
On Sun, 11 Jun 2023 21:01:54 GMT, Oliver Kopp wrote:
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split
On Sat, 10 Jun 2023 06:44:56 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>>
>> When an application is launched, the `app` classloader internally uses a
>>
On Sat, 10 Jun 2023 13:40:30 GMT, Jaikiran Pai wrote:
> When I started looking into this issue, I was curious why this wasn't
> reported in Java 8 since the reporter was merely switching Java version from
> 8 to a newer version. When I look into Java 8 code, I see that the
>
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
There is a lot of output and does seem to overwhelm the java -XshowSettings
output with detail that I wouldn't expect by
On Sat, 10 Jun 2023 05:16:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>>
>> When an application is launched, the `app` classloader internally uses a
>>
On Fri, 9 Jun 2023 16:53:15 GMT, Andrew Haley wrote:
> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>
> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM
> error occurs it can not recover scoped values.
>
> Moving `runWith()` into the common subclass
On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang wrote:
>> The test used a too-small heap for generic testing, and coupled with looking
>> at `freeMemory()` it led to a less-than-ideal determinism of execution of
>> the test.
>
> Viktor Klang has updated the pull request incrementally with one
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>>
>> When an application is launched, the `app` classloader internally uses a
>>
On Fri, 9 Jun 2023 14:55:50 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8308184?
>
> When an application is launched, the `app` classloader internally uses a
>
On Fri, 9 Jun 2023 13:39:26 GMT, Matthias Baesken wrote:
> On AIX , new jtreg test
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java always failed with
> the output :
>
> --System.err:(294/28579)--
> STARTED DynamicLoadWarningTest::testLoadJavaAgent
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
If I read the existing code correctly, ClassCache::get can't return null. If
there are two
On Thu, 8 Jun 2023 18:56:28 GMT, Mandy Chung wrote:
> The `RuntimeArguments` test verifies the VM arguments returned by
> `jdk.internal.misc.VM::getRuntimeArguments` as expected.This test fails
> when running with GraalVM as it was created with `jlink --add-options` and
> the application
This test moved from test/jdk/jdk/incubator/concurrent to test/jdk/java/lang as
part of the JEP 446 integration so it is running in a lot more configurations
now. It's unstable in some configurations, including
JTREG_TEST_THREAD_FACTORY=Virtual runs. The implementation may need more
On Wed, 7 Jun 2023 15:12:40 GMT, Alan Bateman wrote:
> Thread.interrupted is used to "get and clear" the current thread's interrupt
> status. When called from a virtual thread, the current implementation always
> clears the carrier's interrupt status. There is no n
On Thu, 8 Jun 2023 15:08:28 GMT, Claes Redestad wrote:
> https://bugs.openjdk.org/browse/JDK-8301958 and later changes improved
> Arrays.copyOf/-Range methods to improve peak performance in microbenchmarks
> when copying the entire array, but it's resulted in a few lurking footprint
>
On Thu, 1 Jun 2023 06:40:04 GMT, Alan Bateman wrote:
> Thread.countStackFrames is/was an ill-defined method that dates from JDK 1.0
> for counting the stack frames of a suspended Thread. The method was
> deprecated in JDK 1.2 (1998), deprecated for removal in Java 9, and
>
On Thu, 8 Jun 2023 16:46:55 GMT, Mandy Chung wrote:
>> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has
>> been reported. Those issues were related with exception being thrown with
>> invalid arguments. We propose to remove the old core reflection
>>
Central found
> only 1 usages to this method. The 1 usage appears to be a class that just
> wraps all methods, it doesn't actually make use of it.
Alan Bateman has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated cha
On Thu, 8 Jun 2023 11:27:37 GMT, Pavel Rappo wrote:
> If we were to (re-)structure doc comments in the way you propose, I'd suggest
> we do it in a separate, non-jdk.javadoc PR. I was simply trying to keep JDK
> API documentation unchanged.
Understood, it was just a passing comment that
On Thu, 8 Jun 2023 00:37:07 GMT, Joe Darcy wrote:
>> Time to get JDK 22 underway...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 39 commits:
>
> - Merge branch 'master' into JDK-8306584
> - Merge branch 'master'
Central found
> only 1 usages to this method. The 1 usage appears to be a class that just
> wraps all methods, it doesn't actually make use of it.
Alan Bateman has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated cha
On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Thu, 8 Jun 2023 09:55:27 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
Thread.interrupted is used to "get and clear" the current thread's interrupt
status. When called from a virtual thread, the current implementation always
clears the carrier's interrupt status. There is no need to do this when the
interrupt status is not set, it can just read the interrupt
On Thu, 8 Jun 2023 00:37:07 GMT, Joe Darcy wrote:
>> Time to get JDK 22 underway...
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 39 commits:
>
> - Merge branch 'master' into JDK-8306584
> - Merge branch 'master'
On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung wrote:
>> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has
>> been reported. Those issues were related with exception being thrown with
>> invalid arguments. We propose to remove the old core reflection
>>
On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung wrote:
>> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has
>> been reported. Those issues were related with exception being thrown with
>> invalid arguments. We propose to remove the old core reflection
>>
On Thu, 8 Jun 2023 04:00:31 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request with a new target
On Thu, 8 Jun 2023 04:00:31 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request with a new target
On Wed, 7 Jun 2023 16:06:54 GMT, Mandy Chung wrote:
> `FieldSetAccessibleTest` attempts to load all JDK classes and test
> `setAccessible` on their public fields to work properly. It should filter
> the modules that directly and indirectly depend on `jdk.internal.vm.compiler`
> and
On Wed, 7 Jun 2023 12:09:33 GMT, Alan Bateman wrote:
>> Nagata-Haruhito has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refer review comment
>
> src/java.base/share/classes/java/io/F
On Wed, 7 Jun 2023 17:16:50 GMT, Mandy Chung wrote:
>> test/jdk/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java line
>> 314:
>>
>>> 312: });
>>> 313:
>>> 314: Set deployModules = Set.of("javafx.deploy",
>>> "jdk.deploy", "jdk.plugin", "jdk.javaws");
>>
On Wed, 7 Jun 2023 16:06:54 GMT, Mandy Chung wrote:
> `FieldSetAccessibleTest` attempts to load all JDK classes and test
> `setAccessible` on their public fields to work properly. It should filter
> the modules that directly and indirectly depend on `jdk.internal.vm.compiler`
> and
On Wed, 7 Jun 2023 11:55:57 GMT, Daniel Jeliński wrote:
> That being said, the number of long-lived `BaseLocale` objects is very
> limited; we only keep them in Locale, LocaleKey, and Locale.CONSTANT_LOCALES.
> Unless I'm missing something, we could solve this problem by removing
>
On Wed, 7 Jun 2023 03:37:26 GMT, SUN Guoyun wrote:
>> command: make test CONF=fastdebug JTREG="VM_OPTIONS=-Xcomp"
>> TEST=gc/TestAllocHumongousFragment.java
>> error info:
>>
>> Caused by: java.lang.NullPointerException: Cannot invoke
>> "sun.util.locale.BaseLocale.getVariant()" because
On Wed, 7 Jun 2023 08:16:19 GMT, Nagata-Haruhito wrote:
>> I fixed File.listRoots description.
>> * remove "the insertion or ejection of removable media"
>> * change "available" to "existing"
>>
>> Please review this change.
>
> Nagata-Haruhito has updated the pull request incrementally with
On Thu, 11 May 2023 13:08:55 GMT, Alan Bateman wrote:
> This is the implementation of:
>
> - JEP 453: Structured Concurrency (Preview)
> - JEP 446: Scoped Values (Preview)
>
> For the most part, this is just moving code and tests. StructuredTaskScope
> moves to j.u.co
On Tue, 6 Jun 2023 17:15:32 GMT, Joe Darcy wrote:
>> Document existing behavior.
>>
>> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8309415
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the
On Mon, 5 Jun 2023 19:33:48 GMT, Mandy Chung wrote:
> Lookup.findSpecial fails on Object method call from an interface because of a
> bug in the implementation calling `Class::getSuperclass` on an interface
> which has no superclass. The implementation should only search the method
> from
901 - 1000 of 2040 matches
Mail list logo
